dls-dodal 1.69.0__py3-none-any.whl → 2.0.0__py3-none-any.whl

dodal/beamlines/i19_2.py

@@ -1,26 +1,30 @@
+from functools import cache
 from pathlib import Path
 
+from ophyd_async.core import PathProvider
 from ophyd_async.fastcs.eiger import EigerDetector
 from ophyd_async.fastcs.panda import HDFPanda
 
-from dodal.common.beamlines.beamline_utils import (
-    device_factory,
-    get_path_provider,
-    set_path_provider,
-)
 from dodal.common.beamlines.beamline_utils import (
     set_beamline as set_utils_beamline,
 )
 from dodal.common.visit import StaticVisitPathProvider
-from dodal.devices.i19.access_controlled.attenuator_motor_squad import (
+from dodal.device_manager import DeviceManager
+from dodal.devices.beamlines.i19.access_controlled.attenuator_motor_squad import (
     AttenuatorMotorSquad,
 )
-from dodal.devices.i19.access_controlled.blueapi_device import HutchState
-from dodal.devices.i19.access_controlled.shutter import AccessControlledShutter
-from dodal.devices.i19.backlight import BacklightPosition
-from dodal.devices.i19.beamstop import BeamStop
-from dodal.devices.i19.diffractometer import FourCircleDiffractometer
-from dodal.devices.i19.pin_col_stages import PinholeCollimatorControl
+from dodal.devices.beamlines.i19.access_controlled.blueapi_device import HutchState
+from dodal.devices.beamlines.i19.access_controlled.piezo_control import (
+    AccessControlledPiezoActuator,
+    FocusingMirrorName,
+)
+from dodal.devices.beamlines.i19.access_controlled.shutter import (
+    AccessControlledShutter,
+)
+from dodal.devices.beamlines.i19.backlight import BacklightPosition
+from dodal.devices.beamlines.i19.beamstop import BeamStop
+from dodal.devices.beamlines.i19.diffractometer import FourCircleDiffractometer
+from dodal.devices.beamlines.i19.pin_col_stages import PinholeCollimatorControl
 from dodal.devices.synchrotron import Synchrotron
 from dodal.devices.zebra.zebra import Zebra
 from dodal.devices.zebra.zebra_constants_mapping import (
@@ -39,13 +43,6 @@ PREFIX = BeamlinePrefix("i19", "I")
 set_log_beamline(BL)
 set_utils_beamline(BL)
 
-set_path_provider(
-    StaticVisitPathProvider(
-        BL,
-        Path("/dls/i19-2/data/2025/cm40639-4/"),
-    )
-)
-
 I19_2_COMMISSIONING_INSTR_SESSION: str = "cm40639-5"
 
 I19_2_ZEBRA_MAPPING = ZebraMapping(
@@ -53,67 +50,66 @@ I19_2_ZEBRA_MAPPING = ZebraMapping(
     sources=ZebraSources(),
 )
 
+devices = DeviceManager()
+
 
-@device_factory()
+@devices.fixture
+@cache
+def path_provider() -> PathProvider:
+    return StaticVisitPathProvider(
+        BL,
+        Path("/dls/i19-2/data/2026/cm44169-1/"),
+    )
+
+
+@devices.factory()
 def attenuator_motor_squad() -> AttenuatorMotorSquad:
     return AttenuatorMotorSquad(
         hutch=HutchState.EH2, instrument_session=I19_2_COMMISSIONING_INSTR_SESSION
     )
 
 
-@device_factory()
+@devices.factory()
 def backlight() -> BacklightPosition:
-    """Get the i19-2 backlight device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
     return BacklightPosition(prefix=f"{PREFIX.beamline_prefix}-EA-IOC-12:")
 
 
-@device_factory()
+@devices.factory()
 def beamstop() -> BeamStop:
-    """Get the i19-2 beamstop device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
     return BeamStop(prefix=f"{PREFIX.beamline_prefix}-OP-ABSB-02:")
 
 
-@device_factory()
+@devices.factory()
 def diffractometer() -> FourCircleDiffractometer:
     return FourCircleDiffractometer(prefix=PREFIX.beamline_prefix)
 
 
-@device_factory()
-def eiger() -> EigerDetector:
+@devices.factory()
+def eiger(path_provider: PathProvider) -> EigerDetector:
     return EigerDetector(
         prefix=PREFIX.beamline_prefix,
-        path_provider=get_path_provider(),
+        path_provider=path_provider,
         drv_suffix="-EA-EIGER-01:",
         hdf_suffix="-EA-EIGER-01:OD:",
     )
 
 
-@device_factory()
-def panda() -> HDFPanda:
+@devices.factory()
+def panda(path_provider: PathProvider) -> HDFPanda:
     return HDFPanda(
         prefix=f"{PREFIX.beamline_prefix}-EA-PANDA-01:",
-        path_provider=get_path_provider(),
+        path_provider=path_provider,
     )
 
 
-@device_factory()
+@devices.factory()
 def pinhole_and_collimator() -> PinholeCollimatorControl:
-    """Get the i19-2 pinhole and collimator control device, instantiate it if it
-    hasn't already been. If this is called when already instantiated in i19-2,
-    it will return the existing object.
-    """
     return PinholeCollimatorControl(prefix=PREFIX.beamline_prefix)
 
 
-@device_factory()
+@devices.factory()
 def shutter() -> AccessControlledShutter:
-    """Get the i19-2 hutch shutter device, instantiate it if it hasn't already been.
-    If this is called when already instantiated, it will return the existing object.
-    """
+    """Access controlled wrapper for the experiment shutter."""
     return AccessControlledShutter(
         prefix=f"{PREFIX.beamline_prefix}-PS-SHTR-01:",
         hutch=HutchState.EH2,
@@ -121,20 +117,40 @@ def shutter() -> AccessControlledShutter:
     )
 
 
-@device_factory()
+@devices.factory()
 def synchrotron() -> Synchrotron:
-    """Get the i19-2 synchrotron device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
     return Synchrotron()
 
 
-@device_factory()
+@devices.factory()
 def zebra() -> Zebra:
-    """Get the i19-2 zebra device, instantiate it if it hasn't already been.
-    If this is called when already instantiated in i19-2, it will return the existing object.
-    """
     return Zebra(
         mapping=I19_2_ZEBRA_MAPPING,
         prefix=f"{PREFIX.beamline_prefix}-EA-ZEBRA-03:",
     )
+
+
+@devices.factory()
+def hfm_piezo() -> AccessControlledPiezoActuator:
+    """Get the i19-2 access controlled hfm piezo device, instantiate it if it hasn't already been.
+    If this is called when already instantiated, it will return the existing object.
+    """
+    return AccessControlledPiezoActuator(
+        prefix=f"{PREFIX.beamline_prefix}-OP-HFM-01:",
+        mirror_type=FocusingMirrorName.HFM,
+        hutch=HutchState.EH2,
+        instrument_session=I19_2_COMMISSIONING_INSTR_SESSION,
+    )
+
+
+@devices.factory()
+def vfm_piezo() -> AccessControlledPiezoActuator:
+    """Get the i19-2 access controlled vfm piezo device, instantiate it if it hasn't already been.
+    If this is called when already instantiated, it will return the existing object.
+    """
+    return AccessControlledPiezoActuator(
+        prefix=f"{PREFIX.beamline_prefix}-OP-VFM-01:",
+        mirror_type=FocusingMirrorName.VFM,
+        hutch=HutchState.EH2,
+        instrument_session=I19_2_COMMISSIONING_INSTR_SESSION,
+    )

dodal/beamlines/i19_optics.py

@@ -1,14 +1,13 @@
-from dodal.common.beamlines.beamline_utils import (
-    device_factory,
-)
 from dodal.common.beamlines.beamline_utils import (
     set_beamline as set_utils_beamline,
 )
-from dodal.devices.hutch_shutter import HutchShutter
-from dodal.devices.i19.access_controlled.hutch_access import (
+from dodal.device_manager import DeviceManager
+from dodal.devices.beamlines.i19.access_controlled.hutch_access import (
     ACCESS_DEVICE_NAME,
     HutchAccessControl,
 )
+from dodal.devices.focusing_mirror import FocusingMirrorWithPiezo
+from dodal.devices.hutch_shutter import HutchShutter
 from dodal.log import set_beamline as set_log_beamline
 from dodal.utils import BeamlinePrefix
 
@@ -17,20 +16,34 @@ PREFIX = BeamlinePrefix("i19", "I")
 set_log_beamline(BL)
 set_utils_beamline(BL)
 
+devices = DeviceManager()
+
 
-@device_factory()
+@devices.factory()
 def shutter() -> HutchShutter:
-    """Get the i19 hutch shutter device, instantiate it if it hasn't already been.
-    If this is called when already instantiated, it will return the existing object.
-    """
+    """Real experiment shutter device for I19."""
     return HutchShutter(f"{PREFIX.beamline_prefix}-PS-SHTR-01:")
 
 
-@device_factory()
+@devices.factory()
 def access_control() -> HutchAccessControl:
-    """Get a device that checks the active hutch for i19, instantiate it if it hasn't already been.
-    If this is called when already instantiated, it will return the existing object.
-    """
+    """Device to check which hutch is the active hutch on i19."""
     return HutchAccessControl(
         f"{PREFIX.beamline_prefix}-OP-STAT-01:", ACCESS_DEVICE_NAME
     )
+
+
+@devices.factory()
+def vfm() -> FocusingMirrorWithPiezo:
+    """Get the i19 vfm device, instantiate it if it hasn't already been.
+    If this is called when already instantiated, it will return the existing object.
+    """
+    return FocusingMirrorWithPiezo(f"{PREFIX.beamline_prefix}-OP-VFM-01:")
+
+
+@devices.factory()
+def hfm() -> FocusingMirrorWithPiezo:
+    """Get the i19 hfm device, instantiate it if it hasn't already been.
+    If this is called when already instantiated, it will return the existing object.
+    """
+    return FocusingMirrorWithPiezo(f"{PREFIX.beamline_prefix}-OP-HFM-01:")

dodal/beamlines/i20_1.py

@@ -38,32 +38,26 @@ set_path_provider(
 """
 NOTE: Due to the CA gateway machine being switched off, PVs are not available remotely
 and you need to be on the beamline network to access them.
-The simplest way to do this is to `ssh i20-1-ws001` and run dodal connect i20_1 from there.
+The simplest way to do this is to `ssh i20-1-ws001` and run dodal connect i20_1 from
+there.
 """
 
 
 @device_factory()
 def turbo_slit() -> TurboSlit:
-    """
-    turboslit for selecting energy from the polychromator
-    """
-
+    """Turboslit for selecting energy from the polychromator."""
     return TurboSlit(f"{PREFIX.beamline_prefix}-OP-PCHRO-01:TS:")
 
 
 @device_factory()
 def turbo_slit_x() -> Motor:
-    """
-    turbo slit x motor
-    """
+    """Turbo slit x motor."""
     return Motor(f"{PREFIX.beamline_prefix}-OP-PCHRO-01:TS:XFINE")
 
 
 @device_factory()
 def turbo_slit_pmac() -> PmacIO:
-    """
-    PMac controller using running fly scans with trajectory
-    """
+    """PMac controller using running fly scans with trajectory."""
     motor = turbo_slit_x()
     return PmacIO(
         prefix=f"{PREFIX.beamline_prefix}-MO-STEP-06:",
@@ -93,9 +87,7 @@ def alignment_y() -> Motor:
 
 @device_factory(skip=True)
 def xspress3() -> Xspress3:
-    """
-    16 channels Xspress3 detector
-    """
+    """16 channels Xspress3 detector."""
     return Xspress3(
         f"{PREFIX.beamline_prefix}-EA-DET-03:",
         num_channels=16,

dodal/beamlines/i21.py

@@ -2,13 +2,9 @@ from pathlib import Path
 
 from daq_config_server.client import ConfigServer
 
-from dodal.common.beamlines.beamline_utils import (
-    device_factory,
-)
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
-from dodal.devices.i21 import (
-    Grating,
-)
+from dodal.device_manager import DeviceManager
+from dodal.devices.beamlines.i21 import Grating
 from dodal.devices.insertion_device import (
     Apple2,
     Apple2EnforceLHMoveController,
@@ -42,14 +38,15 @@ I21_CONF_CLIENT = ConfigServer(url="https://daq-config.diamond.ac.uk")
 LOOK_UPTABLE_DIR = "/dls_sw/i21/software/gda/workspace_git/gda-diamond.git/configurations/i21-config/lookupTables/"
 GAP_LOOKUP_FILE_NAME = "IDEnergy2GapCalibrations.csv"
 PHASE_LOOKUP_FILE_NAME = "IDEnergy2PhaseCalibrations.csv"
+devices = DeviceManager()
 
 
-@device_factory()
+@devices.factory()
 def synchrotron() -> Synchrotron:
     return Synchrotron()
 
 
-@device_factory()
+@devices.factory()
 def pgm() -> PlaneGratingMonochromator:
     return PlaneGratingMonochromator(
         prefix=f"{PREFIX.beamline_prefix}-OP-PGM-01:",
@@ -57,12 +54,12 @@ def pgm() -> PlaneGratingMonochromator:
     )
 
 
-@device_factory()
+@devices.factory()
 def id_gap() -> UndulatorGap:
     return UndulatorGap(prefix=f"{PREFIX.insertion_prefix}-MO-SERVC-01:")
 
 
-@device_factory()
+@devices.factory()
 def id_phase() -> UndulatorPhaseAxes:
     return UndulatorPhaseAxes(
         prefix=f"{PREFIX.insertion_prefix}-MO-SERVC-01:",
@@ -73,20 +70,24 @@ def id_phase() -> UndulatorPhaseAxes:
     )
 
 
-@device_factory()
-def id() -> Apple2[UndulatorPhaseAxes]:
+@devices.factory()
+def id(
+    id_gap: UndulatorGap, id_phase: UndulatorPhaseAxes
+) -> Apple2[UndulatorPhaseAxes]:
     """I21 insertion device."""
     return Apple2[UndulatorPhaseAxes](
-        id_gap=id_gap(),
-        id_phase=id_phase(),
+        id_gap=id_gap,
+        id_phase=id_phase,
     )
 
 
-@device_factory()
-def id_controller() -> Apple2EnforceLHMoveController[UndulatorPhaseAxes]:
-    """i21 insertion device controller."""
+@devices.factory()
+def id_controller(
+    id: Apple2[UndulatorPhaseAxes],
+) -> Apple2EnforceLHMoveController[UndulatorPhaseAxes]:
+    """I21 insertion device controller."""
     return Apple2EnforceLHMoveController[UndulatorPhaseAxes](
-        apple2=id(),
+        apple2=id,
         gap_energy_motor_lut=ConfigServerEnergyMotorLookup(
             lut_config=LookupTableColumnConfig(grating=I21_GRATING_COLUMNS),
             config_client=I21_CONF_CLIENT,
@@ -103,22 +104,28 @@ def id_controller() -> Apple2EnforceLHMoveController[UndulatorPhaseAxes]:
     )
 
 
-@device_factory()
-def id_energy() -> InsertionDeviceEnergy:
-    return InsertionDeviceEnergy(id_controller=id_controller())
+@devices.factory()
+def id_energy(
+    id_controller: Apple2EnforceLHMoveController[UndulatorPhaseAxes],
+) -> InsertionDeviceEnergy:
+    return InsertionDeviceEnergy(id_controller=id_controller)
 
 
-@device_factory()
-def id_polarisation() -> InsertionDevicePolarisation:
-    return InsertionDevicePolarisation(id_controller=id_controller())
+@devices.factory()
+def id_polarisation(
+    id_controller: Apple2EnforceLHMoveController[UndulatorPhaseAxes],
+) -> InsertionDevicePolarisation:
+    return InsertionDevicePolarisation(id_controller=id_controller)
 
 
-@device_factory()
-def energy_jid() -> BeamEnergy:
+@devices.factory()
+def energy(
+    id_energy: InsertionDeviceEnergy, pgm: PlaneGratingMonochromator
+) -> BeamEnergy:
     """Beam energy."""
-    return BeamEnergy(id_energy=id_energy(), mono=pgm().energy)
+    return BeamEnergy(id_energy=id_energy, mono=pgm.energy)
 
 
-@device_factory()
+@devices.factory()
 def sample_temperature_controller() -> Lakeshore336:
     return Lakeshore336(prefix=f"{PREFIX.beamline_prefix}-EA-TCTRL-01:")

dodal/beamlines/i22.py

@@ -1,3 +1,6 @@
+from pathlib import Path
+
+from ophyd_async.core import StaticPathProvider, UUIDFilenameProvider
 from ophyd_async.epics.adaravis import AravisDetector
 from ophyd_async.epics.adcore import NDPluginBaseIO, NDPluginStatsIO
 from ophyd_async.epics.adpilatus import PilatusDetector
@@ -6,6 +9,7 @@ from ophyd_async.fastcs.panda import HDFPanda
 from dodal.common.beamlines.beamline_utils import (
     device_factory,
     get_path_provider,
+    set_path_provider,
 )
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
 from dodal.common.beamlines.device_helpers import CAM_SUFFIX, DET_SUFFIX, HDF5_SUFFIX
@@ -13,11 +17,15 @@ from dodal.common.crystal_metadata import (
     MaterialsEnum,
     make_crystal_metadata_from_material,
 )
+from dodal.devices.beamlines.i22.dcm import DCM
+from dodal.devices.beamlines.i22.fswitch import FSwitch
+from dodal.devices.beamlines.i22.nxsas import (
+    NXSasMetadataHolder,
+    NXSasOAV,
+    NXSasPilatus,
+)
 from dodal.devices.bimorph_mirror import BimorphMirror
 from dodal.devices.focusing_mirror import FocusingMirror
-from dodal.devices.i22.dcm import DCM
-from dodal.devices.i22.fswitch import FSwitch
-from dodal.devices.i22.nxsas import NXSasMetadataHolder, NXSasOAV, NXSasPilatus
 from dodal.devices.linkam3 import Linkam3
 from dodal.devices.motors import XYPitchStage, XYRollStage, XYStage
 from dodal.devices.slits import Slits
@@ -33,6 +41,13 @@ PREFIX = BeamlinePrefix(BL)
 set_log_beamline(BL)
 set_utils_beamline(BL)
 
+# This should be removed when the DeviceManager is adopted
+try:
+    get_path_provider()
+except NameError:
+    # If one hasn't already been set, use a default to stop things crashing
+    set_path_provider(StaticPathProvider(UUIDFilenameProvider(), Path("/tmp")))
+
 
 @device_factory()
 def saxs() -> PilatusDetector:
@@ -267,7 +282,7 @@ def linkam() -> Linkam3:
 
 @device_factory(skip=True)
 def ppump() -> WatsonMarlow323Pump:
-    """Sample Environment Peristaltic Pump"""
+    """Sample Environment Peristaltic Pump."""
     return WatsonMarlow323Pump(f"{PREFIX.beamline_prefix}-EA-PUMP-01:")
 
 

dodal/beamlines/i23.py

@@ -52,8 +52,7 @@ class I23DetectorPositions(StrictEnum):
 
 
 def _is_i23_machine():
-    """
-    Devices using PVA can only connect from i23 machines, due to the absence of
+    """Devices using PVA can only connect from i23 machines, due to the absence of
     PVA gateways at present.
     """
     hostname = get_hostname()

dodal/beamlines/i24.py

@@ -12,16 +12,16 @@ from dodal.devices.attenuator.filter_selections import (
     I24FilterOneSelections,
     I24FilterTwoSelections,
 )
+from dodal.devices.beamlines.i24.aperture import Aperture
+from dodal.devices.beamlines.i24.beam_center import DetectorBeamCenter
+from dodal.devices.beamlines.i24.beamstop import Beamstop
+from dodal.devices.beamlines.i24.commissioning_jungfrau import CommissioningJungfrau
+from dodal.devices.beamlines.i24.dcm import DCM
+from dodal.devices.beamlines.i24.dual_backlight import DualBacklight
+from dodal.devices.beamlines.i24.focus_mirrors import FocusMirrorsMode
+from dodal.devices.beamlines.i24.pmac import PMAC
+from dodal.devices.beamlines.i24.vgonio import VerticalGoniometer
 from dodal.devices.hutch_shutter import HutchShutter
-from dodal.devices.i24.aperture import Aperture
-from dodal.devices.i24.beam_center import DetectorBeamCenter
-from dodal.devices.i24.beamstop import Beamstop
-from dodal.devices.i24.commissioning_jungfrau import CommissioningJungfrau
-from dodal.devices.i24.dcm import DCM
-from dodal.devices.i24.dual_backlight import DualBacklight
-from dodal.devices.i24.focus_mirrors import FocusMirrorsMode
-from dodal.devices.i24.pmac import PMAC
-from dodal.devices.i24.vgonio import VerticalGoniometer
 from dodal.devices.motors import YZStage
 from dodal.devices.oav.oav_detector import OAVBeamCentreFile
 from dodal.devices.oav.oav_parameters import OAVConfigBeamCentre
@@ -148,7 +148,8 @@ def commissioning_jungfrau(
     path_provider: PathProvider,
 ) -> CommissioningJungfrau:
     """Get the commissionning Jungfrau 9M device, which uses a temporary filewriter
-    device in place of Odin while the detector is in commissioning."""
+    device in place of Odin while the detector is in commissioning.
+    """
     return CommissioningJungfrau(
         f"{PREFIX.beamline_prefix}-EA-JFRAU-01:",
         f"{PREFIX.beamline_prefix}-JUNGFRAU-META:FD:",

dodal/beamlines/k07.py

@@ -1,21 +1,43 @@
+from pathlib import Path
+
+from daq_config_server.client import ConfigServer
 from ophyd_async.core import StrictEnum
 
-from dodal.common.beamlines.beamline_utils import (
-    device_factory,
-)
 from dodal.common.beamlines.beamline_utils import set_beamline as set_utils_beamline
+from dodal.device_manager import DeviceManager
+from dodal.devices.insertion_device import (
+    Apple2,
+    Apple2EnforceLHMoveController,
+    ConfigServerEnergyMotorLookup,
+    InsertionDeviceEnergy,
+    InsertionDevicePolarisation,
+    LookupTableColumnConfig,
+    UndulatorGap,
+    UndulatorPhaseAxes,
+)
 from dodal.devices.pgm import PlaneGratingMonochromator
 from dodal.devices.synchrotron import Synchrotron
 from dodal.log import set_beamline as set_log_beamline
 from dodal.utils import BeamlinePrefix, get_beamline_name
 
+devices = DeviceManager()
+
+
+K07_CONF_CLIENT = ConfigServer(url="https://daq-config.diamond.ac.uk")
+
+LOOK_UPTABLE_DIR = "/dls_sw/k07/software/gda/workspace_git/gda-diamond.git/configurations/k07/lookupTables/"
+GAP_LOOKUP_FILE_NAME = "JIDEnergy2GapCalibrations.csv"
+PHASE_LOOKUP_FILE_NAME = "JIDEnergy2PhaseCalibrations.csv"
+K07_GRATING_COLUMNS = "Grating"
+K07_PHASE_POLY_DEG_COLUMNS = ["0th-order"]
+
 BL = get_beamline_name("k07")
 PREFIX = BeamlinePrefix(BL)
 set_log_beamline(BL)
 set_utils_beamline(BL)
 
 
-@device_factory()
+@devices.factory()
 def synchrotron() -> Synchrotron:
     return Synchrotron()
 
@@ -26,9 +48,81 @@ class Grating(StrictEnum):
 
 
 # Grating does not exist yet - this class is a placeholder for when it does
-@device_factory(skip=True)
+@devices.factory(skip=True)
 def pgm() -> PlaneGratingMonochromator:
     return PlaneGratingMonochromator(
         prefix=f"{PREFIX.beamline_prefix}-OP-PGM-01:",
         grating=Grating,
     )
+
+
+# Insertion device does not exist yet - these classes are placeholders at the moment.
+@devices.factory(skip=True)
+def id_gap() -> UndulatorGap:
+    return UndulatorGap(
+        prefix=f"{PREFIX.insertion_prefix}-MO-SERVC-01:",
+    )
+
+
+# Insertion device does not exist yet - these classes are placeholders at the moment.
+@devices.factory(skip=True)
+def id_phase() -> UndulatorPhaseAxes:
+    return UndulatorPhaseAxes(
+        prefix=f"{PREFIX.insertion_prefix}-MO-SERVC-01:",
+        top_outer="RPQ1",
+        top_inner="RPQ2",
+        btm_inner="RPQ3",
+        btm_outer="RPQ4",
+    )
+
+
+# Insertion device does not exist yet - these classes are placeholders at the moment.
+@devices.factory(skip=True)
+def id(
+    id_gap: UndulatorGap, id_phase: UndulatorPhaseAxes
+) -> Apple2[UndulatorPhaseAxes]:
+    """K07 insertion device."""
+    return Apple2[UndulatorPhaseAxes](
+        id_gap=id_gap,
+        id_phase=id_phase,
+    )
+
+
+# Insertion device does not exist yet - temporary use Apple2EnforceLHMoveController
+@devices.factory(skip=True)
+def id_controller(
+    id: Apple2[UndulatorPhaseAxes],
+) -> Apple2EnforceLHMoveController[UndulatorPhaseAxes]:
+    """I21 insertion device controller."""
+    return Apple2EnforceLHMoveController[UndulatorPhaseAxes](
+        apple2=id,
+        gap_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(grating=K07_GRATING_COLUMNS),
+            config_client=K07_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, GAP_LOOKUP_FILE_NAME),
+        ),
+        phase_energy_motor_lut=ConfigServerEnergyMotorLookup(
+            lut_config=LookupTableColumnConfig(
+                grating=K07_GRATING_COLUMNS, poly_deg=K07_PHASE_POLY_DEG_COLUMNS
+            ),
+            config_client=K07_CONF_CLIENT,
+            path=Path(LOOK_UPTABLE_DIR, GAP_LOOKUP_FILE_NAME),
+        ),
+        units="eV",
+    )
+
+
+# Insertion device does not exist yet - these classes are placeholders at the moment.
+@devices.factory(skip=True)
+def id_energy(
+    id_controller: Apple2EnforceLHMoveController[UndulatorPhaseAxes],
+) -> InsertionDeviceEnergy:
+    return InsertionDeviceEnergy(id_controller)
+
+
+# Insertion device does not exist yet - these classes are placeholders at the moment.
+@devices.factory(skip=True)
+def id_polarisation(
+    id_controller: Apple2EnforceLHMoveController[UndulatorPhaseAxes],
+) -> InsertionDevicePolarisation:
+    return InsertionDevicePolarisation(id_controller)

dodal/beamlines/p38.py

@@ -15,9 +15,9 @@ from dodal.common.crystal_metadata import (
     make_crystal_metadata_from_material,
 )
 from dodal.common.visit import LocalDirectoryServiceClient, StaticVisitPathProvider
+from dodal.devices.beamlines.i22.dcm import DCM
+from dodal.devices.beamlines.i22.fswitch import FSwitch
 from dodal.devices.focusing_mirror import FocusingMirror
-from dodal.devices.i22.dcm import DCM
-from dodal.devices.i22.fswitch import FSwitch
 from dodal.devices.linkam3 import Linkam3
 from dodal.devices.pressure_jump_cell import PressureJumpCell
 from dodal.devices.slits import Slits
@@ -198,7 +198,7 @@ def linkam() -> Linkam3:
 
 @device_factory()
 def ppump() -> WatsonMarlow323Pump:
-    """Peristaltic Pump"""
+    """Peristaltic Pump."""
     return WatsonMarlow323Pump(f"{PREFIX.beamline_prefix}-EA-PUMP-01:")