dls-dodal 1.69.0__py3-none-any.whl → 2.0.0__py3-none-any.whl

dodal/devices/{i09_1_shared → beamlines/i09_1_shared}/hard_energy.py

@@ -12,17 +12,16 @@ from ophyd_async.core import (
     soft_signal_rw,
 )
 
-from dodal.devices.common_dcm import DoubleCrystalMonochromatorBase
-from dodal.devices.i09_1_shared.hard_undulator_functions import (
+from dodal.devices.beamlines.i09_1_shared.hard_undulator_functions import (
     MAX_ENERGY_COLUMN,
     MIN_ENERGY_COLUMN,
 )
+from dodal.devices.common_dcm import DoubleCrystalMonochromatorBase
 from dodal.devices.undulator import UndulatorInMm, UndulatorOrder
 
 
 class HardInsertionDeviceEnergy(StandardReadable, Movable[float]):
-    """
-    Compound device to link hard x-ray undulator gap and order to photon energy.
+    """Compound device to link hard x-ray undulator gap and order to photon energy.
     Setting the energy adjusts the undulator gap accordingly.
     """
 
@@ -83,8 +82,8 @@ class HardInsertionDeviceEnergy(StandardReadable, Movable[float]):
 
 
 class HardEnergy(StandardReadable, Locatable[float]):
-    """
-    Energy compound device that provides combined change of both DCM energy and undulator gap accordingly.
+    """Energy compound device that provides combined change of both DCM energy and
+    undulator gap accordingly.
     """
 
     def __init__(

dodal/devices/{i09_1_shared → beamlines/i09_1_shared}/hard_undulator_functions.py

@@ -49,9 +49,7 @@ def _calculate_gamma(look_up_table: dict[int, "np.ndarray"], order: int) -> floa
 def _calculate_undulator_parameter_max(
     magnet_field: float, undulator_period_mm: int
 ) -> float:
-    """
-    Calculate the maximum undulator parameter.
-    """
+    """Calculate the maximum undulator parameter."""
     return (
         (
             2
@@ -73,22 +71,25 @@ def calculate_gap_i09_hu(
     gap_offset: float = 0.0,
     undulator_period_mm: int = 27,
 ) -> float:
-    """
-    Calculate the undulator gap required to produce a given energy at a given harmonic order.
-    This algorithm was provided by the I09 beamline scientists, and is based on the physics of undulator radiation.
+    """Calculate the undulator gap required to produce a given energy at a given
+    harmonic order. This algorithm was provided by the I09 beamline scientists, and is
+    based on the physics of undulator radiation.
+
     https://cxro.lbl.gov//PDF/X-Ray-Data-Booklet.pdf
 
     Args:
         photon_energy_kev (float): Requested photon energy in keV.
-        look_up_table (dict[int, np.ndarray]): Lookup table containing undulator and beamline parameters for each harmonic order.
-        order (int, optional): Harmonic order for which to calculate the gap. Defaults to 1.
-        gap_offset (float, optional): Additional gap offset to apply (in mm). Defaults to 0.0.
+        look_up_table (dict[int, np.ndarray]): Lookup table containing undulator and
+            beamline parameters for each harmonic order.
+        order (int, optional): Harmonic order for which to calculate the gap. Defaults
+            to 1.
+        gap_offset (float, optional): Additional gap offset to apply (in mm). Defaults
+            to 0.0.
         undulator_period_mm (int, optional): Undulator period in mm. Defaults to 27.
 
     Returns:
         float: Calculated undulator gap in millimeters.
     """
-
     _validate_order(order, look_up_table)
     gamma = _calculate_gamma(look_up_table, order)
 
@@ -141,15 +142,17 @@ def calculate_energy_i09_hu(
     gap_offset: float = 0.0,
     undulator_period_mm: int = 27,
 ) -> float:
-    """
-    Calculate the photon energy produced by the undulator at a given gap and harmonic order.
-    Reverse of the calculate_gap_i09_hu function.
+    """Calculate the photon energy produced by the undulator at a given gap and harmonic
+    order. Reverse of the calculate_gap_i09_hu function.
 
     Args:
         gap (float): Undulator gap in millimeters.
-        look_up_table (dict[int, np.ndarray]): Lookup table containing undulator and beamline parameters for each harmonic order.
-        order (int, optional): Harmonic order for which to calculate the energy. Defaults to 1.
-        gap_offset (float, optional): Additional gap offset to apply (in mm). Defaults to 0.0.
+        look_up_table (dict[int, np.ndarray]): Lookup table containing undulator and
+            beamline parameters for each harmonic order.
+        order (int, optional): Harmonic order for which to calculate the energy.
+            Defaults to 1.
+        gap_offset (float, optional): Additional gap offset to apply (in mm). Defaults
+            to 0.0.
         undulator_period_mm (int, optional): Undulator period in mm. Defaults to 27.
 
     Returns:

dodal/devices/{i10 → beamlines/i10}/diagnostics.py

@@ -86,7 +86,8 @@ class D3jPosition(StrictEnum):
 class I10PneumaticStage(StandardReadable):
     """Pneumatic stage only has two real positions in or out.
     Use for fluorescent screen which can be insert into the x-ray beam.
-    Most often use in conjunction with a webcam to locate the x-ray beam."""
+    Most often use in conjunction with a webcam to locate the x-ray beam.
+    """
 
     def __init__(
         self,
@@ -106,7 +107,7 @@ class I10PneumaticStage(StandardReadable):
 
 
 class ScreenCam(Device):
-    """Compound device of pneumatic stage(fluorescent screen) and webcam"""
+    """Compound device of pneumatic stage(fluorescent screen) and webcam."""
 
     def __init__(
         self,
@@ -191,7 +192,7 @@ class I10JDiagnostic(Device):
 
 
 class I10Diagnostic5ADet(Device):
-    """Diagnostic 5a detection with drain current and photo diode"""
+    """Diagnostic 5a detection with drain current and photo diode."""
 
     def __init__(
         self, prefix: str, name: str = "", connector: DeviceConnector | None = None

dodal/devices/{i10 → beamlines/i10}/i10_apple2.py

@@ -32,7 +32,14 @@ ALPHA_OFFSET = 180
 
 
 class I10Apple2(Apple2[UndulatorPhaseAxes]):
-    """I10Apple2 device is an apple2 with extra jaw phase motor."""
+    """I10Apple2 device is an apple2 with extra jaw phase motor.
+
+    Args:
+        id_gap (UndulatorJawPhase): The gap motor of the undulator.
+        id_phase (UndulatorJawPhase): The phase motors of the undulator.
+        id_jaw_phase (UndulatorJawPhase): The jaw phase motor of the undulator.
+        name (str, optional): The name of the device, by default "".
+    """
 
     def __init__(
         self,
@@ -41,27 +48,29 @@ class I10Apple2(Apple2[UndulatorPhaseAxes]):
         id_jaw_phase: UndulatorJawPhase,
         name: str = "",
     ) -> None:
-        """
-        Parameters:
-        ------------
-        id_gap : UndulatorJawPhase
-            The gap motor of the undulator.
-        id_phase : UndulatorJawPhase
-            The phase motors of the undulator.
-        id_jaw_phase : UndulatorJawPhase
-            The jaw phase motor of the undulator.
-        name : str, optional
-            The name of the device, by default "".
-        """
         with self.add_children_as_readables():
             self.jaw_phase = Reference(id_jaw_phase)
         super().__init__(id_gap=id_gap, id_phase=id_phase, name=name)
 
 
 class I10Apple2Controller(Apple2Controller[I10Apple2]):
-    """
-    I10Apple2Controller is a extension of Apple2Controller which provide linear
+    """I10Apple2Controller is a extension of Apple2Controller which provide linear
     arbitrary angle control.
+
+    Args:
+        apple2 (I10Apple2): An I10Apple2 device.
+        gap_energy_motor_lut (EnergyMotorLookup): The class that handles the gap
+            look up table logic for the insertion device.
+        phase_energy_motor_lut (EnergyMotorLookup): The class that handles the phase
+            look up table logic for the insertion device.
+        jaw_phase_limit (float, optional): The maximum allowed jaw_phase movement.
+            The default is 12.0
+        jaw_phase_poly_param (list[float], optional): polynomial parameters highest
+            power first. The default is DEFAULT_JAW_PHASE_POLY_PARAMS
+        angle_threshold_deg (float, optional): The angle threshold to switch between
+            0-180 and 180-360 range. The default is 30.0
+        units (str, optional): the units of this device. Defaults to eV.
+        name (str, optional): New device name.
     """
 
     def __init__(
@@ -75,26 +84,6 @@ class I10Apple2Controller(Apple2Controller[I10Apple2]):
         units: str = "eV",
         name: str = "",
     ) -> None:
-        """
-        Parameters:
-        -----------
-        apple2 : I10Apple2
-            An I10Apple2 device.
-        gap_energy_motor_lut: EnergyMotorLookup
-            The class that handles the gap look up table logic for the insertion device.
-        phase_energy_motor_lut: EnergyMotorLookup
-            The class that handles the phase look up table logic for the insertion device.
-        jaw_phase_limit : float, optional
-            The maximum allowed jaw_phase movement., by default 12.0
-        jaw_phase_poly_param : list[float], optional
-            polynomial parameters highest power first., by default DEFAULT_JAW_PHASE_POLY_PARAMS
-        angle_threshold_deg : float, optional
-            The angle threshold to switch between 0-180 and 180-360 range., by default 30.0
-        units:
-            the units of this device. Defaults to eV.
-        name : str, optional
-            New device name.
-        """
         self.gap_energy_motor_lut = gap_energy_motor_lut
         self.phase_energy_motor_lut = phase_energy_motor_lut
         super().__init__(
@@ -167,8 +156,13 @@ class I10Apple2Controller(Apple2Controller[I10Apple2]):
 
 
 class LinearArbitraryAngle(StandardReadable, Movable[SupportsFloat]):
-    """
-    Device to set the polarisation angle of the Apple2 undulator in Linear Arbitrary (LA) mode.
+    """Device to set the polarisation angle of the Apple2 undulator in Linear Arbitrary
+    (LA) mode.
+
+    Args:
+        id_controller (I10Apple2Controller): The I10Apple2Controller which control
+            the ID.
+        name (str, optional): New device name.
     """
 
     def __init__(
@@ -176,14 +170,6 @@ class LinearArbitraryAngle(StandardReadable, Movable[SupportsFloat]):
         id_controller: I10Apple2Controller,
         name: str = "",
     ) -> None:
-        """
-        Parameters
-        ----------
-        id_controller : I10Apple2Controller
-            The I10Apple2Controller which control the ID.
-        name : str, optional
-            New device name.
-        """
         super().__init__(name=name)
         self.linear_arbitrary_angle = Reference(id_controller.linear_arbitrary_angle)
 

dodal/devices/{i10 → beamlines/i10}/rasor/rasor_current_amp.py

@@ -6,11 +6,6 @@ from dodal.devices.current_amplifiers import (
     Femto3xxGainToCurrentTable,
     Femto3xxRaiseTime,
     FemtoDDPCA,
-    SR570FineGainTable,
-    SR570FullGainTable,
-    SR570GainTable,
-    SR570GainToCurrentTable,
-    SR570RaiseTimeTable,
 )
 
 
@@ -41,32 +36,14 @@ class RasorFemto(Device):
 
 
 class RasorSR570(Device):
-    def __init__(self, prefix: str, suffix: str = "SENS:SEL", name: str = "") -> None:
+    def __init__(self, prefix: str, name: str = "") -> None:
         self.ca1 = SR570(
             prefix + "-04:",
-            suffix=suffix,
-            fine_gain_table=SR570FineGainTable,
-            coarse_gain_table=SR570GainTable,
-            combined_table=SR570FullGainTable,
-            gain_to_current_table=SR570GainToCurrentTable,
-            raise_timetable=SR570RaiseTimeTable,
         )
         self.ca2 = SR570(
             prefix + "-05:",
-            suffix=suffix,
-            fine_gain_table=SR570FineGainTable,
-            coarse_gain_table=SR570GainTable,
-            combined_table=SR570FullGainTable,
-            gain_to_current_table=SR570GainToCurrentTable,
-            raise_timetable=SR570RaiseTimeTable,
         )
         self.ca3 = SR570(
             prefix + "-06:",
-            suffix=suffix,
-            fine_gain_table=SR570FineGainTable,
-            coarse_gain_table=SR570GainTable,
-            combined_table=SR570FullGainTable,
-            gain_to_current_table=SR570GainToCurrentTable,
-            raise_timetable=SR570RaiseTimeTable,
         )
         super().__init__(name)

dodal/devices/{i10 → beamlines/i10}/rasor/rasor_motors.py

@@ -18,7 +18,7 @@ class Diffractometer(StandardReadable):
 
 
 class DetSlits(StandardReadable):
-    "Detector slits"
+    """Detector slits."""
 
     def __init__(
         self,
@@ -32,7 +32,7 @@ class DetSlits(StandardReadable):
 
 
 class PaStage(StandardReadable):
-    "Rasor detector stage"
+    """Rasor detector stage."""
 
     def __init__(
         self,

dodal/devices/{i10 → beamlines/i10}/slits.py

@@ -27,9 +27,10 @@ class I10SlitsBlades(Slits):
 
 
 class BladeDrainCurrents(Device):
-    """ "The drain current measurements on each blade. The drain current are due to
+    """The drain current measurements on each blade. The drain current are due to
     photoelectric effect (https://en.wikipedia.org/wiki/Photoelectric_effect).
-    Note the readings are in voltage as it is the output of a current amplifier."""
+    Note the readings are in voltage as it is the output of a current amplifier.
+    """
 
     def __init__(
         self,
@@ -59,7 +60,8 @@ class BladeDrainCurrents(Device):
 
 class I10PrimarySlits(Slits):
     """First slits of the beamline with very high power load, they are two square water
-    cooled blocks(aperture/aptr) that overlap to produce slit like behavior."""
+    cooled blocks(aperture/aptr) that overlap to produce slit like behavior.
+    """
 
     def __init__(self, prefix: str, name: str = "") -> None:
         with self.add_children_as_readables():

dodal/devices/beamlines/i10_1/__init__.py

@@ -0,0 +1,9 @@
+from .electromagnet.magnet import ElectromagnetMagnetField
+from .electromagnet.stages import ElectromagnetStage
+from .scaler_cards import I10JScalerCard
+
+__all__ = [
+    "ElectromagnetMagnetField",
+    "I10JScalerCard",
+    "ElectromagnetStage",
+]

dodal/devices/beamlines/i10_1/electromagnet/magnet.py

@@ -0,0 +1,16 @@
+from ophyd_async.core import StandardReadable
+from ophyd_async.epics.core import epics_signal_rw
+
+
+class ElectromagnetMagnetField(StandardReadable):
+    def __init__(
+        self,
+        prefix: str,
+        name: str = "",
+    ):
+        with self.add_children_as_readables():
+            self.field = epics_signal_rw(
+                float, write_pv=prefix + "FIELD", read_pv=prefix + "FIELD:RBV"
+            )
+            self.current = epics_signal_rw(float, prefix + "DMD")
+        super().__init__(name=name)

dodal/devices/beamlines/i10_1/electromagnet/stages.py

@@ -0,0 +1,14 @@
+from ophyd_async.core import StandardReadable
+from ophyd_async.epics.motor import Motor
+
+
+class ElectromagnetStage(StandardReadable):
+    def __init__(
+        self,
+        prefix: str,
+        name: str = "",
+    ):
+        with self.add_children_as_readables():
+            self.y = Motor(prefix + "Y")
+            self.pitch = Motor(prefix + "PITCH")
+        super().__init__(name=name)

dodal/devices/beamlines/i10_1/scaler_cards.py

@@ -0,0 +1,13 @@
+from ophyd_async.core import StandardReadable
+
+from dodal.devices.current_amplifiers import StruckScaler
+
+
+class I10JScalerCard(StandardReadable):
+    def __init__(self, prefix, name: str = "") -> None:
+        with self.add_children_as_readables():
+            self.mon = StruckScaler(prefix=prefix, suffix=".S17")
+            self.tey = StruckScaler(prefix=prefix, suffix=".S18")
+            self.fy = StruckScaler(prefix=prefix, suffix=".S19")
+            self.fy2 = StruckScaler(prefix=prefix, suffix=".S20")
+        super().__init__(name)

dodal/devices/{i11 → beamlines/i11}/cyberstar_blower.py

@@ -9,7 +9,7 @@ EU = TypeVar("EU", bound=EurothermGeneral)
 
 
 class CyberstarBlower(StandardReadable, Generic[EU]):
-    """This is a specific device that uses a Eurotherm controller"""
+    """This is a specific device that uses a Eurotherm controller."""
 
     def __init__(
         self,

dodal/devices/{i11 → beamlines/i11}/diff_stages.py

@@ -4,10 +4,9 @@ from dodal.devices.motors import Stage
 
 
 class DiffractometerStage(Stage):
-    """
-    This is the diffractometer stage which contains both detectors,
+    """This is the diffractometer stage which contains both detectors,
     it allows for rotations and also sample position. Contains:
-    theta, delta, two_theta, sample_position
+    theta, delta, two_theta, sample_position.
     """
 
     def __init__(
@@ -29,10 +28,9 @@ class DiffractometerStage(Stage):
 
 
 class DiffractometerBase(Stage):
-    """
-    This is the diffractometer stage which contains both detectors,
+    """This is the diffractometer stage which contains both detectors,
     it allows for translation about x and y and also sample position. Contains:
-    x1, x2, y1, y2, y3. Used for aligning the detector to the beam/sample
+    x1, x2, y1, y2, y3. Used for aligning the detector to the beam/sample.
     """
 
     def __init__(

dodal/devices/{i11 → beamlines/i11}/mythen.py

@@ -99,7 +99,7 @@ _BIT_DEPTH = 24
 
 
 class Mythen3Controller(ADBaseController):
-    """ADBaseController` for a Mythen3"""
+    """ADBaseController` for a Mythen3."""
 
     def __init__(self, driver: Mythen3Driver):
         self._driver = driver
@@ -134,9 +134,8 @@ class Mythen3Controller(ADBaseController):
 
 
 class Mythen3(AreaDetector[Mythen3Controller]):
-    """
-    The detector may be configured for an external trigger on a GPIO port,
-    which must be done prior to preparing the detector
+    """The detector may be configured for an external trigger on a GPIO port,
+    which must be done prior to preparing the detector.
     """
 
     def __init__(

dodal/devices/{i11 → beamlines/i11}/nx100robot.py

@@ -34,9 +34,8 @@ class RobotSampleState(float, Enum):
 
 
 class NX100Robot(StandardReadable, Locatable[int], Stoppable, Pausable):
-    """
-    This is a Yaskawa Motoman that uses an NX100 controller. It consists of a robot arm
-    with a gripper and a carousel for sample handling. It can pick and place samples
+    """This is a Yaskawa Motoman that uses an NX100 controller. It consists of a robot
+    arm with a gripper and a carousel for sample handling. It can pick and place samples
     from the carousel to the diffractometer and vice versa.
 
     Has set, pause, resume, stop, locate, stage methods.
@@ -71,9 +70,10 @@ class NX100Robot(StandardReadable, Locatable[int], Stoppable, Pausable):
         )
 
     async def clear_sample(self, table_in: bool = True):
-        """clears the sample from the diffractometer and places it on the carousel.
-        if table_in is True, it will also move the sample holder to the table in position."""
-
+        """Clears the sample from the diffractometer and places it on the carousel.
+        if table_in is True, it will also move the sample holder to the table in
+        position.
+        """
         sample_state = await self.robot_sample_state.get_value()
         if sample_state == RobotSampleState.DIFFRACTOMETER:
             await asyncio.gather(

dodal/devices/{i11 → beamlines/i11}/spinner.py

@@ -8,7 +8,7 @@ from ophyd_async.epics.core import epics_signal_rw
 
 
 class Spinner(StandardReadable, Pausable):
-    """This is a simple sample spinner, that has enable and speed (%)"""
+    """This is a simple sample spinner, that has enable and speed (%)."""
 
     def __init__(
         self,

dodal/devices/{i13_1 → beamlines/i13_1}/merlin.py

@@ -2,7 +2,7 @@ from ophyd_async.core import PathProvider, StandardDetector
 from ophyd_async.epics import adcore
 
 from dodal.common.beamlines.device_helpers import CAM_SUFFIX, HDF5_SUFFIX
-from dodal.devices.i13_1.merlin_controller import MerlinController
+from dodal.devices.beamlines.i13_1.merlin_controller import MerlinController
 
 
 class Merlin(StandardDetector):

dodal/devices/{i15 → beamlines/i15}/dcm.py

@@ -23,8 +23,7 @@ class ThetaRollYZCrystal(ThetaYCrystal):
 
 
 class DCM(DoubleCrystalMonochromatorBase[ThetaRollYZCrystal, ThetaYCrystal]):
-    """
-    A double crystal monochromator device, used to select the beam energy.
+    """A double crystal monochromator device, used to select the beam energy.
 
     Once the i15 DCM supports all of the PVs required by DoubleCrystalMonochromator or
     DoubleCrystalMonochromatorWithDSpacing this class can be changed to inherit from it,

dodal/devices/{i15 → beamlines/i15}/focussing_mirror.py

@@ -3,7 +3,7 @@ from ophyd_async.epics.motor import Motor
 
 
 class FocusingMirrorBase(StandardReadable):
-    """Focusing Mirror with curve, ellip & pitch"""
+    """Focusing Mirror with curve, ellip & pitch."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():
@@ -15,7 +15,7 @@ class FocusingMirrorBase(StandardReadable):
 
 
 class FocusingMirrorHorizontal(FocusingMirrorBase):
-    """Focusing Mirror with curve, ellip, pitch & X"""
+    """Focusing Mirror with curve, ellip, pitch & X."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():
@@ -25,7 +25,7 @@ class FocusingMirrorHorizontal(FocusingMirrorBase):
 
 
 class FocusingMirrorVertical(FocusingMirrorBase):
-    """Focusing Mirror with curve, ellip, pitch & Y"""
+    """Focusing Mirror with curve, ellip, pitch & Y."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():
@@ -35,7 +35,7 @@ class FocusingMirrorVertical(FocusingMirrorBase):
 
 
 class FocusingMirror(FocusingMirrorBase):
-    """Focusing Mirror with curve, ellip, pitch, yaw, X & Y"""
+    """Focusing Mirror with curve, ellip, pitch, yaw, X & Y."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():
@@ -47,7 +47,7 @@ class FocusingMirror(FocusingMirrorBase):
 
 
 class FocusingMirrorWithRoll(FocusingMirror):
-    """Focusing Mirror with curve, ellip, pitch, roll, yaw, X & Y"""
+    """Focusing Mirror with curve, ellip, pitch, roll, yaw, X & Y."""
 
     def __init__(self, prefix: str, name: str = "") -> None:
         with self.add_children_as_readables():

dodal/devices/{i15 → beamlines/i15}/jack.py

@@ -3,7 +3,7 @@ from ophyd_async.epics.motor import Motor
 
 
 class JackX(StandardReadable):
-    """Focusing Mirror"""
+    """Focusing Mirror."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():
@@ -17,7 +17,7 @@ class JackX(StandardReadable):
 
 
 class JackY(StandardReadable):
-    """Focusing Mirror"""
+    """Focusing Mirror."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():

dodal/devices/{i15 → beamlines/i15}/multilayer_mirror.py

@@ -3,7 +3,7 @@ from ophyd_async.epics.motor import Motor
 
 
 class MultiLayerMirror(StandardReadable):
-    """Multilayer Mirror"""
+    """Multilayer Mirror."""
 
     def __init__(self, prefix: str, name: str = ""):
         with self.add_children_as_readables():

dodal/devices/{i17 → beamlines/i17}/i17_apple2.py

@@ -17,9 +17,17 @@ MAXIMUM_MOVE_TIME = 550  # There is no useful movements take longer than this.
 
 
 class I17Apple2Controller(Apple2Controller[Apple2[UndulatorPhaseAxes]]):
-    """
-    I10Apple2Controller is a extension of Apple2Controller which provide linear
+    """I17Apple2Controller is a extension of Apple2Controller which provide linear
     arbitrary angle control.
+
+    Args:
+        apple2 (Apple2): An Apple2 device.
+        gap_energy_motor_lut (EnergyMotorLookup): The class that handles the gap
+            look up table logic for the insertion device.
+        phase_energy_motor_lut (EnergyMotorLookup): The class that handles the phase
+            look up table logic for the insertion device.
+        units (str, optional): The units of this device. Defaults to eV.
+        name (str, optional): New device name.
     """
 
     def __init__(
@@ -30,20 +38,6 @@ class I17Apple2Controller(Apple2Controller[Apple2[UndulatorPhaseAxes]]):
         units: str = "eV",
         name: str = "",
     ) -> None:
-        """
-        Parameters:
-        -----------
-        apple2 : Apple2
-            An Apple2 device.
-        gap_energy_motor_lut: EnergyMotorLookup
-            The class that handles the gap look up table logic for the insertion device.
-        phase_energy_motor_lut: EnergyMotorLookup
-            The class that handles the phase look up table logic for the insertion device.
-        units:
-            the units of this device. Defaults to eV.
-        name : str, optional
-            New device name.
-        """
         self.gap_energy_motor_lut = gap_energy_motor_lut
         self.phase_energy_motor_lut = phase_energy_motor_lut
         super().__init__(

dodal/devices/{i18 → beamlines/i18}/diode.py

@@ -5,7 +5,7 @@ from dodal.devices.positioner import create_positioner
 
 
 class FilterAValues(StrictEnum):
-    """Maps from a short usable name to the string name in EPICS"""
+    """Maps from a short usable name to the string name in EPICS."""
 
     AL_2MM = "2 mm Al"
     AL_1_5MM = "1.5 mm Al"