django-spire 0.23.7__py3-none-any.whl → 0.23.8__py3-none-any.whl

django_spire/auth/group/tests/test_views.py

@@ -0,0 +1,377 @@
+from __future__ import annotations
+
+from django.urls import reverse
+
+from django_spire.auth.group.models import AuthGroup
+from django_spire.auth.user.tests.factories import create_user
+from django_spire.core.tests.test_cases import BaseTestCase
+
+
+class GroupPageViewsTestCase(BaseTestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.group = AuthGroup.objects.create(name='Test Group')
+
+    def test_list_view_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        assert response.status_code == 403
+
+    def test_list_view_with_permission(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        assert response.status_code == 200
+
+    def test_list_view_context_contains_groups(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        assert 'group_list' in response.context
+
+    def test_list_view_contains_created_group(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        group_names = [g.name for g in response.context['group_list']]
+        assert 'Test Group' in group_names
+
+    def test_detail_view_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 403
+
+    def test_detail_view_with_permission(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 200
+
+    def test_detail_view_context_contains_group(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert 'group' in response.context
+        assert response.context['group'] == self.group
+
+    def test_detail_view_404_for_nonexistent_group(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_detail_view_contains_permission_data(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert 'permission_data' in response.context
+
+    def test_detail_view_contains_user_lists(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert 'active_user_list' in response.context
+        assert 'inactive_user_list' in response.context
+
+    def test_list_view_contains_permission_data(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        assert 'group_list_permission_data' in response.context
+
+    def test_list_view_multiple_groups(self) -> None:
+        AuthGroup.objects.create(name='Group 2')
+        AuthGroup.objects.create(name='Group 3')
+        response = self.client.get(reverse('django_spire:auth:group:page:list'))
+        assert len(response.context['group_list']) >= 3
+
+    def test_detail_view_with_users_in_group(self) -> None:
+        user = create_user(username='groupmember')
+        self.group.user_set.add(user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 200
+
+    def test_detail_view_separates_active_inactive_users(self) -> None:
+        active_user = create_user(username='activeuser', is_active=True)
+        inactive_user = create_user(username='inactiveuser', is_active=False)
+        self.group.user_set.add(active_user, inactive_user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:page:detail', kwargs={'pk': self.group.pk})
+        )
+        active_ids = [u.pk for u in response.context['active_user_list']]
+        inactive_ids = [u.pk for u in response.context['inactive_user_list']]
+        assert active_user.pk in active_ids
+        assert inactive_user.pk in inactive_ids
+
+
+class GroupFormViewsTestCase(BaseTestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.group = AuthGroup.objects.create(name='Test Group')
+
+    def test_add_form_view_get(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:group:form:add'))
+        assert response.status_code == 200
+
+    def test_add_form_view_post_creates_group(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': 'New Group'}
+        )
+        assert response.status_code == 302
+        assert AuthGroup.objects.filter(name='New Group').exists()
+
+    def test_add_form_view_post_invalid_name(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': 'All Users'}
+        )
+        assert response.status_code == 200
+        assert not AuthGroup.objects.filter(name='All Users').exists()
+
+    def test_add_form_view_post_empty_name(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': ''}
+        )
+        assert response.status_code == 200
+
+    def test_update_form_view_get(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:update', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 200
+
+    def test_update_form_view_post_updates_group(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:update', kwargs={'pk': self.group.pk}),
+            data={'name': 'Updated Group'}
+        )
+        assert response.status_code == 302
+        self.group.refresh_from_db()
+        assert self.group.name == 'Updated Group'
+
+    def test_update_form_view_nonexistent_group_returns_200(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:update', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 200
+
+    def test_delete_form_view_get(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:delete', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 200
+
+    def test_delete_form_view_404(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:delete', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_user_form_view_get(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:user', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 200
+
+    def test_user_form_view_404(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:user', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_add_form_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(reverse('django_spire:auth:group:form:add'))
+        assert response.status_code == 403
+
+    def test_update_form_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:update', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 403
+
+    def test_delete_form_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:delete', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 403
+
+    def test_user_form_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.get(
+            reverse('django_spire:auth:group:form:user', kwargs={'pk': self.group.pk})
+        )
+        assert response.status_code == 403
+
+    def test_add_form_view_post_duplicate_name(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': 'Test Group'}
+        )
+        assert response.status_code == 200
+
+    def test_update_form_view_post_to_reserved_name(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:update', kwargs={'pk': self.group.pk}),
+            data={'name': 'All Users'}
+        )
+        assert response.status_code == 200
+        self.group.refresh_from_db()
+        assert self.group.name != 'All Users'
+
+    def test_add_form_view_post_unicode_name(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': 'Tëst Grøup 日本語'}
+        )
+        assert response.status_code == 302
+        assert AuthGroup.objects.filter(name='Tëst Grøup 日本語').exists()
+
+    def test_add_form_view_post_special_characters(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:add'),
+            data={'name': 'Group & Co <Test>'}
+        )
+        assert response.status_code == 302
+
+    def test_user_form_view_post_adds_users(self) -> None:
+        user = create_user(username='newgroupuser')
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:user', kwargs={'pk': self.group.pk}),
+            data={'users': [user.pk]}
+        )
+        assert response.status_code == 302
+        assert user in self.group.user_set.all()
+
+    def test_user_form_view_post_removes_users(self) -> None:
+        user = create_user(username='removeuser')
+        self.group.user_set.add(user)
+        response = self.client.post(
+            reverse('django_spire:auth:group:form:user', kwargs={'pk': self.group.pk}),
+            data={'users': []}
+        )
+        assert response.status_code == 302
+        assert user not in self.group.user_set.all()
+
+
+class GroupJsonViewsTestCase(BaseTestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.group = AuthGroup.objects.create(name='Test Group')
+
+    def test_permission_form_ajax_invalid_app(self) -> None:
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'invalid_app'}
+            ),
+            data={'perm_level': 'View'},
+            content_type='application/json'
+        )
+        assert response.status_code == 200
+        data = response.json()
+        assert data['status'] == 400
+
+    def test_permission_form_ajax_valid_app(self) -> None:
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'group'}
+            ),
+            data='{"perm_level": "View"}',
+            content_type='application/json'
+        )
+        assert response.status_code == 200
+
+    def test_permission_form_ajax_requires_post(self) -> None:
+        response = self.client.get(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'group'}
+            )
+        )
+        assert response.status_code == 405
+
+    def test_permission_form_ajax_404_group(self) -> None:
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': 99999, 'app_name': 'group'}
+            ),
+            data='{"perm_level": "View"}',
+            content_type='application/json'
+        )
+        assert response.status_code == 404
+
+    def test_special_role_ajax_invalid_app(self) -> None:
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_special_role_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'invalid_app'}
+            ),
+            data='{"codename": "test", "grant_special_role_access": true}',
+            content_type='application/json'
+        )
+        assert response.status_code == 200
+        data = response.json()
+        assert data['status'] == 400
+
+    def test_permission_form_ajax_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'group'}
+            ),
+            data='{"perm_level": "View"}',
+            content_type='application/json'
+        )
+        assert response.status_code == 403
+
+    def test_special_role_ajax_requires_permission(self) -> None:
+        user = create_user(username='normaluser')
+        self.client.force_login(user)
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_special_role_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'group'}
+            ),
+            data='{"codename": "test", "grant_special_role_access": true}',
+            content_type='application/json'
+        )
+        assert response.status_code == 403
+
+    def test_permission_form_ajax_all_perm_levels(self) -> None:
+        for perm_level in ['None', 'View', 'Add', 'Change', 'Delete']:
+            response = self.client.post(
+                reverse(
+                    'django_spire:auth:group:json:group_permission_ajax',
+                    kwargs={'pk': self.group.pk, 'app_name': 'group'}
+                ),
+                data=f'{{"perm_level": "{perm_level}"}}',
+                content_type='application/json'
+            )
+            assert response.status_code == 200
+
+    def test_permission_form_ajax_invalid_perm_level_defaults_to_none(self) -> None:
+        response = self.client.post(
+            reverse(
+                'django_spire:auth:group:json:group_permission_ajax',
+                kwargs={'pk': self.group.pk, 'app_name': 'group'}
+            ),
+            data='{"perm_level": "InvalidLevel"}',
+            content_type='application/json'
+        )
+        assert response.status_code == 200
+        data = response.json()
+        assert data['status'] == 200

django_spire/auth/group/urls/__init__.py

@@ -1,4 +1,6 @@
-from django.urls import path, include
+from __future__ import annotations
+
+from django.urls import include, path
 
 
 app_name = 'group'

django_spire/auth/group/urls/form_urls.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.auth.group.views import form_views

django_spire/auth/group/urls/json_urls.py

@@ -1,7 +1,10 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.auth.group.views import json_views
 
+
 app_name = 'group'
 
 # Group

django_spire/auth/group/urls/page_urls.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.auth.group.views import page_views

django_spire/auth/group/utils.py

@@ -2,7 +2,10 @@ from __future__ import annotations
 
 from typing import TYPE_CHECKING
 
-from django_spire.auth.permissions.consts import VALID_PERMISSION_LEVELS, PERMISSIONS_LEVEL_CHOICES
+from django_spire.auth.permissions.consts import (
+    PERMISSIONS_LEVEL_CHOICES,
+    VALID_PERMISSION_LEVELS
+)
 
 if TYPE_CHECKING:
     from django.contrib.auth.models import Group, User
@@ -31,7 +34,8 @@ def codename_list_to_perm_level(codenames_list: list[str]) -> int:
 def perm_level_to_int(perm_level: VALID_PERMISSION_LEVELS | str) -> int:
     if isinstance(perm_level, int) and 4 >= perm_level >= 0:
         return perm_level
-    elif isinstance(perm_level, str):
+
+    if isinstance(perm_level, str):
         for perm in PERMISSIONS_LEVEL_CHOICES:
             if perm_level.lower() == perm[1].lower():
                 return perm[0]

django_spire/auth/group/views/form_views.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+
 from django.http import HttpResponseRedirect
 from django.shortcuts import get_object_or_404
 from django.urls import reverse
@@ -15,12 +17,13 @@ from django_spire.contrib.form.utils import show_form_errors
 from django_spire.contrib.generic_views import portal_views
 from django_spire.core.shortcuts import get_object_or_null_obj
 from django_spire.history.activity.utils import add_form_activity
-from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from django.core.handlers.wsgi import WSGIRequest
     from django.template.response import TemplateResponse
 
+    from django_spire.contrib.breadcrumb.models import Breadcrumbs
+
 
 @permission_required('django_spire_auth_group.change_authgroup')
 def form_view(
@@ -94,7 +97,7 @@ def user_form_view(
 
     form = forms.GroupUserForm()
 
-    def crumbs(breadcrumbs) -> None:
+    def crumbs(breadcrumbs: Breadcrumbs) -> None:
         breadcrumbs.add_breadcrumb(name='Edit Users')
 
     context_data = {
@@ -160,7 +163,7 @@ def group_remove_user_form_view(
 
     form = DeleteConfirmationForm(request.GET, obj=user)
 
-    def get_breadcrumbs(breadcrumbs) -> None:
+    def get_breadcrumbs(breadcrumbs: Breadcrumbs) -> None:
         breadcrumbs = group.breadcrumbs()
         breadcrumbs.add_breadcrumb(name=user.get_full_name())
         breadcrumbs.add_breadcrumb(name='Remove')

django_spire/auth/group/views/json_views.py

@@ -1,6 +1,7 @@
 from __future__ import annotations
 
-from django.core.handlers.wsgi import WSGIRequest
+from typing import TYPE_CHECKING
+
 from django.http import JsonResponse
 from django.shortcuts import get_object_or_404
 from django.views.decorators.http import require_POST
@@ -9,9 +10,12 @@ from django_spire.auth.group import models
 from django_spire.auth.group.utils import perm_level_to_int, perm_level_to_django_permission
 from django_spire.auth.permissions.decorators import permission_required
 from django_spire.auth.permissions.permissions import GroupPermissions
-from django_spire.auth.permissions.tools import generate_model_permissions, generate_model_key_permission_map
+from django_spire.auth.permissions.tools import generate_model_key_permission_map
 from django_spire.core.shortcuts import process_request_body
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+
 
 @require_POST
 @permission_required('django_spire_auth_group.change_authgroup')

django_spire/auth/mfa/admin.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.contrib import admin
 from django.urls import reverse
 from django.utils.html import format_html

django_spire/auth/mfa/apps.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 from django.apps import AppConfig
 
 from django_spire.utils import check_required_apps

django_spire/auth/mfa/forms.py

@@ -4,6 +4,7 @@ from django import forms
 
 class MFAForm(forms.Form):
     pass
+
     # def __init__(self, generated_mfa_code, *args, **kwargs):
     #     super().__init__(*args, **kwargs)
     #

django_spire/auth/mfa/querysets.py

@@ -1,9 +1,16 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+
 from django.db.models import QuerySet
 from django.utils.timezone import localtime
 
+if TYPE_CHECKING:
+    from django.contrib.auth.models import User
+
+    from django_spire.auth.mfa.models import MfaCode
+
 
 class MfaCodeQuerySet(QuerySet):
-    def valid_code(self, user):
-        return self.filter(user=user, expiration_datetime__gte=localtime()).first()
+    def valid_code(self, user: User) -> MfaCode | None:
+        return self.filter(user=user, expiration_datetime__gt=localtime()).first()