django-spire 0.23.7__py3-none-any.whl → 0.23.8__py3-none-any.whl

django_spire/auth/user/tests/test_user_factories.py

@@ -0,0 +1,139 @@
+from __future__ import annotations
+
+from django_spire.auth.user.factories import register_new_user
+from django_spire.auth.user.models import AuthUser
+from django_spire.core.tests.test_cases import BaseTestCase
+
+
+class RegisterNewUserTestCase(BaseTestCase):
+    def test_creates_user(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert isinstance(user, AuthUser) is True
+        assert AuthUser.objects.filter(pk=user.pk).exists() is True
+
+    def test_sets_correct_attributes(self) -> None:
+        user = register_new_user(
+            first_name='John',
+            last_name='Doe',
+            email='john.doe@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.first_name == 'John'
+        assert user.last_name == 'Doe'
+        assert user.email == 'john.doe@example.com'
+
+    def test_username_is_lowercase_email(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='Test.User@Example.COM',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.username == 'test.user@example.com'
+        assert user.email == 'test.user@example.com'
+
+    def test_password_is_set(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.check_password('securepassword123') is True
+
+    def test_password_is_hashed(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.password != 'securepassword123'  # noqa: S106
+
+    def test_user_is_active_by_default(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.is_active is True
+
+    def test_user_is_not_staff_by_default(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.is_staff is False
+
+    def test_user_is_not_superuser_by_default(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.is_superuser is False
+
+    def test_empty_first_name(self) -> None:
+        user = register_new_user(
+            first_name='',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.first_name == ''
+
+    def test_empty_last_name(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.last_name == ''
+
+    def test_unicode_names(self) -> None:
+        user = register_new_user(
+            first_name='Tëst',
+            last_name='Üser',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.first_name == 'Tëst'
+        assert user.last_name == 'Üser'
+
+    def test_long_password(self) -> None:
+        long_password = 'a' * 100
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password=long_password
+        )
+        assert user.check_password(long_password) is True
+
+    def test_special_characters_in_email(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test+special@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.email == 'test+special@example.com'
+
+    def test_wrong_password_fails(self) -> None:
+        user = register_new_user(
+            first_name='Test',
+            last_name='User',
+            email='test@example.com',
+            password='securepassword123'  # noqa: S106
+        )
+        assert user.check_password('wrongpassword') is False

django_spire/auth/user/tests/test_views.py

@@ -0,0 +1,363 @@
+from __future__ import annotations
+
+from django.urls import reverse
+
+from django_spire.auth.group.models import AuthGroup
+from django_spire.auth.user.models import AuthUser
+from django_spire.auth.user.tests.factories import create_user
+from django_spire.core.tests.test_cases import BaseTestCase
+
+
+class UserPageViewsTestCase(BaseTestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.user = create_user(
+            username='testuser',
+            first_name='Test',
+            last_name='User',
+            email='test@example.com'
+        )
+
+    def test_list_view_requires_permission(self) -> None:
+        normal_user = create_user(username='normaluser')
+        self.client.force_login(normal_user)
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        assert response.status_code == 403
+
+    def test_list_view_with_permission(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        assert response.status_code == 200
+
+    def test_list_view_context_contains_users(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        assert 'active_user_list' in response.context
+        assert 'inactive_user_list' in response.context
+
+    def test_list_view_separates_active_inactive(self) -> None:
+        inactive_user = create_user(username='inactiveuser', is_active=False)
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        active_ids = [u.pk for u in response.context['active_user_list']]
+        inactive_ids = [u.pk for u in response.context['inactive_user_list']]
+        assert inactive_user.pk in inactive_ids
+        assert inactive_user.pk not in active_ids
+
+    def test_detail_view_requires_permission(self) -> None:
+        normal_user = create_user(username='normaluser')
+        self.client.force_login(normal_user)
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 403
+
+    def test_detail_view_with_permission(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 200
+
+    def test_detail_view_context_contains_user(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert 'user' in response.context
+
+    def test_detail_view_context_contains_groups(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert 'group_list' in response.context
+
+    def test_detail_view_context_contains_permissions(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert 'user_perm_data' in response.context
+
+    def test_detail_view_404_for_nonexistent_user(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_list_view_contains_active_user(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        active_ids = [u.pk for u in response.context['active_user_list']]
+        assert self.user.pk in active_ids
+
+    def test_list_view_pagination(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        assert 'active_user_list' in response.context
+        assert hasattr(response.context['active_user_list'], 'paginator')
+
+    def test_detail_view_with_groups(self) -> None:
+        group = AuthGroup.objects.create(name='Test Group')
+        self.user.groups.add(group)
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 200
+        assert group in response.context['group_list']
+
+    def test_detail_view_context_contains_group_permission_data(self) -> None:
+        group = AuthGroup.objects.create(name='Test Group')
+        self.user.groups.add(group)
+        response = self.client.get(
+            reverse('django_spire:auth:user:page:detail', kwargs={'pk': self.user.pk})
+        )
+        assert 'group_list_permission_data' in response.context
+
+    def test_list_view_multiple_users(self) -> None:
+        create_user(username='user1', first_name='User', last_name='One')
+        create_user(username='user2', first_name='User', last_name='Two')
+        response = self.client.get(reverse('django_spire:auth:user:page:list'))
+        assert len(response.context['active_user_list']) >= 2
+
+
+class UserFormViewsTestCase(BaseTestCase):
+    def setUp(self) -> None:
+        super().setUp()
+
+        self.user = create_user(
+            username='testuser',
+            first_name='Test',
+            last_name='User',
+            email='test@example.com'
+        )
+
+    def test_register_form_view_get(self) -> None:
+        response = self.client.get(reverse('django_spire:auth:user:form:register'))
+        assert response.status_code == 200
+
+    def test_register_form_view_post_creates_user(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'newuser@example.com',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 302
+        assert AuthUser.objects.filter(email='newuser@example.com').exists()
+
+    def test_register_form_view_post_invalid_password(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'newuser@example.com',
+                'password': 'short'
+            }
+        )
+        assert response.status_code == 200
+        assert not AuthUser.objects.filter(email='newuser@example.com').exists()
+
+    def test_register_form_view_post_invalid_email(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'invalid-email',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 200
+
+    def test_register_form_requires_permission(self) -> None:
+        normal_user = create_user(username='normaluser')
+        self.client.force_login(normal_user)
+        response = self.client.get(reverse('django_spire:auth:user:form:register'))
+        assert response.status_code == 403
+
+    def test_update_form_view_get(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:update', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 200
+
+    def test_update_form_view_404(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:update', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_update_form_requires_permission(self) -> None:
+        normal_user = create_user(username='normaluser')
+        self.client.force_login(normal_user)
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:update', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 403
+
+    def test_group_form_view_get(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 200
+
+    def test_group_form_view_post_updates_groups(self) -> None:
+        group = AuthGroup.objects.create(name='Test Group')
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk}),
+            data={'group_list': [group.pk]}
+        )
+        assert response.status_code == 302
+        self.user.refresh_from_db()
+        assert group in self.user.groups.all()
+
+    def test_group_form_view_post_multiple_groups(self) -> None:
+        group1 = AuthGroup.objects.create(name='Group 1')
+        group2 = AuthGroup.objects.create(name='Group 2')
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk}),
+            data={'group_list': [group1.pk, group2.pk]}
+        )
+        assert response.status_code == 302
+        self.user.refresh_from_db()
+        assert group1 in self.user.groups.all()
+        assert group2 in self.user.groups.all()
+
+    def test_group_form_view_404(self) -> None:
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': 99999})
+        )
+        assert response.status_code == 404
+
+    def test_group_form_requires_permission(self) -> None:
+        normal_user = create_user(username='normaluser')
+        self.client.force_login(normal_user)
+        response = self.client.get(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk})
+        )
+        assert response.status_code == 403
+
+    def test_register_form_view_post_empty_password(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'newuser@example.com',
+                'password': ''
+            }
+        )
+        assert response.status_code == 200
+
+    def test_register_form_view_post_empty_email(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': '',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 200
+
+    def test_register_form_view_post_unicode_names(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'Tëst',
+                'last_name': 'Üsér',
+                'email': 'unicode@example.com',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 302
+        user = AuthUser.objects.get(email='unicode@example.com')
+        assert user.first_name == 'Tëst'
+        assert user.last_name == 'Üsér'
+
+    def test_group_form_view_post_removes_existing_groups(self) -> None:
+        group1 = AuthGroup.objects.create(name='Group 1')
+        group2 = AuthGroup.objects.create(name='Group 2')
+        self.user.groups.add(group1)
+
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk}),
+            data={'group_list': [group2.pk]}
+        )
+        assert response.status_code == 302
+        self.user.refresh_from_db()
+        assert group1 not in self.user.groups.all()
+        assert group2 in self.user.groups.all()
+
+    def test_group_form_view_post_invalid_group_id(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk}),
+            data={'group_list': [99999]}
+        )
+        assert response.status_code == 200
+
+    def test_register_redirects_after_success(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'newuser@example.com',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 302
+        assert 'list' in response.url or 'user' in response.url
+
+    def test_group_form_redirects_after_success(self) -> None:
+        group = AuthGroup.objects.create(name='Test Group')
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:group_form', kwargs={'pk': self.user.pk}),
+            data={'group_list': [group.pk]}
+        )
+        assert response.status_code == 302
+        assert str(self.user.pk) in response.url
+
+    def test_update_form_view_post_updates_user(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:update', kwargs={'pk': self.user.pk}),
+            data={
+                'first_name': 'Updated',
+                'last_name': 'Name',
+                'email': 'updated@example.com',
+                'is_active': True
+            }
+        )
+        assert response.status_code == 302
+        self.user.refresh_from_db()
+        assert self.user.first_name == 'Updated'
+        assert self.user.last_name == 'Name'
+        assert self.user.email == 'updated@example.com'
+
+    def test_update_form_view_post_deactivates_user(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:update', kwargs={'pk': self.user.pk}),
+            data={
+                'first_name': 'Test',
+                'last_name': 'User',
+                'email': 'test@example.com',
+                'is_active': False
+            }
+        )
+        assert response.status_code == 302
+        self.user.refresh_from_db()
+        assert not self.user.is_active
+
+    def test_register_form_adds_to_all_users_group(self) -> None:
+        response = self.client.post(
+            reverse('django_spire:auth:user:form:register'),
+            data={
+                'first_name': 'New',
+                'last_name': 'User',
+                'email': 'newuser@example.com',
+                'password': 'securepassword123'
+            }
+        )
+        assert response.status_code == 302
+        user = AuthUser.objects.get(email='newuser@example.com')
+        group_names = [g.name for g in user.groups.all()]
+        assert 'All Users' in group_names

django_spire/auth/user/tools.py

@@ -1,5 +1,11 @@
+from __future__ import annotations
+
+from typing import TYPE_CHECKING
+
 from django.contrib.auth.models import Group
-from django_spire.auth.user.models import AuthUser
+
+if TYPE_CHECKING:
+    from django_spire.auth.user.models import AuthUser
 
 
 def add_user_to_all_user_group(user: AuthUser):

django_spire/auth/user/urls/form_urls.py

@@ -1,7 +1,10 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.auth.user.views import form_views
 
+
 app_name = 'form'
 
 urlpatterns = [

django_spire/auth/user/urls/page_urls.py

@@ -1,7 +1,10 @@
+from __future__ import annotations
+
 from django.urls import path
 
 from django_spire.auth.user.views import page_views
 
+
 app_name = 'page'
 
 urlpatterns = [

django_spire/auth/user/views/form_views.py

@@ -3,11 +3,12 @@ from __future__ import annotations
 import json
 
 import django_glue as dg
-from django.contrib.auth.decorators import login_required
+
 from django.core.serializers.json import DjangoJSONEncoder
 from django.http import HttpResponseRedirect
 from django.shortcuts import get_object_or_404
 from django.urls import reverse
+
 from django_glue.utils import serialize_to_json
 
 from django_spire.auth.group.models import AuthGroup
@@ -16,15 +17,18 @@ from django_spire.auth.user import forms
 from django_spire.auth.user.models import AuthUser
 from django_spire.auth.user.tools import add_user_to_all_user_group
 from django_spire.contrib import Breadcrumbs
-from django_spire.contrib.form.confirmation_forms import DeleteConfirmationForm, ConfirmationForm
 from django_spire.contrib.form.utils import show_form_errors
 from django_spire.contrib.generic_views import portal_views
-from django_spire.core.redirect import safe_redirect_url
 from django_spire.history.activity.utils import add_form_activity
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+    from django.template.response import TemplateResponse
 
 
 @permission_required('django_spire_auth_user.add_authuser')
-def register_form_view(request):
+def register_form_view(request: WSGIRequest) -> TemplateResponse:
     portal_user = AuthUser()
     dg.glue_model_object(request, 'portal_user', portal_user, 'view')
 
@@ -44,7 +48,7 @@ def register_form_view(request):
         user_form = forms.RegisterUserForm(instance=portal_user)
 
     context_data = {
-        # Todo: Function that takes in all of the forms and dumps the data here?
+        # TODO: Function that takes in all of the forms and dumps the data here?
         'user_form_data': json.dumps(user_form.data, cls=DjangoJSONEncoder),
     }
 
@@ -63,7 +67,7 @@ def register_form_view(request):
 
 
 @permission_required('django_spire_auth_user.change_authuser')
-def form_view(request, pk):
+def form_view(request: WSGIRequest, pk: int) -> TemplateResponse:
     portal_user = get_object_or_404(AuthUser, pk=pk)
     dg.glue_model_object(request, 'portal_user', portal_user, 'view')
 
@@ -74,7 +78,12 @@ def form_view(request, pk):
             portal_user = form.save()
             add_form_activity(portal_user, pk, request.user)
 
-            return HttpResponseRedirect(reverse('django_spire:auth:user:page:detail', kwargs={'pk': pk}))
+            return HttpResponseRedirect(
+                reverse(
+                    'django_spire:auth:user:page:detail',
+                    kwargs={'pk': pk}
+                )
+            )
     else:
         form = forms.UserForm(instance=portal_user)
 
@@ -93,7 +102,7 @@ def form_view(request, pk):
 
 
 @permission_required('django_spire_auth_group.change_authgroup')
-def group_form_view(request, pk):
+def group_form_view(request: WSGIRequest, pk: int) -> TemplateResponse:
     user = get_object_or_404(AuthUser, pk=pk)
     dg.glue_query_set(request, 'group_choices', AuthGroup.objects.all())
     selected_group_ids = [group.pk for group in user.groups.all()]
@@ -104,8 +113,8 @@ def group_form_view(request, pk):
         if form.is_valid():
             user.groups.set(form.cleaned_data['group_list'])
             return HttpResponseRedirect(reverse('django_spire:auth:user:page:detail', kwargs={'pk': pk}))
-        else:
-            show_form_errors(request, form)
+
+        show_form_errors(request, form)
 
     form = forms.UserGroupForm()
 

django_spire/auth/user/views/page_views.py

@@ -1,5 +1,7 @@
 from __future__ import annotations
 
+from typing import TYPE_CHECKING
+
 from django.shortcuts import get_object_or_404
 
 from django_spire.auth.permissions.decorators import permission_required
@@ -8,9 +10,13 @@ from django_spire.contrib.pagination.pagination import paginate_list
 from django_spire.auth.user.models import AuthUser
 from django_spire.contrib.generic_views import portal_views
 
+if TYPE_CHECKING:
+    from django.core.handlers.wsgi import WSGIRequest
+    from django.template.response import TemplateResponse
+
 
 @permission_required('django_spire_auth_user.view_authuser')
-def detail_view(request, pk):
+def detail_view(request: WSGIRequest, pk: int) -> TemplateResponse:
     user = get_object_or_404(AuthUser, pk=pk)
     group_list = user.groups.all()
 
@@ -30,7 +36,7 @@ def detail_view(request, pk):
 
 
 @permission_required('django_spire_auth_user.view_authuser')
-def list_view(request):
+def list_view(request: WSGIRequest) -> TemplateResponse:
     active_user_list = AuthUser.objects.filter(is_active=True).prefetch_related('groups').order_by('first_name', 'last_name')
     inactive_user_list = AuthUser.objects.filter(is_active=False).prefetch_related('groups').order_by('first_name', 'last_name')