claude-mpm 4.14.7__py3-none-any.whl → 4.14.8__py3-none-any.whl

claude_mpm/services/diagnostics/checks/mcp_check.py

@@ -9,6 +9,8 @@ import json
 import subprocess
 from pathlib import Path
 
+from claude_mpm.core.enums import ServiceState
+
 from ..models import DiagnosticResult, DiagnosticStatus
 from .base_check import BaseDiagnosticCheck
 
@@ -226,18 +228,18 @@ class MCPCheck(BaseDiagnosticCheck):
             )
 
             if result.returncode == 0:
-                if "running" in result.stdout.lower():
+                if ServiceState.RUNNING.value in result.stdout.lower():
                     return DiagnosticResult(
                         category="MCP Server Status",
                         status=DiagnosticStatus.OK,
                         message="MCP server is running",
-                        details={"running": True},
+                        details={"running": True, "state": ServiceState.RUNNING},
                     )
                 return DiagnosticResult(
                     category="MCP Server Status",
                     status=DiagnosticStatus.WARNING,
                     message="MCP server not running",
-                    details={"running": False},
+                    details={"running": False, "state": ServiceState.STOPPED},
                     fix_command="claude-mpm mcp start",
                     fix_description="Start the MCP server",
                 )
@@ -245,7 +247,11 @@ class MCPCheck(BaseDiagnosticCheck):
                 category="MCP Server Status",
                 status=DiagnosticStatus.WARNING,
                 message="Could not determine server status",
-                details={"running": "unknown", "error": result.stderr},
+                details={
+                    "running": "unknown",
+                    "state": ServiceState.UNKNOWN,
+                    "error": result.stderr,
+                },
             )
 
         except subprocess.TimeoutExpired:
@@ -253,14 +259,22 @@ class MCPCheck(BaseDiagnosticCheck):
                 category="MCP Server Status",
                 status=DiagnosticStatus.WARNING,
                 message="Server status check timed out",
-                details={"running": "unknown", "error": "timeout"},
+                details={
+                    "running": "unknown",
+                    "state": ServiceState.UNKNOWN,
+                    "error": "timeout",
+                },
             )
         except Exception as e:
             return DiagnosticResult(
                 category="MCP Server Status",
                 status=DiagnosticStatus.WARNING,
                 message=f"Could not check server status: {e!s}",
-                details={"running": "unknown", "error": str(e)},
+                details={
+                    "running": "unknown",
+                    "state": ServiceState.UNKNOWN,
+                    "error": str(e),
+                },
             )
 
     def _check_startup_verification(self) -> DiagnosticResult:

claude_mpm/services/mcp_gateway/tools/health_check_tool.py

@@ -26,6 +26,7 @@ from typing import Any, Dict
 import psutil
 
 from claude_mpm.config.paths import paths
+from claude_mpm.core.enums import OperationResult, ServiceState
 from claude_mpm.core.logger import get_logger
 from claude_mpm.services.mcp_gateway.core.interfaces import (
     MCPToolDefinition,
@@ -168,20 +169,20 @@ class HealthCheckTool(BaseToolAdapter):
                 if i < len(check_results):
                     if isinstance(check_results[i], Exception):
                         results["checks"][check_name] = {
-                            "status": "error",
+                            "status": OperationResult.ERROR,
                             "error": str(check_results[i]),
                         }
                     else:
                         results["checks"][check_name] = check_results[i]
                 else:
                     results["checks"][check_name] = {
-                        "status": "timeout",
+                        "status": OperationResult.TIMEOUT,
                         "error": "Check timed out",
                     }
 
         except asyncio.TimeoutError:
             results["checks"]["timeout"] = {
-                "status": "error",
+                "status": OperationResult.ERROR,
                 "error": f"Health checks timed out after {timeout} seconds",
             }
 
@@ -194,7 +195,7 @@ class HealthCheckTool(BaseToolAdapter):
     async def _check_system_health(self, detailed: bool) -> Dict[str, Any]:
         """Check system health (CPU, memory, disk, etc.)."""
         check_result = {
-            "status": "healthy",
+            "status": ServiceState.RUNNING,
             "checks": {},
             "warnings": [],
             "errors": [],
@@ -270,7 +271,7 @@ class HealthCheckTool(BaseToolAdapter):
     async def _check_gateway_health(self, detailed: bool) -> Dict[str, Any]:
         """Check MCP Gateway health."""
         check_result = {
-            "status": "healthy",
+            "status": ServiceState.RUNNING,
             "checks": {},
             "warnings": [],
             "errors": [],
@@ -313,7 +314,7 @@ class HealthCheckTool(BaseToolAdapter):
     async def _check_tools_health(self, detailed: bool) -> Dict[str, Any]:
         """Check MCP tools health."""
         check_result = {
-            "status": "healthy",
+            "status": ServiceState.RUNNING,
             "checks": {},
             "warnings": [],
             "errors": [],
@@ -365,7 +366,7 @@ class HealthCheckTool(BaseToolAdapter):
     async def _check_config_health(self, detailed: bool) -> Dict[str, Any]:
         """Check configuration health."""
         check_result = {
-            "status": "healthy",
+            "status": ServiceState.RUNNING,
             "checks": {},
             "warnings": [],
             "errors": [],

claude_mpm/services/memory_hook_service.py

@@ -11,6 +11,7 @@ Extracted from ClaudeRunner to follow Single Responsibility Principle.
 from typing import Any, Dict
 
 from claude_mpm.core.base_service import BaseService
+from claude_mpm.core.enums import ServiceState
 from claude_mpm.services.core.interfaces import MemoryHookInterface
 
 
@@ -463,5 +464,7 @@ class MemoryHookService(BaseService, MemoryHookInterface):
             "hook_service_available": self.hook_service is not None,
             "memory_enabled": self.is_memory_enabled(),
             "total_hooks": len(self.registered_hooks),
-            "status": "active" if self.registered_hooks else "inactive",
+            "status": (
+                ServiceState.RUNNING if self.registered_hooks else ServiceState.IDLE
+            ),
         }

claude_mpm/services/monitor/daemon_manager.py

@@ -31,6 +31,7 @@ import time
 from pathlib import Path
 from typing import Optional, Tuple
 
+from ...core.enums import OperationResult
 from ...core.logging_config import get_logger
 
 
@@ -906,7 +907,7 @@ class DaemonManager:
                     with self.startup_status_file.open() as f:
                         status = f.read().strip()
 
-                    if status == "success":
+                    if status == OperationResult.SUCCESS:
                         # Cleanup status file
                         Path(self.startup_status_file).unlink(missing_ok=True)
                         return True
@@ -936,7 +937,7 @@ class DaemonManager:
                 # Don't check if file exists - we need to write to it regardless
                 # The parent created it and is waiting for us to update it
                 with self.startup_status_file.open("w") as f:
-                    f.write("success")
+                    f.write(OperationResult.SUCCESS)
                     f.flush()  # Ensure it's written immediately
                     os.fsync(f.fileno())  # Force write to disk
             except Exception:

claude_mpm/services/monitor/handlers/dashboard.py

@@ -18,6 +18,7 @@ from typing import Dict, Set
 
 import socketio
 
+from ....core.enums import ServiceState
 from ....core.logging_config import get_logger
 
 
@@ -128,7 +129,7 @@ class DashboardHandler:
         try:
             status = {
                 "service": "unified-monitor",
-                "status": "running",
+                "status": ServiceState.RUNNING,
                 "clients_connected": len(self.connected_clients),
                 "uptime": asyncio.get_event_loop().time(),
                 "features": {

claude_mpm/services/monitor/handlers/hooks.py

@@ -19,6 +19,7 @@ from typing import Dict, List
 
 import socketio
 
+from ....core.enums import ServiceState
 from ....core.logging_config import get_logger
 
 
@@ -170,7 +171,7 @@ class HookHandler:
             session_info = {
                 "session_id": session_id,
                 "start_time": asyncio.get_event_loop().time(),
-                "status": "active",
+                "status": ServiceState.RUNNING,
                 "event_count": 0,
                 "last_activity": asyncio.get_event_loop().time(),
                 "metadata": data.get("metadata", {}),

claude_mpm/services/monitor/management/lifecycle.py

@@ -23,6 +23,7 @@ import time
 from pathlib import Path
 from typing import Optional, Tuple
 
+from ....core.enums import OperationResult
 from ....core.logging_config import get_logger
 
 
@@ -388,7 +389,7 @@ class DaemonLifecycle:
                     with self.startup_status_file.open() as f:
                         status = f.read().strip()
 
-                    if status == "success":
+                    if status == OperationResult.SUCCESS:
                         # Child started successfully
                         self._cleanup_status_file()
                         return True
@@ -438,7 +439,7 @@ class DaemonLifecycle:
         if self.startup_status_file:
             try:
                 with self.startup_status_file.open("w") as f:
-                    f.write("success")
+                    f.write(OperationResult.SUCCESS)
             except Exception as e:
                 self.logger.error(f"Failed to report startup success: {e}")
 

claude_mpm/services/monitor/server.py

@@ -26,6 +26,7 @@ from typing import Dict, Optional
 import socketio
 from aiohttp import web
 
+from ...core.enums import ServiceState
 from ...core.logging_config import get_logger
 from ...dashboard.api.simple_directory import list_directory
 from .event_emitter import get_event_emitter
@@ -333,7 +334,7 @@ class UnifiedMonitorServer:
 
                 return web.json_response(
                     {
-                        "status": "healthy",
+                        "status": ServiceState.RUNNING,
                         "service": "claude-mpm-monitor",  # Important: must match what is_our_service() checks
                         "version": version,
                         "port": self.port,

claude_mpm/services/session_management_service.py

@@ -17,6 +17,7 @@ from datetime import timezone
 from typing import Any, Dict, List, Optional
 
 from claude_mpm.core.base_service import BaseService
+from claude_mpm.core.enums import OperationResult, ServiceState
 from claude_mpm.services.core.interfaces import SessionManagementInterface
 
 
@@ -223,7 +224,7 @@ class SessionManagementService(BaseService, SessionManagementInterface):
             "id": session_id,
             "config": session_config,
             "start_time": time.time(),
-            "status": "active",
+            "status": ServiceState.RUNNING,
             "type": session_config.get("type", "interactive"),
         }
 
@@ -267,7 +268,7 @@ class SessionManagementService(BaseService, SessionManagementInterface):
             return self.active_sessions[session_id].copy()
         return {
             "id": session_id,
-            "status": "not_found",
+            "status": OperationResult.ERROR,
             "error": "Session not found",
         }
 

claude_mpm/services/socketio/handlers/hook.py

@@ -7,6 +7,7 @@ agent delegations, and other hook-based activity for the system heartbeat.
 from datetime import datetime, timezone
 from typing import Any, Dict
 
+from ....core.enums import ServiceState
 from .base import BaseEventHandler
 
 
@@ -108,7 +109,7 @@ class HookEventHandler(BaseEventHandler):
                 "session_id": session_id,
                 "start_time": datetime.now(timezone.utc).isoformat(),
                 "agent": agent_type,
-                "status": "active",
+                "status": ServiceState.RUNNING,
                 "prompt": data.get("prompt", "")[:100],  # First 100 chars
                 "last_activity": datetime.now(timezone.utc).isoformat(),
             }
@@ -159,7 +160,7 @@ class HookEventHandler(BaseEventHandler):
                     "session_id": session_id,
                     "start_time": datetime.now(timezone.utc).isoformat(),
                     "agent": "pm",  # Default to PM
-                    "status": "active",
+                    "status": ServiceState.RUNNING,
                     "prompt": data.get("prompt_text", "")[:100],
                     "working_directory": data.get("working_directory", ""),
                     "last_activity": datetime.now(timezone.utc).isoformat(),

claude_mpm/services/socketio/server/main.py

@@ -16,6 +16,8 @@ from collections import deque
 from datetime import datetime, timezone
 from typing import Any, Dict, List, Optional, Set
 
+from ....core.enums import ServiceState
+
 try:
     import aiohttp
     import socketio
@@ -384,7 +386,7 @@ class SocketIOServer(SocketIOServiceInterface):
             "session_id": session_id,
             "start_time": datetime.now(timezone.utc).isoformat(),
             "agent": "pm",  # Default to PM, will be updated if delegated
-            "status": "active",
+            "status": ServiceState.RUNNING,
             "launch_method": launch_method,
             "working_dir": working_dir,
         }

claude_mpm/services/subprocess_launcher_service.py

@@ -22,6 +22,7 @@ import tty
 from typing import Any, Dict, List, Optional
 
 from claude_mpm.core.base_service import BaseService
+from claude_mpm.core.enums import OperationResult, ServiceState
 from claude_mpm.services.core.interfaces import SubprocessLauncherInterface
 
 
@@ -62,9 +63,17 @@ class SubprocessLauncherService(BaseService, SubprocessLauncherInterface):
         try:
             env = kwargs.get("env", self.prepare_subprocess_environment())
             self.launch_subprocess_interactive(command, env)
-            return {"status": "launched", "command": command, "method": "interactive"}
+            return {
+                "status": OperationResult.SUCCESS,
+                "command": command,
+                "method": "interactive",
+            }
         except Exception as e:
-            return {"status": "failed", "error": str(e), "command": command}
+            return {
+                "status": OperationResult.FAILED,
+                "error": str(e),
+                "command": command,
+            }
 
     async def launch_subprocess_async(
         self, command: List[str], **kwargs
@@ -109,7 +118,7 @@ class SubprocessLauncherService(BaseService, SubprocessLauncherInterface):
         # For now, return unknown status
         return {
             "process_id": process_id,
-            "status": "unknown",
+            "status": OperationResult.UNKNOWN,
             "message": "Process tracking not implemented",
         }
 
@@ -160,7 +169,7 @@ class SubprocessLauncherService(BaseService, SubprocessLauncherInterface):
             # Notify WebSocket clients
             if self.websocket_server:
                 self.websocket_server.claude_status_changed(
-                    status="running",
+                    status=ServiceState.RUNNING,
                     pid=process.pid,
                     message="Claude subprocess started",
                 )
@@ -195,7 +204,7 @@ class SubprocessLauncherService(BaseService, SubprocessLauncherInterface):
             # Notify WebSocket clients
             if self.websocket_server:
                 self.websocket_server.claude_status_changed(
-                    status="stopped",
+                    status=ServiceState.STOPPED,
                     message=f"Claude subprocess exited with code {process.returncode}",
                 )
 

claude_mpm/services/unified/analyzer_strategies/code_analyzer.py

@@ -14,6 +14,7 @@ import re
 from pathlib import Path
 from typing import Any, Dict, List, Optional
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 from ..strategies import (
@@ -120,7 +121,7 @@ class CodeAnalyzerStrategy(AnalyzerStrategy):
             return self._analyze_ast(target, options)
 
         return {
-            "status": "error",
+            "status": OperationResult.ERROR,
             "message": f"Unsupported target type: {type(target).__name__}",
         }
 
@@ -159,7 +160,7 @@ class CodeAnalyzerStrategy(AnalyzerStrategy):
             metrics["maintainability_index"] = self._calculate_maintainability(metrics)
 
             return {
-                "status": "success",
+                "status": OperationResult.SUCCESS,
                 "type": "file",
                 "path": str(file_path),
                 "metrics": metrics,
@@ -168,7 +169,7 @@ class CodeAnalyzerStrategy(AnalyzerStrategy):
         except Exception as e:
             logger.error(f"Error analyzing file {file_path}: {e}")
             return {
-                "status": "error",
+                "status": OperationResult.ERROR,
                 "path": str(file_path),
                 "error": str(e),
             }
@@ -178,7 +179,7 @@ class CodeAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze all code files in a directory."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "directory",
             "path": str(dir_path),
             "files": [],
@@ -285,7 +286,7 @@ class CodeAnalyzerStrategy(AnalyzerStrategy):
             )
 
         return {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "ast",
             "metrics": metrics,
         }

claude_mpm/services/unified/analyzer_strategies/dependency_analyzer.py

@@ -14,6 +14,7 @@ import re
 from pathlib import Path
 from typing import Any, ClassVar, Dict, List, Optional
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 from ..strategies import (
@@ -166,7 +167,7 @@ class DependencyAnalyzerStrategy(AnalyzerStrategy):
                 return self._analyze_manifest(target_path, options)
 
         return {
-            "status": "error",
+            "status": OperationResult.ERROR,
             "message": f"Unsupported target type: {type(target).__name__}",
         }
 
@@ -175,7 +176,7 @@ class DependencyAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze dependencies in a project directory."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "project",
             "path": str(project_path),
             "package_managers": [],
@@ -221,7 +222,7 @@ class DependencyAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze a specific package manifest file."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "manifest",
             "path": str(manifest_path),
             "dependencies": {},
@@ -238,7 +239,7 @@ class DependencyAnalyzerStrategy(AnalyzerStrategy):
 
         if not manager:
             return {
-                "status": "error",
+                "status": OperationResult.ERROR,
                 "message": f"Unknown manifest file: {manifest_path.name}",
             }
 

claude_mpm/services/unified/analyzer_strategies/performance_analyzer.py

@@ -14,6 +14,7 @@ import re
 from pathlib import Path
 from typing import Any, ClassVar, Dict, List, Optional
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 from ..strategies import (
@@ -188,14 +189,14 @@ class PerformanceAnalyzerStrategy(AnalyzerStrategy):
             return self._analyze_ast_performance(target, options)
 
         return {
-            "status": "error",
+            "status": OperationResult.ERROR,
             "message": f"Unsupported target type: {type(target).__name__}",
         }
 
     def _analyze_file(self, file_path: Path, options: Dict[str, Any]) -> Dict[str, Any]:
         """Analyze a single file for performance issues."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "file",
             "path": str(file_path),
             "issues": [],
@@ -250,7 +251,7 @@ class PerformanceAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze all files in a directory for performance issues."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "directory",
             "path": str(dir_path),
             "files_analyzed": 0,
@@ -654,7 +655,7 @@ class PerformanceAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze performance of an AST node."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "ast",
             "complexity": {},
             "issues": [],

claude_mpm/services/unified/analyzer_strategies/security_analyzer.py

@@ -14,6 +14,7 @@ import re
 from pathlib import Path
 from typing import Any, ClassVar, Dict, List, Optional
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 from ..strategies import (
@@ -198,14 +199,14 @@ class SecurityAnalyzerStrategy(AnalyzerStrategy):
                 return self._analyze_directory(target_path, options)
 
         return {
-            "status": "error",
+            "status": OperationResult.ERROR,
             "message": f"Unsupported target type: {type(target).__name__}",
         }
 
     def _analyze_file(self, file_path: Path, options: Dict[str, Any]) -> Dict[str, Any]:
         """Analyze a single file for security issues."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "file",
             "path": str(file_path),
             "vulnerabilities": [],
@@ -251,7 +252,7 @@ class SecurityAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze all files in a directory for security issues."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "directory",
             "path": str(dir_path),
             "files_analyzed": 0,

claude_mpm/services/unified/analyzer_strategies/structure_analyzer.py

@@ -13,6 +13,7 @@ import fnmatch
 from pathlib import Path
 from typing import Any, ClassVar, Dict, List, Optional, Tuple
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 from ..strategies import (
@@ -174,14 +175,14 @@ class StructureAnalyzerStrategy(AnalyzerStrategy):
 
             if not target_path.is_dir():
                 return {
-                    "status": "error",
+                    "status": OperationResult.ERROR,
                     "message": "Target must be a directory",
                 }
 
             return self._analyze_structure(target_path, options)
 
         return {
-            "status": "error",
+            "status": OperationResult.ERROR,
             "message": f"Unsupported target type: {type(target).__name__}",
         }
 
@@ -190,7 +191,7 @@ class StructureAnalyzerStrategy(AnalyzerStrategy):
     ) -> Dict[str, Any]:
         """Analyze the structure of a project directory."""
         results = {
-            "status": "success",
+            "status": OperationResult.SUCCESS,
             "type": "structure",
             "path": str(root_path),
             "tree": {},

claude_mpm/services/unified/config_strategies/validation_strategy.py

@@ -13,6 +13,7 @@ from enum import Enum
 from pathlib import Path
 from typing import Any, Callable, Dict, List, Optional, Pattern, Union
 
+from claude_mpm.core.enums import ValidationSeverity
 from claude_mpm.core.logging_utils import get_logger
 
 from .unified_config_service import IConfigStrategy
@@ -45,7 +46,7 @@ class ValidationRule:
     type: ValidationType
     params: Dict[str, Any] = field(default_factory=dict)
     message: Optional[str] = None
-    severity: str = "error"  # error, warning, info
+    severity: str = ValidationSeverity.ERROR
     condition: Optional[Callable] = None
 
 
@@ -73,15 +74,18 @@ class BaseValidator(ABC):
         """Perform validation"""
 
     def _create_result(
-        self, valid: bool, message: Optional[str] = None, severity: str = "error"
+        self,
+        valid: bool,
+        message: Optional[str] = None,
+        severity: str = ValidationSeverity.ERROR,
     ) -> ValidationResult:
         """Create validation result"""
         result = ValidationResult(valid=valid)
 
         if not valid and message:
-            if severity == "error":
+            if severity == ValidationSeverity.ERROR:
                 result.errors.append(message)
-            elif severity == "warning":
+            elif severity == ValidationSeverity.WARNING:
                 result.warnings.append(message)
             else:
                 result.info.append(message)
@@ -556,9 +560,9 @@ class DependencyValidator(BaseValidator):
         if errors:
             result = ValidationResult(valid=False)
             for error in errors:
-                if rule.severity == "error":
+                if rule.severity == ValidationSeverity.ERROR:
                     result.errors.append(error)
-                elif rule.severity == "warning":
+                elif rule.severity == ValidationSeverity.WARNING:
                     result.warnings.append(error)
                 else:
                     result.info.append(error)
@@ -721,7 +725,7 @@ class ConditionalValidator(BaseValidator):
             type=ValidationType[rule_def.get("type", "CUSTOM").upper()],
             params=rule_def.get("params", {}),
             message=rule_def.get("message"),
-            severity=rule_def.get("severity", "error"),
+            severity=rule_def.get("severity", ValidationSeverity.ERROR),
         )
 
         # Find appropriate validator
@@ -843,9 +847,9 @@ class CrossFieldValidator(BaseValidator):
         for constraint in constraints:
             if not self._evaluate_constraint(config, constraint):
                 message = constraint.get("message", "Cross-field constraint failed")
-                if rule.severity == "error":
+                if rule.severity == ValidationSeverity.ERROR:
                     result.errors.append(message)
-                elif rule.severity == "warning":
+                elif rule.severity == ValidationSeverity.WARNING:
                     result.warnings.append(message)
                 else:
                     result.info.append(message)