claude-mpm 4.14.7__py3-none-any.whl → 4.14.8__py3-none-any.whl

claude_mpm/core/enums.py

@@ -0,0 +1,322 @@
+"""
+Centralized enums for type-safe string constants across Claude MPM.
+
+This module provides enumerated types to replace magic strings throughout the codebase,
+improving type safety, IDE autocomplete, and preventing typos.
+
+Created: 2025-10-25
+Priority: Phase 1 of systematic enum migration (3-4 week plan)
+Impact: Replaces 2,050+ magic string occurrences
+
+Usage:
+    from claude_mpm.core.enums import OperationResult, OutputFormat, ServiceState
+
+    # Type-safe operation results
+    result = OperationResult.SUCCESS
+    if result == OperationResult.SUCCESS:
+        print("Operation completed successfully")
+
+    # Type-safe output formatting
+    format_type = OutputFormat.JSON
+
+    # Type-safe service state management
+    state = ServiceState.RUNNING
+"""
+
+from enum import StrEnum
+
+
+class OperationResult(StrEnum):
+    """
+    Standard result codes for operations throughout Claude MPM.
+
+    Replaces 876+ occurrences of magic strings like "success", "error", "failed".
+    Used in: CLI commands, service operations, API responses, hook handlers.
+
+    Migration Priority: HIGH (Week 1)
+    Coverage: ~42% of all magic strings
+    """
+
+    SUCCESS = "success"
+    """Operation completed successfully."""
+
+    ERROR = "error"
+    """Operation encountered an error."""
+
+    FAILED = "failed"
+    """Operation failed to complete."""
+
+    PENDING = "pending"
+    """Operation is waiting to execute."""
+
+    COMPLETED = "completed"
+    """Operation has been completed."""
+
+    TIMEOUT = "timeout"
+    """Operation exceeded time limit."""
+
+    CANCELLED = "cancelled"
+    """Operation was cancelled before completion."""
+
+    CONTEXT_READY = "context_ready"
+    """Context is prepared and ready for use."""
+
+    SKIPPED = "skipped"
+    """Operation was intentionally skipped."""
+
+    RETRY = "retry"
+    """Operation should be retried."""
+
+    PARTIAL = "partial"
+    """Operation completed partially."""
+
+    UNKNOWN = "unknown"
+    """Operation result is unknown or indeterminate."""
+
+
+class OutputFormat(StrEnum):
+    """
+    Output format options for CLI commands and logging.
+
+    Replaces 200+ occurrences of format strings.
+    Used in: CLI output, logging, configuration exports, API responses.
+
+    Migration Priority: HIGH (Week 1)
+    Coverage: ~10% of all magic strings
+    """
+
+    JSON = "json"
+    """JavaScript Object Notation format."""
+
+    YAML = "yaml"
+    """YAML Ain't Markup Language format."""
+
+    TEXT = "text"
+    """Plain text format."""
+
+    MARKDOWN = "markdown"
+    """Markdown formatted text."""
+
+    RAW = "raw"
+    """Raw unformatted output."""
+
+    TABLE = "table"
+    """Tabular format for display."""
+
+    CSV = "csv"
+    """Comma-separated values format."""
+
+    HTML = "html"
+    """HyperText Markup Language format."""
+
+    XML = "xml"
+    """eXtensible Markup Language format."""
+
+
+class ServiceState(StrEnum):
+    """
+    Service lifecycle states for all Claude MPM services.
+
+    Replaces 150+ occurrences of service state strings.
+    Used in: Hook services, MCP servers, monitoring, health checks.
+
+    Migration Priority: HIGH (Week 1)
+    Coverage: ~7% of all magic strings
+    """
+
+    STOPPED = "stopped"
+    """Service is completely stopped."""
+
+    STARTING = "starting"
+    """Service is in the process of starting."""
+
+    RUNNING = "running"
+    """Service is actively running."""
+
+    STOPPING = "stopping"
+    """Service is in the process of stopping."""
+
+    RESTARTING = "restarting"
+    """Service is restarting."""
+
+    ERROR = "error"
+    """Service encountered an error."""
+
+    UNKNOWN = "unknown"
+    """Service state cannot be determined."""
+
+    DEGRADED = "degraded"
+    """Service is running but with reduced functionality."""
+
+    IDLE = "idle"
+    """Service is running but not actively processing."""
+
+
+class ValidationSeverity(StrEnum):
+    """
+    Severity levels for validation and error reporting.
+
+    Replaces validation severity strings across validators and error handlers.
+    Used in: Frontmatter validation, API validation, config validation.
+
+    Migration Priority: MEDIUM (Week 2)
+    Coverage: ~5% of all magic strings
+    """
+
+    INFO = "info"
+    """Informational message, no action required."""
+
+    WARNING = "warning"
+    """Warning that should be addressed but not critical."""
+
+    ERROR = "error"
+    """Error that prevents operation completion."""
+
+    CRITICAL = "critical"
+    """Critical error requiring immediate attention."""
+
+    DEBUG = "debug"
+    """Debug-level information for troubleshooting."""
+
+
+class ModelTier(StrEnum):
+    """
+    Claude model tier classifications and identifiers.
+
+    Replaces model name strings and enables model normalization.
+    Used in: Agent configuration, API calls, capability detection.
+
+    Migration Priority: MEDIUM (Week 2)
+    Coverage: ~4% of all magic strings
+
+    Notes:
+        - Replaces manual model normalization code
+        - Enables type-safe model selection
+        - Provides both tier names and full model identifiers
+    """
+
+    # Tier names (simplified)
+    OPUS = "opus"
+    """Claude Opus tier (highest capability)."""
+
+    SONNET = "sonnet"
+    """Claude Sonnet tier (balanced)."""
+
+    HAIKU = "haiku"
+    """Claude Haiku tier (fastest)."""
+
+    # Full model identifiers (Claude 4.x)
+    OPUS_4 = "claude-opus-4-20250514"
+    """Claude 4 Opus - May 2025 release."""
+
+    SONNET_4 = "claude-sonnet-4-20250514"
+    """Claude 4 Sonnet - May 2025 release."""
+
+    SONNET_4_5 = "claude-sonnet-4-5-20250929"
+    """Claude 4.5 Sonnet - September 2025 release."""
+
+    # Legacy model identifiers (Claude 3.x)
+    OPUS_3 = "claude-3-opus-20240229"
+    """Claude 3 Opus - February 2024 release."""
+
+    SONNET_3_5 = "claude-3-5-sonnet-20241022"
+    """Claude 3.5 Sonnet - October 2024 release."""
+
+    HAIKU_3 = "claude-3-haiku-20240307"
+    """Claude 3 Haiku - March 2024 release."""
+
+    @classmethod
+    def normalize(cls, model_name: str) -> "ModelTier":
+        """
+        Normalize a model name to its canonical tier.
+
+        Args:
+            model_name: Any model name variant (e.g., "opus", "claude-opus-4", "OPUS")
+
+        Returns:
+            Normalized ModelTier enum value
+
+        Examples:
+            >>> ModelTier.normalize("OPUS")
+            ModelTier.OPUS
+            >>> ModelTier.normalize("claude-sonnet-4-20250514")
+            ModelTier.SONNET_4
+            >>> ModelTier.normalize("sonnet")
+            ModelTier.SONNET
+        """
+        normalized = model_name.lower().strip()
+
+        # Direct enum value match
+        for tier in cls:
+            if tier.value == normalized:
+                return tier
+
+        # Tier name extraction
+        if "opus" in normalized:
+            return cls.OPUS
+        if "sonnet" in normalized:
+            return cls.SONNET
+        if "haiku" in normalized:
+            return cls.HAIKU
+
+        # Default to sonnet for unknown models
+        return cls.SONNET
+
+
+class AgentCategory(StrEnum):
+    """
+    Agent specialization categories for classification and routing.
+
+    Replaces category strings in agent configurations and routing logic.
+    Used in: Agent templates, capability detection, routing decisions.
+
+    Migration Priority: MEDIUM (Week 3)
+    Coverage: ~3% of all magic strings
+    """
+
+    RESEARCH = "research"
+    """Research and analysis agents."""
+
+    ENGINEERING = "engineering"
+    """Software engineering and implementation agents."""
+
+    QA = "qa"
+    """Quality assurance and testing agents."""
+
+    SECURITY = "security"
+    """Security analysis and vulnerability assessment agents."""
+
+    DOCUMENTATION = "documentation"
+    """Documentation and technical writing agents."""
+
+    OPERATIONS = "operations"
+    """DevOps and infrastructure management agents."""
+
+    DATA = "data"
+    """Data engineering and analytics agents."""
+
+    VERSION_CONTROL = "version_control"
+    """Version control and release management agents."""
+
+    GENERAL = "general"
+    """General-purpose agents without specific specialization."""
+
+    CUSTOM = "custom"
+    """User-defined custom agent categories."""
+
+    PROJECT_MANAGEMENT = "project_management"
+    """Project management and coordination agents."""
+
+    DESIGN = "design"
+    """UI/UX design and frontend agents."""
+
+
+# Export all enums for convenient access
+__all__ = [
+    "AgentCategory",
+    "ModelTier",
+    "OperationResult",
+    "OutputFormat",
+    "ServiceState",
+    "ValidationSeverity",
+]

claude_mpm/core/instruction_reinforcement_hook.py

@@ -21,6 +21,7 @@ import threading
 from datetime import datetime, timezone
 from typing import Any, Dict, List, Optional
 
+from ..core.enums import OperationResult
 from ..core.logger import get_logger
 
 
@@ -158,7 +159,7 @@ class InstructionReinforcementHook:
         # Create reminder todo
         reminder_todo = {
             "content": message,
-            "status": "pending",
+            "status": OperationResult.PENDING,
             "activeForm": "Processing instruction reminder",
         }
 

claude_mpm/core/interactive_session.py

@@ -11,6 +11,7 @@ import uuid
 from pathlib import Path
 from typing import Any, Dict, Optional, Tuple
 
+from claude_mpm.core.enums import ServiceState
 from claude_mpm.core.logger import get_logger
 
 
@@ -179,7 +180,8 @@ class InteractiveSession:
             # Notify WebSocket if connected
             if self.runner.websocket_server:
                 self.runner.websocket_server.claude_status_changed(
-                    status="starting", message="Launching Claude interactive session"
+                    status=ServiceState.STARTING,
+                    message="Launching Claude interactive session",
                 )
 
             # Launch using selected method
@@ -454,7 +456,8 @@ class InteractiveSession:
         # Notify WebSocket before exec
         if self.runner.websocket_server:
             self.runner.websocket_server.claude_status_changed(
-                status="running", message="Claude process started (exec mode)"
+                status=ServiceState.RUNNING,
+                message="Claude process started (exec mode)",
             )
 
         # This will not return if successful
@@ -494,7 +497,7 @@ class InteractiveSession:
         # Notify WebSocket of error
         if self.runner.websocket_server:
             self.runner.websocket_server.claude_status_changed(
-                status="error", message=f"Failed to launch Claude: {error}"
+                status=ServiceState.ERROR, message=f"Failed to launch Claude: {error}"
             )
 
     def _handle_keyboard_interrupt(self) -> None:

claude_mpm/core/logging_config.py

@@ -24,6 +24,7 @@ from contextlib import contextmanager
 from pathlib import Path
 from typing import Any, Dict, Optional, Union
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logger import (
     JsonFormatter,
     finalize_streaming_logs,
@@ -234,7 +235,10 @@ def log_operation(
             execution_time = time.time() - start_time
             logger.info(
                 f"Completed {operation}",
-                extra={"execution_time": execution_time, "status": "success"},
+                extra={
+                    "execution_time": execution_time,
+                    "status": OperationResult.SUCCESS,
+                },
             )
         except Exception as e:
             execution_time = time.time() - start_time
@@ -242,7 +246,7 @@ def log_operation(
                 f"Failed {operation}: {e}",
                 extra={
                     "execution_time": execution_time,
-                    "status": "failure",
+                    "status": OperationResult.FAILED,
                     "error": str(e),
                 },
             )

claude_mpm/core/oneshot_session.py

@@ -12,6 +12,7 @@ import uuid
 from pathlib import Path
 from typing import Any, Dict, Optional, Tuple
 
+from claude_mpm.core.enums import OperationResult, ServiceState
 from claude_mpm.core.logger import get_logger
 
 
@@ -162,7 +163,7 @@ class OneshotSession:
 
         if self.runner.websocket_server:
             self.runner.websocket_server.claude_status_changed(
-                status="running", message="Executing Claude oneshot command"
+                status=ServiceState.RUNNING, message="Executing Claude oneshot command"
             )
 
     def _run_subprocess(
@@ -222,7 +223,7 @@ class OneshotSession:
         # End WebSocket session
         if self.runner.websocket_server:
             self.runner.websocket_server.claude_status_changed(
-                status="stopped", message="Session completed"
+                status=ServiceState.STOPPED, message="Session completed"
             )
             self.runner.websocket_server.session_ended()
 
@@ -299,7 +300,9 @@ class OneshotSession:
                 agent_name = self.runner._extract_agent_from_response(response)
                 if agent_name:
                     self.runner.websocket_server.agent_delegated(
-                        agent=agent_name, task=prompt[:100], status="detected"
+                        agent=agent_name,
+                        task=prompt[:100],
+                        status=OperationResult.PENDING,
                     )
 
         # Log completion
@@ -335,7 +338,8 @@ class OneshotSession:
         if self.runner.websocket_server:
             self.runner.websocket_server.claude_output(error_msg, "stderr")
             self.runner.websocket_server.claude_status_changed(
-                status="error", message=f"Command failed with code {return_code}"
+                status=ServiceState.ERROR,
+                message=f"Command failed with code {return_code}",
             )
 
         # Log error

claude_mpm/core/service_registry.py

@@ -10,6 +10,7 @@ from typing import TYPE_CHECKING, Any, Dict, List, Optional, Type, Union
 from .base_service import BaseService
 from .config import Config
 from .container import DIContainer, ServiceLifetime, get_container
+from .enums import OperationResult
 from .logger import get_logger
 from .shared.config_loader import ConfigLoader
 
@@ -249,7 +250,10 @@ class ServiceRegistry:
                                 "metrics": health.metrics,
                             }
                 except Exception as e:
-                    health_status[name] = {"status": "error", "message": str(e)}
+                    health_status[name] = {
+                        "status": OperationResult.ERROR,
+                        "message": str(e),
+                    }
 
             return health_status
 

claude_mpm/core/typing_utils.py

@@ -32,6 +32,8 @@ from typing import (
 
 from typing_extensions import NotRequired, TypeAlias, TypedDict
 
+from claude_mpm.core.enums import OperationResult, ServiceState
+
 # Generic type variables
 T = TypeVar("T")
 TSession = TypeVar("TSession")  # Generic session type
@@ -42,15 +44,14 @@ TService = TypeVar("TService")  # Generic service type
 PathLike: TypeAlias = Union[str, Path]
 JSONValue: TypeAlias = Union[str, int, float, bool, None, Dict[str, Any], List[Any]]
 JSONDict: TypeAlias = Dict[str, JSONValue]
+
 Headers: TypeAlias = Dict[str, str]
 ErrorCode: TypeAlias = Union[int, str]
 LogLevel: TypeAlias = Literal["DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL"]
 
 # Session types
 SessionId: TypeAlias = str
-SessionStatus: TypeAlias = Literal[
-    "initializing", "running", "stopped", "error", "completed"
-]
+SessionStatus: TypeAlias = ServiceState  # Replaced Literal with ServiceState enum
 LaunchMethod: TypeAlias = Literal["exec", "subprocess", "oneshot"]
 
 
@@ -152,7 +153,7 @@ class WebSocketMessage(TypedDict):
 class ClaudeStatus(TypedDict):
     """Claude process status."""
 
-    status: Literal["starting", "running", "stopped", "error"]
+    status: ServiceState  # Replaced Literal with ServiceState enum
     message: str
     timestamp: NotRequired[datetime]
     pid: NotRequired[int]
@@ -163,7 +164,7 @@ class DelegationInfo(TypedDict):
 
     agent: AgentId
     task: str
-    status: Literal["detected", "started", "completed", "failed"]
+    status: OperationResult  # Replaced Literal with OperationResult enum
     timestamp: NotRequired[datetime]
     result: NotRequired[str]
 
@@ -194,7 +195,7 @@ class HookContext(TypedDict):
 
 # Service types
 ServiceName: TypeAlias = str
-ServiceStatus: TypeAlias = Literal["idle", "running", "stopped", "error"]
+ServiceStatus: TypeAlias = ServiceState  # Replaced Literal with ServiceState enum
 
 
 class ServiceConfig(TypedDict):

claude_mpm/hooks/instruction_reinforcement.py

@@ -10,6 +10,7 @@ from dataclasses import dataclass
 from enum import Enum
 from typing import Dict, List, Optional, Tuple
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.logging_utils import get_logger
 
 logger = get_logger(__name__)
@@ -267,7 +268,7 @@ class InstructionReinforcementHook:
         if not self.violations:
             return {
                 "total_violations": 0,
-                "status": "COMPLIANT",
+                "status": OperationResult.SUCCESS,
                 "message": "No PM delegation violations detected",
             }
 
@@ -276,7 +277,11 @@ class InstructionReinforcementHook:
             vtype = v.violation_type.value
             violation_types[vtype] = violation_types.get(vtype, 0) + 1
 
-        status = "WARNING" if self.violation_count < 3 else "CRITICAL"
+        status = (
+            OperationResult.ERROR
+            if self.violation_count < 3
+            else OperationResult.FAILED
+        )
 
         return {
             "total_violations": self.violation_count,

claude_mpm/services/agents/deployment/interface_adapter.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 from typing import Any, Dict, List, Tuple
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.interfaces import AgentDeploymentInterface
 from claude_mpm.core.logger import get_logger
 
@@ -195,7 +196,7 @@ class AgentDeploymentInterfaceAdapter(AgentDeploymentInterface):
             # Ensure the result is a dictionary
             if not isinstance(status, dict):
                 return {
-                    "status": "unknown",
+                    "status": OperationResult.UNKNOWN,
                     "error": "Invalid status format from deployment service",
                     "interface_version": "1.0.0",
                     "adapter_used": True,
@@ -210,7 +211,7 @@ class AgentDeploymentInterfaceAdapter(AgentDeploymentInterface):
         except Exception as e:
             self.logger.error(f"Failed to get deployment status: {e}", exc_info=True)
             return {
-                "status": "error",
+                "status": OperationResult.ERROR,
                 "error": str(e),
                 "interface_version": "1.0.0",
                 "adapter_used": True,

claude_mpm/services/agents/deployment/refactored_agent_deployment_service.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Tuple
 
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.interfaces import AgentDeploymentInterface
 from claude_mpm.core.logger import get_logger
 
@@ -235,7 +236,7 @@ class RefactoredAgentDeploymentService(AgentDeploymentInterface):
             # Build status information
             return {
                 "service_version": "refactored-1.0.0",
-                "status": "ready",
+                "status": OperationResult.SUCCESS,
                 "templates_dir": str(self.templates_dir),
                 "base_agent_path": str(self.base_agent_path),
                 "working_directory": str(self.working_directory),
@@ -255,7 +256,7 @@ class RefactoredAgentDeploymentService(AgentDeploymentInterface):
             self.logger.error(f"Failed to get deployment status: {e}", exc_info=True)
             return {
                 "service_version": "refactored-1.0.0",
-                "status": "error",
+                "status": OperationResult.ERROR,
                 "error": str(e),
             }
 

claude_mpm/services/agents/memory/agent_memory_manager.py

@@ -25,6 +25,7 @@ import logging
 from typing import Any, ClassVar, Dict, List, Optional, Tuple
 
 from claude_mpm.core.config import Config
+from claude_mpm.core.enums import OperationResult
 from claude_mpm.core.interfaces import MemoryServiceInterface
 from claude_mpm.core.unified_paths import get_path_manager
 
@@ -596,9 +597,10 @@ class AgentMemoryManager(MemoryServiceInterface):
         """
         # Deprecated - return informative message
         return {
-            "status": "deprecated",
+            "status": OperationResult.ERROR,  # Deprecated function - calling it is an error
             "message": "Cross-reference analysis has been deprecated in favor of simplified memory management",
             "suggestion": "Use get_memory_status() for memory overview",
+            "deprecated": True,
         }
 
     def get_all_memories_raw(self) -> Dict[str, Any]:
@@ -613,9 +615,10 @@ class AgentMemoryManager(MemoryServiceInterface):
         """
         # Deprecated - return informative message
         return {
-            "status": "deprecated",
+            "status": OperationResult.ERROR,  # Deprecated function - calling it is an error
             "message": "Raw memory access has been deprecated in favor of simplified memory management",
             "suggestion": "Use load_agent_memory() for specific agent memories",
+            "deprecated": True,
         }
 
     def _save_memory_file_wrapper(self, agent_id: str, content: str) -> bool:

claude_mpm/services/diagnostics/checks/installation_check.py

@@ -11,6 +11,7 @@ import sys
 from pathlib import Path
 from typing import Optional
 
+from ....core.enums import OperationResult
 from ..models import DiagnosticResult, DiagnosticStatus
 from .base_check import BaseDiagnosticCheck
 
@@ -418,7 +419,7 @@ class InstallationCheck(BaseDiagnosticCheck):
                 message=f"Missing optional dependencies: {', '.join(warnings)}",
                 details={
                     "optional_missing": warnings,
-                    "status": "partial",
+                    "status": OperationResult.PARTIAL,
                     "installed": installed,
                     "python_executable": sys.executable,
                     "in_venv": in_venv,
@@ -429,7 +430,7 @@ class InstallationCheck(BaseDiagnosticCheck):
             status=DiagnosticStatus.OK,
             message="All dependencies installed",
             details={
-                "status": "complete",
+                "status": OperationResult.COMPLETED,
                 "installed": installed,
                 "python_executable": sys.executable,
                 "in_venv": in_venv,