claude-mpm 4.1.1__py3-none-any.whl → 4.1.3__py3-none-any.whl

claude_mpm/services/mcp_gateway/tools/ticket_tools.py

@@ -18,9 +18,7 @@ DESIGN DECISIONS:
 
 import asyncio
 import json
-import subprocess
 from datetime import datetime
-from typing import Any, Dict, List, Optional
 
 from claude_mpm.services.mcp_gateway.core.interfaces import (
     MCPToolDefinition,
@@ -106,7 +104,7 @@ class TicketCreateTool(BaseToolAdapter):
             if "priority" in params:
                 cmd.extend(["--priority", params["priority"]])
 
-            if "tags" in params and params["tags"]:
+            if params.get("tags"):
                 # aitrackdown uses --tag for tags (singular)
                 for tag in params["tags"]:
                     cmd.extend(["--tag", tag])
@@ -152,15 +150,14 @@ class TicketCreateTool(BaseToolAdapter):
                     execution_time=execution_time,
                     metadata={"tool": "ticket_create", "operation": "create"},
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to create ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to create ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -168,7 +165,7 @@ class TicketCreateTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket creation failed: {str(e)}",
+                error=f"Ticket creation failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -278,15 +275,14 @@ class TicketListTool(BaseToolAdapter):
                         "count": len(tickets) if isinstance(tickets, list) else 1,
                     },
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to list tickets: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to list tickets: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -294,7 +290,7 @@ class TicketListTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket listing failed: {str(e)}",
+                error=f"Ticket listing failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -408,15 +404,14 @@ class TicketUpdateTool(BaseToolAdapter):
                     execution_time=execution_time,
                     metadata={"tool": "ticket_update", "operation": "update"},
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to update ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to update ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -424,7 +419,7 @@ class TicketUpdateTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket update failed: {str(e)}",
+                error=f"Ticket update failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -513,15 +508,14 @@ class TicketViewTool(BaseToolAdapter):
                         "ticket_id": ticket_id,
                     },
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to view ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to view ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -529,7 +523,7 @@ class TicketViewTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket view failed: {str(e)}",
+                error=f"Ticket view failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -621,15 +615,14 @@ class TicketSearchTool(BaseToolAdapter):
                         "query": query,
                     },
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to search tickets: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to search tickets: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -637,7 +630,7 @@ class TicketSearchTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket search failed: {str(e)}",
+                error=f"Ticket search failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -646,7 +639,7 @@ class TicketSearchTool(BaseToolAdapter):
 __all__ = [
     "TicketCreateTool",
     "TicketListTool",
+    "TicketSearchTool",
     "TicketUpdateTool",
     "TicketViewTool",
-    "TicketSearchTool",
 ]

claude_mpm/services/mcp_gateway/tools/unified_ticket_tool.py

@@ -21,9 +21,8 @@ DESIGN DECISIONS:
 import asyncio
 import json
 import re
-import subprocess
 from datetime import datetime
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, Optional
 
 from claude_mpm.services.mcp_gateway.core.interfaces import (
     MCPToolDefinition,
@@ -191,7 +190,9 @@ class UnifiedTicketTool(BaseToolAdapter):
 
         return await handler(invocation.parameters)
 
-    def _validate_parameters(self, operation: str, params: Dict[str, Any]) -> Optional[str]:
+    def _validate_parameters(
+        self, operation: str, params: Dict[str, Any]
+    ) -> Optional[str]:
         """
         Validate parameters based on the operation type.
 
@@ -209,26 +210,26 @@ class UnifiedTicketTool(BaseToolAdapter):
                 return "'title' parameter is required for create operation"
             if params["type"] not in ["task", "issue", "epic"]:
                 return f"Invalid type '{params['type']}'. Must be 'task', 'issue', or 'epic'"
-        
+
         elif operation == "update":
             if "ticket_id" not in params:
                 return "'ticket_id' parameter is required for update operation"
-        
+
         elif operation == "view":
             if "ticket_id" not in params:
                 return "'ticket_id' parameter is required for view operation"
-        
+
         elif operation == "search":
             if "query" not in params:
                 return "'query' parameter is required for search operation"
-        
+
         elif operation == "list":
             # List operation has no required parameters beyond operation itself
             pass
-        
+
         else:
             return f"Unknown operation: {operation}"
-        
+
         return None
 
     async def _handle_create(self, params: Dict[str, Any]) -> MCPToolResult:
@@ -254,7 +255,7 @@ class UnifiedTicketTool(BaseToolAdapter):
             if "priority" in params:
                 cmd.extend(["--priority", params["priority"]])
 
-            if "tags" in params and params["tags"]:
+            if params.get("tags"):
                 for tag in params["tags"]:
                     cmd.extend(["--tag", tag])
 
@@ -294,15 +295,14 @@ class UnifiedTicketTool(BaseToolAdapter):
                     execution_time=execution_time,
                     metadata={"tool": "ticket", "operation": "create"},
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to create ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to create ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -310,7 +310,7 @@ class UnifiedTicketTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket creation failed: {str(e)}",
+                error=f"Ticket creation failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -365,15 +365,14 @@ class UnifiedTicketTool(BaseToolAdapter):
                         "count": len(tickets) if isinstance(tickets, list) else 1,
                     },
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to list tickets: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to list tickets: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -381,7 +380,7 @@ class UnifiedTicketTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket listing failed: {str(e)}",
+                error=f"Ticket listing failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -444,15 +443,14 @@ class UnifiedTicketTool(BaseToolAdapter):
                     execution_time=execution_time,
                     metadata={"tool": "ticket", "operation": "update"},
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to update ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to update ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -460,7 +458,7 @@ class UnifiedTicketTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket update failed: {str(e)}",
+                error=f"Ticket update failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -514,15 +512,14 @@ class UnifiedTicketTool(BaseToolAdapter):
                         "ticket_id": ticket_id,
                     },
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to view ticket: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to view ticket: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -530,7 +527,7 @@ class UnifiedTicketTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket view failed: {str(e)}",
+                error=f"Ticket view failed: {e!s}",
                 execution_time=execution_time,
             )
 
@@ -581,15 +578,14 @@ class UnifiedTicketTool(BaseToolAdapter):
                     execution_time=execution_time,
                     metadata={"tool": "ticket", "operation": "search", "query": query},
                 )
-            else:
-                error_msg = stderr.decode() if stderr else stdout.decode()
-                self._update_metrics(False, execution_time)
+            error_msg = stderr.decode() if stderr else stdout.decode()
+            self._update_metrics(False, execution_time)
 
-                return MCPToolResult(
-                    success=False,
-                    error=f"Failed to search tickets: {error_msg}",
-                    execution_time=execution_time,
-                )
+            return MCPToolResult(
+                success=False,
+                error=f"Failed to search tickets: {error_msg}",
+                execution_time=execution_time,
+            )
 
         except Exception as e:
             execution_time = (datetime.now() - start_time).total_seconds()
@@ -597,7 +593,7 @@ class UnifiedTicketTool(BaseToolAdapter):
 
             return MCPToolResult(
                 success=False,
-                error=f"Ticket search failed: {str(e)}",
+                error=f"Ticket search failed: {e!s}",
                 execution_time=execution_time,
             )
 

claude_mpm/services/memory/__init__.py

@@ -7,13 +7,13 @@ This module provides memory management services including:
 """
 
 from .builder import MemoryBuilder
+from .indexed_memory import IndexedMemoryService
 from .optimizer import MemoryOptimizer
 from .router import MemoryRouter
-from .indexed_memory import IndexedMemoryService
 
 __all__ = [
+    "IndexedMemoryService",
     "MemoryBuilder",
-    "MemoryRouter",
     "MemoryOptimizer",
-    "IndexedMemoryService",
+    "MemoryRouter",
 ]

claude_mpm/services/memory/builder.py

@@ -26,7 +26,7 @@ import os
 import re
 from datetime import datetime
 from pathlib import Path
-from typing import Any, Dict, List, Optional, Tuple
+from typing import Any, Dict, List, Optional
 
 from claude_mpm.core.config import Config
 from claude_mpm.core.mixins import LoggerMixin
@@ -410,7 +410,7 @@ class MemoryBuilder(LoggerMixin):
 
                 except Exception as e:
                     result["items_skipped"] += 1
-                    result["errors"].append(f"Error processing item: {str(e)}")
+                    result["errors"].append(f"Error processing item: {e!s}")
 
             # Convert set to list
             result["sections_updated"] = list(result["sections_updated"])
@@ -878,10 +878,7 @@ class MemoryBuilder(LoggerMixin):
             "as mentioned",
             "for more info",
         ]
-        if any(phrase in content.lower() for phrase in generic_phrases):
-            return False
-
-        return True
+        return not any(phrase in content.lower() for phrase in generic_phrases)
 
     def _deduplicate_extracted_items(
         self, items: List[Dict[str, Any]]

claude_mpm/services/memory/cache/__init__.py

@@ -9,6 +9,6 @@ from .shared_prompt_cache import SharedPromptCache
 from .simple_cache import SimpleCacheService
 
 __all__ = [
-    "SimpleCacheService",
     "SharedPromptCache",
+    "SimpleCacheService",
 ]

claude_mpm/services/memory/cache/shared_prompt_cache.py

@@ -41,15 +41,13 @@ import asyncio
 import json
 import threading
 import time
-import weakref
 from collections import OrderedDict
 from dataclasses import dataclass, field
-from datetime import datetime, timedelta
 from functools import wraps
 from threading import RLock
-from typing import Any, Dict, List, Optional, Set, Tuple, Union
+from typing import Any, Dict, List, Optional, Set
 
-from claude_mpm.core.base_service import BaseService, ServiceHealth, ServiceMetrics
+from claude_mpm.core.base_service import BaseService
 
 
 @dataclass
@@ -429,7 +427,7 @@ class SharedPromptCache(BaseService):
             with self._cache_lock:
                 keys_to_remove = []
 
-                for key in self._cache.keys():
+                for key in self._cache:
                     if fnmatch.fnmatch(key, pattern):
                         keys_to_remove.append(key)
 

claude_mpm/services/memory/cache/simple_cache.py

@@ -229,7 +229,7 @@ class SimpleCacheService(ICacheService):
         with self.lock:
             keys_to_delete = []
 
-            for key in self.cache.keys():
+            for key in self.cache:
                 if fnmatch.fnmatch(key, pattern):
                     keys_to_delete.append(key)
 

claude_mpm/services/memory/indexed_memory.py

@@ -18,17 +18,15 @@ WHY indexed memory:
 
 import bisect
 import hashlib
-import mmap
-import os
 import pickle
 import re
 import time
 from collections import Counter, defaultdict
 from dataclasses import dataclass, field
 from datetime import datetime, timedelta
-from typing import Any, Dict, List, Optional, Set, Tuple, Union
+from typing import Any, Dict, List, Optional, Set, Tuple
 
-from ...core.cache import FileSystemCache, get_file_cache
+from ...core.cache import get_file_cache
 from ...core.logger import get_logger
 
 
@@ -256,7 +254,7 @@ class BTreeIndex:
         self.index = [(k, id) for k, id in self.index if id != entry_id]
 
     def range_search(
-        self, min_key: Any = None, max_key: Any = None, limit: int = None
+        self, min_key: Any = None, max_key: Any = None, limit: Optional[int] = None
     ) -> List[str]:
         """Search for entries in key range.
 
@@ -366,8 +364,8 @@ class IndexedMemoryService:
         agent_id: str,
         content: str,
         category: str = "general",
-        tags: List[str] = None,
-        metadata: Dict[str, Any] = None,
+        tags: Optional[List[str]] = None,
+        metadata: Optional[Dict[str, Any]] = None,
     ) -> str:
         """Add a new memory entry.
 

claude_mpm/services/memory/optimizer.py

@@ -27,7 +27,7 @@ import re
 from datetime import datetime
 from difflib import SequenceMatcher
 from pathlib import Path
-from typing import Any, Dict, List, Optional, Set, Tuple
+from typing import Any, Dict, List, Optional, Tuple
 
 from claude_mpm.core.config import Config
 from claude_mpm.core.mixins import LoggerMixin
@@ -260,8 +260,7 @@ class MemoryOptimizer(LoggerMixin):
         try:
             if agent_id:
                 return self._analyze_single_agent(agent_id)
-            else:
-                return self._analyze_all_agents()
+            return self._analyze_all_agents()
 
         except Exception as e:
             self.logger.error(f"Error analyzing optimization opportunities: {e}")
@@ -324,7 +323,7 @@ class MemoryOptimizer(LoggerMixin):
             stripped = line.strip()
             if stripped.startswith("- "):
                 bullet_points.append(line)
-            elif stripped.startswith("## ") or stripped.startswith("<!--"):
+            elif stripped.startswith(("## ", "<!--")):
                 header_lines.append(line)
             else:
                 other_lines.append(line)
@@ -533,28 +532,26 @@ class MemoryOptimizer(LoggerMixin):
         # Add ordered sections
         for section_name in section_order:
             if section_name in sections and section_name != "header":
-                if content_lines and not content_lines[-1].strip() == "":
+                if content_lines and content_lines[-1].strip() != "":
                     content_lines.append("")  # Add spacing
                 content_lines.extend(sections[section_name])
 
         # Add any remaining sections not in the order
         for section_name, section_content in sections.items():
             if section_name not in section_order and section_name != "header":
-                if content_lines and not content_lines[-1].strip() == "":
+                if content_lines and content_lines[-1].strip() != "":
                     content_lines.append("")
                 content_lines.extend(section_content)
 
         # Update timestamp
         content = "\n".join(content_lines)
         timestamp = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
-        content = re.sub(
+        return re.sub(
             r"<!-- Last Updated: .+ \| Auto-updated by: .+ -->",
             f"<!-- Last Updated: {timestamp} | Auto-updated by: optimizer -->",
             content,
         )
 
-        return content
-
     def _create_backup(self, memory_file: Path) -> Path:
         """Create backup of memory file before optimization.
 
@@ -601,7 +598,7 @@ class MemoryOptimizer(LoggerMixin):
             "agent_id": agent_id,
             "file_size": len(content),
             "sections": len(
-                [s for s in sections if not s.lower() in ["header", "metadata"]]
+                [s for s in sections if s.lower() not in ["header", "metadata"]]
             ),
             "opportunities": [],
         }

claude_mpm/services/memory/router.py

@@ -586,9 +586,9 @@ class MemoryRouter(LoggerMixin):
                 "expected_agent": expected,
                 "actual_agent": routing_result["target_agent"],
                 "confidence": routing_result["confidence"],
-                "correct": expected == routing_result["target_agent"]
-                if expected
-                else None,
+                "correct": (
+                    expected == routing_result["target_agent"] if expected else None
+                ),
                 "reasoning": routing_result["reasoning"],
             }
 
@@ -781,17 +781,16 @@ class MemoryRouter(LoggerMixin):
         # Simple heuristics for section selection
         if "mistake" in content or "error" in content or "avoid" in content:
             return "Common Mistakes to Avoid"
-        elif "pattern" in content or "architecture" in content:
+        if "pattern" in content or "architecture" in content:
             return (
                 sections[0] if sections else "Recent Learnings"
             )  # First section is usually patterns
-        elif "guideline" in content or "standard" in content:
+        if "guideline" in content or "standard" in content:
             return "Implementation Guidelines"
-        elif "context" in content or "current" in content:
+        if "context" in content or "current" in content:
             return "Current Technical Context"
-        else:
-            # Default to first available section or Recent Learnings
-            return sections[0] if sections else "Recent Learnings"
+        # Default to first available section or Recent Learnings
+        return sections[0] if sections else "Recent Learnings"
 
     def _build_reasoning(
         self,