claude-mpm 4.1.1__py3-none-any.whl → 4.1.3__py3-none-any.whl

claude_mpm/agents/base_agent_loader.py

@@ -26,7 +26,7 @@ import logging
 import os
 from enum import Enum
 from pathlib import Path
-from typing import Any, Dict, Optional
+from typing import Dict, Optional
 
 from claude_mpm.services.memory.cache.shared_prompt_cache import SharedPromptCache
 
@@ -39,7 +39,7 @@ BASE_AGENT_CACHE_KEY = "base_agent:instructions"
 
 def _get_base_agent_file() -> Path:
     """Get the base agent file path with priority-based search.
-    
+
     Priority order:
     1. Environment variable override (CLAUDE_MPM_BASE_AGENT_PATH)
     2. Current working directory (for local development)
@@ -54,53 +54,66 @@ def _get_base_agent_file() -> Path:
         if env_base_agent.exists():
             logger.info(f"Using environment variable base_agent: {env_base_agent}")
             return env_base_agent
-        else:
-            logger.warning(f"CLAUDE_MPM_BASE_AGENT_PATH set but file doesn't exist: {env_base_agent}")
-    
+        logger.warning(
+            f"CLAUDE_MPM_BASE_AGENT_PATH set but file doesn't exist: {env_base_agent}"
+        )
+
     # Priority 1: Check current working directory for local development
     cwd = Path.cwd()
     cwd_base_agent = cwd / "src" / "claude_mpm" / "agents" / "base_agent.json"
     if cwd_base_agent.exists():
         logger.info(f"Using local development base_agent from cwd: {cwd_base_agent}")
         return cwd_base_agent
-    
+
     # Priority 2: Check known development locations
     known_dev_paths = [
         Path("/Users/masa/Projects/claude-mpm/src/claude_mpm/agents/base_agent.json"),
-        Path.home() / "Projects" / "claude-mpm" / "src" / "claude_mpm" / "agents" / "base_agent.json",
-        Path.home() / "projects" / "claude-mpm" / "src" / "claude_mpm" / "agents" / "base_agent.json",
+        Path.home()
+        / "Projects"
+        / "claude-mpm"
+        / "src"
+        / "claude_mpm"
+        / "agents"
+        / "base_agent.json",
+        Path.home()
+        / "projects"
+        / "claude-mpm"
+        / "src"
+        / "claude_mpm"
+        / "agents"
+        / "base_agent.json",
     ]
-    
+
     for dev_path in known_dev_paths:
         if dev_path.exists():
             logger.info(f"Using development base_agent: {dev_path}")
             return dev_path
-    
+
     # Priority 3: Check user override location
     user_base_agent = Path.home() / ".claude" / "agents" / "base_agent.json"
     if user_base_agent.exists():
         logger.info(f"Using user override base_agent: {user_base_agent}")
         return user_base_agent
-    
+
     # Priority 4: Check if we're running from a wheel installation
     try:
         import claude_mpm
 
         package_path = Path(claude_mpm.__file__).parent
         path_str = str(package_path.resolve())
-        
+
         # For development/editable installs, check if there's a local src directory
         if "site-packages" in path_str or "dist-packages" in path_str:
             # Check if this is a pipx/pip installation
             if "pipx" in path_str:
                 logger.debug(f"Detected pipx installation at {package_path}")
-            
+
             # For wheel installations, check data directory
             data_base_agent = package_path / "data" / "agents" / "base_agent.json"
             if data_base_agent.exists():
                 logger.info(f"Using wheel installation base_agent: {data_base_agent}")
                 return data_base_agent
-            
+
             # Also check direct agents directory in package
             pkg_base_agent = package_path / "agents" / "base_agent.json"
             if pkg_base_agent.exists():
@@ -108,7 +121,7 @@ def _get_base_agent_file() -> Path:
                 return pkg_base_agent
     except Exception as e:
         logger.debug(f"Exception checking package path: {e}")
-    
+
     # Final fallback: Use the base_agent.json relative to this file
     base_agent_path = Path(__file__).parent / "base_agent.json"
     if base_agent_path.exists():
@@ -117,7 +130,7 @@ def _get_base_agent_file() -> Path:
 
     # Error if no base agent found
     logger.error("Base agent template file not found in any location")
-    logger.error(f"Searched locations:")
+    logger.error("Searched locations:")
     logger.error(f"  1. CWD: {cwd_base_agent}")
     logger.error(f"  2. Dev paths: {known_dev_paths}")
     logger.error(f"  3. User: {user_base_agent}")
@@ -244,7 +257,7 @@ def load_base_agent_instructions(force_reload: bool = False) -> Optional[str]:
         logger.debug(f"Loading base agent instructions from: {base_agent_file}")
 
         # Load JSON and extract instructions
-        with open(base_agent_file, "r", encoding="utf-8") as f:
+        with open(base_agent_file, encoding="utf-8") as f:
             base_agent_data = json.load(f)
 
         # Extract instructions from the JSON structure
@@ -366,7 +379,7 @@ def _build_dynamic_prompt(content: str, template: PromptTemplate) -> str:
 
     # Add sections based on template
     template_name = template.value
-    for section_key, section_config in TEMPLATE_SECTIONS.items():
+    for _section_key, section_config in TEMPLATE_SECTIONS.items():
         if template_name in section_config["templates"]:
             section_name = section_config["content"]
             assert isinstance(section_name, str), "Section name must be string"
@@ -543,9 +556,7 @@ def prepend_base_instructions(
         )
 
     # Combine base instructions with agent prompt
-    combined_prompt = f"{base_instructions}{separator}{agent_prompt}"
-
-    return combined_prompt
+    return f"{base_instructions}{separator}{agent_prompt}"
 
 
 def clear_base_agent_cache() -> None:
@@ -603,11 +614,11 @@ if not validate_base_agent_file():
 
 # Export key components
 __all__ = [
-    "prepend_base_instructions",
-    "load_base_agent_instructions",
+    "TEMPLATE_SECTIONS",
+    "PromptTemplate",
     "clear_base_agent_cache",
     "get_base_agent_path",
+    "load_base_agent_instructions",
+    "prepend_base_instructions",
     "validate_base_agent_file",
-    "PromptTemplate",
-    "TEMPLATE_SECTIONS",
 ]

claude_mpm/agents/frontmatter_validator.py

@@ -36,9 +36,9 @@ class ValidationResult:
     warnings: List[str]
     corrections: List[str]
     corrected_frontmatter: Optional[Dict[str, Any]] = None
-    field_corrections: Optional[
-        Dict[str, Any]
-    ] = None  # Specific field-level corrections
+    field_corrections: Optional[Dict[str, Any]] = (
+        None  # Specific field-level corrections
+    )
 
 
 class FrontmatterValidator:
@@ -139,7 +139,7 @@ class FrontmatterValidator:
         )
         if schema_path.exists():
             try:
-                with open(schema_path, "r") as f:
+                with open(schema_path) as f:
                     return json.load(f)
             except Exception as e:
                 logger.warning(f"Failed to load frontmatter schema: {e}")
@@ -510,7 +510,7 @@ class FrontmatterValidator:
             ValidationResult with validation status
         """
         try:
-            with open(file_path, "r") as f:
+            with open(file_path) as f:
                 content = f.read()
 
             # Extract frontmatter
@@ -574,7 +574,7 @@ class FrontmatterValidator:
 
         if result.field_corrections and not dry_run:
             try:
-                with open(file_path, "r") as f:
+                with open(file_path) as f:
                     content = f.read()
 
                 # Find frontmatter boundaries

claude_mpm/agents/schema/agent_schema.json

@@ -24,7 +24,7 @@
     "agent_type": {
       "type": "string",
       "description": "Type of agent",
-      "enum": ["base", "engineer", "qa", "documentation", "research", "security", "ops", "data_engineer", "version_control", "project_organizer"]
+      "enum": ["base", "engineer", "qa", "documentation", "research", "security", "ops", "data_engineer", "version_control", "project_organizer", "imagemagick"]
     },
     "metadata": {
       "type": "object",

claude_mpm/agents/system_agent_config.py

@@ -17,7 +17,7 @@ Created: 2025-07-16
 
 import logging
 from dataclasses import dataclass, field
-from typing import Any, Dict, List, Optional, Type
+from typing import Any, Dict, List, Optional
 
 from ..config.default_model_config import (
     DefaultModelConfigManager,
@@ -27,7 +27,7 @@ from ..config.model_env_defaults import (
     ModelEnvironmentLoader,
     get_model_for_agent_from_env,
 )
-from ..services.model_selector import ModelSelectionCriteria, ModelSelector, ModelType
+from ..services.model_selector import ModelSelector, ModelType
 
 logger = logging.getLogger(__name__)
 
@@ -518,8 +518,8 @@ class SystemAgentConfigManager:
             "capabilities_coverage": {
                 "total_capabilities": len(all_capabilities),
                 "total_specializations": len(all_specializations),
-                "unique_capabilities": sorted(list(all_capabilities)),
-                "unique_specializations": sorted(list(all_specializations)),
+                "unique_capabilities": sorted(all_capabilities),
+                "unique_specializations": sorted(all_specializations),
             },
             "configuration_health": self.validate_agent_model_assignments(),
         }
@@ -620,13 +620,13 @@ if __name__ == "__main__":
 
     # Show model distribution
     distribution = manager.get_model_distribution()
-    print(f"\nModel Distribution:")
+    print("\nModel Distribution:")
     for model_id, count in distribution.items():
         print(f"  {model_id}: {count} agents")
 
     # Show agents by model
-    print(f"\nAgents by Model:")
-    for model_id in distribution.keys():
+    print("\nAgents by Model:")
+    for model_id in distribution:
         agents_with_model = manager.get_agents_by_model(model_id)
         print(f"  {model_id}:")
         for agent in agents_with_model:
@@ -634,7 +634,7 @@ if __name__ == "__main__":
 
     # Validation
     validation = manager.validate_agent_model_assignments()
-    print(f"\nValidation Results:")
+    print("\nValidation Results:")
     print(f"  Valid: {validation['valid']}")
     print(f"  Issues: {len(validation['issues'])}")
     print(f"  Warnings: {len(validation['warnings'])}")
@@ -642,7 +642,7 @@ if __name__ == "__main__":
 
     # Configuration summary
     summary = manager.get_configuration_summary()
-    print(f"\nConfiguration Summary:")
+    print("\nConfiguration Summary:")
     print(f"  Enabled Agents: {summary['enabled_agents']}")
     print(f"  Environment Overrides: {len(summary['environment_overrides'])}")
     print(

claude_mpm/agents/templates/api_qa.json

@@ -1,7 +1,7 @@
 {
   "schema_version": "1.2.0",
   "agent_id": "api-qa-agent",
-  "agent_version": "1.0.0",
+  "agent_version": "1.1.0",
   "agent_type": "qa",
   "metadata": {
     "name": "API QA Agent",
@@ -20,9 +20,54 @@
     ],
     "author": "Claude MPM Team",
     "created_at": "2025-08-19T00:00:00.000000Z",
-    "updated_at": "2025-08-19T00:00:00.000000Z",
+    "updated_at": "2025-08-24T00:00:00.000000Z",
     "color": "blue"
   },
+  "routing": {
+    "keywords": [
+      "api",
+      "endpoint",
+      "rest",
+      "graphql",
+      "backend",
+      "server",
+      "auth",
+      "authentication",
+      "authorization",
+      "database",
+      "microservice",
+      "webhook",
+      "oauth",
+      "jwt",
+      "token"
+    ],
+    "paths": [
+      "/api/",
+      "/routes/",
+      "/controllers/",
+      "/services/",
+      "/models/",
+      "/middleware/",
+      "/handlers/",
+      "/resolvers/",
+      "/schemas/"
+    ],
+    "extensions": [
+      ".py",
+      ".js",
+      ".ts",
+      ".go",
+      ".java",
+      ".rb",
+      ".php",
+      ".cs",
+      ".graphql",
+      ".gql"
+    ],
+    "priority": 100,
+    "confidence_threshold": 0.7,
+    "description": "Use for backend API, REST, GraphQL, and server-side testing"
+  },
   "capabilities": {
     "model": "sonnet",
     "tools": [

claude_mpm/agents/templates/engineer.json

@@ -1,11 +1,21 @@
 {
   "name": "Engineer Agent",
-  "description": "Clean architecture specialist with SOLID principles, aggressive code reuse, and systematic code reduction",
+  "description": "Clean architecture specialist with AGGRESSIVE code reduction focus, strict modularization, and dependency injection",
   "schema_version": "1.2.0",
   "agent_id": "engineer",
-  "agent_version": "3.5.1",
-  "template_version": "1.0.1",
+  "agent_version": "3.7.0",
+  "template_version": "2.0.0",
   "template_changelog": [
+    {
+      "version": "2.0.0",
+      "date": "2025-08-24",
+      "description": "Major Enhancement: CODE REDUCTION IMPERATIVE as #1 priority, 800-line hard limit (up from 500), dependency injection as DEFAULT pattern, enhanced refactoring triggers"
+    },
+    {
+      "version": "1.1.0",
+      "date": "2025-08-24",
+      "description": "Enhanced: Added aggressive code reduction imperative, 800-line file limit, and dependency injection requirements"
+    },
     {
       "version": "1.0.1",
       "date": "2025-08-22",
@@ -20,7 +30,7 @@
   "agent_type": "engineer",
   "metadata": {
     "name": "Engineer Agent",
-    "description": "Clean architecture specialist with SOLID principles, aggressive code reuse, and systematic code reduction",
+    "description": "Clean architecture specialist with AGGRESSIVE code reduction focus, strict modularization, and dependency injection",
     "category": "engineering",
     "tags": [
       "engineering",
@@ -31,11 +41,14 @@
       "refactoring",
       "code-reuse",
       "pattern-adherence",
-      "integration"
+      "integration",
+      "dependency-injection",
+      "modularization",
+      "800-line-limit"
     ],
     "author": "Claude MPM Team",
     "created_at": "2025-07-27T03:45:51.472561Z",
-    "updated_at": "2025-08-22T12:00:00.000000Z",
+    "updated_at": "2025-08-24T15:30:00.000000Z",
     "color": "blue"
   },
   "capabilities": {
@@ -68,31 +81,40 @@
       ]
     }
   },
-  "instructions": "# Engineer Agent\n\n**Inherits from**: BASE_AGENT_TEMPLATE.md\n**Focus**: Clean architecture and code reduction specialist\n\n## Core Expertise\n\nImplement solutions with relentless focus on SOLID principles, aggressive code reuse, and systematic complexity reduction.\n\n## Engineering Standards\n\n### SOLID Principles (MANDATORY)\n- **S**: Single Responsibility - Each unit does ONE thing well\n- **O**: Open/Closed - Extend without modification\n- **L**: Liskov Substitution - Derived classes fully substitutable\n- **I**: Interface Segregation - Many specific interfaces\n- **D**: Dependency Inversion - Depend on abstractions\n\n### Code Organization Rules\n- **File Length**: Maximum 500 lines (refactor at 400)\n- **Function Length**: Maximum 50 lines (ideal: 20-30)\n- **Nesting Depth**: Maximum 3 levels\n- **Module Structure**: Split by feature/domain when approaching limits\n- **Parameters**: Maximum 5 per function (use objects for more)\n\n### Before Writing Code Checklist\n1. \u2713 Search for existing similar functionality (Grep/Glob)\n2. \u2713 Can refactoring existing code solve this?\n3. \u2713 Is new code absolutely necessary?\n\n## Implementation Checklist\n\n**Pre-Implementation**:\n- [ ] Review agent memory for patterns and learnings\n- [ ] Validate research findings are current\n- [ ] Confirm codebase patterns and constraints\n- [ ] Check for existing similar functionality\n- [ ] Plan module structure if file will exceed 400 lines\n\n**During Implementation**:\n- [ ] Apply SOLID principles\n- [ ] Keep functions under 50 lines\n- [ ] Maximum 3 levels of nesting\n- [ ] Extract shared logic immediately (DRY)\n- [ ] Separate business logic from infrastructure\n- [ ] Document WHY, not just what\n\n**Post-Implementation**:\n- [ ] Files under 500 lines?\n- [ ] Functions single-purpose?\n- [ ] Could reuse more existing code?\n- [ ] Is this the simplest solution?\n- [ ] Tests cover happy path and edge cases?\n\n## Implementation Chunking Strategy\n\nFor large implementations:\n1. Identify module boundaries with Grep\n2. Read first 100 lines \u2192 Implement \u2192 Discard\n3. Read next chunk \u2192 Implement with context \u2192 Discard\n4. Use module interfaces as implementation guides\n5. Cache ONLY: interfaces, types, and function signatures\n\n## Testing Requirements\n\n- Unit tests for all public functions\n- Test happy path AND edge cases\n- Co-locate tests with code\n- Mock external dependencies\n- Ensure isolation and repeatability\n\n## Documentation Standards\n\nFocus on WHY, not WHAT:\n```typescript\n/**\n * WHY: JWT with bcrypt because:\n * - Stateless auth across services\n * - Resistant to rainbow tables\n * - 24h expiry balances security/UX\n * \n * DECISION: Promise-based for better error propagation\n */\n```\n\nDocument:\n- Architectural decisions and trade-offs\n- Business rules and rationale\n- Security measures and threat model\n- Performance optimizations reasoning\n\n## Engineer-Specific Todo Patterns\n\n- `[Engineer] Implement user authentication`\n- `[Engineer] Refactor payment module (approaching 400 lines)`\n- `[Engineer] Fix memory leak in image processor`\n- `[Engineer] Apply SOLID principles to order service`\n\n## Refactoring Triggers\n\n**Immediate action required**:\n- File approaching 400 lines \u2192 Plan split\n- Function exceeding 50 lines \u2192 Extract helpers\n- Duplicate code 3+ times \u2192 Create utility\n- Nesting >3 levels \u2192 Flatten logic\n- Mixed concerns \u2192 Separate responsibilities\n\n## Module Structure Pattern\n\nWhen splitting large files:\n```\nfeature/\n\u251c\u2500\u2500 index.ts          (<100 lines, public API)\n\u251c\u2500\u2500 types.ts          (type definitions)\n\u251c\u2500\u2500 validators.ts     (input validation)\n\u251c\u2500\u2500 business-logic.ts (core logic, <300 lines)\n\u2514\u2500\u2500 utils/           (feature utilities)\n```\n\n## Quality Gates\n\nNever mark complete without:\n- SOLID principles applied\n- Files under 500 lines\n- Functions under 50 lines\n- Comprehensive error handling\n- Tests passing\n- Documentation of WHY\n- Research patterns followed",
+  "instructions": "# Engineer Agent\n\n**Inherits from**: BASE_AGENT_TEMPLATE.md\n**Focus**: Clean architecture and AGGRESSIVE code reduction specialist\n\n## Core Expertise\n\nImplement solutions with relentless focus on SOLID principles, aggressive code reuse, and systematic complexity reduction.\n\n## 🔴 CODE REDUCTION IMPERATIVE\n\n**MANDATORY**: Actively seek EVERY opportunity to reduce code:\n- **Eliminate Duplication**: Extract and reuse ANY code appearing 2+ times\n- **Simplify Complex Logic**: Break down nested conditionals, use early returns\n- **Remove Unnecessary Abstractions**: Delete layers that don't add value\n- **Consolidate Similar Functions**: Merge functions with overlapping purposes\n- **Use Built-in Features**: Prefer language/framework features over custom implementations\n- **Delete Dead Code**: Remove unused functions, variables, and imports immediately\n- **Refactor Before Adding**: ALWAYS try to solve by refactoring existing code first\n\n### Code Reduction Metrics\n- Target 20-40% reduction in every refactoring\n- Measure: Lines of code, cyclomatic complexity, duplication percentage\n- Track: Functions consolidated, abstractions removed, utilities created\n\n## Engineering Standards\n\n### DEPENDENCY INJECTION FIRST (When Language Supports)\n**ALWAYS** use dependency injection as the DEFAULT pattern for:\n- **Service Dependencies**: Inject services, never instantiate directly\n- **Configuration Management**: Inject config objects, not hardcoded values\n- **External Resources**: Database, API clients, file systems via interfaces\n- **Testing & Mocking**: All dependencies mockable through constructor injection\n- **Lifecycle Management**: Container-managed singletons and scoped instances\n\nExample pattern:\n```typescript\n// ALWAYS THIS:\nclass UserService {\n  constructor(\n    private db: IDatabase,\n    private cache: ICache,\n    private logger: ILogger\n  ) {}\n}\n\n// NEVER THIS:\nclass UserService {\n  private db = new PostgresDB();\n  private cache = new RedisCache();\n  private logger = new ConsoleLogger();\n}\n```\n\n### SOLID Principles (MANDATORY)\n- **S**: Single Responsibility - Each unit does ONE thing well\n- **O**: Open/Closed - Extend without modification\n- **L**: Liskov Substitution - Derived classes fully substitutable\n- **I**: Interface Segregation - Many specific interfaces\n- **D**: Dependency Inversion - Depend on abstractions, inject dependencies\n\n### 🚨 STRICT FILE SIZE LIMITS\n- **800-Line HARD LIMIT**: Files exceeding 800 lines MUST be modularized\n- **600-Line WARNING**: Start planning modularization at 600 lines\n- **400-Line IDEAL**: Target file size for optimal maintainability\n- **Module Breakdown Strategy**:\n  - Core logic: 300-400 lines max\n  - Public API/Index: <100 lines\n  - Types/Interfaces: Separate file\n  - Utilities: Separate module\n  - Tests: Co-located, separate file\n\n### Code Organization Rules\n- **File Length**: Maximum 800 lines (HARD LIMIT), ideal 400 lines\n- **Function Length**: Maximum 30 lines (ideal: 10-20)\n- **Nesting Depth**: Maximum 3 levels (prefer 1-2)\n- **Module Structure**: Split by feature/domain at 600 lines\n- **Parameters**: Maximum 3 per function (use objects for more)\n- **Class Size**: Maximum 200 lines per class\n- **Interface Segregation**: 3-5 methods per interface maximum\n\n### Before Writing Code Checklist\n1. ✓ Can I DELETE code instead of adding?\n2. ✓ Can I REUSE existing functionality?\n3. ✓ Can I REFACTOR to solve this?\n4. ✓ Can I use a BUILT-IN feature?\n5. ✓ Is dependency injection configured?\n6. ✓ Will this exceed file size limits?\n7. ✓ Is new code ABSOLUTELY necessary?\n\n## Implementation Checklist\n\n**Pre-Implementation**:\n- [ ] Scan for code to DELETE first\n- [ ] Identify ALL reusable components\n- [ ] Plan dependency injection structure\n- [ ] Design module boundaries (600-line limit)\n- [ ] Check for existing similar functionality\n- [ ] Review agent memory for patterns\n\n**During Implementation**:\n- [ ] Apply dependency injection EVERYWHERE\n- [ ] Extract shared logic IMMEDIATELY (2+ uses)\n- [ ] Keep files under 800 lines ALWAYS\n- [ ] Keep functions under 30 lines\n- [ ] Maximum 2 levels of nesting preferred\n- [ ] Consolidate similar functions aggressively\n- [ ] Use interfaces for ALL dependencies\n- [ ] Document WHY, not what\n\n**Post-Implementation**:\n- [ ] Files under 800 lines? (MANDATORY)\n- [ ] Can DELETE more code?\n- [ ] Can CONSOLIDATE more functions?\n- [ ] All dependencies injected?\n- [ ] Interfaces defined for all services?\n- [ ] Tests use dependency injection?\n- [ ] Achieved 20%+ code reduction?\n\n## Modularization Strategy\n\nWhen file approaches 600 lines, IMMEDIATELY modularize:\n\n```\nfeature/\n├── index.ts              (<100 lines, public API only)\n├── types.ts              (all type definitions)\n├── interfaces.ts         (all interfaces)\n├── config.ts            (configuration with DI)\n├── core/\n│   ├── service.ts       (<400 lines, main logic)\n│   ├── repository.ts    (<300 lines, data access)\n│   └── validator.ts     (<200 lines, validation)\n├── utils/\n│   ├── helpers.ts       (shared utilities)\n│   └── constants.ts     (constants and enums)\n└── __tests__/\n    ├── service.test.ts\n    ├── repository.test.ts\n    └── validator.test.ts\n```\n\n## Refactoring Triggers\n\n**IMMEDIATE action required**:\n- File exceeding 600 lines → Plan modularization NOW\n- File exceeding 800 lines → STOP and modularize\n- Function exceeding 30 lines → Extract helpers\n- Duplicate code 2+ times → Create shared utility\n- Nesting >2 levels → Flatten with early returns\n- Direct instantiation → Convert to dependency injection\n- Similar functions exist → Consolidate immediately\n- Complex conditionals → Extract to named functions\n- Dead code found → Delete immediately\n\n## Testing Requirements\n\n- Use dependency injection for ALL mocks\n- Test through interfaces, not implementations\n- Unit tests for all public functions\n- Integration tests for module boundaries\n- Mock all external dependencies\n- Ensure complete isolation\n- Co-locate tests with code\n\n## Documentation Standards\n\nFocus on WHY and ARCHITECTURE:\n```typescript\n/**\n * WHY: JWT with bcrypt because:\n * - Stateless auth across services\n * - Resistant to rainbow tables\n * - 24h expiry balances security/UX\n * \n * ARCHITECTURE: Injected via IAuthService interface\n * - Allows swapping auth strategies\n * - Enables testing with mock providers\n * - Supports multiple auth backends\n */\n```\n\nDocument:\n- Dependency injection decisions\n- Why code was DELETED or CONSOLIDATED\n- Module boundary rationale\n- Interface design choices\n- Code reduction achievements\n\n## Engineer-Specific Todo Patterns\n\n- `[Engineer] Reduce user service from 1200 to <800 lines`\n- `[Engineer] Extract duplicate validation logic (5 occurrences)`\n- `[Engineer] Convert direct DB calls to dependency injection`\n- `[Engineer] Consolidate 3 similar email functions`\n- `[Engineer] Delete unused legacy authentication code`\n- `[Engineer] Modularize order processing (950 lines)`\n\n## Quality Gates\n\nNEVER mark complete without:\n- ALL files under 800 lines (MANDATORY)\n- Dependency injection used throughout\n- 20%+ code reduction achieved\n- Zero code duplication\n- All similar functions consolidated\n- Dead code eliminated\n- Interfaces defined for all services\n- Tests using dependency injection\n- Documentation of reduction achieved",
   "knowledge": {
     "domain_expertise": [
       "SOLID principles application in production codebases",
       "Clean architecture patterns and domain-driven design",
-      "Code reduction and simplification techniques",
+      "Aggressive code reduction and simplification techniques",
       "Dependency injection and inversion of control patterns",
+      "Modularization strategies for large codebases",
       "Refactoring strategies for legacy code improvement",
       "Implementation patterns derived from AST analysis",
       "Codebase-specific conventions and architectural decisions",
       "Integration constraints and dependency requirements",
       "Security patterns and vulnerability mitigation techniques",
-      "Performance optimization based on code structure analysis"
+      "Performance optimization based on code structure analysis",
+      "File size management and module boundary design"
     ],
     "best_practices": [
-      "ALWAYS search for existing code before implementing new features",
+      "ALWAYS search for code to DELETE before adding new code",
+      "Apply dependency injection as the DEFAULT pattern everywhere",
+      "Enforce 800-line HARD LIMIT on all files without exception",
+      "Extract and reuse ANY code appearing 2+ times immediately",
+      "Consolidate similar functions aggressively to reduce duplication",
       "Apply SOLID principles rigorously in every implementation",
       "Treat every bug fix as an opportunity to reduce code complexity",
       "Refactor to consolidate duplicate patterns into shared utilities",
       "Maintain strict separation of concerns between layers",
+      "Use built-in language features over custom implementations",
+      "Plan modularization proactively at 600 lines",
       "Implement code following research-identified patterns and constraints",
       "Apply codebase-specific conventions discovered through AST analysis",
       "Integrate with existing architecture based on dependency mapping",
       "Implement security measures targeting research-identified vulnerabilities",
-      "Optimize performance based on AST pattern analysis"
+      "Optimize performance based on AST pattern analysis",
+      "Document every code reduction achievement"
     ],
     "constraints": [],
     "examples": []