chia-blockchain 2.5.1rc1__py3-none-any.whl

chia/_tests/wallet/nft_wallet/test_nft_1_offers.py

@@ -0,0 +1,1493 @@
+from __future__ import annotations
+
+import asyncio
+import logging
+import random
+from collections.abc import Coroutine
+from typing import Any, Callable, Optional
+
+import pytest
+
+from chia._tests.util.time_out_assert import time_out_assert, time_out_assert_not_none
+from chia.consensus.block_rewards import calculate_base_farmer_reward, calculate_pool_reward
+from chia.simulator.full_node_simulator import FullNodeSimulator
+from chia.simulator.simulator_protocol import FarmNewBlockProtocol
+from chia.types.blockchain_format.program import Program
+from chia.types.blockchain_format.sized_bytes import bytes32
+from chia.types.peer_info import PeerInfo
+from chia.util.ints import uint16, uint32, uint64, uint128
+from chia.wallet.cat_wallet.cat_wallet import CATWallet
+from chia.wallet.did_wallet.did_wallet import DIDWallet
+from chia.wallet.nft_wallet.nft_wallet import NFTWallet
+from chia.wallet.outer_puzzles import create_asset_id, match_puzzle
+from chia.wallet.puzzle_drivers import PuzzleInfo
+from chia.wallet.trading.offer import Offer
+from chia.wallet.trading.trade_status import TradeStatus
+from chia.wallet.uncurried_puzzle import uncurry_puzzle
+from chia.wallet.util.compute_memos import compute_memos
+from chia.wallet.util.tx_config import DEFAULT_TX_CONFIG
+from chia.wallet.wallet_node import WalletNode
+
+# from clvm_tools.binutils import disassemble
+
+logging.getLogger("aiosqlite").setLevel(logging.INFO)  # Too much logging on debug level
+
+
+def mempool_not_empty(fnapi: FullNodeSimulator) -> bool:
+    return fnapi.full_node.mempool_manager.mempool.size() > 0
+
+
+async def farm_blocks_until(
+    predicate_f: Callable[[], Coroutine[Any, Any, bool]], fnapi: FullNodeSimulator, ph: bytes32
+) -> None:
+    for i in range(50):
+        await fnapi.farm_new_transaction_block(FarmNewBlockProtocol(ph))
+        if await predicate_f():
+            return None
+        await asyncio.sleep(0.3)
+    raise TimeoutError()
+
+
+async def get_nft_count(wallet: NFTWallet) -> int:
+    return await wallet.get_nft_count()
+
+
+def trusted_setup_helper(
+    trusted: bool, wallet_node_maker: WalletNode, wallet_node_taker: WalletNode, full_node_api: FullNodeSimulator
+) -> None:
+    if trusted:
+        wallet_node_maker.config["trusted_peers"] = {
+            full_node_api.full_node.server.node_id.hex(): full_node_api.full_node.server.node_id.hex()
+        }
+        wallet_node_taker.config["trusted_peers"] = {
+            full_node_api.full_node.server.node_id.hex(): full_node_api.full_node.server.node_id.hex()
+        }
+    else:
+        wallet_node_maker.config["trusted_peers"] = {}
+        wallet_node_taker.config["trusted_peers"] = {}
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize("zero_royalties", [True, False])
+@pytest.mark.anyio
+async def test_nft_offer_sell_nft(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, zero_royalties: bool, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+    wallet_taker = wallet_node_taker.wallet_state_manager.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 2))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_taker, timeout=30)
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_maker.wallet_state_manager, wallet_maker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_maker.get_pending_change_balance, 0)
+    await time_out_assert(20, wallet_maker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, funds - 1)
+
+    hex_did_id = did_wallet_maker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_maker
+    royalty_puzhash = ph_maker
+    royalty_basis_pts = uint16(0 if zero_royalties else 200)
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_maker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_maker)
+
+    # TAKER SETUP -  NO DID
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET TAKER"
+    )
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+    trade_manager_taker = wallet_taker.wallet_state_manager.trade_manager
+
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 1
+    assert await nft_wallet_taker.get_nft_count() == 0
+
+    nft_to_offer = coins_maker[0]
+    nft_to_offer_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_offer.full_puzzle))
+    nft_to_offer_asset_id: bytes32 = create_asset_id(nft_to_offer_info)  # type: ignore
+    xch_requested = 1000
+    maker_fee = uint64(433)
+
+    offer_did_nft_for_xch = {nft_to_offer_asset_id: -1, wallet_maker.id(): xch_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            offer_did_nft_for_xch, action_scope, {}, fee=maker_fee
+        )
+    assert success is True
+    assert error is None
+    assert trade_make is not None
+
+    taker_fee = 1
+    assert not mempool_not_empty(full_node_api)
+    peer = wallet_node_taker.get_full_node_peer()
+
+    [_maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer), peer, action_scope, fee=uint64(taker_fee)
+        )
+
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+
+    assert trade_take is not None
+
+    async def maker_0_taker_1() -> bool:
+        return await nft_wallet_maker.get_nft_count() == 0 and await nft_wallet_taker.get_nft_count() == 1
+
+    await farm_blocks_until(maker_0_taker_1, full_node_api, ph_token)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 0, nft_wallet_maker)
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_taker)
+
+    # assert payments and royalties
+    expected_royalty = uint64(xch_requested * royalty_basis_pts / 10000)
+    expected_maker_balance = funds - 2 - maker_fee + xch_requested + expected_royalty
+    expected_taker_balance = funds - taker_fee - xch_requested - expected_royalty
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, expected_maker_balance)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, expected_taker_balance)
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize("zero_royalties", [True, False])
+@pytest.mark.anyio
+async def test_nft_offer_request_nft(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, zero_royalties: bool, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+    wallet_taker = wallet_node_taker.wallet_state_manager.main_wallet
+
+    ph_taker = await wallet_taker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 2))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_taker, timeout=30)
+
+    async with wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_taker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_taker.wallet_state_manager, wallet_taker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_taker.get_pending_change_balance, 0)
+
+    hex_did_id = did_wallet_taker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_taker
+    royalty_puzhash = ph_taker
+    royalty_basis_pts = uint16(0 if zero_royalties else 200)
+
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET DID TAKER", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+    await time_out_assert(20, wallet_taker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, funds - 1)
+
+    async with nft_wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_taker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_taker)
+
+    # MAKER SETUP -  NO DID
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET MAKER"
+    )
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+    trade_manager_taker = wallet_taker.wallet_state_manager.trade_manager
+
+    coins_taker = await nft_wallet_taker.get_current_nfts()
+    assert len(coins_taker) == 1
+
+    assert await nft_wallet_maker.get_nft_count() == 0
+    nft_to_request = coins_taker[0]
+    nft_to_request_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_request.full_puzzle))
+
+    assert isinstance(nft_to_request_info, PuzzleInfo)
+    nft_to_request_asset_id = create_asset_id(nft_to_request_info)
+    xch_offered = 1000
+    maker_fee = 10
+    driver_dict = {nft_to_request_asset_id: nft_to_request_info}
+
+    offer_dict = {nft_to_request_asset_id: 1, wallet_maker.id(): -xch_offered}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            offer_dict, action_scope, driver_dict, fee=maker_fee
+        )
+    assert success is True
+    assert error is None
+    assert trade_make is not None
+
+    taker_fee = 1
+
+    peer = wallet_node_taker.get_full_node_peer()
+    [_maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer), peer, action_scope, fee=uint64(taker_fee)
+        )
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+    assert trade_take is not None
+
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    async def maker_1_taker_0() -> bool:
+        return await nft_wallet_maker.get_nft_count() == 1 and await nft_wallet_taker.get_nft_count() == 0
+
+    await farm_blocks_until(maker_1_taker_0, full_node_api, ph_token)
+
+    # assert payments and royalties
+    expected_royalty = uint64(xch_offered * royalty_basis_pts / 10000)
+    expected_maker_balance = funds - maker_fee - xch_offered - expected_royalty
+    expected_taker_balance = funds - 2 - taker_fee + xch_offered + expected_royalty
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, expected_maker_balance)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, expected_taker_balance)
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize("zero_royalties", [True, False])
+@pytest.mark.anyio
+async def test_nft_offer_sell_did_to_did(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, zero_royalties: bool, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+    wallet_taker = wallet_node_taker.wallet_state_manager.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 2))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_taker, timeout=30)
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_maker.wallet_state_manager, wallet_maker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_maker.get_pending_change_balance, 0)
+
+    hex_did_id = did_wallet_maker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_maker
+    royalty_puzhash = ph_maker
+    royalty_basis_pts = uint16(0 if zero_royalties else 200)
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    await time_out_assert(20, wallet_maker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, funds - 1)
+
+    async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_maker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(bytes32.zeros))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_maker)
+
+    # TAKER SETUP -  WITH DID
+    async with wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_taker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_taker.wallet_state_manager, wallet_taker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_taker.get_pending_change_balance, 0)
+
+    hex_did_id_taker = did_wallet_taker.get_my_DID()
+    did_id_taker = bytes32.fromhex(hex_did_id_taker)
+
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET TAKER", did_id=did_id_taker
+    )
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+    trade_manager_taker = wallet_taker.wallet_state_manager.trade_manager
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 1
+    assert await nft_wallet_taker.get_nft_count() == 0
+    nft_to_offer = coins_maker[0]
+    nft_to_offer_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_offer.full_puzzle))
+    nft_to_offer_asset_id: bytes32 = create_asset_id(nft_to_offer_info)  # type: ignore
+    xch_requested = 1000
+    maker_fee = uint64(433)
+
+    offer_did_nft_for_xch = {nft_to_offer_asset_id: -1, wallet_maker.id(): xch_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            offer_did_nft_for_xch, action_scope, {}, fee=maker_fee
+        )
+    assert success is True
+    assert error is None
+    assert trade_make is not None
+
+    taker_fee = 1
+
+    peer = wallet_node_taker.get_full_node_peer()
+    [_maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer), peer, action_scope, fee=uint64(taker_fee)
+        )
+
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+    assert trade_take is not None
+
+    async def maker_0_taker_1() -> bool:
+        return (
+            await nft_wallet_maker.get_nft_count() == 0
+            and len(wallet_taker.wallet_state_manager.wallets) == 4
+            and await wallet_taker.wallet_state_manager.wallets[4].get_nft_count() == 1
+        )
+
+    await farm_blocks_until(maker_0_taker_1, full_node_api, ph_token)
+
+    await time_out_assert(20, get_nft_count, 0, nft_wallet_maker)
+    # assert nnew nft wallet is created for taker
+    await time_out_assert(20, len, 4, wallet_taker.wallet_state_manager.wallets)
+    await time_out_assert(20, get_nft_count, 1, wallet_taker.wallet_state_manager.wallets[4])
+    assert await wallet_taker.wallet_state_manager.wallets[4].nft_store.get_nft_by_id(nft_to_offer_asset_id) is not None
+    # assert payments and royalties
+    expected_royalty = uint64(xch_requested * royalty_basis_pts / 10000)
+    expected_maker_balance = funds - 2 - maker_fee + xch_requested + expected_royalty
+    expected_taker_balance = funds - 1 - taker_fee - xch_requested - expected_royalty
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, expected_maker_balance)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, expected_taker_balance)
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize("zero_royalties", [True, False])
+@pytest.mark.anyio
+async def test_nft_offer_sell_nft_for_cat(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, zero_royalties: bool, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+    wallet_taker = wallet_node_taker.wallet_state_manager.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 2))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_taker, timeout=30)
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_maker.wallet_state_manager, wallet_maker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_maker.get_pending_change_balance, 0)
+    await time_out_assert(20, wallet_maker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, funds - 1)
+
+    hex_did_id = did_wallet_maker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_maker
+    royalty_puzhash = ph_maker
+    royalty_basis_pts = uint16(0 if zero_royalties else 200)
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_maker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_maker)
+
+    # TAKER SETUP -  NO DID
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET TAKER"
+    )
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+    trade_manager_taker = wallet_taker.wallet_state_manager.trade_manager
+
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 1
+    coins_taker = await nft_wallet_taker.get_current_nfts()
+    assert len(coins_taker) == 0
+
+    # Create new CAT and wallets for maker and taker
+    # Trade them between maker and taker to ensure multiple coins for each cat
+    cats_to_mint = 100000
+    cats_to_trade = uint64(10000)
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        full_node_api.full_node.log.warning(f"Mempool size: {full_node_api.full_node.mempool_manager.mempool.size()}")
+        cat_wallet_maker = await CATWallet.create_new_cat_wallet(
+            wallet_node_maker.wallet_state_manager,
+            wallet_maker,
+            {"identifier": "genesis_by_id"},
+            uint64(cats_to_mint),
+            action_scope,
+        )
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, cat_wallet_maker.get_confirmed_balance, cats_to_mint)
+    await time_out_assert(20, cat_wallet_maker.get_unconfirmed_balance, cats_to_mint)
+
+    cat_wallet_taker: CATWallet = await CATWallet.get_or_create_wallet_for_cat(
+        wallet_node_taker.wallet_state_manager, wallet_taker, cat_wallet_maker.get_asset_id()
+    )
+
+    ph_taker_cat_1 = await wallet_taker.get_new_puzzlehash()
+    ph_taker_cat_2 = await wallet_taker.get_new_puzzlehash()
+    async with cat_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await cat_wallet_maker.generate_signed_transaction(
+            [cats_to_trade, cats_to_trade],
+            [ph_taker_cat_1, ph_taker_cat_2],
+            action_scope,
+            memos=[[ph_taker_cat_1], [ph_taker_cat_2]],
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    maker_cat_balance = cats_to_mint - (2 * cats_to_trade)
+    taker_cat_balance = 2 * cats_to_trade
+    await time_out_assert(20, cat_wallet_maker.get_confirmed_balance, maker_cat_balance)
+    await time_out_assert(20, cat_wallet_taker.get_confirmed_balance, taker_cat_balance)
+    nft_to_offer = coins_maker[0]
+    nft_to_offer_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_offer.full_puzzle))
+    nft_to_offer_asset_id: bytes32 = create_asset_id(nft_to_offer_info)  # type: ignore
+    cats_requested = 1000
+    maker_fee = uint64(433)
+
+    offer_did_nft_for_xch = {nft_to_offer_asset_id: -1, cat_wallet_maker.id(): cats_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            offer_did_nft_for_xch, action_scope, {}, fee=maker_fee
+        )
+
+    assert success is True
+    assert error is None
+    assert trade_make is not None
+
+    taker_fee = 1
+
+    peer = wallet_node_taker.get_full_node_peer()
+    [_maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer), peer, action_scope, fee=uint64(taker_fee)
+        )
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+    assert trade_take is not None
+
+    async def maker_0_taker_1() -> bool:
+        return (
+            len(await nft_wallet_maker.get_current_nfts()) == 0 and len(await nft_wallet_taker.get_current_nfts()) == 1
+        )
+
+    await farm_blocks_until(maker_0_taker_1, full_node_api, ph_token)
+
+    # assert payments and royalties
+    expected_royalty = uint64(cats_requested * royalty_basis_pts / 10000)
+    expected_maker_balance = funds - 2 - cats_to_mint - maker_fee
+    expected_taker_balance = funds - taker_fee
+    expected_maker_cat_balance = maker_cat_balance + cats_requested + expected_royalty
+    expected_taker_cat_balance = taker_cat_balance - cats_requested - expected_royalty
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, expected_maker_balance)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, expected_taker_balance)
+    await time_out_assert(20, cat_wallet_maker.get_confirmed_balance, expected_maker_cat_balance)
+    await time_out_assert(20, cat_wallet_taker.get_confirmed_balance, expected_taker_cat_balance)
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize("test_change", [True, False])
+@pytest.mark.anyio
+async def test_nft_offer_request_nft_for_cat(
+    self_hostname: str, two_wallet_nodes: Any, trusted: bool, test_change: bool, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+    wallet_taker = wallet_node_taker.wallet_state_manager.main_wallet
+
+    ph_taker = await wallet_taker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 2))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_taker, timeout=30)
+
+    async with wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_taker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_taker.wallet_state_manager, wallet_taker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, wallet_taker.get_pending_change_balance, 0)
+    await time_out_assert(20, wallet_taker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, funds - 1)
+
+    hex_did_id = did_wallet_taker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_taker
+    royalty_puzhash = ph_taker
+    royalty_basis_pts = uint16(5000)  # 50%
+
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET DID TAKER", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    async with nft_wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_taker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_taker)
+
+    # MAKER SETUP -  NO DID
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET MAKER"
+    )
+
+    # maker create offer: NFT for CAT
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+    trade_manager_taker = wallet_taker.wallet_state_manager.trade_manager
+
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 0
+    coins_taker = await nft_wallet_taker.get_current_nfts()
+    assert len(coins_taker) == 1
+
+    # Create new CAT and wallets for maker and taker
+    # Trade them between maker and taker to ensure multiple coins for each cat
+    cats_to_mint = 100000
+    cats_to_trade = uint64(20000)
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        cat_wallet_maker = await CATWallet.create_new_cat_wallet(
+            wallet_node_maker.wallet_state_manager,
+            wallet_maker,
+            {"identifier": "genesis_by_id"},
+            uint64(cats_to_mint),
+            action_scope,
+        )
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    await time_out_assert(20, cat_wallet_maker.get_confirmed_balance, cats_to_mint)
+    await time_out_assert(20, cat_wallet_maker.get_unconfirmed_balance, cats_to_mint)
+
+    cat_wallet_taker: CATWallet = await CATWallet.get_or_create_wallet_for_cat(
+        wallet_node_taker.wallet_state_manager, wallet_taker, cat_wallet_maker.get_asset_id()
+    )
+    if test_change:
+        cat_1 = await wallet_maker.get_new_puzzlehash()
+        cat_2 = await wallet_maker.get_new_puzzlehash()
+    else:
+        cat_1 = await wallet_taker.get_new_puzzlehash()
+        cat_2 = await wallet_taker.get_new_puzzlehash()
+    puzzle_hashes = [cat_1, cat_2]
+    amounts = [cats_to_trade, cats_to_trade]
+    if test_change:
+        ph_taker_cat_1 = await wallet_taker.get_new_puzzlehash()
+        extra_change = cats_to_mint - (2 * cats_to_trade)
+        amounts.append(uint64(extra_change))
+        puzzle_hashes.append(ph_taker_cat_1)
+    async with cat_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await cat_wallet_maker.generate_signed_transaction(amounts, puzzle_hashes, action_scope)
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=20)
+
+    if test_change:
+        taker_cat_balance = cats_to_mint - (2 * cats_to_trade)
+        maker_cat_balance = 2 * cats_to_trade
+    else:
+        maker_cat_balance = cats_to_mint - (2 * cats_to_trade)
+        taker_cat_balance = 2 * cats_to_trade
+    await time_out_assert(15, cat_wallet_maker.get_confirmed_balance, maker_cat_balance)
+    await time_out_assert(15, cat_wallet_taker.get_confirmed_balance, taker_cat_balance)
+
+    nft_to_request = coins_taker[0]
+    nft_to_request_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_request.full_puzzle))
+    nft_to_request_asset_id: bytes32 = create_asset_id(nft_to_request_info)  # type: ignore
+    cats_requested = 10000
+    maker_fee = uint64(433)
+    driver_dict = {nft_to_request_asset_id: nft_to_request_info}
+
+    offer_dict = {nft_to_request_asset_id: 1, cat_wallet_maker.id(): -cats_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            offer_dict, action_scope, driver_dict, fee=maker_fee
+        )
+    assert success is True
+    assert error is None
+    assert trade_make is not None
+
+    taker_fee = 1
+
+    peer = wallet_node_taker.get_full_node_peer()
+    [_maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer), peer, action_scope, fee=uint64(taker_fee)
+        )
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+    assert trade_take is not None
+
+    async def maker_1_taker_0() -> bool:
+        return (
+            len(await nft_wallet_maker.get_current_nfts()) == 1 and len(await nft_wallet_taker.get_current_nfts()) == 0
+        )
+
+    await farm_blocks_until(maker_1_taker_0, full_node_api, ph_token)
+
+    # assert payments and royalties
+    expected_royalty = uint64(cats_requested * royalty_basis_pts / 10000)
+    expected_maker_balance = funds - cats_to_mint - maker_fee
+    expected_taker_balance = funds - 2 - taker_fee
+    expected_maker_cat_balance = maker_cat_balance - cats_requested - expected_royalty
+    expected_taker_cat_balance = taker_cat_balance + cats_requested + expected_royalty
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, expected_maker_balance)
+    await time_out_assert(20, wallet_taker.get_confirmed_balance, expected_taker_balance)
+    await time_out_assert(20, cat_wallet_maker.get_confirmed_balance, expected_maker_cat_balance)
+    await time_out_assert(20, cat_wallet_taker.get_confirmed_balance, expected_taker_cat_balance)
+
+
+@pytest.mark.parametrize(
+    "trusted",
+    [True, False],
+)
+@pytest.mark.anyio
+# @pytest.mark.skip
+async def test_nft_offer_sell_cancel(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, seeded_random: random.Random
+) -> None:
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    if trusted:
+        wallet_node_maker.config["trusted_peers"] = {
+            full_node_api.full_node.server.node_id.hex(): full_node_api.full_node.server.node_id.hex()
+        }
+    else:
+        wallet_node_maker.config["trusted_peers"] = {}
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 3))
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_maker.wallet_state_manager, wallet_maker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker], timeout=20)
+
+    await time_out_assert(20, wallet_maker.get_pending_change_balance, 0)
+    await time_out_assert(20, wallet_maker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(20, wallet_maker.get_confirmed_balance, funds - 1)
+
+    hex_did_id = did_wallet_maker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_maker
+    royalty_puzhash = ph_maker
+    royalty_basis_pts = uint16(200)
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_maker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker], timeout=20)
+
+    await time_out_assert(20, get_nft_count, 1, nft_wallet_maker)
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 1
+
+    nft_to_offer = coins_maker[0]
+    nft_to_offer_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_offer.full_puzzle))
+    nft_to_offer_asset_id: bytes32 = create_asset_id(nft_to_offer_info)  # type: ignore
+    xch_requested = 1000
+    maker_fee = uint64(433)
+
+    offer_did_nft_for_xch = {nft_to_offer_asset_id: -1, wallet_maker.id(): xch_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        _success, trade_make, _error = await trade_manager_maker.create_offer_for_ids(
+            offer_did_nft_for_xch, action_scope, {}, fee=maker_fee
+        )
+
+    FEE = uint64(2000000000000)
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await trade_manager_maker.cancel_pending_offers([trade_make.trade_id], action_scope, fee=FEE, secure=True)
+
+    async def get_trade_and_status(trade_manager: Any, trade: Any) -> TradeStatus:
+        trade_rec = await trade_manager.get_trade_by_id(trade.trade_id)
+        return TradeStatus(trade_rec.status)
+
+    await time_out_assert(20, get_trade_and_status, TradeStatus.PENDING_CANCEL, trade_manager_maker, trade_make)
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker], timeout=20)
+
+    await time_out_assert(15, get_trade_and_status, TradeStatus.CANCELLED, trade_manager_maker, trade_make)
+
+
+@pytest.mark.parametrize(
+    "trusted",
+    [True],
+)
+@pytest.mark.anyio
+async def test_nft_offer_sell_cancel_in_batch(
+    self_hostname: str, two_wallet_nodes: Any, trusted: Any, seeded_random: random.Random
+) -> None:
+    num_blocks = 3
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_maker = wallet_node_maker.wallet_state_manager.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    if trusted:
+        wallet_node_maker.config["trusted_peers"] = {
+            full_node_api.full_node.server.node_id.hex(): full_node_api.full_node.server.node_id.hex()
+        }
+    else:
+        wallet_node_maker.config["trusted_peers"] = {}
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    funds = sum(
+        calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, num_blocks)
+    )
+    await full_node_api.farm_rewards_to_wallet(funds, wallet_maker, timeout=30)
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wallet_node_maker.wallet_state_manager, wallet_maker, uint64(1), action_scope
+        )
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+
+    await time_out_assert(15, wallet_maker.get_pending_change_balance, 0)
+    await time_out_assert(10, wallet_maker.get_unconfirmed_balance, funds - 1)
+    await time_out_assert(10, wallet_maker.get_confirmed_balance, funds - 1)
+
+    hex_did_id = did_wallet_maker.get_my_DID()
+    did_id = bytes32.fromhex(hex_did_id)
+    target_puzhash = ph_maker
+    royalty_puzhash = ph_maker
+    royalty_basis_pts = uint16(200)
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+
+    async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_maker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash,
+            royalty_puzhash,
+            royalty_basis_pts,
+            did_id,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            assert compute_memos(tx.spend_bundle)
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+
+    for i in range(1, num_blocks):
+        await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+
+    await time_out_assert(10, get_nft_count, 1, nft_wallet_maker)
+
+    # maker create offer: NFT for xch
+    trade_manager_maker = wallet_maker.wallet_state_manager.trade_manager
+
+    coins_maker = await nft_wallet_maker.get_current_nfts()
+    assert len(coins_maker) == 1
+
+    nft_to_offer = coins_maker[0]
+    nft_to_offer_info: Optional[PuzzleInfo] = match_puzzle(uncurry_puzzle(nft_to_offer.full_puzzle))
+    nft_to_offer_asset_id: bytes32 = create_asset_id(nft_to_offer_info)  # type: ignore
+    xch_requested = 1000
+    maker_fee = uint64(433)
+
+    offer_did_nft_for_xch = {nft_to_offer_asset_id: -1, wallet_maker.id(): xch_requested}
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        _success, trade_make, _error = await trade_manager_maker.create_offer_for_ids(
+            offer_did_nft_for_xch, action_scope, {}, fee=maker_fee
+        )
+
+    FEE = uint64(2000000000000)
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await trade_manager_maker.cancel_pending_offers([trade_make.trade_id], action_scope, fee=FEE, secure=True)
+
+    async def get_trade_and_status(trade_manager: Any, trade: Any) -> TradeStatus:
+        trade_rec = await trade_manager.get_trade_by_id(trade.trade_id)
+        return TradeStatus(trade_rec.status)
+
+    await time_out_assert(15, get_trade_and_status, TradeStatus.PENDING_CANCEL, trade_manager_maker, trade_make)
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+
+    for i in range(1, num_blocks):
+        await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(bytes32.zeros))
+
+    await time_out_assert(15, get_trade_and_status, TradeStatus.CANCELLED, trade_manager_maker, trade_make)
+
+
+@pytest.mark.parametrize("trusted", [True, False])
+@pytest.mark.parametrize(
+    "royalty_pts",
+    [
+        (200, 500, 500),
+        (200, 500, 500),
+        (0, 0, 0),  # test that we can have 0 royalty
+        (10000, 10001, 10005),  # tests 100% royalty is not allowed
+        (100000, 10001, 10005),  # 1000% shouldn't work
+    ],
+)
+@pytest.mark.anyio
+async def test_complex_nft_offer(
+    self_hostname: str,
+    two_wallet_nodes: Any,
+    trusted: Any,
+    royalty_pts: tuple[int, int, int],
+    seeded_random: random.Random,
+) -> None:
+    """
+    This test is going to create an offer where the maker offers 1 NFT and 1 CAT for 2 NFTs, an XCH and a CAT
+    """
+    full_nodes, wallets, _ = two_wallet_nodes
+    full_node_api: FullNodeSimulator = full_nodes[0]
+    full_node_server = full_node_api.server
+    wallet_node_maker, server_0 = wallets[0]
+    wallet_node_taker, server_1 = wallets[1]
+    wsm_maker = wallet_node_maker.wallet_state_manager
+    wsm_taker = wallet_node_taker.wallet_state_manager
+    wallet_maker = wsm_maker.main_wallet
+    wallet_taker = wsm_taker.main_wallet
+
+    ph_maker = await wallet_maker.get_new_puzzlehash()
+    ph_taker = await wallet_taker.get_new_puzzlehash()
+    ph_token = bytes32.random(seeded_random)
+
+    trusted_setup_helper(trusted, wallet_node_maker, wallet_node_taker, full_node_api)
+    wallet_node_maker.config["automatically_add_unknown_cats"] = True
+    wallet_node_taker.config["automatically_add_unknown_cats"] = True
+
+    await server_0.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+    await server_1.start_client(PeerInfo(self_hostname, full_node_server.get_port()), None)
+
+    # Need money for fees and offering
+    funds_maker = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 3))
+    funds_taker = sum(calculate_pool_reward(uint32(i)) + calculate_base_farmer_reward(uint32(i)) for i in range(1, 6))
+
+    await full_node_api.farm_rewards_to_wallet(amount=funds_maker, wallet=wsm_maker.main_wallet, timeout=60)
+    await full_node_api.farm_rewards_to_wallet(amount=funds_taker, wallet=wsm_taker.main_wallet, timeout=60)
+
+    CAT_AMOUNT = uint64(100000000)
+    txs = []
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        cat_wallet_maker = await CATWallet.create_new_cat_wallet(
+            wsm_maker, wallet_maker, {"identifier": "genesis_by_id"}, CAT_AMOUNT, action_scope
+        )
+    txs.extend(action_scope.side_effects.transactions)
+    async with wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        cat_wallet_taker = await CATWallet.create_new_cat_wallet(
+            wsm_taker, wallet_taker, {"identifier": "genesis_by_id"}, CAT_AMOUNT, action_scope
+        )
+    txs.extend(action_scope.side_effects.transactions)
+
+    # We'll need these later
+    basic_nft_wallet_maker = await NFTWallet.create_new_nft_wallet(wsm_maker, wallet_maker, name="NFT WALLET MAKER")
+    basic_nft_wallet_taker = await NFTWallet.create_new_nft_wallet(wsm_taker, wallet_taker, name="NFT WALLET TAKER")
+
+    async with wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_maker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wsm_maker, wallet_maker, uint64(1), action_scope
+        )
+    txs.extend(action_scope.side_effects.transactions)
+    async with wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        did_wallet_taker: DIDWallet = await DIDWallet.create_new_did_wallet(
+            wsm_taker, wallet_taker, uint64(1), action_scope
+        )
+    txs.extend(action_scope.side_effects.transactions)
+
+    await full_node_api.process_transaction_records(records=txs)
+
+    funds_maker = funds_maker - 1 - CAT_AMOUNT
+    funds_taker = funds_taker - 1 - CAT_AMOUNT
+
+    await time_out_assert(30, wallet_maker.get_unconfirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_maker.get_confirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_taker.get_unconfirmed_balance, funds_taker)
+    await time_out_assert(30, wallet_taker.get_confirmed_balance, funds_taker)
+    await time_out_assert(30, cat_wallet_maker.get_confirmed_balance, CAT_AMOUNT)
+    await time_out_assert(30, cat_wallet_maker.get_unconfirmed_balance, CAT_AMOUNT)
+    await time_out_assert(30, cat_wallet_taker.get_confirmed_balance, CAT_AMOUNT)
+    await time_out_assert(30, cat_wallet_taker.get_unconfirmed_balance, CAT_AMOUNT)
+    did_id_maker = bytes32.fromhex(did_wallet_maker.get_my_DID())
+    did_id_taker = bytes32.fromhex(did_wallet_taker.get_my_DID())
+    target_puzhash_maker = ph_maker
+    target_puzhash_taker = ph_taker
+    royalty_puzhash_maker = ph_maker
+    royalty_puzhash_taker = ph_taker
+    royalty_basis_pts_maker, royalty_basis_pts_taker_1, royalty_basis_pts_taker_2 = (
+        royalty_pts[0],
+        uint16(royalty_pts[1]),
+        uint16(royalty_pts[2]),
+    )
+
+    nft_wallet_maker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_maker.wallet_state_manager, wallet_maker, name="NFT WALLET DID 1", did_id=did_id_maker
+    )
+    nft_wallet_taker = await NFTWallet.create_new_nft_wallet(
+        wallet_node_taker.wallet_state_manager, wallet_taker, name="NFT WALLET DID 1", did_id=did_id_taker
+    )
+    metadata = Program.to(
+        [
+            ("u", ["https://www.chia.net/img/branding/chia-logo.svg"]),
+            ("h", "0xD4584AD463139FA8C0D9F68F4B59F185"),
+        ]
+    )
+    if royalty_basis_pts_maker > 65535:
+        with pytest.raises(ValueError):
+            async with nft_wallet_maker.wallet_state_manager.new_action_scope(
+                DEFAULT_TX_CONFIG, push=False
+            ) as action_scope:
+                await nft_wallet_maker.generate_new_nft(
+                    metadata,
+                    action_scope,
+                    target_puzhash_maker,
+                    royalty_puzhash_maker,
+                    royalty_basis_pts_maker,  # type: ignore
+                    did_id_maker,
+                )
+        return
+    else:
+        async with nft_wallet_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+            await nft_wallet_maker.generate_new_nft(
+                metadata,
+                action_scope,
+                target_puzhash_maker,
+                royalty_puzhash_maker,
+                uint16(royalty_basis_pts_maker),
+                did_id_maker,
+            )
+        for tx in action_scope.side_effects.transactions:
+            if tx.spend_bundle is not None:
+                await time_out_assert_not_none(
+                    20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+                )
+
+    async with nft_wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_taker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash_taker,
+            royalty_puzhash_taker,
+            royalty_basis_pts_taker_1,
+            did_id_taker,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+
+    funds_maker -= 1
+    funds_taker -= 1
+
+    await time_out_assert(30, wallet_maker.get_unconfirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_maker.get_confirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_taker.get_unconfirmed_balance, funds_taker)
+    await time_out_assert(30, wallet_taker.get_confirmed_balance, funds_taker)
+    await time_out_assert(30, get_nft_count, 1, nft_wallet_maker)
+    await time_out_assert(30, get_nft_count, 1, nft_wallet_taker)
+
+    # MAke one more NFT for the taker
+    async with nft_wallet_taker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=True) as action_scope:
+        await nft_wallet_taker.generate_new_nft(
+            metadata,
+            action_scope,
+            target_puzhash_taker,
+            royalty_puzhash_taker,
+            royalty_basis_pts_taker_2,
+            did_id_taker,
+        )
+    for tx in action_scope.side_effects.transactions:
+        if tx.spend_bundle is not None:
+            await time_out_assert_not_none(
+                20, full_node_api.full_node.mempool_manager.get_spendbundle, tx.spend_bundle.name()
+            )
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+
+    funds_taker -= 1
+
+    await time_out_assert(30, wallet_taker.get_unconfirmed_balance, funds_taker)
+    await time_out_assert(30, wallet_taker.get_confirmed_balance, funds_taker)
+    await time_out_assert(30, get_nft_count, 2, nft_wallet_taker)
+
+    trade_manager_maker = wsm_maker.trade_manager
+    trade_manager_taker = wsm_taker.trade_manager
+    maker_nfts = await nft_wallet_maker.get_current_nfts()
+    taker_nfts = await nft_wallet_taker.get_current_nfts()
+    nft_to_offer_asset_id_maker: bytes32 = maker_nfts[0].nft_id
+    nft_to_offer_asset_id_taker_1: bytes32 = taker_nfts[0].nft_id
+    nft_to_offer_asset_id_taker_2: bytes32 = taker_nfts[1].nft_id
+    if royalty_basis_pts_maker > 60000:
+        XCH_REQUESTED = 20000
+        CAT_REQUESTED = 1000
+        FEE = uint64(20000)
+    else:
+        XCH_REQUESTED = 2000000000000
+        CAT_REQUESTED = 100000
+        FEE = uint64(2000000000000)
+
+    complex_nft_offer = {
+        nft_to_offer_asset_id_maker: -1,
+        cat_wallet_maker.id(): CAT_REQUESTED * -1,
+        1: XCH_REQUESTED,
+        nft_to_offer_asset_id_taker_1: 1,
+        nft_to_offer_asset_id_taker_2: 1,
+        bytes32.from_hexstr(cat_wallet_taker.get_asset_id()): CAT_REQUESTED,
+    }
+
+    driver_dict = {
+        nft_to_offer_asset_id_taker_1: match_puzzle(uncurry_puzzle(taker_nfts[0].full_puzzle)),
+        nft_to_offer_asset_id_taker_2: match_puzzle(uncurry_puzzle(taker_nfts[1].full_puzzle)),
+        bytes32.from_hexstr(cat_wallet_taker.get_asset_id()): PuzzleInfo(
+            {
+                "type": "CAT",
+                "tail": "0x" + cat_wallet_taker.get_asset_id(),
+            }
+        ),
+    }
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            complex_nft_offer, action_scope, driver_dict=driver_dict, fee=FEE
+        )
+    assert error is None
+    assert success
+    assert trade_make is not None
+
+    [maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    if royalty_basis_pts_maker == 10000:
+        with pytest.raises(ValueError):
+            async with trade_manager_taker.wallet_state_manager.new_action_scope(
+                DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+            ) as action_scope:
+                trade_take = await trade_manager_taker.respond_to_offer(
+                    Offer.from_bytes(trade_make.offer),
+                    wallet_node_taker.get_full_node_peer(),
+                    action_scope,
+                    fee=FEE,
+                )
+        # all done for this test
+        return
+    else:
+        async with trade_manager_taker.wallet_state_manager.new_action_scope(
+            DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+        ) as action_scope:
+            trade_take = await trade_manager_taker.respond_to_offer(
+                maker_offer,
+                wallet_node_taker.get_full_node_peer(),
+                action_scope,
+                fee=FEE,
+            )
+    assert trade_take is not None
+    await full_node_api.process_transaction_records(records=action_scope.side_effects.transactions)
+    await full_node_api.wait_for_wallets_synced(wallet_nodes=[wallet_node_maker, wallet_node_taker], timeout=60)
+
+    # Now let's make sure the final wallet state is correct
+    maker_royalty_summary = NFTWallet.royalty_calculation(
+        {
+            nft_to_offer_asset_id_maker: (royalty_puzhash_maker, uint16(royalty_basis_pts_maker)),
+        },
+        {
+            None: uint64(XCH_REQUESTED),
+            bytes32.from_hexstr(cat_wallet_taker.get_asset_id()): uint64(CAT_REQUESTED),
+        },
+    )
+    taker_royalty_summary = NFTWallet.royalty_calculation(
+        {
+            nft_to_offer_asset_id_taker_1: (royalty_puzhash_taker, royalty_basis_pts_taker_1),
+            nft_to_offer_asset_id_taker_2: (royalty_puzhash_taker, royalty_basis_pts_taker_2),
+        },
+        {
+            bytes32.from_hexstr(cat_wallet_maker.get_asset_id()): uint64(CAT_REQUESTED),
+        },
+    )
+    maker_xch_royalties_expected = maker_royalty_summary[nft_to_offer_asset_id_maker][0]["amount"]
+    maker_cat_royalties_expected = maker_royalty_summary[nft_to_offer_asset_id_maker][1]["amount"]
+    taker_cat_royalties_expected = (
+        taker_royalty_summary[nft_to_offer_asset_id_taker_1][0]["amount"]
+        + taker_royalty_summary[nft_to_offer_asset_id_taker_2][0]["amount"]
+    )
+    funds_maker = int(funds_maker - FEE + XCH_REQUESTED + maker_xch_royalties_expected)
+    funds_taker = int(funds_taker - FEE - XCH_REQUESTED - maker_xch_royalties_expected)
+
+    await time_out_assert(30, wallet_maker.get_unconfirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_maker.get_confirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_taker.get_unconfirmed_balance, funds_taker)
+    await time_out_assert(30, wallet_taker.get_confirmed_balance, funds_taker)
+
+    async def get_cat_wallet_and_check_balance(asset_id: str, wsm: Any) -> uint128:
+        cat_wallet = await wsm.get_wallet_for_asset_id(asset_id)
+        if cat_wallet is None:
+            return uint128(0)
+        else:
+            return uint128(await cat_wallet.get_confirmed_balance())
+
+    taker_cat_funds_maker = CAT_REQUESTED + maker_cat_royalties_expected
+    maker_cat_funds_taker = CAT_REQUESTED + taker_cat_royalties_expected
+    await time_out_assert(
+        30,
+        get_cat_wallet_and_check_balance,
+        taker_cat_funds_maker,
+        cat_wallet_taker.get_asset_id(),
+        wsm_maker,
+    )
+    await time_out_assert(
+        30,
+        get_cat_wallet_and_check_balance,
+        maker_cat_funds_taker,
+        cat_wallet_maker.get_asset_id(),
+        wsm_taker,
+    )
+    maker_nfts = await basic_nft_wallet_maker.get_current_nfts()
+    taker_nfts = await basic_nft_wallet_taker.get_current_nfts()
+    assert len(maker_nfts) == 2
+    assert len(taker_nfts) == 1
+
+    assert nft_to_offer_asset_id_maker == taker_nfts[0].nft_id
+    assert nft_to_offer_asset_id_taker_1 in [nft.nft_id for nft in maker_nfts]
+    assert nft_to_offer_asset_id_taker_2 in [nft.nft_id for nft in maker_nfts]
+
+    # Try another permutation
+    complex_nft_offer = {
+        cat_wallet_maker.id(): CAT_REQUESTED * -1,
+        1: int(XCH_REQUESTED / 2),
+        bytes32.from_hexstr(cat_wallet_taker.get_asset_id()): CAT_REQUESTED,
+        nft_to_offer_asset_id_maker: 1,
+    }
+
+    driver_dict = {
+        nft_to_offer_asset_id_maker: match_puzzle(uncurry_puzzle(taker_nfts[0].full_puzzle)),
+        bytes32.from_hexstr(cat_wallet_taker.get_asset_id()): PuzzleInfo(
+            {
+                "type": "CAT",
+                "tail": "0x" + cat_wallet_taker.get_asset_id(),
+            }
+        ),
+    }
+
+    async with trade_manager_maker.wallet_state_manager.new_action_scope(DEFAULT_TX_CONFIG, push=False) as action_scope:
+        success, trade_make, error = await trade_manager_maker.create_offer_for_ids(
+            complex_nft_offer, action_scope, driver_dict=driver_dict, fee=uint64(0)
+        )
+    assert error is None
+    assert success
+    assert trade_make is not None
+
+    [maker_offer], signing_response = await wallet_node_maker.wallet_state_manager.sign_offers(
+        [Offer.from_bytes(trade_make.offer)]
+    )
+    async with trade_manager_taker.wallet_state_manager.new_action_scope(
+        DEFAULT_TX_CONFIG, push=True, additional_signing_responses=signing_response
+    ) as action_scope:
+        trade_take = await trade_manager_taker.respond_to_offer(
+            Offer.from_bytes(trade_make.offer),
+            wallet_node_taker.get_full_node_peer(),
+            action_scope,
+            fee=uint64(0),
+        )
+    assert trade_take is not None
+    await time_out_assert(20, mempool_not_empty, True, full_node_api)
+
+    await full_node_api.farm_new_transaction_block(FarmNewBlockProtocol(ph_token))
+
+    # Now let's make sure the final wallet state is correct
+    funds_maker = int(funds_maker + XCH_REQUESTED / 2)
+    funds_taker = int(funds_taker - XCH_REQUESTED / 2)
+
+    await time_out_assert(30, wallet_maker.get_unconfirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_maker.get_confirmed_balance, funds_maker)
+    await time_out_assert(30, wallet_taker.get_unconfirmed_balance, funds_taker)
+    await time_out_assert(30, wallet_taker.get_confirmed_balance, funds_taker)
+
+    await time_out_assert(
+        30,
+        get_cat_wallet_and_check_balance,
+        taker_cat_funds_maker + CAT_REQUESTED,
+        cat_wallet_taker.get_asset_id(),
+        wsm_maker,
+    )
+    await time_out_assert(
+        30,
+        get_cat_wallet_and_check_balance,
+        maker_cat_funds_taker + CAT_REQUESTED,
+        cat_wallet_maker.get_asset_id(),
+        wsm_taker,
+    )
+    await time_out_assert(20, get_nft_count, 3, basic_nft_wallet_maker)
+    await time_out_assert(20, get_nft_count, 0, basic_nft_wallet_taker)
+    assert await basic_nft_wallet_maker.nft_store.get_nft_by_id(nft_to_offer_asset_id_maker) is not None