ardupilot-methodic-configurator 2.6.0__py3-none-any.whl → 2.7.0__py3-none-any.whl

ardupilot_methodic_configurator/frontend_tkinter_parameter_editor_table.py

@@ -1,7 +1,7 @@
 """
 Parameter editor table GUI using the "Ardupilot Parameter data model".
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 
@@ -60,7 +60,6 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         self.configuration_manager = configuration_manager
         self.parameter_editor = parameter_editor  # the parent window that contains this table
         self.upload_checkbutton_var: dict[str, tk.BooleanVar] = {}
-        self.at_least_one_param_edited = False
 
         # Track last return values to prevent duplicate event processing
         self._last_return_values: dict[tk.Misc, str] = {}
@@ -128,7 +127,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         return tuple(base_headers), tuple(base_tooltips)
 
     def repopulate(  # pylint: disable=too-many-locals
-        self, show_only_differences: bool, gui_complexity: str
+        self, show_only_differences: bool, gui_complexity: str, regenerate_from_disk: bool
     ) -> None:
         for widget in self.view_port.winfo_children():
             widget.destroy()
@@ -151,14 +150,13 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         self.upload_checkbutton_var = {}
 
         # Process configuration step and create domain model parameters
-        (config_step_edited, ui_errors, ui_infos) = self.configuration_manager.repopulate_configuration_step_parameters()
-        if config_step_edited:
-            self.at_least_one_param_edited = True
+        if regenerate_from_disk:
+            (ui_errors, ui_infos) = self.configuration_manager.repopulate_configuration_step_parameters()
 
-        for title, msg in ui_errors:
-            messagebox.showerror(title, msg)
-        for title, msg in ui_infos:
-            messagebox.showinfo(title, msg)
+            for title, msg in ui_errors:
+                messagebox.showerror(title, msg)
+            for title, msg in ui_infos:
+                messagebox.showinfo(title, msg)
 
         if show_only_differences:
             # Filter to show only different parameters
@@ -173,7 +171,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
                 self.parameter_editor.on_skip_click()
                 return
         else:
-            self._update_table(self.configuration_manager.parameters, self.parameter_editor.gui_complexity)
+            self._update_table(self.configuration_manager.current_step_parameters, self.parameter_editor.gui_complexity)
         self._apply_scroll_position(scroll_to_bottom)
 
     def _apply_scroll_position(self, scroll_to_bottom: bool) -> None:
@@ -341,7 +339,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         new_value_str = combobox_widget.get_selected_key() or ""
         try:
             # Pass the string to the domain model; it will validate and raise on error
-            new_value = param.set_new_value(new_value_str)
+            param.set_new_value(new_value_str)
         except ParameterUnchangedError:
             # valid but no change; just refresh style
             pass
@@ -350,10 +348,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
             logging_exception(msg, exc)
             messagebox.showerror(_("Error"), str(exc))
         else:
-            # Success: mark edited and update the stored file parameter value
+            # Success: mark edited and sync the ArduPilotParameter back to filesystem
             show_tooltip(change_reason_widget, param.tooltip_change_reason)
-            self.at_least_one_param_edited = True
-            self.configuration_manager.current_file_parameters[param.name].value = new_value
             value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
         combobox_widget.configure(
@@ -469,18 +465,17 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
             if hasattr(event, "type") and event.type == tk.EventType.KeyPress:  # KeyPress event (Return/Enter)
                 self._last_return_values[event.widget] = new_value
 
-            new_value_result = None
             valid = True
 
             try:
                 # first attempt: let the model validate the provided string
                 # (it will convert/validate as required)
-                new_value_result = param.set_new_value(new_value)
+                param.set_new_value(new_value)
             except ParameterOutOfRangeError as oor:  # user-visible warning from model
                 # Ask the user if they want to accept the out-of-range value
                 if messagebox.askyesno(_("Out-of-range value"), str(oor) + _(" Use out-of-range value?"), icon="warning"):
                     # Retry accepting the value while telling the model to ignore range checks
-                    new_value_result = param.set_new_value(new_value, ignore_out_of_range=True)
+                    param.set_new_value(new_value, ignore_out_of_range=True)
                 else:
                     valid = False
             except ParameterUnchangedError:
@@ -491,13 +486,9 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
                 messagebox.showerror(_("Invalid value"), str(exc))
                 valid = False
 
-            if valid and new_value_result is not None:
+            if valid:
                 logging_debug(_("Parameter %s changed, will later ask if change(s) should be saved to file."), param.name)
                 show_tooltip(change_reason_widget, param.tooltip_change_reason)
-                self.at_least_one_param_edited = True
-                # Update the corresponding file parameter with the model-returned value
-                # (model returns the canonical numeric/string representation)
-                self.configuration_manager.current_file_parameters[param.name].value = new_value_result
                 value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
             # Update the displayed value in the Entry or Combobox
@@ -547,18 +538,15 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
                 )
                 return
 
-            new_value_result = None
             valid = True
             # Update the parameter value and entry text
             try:
-                new_value_result = param.set_new_value(BitmaskHelper.get_value_from_keys(checked_keys))
+                param.set_new_value(BitmaskHelper.get_value_from_keys(checked_keys))
             except ParameterOutOfRangeError as oor:  # user-visible warning from model
                 # Ask the user if they want to accept the out-of-range value
                 if messagebox.askyesno(_("Unknown bit set"), str(oor) + _(" Use out-of-range value?"), icon="warning"):
                     # Retry accepting the value while telling the model to ignore range checks
-                    new_value_result = param.set_new_value(
-                        BitmaskHelper.get_value_from_keys(checked_keys), ignore_out_of_range=True
-                    )
+                    param.set_new_value(BitmaskHelper.get_value_from_keys(checked_keys), ignore_out_of_range=True)
                 else:
                     valid = False
             except ParameterUnchangedError:
@@ -569,11 +557,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
                 messagebox.showerror(_("Error"), str(exc))
                 valid = False
 
-            if valid and new_value_result is not None:
+            if valid:
                 show_tooltip(change_reason_widget, param.tooltip_change_reason)
-                self.at_least_one_param_edited = True
-                # Update the corresponding file parameter
-                self.configuration_manager.current_file_parameters[param.name].value = new_value_result
                 value_is_different.config(text=NEW_VALUE_DIFFERENT_STR if param.is_different_from_fc else " ")
 
             # Update new_value_entry with the new decimal value
@@ -717,9 +702,6 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
                         param.change_reason,
                         new_comment,
                     )
-                    self.at_least_one_param_edited = True
-                    # Update the corresponding file parameter comment
-                    self.configuration_manager.current_file_parameters[param.name].comment = new_comment
 
             change_reason_entry.bind("<FocusOut>", _on_change_reason_change)
             change_reason_entry.bind("<Return>", _on_change_reason_change)
@@ -737,8 +719,7 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
 
             # Delete the parameter
             self.configuration_manager.delete_parameter_from_current_file(param_name)
-            self.at_least_one_param_edited = True
-            self.parameter_editor.repopulate_parameter_table()
+            self.parameter_editor.repopulate_parameter_table(regenerate_from_disk=False)
 
             # Restore the scroll position
             self.canvas.yview_moveto(current_scroll_position)
@@ -788,9 +769,8 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         """Confirm and process parameter addition using ConfigurationManager."""
         try:
             if self.configuration_manager.add_parameter_to_current_file(param_name):
-                self.at_least_one_param_edited = True
                 self._pending_scroll_to_bottom = True
-                self.parameter_editor.repopulate_parameter_table()
+                self.parameter_editor.repopulate_parameter_table(regenerate_from_disk=False)
                 return True
         except InvalidParameterNameError as exc:
             messagebox.showerror(_("Invalid parameter name."), str(exc))
@@ -804,21 +784,9 @@ class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
         """Get the parameters selected for upload."""
         # Check if we should show upload column based on GUI complexity
         if not self._should_show_upload_column(gui_complexity):
-            # all parameters are selected for upload in simple mode
-            return self.configuration_manager.current_file_parameters
-
-        return ParDict(
-            {
-                param_name: self.configuration_manager.current_file_parameters[param_name]
-                for param_name, checkbutton_state in self.upload_checkbutton_var.items()
-                if checkbutton_state.get()
-            }
-        )
-
-    def get_at_least_one_param_edited(self) -> bool:
-        """Get whether at least one parameter has been edited."""
-        return self.at_least_one_param_edited
+            # All parameters are selected for upload in simple mode
+            return self.configuration_manager.get_parameters_as_par_dict()
 
-    def set_at_least_one_param_edited(self, value: bool) -> None:
-        """Set whether at least one parameter has been edited."""
-        self.at_least_one_param_edited = value
+        # Get only selected parameters
+        selected_names = [name for name, checkbutton_state in self.upload_checkbutton_var.items() if checkbutton_state.get()]
+        return self.configuration_manager.get_parameters_as_par_dict(selected_names)

ardupilot_methodic_configurator/frontend_tkinter_progress_window.py

@@ -1,7 +1,7 @@
 """
 TKinter progress window class.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_project_creator.py

@@ -3,7 +3,7 @@
 """
 GUI to create the directory to store the vehicle configuration files.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_project_opener.py

@@ -3,7 +3,7 @@
 """
 GUI to select the directory to store the vehicle configuration files.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_rich_text.py

@@ -1,7 +1,7 @@
 """
 TKinter base classes reused in multiple parts of the code.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_scroll_frame.py

@@ -1,7 +1,7 @@
 """
 TKinter base classes reused in multiple parts of the code.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_show.py

@@ -1,7 +1,7 @@
 """
 TKinter base classes reused in multiple parts of the code.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_software_update.py

@@ -1,7 +1,7 @@
 """
 Check for software updates and install them if available.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar Lucas
 

ardupilot_methodic_configurator/frontend_tkinter_stage_progress.py

@@ -29,7 +29,7 @@ Each phase's progress bar automatically:
 The UI dynamically adjusts to window resizing while maintaining proportional spacing
 between phases.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 
@@ -45,7 +45,7 @@ from tkinter import ttk
 from typing import Union
 
 from ardupilot_methodic_configurator import _
-from ardupilot_methodic_configurator.backend_filesystem_configuration_steps import ConfigurationSteps
+from ardupilot_methodic_configurator.backend_filesystem_configuration_steps import ConfigurationSteps, PhaseData
 from ardupilot_methodic_configurator.common_arguments import add_common_arguments
 from ardupilot_methodic_configurator.frontend_tkinter_show import show_tooltip
 
@@ -54,10 +54,15 @@ class StageProgressBar(ttk.LabelFrame):  # pylint: disable=too-many-ancestors
     """Stage-segmented Configuration sequence progress UI."""
 
     def __init__(
-        self, master: Union[tk.Widget, tk.Tk], phases: dict[str, dict], total_steps: int, gui_complexity: str, **kwargs
+        self,
+        master: Union[tk.Widget, tk.Tk],
+        sorted_phases: dict[str, PhaseData],
+        total_steps: int,
+        gui_complexity: str,
+        **kwargs,
     ) -> None:
         super().__init__(master, text=_("Configuration sequence progress"), **kwargs)
-        self.phases = phases
+        self.phases = sorted_phases
         self.total_files = total_steps
         self.phase_frames: dict[str, ttk.Frame] = {}
         self.phase_bars: list[dict[str, Union[ttk.Progressbar, int]]] = []
@@ -78,26 +83,10 @@ class StageProgressBar(ttk.LabelFrame):  # pylint: disable=too-many-ancestors
 
     def create_phase_frames(self, gui_complexity: str) -> None:
         """Create frames for each phase with progress bars and labels."""
-        # Get phases with start positions
-        active_phases = {k: v for k, v in self.phases.items() if "start" in v}
-
-        # Sort phases by start position
-        sorted_phases = dict(sorted(active_phases.items(), key=lambda x: x[1]["start"]))
-
-        # Add the end information to each phase using the start of the next phase
-        phase_names = list(sorted_phases.keys())
-        for i, phase_name in enumerate(phase_names):
-            if i < len(phase_names) - 1:
-                next_phase_name = phase_names[i + 1]
-                sorted_phases[phase_name]["end"] = sorted_phases[next_phase_name]["start"]
-            else:
-                sorted_phases[phase_name]["end"] = self.total_files
-            sorted_phases[phase_name]["weight"] = max(2, sorted_phases[phase_name]["end"] - sorted_phases[phase_name]["start"])
-
         # Calculate non-optional phases
-        non_optional_sorted_phases = {name: data for name, data in sorted_phases.items() if not data.get("optional", False)}
+        non_optional_phases = {name: data for name, data in self.phases.items() if not data.get("optional", False)}
 
-        phases_to_display = non_optional_sorted_phases if gui_complexity == "simple" else sorted_phases
+        phases_to_display = non_optional_phases if gui_complexity == "simple" else self.phases
 
         # Create container frame that will expand
         container = ttk.Frame(self)
@@ -106,14 +95,14 @@ class StageProgressBar(ttk.LabelFrame):  # pylint: disable=too-many-ancestors
         # Configure container columns to expand equally
         for i, (phase_name, phase_data) in enumerate(phases_to_display.items()):
             container.grid_columnconfigure(
-                i, weight=phase_data["weight"] if gui_complexity == "simple" else 1, uniform="phase"
+                i, weight=phase_data.get("weight", 1) if gui_complexity == "simple" else 1, uniform="phase"
             )
-            start = phase_data["start"]
-            end = phase_data["end"]
+            start = phase_data.get("start", 0)
+            end = phase_data.get("end", self.total_files)
             self.phase_frames[phase_name] = self._create_phase_frame(container, i, phase_name, phase_data, (start, end))
 
     def _create_phase_frame(  # pylint: disable=too-many-arguments, too-many-positional-arguments
-        self, container: ttk.Frame, i: int, phase_name: str, phase_data: dict[str, Union[str, bool]], limits: tuple[int, int]
+        self, container: ttk.Frame, i: int, phase_name: str, phase_data: PhaseData, limits: tuple[int, int]
     ) -> ttk.Frame:
         frame = ttk.Frame(container)
         frame.grid(row=0, column=i, sticky="nsew", padx=1)
@@ -136,7 +125,7 @@ class StageProgressBar(ttk.LabelFrame):  # pylint: disable=too-many-ancestors
         # Use gray text color if phase is marked as optional
         is_optional = False
         if "optional" in phase_data and isinstance(phase_data["optional"], bool):
-            is_optional = phase_data.get("optional", False)  # type: ignore[assignment]
+            is_optional = phase_data.get("optional", False)
         label_fg = "gray" if is_optional else "black"
 
         label = ttk.Label(
@@ -150,7 +139,7 @@ class StageProgressBar(ttk.LabelFrame):  # pylint: disable=too-many-ancestors
         label.grid(row=1, column=0, sticky="ew")
 
         if "description" in phase_data and isinstance(phase_data["description"], str):
-            tooltip_msg = _(phase_data.get("description", ""))  # type: ignore[arg-type]
+            tooltip_msg = _(phase_data.get("description", ""))
             if is_optional:
                 tooltip_msg += "\n" + _("This phase is optional.")
             show_tooltip(frame, tooltip_msg)
@@ -244,7 +233,8 @@ def main() -> None:
     config_steps = ConfigurationSteps("", "ArduCopter")
     config_steps.re_init("", "ArduCopter")
 
-    progress = StageProgressBar(root, config_steps.configuration_phases, 54, "normal")
+    processed_phases = config_steps.get_sorted_phases_with_end_and_weight(54)
+    progress = StageProgressBar(root, processed_phases, 54, "normal")
     progress.pack(padx=10, pady=10, fill="both", expand=True)
 
     # Demo update function

ardupilot_methodic_configurator/frontend_tkinter_template_overview.py

@@ -3,7 +3,7 @@
 """
 Vehicle template overview GUI.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/frontend_tkinter_usage_popup_window.py

@@ -1,7 +1,7 @@
 """
 A reusable usage popup window.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/internationalization.py

@@ -1,7 +1,7 @@
 """
 Translations to other written languages.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/param_pid_adjustment_update.py

@@ -1,4 +1,4 @@
-#!/usr/bin/python3
+#!/usr/bin/env python3
 # PYTHON_ARGCOMPLETE_OK
 
 """
@@ -7,7 +7,7 @@ Updates the PID adjustment parameters to be factor of the corresponding autotune
 Usage:
     ./param_pid_adjustment_update.py -d /path/to/directory optimized_parameter_file.param
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 
@@ -113,43 +113,47 @@ def load_param_file_with_content(param_file: str) -> tuple[ParDict, list[str]]:
     """
     parameter_dict = ParDict()
     content = []
-    with open(param_file, encoding="utf-8") as f_handle:
-        for n, f_line in enumerate(f_handle, start=1):
-            line = f_line.strip()
-            content.append(line)
-            comment = None
-            if not line or line.startswith("#"):
-                continue
-            if "#" in line:
-                line, comment = line.split("#", 1)
-                comment = comment.strip()
-            if "," in line:
-                parameter, value = line.split(",", 1)
-            elif " " in line:
-                parameter, value = line.split(" ", 1)
-            elif "\t" in line:
-                parameter, value = line.split("\t", 1)
-            else:
-                msg = f"Missing parameter-value separator: {line} in {param_file} line {n}"
-                raise SystemExit(msg)
-            # Strip whitespace from both parameter name and value immediately after splitting
-            parameter = parameter.strip()
-            value = value.strip()
-            if len(parameter) > PARAM_NAME_MAX_LEN:
-                msg = f"Too long parameter name: {parameter} in {param_file} line {n}"
-                raise SystemExit(msg)
-            if not re.match(PARAM_NAME_REGEX, parameter):
-                msg = f"Invalid characters in parameter name {parameter} in {param_file} line {n}"
-                raise SystemExit(msg)
-            try:
-                fvalue = float(value)
-            except ValueError as exc:
-                msg = f"Invalid parameter value {value} in {param_file} line {n}"
-                raise SystemExit(msg) from exc
-            if parameter in parameter_dict:
-                msg = f"Duplicated parameter {parameter} in {param_file} line {n}"
-                raise SystemExit(msg)
-            parameter_dict[parameter] = Par(fvalue, comment)
+    try:
+        with open(param_file, encoding="utf-8-sig") as f_handle:
+            for n, f_line in enumerate(f_handle, start=1):
+                line = f_line.strip()
+                content.append(line)
+                comment = None
+                if not line or line.startswith("#"):
+                    continue
+                if "#" in line:
+                    line, comment = line.split("#", 1)
+                    comment = comment.strip()
+                if "," in line:
+                    parameter, value = line.split(",", 1)
+                elif " " in line:
+                    parameter, value = line.split(" ", 1)
+                elif "\t" in line:
+                    parameter, value = line.split("\t", 1)
+                else:
+                    msg = f"Missing parameter-value separator: {line} in {param_file} line {n}"
+                    raise SystemExit(msg)
+                # Strip whitespace from both parameter name and value immediately after splitting
+                parameter = parameter.strip()
+                value = value.strip()
+                if len(parameter) > PARAM_NAME_MAX_LEN:
+                    msg = f"Too long parameter name: {parameter} in {param_file} line {n}"
+                    raise SystemExit(msg)
+                if not re.match(PARAM_NAME_REGEX, parameter):
+                    msg = f"Invalid characters in parameter name {parameter} in {param_file} line {n}"
+                    raise SystemExit(msg)
+                try:
+                    fvalue = float(value)
+                except ValueError as exc:
+                    msg = f"Invalid parameter value {value} in {param_file} line {n}"
+                    raise SystemExit(msg) from exc
+                if parameter in parameter_dict:
+                    msg = f"Duplicated parameter {parameter} in {param_file} line {n}"
+                    raise SystemExit(msg)
+                parameter_dict[parameter] = Par(fvalue, comment)
+    except UnicodeDecodeError as exp:
+        msg = f"Fatal error reading {param_file}, file must be UTF-8 encoded: {exp}"
+        raise SystemExit(msg) from exp
     return parameter_dict, content
 
 

ardupilot_methodic_configurator/tempcal_imu.py

@@ -5,7 +5,7 @@ Create temperature calibration parameters for IMUs based on log data.
 The original (python2) version of this file is part of the Ardupilot project.
 This version has been modified to work with >= python3.6 and to pass pylint and ruff checks.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2021 Andrew Tridgell <andrew@tridgell.net>, 2024-2025 Amilcar do Carmo Lucas <amilcar.lucas@iav.de>
 

ardupilot_methodic_configurator/vehicle_components.py

@@ -1,7 +1,7 @@
 """
 Auto-generated by the update_vehicle_components_translation.py. Do not edit, ALL CHANGES WILL BE LOST.
 
-This file is part of Ardupilot methodic configurator. https://github.com/ArduPilot/MethodicConfigurator
+This file is part of ArduPilot Methodic Configurator. https://github.com/ArduPilot/MethodicConfigurator
 
 SPDX-FileCopyrightText: 2024-2025 Amilcar Lucas
 

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/AirCar_v1/14_logging.param

@@ -1,6 +1,6 @@
 INS_LOG_BAT_CNT,1024  # the default of 1024 causes some problems with https://firmware.ardupilot.org/Tools/WebTools/FilterReview/
-INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Big_Owl/14_logging.param

@@ -1,6 +1,6 @@
-INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BACKEND_TYPE,1  # we want to log data to the SDCard
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Chimera7/14_logging.param

@@ -1,5 +1,5 @@
-INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/FETtec-5/14_logging.param

@@ -1,5 +1,5 @@
-INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/GazeboIrisWithTargetFollow/14_logging.param

@@ -1,5 +1,5 @@
-INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500/14_logging.param

@@ -1,7 +1,7 @@
 INS_LOG_BAT_CNT,1024  # the default of 1024 causes some problems with https://firmware.ardupilot.org/Tools/WebTools/FilterReview/
-INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_BUFSIZE,50  # We have a F7 processor, so be a bit conservative
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot

ardupilot_methodic_configurator/vehicle_templates/ArduCopter/Holybro_X500_V2/14_logging.param

@@ -1,6 +1,6 @@
 INS_LOG_BAT_CNT,992  # the default of 1024 causes some problems with https://firmware.ardupilot.org/Tools/WebTools/FilterReview/
-INS_LOG_BAT_MASK,1  # Use acc and gyro batch logging on F4 processors, gyro raw logging on others
-INS_LOG_BAT_OPT,4  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
-INS_RAW_LOG_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors, pre-post gyro raw logging on others
+INS_LOG_BAT_MASK,0  # Use acc and gyro batch logging on F4 processors or big props, gyro raw logging on others
+INS_LOG_BAT_OPT,0  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
+INS_RAW_LOG_OPT,9  # Use pre and post filters acc and gyro batch logging on F4 processors or big props, pre-post gyro raw logging on others
 LOG_BITMASK,145118  # Log all but fast att, Nav, Mission, OF, camera, fast IMU, raw, IMU, video stabilization. These are not needed now
 LOG_FILE_DSRMROT,1  # One .bin log file per flight, not per battery/reboot