webpack 5.92.1 → 5.94.0

package/lib/sharing/ConsumeSharedPlugin.js

@@ -27,7 +27,9 @@ const {
 /** @typedef {import("../../declarations/plugins/sharing/ConsumeSharedPlugin").ConsumesConfig} ConsumesConfig */
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../ResolverFactory").ResolveOptionsWithDependencyType} ResolveOptionsWithDependencyType */
+/** @typedef {import("../util/semver").SemVerRange} SemVerRange */
 /** @typedef {import("./ConsumeSharedModule").ConsumeOptions} ConsumeOptions */
+/** @typedef {import("./utils").DescriptionFile} DescriptionFile */
 
 const validate = createSchemaValidation(
 	require("../../schemas/plugins/sharing/ConsumeSharedPlugin.check.js"),
@@ -57,7 +59,7 @@ class ConsumeSharedPlugin {
 			(item, key) => {
 				if (Array.isArray(item)) throw new Error("Unexpected array in options");
 				/** @type {ConsumeOptions} */
-				let result =
+				const result =
 					item === key || !isRequiredVersion(item)
 						? // item is a request/key
 							{
@@ -97,8 +99,8 @@ class ConsumeSharedPlugin {
 						? item.strictVersion
 						: item.import !== false && !item.singleton,
 				packageName: item.packageName,
-				singleton: !!item.singleton,
-				eager: !!item.eager
+				singleton: Boolean(item.singleton),
+				eager: Boolean(item.eager)
 			})
 		);
 	}
@@ -157,110 +159,127 @@ class ConsumeSharedPlugin {
 						config.import &&
 						/^(\.\.?(\/|$)|\/|[A-Za-z]:|\\\\)/.test(config.import);
 					return Promise.all([
-						new Promise(resolve => {
-							if (!config.import) return resolve();
-							const resolveContext = {
-								/** @type {LazySet<string>} */
-								fileDependencies: new LazySet(),
-								/** @type {LazySet<string>} */
-								contextDependencies: new LazySet(),
-								/** @type {LazySet<string>} */
-								missingDependencies: new LazySet()
-							};
-							resolver.resolve(
-								{},
-								directFallback ? compiler.context : context,
-								config.import,
-								resolveContext,
-								(err, result) => {
-									compilation.contextDependencies.addAll(
-										resolveContext.contextDependencies
-									);
-									compilation.fileDependencies.addAll(
-										resolveContext.fileDependencies
-									);
-									compilation.missingDependencies.addAll(
-										resolveContext.missingDependencies
-									);
-									if (err) {
-										compilation.errors.push(
-											new ModuleNotFoundError(null, err, {
-												name: `resolving fallback for shared module ${request}`
-											})
-										);
-										return resolve();
-									}
-									resolve(result);
-								}
-							);
-						}),
-						new Promise(resolve => {
-							if (config.requiredVersion !== undefined)
-								return resolve(config.requiredVersion);
-							let packageName = config.packageName;
-							if (packageName === undefined) {
-								if (/^(\/|[A-Za-z]:|\\\\)/.test(request)) {
-									// For relative or absolute requests we don't automatically use a packageName.
-									// If wished one can specify one with the packageName option.
-									return resolve();
+						new Promise(
+							/**
+							 * @param {(value?: string) => void} resolve resolve
+							 */
+							resolve => {
+								if (!config.import) {
+									resolve();
+									return;
 								}
-								const match = /^((?:@[^\\/]+[\\/])?[^\\/]+)/.exec(request);
-								if (!match) {
-									requiredVersionWarning(
-										"Unable to extract the package name from request."
-									);
-									return resolve();
-								}
-								packageName = match[0];
-							}
-
-							getDescriptionFile(
-								compilation.inputFileSystem,
-								context,
-								["package.json"],
-								(err, result) => {
-									if (err) {
-										requiredVersionWarning(
-											`Unable to read description file: ${err}`
+								const resolveContext = {
+									/** @type {LazySet<string>} */
+									fileDependencies: new LazySet(),
+									/** @type {LazySet<string>} */
+									contextDependencies: new LazySet(),
+									/** @type {LazySet<string>} */
+									missingDependencies: new LazySet()
+								};
+								resolver.resolve(
+									{},
+									directFallback ? compiler.context : context,
+									config.import,
+									resolveContext,
+									(err, result) => {
+										compilation.contextDependencies.addAll(
+											resolveContext.contextDependencies
 										);
-										return resolve();
-									}
-									const { data, path: descriptionPath } = result;
-									if (!data) {
-										requiredVersionWarning(
-											`Unable to find description file in ${context}.`
+										compilation.fileDependencies.addAll(
+											resolveContext.fileDependencies
+										);
+										compilation.missingDependencies.addAll(
+											resolveContext.missingDependencies
 										);
-										return resolve();
+										if (err) {
+											compilation.errors.push(
+												new ModuleNotFoundError(null, err, {
+													name: `resolving fallback for shared module ${request}`
+												})
+											);
+											return resolve();
+										}
+										resolve(/** @type {string} */ (result));
 									}
-									if (data.name === packageName) {
-										// Package self-referencing
-										return resolve();
+								);
+							}
+						),
+						new Promise(
+							/**
+							 * @param {(value?: SemVerRange) => void} resolve resolve
+							 */
+							resolve => {
+								if (config.requiredVersion !== undefined) {
+									resolve(/** @type {SemVerRange} */ (config.requiredVersion));
+									return;
+								}
+								let packageName = config.packageName;
+								if (packageName === undefined) {
+									if (/^(\/|[A-Za-z]:|\\\\)/.test(request)) {
+										// For relative or absolute requests we don't automatically use a packageName.
+										// If wished one can specify one with the packageName option.
+										resolve();
+										return;
 									}
-									const requiredVersion = getRequiredVersionFromDescriptionFile(
-										data,
-										packageName
-									);
-									if (typeof requiredVersion !== "string") {
+									const match = /^((?:@[^\\/]+[\\/])?[^\\/]+)/.exec(request);
+									if (!match) {
 										requiredVersionWarning(
-											`Unable to find required version for "${packageName}" in description file (${descriptionPath}). It need to be in dependencies, devDependencies or peerDependencies.`
+											"Unable to extract the package name from request."
 										);
-										return resolve();
+										resolve();
+										return;
 									}
-									resolve(parseRange(requiredVersion));
+									packageName = match[0];
 								}
-							);
-						})
-					]).then(([importResolved, requiredVersion]) => {
-						return new ConsumeSharedModule(
-							directFallback ? compiler.context : context,
-							{
-								...config,
-								importResolved,
-								import: importResolved ? config.import : undefined,
-								requiredVersion
+
+								getDescriptionFile(
+									compilation.inputFileSystem,
+									context,
+									["package.json"],
+									(err, result) => {
+										if (err) {
+											requiredVersionWarning(
+												`Unable to read description file: ${err}`
+											);
+											return resolve();
+										}
+										const { data, path: descriptionPath } =
+											/** @type {DescriptionFile} */ (result);
+										if (!data) {
+											requiredVersionWarning(
+												`Unable to find description file in ${context}.`
+											);
+											return resolve();
+										}
+										if (data.name === packageName) {
+											// Package self-referencing
+											return resolve();
+										}
+										const requiredVersion =
+											getRequiredVersionFromDescriptionFile(data, packageName);
+										if (typeof requiredVersion !== "string") {
+											requiredVersionWarning(
+												`Unable to find required version for "${packageName}" in description file (${descriptionPath}). It need to be in dependencies, devDependencies or peerDependencies.`
+											);
+											return resolve();
+										}
+										resolve(parseRange(requiredVersion));
+									}
+								);
 							}
-						);
-					});
+						)
+					]).then(
+						([importResolved, requiredVersion]) =>
+							new ConsumeSharedModule(
+								directFallback ? compiler.context : context,
+								{
+									...config,
+									importResolved,
+									import: importResolved ? config.import : undefined,
+									requiredVersion
+								}
+							)
+					);
 				};
 
 				normalModuleFactory.hooks.factorize.tapPromise(

package/lib/sharing/ConsumeSharedRuntimeModule.js

@@ -19,6 +19,7 @@ const {
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../Chunk").ChunkId} ChunkId */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
+/** @typedef {import("../ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("../Compilation")} Compilation */
 /** @typedef {import("../Module")} Module */
 /** @typedef {import("../Module").ReadOnlyRuntimeRequirements} ReadOnlyRuntimeRequirements */
@@ -47,15 +48,14 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 		/** @type {(string | number)[]} */
 		const initialConsumes = [];
 		/**
-		 *
 		 * @param {Iterable<Module>} modules modules
 		 * @param {Chunk} chunk the chunk
 		 * @param {(string | number)[]} list list of ids
 		 */
 		const addModules = (modules, chunk, list) => {
 			for (const m of modules) {
-				const module = /** @type {ConsumeSharedModule} */ (m);
-				const id = chunkGraph.getModuleId(module);
+				const module = m;
+				const id = /** @type {ModuleId} */ (chunkGraph.getModuleId(module));
 				list.push(id);
 				moduleIdToSourceMapping.set(
 					id,
@@ -95,63 +95,39 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 			versionLtRuntimeCode(runtimeTemplate),
 			rangeToStringRuntimeCode(runtimeTemplate),
 			satisfyRuntimeCode(runtimeTemplate),
-			`var ensureExistence = ${runtimeTemplate.basicFunction("scopeName, key", [
-				`var scope = ${RuntimeGlobals.shareScopeMap}[scopeName];`,
-				`if(!scope || !${RuntimeGlobals.hasOwnProperty}(scope, key)) throw new Error("Shared module " + key + " doesn't exist in shared scope " + scopeName);`,
-				"return scope;"
+			`var exists = ${runtimeTemplate.basicFunction("scope, key", [
+				`return scope && ${RuntimeGlobals.hasOwnProperty}(scope, key);`
+			])}`,
+			`var get = ${runtimeTemplate.basicFunction("entry", [
+				"entry.loaded = 1;",
+				"return entry.get()"
 			])};`,
-			`var findVersion = ${runtimeTemplate.basicFunction("scope, key", [
-				"var versions = scope[key];",
-				`var key = Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
-					"a, b",
-					["return !a || versionLt(a, b) ? b : a;"]
-				)}, 0);`,
-				"return key && versions[key]"
+			`var eagerOnly = ${runtimeTemplate.basicFunction("versions", [
+				`return Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
+					"filtered, version",
+					Template.indent([
+						"if (versions[version].eager) {",
+						Template.indent(["filtered[version] = versions[version];"]),
+						"}",
+						"return filtered;"
+					])
+				)}, {});`
 			])};`,
-			`var findSingletonVersionKey = ${runtimeTemplate.basicFunction(
-				"scope, key",
+			`var findLatestVersion = ${runtimeTemplate.basicFunction(
+				"scope, key, eager",
 				[
-					"var versions = scope[key];",
-					`return Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
+					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
+					`var key = Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 						"a, b",
-						["return !a || (!versions[a].loaded && versionLt(a, b)) ? b : a;"]
-					)}, 0);`
-				]
-			)};`,
-			`var getInvalidSingletonVersionMessage = ${runtimeTemplate.basicFunction(
-				"scope, key, version, requiredVersion",
-				[
-					`return "Unsatisfied version " + version + " from " + (version && scope[key][version].from) + " of shared singleton module " + key + " (required " + rangeToString(requiredVersion) + ")"`
-				]
-			)};`,
-			`var getSingleton = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
-				[
-					"var version = findSingletonVersionKey(scope, key);",
-					"return get(scope[key][version]);"
-				]
-			)};`,
-			`var getSingletonVersion = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
-				[
-					"var version = findSingletonVersionKey(scope, key);",
-					"if (!satisfy(requiredVersion, version)) warn(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));",
-					"return get(scope[key][version]);"
-				]
-			)};`,
-			`var getStrictSingletonVersion = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
-				[
-					"var version = findSingletonVersionKey(scope, key);",
-					"if (!satisfy(requiredVersion, version)) " +
-						"throw new Error(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));",
-					"return get(scope[key][version]);"
+						["return !a || versionLt(a, b) ? b : a;"]
+					)}, 0);`,
+					"return key && versions[key];"
 				]
 			)};`,
-			`var findValidVersion = ${runtimeTemplate.basicFunction(
-				"scope, key, requiredVersion",
+			`var findSatisfyingVersion = ${runtimeTemplate.basicFunction(
+				"scope, key, requiredVersion, eager",
 				[
-					"var versions = scope[key];",
+					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
 					`var key = Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
 						"a, b",
 						[
@@ -162,136 +138,127 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 					"return key && versions[key]"
 				]
 			)};`,
+			`var findSingletonVersionKey = ${runtimeTemplate.basicFunction(
+				"scope, key, eager",
+				[
+					"var versions = eager ? eagerOnly(scope[key]) : scope[key];",
+					`return Object.keys(versions).reduce(${runtimeTemplate.basicFunction(
+						"a, b",
+						["return !a || (!versions[a].loaded && versionLt(a, b)) ? b : a;"]
+					)}, 0);`
+				]
+			)};`,
+			`var getInvalidSingletonVersionMessage = ${runtimeTemplate.basicFunction(
+				"scope, key, version, requiredVersion",
+				[
+					'return "Unsatisfied version " + version + " from " + (version && scope[key][version].from) + " of shared singleton module " + key + " (required " + rangeToString(requiredVersion) + ")"'
+				]
+			)};`,
 			`var getInvalidVersionMessage = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
+				"scope, scopeName, key, requiredVersion, eager",
 				[
 					"var versions = scope[key];",
-					'return "No satisfying version (" + rangeToString(requiredVersion) + ") of shared module " + key + " found in shared scope " + scopeName + ".\\n" +',
+					'return "No satisfying version (" + rangeToString(requiredVersion) + ")" + (eager ? " for eager consumption" : "") + " of shared module " + key + " found in shared scope " + scopeName + ".\\n" +',
 					`\t"Available versions: " + Object.keys(versions).map(${runtimeTemplate.basicFunction(
 						"key",
 						['return key + " from " + versions[key].from;']
 					)}).join(", ");`
 				]
 			)};`,
-			`var getValidVersion = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
-				[
-					"var entry = findValidVersion(scope, key, requiredVersion);",
-					"if(entry) return get(entry);",
-					"throw new Error(getInvalidVersionMessage(scope, scopeName, key, requiredVersion));"
-				]
-			)};`,
-			`var warn = ${
+			`var fail = ${runtimeTemplate.basicFunction("msg", [
+				"throw new Error(msg);"
+			])}`,
+			`var failAsNotExist = ${runtimeTemplate.basicFunction("scopeName, key", [
+				'return fail("Shared module " + key + " doesn\'t exist in shared scope " + scopeName);'
+			])}`,
+			`var warn = /*#__PURE__*/ ${
 				compilation.outputOptions.ignoreBrowserWarnings
 					? runtimeTemplate.basicFunction("", "")
 					: runtimeTemplate.basicFunction("msg", [
 							'if (typeof console !== "undefined" && console.warn) console.warn(msg);'
 						])
 			};`,
-			`var warnInvalidVersion = ${runtimeTemplate.basicFunction(
-				"scope, scopeName, key, requiredVersion",
-				[
-					"warn(getInvalidVersionMessage(scope, scopeName, key, requiredVersion));"
-				]
-			)};`,
-			`var get = ${runtimeTemplate.basicFunction("entry", [
-				"entry.loaded = 1;",
-				"return entry.get()"
-			])};`,
 			`var init = ${runtimeTemplate.returningFunction(
 				Template.asString([
-					"function(scopeName, a, b, c) {",
+					"function(scopeName, key, eager, c, d) {",
 					Template.indent([
 						`var promise = ${RuntimeGlobals.initializeSharing}(scopeName);`,
-						`if (promise && promise.then) return promise.then(fn.bind(fn, scopeName, ${RuntimeGlobals.shareScopeMap}[scopeName], a, b, c));`,
-						`return fn(scopeName, ${RuntimeGlobals.shareScopeMap}[scopeName], a, b, c);`
+						// if we require eager shared, we expect it to be already loaded before it requested, no need to wait the whole scope loaded.
+						"if (promise && promise.then && !eager) { ",
+						Template.indent([
+							`return promise.then(fn.bind(fn, scopeName, ${RuntimeGlobals.shareScopeMap}[scopeName], key, false, c, d));`
+						]),
+						"}",
+						`return fn(scopeName, ${RuntimeGlobals.shareScopeMap}[scopeName], key, eager, c, d);`
 					]),
 					"}"
 				]),
 				"fn"
 			)};`,
 			"",
+			`var useFallback = ${runtimeTemplate.basicFunction(
+				"scopeName, key, fallback",
+				["return fallback ? fallback() : failAsNotExist(scopeName, key);"]
+			)}`,
 			`var load = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key",
+				"scopeName, scope, key, eager, fallback",
 				[
-					"ensureExistence(scopeName, key);",
-					"return get(findVersion(scope, key));"
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"return get(findLatestVersion(scope, key, eager));"
 				]
 			)});`,
-			`var loadFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, fallback",
+			`var loadVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
-					`return scope && ${RuntimeGlobals.hasOwnProperty}(scope, key) ? get(findVersion(scope, key)) : fallback();`
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"var satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);",
+					"if (satisfyingVersion) return get(satisfyingVersion);",
+					"warn(getInvalidVersionMessage(scope, scopeName, key, requiredVersion, eager))",
+					"return get(findLatestVersion(scope, key, eager));"
 				]
 			)});`,
-			`var loadVersionCheck = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version",
+			`var loadStrictVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
-					"ensureExistence(scopeName, key);",
-					"return get(findValidVersion(scope, key, version) || warnInvalidVersion(scope, scopeName, key, version) || findVersion(scope, key));"
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"var satisfyingVersion = findSatisfyingVersion(scope, key, requiredVersion, eager);",
+					"if (satisfyingVersion) return get(satisfyingVersion);",
+					"if (fallback) return fallback();",
+					"fail(getInvalidVersionMessage(scope, scopeName, key, requiredVersion, eager));"
 				]
 			)});`,
 			`var loadSingleton = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key",
-				[
-					"ensureExistence(scopeName, key);",
-					"return getSingleton(scope, scopeName, key);"
-				]
-			)});`,
-			`var loadSingletonVersionCheck = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version",
-				[
-					"ensureExistence(scopeName, key);",
-					"return getSingletonVersion(scope, scopeName, key, version);"
-				]
-			)});`,
-			`var loadStrictVersionCheck = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version",
+				"scopeName, scope, key, eager, fallback",
 				[
-					"ensureExistence(scopeName, key);",
-					"return getValidVersion(scope, scopeName, key, version);"
-				]
-			)});`,
-			`var loadStrictSingletonVersionCheck = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version",
-				[
-					"ensureExistence(scopeName, key);",
-					"return getStrictSingletonVersion(scope, scopeName, key, version);"
-				]
-			)});`,
-			`var loadVersionCheckFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version, fallback",
-				[
-					`if(!scope || !${RuntimeGlobals.hasOwnProperty}(scope, key)) return fallback();`,
-					"return get(findValidVersion(scope, key, version) || warnInvalidVersion(scope, scopeName, key, version) || findVersion(scope, key));"
-				]
-			)});`,
-			`var loadSingletonFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, fallback",
-				[
-					`if(!scope || !${RuntimeGlobals.hasOwnProperty}(scope, key)) return fallback();`,
-					"return getSingleton(scope, scopeName, key);"
-				]
-			)});`,
-			`var loadSingletonVersionCheckFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version, fallback",
-				[
-					`if(!scope || !${RuntimeGlobals.hasOwnProperty}(scope, key)) return fallback();`,
-					"return getSingletonVersion(scope, scopeName, key, version);"
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"var version = findSingletonVersionKey(scope, key, eager);",
+					"return get(scope[key][version]);"
 				]
 			)});`,
-			`var loadStrictVersionCheckFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version, fallback",
+			`var loadSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
-					`var entry = scope && ${RuntimeGlobals.hasOwnProperty}(scope, key) && findValidVersion(scope, key, version);`,
-					`return entry ? get(entry) : fallback();`
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"var version = findSingletonVersionKey(scope, key, eager);",
+					"if (!satisfy(requiredVersion, version)) {",
+					Template.indent([
+						"warn(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));"
+					]),
+					"}",
+					"return get(scope[key][version]);"
 				]
 			)});`,
-			`var loadStrictSingletonVersionCheckFallback = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
-				"scopeName, scope, key, version, fallback",
+			`var loadStrictSingletonVersion = /*#__PURE__*/ init(${runtimeTemplate.basicFunction(
+				"scopeName, scope, key, eager, requiredVersion, fallback",
 				[
-					`if(!scope || !${RuntimeGlobals.hasOwnProperty}(scope, key)) return fallback();`,
-					"return getStrictSingletonVersion(scope, scopeName, key, version);"
+					"if (!exists(scope, key)) return useFallback(scopeName, key, fallback);",
+					"var version = findSingletonVersionKey(scope, key, eager);",
+					"if (!satisfy(requiredVersion, version)) {",
+					Template.indent([
+						"fail(getInvalidSingletonVersionMessage(scope, key, version, requiredVersion));"
+					]),
+					"}",
+					"return get(scope[key][version]);"
 				]
 			)});`,
 			"var installedModules = {};",
@@ -316,7 +283,7 @@ class ConsumeSharedRuntimeModule extends RuntimeModule {
 								`delete ${RuntimeGlobals.moduleCache}[id];`,
 								"var factory = moduleToHandlerMapping[id]();",
 								'if(typeof factory !== "function") throw new Error("Shared module is not available for eager consumption: " + id);',
-								`module.exports = factory();`
+								"module.exports = factory();"
 							])}`
 						])});`
 					])

package/lib/sharing/ProvideForSharedDependency.js

@@ -10,7 +10,6 @@ const makeSerializable = require("../util/makeSerializable");
 
 class ProvideForSharedDependency extends ModuleDependency {
 	/**
-	 *
 	 * @param {string} request request string
 	 */
 	constructor(request) {

package/lib/sharing/ProvideSharedPlugin.js

@@ -62,7 +62,7 @@ class ProvideSharedPlugin {
 					shareKey: item.shareKey,
 					version: item.version,
 					shareScope: item.shareScope || options.shareScope || "default",
-					eager: !!item.eager
+					eager: Boolean(item.eager)
 				})
 			)
 		);
@@ -129,7 +129,7 @@ class ProvideSharedPlugin {
 					if (version === undefined) {
 						let details = "";
 						if (!resourceResolveData) {
-							details = `No resolve data provided from resolver.`;
+							details = "No resolve data provided from resolver.";
 						} else {
 							const descriptionFileData =
 								resourceResolveData.descriptionFileData;

package/lib/sharing/resolveMatchedConfigs.js

@@ -28,7 +28,7 @@ const RESOLVE_OPTIONS = { dependencyType: "esm" };
  * @param {[string, T][]} configs to be processed configs
  * @returns {Promise<MatchedConfigs<T>>} resolved matchers
  */
-exports.resolveMatchedConfigs = (compilation, configs) => {
+module.exports.resolveMatchedConfigs = (compilation, configs) => {
 	/** @type {Map<string, T>} */
 	const resolved = new Map();
 	/** @type {Map<string, T>} */
@@ -47,6 +47,7 @@ exports.resolveMatchedConfigs = (compilation, configs) => {
 	const context = compilation.compiler.context;
 
 	return Promise.all(
+		// eslint-disable-next-line array-callback-return
 		configs.map(([request, config]) => {
 			if (/^\.\.?(\/|$)/.test(request)) {
 				// relative request