webpack 5.92.1 → 5.94.0

package/lib/FlagAllModulesAsUsedPlugin.js

@@ -30,7 +30,7 @@ class FlagAllModulesAsUsedPlugin {
 			const moduleGraph = compilation.moduleGraph;
 			compilation.hooks.optimizeDependencies.tap(PLUGIN_NAME, modules => {
 				/** @type {RuntimeSpec} */
-				let runtime = undefined;
+				let runtime;
 				for (const [name, { options }] of compilation.entries) {
 					runtime = mergeRuntimeOwned(
 						runtime,

package/lib/FlagDependencyExportsPlugin.js

@@ -54,14 +54,15 @@ class FlagDependencyExportsPlugin {
 							const exportsInfo = moduleGraph.getExportsInfo(module);
 							// If the module doesn't have an exportsType, it's a module
 							// without declared exports.
-							if (!module.buildMeta || !module.buildMeta.exportsType) {
-								if (exportsInfo.otherExportsInfo.provided !== null) {
-									// It's a module without declared exports
-									statNoExports++;
-									exportsInfo.setHasProvideInfo();
-									exportsInfo.setUnknownExportsProvided();
-									return callback();
-								}
+							if (
+								(!module.buildMeta || !module.buildMeta.exportsType) &&
+								exportsInfo.otherExportsInfo.provided !== null
+							) {
+								// It's a module without declared exports
+								statNoExports++;
+								exportsInfo.setHasProvideInfo();
+								exportsInfo.setUnknownExportsProvided();
+								return callback();
 							}
 							// If the module has no hash, it's uncacheable
 							if (
@@ -189,9 +190,9 @@ class FlagDependencyExportsPlugin {
 											let name;
 											let canMangle = globalCanMangle;
 											let terminalBinding = globalTerminalBinding;
-											let exports = undefined;
+											let exports;
 											let from = globalFrom;
-											let fromExport = undefined;
+											let fromExport;
 											let priority = globalPriority;
 											let hidden = false;
 											if (typeof exportNameOrSpec === "string") {
@@ -261,7 +262,7 @@ class FlagDependencyExportsPlugin {
 
 											// Recalculate target exportsInfo
 											const target = exportInfo.getTarget(moduleGraph);
-											let targetExportsInfo = undefined;
+											let targetExportsInfo;
 											if (target) {
 												const targetModuleExportsInfo =
 													moduleGraph.getExportsInfo(target.module);

package/lib/FlagDependencyUsagePlugin.js

@@ -308,7 +308,7 @@ class FlagDependencyUsagePlugin {
 						}
 					};
 					/** @type {RuntimeSpec} */
-					let globalRuntime = undefined;
+					let globalRuntime;
 					for (const [
 						entryName,
 						{ dependencies: deps, includeDependencies: includeDeps, options }

package/lib/Generator.js

@@ -42,9 +42,6 @@
  * @property {RuntimeTemplate=} runtimeTemplate
  */
 
-/**
- *
- */
 class Generator {
 	/**
 	 * @param {Record<string, Generator>} map map of types
@@ -133,8 +130,8 @@ class ByTypeGenerator extends Generator {
 	 * @param {string=} type source type
 	 * @returns {number} estimate size of the module
 	 */
-	getSize(module, type) {
-		const t = type || "javascript";
+	getSize(module, type = "javascript") {
+		const t = type;
 		const generator = this.map[t];
 		return generator ? generator.getSize(module, t) : 0;
 	}

package/lib/GraphHelpers.js

@@ -33,5 +33,6 @@ const connectChunkGroupParentAndChild = (parent, child) => {
 	}
 };
 
-exports.connectChunkGroupAndChunk = connectChunkGroupAndChunk;
-exports.connectChunkGroupParentAndChild = connectChunkGroupParentAndChild;
+module.exports.connectChunkGroupAndChunk = connectChunkGroupAndChunk;
+module.exports.connectChunkGroupParentAndChild =
+	connectChunkGroupParentAndChild;

package/lib/HookWebpackError.js

@@ -55,18 +55,16 @@ module.exports.makeWebpackError = makeWebpackError;
  * @param {string} hook name of hook
  * @returns {Callback<T>} generic callback
  */
-const makeWebpackErrorCallback = (callback, hook) => {
-	return (err, result) => {
-		if (err) {
-			if (err instanceof WebpackError) {
-				callback(err);
-				return;
-			}
-			callback(new HookWebpackError(err, hook));
+const makeWebpackErrorCallback = (callback, hook) => (err, result) => {
+	if (err) {
+		if (err instanceof WebpackError) {
+			callback(err);
 			return;
 		}
-		callback(null, result);
-	};
+		callback(new HookWebpackError(err, hook));
+		return;
+	}
+	callback(null, result);
 };
 
 module.exports.makeWebpackErrorCallback = makeWebpackErrorCallback;

package/lib/HotModuleReplacementPlugin.js

@@ -44,8 +44,10 @@ const {
 
 /** @typedef {import("estree").CallExpression} CallExpression */
 /** @typedef {import("estree").Expression} Expression */
+/** @typedef {import("../declarations/WebpackOptions").OutputNormalized} OutputNormalized */
 /** @typedef {import("./Chunk")} Chunk */
 /** @typedef {import("./Chunk").ChunkId} ChunkId */
+/** @typedef {import("./ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
@@ -62,7 +64,8 @@ const {
  * @property {SyncBailHook<[TODO, string[]], void>} hotAcceptWithoutCallback
  */
 
-/** @typedef {Map<string, { updatedChunkIds: Set<ChunkId>, removedChunkIds: Set<ChunkId>, removedModules: Set<Module>, filename: string, assetInfo: AssetInfo }>} HotUpdateMainContentByRuntime */
+/** @typedef {{ updatedChunkIds: Set<ChunkId>, removedChunkIds: Set<ChunkId>, removedModules: Set<Module>, filename: string, assetInfo: AssetInfo }} HotUpdateMainContentByRuntimeItem */
+/** @typedef {Map<string, HotUpdateMainContentByRuntimeItem>} HotUpdateMainContentByRuntime */
 
 /** @type {WeakMap<JavascriptParser, HMRJavascriptParserHooks>} */
 const parserHooksMap = new WeakMap();
@@ -131,7 +134,9 @@ class HotModuleReplacementPlugin {
 				(module.buildInfo).moduleConcatenationBailout =
 					"Hot Module Replacement";
 				if (expr.arguments.length >= 1) {
-					const arg = parser.evaluateExpression(expr.arguments[0]);
+					const arg = parser.evaluateExpression(
+						/** @type {Expression} */ (expr.arguments[0])
+					);
 					/** @type {BasicEvaluatedExpression[]} */
 					let params = [];
 					if (arg.isString()) {
@@ -142,9 +147,9 @@ class HotModuleReplacementPlugin {
 							(arg.items).filter(param => param.isString());
 					}
 					/** @type {string[]} */
-					let requests = [];
+					const requests = [];
 					if (params.length > 0) {
-						params.forEach((param, idx) => {
+						for (const [idx, param] of params.entries()) {
 							const request = /** @type {string} */ (param.string);
 							const dep = new ParamDependency(
 								request,
@@ -157,17 +162,16 @@ class HotModuleReplacementPlugin {
 							dep.loc.index = idx;
 							module.addDependency(dep);
 							requests.push(request);
-						});
+						}
 						if (expr.arguments.length > 1) {
 							hotAcceptCallback.call(expr.arguments[1], requests);
 							for (let i = 1; i < expr.arguments.length; i++) {
 								parser.walkExpression(expr.arguments[i]);
 							}
 							return true;
-						} else {
-							hotAcceptWithoutCallback.call(expr, requests);
-							return true;
 						}
+						hotAcceptWithoutCallback.call(expr, requests);
+						return true;
 					}
 				}
 				parser.walkExpressions(expr.arguments);
@@ -202,7 +206,7 @@ class HotModuleReplacementPlugin {
 						/** @type {BasicEvaluatedExpression[]} */
 						(arg.items).filter(param => param.isString());
 				}
-				params.forEach((param, idx) => {
+				for (const [idx, param] of params.entries()) {
 					const dep = new ParamDependency(
 						/** @type {string} */ (param.string),
 						/** @type {Range} */ (param.range)
@@ -211,7 +215,7 @@ class HotModuleReplacementPlugin {
 					dep.loc = Object.create(/** @type {DependencyLocation} */ (expr.loc));
 					dep.loc.index = idx;
 					module.addDependency(dep);
-				});
+				}
 			}
 			return true;
 		};
@@ -244,14 +248,13 @@ class HotModuleReplacementPlugin {
 					name: PLUGIN_NAME,
 					before: "NodeStuffPlugin"
 				},
-				expr => {
-					return evaluateToIdentifier(
+				expr =>
+					evaluateToIdentifier(
 						"module.hot",
 						"module",
 						() => ["hot"],
 						true
-					)(expr);
-				}
+					)(expr)
 			);
 			parser.hooks.call
 				.for("module.hot.accept")
@@ -277,14 +280,14 @@ class HotModuleReplacementPlugin {
 		const applyImportMetaHot = parser => {
 			parser.hooks.evaluateIdentifier
 				.for("import.meta.webpackHot")
-				.tap(PLUGIN_NAME, expr => {
-					return evaluateToIdentifier(
+				.tap(PLUGIN_NAME, expr =>
+					evaluateToIdentifier(
 						"import.meta.webpackHot",
 						"import.meta",
 						() => ["webpackHot"],
 						true
-					)(expr);
-				});
+					)(expr)
+				);
 			parser.hooks.call
 				.for("import.meta.webpackHot.accept")
 				.tap(
@@ -309,7 +312,7 @@ class HotModuleReplacementPlugin {
 				// It should not affect child compilations
 				if (compilation.compiler !== compiler) return;
 
-				//#region module.hot.* API
+				// #region module.hot.* API
 				compilation.dependencyFactories.set(
 					ModuleHotAcceptDependency,
 					normalModuleFactory
@@ -326,9 +329,9 @@ class HotModuleReplacementPlugin {
 					ModuleHotDeclineDependency,
 					new ModuleHotDeclineDependency.Template()
 				);
-				//#endregion
+				// #endregion
 
-				//#region import.meta.webpackHot.* API
+				// #region import.meta.webpackHot.* API
 				compilation.dependencyFactories.set(
 					ImportMetaHotAcceptDependency,
 					normalModuleFactory
@@ -345,7 +348,7 @@ class HotModuleReplacementPlugin {
 					ImportMetaHotDeclineDependency,
 					new ImportMetaHotDeclineDependency.Template()
 				);
-				//#endregion
+				// #endregion
 
 				let hotIndex = 0;
 				/** @type {Record<string, string>} */
@@ -401,10 +404,9 @@ class HotModuleReplacementPlugin {
 									module,
 									chunk.runtime
 								);
-							} else {
-								nonCodeGeneratedModules.add(module, chunk.runtime);
-								return chunkGraph.getModuleHash(module, chunk.runtime);
 							}
+							nonCodeGeneratedModules.add(module, chunk.runtime);
+							return chunkGraph.getModuleHash(module, chunk.runtime);
 						};
 						const fullHashModulesInThisChunk =
 							chunkGraph.getChunkFullHashModulesSet(chunk);
@@ -446,28 +448,26 @@ class HotModuleReplacementPlugin {
 										chunkModuleHashes[key] = hash;
 									}
 								}
-							} else {
-								if (fullHashModulesInThisChunk !== undefined) {
-									for (const module of modules) {
-										const key = `${chunk.id}|${module.identifier()}`;
-										const hash = getModuleHash(module);
-										if (
-											fullHashModulesInThisChunk.has(
-												/** @type {RuntimeModule} */ (module)
-											)
-										) {
-											fullHashChunkModuleHashes[key] = hash;
-										} else {
-											chunkModuleHashes[key] = hash;
-										}
-									}
-								} else {
-									for (const module of modules) {
-										const key = `${chunk.id}|${module.identifier()}`;
-										const hash = getModuleHash(module);
+							} else if (fullHashModulesInThisChunk !== undefined) {
+								for (const module of modules) {
+									const key = `${chunk.id}|${module.identifier()}`;
+									const hash = getModuleHash(module);
+									if (
+										fullHashModulesInThisChunk.has(
+											/** @type {RuntimeModule} */ (module)
+										)
+									) {
+										fullHashChunkModuleHashes[key] = hash;
+									} else {
 										chunkModuleHashes[key] = hash;
 									}
 								}
+							} else {
+								for (const module of modules) {
+									const key = `${chunk.id}|${module.identifier()}`;
+									const hash = getModuleHash(module);
+									chunkModuleHashes[key] = hash;
+								}
 							}
 						}
 					}
@@ -517,7 +517,8 @@ class HotModuleReplacementPlugin {
 						forEachRuntime(allOldRuntime, runtime => {
 							const { path: filename, info: assetInfo } =
 								compilation.getPathWithInfo(
-									compilation.outputOptions.hotUpdateMainFilename,
+									/** @type {NonNullable<OutputNormalized["hotUpdateMainFilename"]>} */
+									(compilation.outputOptions.hotUpdateMainFilename),
 									{
 										hash: records.hash,
 										runtime
@@ -540,7 +541,9 @@ class HotModuleReplacementPlugin {
 						/** @type {Map<number|string, Module>} */
 						const allModules = new Map();
 						for (const module of compilation.modules) {
-							const id = chunkGraph.getModuleId(module);
+							const id =
+								/** @type {ModuleId} */
+								(chunkGraph.getModuleId(module));
 							allModules.set(id, module);
 						}
 
@@ -604,16 +607,20 @@ class HotModuleReplacementPlugin {
 								removedFromRuntime = subtractRuntime(oldRuntime, newRuntime);
 							} else {
 								// chunk has completely removed
-								chunkId = `${+key}` === key ? +key : key;
+								chunkId = `${Number(key)}` === key ? Number(key) : key;
 								removedFromRuntime = oldRuntime;
 								newRuntime = oldRuntime;
 							}
 							if (removedFromRuntime) {
 								// chunk was removed from some runtimes
 								forEachRuntime(removedFromRuntime, runtime => {
-									const item = hotUpdateMainContentByRuntime.get(
-										/** @type {string} */ (runtime)
-									);
+									const item =
+										/** @type {HotUpdateMainContentByRuntimeItem} */
+										(
+											hotUpdateMainContentByRuntime.get(
+												/** @type {string} */ (runtime)
+											)
+										);
 									item.removedChunkIds.add(/** @type {ChunkId} */ (chunkId));
 								});
 								// dispose modules from the chunk in these runtimes
@@ -654,16 +661,18 @@ class HotModuleReplacementPlugin {
 											for (const moduleRuntime of runtimes) {
 												if (typeof moduleRuntime === "string") {
 													if (moduleRuntime === runtime) return;
-												} else if (moduleRuntime !== undefined) {
-													if (
-														moduleRuntime.has(/** @type {string} */ (runtime))
-													)
-														return;
-												}
+												} else if (
+													moduleRuntime !== undefined &&
+													moduleRuntime.has(/** @type {string} */ (runtime))
+												)
+													return;
 											}
-											const item = hotUpdateMainContentByRuntime.get(
-												/** @type {string} */ (runtime)
-											);
+											const item =
+												/** @type {HotUpdateMainContentByRuntimeItem} */ (
+													hotUpdateMainContentByRuntime.get(
+														/** @type {string} */ (runtime)
+													)
+												);
 											item.removedModules.add(module);
 										});
 									}
@@ -738,9 +747,12 @@ class HotModuleReplacementPlugin {
 									}
 								}
 								forEachRuntime(newRuntime, runtime => {
-									const item = hotUpdateMainContentByRuntime.get(
-										/** @type {string} */ (runtime)
-									);
+									const item =
+										/** @type {HotUpdateMainContentByRuntimeItem} */ (
+											hotUpdateMainContentByRuntime.get(
+												/** @type {string} */ (runtime)
+											)
+										);
 									item.updatedChunkIds.add(/** @type {ChunkId} */ (chunkId));
 								});
 							}
@@ -795,8 +807,10 @@ To fix this, make sure to include [runtime] in the output.hotUpdateMainFilename
 									removedModules.size === 0
 										? completelyRemovedModulesArray
 										: completelyRemovedModulesArray.concat(
-												Array.from(removedModules, m =>
-													chunkGraph.getModuleId(m)
+												Array.from(
+													removedModules,
+													m =>
+														/** @type {ModuleId} */ (chunkGraph.getModuleId(m))
 												)
 											)
 							};

package/lib/IgnoreErrorModuleFactory.js

@@ -30,9 +30,9 @@ class IgnoreErrorModuleFactory extends ModuleFactory {
 	 * @returns {void}
 	 */
 	create(data, callback) {
-		this.normalModuleFactory.create(data, (err, result) => {
-			return callback(null, result);
-		});
+		this.normalModuleFactory.create(data, (err, result) =>
+			callback(null, result)
+		);
 	}
 }
 

package/lib/IgnorePlugin.js

@@ -36,9 +36,7 @@ class IgnorePlugin {
 	}
 
 	/**
-	 * Note that if "contextRegExp" is given, both the "resourceRegExp"
-	 * and "contextRegExp" have to match.
-	 *
+	 * Note that if "contextRegExp" is given, both the "resourceRegExp" and "contextRegExp" have to match.
 	 * @param {ResolveData} resolveData resolve data
 	 * @returns {false|undefined} returns false when the request should be ignored, otherwise undefined
 	 */

package/lib/IgnoreWarningsPlugin.js

@@ -15,6 +15,7 @@ class IgnoreWarningsPlugin {
 	constructor(ignoreWarnings) {
 		this._ignoreWarnings = ignoreWarnings;
 	}
+
 	/**
 	 * Apply the plugin
 	 * @param {Compiler} compiler the compiler instance
@@ -22,15 +23,11 @@ class IgnoreWarningsPlugin {
 	 */
 	apply(compiler) {
 		compiler.hooks.compilation.tap("IgnoreWarningsPlugin", compilation => {
-			compilation.hooks.processWarnings.tap(
-				"IgnoreWarningsPlugin",
-				warnings => {
-					return warnings.filter(warning => {
-						return !this._ignoreWarnings.some(ignore =>
-							ignore(warning, compilation)
-						);
-					});
-				}
+			compilation.hooks.processWarnings.tap("IgnoreWarningsPlugin", warnings =>
+				warnings.filter(
+					warning =>
+						!this._ignoreWarnings.some(ignore => ignore(warning, compilation))
+				)
 			);
 		});
 	}

package/lib/InitFragment.js

@@ -116,7 +116,7 @@ class InitFragment {
 						continue;
 					}
 				}
-				keyedFragments.set(fragment.key || Symbol(), fragment);
+				keyedFragments.set(fragment.key || Symbol("fragment key"), fragment);
 			}
 
 			const concatSource = new ConcatSource();
@@ -137,9 +137,8 @@ class InitFragment {
 				concatSource.add(content);
 			}
 			return concatSource;
-		} else {
-			return source;
 		}
+		return source;
 	}
 
 	/**

package/lib/LibManifestPlugin.js

@@ -11,6 +11,7 @@ const { someInIterable } = require("./util/IterableHelpers");
 const { compareModulesById } = require("./util/comparators");
 const { dirname, mkdirp } = require("./util/fs");
 
+/** @typedef {import("./ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./Compiler").IntermediateFileSystem} IntermediateFileSystem */
 /** @typedef {import("./Module").BuildMeta} BuildMeta */
@@ -55,7 +56,7 @@ class LibManifestPlugin {
 				const moduleGraph = compilation.moduleGraph;
 				// store used paths to detect issue and output an error. #18200
 				const usedPaths = new Set();
-				asyncLib.forEach(
+				asyncLib.each(
 					Array.from(compilation.chunks),
 					(chunk, callback) => {
 						if (!chunk.canBeInitial()) {
@@ -67,7 +68,7 @@ class LibManifestPlugin {
 							chunk
 						});
 						if (usedPaths.has(targetPath)) {
-							callback(new Error(`each chunk must have a unique path`));
+							callback(new Error("each chunk must have a unique path"));
 							return;
 						}
 						usedPaths.add(targetPath);
@@ -102,7 +103,7 @@ class LibManifestPlugin {
 								const providedExports = exportsInfo.getProvidedExports();
 								/** @type {ManifestModuleData} */
 								const data = {
-									id: chunkGraph.getModuleId(module),
+									id: /** @type {ModuleId} */ (chunkGraph.getModuleId(module)),
 									buildMeta: /** @type {BuildMeta} */ (module.buildMeta),
 									exports: Array.isArray(providedExports)
 										? providedExports