webpack 5.101.3 → 5.102.1

package/lib/ids/SyncModuleIdsPlugin.js

@@ -10,6 +10,7 @@ const { getUsedModuleIdsAndModules } = require("./IdHelpers");
 
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../Module")} Module */
+/** @typedef {import("../Module").ModuleId} ModuleId */
 /** @typedef {import("../util/fs").IntermediateFileSystem} IntermediateFileSystem */
 
 const plugin = "SyncModuleIdsPlugin";
@@ -42,7 +43,7 @@ class SyncModuleIdsPlugin {
 	 * @returns {void}
 	 */
 	apply(compiler) {
-		/** @type {Map<string, string | number>} */
+		/** @type {Map<string, ModuleId>} */
 		let data;
 		let dataChanged = false;
 		if (this._read) {
@@ -70,7 +71,7 @@ class SyncModuleIdsPlugin {
 		if (this._write) {
 			compiler.hooks.emitRecords.tapAsync(plugin, (callback) => {
 				if (!data || !dataChanged) return callback();
-				/** @type {{[key: string]: string | number}} */
+				/** @type {{[key: string]: ModuleId}} */
 				const json = {};
 				const sorted = [...data].sort(([a], [b]) => (a < b ? -1 : 1));
 				for (const [key, value] of sorted) {
@@ -108,7 +109,7 @@ class SyncModuleIdsPlugin {
 							err.module = module;
 							compilation.errors.push(err);
 						}
-						chunkGraph.setModuleId(module, /** @type {string | number} */ (id));
+						chunkGraph.setModuleId(module, /** @type {ModuleId} */ (id));
 						usedIds.add(idAsString);
 					}
 				});

package/lib/index.js

@@ -13,12 +13,6 @@ const memoize = require("./util/memoize");
 /** @typedef {import("../declarations/WebpackOptions").EntryObject} EntryObject */
 /** @typedef {import("../declarations/WebpackOptions").ExternalItem} ExternalItem */
 /** @typedef {import("../declarations/WebpackOptions").ExternalItemFunction} ExternalItemFunction */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionCallback} ExternalItemFunctionCallback */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionData} ExternalItemFunctionData */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionDataGetResolve} ExternalItemFunctionDataGetResolve */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionDataGetResolveCallbackResult} ExternalItemFunctionDataGetResolveCallbackResult */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionDataGetResolveResult} ExternalItemFunctionDataGetResolveResult */
-/** @typedef {import("../declarations/WebpackOptions").ExternalItemFunctionPromise} ExternalItemFunctionPromise */
 /** @typedef {import("../declarations/WebpackOptions").ExternalItemObjectKnown} ExternalItemObjectKnown */
 /** @typedef {import("../declarations/WebpackOptions").ExternalItemObjectUnknown} ExternalItemObjectUnknown */
 /** @typedef {import("../declarations/WebpackOptions").ExternalItemValue} ExternalItemValue */
@@ -42,12 +36,19 @@ const memoize = require("./util/memoize");
 /** @typedef {import("../declarations/WebpackOptions").WebpackPluginFunction} WebpackPluginFunction */
 /** @typedef {import("../declarations/WebpackOptions").WebpackPluginInstance} WebpackPluginInstance */
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
+/** @typedef {import("./Compiler").AssetEmittedInfo} AssetEmittedInfo */
 /** @typedef {import("./Compilation").Asset} Asset */
 /** @typedef {import("./Compilation").AssetInfo} AssetInfo */
 /** @typedef {import("./Compilation").EntryOptions} EntryOptions */
 /** @typedef {import("./Compilation").PathData} PathData */
-/** @typedef {import("./Compiler").AssetEmittedInfo} AssetEmittedInfo */
+/** @typedef {import("./CodeGenerationResults")} CodeGenerationResults */
 /** @typedef {import("./Entrypoint")} Entrypoint */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionCallback} ExternalItemFunctionCallback */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionData} ExternalItemFunctionData */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionDataGetResolve} ExternalItemFunctionDataGetResolve */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionDataGetResolveCallbackResult} ExternalItemFunctionDataGetResolveCallbackResult */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionDataGetResolveResult} ExternalItemFunctionDataGetResolveResult */
+/** @typedef {import("./ExternalModuleFactoryPlugin").ExternalItemFunctionPromise} ExternalItemFunctionPromise */
 /** @typedef {import("./MultiCompiler").MultiCompilerOptions} MultiCompilerOptions */
 /** @typedef {import("./MultiCompiler").MultiWebpackOptions} MultiConfiguration */
 /** @typedef {import("./MultiStats")} MultiStats */

package/lib/javascript/ArrayPushCallbackChunkFormatPlugin.js

@@ -17,6 +17,7 @@ const {
 
 /** @typedef {import("../Compiler")} Compiler */
 /** @typedef {import("../ChunkGraph").EntryModuleWithChunkGroup} EntryModuleWithChunkGroup */
+/** @typedef {import("../CodeGenerationResults")} CodeGenerationResults */
 
 const PLUGIN_NAME = "ArrayPushCallbackChunkFormatPlugin";
 
@@ -89,7 +90,9 @@ class ArrayPushCallbackChunkFormatPlugin {
 							runtime.add(
 								Template.renderRuntimeModules(runtimeModules, {
 									...renderContext,
-									codeGenerationResults: compilation.codeGenerationResults
+									codeGenerationResults:
+										/** @type {CodeGenerationResults} */
+										(compilation.codeGenerationResults)
 								})
 							);
 						}

package/lib/javascript/BasicEvaluatedExpression.js

@@ -8,6 +8,9 @@
 /** @typedef {import("estree").Node} Node */
 /** @typedef {import("./JavascriptParser").Range} Range */
 /** @typedef {import("./JavascriptParser").VariableInfo} VariableInfo */
+/** @typedef {import("./JavascriptParser").Members} Members */
+/** @typedef {import("./JavascriptParser").MembersOptionals} MembersOptionals */
+/** @typedef {import("./JavascriptParser").MemberRanges} MemberRanges */
 
 const TypeUnknown = 0;
 const TypeUndefined = 1;
@@ -24,6 +27,10 @@ const TypeWrapped = 11;
 const TypeTemplateString = 12;
 const TypeBigInt = 13;
 
+/** @typedef {() => Members} GetMembers */
+/** @typedef {() => MembersOptionals} GetMembersOptionals */
+/** @typedef {() => MemberRanges} GetMemberRanges */
+
 class BasicEvaluatedExpression {
 	constructor() {
 		this.type = TypeUnknown;
@@ -67,11 +74,11 @@ class BasicEvaluatedExpression {
 		this.identifier = undefined;
 		/** @type {string | VariableInfo | undefined} */
 		this.rootInfo = undefined;
-		/** @type {(() => string[]) | undefined} */
+		/** @type {GetMembers | undefined} */
 		this.getMembers = undefined;
-		/** @type {(() => boolean[]) | undefined} */
+		/** @type {GetMembersOptionals | undefined} */
 		this.getMembersOptionals = undefined;
-		/** @type {(() => Range[]) | undefined} */
+		/** @type {GetMemberRanges | undefined} */
 		this.getMemberRanges = undefined;
 		/** @type {Node | undefined} */
 		this.expression = undefined;
@@ -388,9 +395,9 @@ class BasicEvaluatedExpression {
 	 * Set's the value of this expression to a particular identifier and its members.
 	 * @param {string | VariableInfo} identifier identifier to set
 	 * @param {string | VariableInfo} rootInfo root info
-	 * @param {() => string[]} getMembers members
-	 * @param {() => boolean[]=} getMembersOptionals optional members
-	 * @param {() => Range[]=} getMemberRanges ranges of progressively increasing sub-expressions
+	 * @param {GetMembers} getMembers members
+	 * @param {GetMembersOptionals=} getMembersOptionals optional members
+	 * @param {GetMemberRanges=} getMemberRanges ranges of progressively increasing sub-expressions
 	 * @returns {this} this
 	 */
 	setIdentifier(

package/lib/javascript/ChunkFormatHelpers.js

@@ -18,7 +18,7 @@ const { updateHashForEntryStartup } = require("./StartupHelpers");
  * Gets information about a chunk including its entries and runtime chunk
  * @param {Chunk} chunk The chunk to get information for
  * @param {ChunkGraph} chunkGraph The chunk graph containing the chunk
- * @returns {{entries: Array<[Module, Entrypoint | undefined]>, runtimeChunk: Chunk|null}} Object containing chunk entries and runtime chunk
+ * @returns {{ entries: [Module, Entrypoint | undefined][], runtimeChunk: Chunk | null }} Object containing chunk entries and runtime chunk
  */
 function getChunkInfo(chunk, chunkGraph) {
 	const entries = [

package/lib/javascript/CommonJsChunkFormatPlugin.js

@@ -21,7 +21,6 @@ const { generateEntryStartup } = require("./StartupHelpers");
 
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../Compiler")} Compiler */
-/** @typedef {import("../Entrypoint")} Entrypoint */
 
 const PLUGIN_NAME = "CommonJsChunkFormatPlugin";
 

package/lib/javascript/JavascriptGenerator.js

@@ -13,17 +13,16 @@ const { JS_TYPES } = require("../ModuleSourceTypesConstants");
 const HarmonyCompatibilityDependency = require("../dependencies/HarmonyCompatibilityDependency");
 
 /** @typedef {import("webpack-sources").Source} Source */
+/** @typedef {import("../Compilation").DependencyConstructor} DependencyConstructor */
 /** @typedef {import("../DependenciesBlock")} DependenciesBlock */
 /** @typedef {import("../Dependency")} Dependency */
 /** @typedef {import("../DependencyTemplate")} DependencyTemplate */
 /** @typedef {import("../DependencyTemplate").DependencyTemplateContext} DependencyTemplateContext */
-/** @typedef {import("../DependencyTemplates")} DependencyTemplates */
 /** @typedef {import("../Generator").GenerateContext} GenerateContext */
 /** @typedef {import("../Module")} Module */
 /** @typedef {import("../Module").ConcatenationBailoutReasonContext} ConcatenationBailoutReasonContext */
 /** @typedef {import("../Module").SourceTypes} SourceTypes */
 /** @typedef {import("../NormalModule")} NormalModule */
-/** @typedef {import("../RuntimeTemplate")} RuntimeTemplate */
 
 const DEFAULT_SOURCE = {
 	source() {
@@ -213,7 +212,7 @@ class JavascriptGenerator extends Generator {
 	 */
 	sourceDependency(module, dependency, initFragments, source, generateContext) {
 		const constructor =
-			/** @type {new (...args: EXPECTED_ANY[]) => Dependency} */
+			/** @type {DependencyConstructor} */
 			(dependency.constructor);
 		const template = generateContext.dependencyTemplates.get(constructor);
 		if (!template) {

package/lib/javascript/JavascriptModulesPlugin.js

@@ -52,8 +52,7 @@ const JavascriptParser = require("./JavascriptParser");
 /** @typedef {import("eslint-scope").Variable} Variable */
 /** @typedef {import("estree").Program} Program */
 /** @typedef {import("webpack-sources").Source} Source */
-/** @typedef {import("../../declarations/WebpackOptions").HashFunction} HashFunction */
-/** @typedef {import("../../declarations/WebpackOptions").Output} OutputOptions */
+/** @typedef {import("../config/defaults").OutputNormalizedWithDefaults} OutputOptions */
 /** @typedef {import("../Chunk")} Chunk */
 /** @typedef {import("../ChunkGraph")} ChunkGraph */
 /** @typedef {import("../CodeGenerationResults")} CodeGenerationResults */
@@ -445,7 +444,6 @@ class JavascriptModulesPlugin {
 				compilation.hooks.contentHash.tap(PLUGIN_NAME, (chunk) => {
 					const {
 						chunkGraph,
-						codeGenerationResults,
 						moduleGraph,
 						runtimeTemplate,
 						outputOptions: {
@@ -455,7 +453,10 @@ class JavascriptModulesPlugin {
 							hashFunction
 						}
 					} = compilation;
-					const hash = createHash(/** @type {HashFunction} */ (hashFunction));
+					const codeGenerationResults =
+						/** @type {CodeGenerationResults} */
+						(compilation.codeGenerationResults);
+					const hash = createHash(hashFunction);
 					if (hashSalt) hash.update(hashSalt);
 					if (chunk.hasRuntime()) {
 						this.updateHashWithBootstrap(
@@ -502,11 +503,10 @@ class JavascriptModulesPlugin {
 						}
 						xor.updateHash(hash);
 					}
-					const digest = /** @type {string} */ (hash.digest(hashDigest));
+					const digest = hash.digest(hashDigest);
 					chunk.contentHash.javascript = nonNumericOnlyHash(
 						digest,
-						/** @type {number} */
-						(hashDigestLength)
+						hashDigestLength
 					);
 				});
 				compilation.hooks.additionalTreeRuntimeRequirements.tap(
@@ -591,11 +591,11 @@ class JavascriptModulesPlugin {
 		if (chunk.filenameTemplate) {
 			return chunk.filenameTemplate;
 		} else if (chunk instanceof HotUpdateChunk) {
-			return /** @type {TemplatePath} */ (outputOptions.hotUpdateChunkFilename);
+			return outputOptions.hotUpdateChunkFilename;
 		} else if (chunk.canBeInitial()) {
-			return /** @type {TemplatePath} */ (outputOptions.filename);
+			return outputOptions.filename;
 		}
-		return /** @type {TemplatePath} */ (outputOptions.chunkFilename);
+		return outputOptions.chunkFilename;
 	}
 
 	/**
@@ -1356,6 +1356,16 @@ class JavascriptModulesPlugin {
 							"// This entry module used 'module' so it can't be inlined"
 						);
 					}
+					if (
+						result.allowInlineStartup &&
+						entryRuntimeRequirements.has(RuntimeGlobals.thisAsExports)
+					) {
+						buf2.push(
+							"// This entry module used `this` as exports so it can't be inlined"
+						);
+						result.allowInlineStartup = false;
+					}
+
 					if (chunks.length > 0) {
 						buf2.push(
 							`${i === 0 ? `var ${RuntimeGlobals.exports} = ` : ""}${
@@ -1374,21 +1384,33 @@ class JavascriptModulesPlugin {
 						);
 					} else {
 						if (i === 0) buf2.push(`var ${RuntimeGlobals.exports} = {};`);
-						if (requireScopeUsed) {
-							buf2.push(
-								`__webpack_modules__[${moduleIdExpr}](0, ${
-									i === 0 ? RuntimeGlobals.exports : "{}"
-								}, ${RuntimeGlobals.require});`
-							);
-						} else if (entryRuntimeRequirements.has(RuntimeGlobals.exports)) {
-							buf2.push(
-								`__webpack_modules__[${moduleIdExpr}](0, ${
-									i === 0 ? RuntimeGlobals.exports : "{}"
-								});`
-							);
-						} else {
-							buf2.push(`__webpack_modules__[${moduleIdExpr}]();`);
+						const needThisAsExports = entryRuntimeRequirements.has(
+							RuntimeGlobals.thisAsExports
+						);
+
+						/** @type {string[]} */
+						const args = [];
+						if (
+							requireScopeUsed ||
+							entryRuntimeRequirements.has(RuntimeGlobals.exports)
+						) {
+							const exportsArg = i === 0 ? RuntimeGlobals.exports : "{}";
+							args.push("0", exportsArg);
+							if (requireScopeUsed) {
+								args.push(RuntimeGlobals.require);
+							}
 						}
+						buf2.push(
+							Template.asString(
+								(() => {
+									if (needThisAsExports) {
+										const comma = args.length ? "," : "";
+										return `__webpack_modules__[${moduleIdExpr}].call(${RuntimeGlobals.exports}${comma}${args.join(",")});`;
+									}
+									return `__webpack_modules__[${moduleIdExpr}](${args.join(",")});`;
+								})()
+							)
+						);
 					}
 				}
 				if (runtimeRequirements.has(RuntimeGlobals.onChunksLoaded)) {