webpack 5.101.3 → 5.102.1

package/README.md

@@ -20,6 +20,7 @@
 [![contributors](https://img.shields.io/github/contributors/webpack/webpack.svg)](https://github.com/webpack/webpack/graphs/contributors)
 [![discussions](https://img.shields.io/github/discussions/webpack/webpack)](https://github.com/webpack/webpack/discussions)
 [![discord](https://img.shields.io/discord/1180618526436888586?label=discord&logo=discord&logoColor=white&style=flat)](https://discord.gg/5sxFZPdx2k)
+[![LFX Health Score](https://insights.linuxfoundation.org/api/badge/health-score?project=webpack)](https://insights.linuxfoundation.org/project/webpack)
 
   <h1>webpack</h1>
   <p>
@@ -45,7 +46,7 @@
   - [Backers](#backers)
 - [Special Thanks](#special-thanks-to)
 
-<h2>Install</h2>
+## Install
 
 Install with npm:
 
@@ -59,7 +60,7 @@ Install with yarn:
 yarn add webpack --dev
 ```
 
-<h2>Introduction</h2>
+## Introduction
 
 Webpack is a bundler for modules. The main purpose is to bundle JavaScript
 files for usage in a browser, yet it is also capable of transforming, bundling,
@@ -87,7 +88,7 @@ Check out webpack's quick [**Get Started**](https://webpack.js.org/guides/gettin
 Webpack supports all browsers that are [ES5-compliant](https://kangax.github.io/compat-table/es5/) (IE8 and below are not supported).
 Webpack also needs `Promise` for `import()` and `require.ensure()`. If you want to support older browsers, you will need to [load a polyfill](https://webpack.js.org/guides/shimming/) before using these expressions.
 
-<h2>Concepts</h2>
+## Concepts
 
 ### [Plugins](https://webpack.js.org/plugins/)
 
@@ -264,7 +265,7 @@ If you're working on webpack itself, or building advanced plugins or integration
 
 [tapable-tracer-npm]: https://img.shields.io/npm/v/tapable-tracer.svg
 
-<h2>Contributing</h2>
+## Contributing
 
 **We want contributing to webpack to be fun, enjoyable, and educational for anyone, and everyone.** We have a [vibrant ecosystem](https://medium.com/webpack/contributors-guide/home) that spans beyond this single repo. We welcome you to check out any of the repositories in [our organization](https://github.com/webpack) or [webpack-contrib organization](https://github.com/webpack-contrib) which houses all of our loaders and plugins.
 
@@ -283,11 +284,11 @@ Contributions go far beyond pull requests and commits. Although we love giving y
 
 To get started have a look at our [documentation on contributing](https://github.com/webpack/webpack/blob/main/CONTRIBUTING.md).
 
-<h3>Creating your own plugins and loaders</h3>
+### Creating your own plugins and loaders
 
 If you create a loader or plugin, we would <3 for you to open source it, and put it on npm. We follow the `x-loader`, `x-webpack-plugin` naming convention.
 
-<h2>Support</h2>
+## Support
 
 We consider webpack to be a low-level tool used not only individually but also layered beneath other awesome tools. Because of its flexibility, webpack isn't always the _easiest_ entry-level solution, however we do believe it is the most powerful. That said, we're always looking for ways to improve and simplify the tool without compromising functionality. If you have any ideas on ways to accomplish this, we're all ears!
 
@@ -295,11 +296,11 @@ If you're just getting started, take a look at [our new docs and concepts page](
 
 If you have discovered a 🐜 or have a feature suggestion, feel free to create an issue on GitHub.
 
-<h2>Current project members</h2>
+## Current project members
 
-For information about the governance of the Node.js project, see [GOVERNANCE.md](./GOVERNANCE.md).
+For information about the governance of the webpack project, see [GOVERNANCE.md](./GOVERNANCE.md).
 
-<h3>TSC (Technical Steering Committee)</h3>
+### TSC (Technical Steering Committee)
 
 - [alexander-akait](https://github.com/alexander-akait) -
   **Alexander Akait** <<sheo13666q@gmail.com>> (he/him)
@@ -312,18 +313,11 @@ For information about the governance of the Node.js project, see [GOVERNANCE.md]
 - [thelarkinn](https://github.com/thelarkinn) -
   **Sean Larkin** <<selarkin@microsoft.com>> (he/him)
 
-<h3>Core Collaborators</h3>
+### Maintenance
 
-- [jhnns](https://github.com/jhnns) -
-  **Johannes Ewald** <<mail@johannesewald.de>>
-- [sokra](https://github.com/sokra) -
-  **Tobias Koppers** <<jackworks@protonmail.co>>
-- [spacek33z](https://github.com/spacek33z) -
-  **Kees Kluskens** <<kees@webduck.nl>>
-- [TheLarkInn](https://github.com/TheLarkInn) -
-  **Sean T. Larkin** <<selarkin@microsoft.com>>
+This webpack repository is maintained by the [`Core Working Group`](./WORKING_GROUP.md).
 
-<h2>Sponsoring</h2>
+## Sponsoring
 
 Most of the core team members, webpack contributors and contributors in the ecosystem do this open source work in their free time. If you use webpack for a serious task, and you'd like us to invest more time on it, please donate. This project increases your income/productivity too. It makes development and applications faster and it reduces the required bandwidth.
 
@@ -336,7 +330,7 @@ This is how we use the donations:
 - Infrastructure cost
 - Fees for money handling
 
-<h3>Premium Partners</h3>
+### Premium Partners
 
 <div align="center">
 
@@ -345,7 +339,7 @@ This is how we use the donations:
 
 </div>
 
-<h3>Other Backers and Sponsors</h3>
+### Other Backers and Sponsors
 
 Before we started using OpenCollective, donations were made anonymously. Now that we have made the switch, we would like to acknowledge these sponsors (and the ones who continue to donate using OpenCollective). If we've missed someone, please send us a PR, and we'll add you to this list.
 
@@ -357,7 +351,7 @@ Before we started using OpenCollective, donations were made anonymously. Now tha
 
 </div>
 
-<h3>Gold Sponsors</h3>
+### Gold Sponsors
 
 [Become a gold sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
@@ -396,7 +390,7 @@ Before we started using OpenCollective, donations were made anonymously. Now tha
 
 </div>
 
-<h3>Silver Sponsors</h3>
+### Silver Sponsors
 
 [Become a silver sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
@@ -435,7 +429,7 @@ Before we started using OpenCollective, donations were made anonymously. Now tha
 
 </div>
 
-<h3>Bronze Sponsors</h3>
+### Bronze Sponsors
 
 [Become a bronze sponsor](https://opencollective.com/webpack#sponsor) and get your logo on our README on GitHub with a link to your site.
 
@@ -545,7 +539,7 @@ Before we started using OpenCollective, donations were made anonymously. Now tha
 
 </div>
 
-<h3>Backers</h3>
+### Backers
 
 [Become a backer](https://opencollective.com/webpack#backer) and get your image on our README on GitHub with a link to your site.
 
@@ -651,7 +645,8 @@ Before we started using OpenCollective, donations were made anonymously. Now tha
 <a href="https://opencollective.com/webpack/backer/99/website?requireActive=false" target="_blank"><img width="30" src="https://opencollective.com/webpack/backer/99/avatar.svg?requireActive=false"></a>
 <a href="https://opencollective.com/webpack/backer/100/website?requireActive=false" target="_blank"><img width="30" src="https://opencollective.com/webpack/backer/100/avatar.svg?requireActive=false"></a>
 
-<h2>Special Thanks to</h2>
+## Special Thanks to
+
 <p>(In chronological order)</p>
 
 - [@google](https://github.com/google) for [Google Web Toolkit (GWT)](http://www.gwtproject.org/), which aims to compile Java to JavaScript. It features a similar [Code Splitting](http://www.gwtproject.org/doc/latest/DevGuideCodeSplitting.html) as webpack.

package/lib/APIPlugin.js

@@ -5,7 +5,9 @@
 
 "use strict";
 
-const InitFragment = require("./InitFragment");
+const {
+	getExternalModuleNodeCommonjsInitFragment
+} = require("./ExternalModule");
 const {
 	JAVASCRIPT_MODULE_TYPE_AUTO,
 	JAVASCRIPT_MODULE_TYPE_DYNAMIC,
@@ -30,11 +32,9 @@ const GetFullHashRuntimeModule = require("./runtime/GetFullHashRuntimeModule");
 /** @typedef {import("./javascript/JavascriptParser").Range} Range */
 
 /**
- * @param {boolean | undefined} module true if ES module
- * @param {string} importMetaName `import.meta` name
  * @returns {Record<string, {expr: string, req: string[] | null, type?: string, assign: boolean}>} replacements
  */
-function getReplacements(module, importMetaName) {
+function getReplacements() {
 	return {
 		__webpack_require__: {
 			expr: RuntimeGlobals.require,
@@ -67,9 +67,7 @@ function getReplacements(module, importMetaName) {
 			assign: true
 		},
 		__non_webpack_require__: {
-			expr: module
-				? `__WEBPACK_EXTERNAL_createRequire(${importMetaName}.url)`
-				: "require",
+			expr: "require",
 			req: null,
 			type: undefined, // type is not known, depends on environment
 			assign: true
@@ -132,19 +130,7 @@ function getReplacements(module, importMetaName) {
 
 const PLUGIN_NAME = "APIPlugin";
 
-/**
- * @typedef {object} APIPluginOptions
- * @property {boolean=} module the output filename
- */
-
 class APIPlugin {
-	/**
-	 * @param {APIPluginOptions=} options options
-	 */
-	constructor(options = {}) {
-		this.options = options;
-	}
-
 	/**
 	 * Apply the plugin
 	 * @param {Compiler} compiler the compiler instance
@@ -154,13 +140,15 @@ class APIPlugin {
 		compiler.hooks.compilation.tap(
 			PLUGIN_NAME,
 			(compilation, { normalModuleFactory }) => {
-				const importMetaName = /** @type {string} */ (
-					compilation.outputOptions.importMetaName
-				);
-				const REPLACEMENTS = getReplacements(
-					this.options.module,
-					importMetaName
-				);
+				const moduleOutput = compilation.options.output.module;
+				const nodeTarget = compiler.platform.node;
+				const nodeEsm = moduleOutput && nodeTarget;
+
+				const REPLACEMENTS = getReplacements();
+				if (nodeEsm) {
+					REPLACEMENTS.__non_webpack_require__.expr =
+						"__WEBPACK_EXTERNAL_createRequire_require";
+				}
 
 				compilation.dependencyTemplates.set(
 					ConstDependency,
@@ -191,13 +179,8 @@ class APIPlugin {
 					(source, module, renderContext) => {
 						if (/** @type {BuildInfo} */ (module.buildInfo).needCreateRequire) {
 							const chunkInitFragments = [
-								new InitFragment(
-									`import { createRequire as __WEBPACK_EXTERNAL_createRequire } from ${renderContext.runtimeTemplate.renderNodePrefixForCoreModule(
-										"module"
-									)};\n`,
-									InitFragment.STAGE_HARMONY_IMPORTS,
-									0,
-									"external module node-commonjs"
+								getExternalModuleNodeCommonjsInitFragment(
+									renderContext.runtimeTemplate
 								)
 							];
 
@@ -217,9 +200,20 @@ class APIPlugin {
 						parser.hooks.expression.for(key).tap(PLUGIN_NAME, (expression) => {
 							const dep = toConstantDependency(parser, info.expr, info.req);
 
-							if (key === "__non_webpack_require__" && this.options.module) {
-								/** @type {BuildInfo} */
-								(parser.state.module.buildInfo).needCreateRequire = true;
+							if (key === "__non_webpack_require__" && moduleOutput) {
+								if (nodeTarget) {
+									/** @type {BuildInfo} */
+									(parser.state.module.buildInfo).needCreateRequire = true;
+								} else {
+									const warning = new WebpackError(
+										`${PLUGIN_NAME}\n__non_webpack_require__ is only allowed in target node`
+									);
+									warning.loc = /** @type {DependencyLocation} */ (
+										expression.loc
+									);
+									warning.module = parser.state.module;
+									compilation.warnings.push(warning);
+								}
 							}
 
 							return dep(expression);

package/lib/AsyncDependenciesBlock.js

@@ -8,13 +8,10 @@
 const DependenciesBlock = require("./DependenciesBlock");
 const makeSerializable = require("./util/makeSerializable");
 
-/** @typedef {import("./ChunkGraph")} ChunkGraph */
-/** @typedef {import("./ChunkGroup")} ChunkGroup */
 /** @typedef {import("./ChunkGroup").ChunkGroupOptions} ChunkGroupOptions */
 /** @typedef {import("./Dependency").DependencyLocation} DependencyLocation */
 /** @typedef {import("./Dependency").UpdateHashContext} UpdateHashContext */
 /** @typedef {import("./Entrypoint").EntryOptions} EntryOptions */
-/** @typedef {import("./Module")} Module */
 /** @typedef {import("./serialization/ObjectMiddleware").ObjectDeserializerContext} ObjectDeserializerContext */
 /** @typedef {import("./serialization/ObjectMiddleware").ObjectSerializerContext} ObjectSerializerContext */
 /** @typedef {import("./util/Hash")} Hash */
@@ -41,7 +38,7 @@ class AsyncDependenciesBlock extends DependenciesBlock {
 	}
 
 	/**
-	 * @returns {string | null | undefined} The name of the chunk
+	 * @returns {ChunkGroupOptions["name"]} The name of the chunk
 	 */
 	get chunkName() {
 		return this.groupOptions.name;

package/lib/BannerPlugin.js

@@ -13,7 +13,6 @@ const createSchemaValidation = require("./util/create-schema-validation");
 
 /** @typedef {import("../declarations/plugins/BannerPlugin").BannerFunction} BannerFunction */
 /** @typedef {import("../declarations/plugins/BannerPlugin").BannerPluginArgument} BannerPluginArgument */
-/** @typedef {import("../declarations/plugins/BannerPlugin").BannerPluginOptions} BannerPluginOptions */
 /** @typedef {import("./Compilation").PathData} PathData */
 /** @typedef {import("./Compiler")} Compiler */
 /** @typedef {import("./TemplatedPathPlugin").TemplatePath} TemplatePath */

package/lib/Cache.js

@@ -29,16 +29,17 @@ const {
 /** @typedef {EXPECTED_ANY} Data */
 
 /**
+ * @template T
  * @callback GotHandler
- * @param {TODO} result
- * @param {(err?: Error) => void} callback
+ * @param {T} result
+ * @param {() => void} callback
  * @returns {void}
  */
 
 /**
  * @param {number} times times
- * @param {(err?: Error) => void} callback callback
- * @returns {(err?: Error) => void} callback
+ * @param {(err?: Error | null) => void} callback callback
+ * @returns {(err?: Error | null) => void} callback
  */
 const needCalls = (times, callback) => (err) => {
 	if (--times === 0) {
@@ -53,7 +54,7 @@ const needCalls = (times, callback) => (err) => {
 class Cache {
 	constructor() {
 		this.hooks = {
-			/** @type {AsyncSeriesBailHook<[string, Etag | null, GotHandler[]], Data>} */
+			/** @type {AsyncSeriesBailHook<[string, Etag | null, GotHandler<EXPECTED_ANY>[]], Data>} */
 			get: new AsyncSeriesBailHook(["identifier", "etag", "gotHandlers"]),
 			/** @type {AsyncParallelHook<[string, Etag | null, Data]>} */
 			store: new AsyncParallelHook(["identifier", "etag", "data"]),
@@ -76,7 +77,7 @@ class Cache {
 	 * @returns {void}
 	 */
 	get(identifier, etag, callback) {
-		/** @type {GotHandler[]} */
+		/** @type {GotHandler<T>[]} */
 		const gotHandlers = [];
 		this.hooks.get.callAsync(identifier, etag, gotHandlers, (err, result) => {
 			if (err) {

package/lib/CacheFacade.js

@@ -12,7 +12,6 @@ const mergeEtags = require("./cache/mergeEtags");
 
 /** @typedef {import("./Cache")} Cache */
 /** @typedef {import("./Cache").Etag} Etag */
-/** @typedef {import("./WebpackError")} WebpackError */
 /** @typedef {import("./cache/getLazyHashedEtag").HashableObject} HashableObject */
 /** @typedef {typeof import("./util/Hash")} HashConstructor */
 

package/lib/Chunk.js

@@ -18,48 +18,56 @@ const {
 const { createArrayToSetDeprecationSet } = require("./util/deprecation");
 const { mergeRuntime } = require("./util/runtime");
 
-/** @typedef {import("webpack-sources").Source} Source */
 /** @typedef {import("./ChunkGraph").ChunkFilterPredicate} ChunkFilterPredicate */
 /** @typedef {import("./ChunkGraph").ChunkSizeOptions} ChunkSizeOptions */
 /** @typedef {import("./ChunkGraph").ModuleFilterPredicate} ModuleFilterPredicate */
 /** @typedef {import("./ChunkGraph").ModuleId} ModuleId */
 /** @typedef {import("./ChunkGroup")} ChunkGroup */
 /** @typedef {import("./ChunkGroup").ChunkGroupOptions} ChunkGroupOptions */
-/** @typedef {import("./Compilation")} Compilation */
-/** @typedef {import("./Compilation").AssetInfo} AssetInfo */
 /** @typedef {import("./Entrypoint").EntryOptions} EntryOptions */
 /** @typedef {import("./Module")} Module */
-/** @typedef {import("./ModuleGraph")} ModuleGraph */
 /** @typedef {import("./TemplatedPathPlugin").TemplatePath} TemplatePath */
 /** @typedef {import("./util/Hash")} Hash */
 /** @typedef {import("./util/runtime").RuntimeSpec} RuntimeSpec */
 
 /** @typedef {string | null} ChunkName */
-/** @typedef {number | string} ChunkId */
+/** @typedef {string | number} ChunkId */
 /** @typedef {SortableSet<string>} IdNameHints */
 
 const ChunkFilesSet = createArrayToSetDeprecationSet("chunk.files");
 
 /**
- * @typedef {object} WithId an object who has an id property *
- * @property {string | number} id the id of the object
+ * @deprecated
+ * @typedef {object} ChunkMaps
+ * @property {Record<ChunkId, string>} hash
+ * @property {Record<ChunkId, Record<string, string>>} contentHash
+ * @property {Record<ChunkId, string>} name
  */
 
 /**
  * @deprecated
- * @typedef {object} ChunkMaps
- * @property {Record<string | number, string>} hash
- * @property {Record<string | number, Record<string, string>>} contentHash
- * @property {Record<string | number, string>} name
+ * @typedef {Record<ChunkId, ChunkId[]>} ChunkModuleIdMap
+ */
+
+/**
+ * @deprecated
+ * @typedef {Record<ModuleId, string>} chunkModuleHashMap
  */
 
 /**
  * @deprecated
  * @typedef {object} ChunkModuleMaps
- * @property {Record<string|number, (string|number)[]>} id
- * @property {Record<string|number, string>} hash
+ * @property {ChunkModuleIdMap} id
+ * @property {chunkModuleHashMap} hash
  */
 
+/** @typedef {Set<Chunk>} Chunks */
+/** @typedef {Set<Entrypoint>} Entrypoints */
+/** @typedef {Set<ChunkGroup>} Queue */
+/** @typedef {SortableSet<ChunkGroup>} SortableChunkGroups */
+/** @typedef {Record<string, ChunkId[]>} ChunkChildIdsByOrdersMap */
+/** @typedef {Record<string, ChunkChildIdsByOrdersMap>} ChunkChildIdsByOrdersMapByData */
+
 let debugId = 1000;
 
 /**
@@ -90,7 +98,7 @@ class Chunk {
 		this.cssFilenameTemplate = undefined;
 		/**
 		 * @private
-		 * @type {SortableSet<ChunkGroup>}
+		 * @type {SortableChunkGroups}
 		 */
 		this._groups = new SortableSet(undefined, compareChunkGroupsByIndex);
 		/** @type {RuntimeSpec} */
@@ -353,9 +361,9 @@ class Chunk {
 			"Chunk.getChunkModuleMaps",
 			"DEP_WEBPACK_CHUNK_GET_CHUNK_MODULE_MAPS"
 		);
-		/** @type {Record<string|number, (string|number)[]>} */
+		/** @type {ChunkModuleIdMap} */
 		const chunkModuleIdMap = Object.create(null);
-		/** @type {Record<string|number, string>} */
+		/** @type {chunkModuleHashMap} */
 		const chunkModuleHashMap = Object.create(null);
 
 		for (const asyncChunk of this.getAllAsyncChunks()) {
@@ -408,11 +416,11 @@ class Chunk {
 	 * @returns {ChunkMaps} the chunk map information
 	 */
 	getChunkMaps(realHash) {
-		/** @type {Record<string|number, string>} */
+		/** @type {Record<ChunkId, string>} */
 		const chunkHashMap = Object.create(null);
-		/** @type {Record<string|number, Record<string, string>>} */
+		/** @type {Record<string, Record<ChunkId, string>>} */
 		const chunkContentHashMap = Object.create(null);
-		/** @type {Record<string|number, string>} */
+		/** @type {Record<ChunkId, string>} */
 		const chunkNameMap = Object.create(null);
 
 		for (const chunk of this.getAllAsyncChunks()) {
@@ -519,7 +527,7 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {SortableSet<ChunkGroup>} the chunkGroups that the said chunk is referenced in
+	 * @returns {SortableChunkGroups} the chunkGroups that the said chunk is referenced in
 	 */
 	get groupsIterable() {
 		this._groups.sort();
@@ -576,16 +584,19 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {Set<Chunk>} a set of all the async chunks
+	 * @returns {Chunks} a set of all the async chunks
 	 */
 	getAllAsyncChunks() {
+		/** @type {Queue} */
 		const queue = new Set();
+		/** @type {Chunks} */
 		const chunks = new Set();
 
 		const initialChunks = intersect(
 			Array.from(this.groupsIterable, (g) => new Set(g.chunks))
 		);
 
+		/** @type {Queue} */
 		const initialQueue = new Set(this.groupsIterable);
 
 		for (const chunkGroup of initialQueue) {
@@ -613,10 +624,12 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {Set<Chunk>} a set of all the initial chunks (including itself)
+	 * @returns {Chunks} a set of all the initial chunks (including itself)
 	 */
 	getAllInitialChunks() {
+		/** @type {Chunks} */
 		const chunks = new Set();
+		/** @type {Queue} */
 		const queue = new Set(this.groupsIterable);
 		for (const group of queue) {
 			if (group.isInitial()) {
@@ -628,10 +641,12 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {Set<Chunk>} a set of all the referenced chunks (including itself)
+	 * @returns {Chunks} a set of all the referenced chunks (including itself)
 	 */
 	getAllReferencedChunks() {
+		/** @type {Queue} */
 		const queue = new Set(this.groupsIterable);
+		/** @type {Chunks} */
 		const chunks = new Set();
 
 		for (const chunkGroup of queue) {
@@ -647,15 +662,17 @@ class Chunk {
 	}
 
 	/**
-	 * @returns {Set<Entrypoint>} a set of all the referenced entrypoints
+	 * @returns {Entrypoints} a set of all the referenced entrypoints
 	 */
 	getAllReferencedAsyncEntrypoints() {
+		/** @type {Queue} */
 		const queue = new Set(this.groupsIterable);
+		/** @type {Entrypoints} */
 		const entrypoints = new Set();
 
 		for (const chunkGroup of queue) {
 			for (const entrypoint of chunkGroup.asyncEntrypointsIterable) {
-				entrypoints.add(entrypoint);
+				entrypoints.add(/** @type {Entrypoint} */ (entrypoint));
 			}
 			for (const child of chunkGroup.childrenIterable) {
 				queue.add(child);
@@ -669,6 +686,7 @@ class Chunk {
 	 * @returns {boolean} true, if the chunk references async chunks
 	 */
 	hasAsyncChunks() {
+		/** @type {Queue} */
 		const queue = new Set();
 
 		const initialChunks = intersect(
@@ -730,7 +748,7 @@ class Chunk {
 				}
 			}
 		}
-		/** @type {Record<string, (string | number)[]>} */
+		/** @type {Record<string, ChunkId[]>} */
 		const result = Object.create(null);
 		for (const [name, list] of lists) {
 			list.sort((a, b) => {
@@ -756,7 +774,7 @@ class Chunk {
 	/**
 	 * @param {ChunkGraph} chunkGraph the chunk graph
 	 * @param {string} type option name
-	 * @returns {{ onChunks: Chunk[], chunks: Set<Chunk> }[] | undefined} referenced chunks for a specific type
+	 * @returns {{ onChunks: Chunk[], chunks: Chunks }[] | undefined} referenced chunks for a specific type
 	 */
 	getChildrenOfTypeInOrder(chunkGraph, type) {
 		const list = [];
@@ -802,10 +820,10 @@ class Chunk {
 	 * @param {ChunkGraph} chunkGraph the chunk graph
 	 * @param {boolean=} includeDirectChildren include direct children (by default only children of async children are included)
 	 * @param {ChunkFilterPredicate=} filterFn function used to filter chunks
-	 * @returns {Record<string|number, Record<string, (string | number)[]>>} a record object of names to lists of child ids(?) by chunk id
+	 * @returns {ChunkChildIdsByOrdersMapByData} a record object of names to lists of child ids(?) by chunk id
 	 */
 	getChildIdsByOrdersMap(chunkGraph, includeDirectChildren, filterFn) {
-		/** @type {Record<string|number, Record<string, (string | number)[]>>} */
+		/** @type {ChunkChildIdsByOrdersMapByData} */
 		const chunkMaps = Object.create(null);
 
 		/**
@@ -824,7 +842,7 @@ class Chunk {
 		};
 
 		if (includeDirectChildren) {
-			/** @type {Set<Chunk>} */
+			/** @type {Chunks} */
 			const chunks = new Set();
 			for (const chunkGroup of this.groupsIterable) {
 				for (const chunk of chunkGroup.chunks) {
@@ -852,7 +870,7 @@ class Chunk {
 	 */
 	hasChildByOrder(chunkGraph, type, includeDirectChildren, filterFn) {
 		if (includeDirectChildren) {
-			/** @type {Set<Chunk>} */
+			/** @type {Chunks} */
 			const chunks = new Set();
 			for (const chunkGroup of this.groupsIterable) {
 				for (const chunk of chunkGroup.chunks) {