webpack-dev-server 5.2.2 → 5.2.3

package/lib/getPort.js

@@ -6,21 +6,21 @@
  * The code structure is similar to get-port, but it searches
  * ports deterministically like portfinder
  */
-const net = require("net");
-const os = require("os");
+const net = require("node:net");
+const os = require("node:os");
 
 const minPort = 1024;
 const maxPort = 65_535;
 
 /**
- * @return {Set<string|undefined>}
+ * @returns {Set<string | undefined>} local hosts
  */
 const getLocalHosts = () => {
   const interfaces = os.networkInterfaces();
 
   // Add undefined value for createServer function to use default host,
   // and default IPv4 host in case createServer defaults to IPv6.
-  // eslint-disable-next-line no-undefined
+
   const results = new Set([undefined, "0.0.0.0"]);
 
   for (const _interface of Object.values(interfaces)) {
@@ -35,9 +35,9 @@ const getLocalHosts = () => {
 };
 
 /**
- * @param {number} basePort
- * @param {string | undefined} host
- * @return {Promise<number>}
+ * @param {number} basePort base port
+ * @param {string | undefined} host host
+ * @returns {Promise<number>} resolved port
  */
 const checkAvailablePort = (basePort, host) =>
   new Promise((resolve, reject) => {
@@ -57,9 +57,9 @@ const checkAvailablePort = (basePort, host) =>
   });
 
 /**
- * @param {number} port
- * @param {Set<string|undefined>} hosts
- * @return {Promise<number>}
+ * @param {number} port port
+ * @param {Set<string|undefined>} hosts hosts
+ * @returns {Promise<number>} resolved port
  */
 const getAvailablePort = async (port, hosts) => {
   /**
@@ -70,7 +70,7 @@ const getAvailablePort = async (port, hosts) => {
   /* Check if the post is available on every local host name */
   for (const host of hosts) {
     try {
-      await checkAvailablePort(port, host); // eslint-disable-line no-await-in-loop
+      await checkAvailablePort(port, host);
     } catch (error) {
       /* We throw an error only if the interface exists */
       if (
@@ -87,9 +87,9 @@ const getAvailablePort = async (port, hosts) => {
 };
 
 /**
- * @param {number} basePort
- * @param {string=} host
- * @return {Promise<number>}
+ * @param {number} basePort base port
+ * @param {string=} host host
+ * @returns {Promise<number>} resolved port
  */
 async function getPorts(basePort, host) {
   if (basePort < minPort || basePort > maxPort) {
@@ -97,22 +97,21 @@ async function getPorts(basePort, host) {
   }
 
   let port = basePort;
+
   const localhosts = getLocalHosts();
-  let hosts;
-  if (host && !localhosts.has(host)) {
-    hosts = new Set([host]);
-  } else {
-    /* If the host is equivalent to localhost
+  const hosts =
+    host && !localhosts.has(host)
+      ? new Set([host])
+      : /* If the host is equivalent to localhost
        we need to check every equivalent host
        else the port might falsely appear as available
        on some operating systems  */
-    hosts = localhosts;
-  }
+        localhosts;
   /** @type {Set<string | undefined>} */
   const portUnavailableErrors = new Set(["EADDRINUSE", "EACCES"]);
   while (port <= maxPort) {
     try {
-      const availablePort = await getAvailablePort(port, hosts); // eslint-disable-line no-await-in-loop
+      const availablePort = await getAvailablePort(port, hosts);
       return availablePort;
     } catch (error) {
       /* Try next port if port is busy; throw for any other error */

package/lib/servers/BaseServer.js

@@ -6,7 +6,7 @@
 // server implementation
 module.exports = class BaseServer {
   /**
-   * @param {import("../Server")} server
+   * @param {import("../Server")} server server
    */
   constructor(server) {
     /** @type {import("../Server")} */

package/lib/servers/SockJSServer.js

@@ -10,18 +10,19 @@ const BaseServer = require("./BaseServer");
 // sockjs will remove Origin header, however Origin header is required for checking host.
 // See https://github.com/webpack/webpack-dev-server/issues/1604 for more information
 {
-  // @ts-ignore
+  // @ts-expect-error
   const SockjsSession = require("sockjs/lib/transport").Session;
-  const decorateConnection = SockjsSession.prototype.decorateConnection;
+
+  const { decorateConnection } = SockjsSession.prototype;
 
   /**
-   * @param {import("http").IncomingMessage} req
+   * @param {import("http").IncomingMessage} req request
    */
   // eslint-disable-next-line func-names
   SockjsSession.prototype.decorateConnection = function (req) {
     decorateConnection.call(this, req);
 
-    const connection = this.connection;
+    const { connection } = this;
 
     if (
       connection.headers &&
@@ -36,7 +37,7 @@ const BaseServer = require("./BaseServer");
 module.exports = class SockJSServer extends BaseServer {
   // options has: error (function), debug (function), server (http/s server), path (string)
   /**
-   * @param {import("../Server")} server
+   * @param {import("../Server")} server server
    */
   constructor(server) {
     super(server);
@@ -49,8 +50,8 @@ module.exports = class SockJSServer extends BaseServer {
       );
 
     /**
-     * @param {NonNullable<WebSocketServerConfiguration["options"]>} options
-     * @returns {string}
+     * @param {NonNullable<WebSocketServerConfiguration["options"]>} options options
+     * @returns {string} sockjs URL
      */
     const getSockjsUrl = (options) => {
       if (typeof options.sockjsUrl !== "undefined") {
@@ -62,11 +63,12 @@ module.exports = class SockJSServer extends BaseServer {
 
     this.implementation = sockjs.createServer({
       // Use provided up-to-date sockjs-client
+      // eslint-disable-next-line camelcase
       sockjs_url: getSockjsUrl(webSocketServerOptions),
       // Default logger is very annoy. Limit useless logs.
       /**
-       * @param {string} severity
-       * @param {string} line
+       * @param {string} severity severity
+       * @param {string} line line
        */
       log: (severity, line) => {
         if (severity === "error") {
@@ -80,8 +82,8 @@ module.exports = class SockJSServer extends BaseServer {
     });
 
     /**
-     * @param {import("sockjs").ServerOptions & { path?: string }} options
-     * @returns {string | undefined}
+     * @param {import("sockjs").ServerOptions & { path?: string }} options options
+     * @returns {string | undefined} prefix
      */
     const getPrefix = (options) => {
       if (typeof options.prefix !== "undefined") {
@@ -102,10 +104,10 @@ module.exports = class SockJSServer extends BaseServer {
     );
 
     this.implementation.on("connection", (client) => {
-      // @ts-ignore
+      // @ts-expect-error
       // Implement the the same API as for `ws`
       client.send = client.write;
-      // @ts-ignore
+      // @ts-expect-error
       client.terminate = client.close;
 
       this.clients.push(/** @type {ClientConnection} */ (client));
@@ -118,7 +120,7 @@ module.exports = class SockJSServer extends BaseServer {
       });
     });
 
-    // @ts-ignore
+    // @ts-expect-error
     this.implementation.close = (callback) => {
       callback();
     };

package/lib/servers/WebsocketServer.js

@@ -10,7 +10,7 @@ module.exports = class WebsocketServer extends BaseServer {
   static heartbeatInterval = 1000;
 
   /**
-   * @param {import("../Server")} server
+   * @param {import("../Server")} server server
    */
   constructor(server) {
     super(server);
@@ -35,9 +35,9 @@ module.exports = class WebsocketServer extends BaseServer {
     (this.server.server).on(
       "upgrade",
       /**
-       * @param {import("http").IncomingMessage} req
-       * @param {import("stream").Duplex} sock
-       * @param {Buffer} head
+       * @param {import("http").IncomingMessage} req request
+       * @param {import("stream").Duplex} sock socket
+       * @param {Buffer} head head
        */
       (req, sock, head) => {
         if (!this.implementation.shouldHandle(req)) {
@@ -53,7 +53,7 @@ module.exports = class WebsocketServer extends BaseServer {
     this.implementation.on(
       "error",
       /**
-       * @param {Error} err
+       * @param {Error} err error
        */
       (err) => {
         this.server.logger.error(err.message);
@@ -61,27 +61,22 @@ module.exports = class WebsocketServer extends BaseServer {
     );
 
     const interval = setInterval(() => {
-      this.clients.forEach(
-        /**
-         * @param {ClientConnection} client
-         */
-        (client) => {
-          if (client.isAlive === false) {
-            client.terminate();
-
-            return;
-          }
-
-          client.isAlive = false;
-          client.ping(() => {});
-        },
-      );
+      for (const client of this.clients) {
+        if (client.isAlive === false) {
+          client.terminate();
+
+          continue;
+        }
+
+        client.isAlive = false;
+        client.ping(() => {});
+      }
     }, WebsocketServer.heartbeatInterval);
 
     this.implementation.on(
       "connection",
       /**
-       * @param {ClientConnection} client
+       * @param {ClientConnection} client client
        */
       (client) => {
         this.clients.push(client);
@@ -100,7 +95,7 @@ module.exports = class WebsocketServer extends BaseServer {
         client.on(
           "error",
           /**
-           * @param {Error} err
+           * @param {Error} err err
            */
           (err) => {
             this.server.logger.error(err.message);

package/package.json

@@ -1,39 +1,37 @@
 {
   "name": "webpack-dev-server",
-  "version": "5.2.2",
+  "version": "5.2.3",
   "description": "Serves a webpack app. Updates the browser on changes.",
-  "bin": "bin/webpack-dev-server.js",
-  "main": "lib/Server.js",
-  "types": "types/lib/Server.d.ts",
-  "author": "Tobias Koppers @sokra",
-  "bugs": "https://github.com/webpack/webpack-dev-server/issues",
   "homepage": "https://github.com/webpack/webpack-dev-server#readme",
+  "bugs": "https://github.com/webpack/webpack-dev-server/issues",
   "repository": "https://github.com/webpack/webpack-dev-server",
-  "license": "MIT",
   "funding": {
     "type": "opencollective",
     "url": "https://opencollective.com/webpack"
   },
+  "license": "MIT",
+  "author": "Tobias Koppers @sokra",
+  "main": "lib/Server.js",
+  "types": "types/lib/Server.d.ts",
+  "bin": "bin/webpack-dev-server.js",
   "files": [
     "bin",
     "lib",
     "client",
     "types"
   ],
-  "engines": {
-    "node": ">= 18.12.0"
-  },
   "scripts": {
     "fmt:check": "prettier \"{**/*,*}.{js,json,md,yml,css,ts}\" --list-different",
     "lint:prettier": "prettier --cache --list-different .",
-    "lint:js": "eslint --cache .",
+    "lint:code": "eslint --cache .",
     "lint:types": "tsc --pretty --noEmit",
+    "lint:types-client": "tsc -p tsconfig.client.json",
     "lint:spelling": "cspell --cache --no-must-find-files --quiet \"**/*.*\"",
     "lint": "npm-run-all -l -p \"lint:**\"",
-    "fix:js": "npm run lint:js -- --fix",
+    "fix:code": "npm run lint:code -- --fix",
     "fix:prettier": "npm run lint:prettier -- --write",
-    "fix": "npm-run-all -l fix:js fix:prettier",
-    "commitlint": "commitlint --from=master",
+    "fix": "npm-run-all -l fix:code fix:prettier",
+    "commitlint": "commitlint --from=main",
     "build:client": "rimraf -g ./client/* && babel client-src/ --out-dir client/ --ignore \"client-src/webpack.config.js\" --ignore \"client-src/modules\" && webpack --config client-src/webpack.config.js",
     "build:types": "rimraf -g ./types/* && tsc --declaration --emitDeclarationOnly --outDir types && node ./scripts/extend-webpack-types.js && prettier \"types/**/*.ts\" --write && prettier \"types/**/*.ts\" --write",
     "build": "npm-run-all -p \"build:**\"",
@@ -48,7 +46,7 @@
   "dependencies": {
     "@types/bonjour": "^3.5.13",
     "@types/connect-history-api-fallback": "^1.5.4",
-    "@types/express": "^4.17.21",
+    "@types/express": "^4.17.25",
     "@types/express-serve-static-core": "^4.17.21",
     "@types/serve-index": "^1.9.4",
     "@types/serve-static": "^1.15.5",
@@ -58,9 +56,9 @@
     "bonjour-service": "^1.2.1",
     "chokidar": "^3.6.0",
     "colorette": "^2.0.10",
-    "compression": "^1.7.4",
+    "compression": "^1.8.1",
     "connect-history-api-fallback": "^2.0.0",
-    "express": "^4.21.2",
+    "express": "^4.22.1",
     "graceful-fs": "^4.2.6",
     "http-proxy-middleware": "^2.0.9",
     "ipaddr.js": "^2.1.0",
@@ -68,7 +66,7 @@
     "open": "^10.0.3",
     "p-retry": "^6.2.0",
     "schema-utils": "^4.2.0",
-    "selfsigned": "^2.4.1",
+    "selfsigned": "^5.5.0",
     "serve-index": "^1.9.1",
     "sockjs": "^0.3.24",
     "spdy": "^4.0.2",
@@ -85,31 +83,35 @@
     "@babel/runtime": "^7.25.9",
     "@commitlint/cli": "^19.5.0",
     "@commitlint/config-conventional": "^19.5.0",
+    "@eslint/markdown": "^7.0.0",
     "@hono/node-server": "^1.13.3",
     "@types/compression": "^1.7.2",
-    "@types/node": "^22.8.4",
+    "@types/graceful-fs": "^4.1.9",
+    "@types/node": "^24.0.14",
     "@types/node-forge": "^1.3.1",
     "@types/sockjs-client": "^1.5.1",
-    "@types/trusted-types": "^2.0.2",
+    "@types/trusted-types": "^2.0.7",
     "acorn": "^8.14.0",
-    "babel-jest": "^29.5.0",
+    "babel-jest": "^30.0.4",
     "babel-loader": "^10.0.0",
-    "body-parser": "^1.19.2",
     "connect": "^3.7.0",
     "core-js": "^3.38.1",
     "cspell": "^8.15.5",
     "css-loader": "^7.1.1",
-    "eslint": "^8.57.1",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-config-webpack": "^1.2.5",
-    "eslint-plugin-import": "^2.31.0",
+    "eslint": "^9.30.1",
+    "eslint-config-prettier": "^10.1.5",
+    "eslint-config-webpack": "^4.4.0",
+    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-jest": "^29.0.1",
+    "eslint-plugin-jsdoc": "^51.3.4",
+    "eslint-plugin-n": "^17.21.0",
     "execa": "^5.1.1",
     "hono": "^4.6.8",
     "html-webpack-plugin": "^5.6.3",
     "http-proxy": "^1.18.1",
     "husky": "^9.1.6",
-    "jest": "^29.5.0",
-    "jest-environment-jsdom": "^29.5.0",
+    "jest": "^30.0.4",
+    "jest-environment-jsdom": "^29.7.0",
     "klona": "^2.0.4",
     "less": "^4.1.1",
     "less-loader": "^12.1.0",
@@ -124,14 +126,14 @@
     "rimraf": "^5.0.5",
     "sockjs-client": "^1.6.1",
     "standard-version": "^9.3.0",
-    "strip-ansi-v6": "npm:strip-ansi@^6.0.0",
     "style-loader": "^4.0.0",
-    "supertest": "^7.0.0",
+    "supertest": "^7.2.2",
     "tcp-port-used": "^1.0.2",
     "typescript": "^5.7.2",
+    "typescript-eslint": "^8.36.0",
     "wait-for-expect": "^3.0.2",
     "webpack": "^5.94.0",
-    "webpack-cli": "^5.0.1",
+    "webpack-cli": "^6.0.1",
     "webpack-merge": "^6.0.1"
   },
   "peerDependencies": {
@@ -144,5 +146,8 @@
     "webpack": {
       "optional": true
     }
+  },
+  "engines": {
+    "node": ">= 18.12.0"
   }
 }

package/types/bin/webpack-dev-server.d.ts

@@ -23,5 +23,5 @@ export type CliOption = {
   /**
    * preprocessor
    */
-  preprocess: Function;
+  preprocess: () => void;
 };