webpack-dev-server 5.2.2 → 5.2.3

package/README.md

@@ -229,7 +229,7 @@ If you use TypeScript in the webpack config, you'll need to properly type `devSe
 
 ```ts
 /// <reference path="node_modules/webpack-dev-server/types/lib/Server.d.ts"/>
-import type { Configuration } from "webpack";
+import { type Configuration } from "webpack";
 
 // Your logic
 ```
@@ -237,8 +237,8 @@ import type { Configuration } from "webpack";
 Or you can import the type from `webpack-dev-server`, i.e.
 
 ```ts
-import type { Configuration as DevServerConfiguration } from "webpack-dev-server";
-import type { Configuration } from "webpack";
+import { type Configuration } from "webpack";
+import { type Configuration as DevServerConfiguration } from "webpack-dev-server";
 
 const devServer: DevServerConfiguration = {};
 const config: Configuration = { devServer };
@@ -311,7 +311,7 @@ This project is heavily inspired by [peerigon/nof5](https://github.com/peerigon/
 [node-url]: https://nodejs.org
 [tests]: https://github.com/webpack/webpack-dev-server/workflows/webpack-dev-server/badge.svg
 [tests-url]: https://github.com/webpack/webpack-dev-server/actions?query=workflow%3Awebpack-dev-server
-[cover]: https://codecov.io/gh/webpack/webpack-dev-server/branch/master/graph/badge.svg
+[cover]: https://codecov.io/gh/webpack/webpack-dev-server/graph/badge.svg
 [cover-url]: https://codecov.io/gh/webpack/webpack-dev-server
 [discussion]: https://img.shields.io/github/discussions/webpack/webpack
 [discussion-url]: https://github.com/webpack/webpack/discussions

package/bin/webpack-dev-server.js

@@ -10,7 +10,8 @@
  * @returns {Promise<void>} promise
  */
 const runCommand = (command, args) => {
-  const cp = require("child_process");
+  const cp = require("node:child_process");
+
   return new Promise((resolve, reject) => {
     const executedCommand = cp.spawn(command, args, {
       stdio: "inherit",
@@ -40,7 +41,7 @@ const isInstalled = (packageName) => {
     return true;
   }
 
-  const path = require("path");
+  const path = require("node:path");
   const fs = require("graceful-fs");
 
   let dir = __dirname;
@@ -52,20 +53,19 @@ const isInstalled = (packageName) => {
       ) {
         return true;
       }
-    } catch (_error) {
+    } catch {
       // Nothing
     }
-    // eslint-disable-next-line no-cond-assign
   } while (dir !== (dir = path.dirname(dir)));
 
   // https://github.com/nodejs/node/blob/v18.9.1/lib/internal/modules/cjs/loader.js#L1274
-  // @ts-ignore
-  for (const internalPath of require("module").globalPaths) {
+  // @ts-expect-error
+  for (const internalPath of require("node:module").globalPaths) {
     try {
       if (fs.statSync(path.join(internalPath, packageName)).isDirectory()) {
         return true;
       }
-    } catch (_error) {
+    } catch {
       // Nothing
     }
   }
@@ -81,9 +81,11 @@ const runCli = (cli) => {
   if (cli.preprocess) {
     cli.preprocess();
   }
-  const path = require("path");
+
+  const path = require("node:path");
+
   const pkgPath = require.resolve(`${cli.package}/package.json`);
-  // eslint-disable-next-line import/no-dynamic-require
+
   const pkg = require(pkgPath);
 
   if (pkg.type === "module" || /\.mjs/i.test(pkg.bin[cli.binName])) {
@@ -94,19 +96,18 @@ const runCli = (cli) => {
       },
     );
   } else {
-    // eslint-disable-next-line import/no-dynamic-require
     require(path.resolve(path.dirname(pkgPath), pkg.bin[cli.binName]));
   }
 };
 
 /**
- * @typedef {Object} CliOption
+ * @typedef {object} CliOption
  * @property {string} name display name
  * @property {string} package npm package name
  * @property {string} binName name of the executable file
  * @property {boolean} installed currently installed?
  * @property {string} url homepage
- * @property {function} preprocess preprocessor
+ * @property {() => void} preprocess preprocessor
  */
 
 /** @type {CliOption} */
@@ -122,9 +123,9 @@ const cli = {
 };
 
 if (!cli.installed) {
-  const path = require("path");
+  const path = require("node:path");
   const fs = require("graceful-fs");
-  const readLine = require("readline");
+  const readLine = require("node:readline");
 
   const notify = `CLI for webpack must be installed.\n  ${cli.name} (${cli.url})\n`;
 
@@ -151,7 +152,7 @@ if (!cli.installed) {
     )} ${cli.package}".`,
   );
 
-  const question = `Do you want to install 'webpack-cli' (yes/no): `;
+  const question = "Do you want to install 'webpack-cli' (yes/no): ";
 
   const questionInterface = readLine.createInterface({
     input: process.stdin,
@@ -185,7 +186,7 @@ if (!cli.installed) {
       }')...`,
     );
 
-    runCommand(packageManager, installOptions.concat(cli.package))
+    runCommand(packageManager, [...installOptions, cli.package])
       .then(() => {
         runCli(cli);
       })

package/client/clients/SockJSClient.js

@@ -6,54 +6,52 @@ function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol"
 function _toPrimitive(t, r) { if ("object" != _typeof(t) || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != _typeof(i)) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
 import SockJS from "../modules/sockjs-client/index.js";
 import { log } from "../utils/log.js";
+
+/** @typedef {import("../index").EXPECTED_ANY} EXPECTED_ANY */
+
+/**
+ * @implements {CommunicationClient}
+ */
 var SockJSClient = /*#__PURE__*/function () {
   /**
-   * @param {string} url
+   * @param {string} url url
    */
   function SockJSClient(url) {
     _classCallCheck(this, SockJSClient);
     // SockJS requires `http` and `https` protocols
     this.sock = new SockJS(url.replace(/^ws:/i, "http:").replace(/^wss:/i, "https:"));
-    this.sock.onerror =
-    /**
-     * @param {Error} error
-     */
-    function (error) {
+    this.sock.onerror = function (error) {
       log.error(error);
     };
   }
 
   /**
-   * @param {(...args: any[]) => void} f
+   * @param {(...args: EXPECTED_ANY[]) => void} fn function
    */
   return _createClass(SockJSClient, [{
     key: "onOpen",
-    value: function onOpen(f) {
-      this.sock.onopen = f;
+    value: function onOpen(fn) {
+      this.sock.onopen = fn;
     }
 
     /**
-     * @param {(...args: any[]) => void} f
+     * @param {(...args: EXPECTED_ANY[]) => void} fn function
      */
   }, {
     key: "onClose",
-    value: function onClose(f) {
-      this.sock.onclose = f;
+    value: function onClose(fn) {
+      this.sock.onclose = fn;
     }
 
     // call f with the message string as the first argument
     /**
-     * @param {(...args: any[]) => void} f
+     * @param {(...args: EXPECTED_ANY[]) => void} fn function
      */
   }, {
     key: "onMessage",
-    value: function onMessage(f) {
-      this.sock.onmessage =
-      /**
-       * @param {Error & { data: string }} e
-       */
-      function (e) {
-        f(e.data);
+    value: function onMessage(fn) {
+      this.sock.onmessage = function (err) {
+        fn(err.data);
       };
     }
   }]);

package/client/clients/WebSocketClient.js

@@ -5,9 +5,15 @@ function _createClass(e, r, t) { return r && _defineProperties(e.prototype, r),
 function _toPropertyKey(t) { var i = _toPrimitive(t, "string"); return "symbol" == _typeof(i) ? i : i + ""; }
 function _toPrimitive(t, r) { if ("object" != _typeof(t) || !t) return t; var e = t[Symbol.toPrimitive]; if (void 0 !== e) { var i = e.call(t, r || "default"); if ("object" != _typeof(i)) return i; throw new TypeError("@@toPrimitive must return a primitive value."); } return ("string" === r ? String : Number)(t); }
 import { log } from "../utils/log.js";
+
+/** @typedef {import("../index").EXPECTED_ANY} EXPECTED_ANY */
+
+/**
+ * @implements {CommunicationClient}
+ */
 var WebSocketClient = /*#__PURE__*/function () {
   /**
-   * @param {string} url
+   * @param {string} url url to connect
    */
   function WebSocketClient(url) {
     _classCallCheck(this, WebSocketClient);
@@ -18,32 +24,32 @@ var WebSocketClient = /*#__PURE__*/function () {
   }
 
   /**
-   * @param {(...args: any[]) => void} f
+   * @param {(...args: EXPECTED_ANY[]) => void} fn function
    */
   return _createClass(WebSocketClient, [{
     key: "onOpen",
-    value: function onOpen(f) {
-      this.client.onopen = f;
+    value: function onOpen(fn) {
+      this.client.onopen = fn;
     }
 
     /**
-     * @param {(...args: any[]) => void} f
+     * @param {(...args: EXPECTED_ANY[]) => void} fn function
      */
   }, {
     key: "onClose",
-    value: function onClose(f) {
-      this.client.onclose = f;
+    value: function onClose(fn) {
+      this.client.onclose = fn;
     }
 
     // call f with the message string as the first argument
     /**
-     * @param {(...args: any[]) => void} f
+     * @param {(...args: EXPECTED_ANY[]) => void} fn function
      */
   }, {
     key: "onMessage",
-    value: function onMessage(f) {
-      this.client.onmessage = function (e) {
-        f(e.data);
+    value: function onMessage(fn) {
+      this.client.onmessage = function (err) {
+        fn(err.data);
       };
     }
   }]);