vibe-forge 0.4.0 → 0.8.2

package/src/lib/config.sh

@@ -0,0 +1,347 @@
+#!/usr/bin/env bash
+#
+# Vibe Forge - Configuration Management
+# Source this file in other scripts: source "$SCRIPT_DIR/lib/config.sh"
+#
+# SECURITY: This module provides safe JSON parsing without grep/cut vulnerabilities.
+#
+
+# Ensure colors are loaded for error messages
+if ! type log_error &>/dev/null; then
+    echo "Error: colors.sh must be sourced before config.sh" >&2
+    exit 1
+fi
+
+# =============================================================================
+# Agent Configuration Loading
+# =============================================================================
+
+# load_agents_from_json AGENTS_JSON_FILE
+# Loads agent configuration from JSON file into shell variables.
+# Sets: VALID_AGENTS array, AGENT_ALIASES associative array, AGENT_DISPLAY_NAMES
+#
+# SECURITY: Uses safe JSON parsing via Node.js
+load_agents_from_json() {
+    local agents_file="$1"
+
+    if [[ ! -f "$agents_file" ]]; then
+        return 1
+    fi
+
+    if ! command -v node &>/dev/null; then
+        log_error "Node.js required for agent configuration"
+        return 1
+    fi
+
+    # Derive forge root from agents file location (agents_file is $FORGE_ROOT/config/agents.json)
+    local forge_root
+    forge_root="$(cd "$(dirname "$agents_file")/.." 2>/dev/null && pwd)"
+    local env_file="$forge_root/.forge/agents.env"
+
+    # Regenerate the static env file only when agents.json is newer or cache missing
+    # SECURITY: Writing to a file and sourcing it is auditable; eval of dynamic strings is not
+    if [[ ! -f "$env_file" || "$agents_file" -nt "$env_file" ]]; then
+        mkdir -p "$(dirname "$env_file")"
+
+        # Write header + validated shell assignments to the static cache file
+        # SECURITY: File path passed as argument, not interpolated into the script
+        # SECURITY: Agent names and aliases are validated to prevent shell injection
+        # NOTE: We output direct assignments (not declare -A) since arrays are pre-declared globally
+        {
+            printf '# AUTO-GENERATED by load_agents_from_json() -- DO NOT EDIT\n'
+            printf '# Source: config/agents.json\n'
+            printf '# Regenerated automatically when agents.json is newer than this file\n'
+            node -e '
+                const fs = require("fs");
+                const file = process.argv[1];
+
+                // SECURITY: Validate identifier contains only safe characters
+                // Allows: lowercase letters, numbers, underscore, hyphen
+                function isValidIdentifier(name) {
+                    return /^[a-z0-9_-]+$/.test(name);
+                }
+
+                // SECURITY: Escape string for safe use in shell double-quoted string
+                // Escapes: $, `, ", \, newlines
+                function escapeForShell(str) {
+                    if (typeof str !== "string") return "";
+                    return str
+                        .replace(/\\/g, "\\\\")
+                        .replace(/"/g, "\\\"")
+                        .replace(/\$/g, "\\$")
+                        .replace(/`/g, "\\`")
+                        .replace(/\n/g, "\\n")
+                        .replace(/\r/g, "");
+                }
+
+                try {
+                    const data = JSON.parse(fs.readFileSync(file, "utf8"));
+                    const agents = data.agents || {};
+
+                    // SECURITY: Validate all agent names before processing
+                    for (const name of Object.keys(agents)) {
+                        if (!isValidIdentifier(name)) {
+                            console.error("SECURITY ERROR: Invalid agent name: " + name);
+                            console.error("Agent names must contain only: a-z, 0-9, underscore, hyphen");
+                            process.exit(1);
+                        }
+                        // Also validate aliases
+                        const info = agents[name];
+                        if (info.aliases) {
+                            for (const alias of info.aliases) {
+                                if (!isValidIdentifier(alias)) {
+                                    console.error("SECURITY ERROR: Invalid alias: " + alias);
+                                    console.error("Aliases must contain only: a-z, 0-9, underscore, hyphen");
+                                    process.exit(1);
+                                }
+                            }
+                        }
+                    }
+
+                    // Output VALID_AGENTS array (names validated above)
+                    const validAgents = Object.keys(agents);
+                    console.log("VALID_AGENTS=(" + validAgents.map(a => `"${a}"`).join(" ") + ")");
+
+                    // Output AGENT_ALIASES assignments (array already declared globally)
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        // Add self-mapping
+                        console.log(`AGENT_ALIASES["${canonical}"]="${canonical}"`);
+                        // Add aliases (validated above)
+                        if (info.aliases) {
+                            for (const alias of info.aliases) {
+                                console.log(`AGENT_ALIASES["${alias}"]="${canonical}"`);
+                            }
+                        }
+                    }
+
+                    // Output AGENT_DISPLAY_NAMES assignments
+                    // SECURITY: Display names are escaped since they come from user input
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        const displayName = escapeForShell(info.name || canonical);
+                        console.log(`AGENT_DISPLAY_NAMES["${canonical}"]="${displayName}"`);
+                    }
+
+                    // Output AGENT_ROLES assignments
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        const role = escapeForShell(info.role || "");
+                        console.log(`AGENT_ROLES["${canonical}"]="${role}"`);
+                    }
+
+                    // Output AGENT_PERSONALITY_FILES assignments
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        const pfile = escapeForShell(info.personality_file || "");
+                        console.log(`AGENT_PERSONALITY_FILES["${canonical}"]="${pfile}"`);
+                    }
+
+                    // Output AGENT_ICONS assignments
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        const icon = escapeForShell(info.icon || "");
+                        console.log(`AGENT_ICONS["${canonical}"]="${icon}"`);
+                    }
+
+                    // Output AGENT_TAB_COLORS assignments
+                    for (const [canonical, info] of Object.entries(agents)) {
+                        const tabColor = escapeForShell(info.tab_color || "");
+                        console.log(`AGENT_TAB_COLORS["${canonical}"]="${tabColor}"`);
+                    }
+
+                } catch (e) {
+                    console.error("Error parsing agents.json:", e.message);
+                    process.exit(1);
+                }
+            ' -- "$agents_file" 2>/dev/null
+        } > "$env_file" || { rm -f "$env_file"; return 1; }
+    fi
+
+    # Source the static cache file instead of eval-ing dynamic Node.js output
+    # SECURITY: Auditable static file; Node.js only runs when agents.json changes
+    # shellcheck source=/dev/null
+    if ! source "$env_file"; then
+        # Corrupted or invalid cache file — remove it so it regenerates on next call
+        rm -f "$env_file"
+        return 1
+    fi
+
+    # Mark as loaded
+    AGENTS_LOADED="true"
+    return 0
+}
+
+# json_get_string FILE KEY
+# Safely extracts a string value from a JSON file.
+# Uses node.js for safe parsing (available since we require Node 16+)
+#
+# SECURITY: This avoids grep/cut vulnerabilities by using proper JSON parsing.
+# SECURITY: File and key are passed as command-line arguments, not interpolated.
+json_get_string() {
+    local file="$1"
+    local key="$2"
+
+    if [[ ! -f "$file" ]]; then
+        return 1
+    fi
+
+    # Use Node.js for safe JSON parsing
+    # SECURITY: Pass file and key as arguments to avoid injection
+    if command -v node &>/dev/null; then
+        node -e '
+            const fs = require("fs");
+            const file = process.argv[1];
+            const key = process.argv[2];
+            try {
+                const data = JSON.parse(fs.readFileSync(file, "utf8"));
+                const value = data[key];
+                if (value !== undefined && value !== null) {
+                    console.log(String(value));
+                }
+            } catch (e) {
+                process.exit(1);
+            }
+        ' -- "$file" "$key" 2>/dev/null
+        return $?
+    fi
+
+    # Fallback: Use Python if available
+    # SECURITY: Pass file and key as arguments to avoid injection
+    if command -v python3 &>/dev/null; then
+        python3 -c '
+import json, sys
+try:
+    file_path = sys.argv[1]
+    key = sys.argv[2]
+    with open(file_path) as f:
+        data = json.load(f)
+    value = data.get(key)
+    if value is not None:
+        print(str(value))
+except:
+    sys.exit(1)
+' "$file" "$key" 2>/dev/null
+        return $?
+    fi
+
+    # No safe parser available - exit with error
+    log_error "No JSON parser available. Install Node.js or Python 3."
+    return 1
+}
+
+# load_forge_config CONFIG_FILE
+# Loads configuration from the forge config file into environment variables.
+# Sets: PLATFORM, GIT_BASH_PATH, TERMINAL_TYPE, FORGE_VALIDATED
+#
+# Returns: 0 on success, 1 on failure
+load_forge_config() {
+    local config_file="$1"
+
+    if [[ ! -f "$config_file" ]]; then
+        log_error "Vibe Forge not initialized."
+        echo "Run 'forge init' first." >&2
+        return 1
+    fi
+
+    # Load config values safely
+    PLATFORM=$(json_get_string "$config_file" "platform") || PLATFORM=""
+    GIT_BASH_PATH=$(json_get_string "$config_file" "git_bash_path") || GIT_BASH_PATH=""
+    TERMINAL_TYPE=$(json_get_string "$config_file" "terminal_type") || TERMINAL_TYPE="manual"
+    FORGE_VALIDATED=$(json_get_string "$config_file" "validated") || FORGE_VALIDATED="false"
+
+    # Validate required fields
+    if [[ -z "$PLATFORM" ]]; then
+        log_error "Invalid config: missing platform"
+        return 1
+    fi
+
+    return 0
+}
+
+# setup_windows_env
+# Sets up Windows-specific environment variables and PATH.
+# Call this after load_forge_config on Windows.
+setup_windows_env() {
+    if [[ "$PLATFORM" != "windows" ]]; then
+        return 0
+    fi
+
+    # Export Git Bash path for Claude Code
+    if [[ -n "$GIT_BASH_PATH" ]]; then
+        # Convert forward slashes to backslashes for Windows
+        local git_bash_win="${GIT_BASH_PATH//\//\\}"
+        export CLAUDE_CODE_GIT_BASH_PATH="$git_bash_win"
+    fi
+
+    # Add npm global path if not already in PATH
+    local npm_path=""
+
+    # Try with USER variable
+    if [[ -n "$USER" ]]; then
+        npm_path="/c/Users/$USER/AppData/Roaming/npm"
+    fi
+
+    # Try with USERPROFILE
+    if [[ -z "$npm_path" || ! -d "$npm_path" ]] && [[ -n "$USERPROFILE" ]]; then
+        npm_path="${USERPROFILE//\\//}/AppData/Roaming/npm"
+    fi
+
+    # Add to PATH if exists and not already there
+    if [[ -n "$npm_path" && -d "$npm_path" && ":$PATH:" != *":$npm_path:"* ]]; then
+        export PATH="$npm_path:$PATH"
+    fi
+}
+
+# require_forge_config FORGE_ROOT
+# Loads config and exits with error if not initialized.
+# Also applies local overrides from .forge/config.local.json if present.
+# config.local.json is gitignored and safe for per-developer settings
+# (e.g. custom terminal path, personal daemon preferences).
+require_forge_config() {
+    local forge_root="$1"
+    local config_file="$forge_root/.forge/config.json"
+    local local_config_file="$forge_root/.forge/config.local.json"
+
+    load_forge_config "$config_file" || exit 1
+
+    # Apply local overrides if present (not committed, per-developer)
+    if [[ -f "$local_config_file" ]]; then
+        local local_terminal local_git_bash local_daemon local_loop
+        local_terminal=$(json_get_string "$local_config_file" "terminal_type") && TERMINAL_TYPE="$local_terminal"
+        local_git_bash=$(json_get_string "$local_config_file" "git_bash_path") && GIT_BASH_PATH="$local_git_bash"
+        local_daemon=$(json_get_string "$local_config_file" "daemon_enabled") && DAEMON_ENABLED="$local_daemon"
+        local_loop=$(json_get_string "$local_config_file" "worker_loop_enabled") && WORKER_LOOP_ENABLED="$local_loop"
+    fi
+
+    setup_windows_env
+}
+
+# write_json_config FILE KEY VALUE
+# Safely writes/updates a key in a JSON config file.
+# Creates file if it doesn't exist.
+#
+# SECURITY: File, key, and value are passed as command-line arguments, not interpolated.
+write_json_config() {
+    local file="$1"
+    local key="$2"
+    local value="$3"
+
+    # Use Node.js for safe JSON manipulation
+    # SECURITY: Pass all values as arguments to avoid injection
+    if command -v node &>/dev/null; then
+        node -e '
+            const fs = require("fs");
+            const file = process.argv[1];
+            const key = process.argv[2];
+            const value = process.argv[3];
+            let data = {};
+            try {
+                if (fs.existsSync(file)) {
+                    data = JSON.parse(fs.readFileSync(file, "utf8"));
+                }
+            } catch (e) {}
+            data[key] = value;
+            fs.writeFileSync(file, JSON.stringify(data, null, 2) + "\n");
+        ' -- "$file" "$key" "$value" 2>/dev/null
+        return $?
+    fi
+
+    log_error "Node.js required for config writing"
+    return 1
+}

package/{bin → src}/lib/constants.sh

@@ -63,10 +63,10 @@ AGENTS_LOADED="${AGENTS_LOADED:-false}"
 # Valid agent names (whitelist for security)
 # These are the ONLY valid canonical agent names
 # NOTE: Must stay in sync with config/agents.json (which is the source of truth)
-# Last sync: 2026-01-16
+# Last sync: 2026-04-03 (added loki, renamed sentinel→temper)
 VALID_AGENTS=(
     "hub"
-    "sentinel"
+    "temper"
     "anvil"
     "furnace"
     "crucible"
@@ -75,6 +75,9 @@ VALID_AGENTS=(
     "ember"
     "aegis"
     "architect"
+    "pixel"
+    "oracle"
+    "loki"
 )
 
 # Agent aliases map (for resolve_agent)
@@ -86,11 +89,11 @@ declare -A AGENT_ALIASES=(
     ["planning"]="hub"
     ["master"]="hub"
     ["forge-master"]="hub"
-    # Sentinel aliases (Code Reviewer)
-    ["sentinel"]="sentinel"
-    ["review"]="sentinel"
-    ["reviewer"]="sentinel"
-    ["cr"]="sentinel"
+    # Temper aliases (Code Reviewer)
+    ["temper"]="temper"
+    ["review"]="temper"
+    ["reviewer"]="temper"
+    ["cr"]="temper"
     # Anvil aliases (Frontend)
     ["anvil"]="anvil"
     ["frontend"]="anvil"
@@ -131,14 +134,31 @@ declare -A AGENT_ALIASES=(
     # Architect aliases (System Design)
     ["architect"]="architect"
     ["arch"]="architect"
-    ["design"]="architect"
     ["sage"]="architect"
+    # Pixel aliases (UX Design)
+    # NOTE: "design" intentionally removed — ambiguous with architect's technical design domain
+    ["pixel"]="pixel"
+    ["ux"]="pixel"
+    ["ui-design"]="pixel"
+    ["user-experience"]="pixel"
+    # Oracle aliases (Product / Requirements)
+    ["oracle"]="oracle"
+    ["product"]="oracle"
+    ["po"]="oracle"
+    ["requirements"]="oracle"
+    ["req"]="oracle"
+    ["analyst"]="oracle"
+    # Loki aliases (Lateral Thinker)
+    ["loki"]="loki"
+    ["trickster"]="loki"
+    ["contrarian"]="loki"
+    ["brainstorm"]="loki"
 )
 
 # Agent display names
 declare -A AGENT_DISPLAY_NAMES=(
     ["hub"]="Planning Hub"
-    ["sentinel"]="Sentinel"
+    ["temper"]="Temper"
     ["anvil"]="Anvil"
     ["furnace"]="Furnace"
     ["crucible"]="Crucible"
@@ -147,12 +167,15 @@ declare -A AGENT_DISPLAY_NAMES=(
     ["ember"]="Ember"
     ["aegis"]="Aegis"
     ["architect"]="Architect"
+    ["pixel"]="Pixel"
+    ["oracle"]="Oracle"
+    ["loki"]="Loki"
 )
 
 # Agent roles
 declare -A AGENT_ROLES=(
     ["hub"]="Chief Orchestrator"
-    ["sentinel"]="Code Reviewer"
+    ["temper"]="Code Reviewer"
     ["anvil"]="Frontend Developer"
     ["furnace"]="Backend Developer"
     ["crucible"]="Tester / QA"
@@ -161,12 +184,15 @@ declare -A AGENT_ROLES=(
     ["ember"]="DevOps Engineer"
     ["aegis"]="Security Specialist"
     ["architect"]="System Architect"
+    ["pixel"]="UX Designer"
+    ["oracle"]="Product Owner / Requirements Analyst"
+    ["loki"]="Lateral Thinker"
 )
 
 # Agent personality files (relative to FORGE_ROOT)
 declare -A AGENT_PERSONALITY_FILES=(
     ["hub"]="agents/planning-hub/personality.md"
-    ["sentinel"]="agents/sentinel/personality.md"
+    ["temper"]="agents/temper/personality.md"
     ["anvil"]="agents/anvil/personality.md"
     ["furnace"]="agents/furnace/personality.md"
     ["crucible"]="agents/crucible/personality.md"
@@ -175,12 +201,15 @@ declare -A AGENT_PERSONALITY_FILES=(
     ["ember"]="agents/ember/personality.md"
     ["aegis"]="agents/aegis/personality.md"
     ["architect"]="agents/architect/personality.md"
+    ["pixel"]="agents/pixel/personality.md"
+    ["oracle"]="agents/oracle/personality.md"
+    ["loki"]="agents/loki/personality.md"
 )
 
 # Agent icons
 declare -A AGENT_ICONS=(
     ["hub"]="⚒️"
-    ["sentinel"]="🛡️"
+    ["temper"]="⚖️"
     ["anvil"]="🔨"
     ["furnace"]="🔥"
     ["crucible"]="🧪"
@@ -189,12 +218,15 @@ declare -A AGENT_ICONS=(
     ["ember"]="⚙️"
     ["aegis"]="🔒"
     ["architect"]="🏛️"
+    ["pixel"]="🎨"
+    ["oracle"]="🔮"
+    ["loki"]="🎭"
 )
 
 # Agent tab colors for Windows Terminal (hex format)
 declare -A AGENT_TAB_COLORS=(
     ["hub"]="#FF6B35"
-    ["sentinel"]="#8B5CF6"
+    ["temper"]="#8B5CF6"
     ["anvil"]="#3B82F6"
     ["furnace"]="#EF4444"
     ["crucible"]="#10B981"
@@ -203,4 +235,7 @@ declare -A AGENT_TAB_COLORS=(
     ["ember"]="#F97316"
     ["aegis"]="#06B6D4"
     ["architect"]="#6366F1"
+    ["pixel"]="#D946EF"
+    ["oracle"]="#FBBF24"
+    ["loki"]="#7C3AED"
 )

package/src/lib/daemon/budgets.sh

@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+#
+# src/lib/daemon/budgets.sh
+#
+# Token budget warnings (T2-F1)
+#
+# Monitors agent session duration as a proxy for token consumption.
+# Claude Code sessions don't expose token counts externally, so we
+# estimate from how long an agent has been continuously "working" on
+# a single task. Agents working beyond the warning threshold get an
+# attention file so the user knows to check on them.
+#
+# Dependencies: database.sh, constants.sh
+# Globals required: FORGE_ROOT, FORGE_DB, TASKS_ATTENTION, LOG_FILE
+
+# Prevent double-sourcing
+[[ -n "${_DAEMON_BUDGETS_LOADED:-}" ]] && return 0
+_DAEMON_BUDGETS_LOADED=1
+
+# Thresholds (seconds)
+TOKEN_WARN_DURATION=${TOKEN_WARN_DURATION:-5400}   # 90 minutes
+TOKEN_URGENT_DURATION=${TOKEN_URGENT_DURATION:-7200} # 2 hours
+
+# Track which agents we've already warned about (reset when they go idle)
+declare -A _budget_warned 2>/dev/null || true
+
+check_token_budgets() {
+    local now_epoch
+    now_epoch=$(date +%s)
+
+    # Query agents currently in "working" status
+    local rows
+    rows=$(sqlite3 "$FORGE_DB" \
+        "SELECT agent, task, updated_at FROM agent_status WHERE status='working';" 2>/dev/null) || return 0
+
+    [[ -z "$rows" ]] && return 0
+
+    while IFS='|' read -r agent task updated; do
+        [[ -z "$agent" || -z "$updated" ]] && continue
+
+        # Calculate how long agent has been working
+        local updated_epoch duration
+        updated_epoch=$(date -d "$updated" +%s 2>/dev/null || echo "0")
+        [[ "$updated_epoch" -eq 0 ]] && continue
+        duration=$((now_epoch - updated_epoch))
+
+        # Skip if we already warned for this agent+task combo
+        local warn_key="${agent}:${task}"
+        [[ "${_budget_warned[$warn_key]:-}" == "1" ]] && continue
+
+        local urgency=""
+        if [[ "$duration" -ge "$TOKEN_URGENT_DURATION" ]]; then
+            urgency="urgent"
+        elif [[ "$duration" -ge "$TOKEN_WARN_DURATION" ]]; then
+            urgency="normal"
+        fi
+
+        [[ -z "$urgency" ]] && continue
+
+        # Create attention file
+        local attention_dir="$FORGE_ROOT/$TASKS_ATTENTION"
+        mkdir -p "$attention_dir"
+
+        local duration_min=$((duration / 60))
+        local attention_file="$attention_dir/token-budget-${agent}.md"
+
+        # Don't overwrite if attention file already exists
+        if [[ -f "$attention_file" ]]; then
+            _budget_warned[$warn_key]=1
+            continue
+        fi
+
+        cat > "$attention_file" << BUDGET
+---
+agent: $agent
+created: $(date -Iseconds)
+type: budget-warning
+urgency: $urgency
+---
+
+## Issue
+
+Token budget warning: **$agent** has been working on \`$task\` for ${duration_min} minutes.
+
+Long-running sessions risk context degradation. Consider:
+- Check if the agent is stuck or looping
+- Use \`/compact-context\` in the agent's session
+- Split remaining work into a new task for a fresh session
+BUDGET
+
+        _budget_warned[$warn_key]=1
+        echo "[$(date -Iseconds)] TOKEN BUDGET: $agent working ${duration_min}m on $task ($urgency)" >> "$LOG_FILE"
+    done <<< "$rows"
+
+    # Clear warnings for agents that are no longer working
+    for key in "${!_budget_warned[@]}"; do
+        local agent_part="${key%%:*}"
+        local still_working
+        still_working=$(sqlite3 "$FORGE_DB" \
+            "SELECT COUNT(*) FROM agent_status WHERE agent='$agent_part' AND status='working';" 2>/dev/null || echo "0")
+        if [[ "$still_working" -eq 0 ]]; then
+            unset "_budget_warned[$key]"
+            # Clean up attention file if agent finished
+            rm -f "$FORGE_ROOT/$TASKS_ATTENTION/token-budget-${agent_part}.md" 2>/dev/null
+        fi
+    done
+}