vibe-forge 0.4.0 → 0.8.2

package/bin/forge-setup.sh

@@ -6,7 +6,7 @@
 # Usage: ./forge-setup.sh [--non-interactive]
 #
 
-set -e
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FORGE_ROOT="$(dirname "$SCRIPT_DIR")"
@@ -16,17 +16,17 @@ FORGE_ROOT="$(dirname "$SCRIPT_DIR")"
 # =============================================================================
 
 # shellcheck source=lib/colors.sh
-source "$SCRIPT_DIR/lib/colors.sh"
+source "$SCRIPT_DIR/../src/lib/colors.sh"
 # shellcheck source=lib/constants.sh
-source "$SCRIPT_DIR/lib/constants.sh"
+source "$SCRIPT_DIR/../src/lib/constants.sh"
 # shellcheck source=lib/json.sh
-source "$SCRIPT_DIR/lib/json.sh"
+source "$SCRIPT_DIR/../src/lib/json.sh"
 # shellcheck source=lib/util.sh
-source "$SCRIPT_DIR/lib/util.sh"
+source "$SCRIPT_DIR/../src/lib/util.sh"
 
 # Parse arguments
 NON_INTERACTIVE=false
-if [[ "$1" == "--non-interactive" ]]; then
+if [[ "${1:-}" == "--non-interactive" ]]; then
     NON_INTERACTIVE=true
 fi
 
@@ -197,7 +197,7 @@ configure_vcs() {
 
     # Auto-detect VCS
     local detected_vcs
-    detected_vcs=$(node "$SCRIPT_DIR/lib/vcs.js" detect 2>/dev/null)
+    detected_vcs=$(node "$SCRIPT_DIR/../src/lib/vcs.js" detect 2>/dev/null)
     local detected_type
     detected_type=$(echo "$detected_vcs" | node -e "const d=require('fs').readFileSync(0,'utf8');try{console.log(JSON.parse(d).type)}catch{console.log('none')}")
     local confidence
@@ -256,7 +256,7 @@ configure_vcs() {
 
     # Initialize VCS folders and save config
     local init_result
-    init_result=$(node "$SCRIPT_DIR/lib/vcs.js" init "$vcs_choice" "$FORGE_ROOT" 2>/dev/null)
+    init_result=$(node "$SCRIPT_DIR/../src/lib/vcs.js" init "$vcs_choice" "$FORGE_ROOT" 2>/dev/null)
 
     echo ""
     case "$vcs_choice" in
@@ -411,7 +411,10 @@ configure_daemon() {
         log_success "Daemon enabled"
         echo ""
         echo "Starting daemon..."
-        "$SCRIPT_DIR/forge-daemon.sh" start
+        if ! "$SCRIPT_DIR/forge-daemon.sh" start; then
+            log_warn "Daemon failed to start (sqlite3 may be missing)"
+            echo "   You can install sqlite3 and start it later with: forge daemon start"
+        fi
     else
         echo ""
         log_info "Daemon disabled"
@@ -534,9 +537,20 @@ create_project_context() {
 
     local context_dir="$PWD/context"
     local context_file="$context_dir/project-context.md"
-    local template_file="$FORGE_ROOT/context/project-context-template.md"
+    local template_file="$FORGE_ROOT/templates/project-context-template.md"
 
     mkdir -p "$context_dir"
+    mkdir -p "$context_dir/agent-overrides"
+
+    # Create architecture.md if missing
+    if [[ ! -f "$context_dir/architecture.md" ]] && [[ -f "$FORGE_ROOT/context/architecture.md" ]]; then
+        cp "$FORGE_ROOT/context/architecture.md" "$context_dir/architecture.md"
+    fi
+
+    # Create agent-overrides README if missing
+    if [[ ! -f "$context_dir/agent-overrides/README.md" ]] && [[ -f "$FORGE_ROOT/context/agent-overrides/README.md" ]]; then
+        cp "$FORGE_ROOT/context/agent-overrides/README.md" "$context_dir/agent-overrides/README.md"
+    fi
 
     # Check if context already exists
     if [[ -f "$context_file" ]]; then
@@ -552,6 +566,7 @@ create_project_context() {
     fi
     echo ""
 
+    local PROJECT_DESC=""
     if [[ "$NON_INTERACTIVE" == "false" ]]; then
         # Ask for project description
         read -p "Brief project description (or Enter to skip): " PROJECT_DESC
@@ -613,7 +628,9 @@ setup_complete() {
     log_info "/forge spawn anvil  Spawn a worker agent"
     log_info "/forge help         See all commands"
     echo ""
-    echo "Optional: Edit context/project-context.md to add more details."
+    echo "Optional: Edit context/project-context.md to add project details."
+    echo "         Edit context/architecture.md for architectural guardrails."
+    echo "         Add files to context/agent-overrides/ for per-agent rules."
     echo ""
 }
 

package/bin/forge-spawn.sh

@@ -10,7 +10,7 @@
 #   - Manual (prints instructions)
 #
 
-set -e
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FORGE_ROOT="$(dirname "$SCRIPT_DIR")"
@@ -21,13 +21,13 @@ CONFIG_FILE="$FORGE_ROOT/.forge/config.json"
 # =============================================================================
 
 # shellcheck source=lib/colors.sh
-source "$SCRIPT_DIR/lib/colors.sh"
+source "$SCRIPT_DIR/../src/lib/colors.sh"
 # shellcheck source=lib/constants.sh
-source "$SCRIPT_DIR/lib/constants.sh"
+source "$SCRIPT_DIR/../src/lib/constants.sh"
 # shellcheck source=lib/config.sh
-source "$SCRIPT_DIR/lib/config.sh"
+source "$SCRIPT_DIR/../src/lib/config.sh"
 # shellcheck source=lib/agents.sh
-source "$SCRIPT_DIR/lib/agents.sh"
+source "$SCRIPT_DIR/../src/lib/agents.sh"
 
 # Load agent configuration from JSON if available
 if [[ -f "$FORGE_ROOT/$AGENTS_CONFIG" ]]; then

package/bin/forge.cmd

@@ -1,83 +1,83 @@
-@echo off
-REM Vibe Forge - Windows Launcher
-REM Wraps forge.sh for Windows compatibility
-
-setlocal EnableDelayedExpansion
-
-set "SCRIPT_DIR=%~dp0"
-set "FORGE_ROOT=%SCRIPT_DIR%.."
-set "CONFIG_FILE=%FORGE_ROOT%\.forge\config.json"
-
-REM Check if this is init or help (doesn't require config)
-set "CMD=%~1"
-if "%CMD%"=="init" goto :find_bash
-if "%CMD%"=="help" goto :find_bash
-if "%CMD%"=="--help" goto :find_bash
-if "%CMD%"=="-h" goto :find_bash
-
-REM For other commands, check if initialized
-if not exist "%CONFIG_FILE%" (
-    echo Error: Vibe Forge not initialized.
-    echo Run 'forge init' first.
-    exit /b 1
-)
-
-REM Extract git_bash_path from config using PowerShell for reliable JSON parsing
-for /f "usebackq delims=" %%a in (`powershell -NoProfile -Command "(Get-Content '%CONFIG_FILE%' | ConvertFrom-Json).git_bash_path"`) do (
-    set "GIT_BASH_PATH=%%a"
-)
-
-REM Convert forward slashes to backslashes if needed
-set "GIT_BASH_PATH=!GIT_BASH_PATH:/=\!"
-
-REM Verify the path exists
-if not exist "!GIT_BASH_PATH!" (
-    echo Error: Git Bash not found at: !GIT_BASH_PATH!
-    echo Please run 'forge init' again.
-    exit /b 1
-)
-
-goto :run_forge
-
-:find_bash
-REM Find Git Bash for init/help commands
-set "GIT_BASH_PATH="
-
-REM Check common paths
-if exist "C:\Program Files\Git\bin\bash.exe" (
-    set "GIT_BASH_PATH=C:\Program Files\Git\bin\bash.exe"
-    goto :run_forge
-)
-if exist "C:\Program Files (x86)\Git\bin\bash.exe" (
-    set "GIT_BASH_PATH=C:\Program Files (x86)\Git\bin\bash.exe"
-    goto :run_forge
-)
-if exist "D:\Program Files\Git\bin\bash.exe" (
-    set "GIT_BASH_PATH=D:\Program Files\Git\bin\bash.exe"
-    goto :run_forge
-)
-if exist "D:\applications\git\bin\bash.exe" (
-    set "GIT_BASH_PATH=D:\applications\git\bin\bash.exe"
-    goto :run_forge
-)
-
-REM Try to find via where command
-for /f "tokens=*" %%i in ('where git 2^>nul') do (
-    set "GIT_PATH=%%~dpi"
-    set "GIT_BASH_PATH=!GIT_PATH!..\bin\bash.exe"
-    if exist "!GIT_BASH_PATH!" goto :run_forge
-)
-
-REM Still not found
-echo Error: Git Bash not found.
-echo Please install Git from https://git-scm.com/downloads/win
-exit /b 1
-
-:run_forge
-REM Set environment variable for Claude Code
-set "CLAUDE_CODE_GIT_BASH_PATH=%GIT_BASH_PATH%"
-
-REM Run the bash script with all arguments
-"%GIT_BASH_PATH%" "%SCRIPT_DIR%forge.sh" %*
-
-endlocal
+@echo off
+REM Vibe Forge - Windows Launcher
+REM Wraps forge.sh for Windows compatibility
+
+setlocal EnableDelayedExpansion
+
+set "SCRIPT_DIR=%~dp0"
+set "FORGE_ROOT=%SCRIPT_DIR%.."
+set "CONFIG_FILE=%FORGE_ROOT%\.forge\config.json"
+
+REM Check if this is init or help (doesn't require config)
+set "CMD=%~1"
+if "%CMD%"=="init" goto :find_bash
+if "%CMD%"=="help" goto :find_bash
+if "%CMD%"=="--help" goto :find_bash
+if "%CMD%"=="-h" goto :find_bash
+
+REM For other commands, check if initialized
+if not exist "%CONFIG_FILE%" (
+    echo Error: Vibe Forge not initialized.
+    echo Run 'forge init' first.
+    exit /b 1
+)
+
+REM Extract git_bash_path from config using PowerShell for reliable JSON parsing
+for /f "usebackq delims=" %%a in (`powershell -NoProfile -Command "(Get-Content '%CONFIG_FILE%' | ConvertFrom-Json).git_bash_path"`) do (
+    set "GIT_BASH_PATH=%%a"
+)
+
+REM Convert forward slashes to backslashes if needed
+set "GIT_BASH_PATH=!GIT_BASH_PATH:/=\!"
+
+REM Verify the path exists
+if not exist "!GIT_BASH_PATH!" (
+    echo Error: Git Bash not found at: !GIT_BASH_PATH!
+    echo Please run 'forge init' again.
+    exit /b 1
+)
+
+goto :run_forge
+
+:find_bash
+REM Find Git Bash for init/help commands
+set "GIT_BASH_PATH="
+
+REM Check common paths
+if exist "C:\Program Files\Git\bin\bash.exe" (
+    set "GIT_BASH_PATH=C:\Program Files\Git\bin\bash.exe"
+    goto :run_forge
+)
+if exist "C:\Program Files (x86)\Git\bin\bash.exe" (
+    set "GIT_BASH_PATH=C:\Program Files (x86)\Git\bin\bash.exe"
+    goto :run_forge
+)
+if exist "D:\Program Files\Git\bin\bash.exe" (
+    set "GIT_BASH_PATH=D:\Program Files\Git\bin\bash.exe"
+    goto :run_forge
+)
+if exist "D:\applications\git\bin\bash.exe" (
+    set "GIT_BASH_PATH=D:\applications\git\bin\bash.exe"
+    goto :run_forge
+)
+
+REM Try to find via where command
+for /f "tokens=*" %%i in ('where git 2^>nul') do (
+    set "GIT_PATH=%%~dpi"
+    set "GIT_BASH_PATH=!GIT_PATH!..\bin\bash.exe"
+    if exist "!GIT_BASH_PATH!" goto :run_forge
+)
+
+REM Still not found
+echo Error: Git Bash not found.
+echo Please install Git from https://git-scm.com/downloads/win
+exit /b 1
+
+:run_forge
+REM Set environment variable for Claude Code
+set "CLAUDE_CODE_GIT_BASH_PATH=%GIT_BASH_PATH%"
+
+REM Run the bash script with all arguments
+"%GIT_BASH_PATH%" "%SCRIPT_DIR%forge.sh" %*
+
+endlocal

package/bin/forge.sh

@@ -9,17 +9,17 @@
 #   forge start <agent> - Start a specific worker agent
 #   forge spawn <agent> - Spawn agent in new terminal window/tab
 #   forge status       - Show forge status
-#   forge test         - Validate setup
+#   forge doctor       - Full environment diagnostics (alias: test)
 #   forge daemon       - Start/stop the background daemon
 #   forge help         - Show help
 #
 # Security Note:
-#   This script uses --dangerously-skip-permissions for Claude Code to enable
-#   seamless agent startup. This is intentional for the forge workflow.
-#   See docs/security.md for details.
+#   Agents use allowlist-based permissions (.claude/settings.json) plus
+#   Heimdall pre-tool hooks instead of --dangerously-skip-permissions.
+#   See docs/security.md for the trust model.
 #
 
-set -e
+set -euo pipefail
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FORGE_ROOT="$(dirname "$SCRIPT_DIR")"
@@ -30,15 +30,15 @@ CONFIG_FILE="$FORGE_ROOT/.forge/config.json"
 # =============================================================================
 
 # shellcheck source=lib/colors.sh
-source "$SCRIPT_DIR/lib/colors.sh"
+source "$SCRIPT_DIR/../src/lib/colors.sh"
 # shellcheck source=lib/constants.sh
-source "$SCRIPT_DIR/lib/constants.sh"
+source "$SCRIPT_DIR/../src/lib/constants.sh"
 # shellcheck source=lib/config.sh
-source "$SCRIPT_DIR/lib/config.sh"
+source "$SCRIPT_DIR/../src/lib/config.sh"
 # shellcheck source=lib/json.sh
-source "$SCRIPT_DIR/lib/json.sh"
+source "$SCRIPT_DIR/../src/lib/json.sh"
 # shellcheck source=lib/agents.sh
-source "$SCRIPT_DIR/lib/agents.sh"
+source "$SCRIPT_DIR/../src/lib/agents.sh"
 
 # Load agent configuration from JSON if available
 # This overwrites the fallback values in constants.sh
@@ -101,6 +101,39 @@ cmd_start() {
 $(cat "$project_context")"
     fi
 
+    # Add per-project agent overrides if they exist (T2-E3)
+    local agent_override="$FORGE_ROOT/$CONTEXT_DIR/agent-overrides/${resolved}.md"
+    if [[ -f "$agent_override" ]]; then
+        system_prompt="$system_prompt
+
+---
+
+# Project-Specific Rules for $agent_name
+
+$(cat "$agent_override")"
+    fi
+
+    # Check for handoff files from previous sessions (T2-F2)
+    local handoff_dir="$FORGE_ROOT/tasks/handoffs"
+    if [[ -d "$handoff_dir" ]]; then
+        for handoff in "$handoff_dir"/*-"${resolved}"-*.md "$handoff_dir"/*-handoff.md; do
+            if [[ -f "$handoff" ]]; then
+                local handoff_agent
+                handoff_agent=$(node "$SCRIPT_DIR/../src/lib/frontmatter.js" "$handoff" "agent" 2>/dev/null | sed -n 's/^agent=//p')
+                if [[ "$handoff_agent" == "$resolved" ]]; then
+                    system_prompt="$system_prompt
+
+---
+
+# Session Handoff (from previous session)
+
+$(cat "$handoff")"
+                    break
+                fi
+            fi
+        done
+    fi
+
     # Add startup instructions based on agent type
     if [[ "$resolved" == "hub" ]]; then
         # Planning Hub startup - Party Mode Team
@@ -131,12 +164,12 @@ You are autonomous - when assigned work exists, start it without asking permissi
     fi
 
     # Launch Claude Code with the personality
-    # --dangerously-skip-permissions avoids repeated prompts when starting agents
-    # This is documented in docs/security.md
+    # Agents use project-level .claude/settings.json for permissions (allowlist + Heimdall hooks)
+    # instead of --dangerously-skip-permissions. See docs/security.md.
     if [[ "$resolved" == "hub" ]]; then
-        claude --dangerously-skip-permissions --system-prompt "$system_prompt" "begin"
+        claude --system-prompt "$system_prompt" "begin"
     else
-        claude --dangerously-skip-permissions --system-prompt "$system_prompt" "startup"
+        claude --system-prompt "$system_prompt" "startup"
     fi
 }
 
@@ -161,36 +194,182 @@ cmd_status() {
 }
 
 cmd_test() {
-    require_forge_config "$FORGE_ROOT"
+    # Alias for doctor
+    cmd_doctor
+}
 
+cmd_doctor() {
     echo ""
-    log_header "🧪 Testing Vibe Forge setup..."
+    log_header "🩺 Forge Doctor"
     echo ""
 
-    # Test Claude Code
-    echo "Testing Claude Code..."
+    local issues=0
+
+    # --- Dependencies ---
+    echo "Dependencies"
+    echo "────────────────────────────────────────────────"
+
     if claude --version &> /dev/null; then
-        log_success "Claude Code working"
+        local claude_ver
+        claude_ver=$(claude --version 2>&1 | head -1)
+        log_success "Claude Code: $claude_ver"
+    else
+        log_error "Claude Code: not found"
+        echo "   Install from: https://claude.ai/download"
+        issues=$((issues + 1))
+    fi
+
+    if command -v node &> /dev/null; then
+        local node_ver
+        node_ver=$(node --version 2>&1)
+        log_success "Node.js: $node_ver"
+        # Warn if below Node 18
+        local node_major
+        node_major=$(node --version | sed 's/v\([0-9]*\).*/\1/')
+        if [[ "$node_major" -lt 18 ]]; then
+            log_warn "Node.js $node_ver is below recommended v18+"
+        fi
+    else
+        log_error "Node.js: not found"
+        issues=$((issues + 1))
+    fi
+
+    if command -v git &> /dev/null; then
+        local git_ver
+        git_ver=$(git --version 2>&1)
+        log_success "Git: $git_ver"
+    else
+        log_error "Git: not found"
+        issues=$((issues + 1))
+    fi
+
+    if command -v sqlite3 &> /dev/null; then
+        local sq_ver
+        sq_ver=$(sqlite3 --version 2>&1 | head -1)
+        log_success "SQLite3: $sq_ver"
     else
-        log_error "Claude Code not working"
-        exit $EXIT_DEPENDENCY_MISSING
+        log_warn "SQLite3: not found (daemon metrics disabled)"
     fi
 
-    # Test personality loading
+    # --- Forge Config ---
     echo ""
-    echo "Testing personality loading..."
-    local test_output
-    test_output=$(claude --system-prompt "You are a test. Respond with only: FORGE_TEST_OK" --print "test" 2>&1 | head -1)
+    echo "Configuration"
+    echo "────────────────────────────────────────────────"
+
+    local config_file="$FORGE_ROOT/.forge/config.json"
+    local local_config_file="$FORGE_ROOT/.forge/config.local.json"
+
+    if [[ -f "$config_file" ]]; then
+        log_success "config.json: found"
+        local platform terminal
+        platform=$(json_get_string "$config_file" "platform" 2>/dev/null || echo "unknown")
+        terminal=$(json_get_string "$config_file" "terminal_type" 2>/dev/null || echo "unknown")
+        echo "   Platform: $platform | Terminal: $terminal"
+    else
+        log_error "config.json: not found — run 'forge init'"
+        issues=$((issues + 1))
+    fi
+
+    if [[ -f "$local_config_file" ]]; then
+        log_success "config.local.json: found (local overrides active)"
+    fi
+
+    # --- agents.json sync check ---
+    local agents_file="$FORGE_ROOT/config/agents.json"
+    if [[ -f "$agents_file" ]]; then
+        log_success "agents.json: found"
+        local agent_count
+        agent_count=$(node -e "const a=require('$agents_file'); console.log(Object.keys(a.agents||{}).length)" 2>/dev/null || echo "?")
+        echo "   Agents defined: $agent_count"
+    else
+        log_error "agents.json: not found"
+        issues=$((issues + 1))
+    fi
+
+    # --- Alias collision check ---
+    if [[ -f "$agents_file" ]]; then
+        local collisions
+        collisions=$(node -e "
+const a = require('$agents_file').agents || {};
+const seen = {};
+const dupes = [];
+for (const [name, info] of Object.entries(a)) {
+    const aliases = [name, ...(info.aliases || [])];
+    for (const alias of aliases) {
+        if (seen[alias] && seen[alias] !== name) {
+            dupes.push(alias + ' (' + seen[alias] + ' vs ' + name + ')');
+        }
+        seen[alias] = name;
+    }
+}
+if (dupes.length) console.log('COLLISION: ' + dupes.join(', '));
+" 2>/dev/null || true)
+        if [[ -n "$collisions" ]]; then
+            log_error "Alias collision detected: $collisions"
+            issues=$((issues + 1))
+        else
+            log_success "No alias collisions"
+        fi
+    fi
 
+    # --- Task directories ---
+    echo ""
+    echo "Task System"
+    echo "────────────────────────────────────────────────"
+
+    local tasks_dir="$FORGE_ROOT/tasks"
+    local required_dirs=("pending" "in-progress" "completed" "review" "approved" "merged" "needs-changes" "attention" "bugs")
+    for dir in "${required_dirs[@]}"; do
+        if [[ -d "$tasks_dir/$dir" ]]; then
+            local count
+            count=$(ls "$tasks_dir/$dir/"*.md 2>/dev/null | wc -l | tr -d ' ')
+            log_success "$dir/: $count task(s)"
+        else
+            log_warn "$dir/: missing (will be created by daemon)"
+        fi
+    done
+
+    # --- Daemon ---
+    echo ""
+    echo "Daemon"
+    echo "────────────────────────────────────────────────"
+
+    local pid_file="$FORGE_ROOT/.forge/daemon.pid"
+    if [[ -f "$pid_file" ]]; then
+        local pid
+        pid=$(cat "$pid_file" 2>/dev/null)
+        if kill -0 "$pid" 2>/dev/null; then
+            log_success "Daemon running (PID $pid)"
+        else
+            log_warn "Daemon PID file exists but process is dead — run 'forge daemon start'"
+        fi
+    else
+        log_warn "Daemon not running — run 'forge daemon start' for automated task routing"
+    fi
+
+    # --- Claude Code test ---
+    echo ""
+    echo "Claude Code Integration"
+    echo "────────────────────────────────────────────────"
+
+    local test_output
+    test_output=$(claude --system-prompt "You are a test. Reply only: FORGE_TEST_OK" --print "test" 2>&1 | head -1)
     if [[ "$test_output" == *"FORGE_TEST_OK"* || "$test_output" == *"test"* ]]; then
-        log_success "Personality loading working"
+        log_success "Personality injection: working"
     else
-        log_warn "Personality loading may have issues"
+        log_warn "Personality injection: response unexpected"
         echo "   Output: $test_output"
     fi
 
+    # --- Summary ---
+    echo ""
+    echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
+    if [[ $issues -eq 0 ]]; then
+        log_success "🔥 Forge looks healthy"
+    else
+        log_error "Found $issues issue(s) — resolve the errors above before starting"
+    fi
     echo ""
-    log_success "🔥 Setup validated!"
 }
 
 cmd_spawn() {
@@ -314,7 +493,7 @@ cmd_help() {
     echo "  start <agent>       Start a specific worker agent (in current terminal)"
     echo "  spawn <agent>       Spawn agent in new terminal window/tab"
     echo "  status              Show current forge status"
-    echo "  test                Validate setup is working"
+    echo "  doctor              Full environment diagnostics (alias: test)"
     echo "  daemon <action>     Manage background daemon (start|stop|status|notifications|clear)"
     echo "  config <setting>    View or change configuration settings"
     echo "  help                Show this help message"
@@ -358,8 +537,8 @@ main() {
         "status")
             cmd_status
             ;;
-        "test")
-            cmd_test
+        "test"|"doctor")
+            cmd_doctor
             ;;
         "daemon")
             shift