typeorm 0.3.7-dev.a748f3c → 0.3.7-dev.bcdddc3

package/driver/sap/SapQueryRunner.d.ts

@@ -52,13 +52,6 @@ export declare class SapQueryRunner extends BaseQueryRunner implements QueryRunn
      * Error will be thrown if transaction was not started.
      */
     rollbackTransaction(): Promise<void>;
-    /**
-     * @description Switches on/off AUTOCOMMIT mode
-     * @link https://help.sap.com/docs/HANA_SERVICE_CF/7c78579ce9b14a669c1f3295b0d8ca16/d538d11053bd4f3f847ec5ce817a3d4c.html?locale=en-US
-     */
-    setAutoCommit(options: {
-        status: "on" | "off";
-    }): Promise<void>;
     /**
      * Executes a given SQL query.
      */

package/driver/sap/SapQueryRunner.js

@@ -20,7 +20,6 @@ const QueryResult_1 = require("../../query-runner/QueryResult");
 const QueryLock_1 = require("../../query-runner/QueryLock");
 const MetadataTableType_1 = require("../types/MetadataTableType");
 const InstanceChecker_1 = require("../../util/InstanceChecker");
-const util_1 = require("util");
 /**
  * Runs queries on a single SQL Server database connection.
  */
@@ -71,11 +70,6 @@ class SapQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
             throw new TransactionAlreadyStartedError_1.TransactionAlreadyStartedError();
         await this.broadcaster.broadcast("BeforeTransactionStart");
         this.isTransactionActive = true;
-        /**
-         * Disable AUTOCOMMIT while running transaction.
-         *  Otherwise, COMMIT/ROLLBACK doesn't work in autocommit mode.
-         */
-        await this.setAutoCommit({ status: "off" });
         if (isolationLevel) {
             await this.query(`SET TRANSACTION ISOLATION LEVEL ${isolationLevel || ""}`);
         }
@@ -93,7 +87,6 @@ class SapQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         await this.broadcaster.broadcast("BeforeTransactionCommit");
         await this.query("COMMIT");
         this.isTransactionActive = false;
-        await this.setAutoCommit({ status: "on" });
         await this.broadcaster.broadcast("AfterTransactionCommit");
     }
     /**
@@ -108,25 +101,8 @@ class SapQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         await this.broadcaster.broadcast("BeforeTransactionRollback");
         await this.query("ROLLBACK");
         this.isTransactionActive = false;
-        await this.setAutoCommit({ status: "on" });
         await this.broadcaster.broadcast("AfterTransactionRollback");
     }
-    /**
-     * @description Switches on/off AUTOCOMMIT mode
-     * @link https://help.sap.com/docs/HANA_SERVICE_CF/7c78579ce9b14a669c1f3295b0d8ca16/d538d11053bd4f3f847ec5ce817a3d4c.html?locale=en-US
-     */
-    async setAutoCommit(options) {
-        const connection = await this.connect();
-        const execute = (0, util_1.promisify)(connection.exec.bind(connection));
-        connection.setAutoCommit(options.status === "on");
-        const query = `SET TRANSACTION AUTOCOMMIT DDL ${options.status.toUpperCase()};`;
-        try {
-            await execute(query);
-        }
-        catch (error) {
-            throw new error_1.QueryFailedError(query, [], error);
-        }
-    }
     /**
      * Executes a given SQL query.
      */
@@ -138,6 +114,8 @@ class SapQueryRunner extends BaseQueryRunner_1.BaseQueryRunner {
         const result = new QueryResult_1.QueryResult();
         try {
             const databaseConnection = await this.connect();
+            // we disable autocommit because ROLLBACK does not work in autocommit mode
+            databaseConnection.setAutoCommit(!this.isTransactionActive);
             this.driver.connection.logger.logQuery(query, parameters, this);
             const queryStartTime = +new Date();
             const isInsertQuery = query.substr(0, 11) === "INSERT INTO";