typeorm 0.3.7-dev.a748f3c → 0.3.7-dev.bcdddc3

package/browser/driver/sap/SapQueryRunner.d.ts

@@ -52,13 +52,6 @@ export declare class SapQueryRunner extends BaseQueryRunner implements QueryRunn
      * Error will be thrown if transaction was not started.
      */
     rollbackTransaction(): Promise<void>;
-    /**
-     * @description Switches on/off AUTOCOMMIT mode
-     * @link https://help.sap.com/docs/HANA_SERVICE_CF/7c78579ce9b14a669c1f3295b0d8ca16/d538d11053bd4f3f847ec5ce817a3d4c.html?locale=en-US
-     */
-    setAutoCommit(options: {
-        status: "on" | "off";
-    }): Promise<void>;
     /**
      * Executes a given SQL query.
      */

package/browser/driver/sap/SapQueryRunner.js

@@ -17,7 +17,6 @@ import { QueryResult } from "../../query-runner/QueryResult";
 import { QueryLock } from "../../query-runner/QueryLock";
 import { MetadataTableType } from "../types/MetadataTableType";
 import { InstanceChecker } from "../../util/InstanceChecker";
-import { promisify } from "util";
 /**
  * Runs queries on a single SQL Server database connection.
  */
@@ -68,11 +67,6 @@ export class SapQueryRunner extends BaseQueryRunner {
             throw new TransactionAlreadyStartedError();
         await this.broadcaster.broadcast("BeforeTransactionStart");
         this.isTransactionActive = true;
-        /**
-         * Disable AUTOCOMMIT while running transaction.
-         *  Otherwise, COMMIT/ROLLBACK doesn't work in autocommit mode.
-         */
-        await this.setAutoCommit({ status: "off" });
         if (isolationLevel) {
             await this.query(`SET TRANSACTION ISOLATION LEVEL ${isolationLevel || ""}`);
         }
@@ -90,7 +84,6 @@ export class SapQueryRunner extends BaseQueryRunner {
         await this.broadcaster.broadcast("BeforeTransactionCommit");
         await this.query("COMMIT");
         this.isTransactionActive = false;
-        await this.setAutoCommit({ status: "on" });
         await this.broadcaster.broadcast("AfterTransactionCommit");
     }
     /**
@@ -105,25 +98,8 @@ export class SapQueryRunner extends BaseQueryRunner {
         await this.broadcaster.broadcast("BeforeTransactionRollback");
         await this.query("ROLLBACK");
         this.isTransactionActive = false;
-        await this.setAutoCommit({ status: "on" });
         await this.broadcaster.broadcast("AfterTransactionRollback");
     }
-    /**
-     * @description Switches on/off AUTOCOMMIT mode
-     * @link https://help.sap.com/docs/HANA_SERVICE_CF/7c78579ce9b14a669c1f3295b0d8ca16/d538d11053bd4f3f847ec5ce817a3d4c.html?locale=en-US
-     */
-    async setAutoCommit(options) {
-        const connection = await this.connect();
-        const execute = promisify(connection.exec.bind(connection));
-        connection.setAutoCommit(options.status === "on");
-        const query = `SET TRANSACTION AUTOCOMMIT DDL ${options.status.toUpperCase()};`;
-        try {
-            await execute(query);
-        }
-        catch (error) {
-            throw new QueryFailedError(query, [], error);
-        }
-    }
     /**
      * Executes a given SQL query.
      */
@@ -135,6 +111,8 @@ export class SapQueryRunner extends BaseQueryRunner {
         const result = new QueryResult();
         try {
             const databaseConnection = await this.connect();
+            // we disable autocommit because ROLLBACK does not work in autocommit mode
+            databaseConnection.setAutoCommit(!this.isTransactionActive);
             this.driver.connection.logger.logQuery(query, parameters, this);
             const queryStartTime = +new Date();
             const isInsertQuery = query.substr(0, 11) === "INSERT INTO";