taxtank-core 0.17.11 → 0.17.12

package/lib/collections/property/property.collection.d.ts

@@ -1,6 +1,8 @@
 import { Collection } from '../collection';
 import { Property } from '../../models/property/property';
 import { PropertyCategory } from '../../models/property/property-category';
+import { DepreciationCollection } from '../depreciation.collection';
+import { TransactionCollection } from '../transaction/transaction.collection';
 export declare class PropertyCollection extends Collection<Property> {
     /**
      * Get new property collection filtered by category id
@@ -32,4 +34,12 @@ export declare class PropertyCollection extends Collection<Property> {
      * Get list of unique property categories from collection
      */
     getCategories(): PropertyCategory[];
+    /**
+     * Get property with the highest growth percent
+     */
+    getBestPerformanceGrowthProperty(): Property;
+    /**
+     * Get property with the lowest tax position
+     */
+    getBestPerformanceTaxProperty(transactions: TransactionCollection, depreciations: DepreciationCollection): Property;
 }

package/lib/models/depreciation/depreciation.d.ts

@@ -56,7 +56,7 @@ export declare class Depreciation extends DepreciationBase implements Expense, I
      */
     getDate(): Date;
     /**
-     * @TODO wrong year, use current financial year, check everywhere
+     * @TODO Vik: Research a problem with depreciations without current year forecast
      */
     get currentYearForecast(): DepreciationForecast;
     getForecastByYear(year: number): DepreciationForecast;
@@ -67,5 +67,8 @@ export declare class Depreciation extends DepreciationBase implements Expense, I
      * Create a new transaction from current depreciation
      */
     toTransaction(params?: {}): Transaction;
+    /**
+     * @TODO Michael: remove and check everywhere in reports
+     */
     get claimAmount(): number;
 }

package/lib/models/property/property.d.ts

@@ -12,6 +12,8 @@ import { User } from '../user/user';
 import { TaxExemptionEnum } from '../../db/Enums/property/property-sale/tax-exemption.enum';
 import { PropertySale } from './property-sale/property-sale';
 import { unitOfTime } from 'moment';
+import { TransactionCollection } from '../../collections/transaction/transaction.collection';
+import { DepreciationCollection } from '../../collections/depreciation.collection';
 /**
  * propertySale docs - https://taxtank.atlassian.net/wiki/spaces/TAXTANK/pages/4209508353/Property+Sold+button
  */
@@ -84,4 +86,5 @@ export declare class Property extends PropertyBase implements Photoable, Documen
      * ownership duration from purchase till sale
      */
     getOwnershipDuration(sale: PropertySale, unitOfTime?: unitOfTime.Diff): number;
+    getTaxPosition(transactions: TransactionCollection, depreciations: DepreciationCollection): number;
 }

package/lib/services/http/depreciation/depreciation.service.d.ts

@@ -22,12 +22,6 @@ export declare class DepreciationService extends RestService<DepreciationBase, D
      */
     listenEvents(): void;
     getOpenBalance(depreciation: Depreciation): Observable<number>;
-    /**
-     * @TODO wrong place, move to collection model
-     */
-    calculateSummaryAmount(depreciationList: Depreciation[]): number;
-    calculateBorrowingExpenses(depreciationList: Depreciation[]): Observable<number>;
-    calculateDepreciations(depreciationList: Depreciation[]): Observable<number>;
     /**
      * Upload depreciation receipt
      * @param depreciation for which will be uploaded receipt

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "taxtank-core",
-  "version": "0.17.11",
+  "version": "0.17.12",
   "private": false,
   "peerDependencies": {
     "@angular/common": "^12.2.3 || ~13.0.0",