taxtank-core 0.17.11 → 0.17.12

package/bundles/taxtank-core.umd.js

@@ -2547,6 +2547,25 @@
         PropertyCollection.prototype.getCategories = function () {
             return uniqBy__default["default"](this.items.map(function (property) { return property.category; }), 'id');
         };
+        /**
+         * Get property with the highest growth percent
+         */
+        PropertyCollection.prototype.getBestPerformanceGrowthProperty = function () {
+            return this.items.reduce(function (max, current) {
+                return max.growthPercent < current.growthPercent ? current : max;
+            }, this.first);
+        };
+        /**
+         * Get property with the lowest tax position
+         */
+        PropertyCollection.prototype.getBestPerformanceTaxProperty = function (transactions, depreciations) {
+            return this.items.reduce(function (min, current) {
+                return min.getTaxPosition(transactions.getBy('property.id', min.id), depreciations.getBy('property.id', min.id))
+                    > current.getTaxPosition(transactions.getBy('property.id', current.id), depreciations.getBy('property.id', current.id))
+                    ? current
+                    : min;
+            }, this.first);
+        };
         return PropertyCollection;
     }(Collection));
 
@@ -4357,6 +4376,9 @@
             if (unitOfTime === void 0) { unitOfTime = 'days'; }
             return moment__namespace(sale.contractDate).diff(moment__namespace(this.contractDate), unitOfTime);
         };
+        Property.prototype.getTaxPosition = function (transactions, depreciations) {
+            return transactions.cashPosition - Math.abs(depreciations.claimAmount);
+        };
         return Property;
     }(Property$1));
     __decorate([
@@ -5184,11 +5206,17 @@
         };
         Object.defineProperty(Depreciation.prototype, "currentYearForecast", {
             /**
-             * @TODO wrong year, use current financial year, check everywhere
+             * @TODO Vik: Research a problem with depreciations without current year forecast
              */
             get: function () {
                 return this.forecasts.find(function (forecast) {
                     return forecast.financialYear === new FinancialYear().year;
+                }) || classTransformer.plainToClass(DepreciationForecast, {
+                    financialYear: new FinancialYear().year,
+                    openBalance: 0,
+                    closeBalance: 0,
+                    amount: 0,
+                    claimPercent: 0
                 });
             },
             enumerable: false,
@@ -5218,6 +5246,9 @@
             return classTransformer.plainToClass(Transaction, Object.assign(params, this, { amount: this.currentYearForecast.amount }));
         };
         Object.defineProperty(Depreciation.prototype, "claimAmount", {
+            /**
+             * @TODO Michael: remove and check everywhere in reports
+             */
             get: function () {
                 var _a;
                 return ((_a = this.currentYearForecast) === null || _a === void 0 ? void 0 : _a.claimAmount) || 0;
@@ -9396,7 +9427,7 @@
          */
         PropertyService.prototype.activate = function (property) {
             var _this = this;
-            return this.http.post(this.environment.apiV2 + "/property-subscriptions", { user: property.user, property: property })
+            return this.http.post(this.environment.apiV2 + "/property-subscriptions", { property: property })
                 .pipe(operators.map(function (propertySubscriptionBase) {
                 var newPropertySubscription = classTransformer.plainToClass(PropertySubscription, propertySubscriptionBase);
                 var activatedProperty = classTransformer.plainToClass(Property, Object.assign({}, property, { subscriptions: [newPropertySubscription] }));
@@ -11448,32 +11479,6 @@
                 return response || 0;
             }));
         };
-        /**
-         * @TODO wrong place, move to collection model
-         */
-        DepreciationService.prototype.calculateSummaryAmount = function (depreciationList) {
-            return depreciationList.reduce(function (sum, depreciation) {
-                // depreciation may not have forecast item for current financial year
-                if (!depreciation.currentYearForecast) {
-                    return sum;
-                }
-                return sum + depreciation.currentYearForecast.claimAmount;
-            }, 0);
-        };
-        DepreciationService.prototype.calculateBorrowingExpenses = function (depreciationList) {
-            var _this = this;
-            return this.getByIds(depreciationList)
-                .pipe(operators.map(function (depreciations) {
-                return _this.calculateSummaryAmount(depreciations.filter(function (depreciation) { return depreciation.isBorrowingExpense(); }));
-            }));
-        };
-        DepreciationService.prototype.calculateDepreciations = function (depreciationList) {
-            var _this = this;
-            return this.getByIds(depreciationList)
-                .pipe(operators.map(function (depreciations) {
-                return _this.calculateSummaryAmount(depreciations.filter(function (depreciation) { return !depreciation.isBorrowingExpense(); }));
-            }));
-        };
         /**
          * Upload depreciation receipt
          * @param depreciation for which will be uploaded receipt