taskplane 0.29.2 → 0.30.0

package/extensions/taskplane/verification.ts

@@ -112,14 +112,19 @@ export interface FingerprintDiff {
 	fixed: TestFingerprint[];
 }
 
-
 // ── Normalization Helpers ────────────────────────────────────────────
 
 /** Max length for normalized message strings */
 const MESSAGE_NORM_MAX_LENGTH = 512;
 
-// eslint-disable-next-line no-control-regex
-const ANSI_REGEX = /[\u001b\u009b]\[[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><~]/g;
+// Built via `new RegExp` so Biome's noControlCharactersInRegex (which only
+// inspects regex literals) does not flag the \u001b/\u009b escapes that are
+// fundamental to ANSI sequence detection. Runtime behavior is identical to
+// the prior literal regex; this is a static-analysis adjustment only.
+const ANSI_REGEX = new RegExp(
+	"[\\u001b\\u009b]\\[[()#;?]*(?:[0-9]{1,4}(?:;[0-9]{0,4})*)?[0-9A-ORZcf-nqry=><~]",
+	"g",
+);
 
 /** Match duration strings like (42ms), (1.2s), (3m 12s), 42 ms, 1200ms */
 const DURATION_REGEX = /\(?\d+(?:\.\d+)?\s*(?:ms|s|m)\s*(?:\d+(?:\.\d+)?\s*(?:ms|s))?\)?/g;
@@ -172,7 +177,6 @@ export function fingerprintKey(fp: TestFingerprint): string {
 	return `${fp.commandId}\0${fp.file}\0${fp.case}\0${fp.kind}\0${fp.messageNorm}`;
 }
 
-
 // ── Command Runner ───────────────────────────────────────────────────
 
 /** Default timeout for verification commands: 5 minutes */
@@ -255,7 +259,6 @@ export function runVerificationCommands(
 	return results;
 }
 
-
 // ── Test Output Parsers ──────────────────────────────────────────────
 
 /**
@@ -371,7 +374,7 @@ export function parseVitestOutput(commandId: string, stdout: string): TestFinger
 		// This covers setup/import/runtime-at-file-load errors where Vitest marks the file as
 		// failed but produces no assertionResults (or only non-failed ones).
 		if (testFile.status === "failed") {
-			const hasFailedAssertions = hasAssertions && assertions!.some(a => a.status === "failed");
+			const hasFailedAssertions = hasAssertions && assertions!.some((a) => a.status === "failed");
 			if (!hasFailedAssertions) {
 				// No assertion-level failures captured — emit suite-level runtime_error fingerprint
 				const suiteMessage = testFile.message || "Suite failed with no message";
@@ -407,13 +410,15 @@ export function parseTestOutput(commandResult: CommandResult): TestFingerprint[]
 
 	// If command had a spawn/timeout error, produce a command_error fingerprint
 	if (error) {
-		return [{
-			commandId,
-			file: "",
-			case: "",
-			kind: "command_error",
-			messageNorm: normalizeMessage(error),
-		}];
+		return [
+			{
+				commandId,
+				file: "",
+				case: "",
+				kind: "command_error",
+				messageNorm: normalizeMessage(error),
+			},
+		];
 	}
 
 	// If exit code is 0, no failures to fingerprint
@@ -433,16 +438,17 @@ export function parseTestOutput(commandResult: CommandResult): TestFingerprint[]
 
 	// Fallback: command_error fingerprint with stderr (or stdout if stderr is empty)
 	const fallbackMessage = stderr.trim() || stdout.trim() || "Command failed with no output";
-	return [{
-		commandId,
-		file: "",
-		case: "",
-		kind: "command_error",
-		messageNorm: normalizeMessage(fallbackMessage),
-	}];
+	return [
+		{
+			commandId,
+			file: "",
+			case: "",
+			kind: "command_error",
+			messageNorm: normalizeMessage(fallbackMessage),
+		},
+	];
 }
 
-
 // ── Fingerprint Diffing ──────────────────────────────────────────────
 
 /**
@@ -509,7 +515,6 @@ export function diffFingerprints(
 	return { newFailures, preExisting, fixed };
 }
 
-
 // ── Baseline Capture ─────────────────────────────────────────────────
 
 /**

package/extensions/taskplane/waves.ts

@@ -7,7 +7,23 @@ import { join } from "path";
 import { parseDependencyReference } from "./discovery.ts";
 import { resolveOperatorId } from "./naming.ts";
 import { AllocationError, buildSegmentId, getTaskDurationMinutes } from "./types.ts";
-import type { AllocatedLane, AllocatedTask, AllocateLanesResult, AllocationErrorCode, DependencyGraph, DiscoveryError, GraphValidationResult, LaneAssignment, OrchestratorConfig, ParsedTask, TaskSegmentPlan, TaskSegmentPlanMap, WaveAssignment, WaveComputationResult, WorkspaceConfig, WorktreeInfo } from "./types.ts";
+import type {
+	AllocatedLane,
+	AllocatedTask,
+	AllocationErrorCode,
+	DependencyGraph,
+	DiscoveryError,
+	GraphValidationResult,
+	LaneAssignment,
+	OrchestratorConfig,
+	ParsedTask,
+	TaskSegmentPlan,
+	TaskSegmentPlanMap,
+	WaveAssignment,
+	WaveComputationResult,
+	WorkspaceConfig,
+	WorktreeInfo,
+} from "./types.ts";
 import { getCurrentBranch, runGit } from "./git.ts";
 import { ensureLaneWorktrees, removeAllWorktrees, removeWorktree } from "./worktree.ts";
 
@@ -56,7 +72,6 @@ export function buildDependencyGraph(
 	return { dependencies, dependents, nodes };
 }
 
-
 // ── Graph Validation ─────────────────────────────────────────────────
 
 /**
@@ -182,7 +197,6 @@ export function validateGraph(
 	};
 }
 
-
 // ── Wave Computation (Topological Sort) ──────────────────────────────
 
 /**
@@ -259,7 +273,6 @@ export function computeWaves(
 	return { waves, errors };
 }
 
-
 // ── File Scope Affinity ──────────────────────────────────────────────
 
 /**
@@ -403,7 +416,6 @@ export function applyFileScopeAffinity(
 	return result;
 }
 
-
 // ── Repo-Scoped Lane Helpers ─────────────────────────────────────────
 
 /**
@@ -505,14 +517,18 @@ export function generateLaneId(laneLocalNumber: number, repoId?: string): string
  * @param opId            - Operator identifier (sanitized, e.g., "henrylach")
  * @param repoId          - Repo identifier (undefined in repo mode)
  */
-export function generateLaneSessionId(sessionPrefix: string, laneLocalNumber: number, opId: string, repoId?: string): string {
+export function generateLaneSessionId(
+	sessionPrefix: string,
+	laneLocalNumber: number,
+	opId: string,
+	repoId?: string,
+): string {
 	if (repoId) {
 		return `${sessionPrefix}-${opId}-${repoId}-lane-${laneLocalNumber}`;
 	}
 	return `${sessionPrefix}-${opId}-lane-${laneLocalNumber}`;
 }
 
-
 // ── Repo-Scoped Worktree Resolution ─────────────────────────────────
 
 /**
@@ -583,7 +599,7 @@ export function resolveBaseBranch(
 			// instead of the orch branch, bypassing batch isolation.
 			console.error(
 				`[taskplane] resolveBaseBranch WARNING: orch branch "${batchBaseBranch}" not found in repo "${repoId}" at ${repoRoot} — falling back to repo HEAD. ` +
-				`This bypasses orch branch isolation. Ensure the orch branch was created in all workspace repos.`,
+					`This bypasses orch branch isolation. Ensure the orch branch was created in all workspace repos.`,
 			);
 		} catch (err) {
 			console.error(
@@ -621,16 +637,15 @@ export function resolveBaseBranch(
 	if (repoId && batchBaseBranch.startsWith("orch/")) {
 		throw new Error(
 			`Cannot resolve base branch for repo "${repoId}" at ${repoRoot}: ` +
-			`HEAD is detached and no defaultBranch is configured. ` +
-			`The batch base branch "${batchBaseBranch}" is an orch branch that does not exist in this repo. ` +
-			`Configure a defaultBranch for this repo in task-orchestrator.yaml workspace settings.`,
+				`HEAD is detached and no defaultBranch is configured. ` +
+				`The batch base branch "${batchBaseBranch}" is an orch branch that does not exist in this repo. ` +
+				`Configure a defaultBranch for this repo in task-orchestrator.yaml workspace settings.`,
 		);
 	}
 
 	return batchBaseBranch;
 }
 
-
 // ── Segment Planning (TP-080) ───────────────────────────────────────
 
 const SEGMENT_REPO_ID_PATTERN = /^[a-z0-9][a-z0-9-]*$/;
@@ -778,7 +793,7 @@ function buildSegmentNodes(taskId: string, repoIds: string[]) {
 		repoId,
 		order,
 	}));
-	return nodes.sort((a, b) => (a.order - b.order) || a.repoId.localeCompare(b.repoId));
+	return nodes.sort((a, b) => a.order - b.order || a.repoId.localeCompare(b.repoId));
 }
 
 export function buildSegmentPlanForTask(
@@ -839,7 +854,6 @@ export function buildTaskSegmentPlans(
 	return plans;
 }
 
-
 // ── Lane Assignment ──────────────────────────────────────────────────
 
 /**
@@ -877,9 +891,7 @@ export function assignTasksToLanes(
 
 	// Step 3: Initialize lane weights (for load-balanced assignment)
 	const laneWeights: number[] = new Array(laneCount).fill(0);
-	const laneAssignments: LaneAssignment[][] = new Array(laneCount)
-		.fill(null)
-		.map(() => []);
+	const laneAssignments: LaneAssignment[][] = new Array(laneCount).fill(null).map(() => []);
 
 	function getWeight(taskId: string): number {
 		const task = pending.get(taskId);
@@ -970,7 +982,6 @@ export function assignTasksToLanes(
 	return result;
 }
 
-
 // ── Global Lane Cap (TP-148) ─────────────────────────────────────────
 
 /**
@@ -1044,8 +1055,8 @@ export function enforceGlobalLaneCap(
 	if (finalTotal > maxLanes) {
 		console.error(
 			`[taskplane] warning: global maxLanes=${maxLanes} could not be enforced — ` +
-			`${byRepo.size} repos each need at least 1 lane (total: ${finalTotal}). ` +
-			`Increase maxLanes to at least ${byRepo.size} to avoid this.`,
+				`${byRepo.size} repos each need at least 1 lane (total: ${finalTotal}). ` +
+				`Increase maxLanes to at least ${byRepo.size} to avoid this.`,
 		);
 	}
 
@@ -1061,7 +1072,6 @@ export function enforceGlobalLaneCap(
 	}
 }
 
-
 /**
  * Result of `allocateLanes()`.
  *
@@ -1145,16 +1155,13 @@ export function validateAllocationInputs(
 		return new AllocationError(
 			"ALLOC_INVALID_CONFIG",
 			`Unknown assignment strategy: "${config.assignment.strategy}". ` +
-			`Valid strategies: ${validStrategies.join(", ")}`,
+				`Valid strategies: ${validStrategies.join(", ")}`,
 		);
 	}
 
 	// Validate worktree prefix is non-empty
 	if (!config.orchestrator.worktree_prefix?.trim()) {
-		return new AllocationError(
-			"ALLOC_INVALID_CONFIG",
-			`worktree_prefix must be a non-empty string`,
-		);
+		return new AllocationError("ALLOC_INVALID_CONFIG", `worktree_prefix must be a non-empty string`);
 	}
 
 	return null;
@@ -1336,7 +1343,12 @@ export function allocateLanes(
 		const groupLaneNumbers = repoLaneGroups.get(groupKey)!;
 		const groupRepoId = repoIdForGroup.get(groupKey);
 		const groupRepoRoot = resolveRepoRoot(groupRepoId, repoRoot, workspaceConfig);
-		const groupBaseBranch = resolveBaseBranch(groupRepoId, groupRepoRoot, baseBranch, workspaceConfig);
+		const groupBaseBranch = resolveBaseBranch(
+			groupRepoId,
+			groupRepoRoot,
+			baseBranch,
+			workspaceConfig,
+		);
 
 		const worktreeResult = ensureLaneWorktrees(
 			groupLaneNumbers,
@@ -1370,16 +1382,17 @@ export function allocateLanes(
 			const failedLanes = worktreeResult.errors
 				.map((e) => `Lane ${e.laneNumber}: [${e.code}] ${e.message}`)
 				.join("\n");
-			const withinGroupRollbackIssues = worktreeResult.rollbackErrors.length > 0
-				? "\nWithin-group rollback issues:\n" +
-				  worktreeResult.rollbackErrors
-					.map((e) => `  Lane ${e.laneNumber}: [${e.code}] ${e.message}`)
-					.join("\n")
-				: "";
-			const crossRepoRollbackIssues = rollbackErrors.length > 0
-				? "\nCross-repo rollback issues:\n" +
-				  rollbackErrors.map((e) => `  ${e}`).join("\n")
-				: "";
+			const withinGroupRollbackIssues =
+				worktreeResult.rollbackErrors.length > 0
+					? "\nWithin-group rollback issues:\n" +
+						worktreeResult.rollbackErrors
+							.map((e) => `  Lane ${e.laneNumber}: [${e.code}] ${e.message}`)
+							.join("\n")
+					: "";
+			const crossRepoRollbackIssues =
+				rollbackErrors.length > 0
+					? "\nCross-repo rollback issues:\n" + rollbackErrors.map((e) => `  ${e}`).join("\n")
+					: "";
 
 			return {
 				success: false,
@@ -1420,7 +1433,14 @@ export function allocateLanes(
 			for (const groupKey of createdGroupKeys) {
 				const groupRepoId = repoIdForGroup.get(groupKey);
 				const groupRepoRoot = resolveRepoRoot(groupRepoId, repoRoot, workspaceConfig);
-				removeAllWorktrees(config.orchestrator.worktree_prefix, groupRepoRoot, opId, undefined, batchId, config);
+				removeAllWorktrees(
+					config.orchestrator.worktree_prefix,
+					groupRepoRoot,
+					opId,
+					undefined,
+					batchId,
+					config,
+				);
 			}
 			return {
 				success: false,
@@ -1447,10 +1467,7 @@ export function allocateLanes(
 			(sum, t) => sum + (sizeWeights[t.task.size] || sizeWeights["M"] || 2),
 			0,
 		);
-		const estimatedMinutes = allocatedTasks.reduce(
-			(sum, t) => sum + t.estimatedMinutes,
-			0,
-		);
+		const estimatedMinutes = allocatedTasks.reduce((sum, t) => sum + t.estimatedMinutes, 0);
 
 		const laneSessionId = generateLaneSessionId(sessionPrefix, entry.localLane, opId, entry.repoId);
 		allocatedLanes.push({
@@ -1480,7 +1497,6 @@ export function allocateLanes(
 	};
 }
 
-
 // ── Full Wave Pipeline ───────────────────────────────────────────────
 
 /**

package/extensions/taskplane/workspace.ts

@@ -54,7 +54,6 @@ import {
 	type PointerResolution,
 } from "./types.ts";
 
-
 // ── Path Canonicalization ────────────────────────────────────────────
 
 /**
@@ -108,7 +107,6 @@ function isPathWithinContainer(childPath: string, parentPath: string): boolean {
 	return child === parent || child.startsWith(`${parent}/`);
 }
 
-
 // ── Pointer Resolution ───────────────────────────────────────────────
 
 /**
@@ -287,7 +285,6 @@ export function resolvePointer(
 	};
 }
 
-
 // ── Workspace Config Loading ─────────────────────────────────────────
 
 /**
@@ -453,9 +450,10 @@ export function loadWorkspaceConfig(workspaceRoot: string): WorkspaceConfig | nu
 		normalizedPaths.set(normalizedPath, repoId);
 
 		// Build repo config
-		const defaultBranch = typeof repoEntry.default_branch === "string" && repoEntry.default_branch.trim()
-			? repoEntry.default_branch.trim()
-			: undefined;
+		const defaultBranch =
+			typeof repoEntry.default_branch === "string" && repoEntry.default_branch.trim()
+				? repoEntry.default_branch.trim()
+				: undefined;
 
 		repos.set(repoId, {
 			id: repoId,
@@ -587,7 +585,6 @@ export function loadWorkspaceConfig(workspaceRoot: string): WorkspaceConfig | nu
 	};
 }
 
-
 // ── Cross-Config Validation ─────────────────────────────────────────
 
 /**
@@ -603,7 +600,7 @@ export function validateTaskAreasWithinTasksRoot(
 ): void {
 	const tasksRoot = workspaceConfig.routing.tasksRoot;
 	const areaEntries = Object.entries(taskRunnerConfig.task_areas ?? {}).sort((a, b) =>
-		a[0].localeCompare(b[0])
+		a[0].localeCompare(b[0]),
 	);
 
 	for (const [areaName, area] of areaEntries) {
@@ -620,7 +617,6 @@ export function validateTaskAreasWithinTasksRoot(
 	}
 }
 
-
 // ── Execution Context Builder ────────────────────────────────────────
 
 /**
@@ -643,8 +639,14 @@ function isInsideGitRepo(cwd: string): boolean {
 
 export function buildExecutionContext(
 	cwd: string,
-	loadOrchConfig: (root: string, pointerConfigRoot?: string) => import("./types.ts").OrchestratorConfig,
-	loadTaskConfig: (root: string, pointerConfigRoot?: string) => import("./types.ts").TaskRunnerConfig,
+	loadOrchConfig: (
+		root: string,
+		pointerConfigRoot?: string,
+	) => import("./types.ts").OrchestratorConfig,
+	loadTaskConfig: (
+		root: string,
+		pointerConfigRoot?: string,
+	) => import("./types.ts").TaskRunnerConfig,
 ): import("./types.ts").ExecutionContext {
 	const workspaceConfig = loadWorkspaceConfig(cwd);
 
@@ -656,7 +658,7 @@ export function buildExecutionContext(
 			throw new WorkspaceConfigError(
 				"WORKSPACE_SETUP_REQUIRED",
 				`No workspace config found at ${wsConfigFile}, and current directory is not a git repository: ${cwd}. ` +
-				`Run Taskplane from a git repository, or create ${wsConfigFile} (taskplane init) to use workspace mode.`,
+					`Run Taskplane from a git repository, or create ${wsConfigFile} (taskplane init) to use workspace mode.`,
 				undefined,
 				cwd,
 			);