taskplane 0.29.2 → 0.30.0

package/extensions/taskplane/mailbox.ts

@@ -24,7 +24,16 @@
  */
 
 import { join, dirname } from "path";
-import { existsSync, mkdirSync, writeFileSync, readFileSync, readdirSync, renameSync, unlinkSync, appendFileSync } from "fs";
+import {
+	existsSync,
+	mkdirSync,
+	writeFileSync,
+	readFileSync,
+	readdirSync,
+	renameSync,
+	unlinkSync,
+	appendFileSync,
+} from "fs";
 import { randomBytes } from "crypto";
 import type { MailboxMessage, MailboxMessageType, WriteMailboxMessageOpts } from "./types.ts";
 import { MAILBOX_DIR_NAME, MAILBOX_MAX_CONTENT_BYTES, MAILBOX_MESSAGE_TYPES } from "./types.ts";
@@ -85,7 +94,6 @@ export function broadcastInboxDir(stateRoot: string, batchId: string): string {
 	return join(stateRoot, ".pi", MAILBOX_DIR_NAME, batchId, "_broadcast", "inbox");
 }
 
-
 // ── Write ────────────────────────────────────────────────────────────
 
 /**
@@ -116,8 +124,8 @@ export function writeMailboxMessage(
 	if (contentBytes > MAILBOX_MAX_CONTENT_BYTES) {
 		throw new Error(
 			`Mailbox message content exceeds ${MAILBOX_MAX_CONTENT_BYTES} byte limit ` +
-			`(${contentBytes} bytes). Steering messages should be concise directives. ` +
-			`Write larger context to a file and reference it by path.`,
+				`(${contentBytes} bytes). Steering messages should be concise directives. ` +
+				`Write larger context to a file and reference it by path.`,
 		);
 	}
 
@@ -140,9 +148,10 @@ export function writeMailboxMessage(
 	};
 
 	// Determine inbox directory
-	const inboxDir = to === "_broadcast"
-		? broadcastInboxDir(stateRoot, batchId)
-		: sessionInboxDir(stateRoot, batchId, to);
+	const inboxDir =
+		to === "_broadcast"
+			? broadcastInboxDir(stateRoot, batchId)
+			: sessionInboxDir(stateRoot, batchId, to);
 
 	// Ensure inbox directory exists
 	mkdirSync(inboxDir, { recursive: true });
@@ -171,7 +180,6 @@ export function writeMailboxMessage(
 	return message;
 }
 
-
 // ── Read ─────────────────────────────────────────────────────────────
 
 /**
@@ -208,7 +216,7 @@ export function readInbox(
 	}
 
 	// Filter: only *.msg.json files (excludes .msg.json.tmp, .tmp, etc.)
-	const msgFiles = entries.filter(f => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
+	const msgFiles = entries.filter((f) => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
 
 	const results: Array<{ filename: string; message: MailboxMessage }> = [];
 
@@ -228,17 +236,13 @@ export function readInbox(
 		try {
 			parsed = JSON.parse(raw);
 		} catch {
-			process.stderr.write(
-				`[mailbox] WARNING: malformed JSON in ${filename}, skipping\n`,
-			);
+			process.stderr.write(`[mailbox] WARNING: malformed JSON in ${filename}, skipping\n`);
 			continue;
 		}
 
 		// Validate shape
 		if (!isValidMailboxMessage(parsed)) {
-			process.stderr.write(
-				`[mailbox] WARNING: invalid message shape in ${filename}, skipping\n`,
-			);
+			process.stderr.write(`[mailbox] WARNING: invalid message shape in ${filename}, skipping\n`);
 			continue;
 		}
 
@@ -265,7 +269,6 @@ export function readInbox(
 	return results;
 }
 
-
 // ── Acknowledge ──────────────────────────────────────────────────────
 
 /**
@@ -312,7 +315,6 @@ export function ackMessage(inboxDir: string, filename: string): boolean {
 	}
 }
 
-
 // ── Validation ───────────────────────────────────────────────────────
 
 /**
@@ -334,13 +336,14 @@ export function isValidMailboxMessage(obj: unknown): obj is MailboxMessage {
 		typeof m.batchId === "string" &&
 		typeof m.from === "string" &&
 		typeof m.to === "string" &&
-		typeof m.timestamp === "number" && Number.isFinite(m.timestamp) &&
-		typeof m.type === "string" && MAILBOX_MESSAGE_TYPES.has(m.type) &&
+		typeof m.timestamp === "number" &&
+		Number.isFinite(m.timestamp) &&
+		typeof m.type === "string" &&
+		MAILBOX_MESSAGE_TYPES.has(m.type) &&
 		typeof m.content === "string"
 	);
 }
 
-
 // ── Outbox (Agent → Supervisor, TP-106) ─────────────────────────
 
 /**
@@ -413,8 +416,14 @@ export function writeOutboxMessage(
 		writeFileSync(tempPath, JSON.stringify(message, null, 2) + "\n", "utf-8");
 		renameSync(tempPath, finalPath);
 	} catch (err) {
-		try { if (existsSync(tempPath)) unlinkSync(tempPath); } catch { /* cleanup */ }
-		throw new Error(`Failed to write outbox message: ${err instanceof Error ? err.message : String(err)}`);
+		try {
+			if (existsSync(tempPath)) unlinkSync(tempPath);
+		} catch {
+			/* cleanup */
+		}
+		throw new Error(
+			`Failed to write outbox message: ${err instanceof Error ? err.message : String(err)}`,
+		);
 	}
 
 	return message;
@@ -430,11 +439,7 @@ export function writeOutboxMessage(
  *
  * @since TP-106
  */
-export function readOutbox(
-	stateRoot: string,
-	batchId: string,
-	agentId: string,
-): MailboxMessage[] {
+export function readOutbox(stateRoot: string, batchId: string, agentId: string): MailboxMessage[] {
 	const outboxDir = sessionOutboxDir(stateRoot, batchId, agentId);
 	if (!existsSync(outboxDir)) return [];
 
@@ -445,7 +450,7 @@ export function readOutbox(
 		return [];
 	}
 
-	const msgFiles = entries.filter(f => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
+	const msgFiles = entries.filter((f) => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
 	const messages: MailboxMessage[] = [];
 
 	for (const filename of msgFiles) {
@@ -455,7 +460,9 @@ export function readOutbox(
 			if (isValidMailboxMessage(parsed)) {
 				messages.push(parsed);
 			}
-		} catch { /* skip malformed */ }
+		} catch {
+			/* skip malformed */
+		}
 	}
 
 	messages.sort((a, b) => a.timestamp - b.timestamp);
@@ -484,12 +491,19 @@ export function readOutboxHistory(
 	const outboxDir = sessionOutboxDir(stateRoot, batchId, agentId);
 	const results: Array<{ message: MailboxMessage; acked: boolean }> = [];
 
-	for (const [dir, acked] of [[outboxDir, false], [join(outboxDir, "processed"), true]] as const) {
+	for (const [dir, acked] of [
+		[outboxDir, false],
+		[join(outboxDir, "processed"), true],
+	] as const) {
 		if (!existsSync(dir)) continue;
 		let entries: string[];
-		try { entries = readdirSync(dir); } catch { continue; }
+		try {
+			entries = readdirSync(dir);
+		} catch {
+			continue;
+		}
 
-		const msgFiles = entries.filter(f => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
+		const msgFiles = entries.filter((f) => f.endsWith(".msg.json") && !f.endsWith(".msg.json.tmp"));
 		for (const filename of msgFiles) {
 			try {
 				const raw = readFileSync(join(dir, filename), "utf-8");
@@ -497,7 +511,9 @@ export function readOutboxHistory(
 				if (isValidMailboxMessage(parsed)) {
 					results.push({ message: parsed, acked });
 				}
-			} catch { /* skip malformed */ }
+			} catch {
+				/* skip malformed */
+			}
 		}
 	}
 
@@ -557,11 +573,7 @@ export function ackOutboxMessage(
  *
  * @since TP-187 (#538)
  */
-export function drainAgentOutbox(
-	stateRoot: string,
-	batchId: string,
-	agentId: string,
-): number {
+export function drainAgentOutbox(stateRoot: string, batchId: string, agentId: string): number {
 	const outboxDir = sessionOutboxDir(stateRoot, batchId, agentId);
 	if (!existsSync(outboxDir)) return 0;
 
@@ -587,7 +599,11 @@ export function drainAgentOutbox(
 
 		if (entry.endsWith(".msg.json")) {
 			if (!processedDirEnsured) {
-				try { mkdirSync(processedDir, { recursive: true }); } catch { /* fall through to rename error handling */ }
+				try {
+					mkdirSync(processedDir, { recursive: true });
+				} catch {
+					/* fall through to rename error handling */
+				}
 				processedDirEnsured = true;
 			}
 			const dstPath = join(processedDir, entry);
@@ -632,23 +648,17 @@ export function drainAgentOutbox(
  *
  * @since TP-091
  */
-export function discoverMailboxAgentIds(
-	stateRoot: string,
-	batchId: string,
-): string[] {
+export function discoverMailboxAgentIds(stateRoot: string, batchId: string): string[] {
 	const mbRoot = join(stateRoot, ".pi", MAILBOX_DIR_NAME, batchId);
 	if (!existsSync(mbRoot)) return [];
 	try {
 		const entries = readdirSync(mbRoot, { withFileTypes: true });
-		return entries
-			.filter(e => e.isDirectory() && e.name !== "_broadcast")
-			.map(e => e.name);
+		return entries.filter((e) => e.isDirectory() && e.name !== "_broadcast").map((e) => e.name);
 	} catch {
 		return [];
 	}
 }
 
-
 export type MailboxAuditEventType =
 	| "message_sent"
 	| "message_delivered"
@@ -694,7 +704,6 @@ export function appendMailboxAuditEvent(
 	}
 }
 
-
 // ── Broadcast (TP-106) ────────────────────────────────────────
 
 /**
@@ -721,7 +730,6 @@ export function writeBroadcastMessage(
 	});
 }
 
-
 // ── Rate Limiting (TP-106) ─────────────────────────────────────
 
 /** Default rate limit: max 1 message per agent per 30 seconds. */