spessasynth_lib 3.24.28 → 3.24.35

package/soundfont/basic_soundfont/write_dls/combine_zones.js

@@ -22,7 +22,7 @@ const notGlobalizedTypes = new Set([
     generatorTypes.coarseTune,         // written into wsmp, there's no global wsmp
     generatorTypes.keyNumToVolEnvHold, // KEY TO SOMETHING:
     generatorTypes.keyNumToVolEnvDecay,// cannot be globalized as they modify their respective generators
-    generatorTypes.keyNumToModEnvHold, // (for example KNTVED modifies VolEnvDecay)
+    generatorTypes.keyNumToModEnvHold, // (for example, keyNumToVolEnvDecay modifies VolEnvDecay)
     generatorTypes.keyNumToModEnvDecay
 ]);
 
@@ -78,7 +78,7 @@ export function combineZones(preset, globalize = true)
     let globalPresetKeyRange = { min: 0, max: 127 };
     let globalPresetVelRange = { min: 0, max: 127 };
     
-    // find the global zone and apply ranges, generators and modulators
+    // find the global zone and apply ranges, generators, and modulators
     const globalPresetZone = preset.presetZones.find(z => z.isGlobal);
     if (globalPresetZone)
     {
@@ -151,7 +151,7 @@ export function combineZones(preset, globalize = true)
             instZoneKeyRange = subtractRanges(instZoneKeyRange, presetZoneKeyRange);
             instZoneVelRange = subtractRanges(instZoneVelRange, presetZoneVelRange);
             
-            // if either of the zones is out of range (i.e. min larger than max)
+            // if either of the zones is out of range (i.e.m min larger than the max),
             // then we discard that zone
             if (instZoneKeyRange.max < instZoneKeyRange.min || instZoneVelRange.max < instZoneVelRange.min)
             {
@@ -175,7 +175,9 @@ export function combineZones(preset, globalize = true)
                     m => Modulator.isIdentical(mod, m));
                 if (identicalInstMod !== -1)
                 {
-                    // sum the amounts (this makes a new modulator because otherwise it would overwrite the one in the soundfont!!!
+                    // sum the amounts
+                    // (this makes a new modulator
+                    // because otherwise it would overwrite the one in the soundfont!
                     finalModList[identicalInstMod] = finalModList[identicalInstMod].sumTransform(
                         mod);
                 }
@@ -308,10 +310,10 @@ export function combineZones(preset, globalize = true)
                     break;
                 }
             }
-            // if at least one occurence, find the most used one and add it to global
+            // if at least one occurrence, find the most used one and add it to global
             if (Object.keys(occurencesForValues).length > 0)
             {
-                // [value, occurences]
+                // [value, occurrences]
                 const valueToGlobalize = Object.entries(occurencesForValues).reduce((max, curr) =>
                 {
                     if (max[1] < curr[1])
@@ -336,13 +338,13 @@ export function combineZones(preset, globalize = true)
                     {
                         if (z.generators[gen].generatorValue === targetValue)
                         {
-                            // that exact value exists. Since it's global now, remove it
+                            // That exact value exists. Since it's global now, remove it
                             z.generators.splice(gen, 1);
                         }
                     }
                     else
                     {
-                        // that type does not exist at all here.
+                        // That type does not exist at all here.
                         // Since we're globalizing, we need to add the default here.
                         if (targetValue !== defaultForChecked)
                         {
@@ -378,13 +380,13 @@ export function combineZones(preset, globalize = true)
             if (existsForAllZones === true)
             {
                 globalZone.modulators.push(Modulator.copy(checkedModulator));
-                // delete from local zones.
+                // delete it from local zones.
                 for (const zone of finalZones)
                 {
                     const modulator = zone.modulators.find(m => Modulator.isIdentical(m, checkedModulator));
                     // Check if the amount is correct.
                     // If so, delete it since it's global.
-                    // if not, then it will simply override global as it's identical.
+                    // If not, then it will simply override global as it's identical.
                     if (modulator.transformAmount === checkedModulator.transformAmount)
                     {
                         zone.modulators.splice(zone.modulators.indexOf(modulator), 1);

package/soundfont/basic_soundfont/write_dls/ins.js

@@ -9,7 +9,7 @@ import { SpessaSynthGroupCollapsed, SpessaSynthGroupEnd } from "../../../utils/l
 import { consoleColors } from "../../../utils/other.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @param preset {BasicPreset}
  * @returns {IndexedByteArray}
  */
@@ -65,7 +65,7 @@ export function writeIns(preset)
         );
     }
     
-    // write region list
+    // write the region list
     const lrgnData = combineArrays(combined.reduce((arrs, z) =>
     {
         if (!z.isGlobal)

package/soundfont/basic_soundfont/write_dls/lins.js

@@ -3,7 +3,7 @@ import { combineArrays } from "../../../utils/indexed_array.js";
 import { writeIns } from "./ins.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function writeLins()

package/soundfont/basic_soundfont/write_dls/modulator_converter.js

@@ -75,7 +75,7 @@ function getDLSDestinationFromSf2(dest, amount)
             return undefined;
         
         case generatorTypes.initialAttenuation:
-            // amount does not get EMU corrected here, as this only applies to modulator attenuation
+            // the amount does not get EMU corrected here, as this only applies to modulator attenuation
             // the generator (affected) attenuation is handled in wsmp.
             return { dest: DLSDestinations.gain, amount: -amount };
         case generatorTypes.fineTune:
@@ -193,10 +193,10 @@ function checkSF2SpecialCombos(dest, amt)
                 isBipolar: true
             };
         
-        // scale tuning is implemented in DLS via an articulator:
-        // keyNum to relative pitch at 12800 cents.
+        // Scale tuning is implemented in DLS via an articulator:
+        // keyNum to relative pitch at 12,800 cents.
         // Change that to scale tuning * 128.
-        // therefore regular scale is still 12800, half is 6400 etc.
+        // Therefore, a regular scale is still 12,800, half is 6400, etc.
         case generatorTypes.scaleTuning:
             return {
                 source: DLSSources.keyNum,
@@ -265,7 +265,7 @@ export function getDLSArticulatorFromSf2Modulator(mod)
         SpessaSynthWarn(`Invalid source: ${mod.sourceIndex}, CC: ${mod.sourceUsesCC}`);
         return undefined;
     }
-    // attenuation is the opposite of gain. Invert
+    // Attenuation is the opposite of gain. Invert.
     if (mod.modulatorDestination === generatorTypes.initialAttenuation)
     {
         sourceDirection = sourceDirection === 1 ? 0 : 1;
@@ -291,13 +291,13 @@ export function getDLSArticulatorFromSf2Modulator(mod)
     if (specialCombo !== undefined)
     {
         amt = specialCombo.amt;
-        // move source to control
+        // move the source to control
         control = source;
         controlTransformType = sourceTransformType;
         controlBipolar = sourceBipolar;
         controlDirection = sourceDirection;
         
-        // set source as static as it's either: env, lfo or keynum
+        // set source as static as it's either: env, lfo or key num
         sourceTransformType = modulatorCurveTypes.linear;
         sourceBipolar = specialCombo.isBipolar ? 1 : 0;
         sourceDirection = 0;
@@ -310,13 +310,13 @@ export function getDLSArticulatorFromSf2Modulator(mod)
         return undefined;
     }
     
-    // source curve type maps to desfont curve type in section 2.10, table 9
+    // source curve type maps to a desfont curve type in section 2.10, table 9
     let transform = 0;
     transform |= controlTransformType << 4;
     transform |= controlBipolar << 8;
     transform |= controlDirection << 9;
     
-    // use use the source curve in output transform
+    // use the source curve in output transform
     transform |= sourceTransformType;
     transform |= sourceBipolar << 14;
     transform |= sourceDirection << 15;

package/soundfont/basic_soundfont/write_dls/rgn2.js

@@ -8,7 +8,7 @@ import { writeArticulator } from "./art2.js";
 /**
  * @param zone {BasicInstrumentZone}
  * @param globalZone {BasicInstrumentZone}
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function writeDLSRegion(zone, globalZone)
@@ -35,8 +35,8 @@ export function writeDLSRegion(zone, globalZone)
     
     let rootKey = zone.getGeneratorValue(generatorTypes.overridingRootKey, zone.sample.samplePitch);
     
-    // a lot of soundfonts like to set scaletuning to 0 in drums and keep the key at 60
-    // since we implement scaletuning via a dls articulator and fluid doesn't support these,
+    // a lot of soundfonts like to set scale tuning to 0 in drums and keep the key at 60
+    // since we implement scale tuning via a dls articulator and fluid doesn't support these,
     // change the root key here
     const scaleTuning = zone.getGeneratorValue(
         generatorTypes.scaleTuning,
@@ -47,7 +47,7 @@ export function writeDLSRegion(zone, globalZone)
         rootKey = zone.keyRange.min;
     }
     
-    // wavesample (Wsmp)
+    // wave sample (Wsmp)
     const wsmp = writeWavesample(
         zone.sample,
         rootKey,
@@ -67,7 +67,7 @@ export function writeDLSRegion(zone, globalZone)
         zone.getGeneratorValue(generatorTypes.sampleModes, 0)
     );
     
-    // wavelink (wlnk)
+    // wave link (wlnk)
     const wlnkData = new IndexedByteArray(12);
     writeWord(wlnkData, 0); // fusOptions
     writeWord(wlnkData, 0); // usPhaseGroup

package/soundfont/basic_soundfont/write_dls/wave.js

@@ -46,7 +46,8 @@ export function writeDLSSample(sample)
         
         for (let i = 0; i < audio.length; i++)
         {
-            data16[i] = audio[i] * 32768;
+            // 32,767, as 32,768 may cause overflow (because vorbis can go above 1 sometimes)
+            data16[i] = audio[i] * 32767;
         }
         
         

package/soundfont/basic_soundfont/write_dls/write_dls.js

@@ -9,7 +9,7 @@ import { consoleColors } from "../../../utils/other.js";
 
 /**
  * Write the soundfont as a .dls file. Experimental
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {Uint8Array}
  */
 export function writeDLS()

package/soundfont/basic_soundfont/write_dls/wsmp.js

@@ -34,10 +34,10 @@ export function writeWavesample(
     // gain correction, use InitialAttenuation, apply attenuation correction
     const attenuationCb = attenuationCentibels * 0.4;
     
-    // gain correction:  Each unit of gain represents 1/655360 dB
+    // gain correction: Each unit of gain represents 1/655360 dB
     const lGain = Math.floor(attenuationCb * -65536);
     writeDword(wsmpData, lGain);
-    // fulOptions: has to be 2 according to all DLS files I have
+    // fulOptions: has to be 2, according to all DLS files I have
     writeDword(wsmpData, 2);
     
     const loopSize = loopEnd - loopStart;

package/soundfont/basic_soundfont/write_dls/wvpl.js

@@ -3,7 +3,7 @@ import { writeRIFFOddSize } from "../riff_chunk.js";
 import { combineArrays } from "../../../utils/indexed_array.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {{data: IndexedByteArray, indexes: number[] }}
  */
 export function writeWavePool()

package/soundfont/basic_soundfont/write_sf2/ibag.js

@@ -3,12 +3,12 @@ import { writeWord } from "../../../utils/byte_functions/little_endian.js";
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getIBAG()
 {
-    // write all ibags with their start indexes as they were changed in getIGEN() and getIMOD()
+    // write all ibag with their start indexes as they were changed in getIGEN() and getIMOD()
     const ibagsize = this.instruments.reduce((sum, i) => i.instrumentZones.length * 4 + sum, 4);
     const ibagdata = new IndexedByteArray(ibagsize);
     let zoneID = 0;

package/soundfont/basic_soundfont/write_sf2/igen.js

@@ -2,10 +2,10 @@ import { writeDword, writeWord } from "../../../utils/byte_functions/little_endi
 import { IndexedByteArray } from "../../../utils/indexed_array.js";
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
-import { generatorTypes } from "../generator.js";
+import { Generator, generatorTypes } from "../generator.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getIGEN()
@@ -16,35 +16,38 @@ export function getIGEN()
     {
         igensize += inst.instrumentZones.reduce((sum, z) =>
         {
-            // clear sample and range generators before derermining the size
+            // clear sample and range generators before determining the size
             z.generators = z.generators.filter(g =>
                 g.generatorType !== generatorTypes.sampleID &&
                 g.generatorType !== generatorTypes.keyRange &&
                 g.generatorType !== generatorTypes.velRange
             );
-            // add sample and ranges if needed
-            // unshift vel then key ( to make key first) and instrument is last
+            // add sample and ranges if necessary
+            // unshift vel then key (to make key first) and the instrument is last
             if (z.velRange.max !== 127 || z.velRange.min !== 0)
             {
-                z.generators.unshift({
-                    generatorType: generatorTypes.velRange,
-                    generatorValue: z.velRange.max << 8 | Math.max(z.velRange.min, 0)
-                });
+                z.generators.unshift(new Generator(
+                    generatorTypes.velRange,
+                    z.velRange.max << 8 | Math.max(z.velRange.min, 0),
+                    false
+                ));
             }
             if (z.keyRange.max !== 127 || z.keyRange.min !== 0)
             {
-                z.generators.unshift({
-                    generatorType: generatorTypes.keyRange,
-                    generatorValue: z.keyRange.max << 8 | Math.max(z.keyRange.min, 0)
-                });
+                z.generators.unshift(new Generator(
+                    generatorTypes.keyRange,
+                    z.keyRange.max << 8 | Math.max(z.keyRange.min, 0),
+                    false
+                ));
             }
             if (!z.isGlobal)
             {
                 // write sample
-                z.generators.push({
-                    generatorType: generatorTypes.sampleID,
-                    generatorValue: this.samples.indexOf(z.sample)
-                });
+                z.generators.push(new Generator(
+                    generatorTypes.sampleID,
+                    this.samples.indexOf(z.sample),
+                    false
+                ));
             }
             return z.generators.length * 4 + sum;
         }, 0);

package/soundfont/basic_soundfont/write_sf2/imod.js

@@ -3,13 +3,13 @@ import { writeLittleEndian, writeWord } from "../../../utils/byte_functions/litt
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getIMOD()
 {
-    // very similar to igen
-    // go through all instruments ->  zones and write modulators sequentially
+    // very similar to igen,
+    // go through all instruments -> zones and write modulators sequentially
     let imodsize = 10;
     for (const inst of this.instruments)
     {

package/soundfont/basic_soundfont/write_sf2/inst.js

@@ -4,14 +4,14 @@ import { writeWord } from "../../../utils/byte_functions/little_endian.js";
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getINST()
 {
     const instsize = this.instruments.length * 22 + 22;
     const instdata = new IndexedByteArray(instsize);
-    // the instrument start index is adjusted in ibag, simply write it here
+    // the instrument start index is adjusted in ibag, write it here
     let instrumentStart = 0;
     let instrumentID = 0;
     for (const inst of this.instruments)

package/soundfont/basic_soundfont/write_sf2/pbag.js

@@ -3,12 +3,12 @@ import { writeWord } from "../../../utils/byte_functions/little_endian.js";
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getPBAG()
 {
-    // write all pbags with their start indexes as they were changed in getPGEN() and getPMOD()
+    // write all pbag with their start indexes as they were changed in getPGEN() and getPMOD()
     const pbagsize = this.presets.reduce((sum, i) => i.presetZones.length * 4 + sum, 4);
     const pbagdata = new IndexedByteArray(pbagsize);
     let zoneID = 0;

package/soundfont/basic_soundfont/write_sf2/pgen.js

@@ -2,22 +2,22 @@ import { writeWord } from "../../../utils/byte_functions/little_endian.js";
 import { IndexedByteArray } from "../../../utils/indexed_array.js";
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
-import { generatorTypes } from "../generator.js";
+import { Generator, generatorTypes } from "../generator.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getPGEN()
 {
-    // almost identical to igen, except correct instrument instead of sample gen
-    // go through all preset zones and write generators sequentially (add 4 for terminal)
+    // almost identical to igen, except the correct instrument instead of sample gen
+    // goes through all preset zones and writes generators sequentially (add 4 for terminal)
     let pgensize = 4;
     for (const preset of this.presets)
     {
         pgensize += preset.presetZones.reduce((size, z) =>
         {
-            // clear instrument and range generators before derermining the size
+            // clear instrument and range generators before determining the size
             z.generators = z.generators.filter(g =>
                 g.generatorType !== generatorTypes.instrument &&
                 g.generatorType !== generatorTypes.keyRange &&
@@ -26,25 +26,28 @@ export function getPGEN()
             // unshift vel then key and instrument is last
             if (z.velRange.max !== 127 || z.velRange.min !== 0)
             {
-                z.generators.unshift({
-                    generatorType: generatorTypes.velRange,
-                    generatorValue: z.velRange.max << 8 | Math.max(z.velRange.min, 0)
-                });
+                z.generators.unshift(new Generator(
+                    generatorTypes.velRange,
+                    z.velRange.max << 8 | Math.max(z.velRange.min, 0),
+                    false
+                ));
             }
             if (z.keyRange.max !== 127 || z.keyRange.min !== 0)
             {
-                z.generators.unshift({
-                    generatorType: generatorTypes.keyRange,
-                    generatorValue: z.keyRange.max << 8 | Math.max(z.keyRange.min, 0)
-                });
+                z.generators.unshift(new Generator(
+                    generatorTypes.keyRange,
+                    z.keyRange.max << 8 | Math.max(z.keyRange.min, 0),
+                    false
+                ));
             }
             if (!z.isGlobal)
             {
-                // write instrument
-                z.generators.push({
-                    generatorType: generatorTypes.instrument,
-                    generatorValue: this.instruments.indexOf(z.instrument)
-                });
+                // write the instrument
+                z.generators.push(new Generator(
+                    generatorTypes.instrument,
+                    this.instruments.indexOf(z.instrument),
+                    false
+                ));
             }
             return z.generators.length * 4 + size;
         }, 0);

package/soundfont/basic_soundfont/write_sf2/phdr.js

@@ -4,7 +4,7 @@ import { writeDword, writeWord } from "../../../utils/byte_functions/little_endi
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getPHDR()
@@ -19,7 +19,7 @@ export function getPHDR()
         writeWord(phdrdata, preset.program);
         writeWord(phdrdata, preset.bank);
         writeWord(phdrdata, presetStart);
-        // 3 unused dwords, spec says to keep em so we do
+        // 3 unused dword, spec says to keep em so we do
         writeDword(phdrdata, preset.library);
         writeDword(phdrdata, preset.genre);
         writeDword(phdrdata, preset.morphology);

package/soundfont/basic_soundfont/write_sf2/pmod.js

@@ -3,12 +3,12 @@ import { writeLittleEndian, writeWord } from "../../../utils/byte_functions/litt
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @returns {IndexedByteArray}
  */
 export function getPMOD()
 {
-    // very similar to imod
+    // very similar to imod,
     // go through all presets -> zones and write modulators sequentially
     let pmodsize = 10;
     for (const preset of this.presets)

package/soundfont/basic_soundfont/write_sf2/sdta.js

@@ -4,7 +4,7 @@ import { SpessaSynthInfo } from "../../../utils/loggin.js";
 import { consoleColors } from "../../../utils/other.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @param smplStartOffsets {number[]}
  * @param smplEndOffsets {number[]}
  * @param compress {boolean}

package/soundfont/basic_soundfont/write_sf2/shdr.js

@@ -4,7 +4,7 @@ import { writeDword, writeWord } from "../../../utils/byte_functions/little_endi
 import { RiffChunk, writeRIFFChunk } from "../riff_chunk.js";
 
 /**
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @param smplStartOffsets {number[]}
  * @param smplEndOffsets {number[]}
  * @returns {IndexedByteArray}

package/soundfont/basic_soundfont/write_sf2/write.js

@@ -16,9 +16,10 @@ import { writeWord } from "../../../utils/byte_functions/little_endian.js";
 import { SpessaSynthGroupCollapsed, SpessaSynthGroupEnd, SpessaSynthInfo } from "../../../utils/loggin.js";
 /**
  * @typedef {Object} SoundFont2WriteOptions
- * @property {boolean} compress - if the soundfont should be compressed with the ogg vorbis codec
+ * @property {boolean} compress - if the soundfont should be compressed with the Ogg Vorbis codec
  * @property {number} compressionQuality - the vorbis compression quality, from -0.1 to 1
- * @property {EncodeVorbisFunction|undefined} compressionFunction - the encode vorbis function. Can be undefined if not compressing.
+ * @property {EncodeVorbisFunction|undefined} compressionFunction - the encode vorbis function.
+ * Can be undefined if not compressed.
  */
 
 /**
@@ -32,7 +33,7 @@ const DEFAULT_WRITE_OPTIONS = {
 
 /**
  * Write the soundfont as an .sf2 file. This method is DESTRUCTIVE
- * @this {BasicSoundFont}
+ * @this {BasicSoundBank}
  * @param {SoundFont2WriteOptions} options
  * @returns {Uint8Array}
  */
@@ -115,7 +116,7 @@ export function write(options = DEFAULT_WRITE_OPTIONS)
         "%cWriting SDTA...",
         consoleColors.info
     );
-    // write sdata
+    // write sdta
     const smplStartOffsets = [];
     const smplEndOffsets = [];
     const sdtaChunk = getSDTA.call(
@@ -131,7 +132,7 @@ export function write(options = DEFAULT_WRITE_OPTIONS)
         "%cWriting PDTA...",
         consoleColors.info
     );
-    // write pdata
+    // write pdta
     // go in reverse so the indexes are correct
     // instruments
     SpessaSynthInfo(
@@ -178,7 +179,7 @@ export function write(options = DEFAULT_WRITE_OPTIONS)
     const phdrChunk = getPHDR.call(this);
     // combine in the sfspec order
     const pdtadata = combineArrays([
-        new IndexedByteArray([112, 100, 116, 97]), // "ptda"
+        new IndexedByteArray([112, 100, 116, 97]), // "pdta"
         phdrChunk,
         pbagChunk,
         pmodChunk,

package/soundfont/dls/articulator_converter.js

@@ -192,6 +192,7 @@ function checkForSpecialDLSCombo(source, destination)
     }
 }
 
+// noinspection JSUnusedGlobalSymbols
 /**
  * @param source {number}
  * @param control {number}

package/soundfont/dls/dls_destinations.js

@@ -9,9 +9,9 @@ export const DLSDestinations = {
     pitch: 0x3,                 // pitch in cents
     pan: 0x4,                   // pan 10ths of a percent
     keyNum: 0x5,                // MIDI key number
-    // nuh uh, the channel controllers are not supported!!!!
-    chorusSend: 0x80,           // chorus send 10ths of a percent
-    reverbSend: 0x81,           // reverb send 10ths of a percent
+    // nuh uh, the channel controllers are not supported!
+    chorusSend: 0x80,           // chorus send level 10ths of a percent
+    reverbSend: 0x81,           // reverb send level 10ths of a percent
     
     modLfoFreq: 0x104,          // modulation LFO frequency
     modLfoDelay: 0x105,         // modulation LFO delay

package/soundfont/dls/dls_preset.js

@@ -19,7 +19,7 @@ export class DLSPreset extends BasicPreset
         const isDrums = ulBank >> 31;
         if (isDrums)
         {
-            // soundfont bank is 128 so we change it here
+            // soundfont bank is 128, so we change it here
             this.bank = 128;
         }