spessasynth_lib 3.24.28 → 3.24.35

package/README.md

@@ -111,7 +111,7 @@ Supported formats list:
   - **First note detection:** Skip unnecessary silence at the start by jumping to the first note!
   - **Lyrics support:** Both regular MIDI and .kar files!
   - **[Write MIDI files from scratch](https://github.com/spessasus/SpessaSynth/wiki/Creating-MIDI-Files)**
-  - **Easy saving:** Save with just [one function!](https://github.com/spessasus/SpessaSynth/wiki/Writing-MIDI-Files#writemidifile)
+  - **Easy saving:** Save with just [one function!](https://github.com/spessasus/SpessaSynth/wiki/Writing-MIDI-Files#writemidi)
 
 #### Read and write [RMID files with embedded SF2 soundfonts](https://github.com/spessasus/sf2-rmidi-specification#readme)
   - **[Level 4](https://github.com/spessasus/sf2-rmidi-specification#level-4) compliance:** Reads and writes *everything!*

package/external_midi/web_midi_link.js

@@ -8,7 +8,7 @@ import { SpessaSynthInfo } from "../utils/loggin.js";
  * https://www.g200kg.com/en/docs/webmidilink/
  */
 
-export class WebMidiLinkHandler
+export class WebMIDILinkHandler
 {
     /**
      * @param synth {Synthetizer} the synth to play to

package/index.js

@@ -1,6 +1,6 @@
 // Import modules
 import { loadSoundFont } from "./soundfont/load_soundfont.js";
-import { BasicSoundFont } from "./soundfont/basic_soundfont/basic_soundfont.js";
+import { BasicSoundBank } from "./soundfont/basic_soundfont/basic_soundfont.js";
 import { BasicSample } from "./soundfont/basic_soundfont/basic_sample.js";
 import { BasicInstrumentZone } from "./soundfont/basic_soundfont/basic_zones.js";
 import { BasicInstrument } from "./soundfont/basic_soundfont/basic_instrument.js";
@@ -9,40 +9,20 @@ import { Modulator } from "./soundfont/basic_soundfont/modulator.js";
 import { BasicPresetZone } from "./soundfont/basic_soundfont/basic_zones.js";
 import { BasicPreset } from "./soundfont/basic_soundfont/basic_preset.js";
 import { BasicMIDI } from "./midi_parser/basic_midi.js";
-import { MidiMessage } from "./midi_parser/midi_message.js";
+import { MIDIMessage } from "./midi_parser/midi_message.js";
 import { MIDI } from './midi_parser/midi_loader.js';
 import { RMIDINFOChunks } from "./midi_parser/rmidi_writer.js";
-import { MIDIticksToSeconds } from './midi_parser/basic_midi.js';
 import { MIDIBuilder } from "./midi_parser/midi_builder.js";
 import { Synthetizer, VOICE_CAP, DEFAULT_PERCUSSION } from './synthetizer/synthetizer.js';
 import { Sequencer } from './sequencer/sequencer.js';
 import { IndexedByteArray } from './utils/indexed_array.js';
-import { writeMIDIFile } from './midi_parser/midi_writer.js';
-import { writeRMIDI } from './midi_parser/rmidi_writer.js'
-import { applySnapshotToMIDI, modifyMIDI } from './midi_parser/midi_editor.js';
 import { audioBufferToWav } from './utils/buffer_to_wav.js';
-import {
-    SpessaSynthInfo,
-    SpessaSynthWarn,
-    SpessaSynthGroupCollapsed,
-    SpessaSynthGroupEnd,
-    SpessaSynthTable,
-    SpessaSynthLogging,
-    SpessaSynthGroup
-} from './utils/loggin.js';
+import { SpessaSynthLogging } from './utils/loggin.js';
 import { midiControllers, messageTypes } from './midi_parser/midi_message.js';
 import { MIDIDeviceHandler} from "./external_midi/midi_handler.js";
-import { WebMidiLinkHandler} from "./external_midi/web_midi_link.js";
-import { formatTime, formatTitle, consoleColors, arrayToHexString } from './utils/other.js';
-import { readBytesAsUintBigEndian } from './utils/byte_functions/big_endian.js';
-import { readBytesAsString } from "./utils/byte_functions/string.js";
-import { readLittleEndian } from "./utils/byte_functions/little_endian.js";
-import { readVariableLengthQuantity } from "./utils/byte_functions/variable_length_quantity.js";
+import { WebMIDILinkHandler} from "./external_midi/web_midi_link.js";
 import { modulatorSources } from "./soundfont/basic_soundfont/modulator.js";
-import { NON_CC_INDEX_OFFSET } from "./synthetizer/worklet_system/worklet_utilities/controller_tables.js";
-import { ALL_CHANNELS_OR_DIFFERENT_ACTION } from './synthetizer/worklet_system/message_protocol/worklet_message.js';
 import { DEFAULT_SYNTH_CONFIG } from "./synthetizer/audio_effects/effects_config.js";
-import { trimSoundfont} from "./soundfont/basic_soundfont/write_sf2/soundfont_trimmer.js";
 import { WORKLET_URL_ABSOLUTE } from './synthetizer/worklet_url.js';
 import { SynthesizerSnapshot} from "./synthetizer/worklet_system/snapshot/synthesizer_snapshot.js";
 import { ChannelSnapshot } from "./synthetizer/worklet_system/snapshot/channel_snapshot.js";
@@ -59,7 +39,7 @@ export {
     DEFAULT_SYNTH_CONFIG,
     
     // SoundFont
-    BasicSoundFont,
+    BasicSoundBank,
     BasicSample,
     BasicInstrumentZone,
     BasicInstrument,
@@ -68,46 +48,22 @@ export {
     Generator,
     Modulator,
     loadSoundFont,
-    trimSoundfont,
     modulatorSources,
     
     // MIDI
     MIDI,
     BasicMIDI,
     MIDIBuilder,
-    IndexedByteArray,
-    MidiMessage,
-    writeMIDIFile,
-    writeRMIDI,
-    applySnapshotToMIDI,
-    modifyMIDI,
-    MIDIticksToSeconds,
+    MIDIMessage,
     RMIDINFOChunks,
     
     // Utilities
+    IndexedByteArray,
     audioBufferToWav,
     SpessaSynthLogging,
-    SpessaSynthGroup,
-    SpessaSynthTable,
-    SpessaSynthGroupEnd,
-    SpessaSynthInfo,
-    SpessaSynthWarn,
-    SpessaSynthGroupCollapsed,
     midiControllers,
     messageTypes,
     MIDIDeviceHandler,
-    WebMidiLinkHandler,
-    arrayToHexString,
-    consoleColors,
-    formatTitle,
-    formatTime,
-    
-    readBytesAsUintBigEndian,
-    readBytesAsString,
-    readLittleEndian,
-    readVariableLengthQuantity,
-    
-    NON_CC_INDEX_OFFSET,
-    ALL_CHANNELS_OR_DIFFERENT_ACTION,
+    WebMIDILinkHandler,
     WORKLET_URL_ABSOLUTE
 };

package/midi_parser/basic_midi.js

@@ -4,13 +4,17 @@ import { messageTypes } from "./midi_message.js";
 import { readBytesAsUintBigEndian } from "../utils/byte_functions/big_endian.js";
 import { SpessaSynthGroup, SpessaSynthGroupEnd, SpessaSynthInfo } from "../utils/loggin.js";
 import { consoleColors, formatTitle, sanitizeKarLyrics } from "../utils/other.js";
+import { writeMIDI } from "./midi_writer.js";
+import { applySnapshotToMIDI, modifyMIDI } from "./midi_editor.js";
+import { writeRMIDI } from "./rmidi_writer.js";
+import { getUsedProgramsAndKeys } from "./used_keys_loaded.js";
 
 /**
  * BasicMIDI is the base of a complete MIDI file, used by the sequencer internally.
  * BasicMIDI is not available on the main thread, as it contains the actual track data which can be large.
  * It can be accessed by calling getMIDI() on the Sequencer.
  */
-export class BasicMIDI extends MIDISequenceData
+class BasicMIDI extends MIDISequenceData
 {
     
     /**
@@ -21,8 +25,8 @@ export class BasicMIDI extends MIDISequenceData
     
     /**
      * The actual track data of the MIDI file, represented as an array of tracks.
-     * Tracks are arrays of MidiMessage objects.
-     * @type {MidiMessage[][]}
+     * Tracks are arrays of MIDIMessage objects.
+     * @type {MIDIMessage[][]}
      */
     tracks = [];
     
@@ -560,7 +564,7 @@ export class BasicMIDI extends MIDISequenceData
          * The total playback time, in seconds
          * @type {number}
          */
-        this.duration = MIDIticksToSeconds(this.lastVoiceEventTick, this);
+        this.duration = this.MIDIticksToSeconds(this.lastVoiceEventTick);
         
         SpessaSynthInfo("%cSuccess!", consoleColors.recognized);
         SpessaSynthGroupEnd();
@@ -581,29 +585,10 @@ export class BasicMIDI extends MIDISequenceData
     }
 }
 
-/**
- * Converts ticks to time in seconds
- * @param ticks {number} time in MIDI ticks
- * @param mid {BasicMIDI|MidiData} the MIDI
- * @returns {number} time in seconds
- */
-export function MIDIticksToSeconds(ticks, mid)
-{
-    let totalSeconds = 0;
-    
-    while (ticks > 0)
-    {
-        // tempo changes are reversed, so the first element is the last tempo change
-        // and the last element is the first tempo change
-        // (always at tick 0 and tempo 120)
-        // find the last tempo change that has occurred
-        let tempo = mid.tempoChanges.find(v => v.ticks < ticks);
-        
-        // calculate the difference and tempo time
-        let timeSinceLastTempo = ticks - tempo.ticks;
-        totalSeconds += (timeSinceLastTempo * 60) / (tempo.tempo * mid.timeDivision);
-        ticks -= timeSinceLastTempo;
-    }
-    
-    return totalSeconds;
-}
+BasicMIDI.prototype.writeMIDI = writeMIDI;
+BasicMIDI.prototype.modifyMIDI = modifyMIDI;
+BasicMIDI.prototype.applySnapshotToMIDI = applySnapshotToMIDI;
+BasicMIDI.prototype.writeRMIDI = writeRMIDI;
+BasicMIDI.prototype.getUsedProgramsAndKeys = getUsedProgramsAndKeys;
+
+export { BasicMIDI };

package/midi_parser/midi_builder.js

@@ -1,5 +1,5 @@
 import { BasicMIDI } from "./basic_midi.js";
-import { messageTypes, MidiMessage } from "./midi_message.js";
+import { messageTypes, MIDIMessage } from "./midi_message.js";
 import { IndexedByteArray } from "../utils/indexed_array.js";
 import { SpessaSynthWarn } from "../utils/loggin.js";
 
@@ -59,7 +59,7 @@ export class MIDIBuilder extends BasicMIDI
         }
         this.tracks.push([]);
         this.tracks[this.tracksAmount - 1].push(
-            new MidiMessage(0, messageTypes.endOfTrack, new IndexedByteArray(0))
+            new MIDIMessage(0, messageTypes.endOfTrack, new IndexedByteArray(0))
         );
         this.addEvent(0, this.tracksAmount - 1, messageTypes.trackName, this.encoder.encode(name));
         this.addEvent(0, this.tracksAmount - 1, messageTypes.midiPort, [port]);
@@ -83,15 +83,15 @@ export class MIDIBuilder extends BasicMIDI
             SpessaSynthWarn("The EndOfTrack is added automatically. Ignoring!");
             return;
         }
-        // remove end of track
+        // remove the end of track
         this.tracks[track].pop();
-        this.tracks[track].push(new MidiMessage(
+        this.tracks[track].push(new MIDIMessage(
             ticks,
             event,
             new IndexedByteArray(eventData)
         ));
-        // add end of track
-        this.tracks[track].push(new MidiMessage(
+        // add the end of track
+        this.tracks[track].push(new MIDIMessage(
             ticks,
             messageTypes.endOfTrack,
             new IndexedByteArray(0)

package/midi_parser/midi_data.js

@@ -5,7 +5,7 @@ import { MIDISequenceData } from "./midi_sequence.js";
  * Use getMIDI() to get the actual sequence.
  * This class contains all properties that MIDI does, except for tracks and the embedded soundfont.
  */
-export class MidiData extends MIDISequenceData
+export class MIDIData extends MIDISequenceData
 {
     
     /**
@@ -53,7 +53,7 @@ export class MidiData extends MIDISequenceData
 
 /**
  * Temporary MIDI data used when the MIDI is not loaded.
- * @type {MidiData}
+ * @type {MIDIData}
  */
 export const DUMMY_MIDI_DATA = {
     duration: 99999,

package/midi_parser/midi_editor.js

@@ -1,18 +1,18 @@
-import { messageTypes, midiControllers, MidiMessage } from "./midi_message.js";
+import { messageTypes, midiControllers, MIDIMessage } from "./midi_message.js";
 import { IndexedByteArray } from "../utils/indexed_array.js";
 import { SpessaSynthGroupCollapsed, SpessaSynthGroupEnd, SpessaSynthInfo } from "../utils/loggin.js";
 import { consoleColors } from "../utils/other.js";
-import { DEFAULT_PERCUSSION } from "../synthetizer/synthetizer.js";
 
 import { customControllers } from "../synthetizer/worklet_system/worklet_utilities/controller_tables.js";
+import { DEFAULT_PERCUSSION } from "../synthetizer/synth_constants.js";
 
 /**
  * @param ticks {number}
- * @returns {MidiMessage}
+ * @returns {MIDIMessage}
  */
 export function getGsOn(ticks)
 {
-    return new MidiMessage(
+    return new MIDIMessage(
         ticks,
         messageTypes.systemExclusive,
         new IndexedByteArray([
@@ -35,11 +35,11 @@ export function getGsOn(ticks)
  * @param cc {number}
  * @param value {number}
  * @param ticks {number}
- * @returns {MidiMessage}
+ * @returns {MIDIMessage}
  */
 function getControllerChange(channel, cc, value, ticks)
 {
-    return new MidiMessage(
+    return new MIDIMessage(
         ticks,
         messageTypes.controllerChange | (channel % 16),
         new IndexedByteArray([cc, value])
@@ -49,7 +49,7 @@ function getControllerChange(channel, cc, value, ticks)
 /**
  * @param channel {number}
  * @param ticks {number}
- * @returns {MidiMessage}
+ * @returns {MIDIMessage}
  */
 function getDrumChange(channel, ticks)
 {
@@ -70,7 +70,7 @@ function getDrumChange(channel, ticks)
     const sum = 0x40 + chanAddress + 0x15 + 0x01;
     const checksum = 128 - (sum % 128);
     // add system exclusive to enable drums
-    return new MidiMessage(
+    return new MIDIMessage(
         ticks,
         messageTypes.systemExclusive,
         new IndexedByteArray([
@@ -110,20 +110,20 @@ function getDrumChange(channel, ticks)
  * Allows easy editing of the file by removing channels, changing programs,
  * changing controllers and transposing channels. Note that this modifies the MIDI in-place.
  *
- * @param {BasicMIDI} midi - The MIDI file to modify.
+ * @this {BasicMIDI}
  * @param {DesiredProgramChange[]} desiredProgramChanges - The programs to set on given channels.
  * @param {DesiredControllerChange[]} desiredControllerChanges - The controllers to set on given channels.
  * @param {number[]} desiredChannelsToClear - The channels to remove from the sequence.
  * @param {DesiredChanneltranspose[]} desiredChannelsToTranspose - The channels to transpose.
  */
 export function modifyMIDI(
-    midi,
     desiredProgramChanges = [],
     desiredControllerChanges = [],
     desiredChannelsToClear = [],
     desiredChannelsToTranspose = []
 )
 {
+    const midi = this;
     SpessaSynthGroupCollapsed("%cApplying changes to the MIDI file...", consoleColors.info);
     
     /**
@@ -252,7 +252,7 @@ export function modifyMIDI(
         };
         
         /**
-         * @param e {MidiMessage}
+         * @param e {MIDIMessage}
          * @param offset{number}
          */
         const addEventBefore = (e, offset = 0) =>
@@ -352,7 +352,7 @@ export function modifyMIDI(
                         // the output event order is: drums -> lsb -> msb -> program change
                         
                         // add program change
-                        const programChange = new MidiMessage(
+                        const programChange = new MIDIMessage(
                             e.ticks,
                             messageTypes.programChange | midiChannel,
                             new IndexedByteArray([
@@ -527,10 +527,10 @@ export function modifyMIDI(
 
 /**
  * Modifies the sequence according to the locked presets and controllers in the given snapshot
- * @param midi {BasicMIDI}
+ * @this {BasicMIDI}
  * @param snapshot {SynthesizerSnapshot}
  */
-export function applySnapshotToMIDI(midi, snapshot)
+export function applySnapshotToMIDI(snapshot)
 {
     /**
      * @type {{
@@ -600,5 +600,5 @@ export function applySnapshotToMIDI(midi, snapshot)
             });
         });
     });
-    modifyMIDI(midi, programChanges, controllerChanges, channelsToClear, channelsToTranspose);
+    this.modifyMIDI(programChanges, controllerChanges, channelsToClear, channelsToTranspose);
 }

package/midi_parser/midi_loader.js

@@ -1,4 +1,4 @@
-import { dataBytesAmount, getChannel, MidiMessage } from "./midi_message.js";
+import { dataBytesAmount, getChannel, MIDIMessage } from "./midi_message.js";
 import { IndexedByteArray } from "../utils/indexed_array.js";
 import { consoleColors } from "../utils/other.js";
 import { SpessaSynthGroupCollapsed, SpessaSynthGroupEnd, SpessaSynthInfo, SpessaSynthWarn } from "../utils/loggin.js";
@@ -172,7 +172,7 @@ class MIDI extends BasicMIDI
         for (let i = 0; i < this.tracksAmount; i++)
         {
             /**
-             * @type {MidiMessage[]}
+             * @type {MIDIMessage[]}
              */
             const track = [];
             const trackChunk = this.readMIDIChunk(fileByteArray);
@@ -262,7 +262,7 @@ class MIDI extends BasicMIDI
                     trackChunk.data.currentIndex,
                     trackChunk.data.currentIndex + eventDataLength
                 ), 0);
-                const event = new MidiMessage(totalTicks, statusByte, eventData);
+                const event = new MIDIMessage(totalTicks, statusByte, eventData);
                 track.push(event);
                 // advance the track chunk
                 trackChunk.data.currentIndex += eventDataLength;

package/midi_parser/midi_message.js

@@ -5,7 +5,7 @@ import { IndexedByteArray } from "../utils/indexed_array.js";
  * purpose: contains enums for midi events and controllers and functions to parse them
  */
 
-export class MidiMessage
+export class MIDIMessage
 {
     /**
      * Absolute number of MIDI ticks from the start of the track.
@@ -249,6 +249,6 @@ export const dataBytesAmount = {
     0xA: 2, // note at
     0xB: 2, // cc change
     0xC: 1, // pg change
-    0xD: 1, // channel aftertouch
+    0xD: 1, // channel after touch
     0xE: 2  // pitch wheel
 };

package/midi_parser/midi_sequence.js

@@ -2,10 +2,10 @@
  * This is the base type for MIDI files. It contains all the "metadata" and information.
  * It extends to:
  * - BasicMIDI, which contains the actual track data of the MIDI file. Essentially the MIDI file itself.
- * - MidiData, which contains all properties that MIDI does, except for tracks and the embedded soundfont.
- * MidiData is the "shell" of the file which is available on the main thread at all times, containing the metadata.
+ * - MIDIData, which contains all properties that MIDI does, except for tracks and the embedded soundfont.
+ * MIDIData is the "shell" of the file which is available on the main thread at all times, containing the metadata.
  */
-export class MIDISequenceData
+class MIDISequenceData
 {
     /**
      * The time division of the sequence, representing the number of ticks per beat.
@@ -143,4 +143,32 @@ export class MIDISequenceData
      * @type {boolean}
      */
     isKaraokeFile = false;
-}
+    
+    /**
+     * Converts ticks to time in seconds
+     * @param ticks {number} time in MIDI ticks
+     * @returns {number} time in seconds
+     */
+    MIDIticksToSeconds(ticks)
+    {
+        let totalSeconds = 0;
+        
+        while (ticks > 0)
+        {
+            // tempo changes are reversed, so the first element is the last tempo change
+            // and the last element is the first tempo change
+            // (always at tick 0 and tempo 120)
+            // find the last tempo change that has occurred
+            let tempo = this.tempoChanges.find(v => v.ticks < ticks);
+            
+            // calculate the difference and tempo time
+            let timeSinceLastTempo = ticks - tempo.ticks;
+            totalSeconds += (timeSinceLastTempo * 60) / (tempo.tempo * this.timeDivision);
+            ticks -= timeSinceLastTempo;
+        }
+        
+        return totalSeconds;
+    }
+}
+
+export { MIDISequenceData };

package/midi_parser/midi_writer.js

@@ -3,12 +3,12 @@ import { writeVariableLengthQuantity } from "../utils/byte_functions/variable_le
 import { writeBytesAsUintBigEndian } from "../utils/byte_functions/big_endian.js";
 
 /**
- * Exports the midi as a .mid file
- * @param midi {BasicMIDI} the midi to export
- * @returns {Uint8Array} the binary .mid file data
+ * Exports the midi as a standard MIDI file
+ * @this {BasicMIDI}
  */
-export function writeMIDIFile(midi)
+export function writeMIDI()
 {
+    const midi = this;
     if (!midi.tracks)
     {
         throw new Error("MIDI has no tracks!");
@@ -24,7 +24,7 @@ export function writeMIDIFile(midi)
         let runningByte = undefined;
         for (const event of track)
         {
-            // ticks stored in MIDI are absolute, but .mid wants relative. Convert them here.
+            // Ticks stored in MIDI are absolute, but SMF wants relative. Convert them here.
             const deltaTicks = event.ticks - currentTick;
             /**
              * @type {number[]}
@@ -33,7 +33,7 @@ export function writeMIDIFile(midi)
             // determine the message
             if (event.messageStatusByte <= messageTypes.keySignature || event.messageStatusByte === messageTypes.sequenceSpecific)
             {
-                // this is a meta message
+                // this is a meta-message
                 // syntax is FF<type><length><data>
                 messageData = [0xff, event.messageStatusByte, ...writeVariableLengthQuantity(event.messageData.length), ...event.messageData];
             }
@@ -49,7 +49,7 @@ export function writeMIDIFile(midi)
                 messageData = [];
                 if (runningByte !== event.messageStatusByte)
                 {
-                    // running byte was not the byte we want. Add the byte here.
+                    // Running byte was not the byte we want. Add the byte here.
                     runningByte = event.messageStatusByte;
                     // add the status byte to the midi
                     messageData.push(event.messageStatusByte);
@@ -59,7 +59,7 @@ export function writeMIDIFile(midi)
             }
             // write VLQ
             binaryTrack.push(...writeVariableLengthQuantity(deltaTicks));
-            // write message
+            // write the message
             binaryTrack.push(...messageData);
             currentTick += deltaTicks;
         }

package/midi_parser/rmidi_writer.js

@@ -1,13 +1,12 @@
 import { combineArrays, IndexedByteArray } from "../utils/indexed_array.js";
-import { writeMIDIFile } from "./midi_writer.js";
 import { writeRIFFOddSize } from "../soundfont/basic_soundfont/riff_chunk.js";
 import { getStringBytes, getStringBytesZero } from "../utils/byte_functions/string.js";
-import { messageTypes, midiControllers, MidiMessage } from "./midi_message.js";
-import { DEFAULT_PERCUSSION } from "../synthetizer/synthetizer.js";
+import { messageTypes, midiControllers, MIDIMessage } from "./midi_message.js";
 import { getGsOn } from "./midi_editor.js";
 import { SpessaSynthGroup, SpessaSynthGroupEnd, SpessaSynthInfo } from "../utils/loggin.js";
 import { consoleColors } from "../utils/other.js";
 import { writeLittleEndian } from "../utils/byte_functions/little_endian.js";
+import { DEFAULT_PERCUSSION } from "../synthetizer/synth_constants.js";
 
 /**
  * @enum {string}
@@ -48,9 +47,9 @@ const DEFAULT_COPYRIGHT = "Created using SpessaSynth";
 
 /**
  * Writes an RMIDI file
+ * @this {BasicMIDI}
  * @param soundfontBinary {Uint8Array}
- * @param mid {BasicMIDI}
- * @param soundfont {BasicSoundFont}
+ * @param soundfont {BasicSoundBank}
  * @param bankOffset {number} the bank offset for RMIDI
  * @param encoding {string} the encoding of the RMIDI info chunk
  * @param metadata {RMIDMetadata} the metadata of the file. Optional. If provided, the encoding is forced to utf-8/
@@ -59,7 +58,6 @@ const DEFAULT_COPYRIGHT = "Created using SpessaSynth";
  */
 export function writeRMIDI(
     soundfontBinary,
-    mid,
     soundfont,
     bankOffset = 0,
     encoding = "Shift_JIS",
@@ -67,6 +65,7 @@ export function writeRMIDI(
     correctBankOffset = true
 )
 {
+    const mid = this;
     SpessaSynthGroup("%cWriting the RMIDI File...", consoleColors.info);
     SpessaSynthInfo(
         `%cConfiguration: Bank offset: %c${bankOffset}%c, encoding: %c${encoding}`,
@@ -79,14 +78,14 @@ export function writeRMIDI(
     SpessaSynthInfo("Initial bank offset", mid.bankOffset);
     if (correctBankOffset)
     {
-        // add offset to bank.
+        // Add the offset to the bank.
         // See https://github.com/spessasus/sf2-rmidi-specification#readme
-        // also fix presets that don't exists
-        // since midiplayer6 doesn't seem to default to 0 when nonextistent...
+        // also fix presets that don't exist
+        // since midi player6 doesn't seem to default to 0 when non-existent...
         let system = "gm";
         /**
          * The unwanted system messages such as gm/gm2 on
-         * @type {{tNum: number, e: MidiMessage}[]}
+         * @type {{tNum: number, e: MIDIMessage}[]}
          */
         let unwantedSystems = [];
         /**
@@ -115,14 +114,14 @@ export function writeRMIDI(
             return index;
         }
         
-        // it copies midiPorts everywhere else, but here 0 works so DO NOT CHANGE!!!!!!!
+        // it copies midiPorts everywhere else, but here 0 works so DO NOT CHANGE!
         const ports = Array(mid.tracks.length).fill(0);
         const channelsAmount = 16 + mid.midiPortChannelOffsets.reduce((max, cur) => cur > max ? cur : max);
         /**
          * @type {{
          *     program: number,
          *     drums: boolean,
-         *     lastBank: MidiMessage,
+         *     lastBank: MIDIMessage,
          *     hasBankSelect: boolean
          * }[]}
          */
@@ -222,7 +221,7 @@ export function writeRMIDI(
                 {
                     if (soundfont.presets.findIndex(p => p.program === e.messageData[0] && p.bank === 128) === -1)
                     {
-                        // doesn't exist. pick any preset that has the 128 bank.
+                        // doesn't exist. pick any preset that has bank 128.
                         e.messageData[0] = soundfont.presets.find(p => p.bank === 128)?.program || 0;
                     }
                 }
@@ -230,7 +229,7 @@ export function writeRMIDI(
                 {
                     if (soundfont.presets.findIndex(p => p.program === e.messageData[0] && p.bank !== 128) === -1)
                     {
-                        // doesn't exist. pick any preset that does not have the 128 bank.
+                        // doesn't exist. pick any preset that does not have bank 128.
                         e.messageData[0] = soundfont.presets.find(p => p.bank !== 128)?.program || 0;
                     }
                 }
@@ -244,7 +243,7 @@ export function writeRMIDI(
                 }
                 if (system === "xg" && channel.drums)
                 {
-                    // drums override: set bank to 127
+                    // drums override: set the bank to 127
                     channelsInfo[chNum].lastBank.messageData[1] = 127;
                 }
                 
@@ -262,7 +261,7 @@ export function writeRMIDI(
                 }
                 else
                 {
-                    // there is a preset with this bank. add offset. For drums add the normal offset.
+                    // There is a preset with this bank. Add offset. For drums add the normal offset.
                     let drumBank = system === "xg" ? 127 : 0;
                     const newBank = (bank === 128 ? drumBank : realBank) + bankOffset;
                     channel.lastBank.messageData[1] = newBank;
@@ -298,7 +297,7 @@ export function writeRMIDI(
             {
                 return;
             }
-            // find first program change (for the given channel)
+            // find the first program change (for the given channel)
             const midiChannel = ch % 16;
             const status = messageTypes.programChange | midiChannel;
             // find track with this channel being used
@@ -325,7 +324,7 @@ export function writeRMIDI(
                 }
                 const programTicks = track[programIndex].ticks;
                 const targetProgram = soundfont.getPreset(0, 0).program;
-                track.splice(programIndex, 0, new MidiMessage(
+                track.splice(programIndex, 0, new MIDIMessage(
                     programTicks,
                     messageTypes.programChange | midiChannel,
                     new IndexedByteArray([targetProgram])
@@ -342,7 +341,7 @@ export function writeRMIDI(
                 0,
                 has.program
             )?.bank + bankOffset) || bankOffset;
-            track.splice(indexToAdd, 0, new MidiMessage(
+            track.splice(indexToAdd, 0, new MIDIMessage(
                 ticks,
                 messageTypes.controllerChange | midiChannel,
                 new IndexedByteArray([midiControllers.bankSelect, targetBank])
@@ -364,9 +363,9 @@ export function writeRMIDI(
             mid.tracks[0].splice(index, 0, getGsOn(0));
         }
     }
-    const newMid = new IndexedByteArray(writeMIDIFile(mid).buffer);
+    const newMid = new IndexedByteArray(mid.writeMIDI().buffer);
     
-    // infodata for RMID
+    // info data for RMID
     /**
      * @type {Uint8Array[]}
      */