sparkforensics-server 0.5.2 → 0.6.0

package/vendor-core/finding-types.js

@@ -10,16 +10,27 @@
                                                                       
                                                           
 
-/** One concrete change a finding's fix makes, alongside its prose `recommendation`. Only a Spark
- * property the detector already names; `suggested` is null when it computes no value. Sizes carry a
- * Spark unit suffix ("384m"), counts are plain numbers, switches are booleans. */
-                              
+/** One concrete change a finding's fix makes, alongside its prose `recommendation`. Entries are
+ * applied together unless the recommendation words them as alternatives ("either ... or"), as an
+ * idle-capacity finding does with dynamic allocation off: then a consumer applies one. */
+                                                            
+
+/** A Spark property the detector already names; `suggested` is null when it computes no value.
+ * Sizes carry a Spark unit suffix ("384m"), counts are plain numbers, switches are booleans. */
+                                  
                
               
                                              
                                               
  
 
+/** A fix no Spark property makes: the job's code or data has to change. `hint` is the same
+ * wording the finding's `recommendation` gives. */
+                                  
+               
+               
+ 
+
 // The columns every finding carries, whatever its detector.
                                          
               
@@ -218,11 +229,12 @@
                                    
  
                                                                                                 
-                                                                                             
-                      
+                                                                                            
+                                                                                         
                               
                         
                      
+                          
  
 
                                             
@@ -236,11 +248,10 @@
                             
  
                                                                                                                   
-                                                                                               
-                                                                    
+                                                                                         
+                                                                                         
                             
-                              
-                         
+                                     
                          
                           
  

package/vendor-core/impact-model.js

@@ -118,8 +118,8 @@ export function tasksMostlyIdle(stage       , sql                            = n
   return cpuMs / runMs < IDLE_CPU_SHARE_MAX;
 }
 
-// skew, straggler and stageSlowness claim time off the stage's longest task itself, so the
-// occupancy clip must not floor them at that same task (see estimateSingleStage).
+// skew, straggler, stageSlowness and lowShuffleParallelism claim time off the stage's longest task
+// itself, so the occupancy clip must not floor them at that same task (see estimateSingleStage).
 export const TAIL_CLAIM                             = { shortensLongestTask: true };
 
 // No quantifiable magnitude -> 'informational'; a rawWaste figure with no stage window ->

package/vendor-core/remediation.js

@@ -1,20 +1,25 @@
 // Constructors for the structured `remediation` a detector attaches next to its prose
 // `recommendation`: only where the detector already names the Spark property, never an invented one.
-                                                      
+                                                                           
 
-                                          
+                                              
 
 /** The property should be raised; `suggested` is the value when the detector computed one. */
-export function increaseConf(key        , suggested            = null)              {
+export function increaseConf(key        , suggested            = null)                  {
   return { kind: 'conf', key, direction: 'increase', suggested };
 }
 
 /** The property should be lowered; `suggested` is the value when the detector computed one. */
-export function decreaseConf(key        , suggested            = null)              {
+export function decreaseConf(key        , suggested            = null)                  {
   return { kind: 'conf', key, direction: 'decrease', suggested };
 }
 
 /** The property should take a specific value (a switch or a class name), not move up or down. */
-export function setConf(key        , suggested            = null)              {
+export function setConf(key        , suggested            = null)                  {
   return { kind: 'conf', key, direction: 'set', suggested };
 }
+
+/** No property fixes it: the job's code or data has to change, as `hint` says. */
+export function codeFix(hint        )                  {
+  return { kind: 'code', hint };
+}

package/vendor-core/run-output.js

@@ -5,21 +5,32 @@ import { buildEffectiveConf,                    } from './effective-conf.js';
                                                          
                                            
 
+/** Which build wrote a report: the host package's name and version, and the build id of the core it
+ * loaded. Core does not know its host, so the surface passes it in. */
+                                  
+               
+                  
+                  
+ 
+
 /** The CLI report's `metrics` and `effectiveConf` blocks, shared with MCP diagnose_run. Under
  * `redact` they come from the run redacted with the report's own inputs, so host and app
- * pseudonyms match the report's. `confKeys`/`confRedactRegex` narrow and mask `effectiveConf`. */
+ * pseudonyms match the report's. `confKeys`/`confRedactRegex` narrow and mask `effectiveConf`.
+ * `generator`, when the surface supplies it, is returned as given: it holds no run identifiers. */
 export function runOutputBlocks(
   appModel          ,
-  { redact, thresholds, confKeys, confRedactRegex }   
+  { redact, thresholds, confKeys, confRedactRegex, generator }   
                                                                                                      
+                                
     = {},
-)                                                               {
+)                                                                                            {
   let blocksModel = appModel;
   if (redact) {
     const { catalog, config } = runFindings(appModel, thresholds);
     blocksModel = redactRunModel(appModel, catalog, config).appModel;
   }
   return {
+    ...(generator ? { generator } : {}),
     metrics: computeRunMetrics(blocksModel, thresholds),
     effectiveConf: buildEffectiveConf(blocksModel.app, { keys: confKeys, userPattern: confRedactRegex }),
   };

package/vendor-core/types.js

@@ -338,9 +338,19 @@
                                                                                                  
                                                                                                
                                                                                    
-                                                                                                                                  
-                                                                     
+                                                                                                  
+                                                                                             
+                                                                                                 
+                                                                                                  
+                        
                                                     
+                                                                                                 
+                                                                                                  
+                                                                                                
+                                                                                                    
+                                                                                                  
+                                                                                        
+                                                 
  
 
 // `Finding` is a union discriminated on `type`, one member per emitted finding type: see

package/vendor-core/wall-clock.js

@@ -1,5 +1,13 @@
 import { mergeIntervals } from './intervals.js';
 
+/** The union of the stages' [submittedAt, completedAt) windows, sorted: where stages were active. */
+export function stageWindows(stages                                                           )                          {
+  const intervals = [...stages.values()]
+    .filter((s) => s.submittedAt != null && s.completedAt != null)
+    .map((s)                   => [s.submittedAt          , s.completedAt          ]);
+  return mergeIntervals(intervals);
+}
+
 export function computeWallClock(app                                                             , stages                                                           )                                                                                     {
   const start = app?.startTime ?? 0;
   const stageList = [...stages.values()].filter(s => s.submittedAt != null && s.completedAt != null);

package/vendor-core/wasted-core-hours.js

@@ -1,7 +1,8 @@
 // Wasted core-hours summary. Pure, worker-agnostic reducer over the same inputs
-// the memoryUtilization detector's idle-cores math uses: capacity core-time vs.
+// the memoryUtilization detector's idle-cores math uses: allocated core-time vs.
 // core-time that actually ran tasks. Feeds a report widget only, no detector.
 
+import { allocatedCoreMs } from './allocation.js';
 import { computePeakConcurrentCores } from './core-count.js';
 import { MS_PER_CORE_HOUR } from './format-utils.js';
 
@@ -32,9 +33,9 @@ const EMPTY                        = {
 // SparkAppInfo | null before parsing completes), which the guard below already
 // tolerates. `resources` is on app's shape so the computePeakConcurrentCores
 // pass-through type-checks; real app objects always carry it. An omitted
-// `executorsRemoved` means no executor left, where peak cores equal the sum.
+// `executorsRemoved` means no executor left.
 export function computeWastedCoreHours(
-  app                                                                                                       ,
+  app                                                                                                                                        ,
   executorsAdded                                                                                    = [],
   runAggregates                      ,
   executorsRemoved                                                   = [],
@@ -44,17 +45,17 @@ export function computeWastedCoreHours(
   const appDurationMs = app.endTime - app.startTime;
   if (appDurationMs <= 0) return EMPTY;
 
-  // Total cores: peak concurrent Executor-Added Total Cores, else peak executors ×
-  // configured cores. Same capacity as the memoryUtilization detector, so an
-  // executor replaced mid-run is not counted twice.
+  // Capacity is the run's allocation (cores x time alive), the same as the idle findings. The
+  // application end is set here, so the allocation never needs the stages to find where a log stops.
+  const allocatedMs = allocatedCoreMs({ app, stages: new Map(), executors: { added: executorsAdded, removed: executorsRemoved } });
+  if (allocatedMs == null) return EMPTY;
+  // Peak concurrent cores, reported as the cluster size: an executor replaced mid-run counts once.
   const totalCores = computePeakConcurrentCores(app, executorsAdded, executorsRemoved);
-  if (totalCores <= 0) return EMPTY;
 
-  const totalCoreHours = (totalCores * appDurationMs) / MS_PER_CORE_HOUR;
+  const totalCoreHours = allocatedMs / MS_PER_CORE_HOUR;
   const usefulCoreHours = (runAggregates.busyCoreMs ?? 0) / MS_PER_CORE_HOUR;
-  // Clamp: totalCores can be a fallback estimate while busyCoreMs is measured
-  // from task events, so the difference can dip below zero (same guard as
-  // src/efficiency-model.js).
+  // Clamp: busyCoreMs is measured from task events while the allocation comes from executor
+  // events, so the difference can dip below zero (same guard as efficiency-model.ts).
   const wastedCoreHours = Math.max(0, totalCoreHours - usefulCoreHours);
 
   const topStages = Object.entries(runAggregates.perStage ?? {})

package/vendor-core/write-targets.js

@@ -17,6 +17,15 @@ import { indexByRoot, isStagedDeltaWrite, parseDeltaTableV2, resolveDeltaCommand
 import { IDENT_PARTS, isCut, splitArgs, tableName,          } from './write-target-args.js';
                                                          
 
+/** The row counts a MergeIntoCommand node reports in its SQL metrics. */
+                            
+                          
+                         
+                         
+                                                                                                 
+                        
+ 
+
                               
                          
                                                                                     
@@ -35,6 +44,10 @@ import { IDENT_PARTS, isCut, splitArgs, tableName,          } from './write-targ
                         
                                                                                           
                             
+                                                                                           
+                                                                                                  
+                                                    
+                              
                                                                              
               
  
@@ -234,6 +247,24 @@ function outputRowsOf(node          )                {
   return metric !== undefined && Number.isFinite(metric.value) ? metric.value : null;
 }
 
+// A name in `names` is read when the log has it. 'number of rows copied' is the label older Delta
+// releases give the rewritten-unmodified counter.
+function metricValue(node          , ...names          )                {
+  const metric = node.metrics?.find((m) => names.includes(m.name));
+  return metric !== undefined && Number.isFinite(metric.value) ? metric.value : null;
+}
+
+function mergeRowsOf(command        , node          )                   {
+  if (command !== 'MergeIntoCommand') return null;
+  const rows = {
+    inserted: metricValue(node, 'number of inserted rows'),
+    updated: metricValue(node, 'number of updated rows'),
+    deleted: metricValue(node, 'number of deleted rows'),
+    copied: metricValue(node, 'number of target rows rewritten unmodified', 'number of rows copied'),
+  };
+  return Object.values(rows).every((v) => v === null) ? null : rows;
+}
+
 function collectWrites(exec              , root          , byRoot                  , out               )       {
   walkPlanTree(root, (node) => {
     const command = commandOf(node.name);
@@ -250,6 +281,7 @@ function collectWrites(exec              , root          , byRoot
       kind: parsed?.kind ?? null,
       target: parsed?.target ?? null,
       outputRows: outputRowsOf(node),
+      mergeRows: mergeRowsOf(command, node),
       raw: detail !== '' ? detail : node.name,
     });
   }, { dedupe: true });

package/public/assets/AutoscalingChurn-8t3U3isq.js

@@ -1 +0,0 @@
-import{r as e}from"./rolldown-runtime-hePW80VL.js";import{M as t,T as n,f as r,l as i,o as a,s as o,t as s,v as c,w as l}from"./charts-vendor-0VMaLVLN.js";import{S as u,d,u as f}from"./DisclosureContext-ZpE6CkHx.js";import{p}from"./plan-graph-vendor-BYl-AzN5.js";import{d as m,m as h}from"./useRecentFiles-XZEnLlal.js";import{k as g}from"./index-B-03mG7K.js";import{c as _,o as v,t as y}from"./Dashboard-C1hNeX49.js";var b=e(t(),1),x=p(),S=60,C=6e4,w=220;function T(e,t,n,r,i){if(e.length===0&&t.length===0)return[];let a=Math.max(i,r-n),o=Math.max(1,Math.ceil(a/i)),s=[];for(let e=0;e<o;e++)s.push({tStart:n+e*i,adds:0,removes:0});let c=e=>Math.min(o-1,Math.max(0,Math.floor((e-n)/i)));for(let t of e)s[c(t.timestamp)].adds++;for(let e of t)s[c(e.timestamp)].removes++;return s}function E(e,t){let n=Math.max(1,t-e);return Math.max(C,Math.ceil(n/S))}function D(e){if(e<=0)return 1;let t=10**Math.floor(Math.log10(e)),n=e/t;return(n<=1?1:n<=2?2:n<=5?5:10)*t}function O(e){let t=D(e.reduce((e,t)=>Math.max(e,Math.abs(t.added),Math.abs(t.removed)),0));return{domain:[-t,t],ticks:[-t,-t/2,0,t/2,t]}}function k(e){return Math.abs(e.height)<1?null:(0,x.jsx)(l,{...e})}function A({finding:e}){return(0,x.jsxs)(`div`,{className:`flex flex-col gap-1 transition-colors`,children:[(0,x.jsxs)(`p`,{className:`text-xs text-muted-foreground`,children:[`Short-lived executors: `,(0,x.jsxs)(`strong`,{children:[e.value,`%`]})]}),(0,x.jsx)(y,{finding:e}),(0,x.jsxs)(`p`,{className:`flex flex-wrap items-start gap-2 text-sm`,children:[(0,x.jsx)(f,{impactBand:e.impactBand,className:`mt-1.5`}),(0,x.jsx)(`span`,{children:(0,x.jsx)(u,{anchor:`#config-autoscale-bounds`,children:`Tuning executorIdleTimeout and the min/max bounds`})})]})]})}var j=(0,b.memo)(function({appModel:e,activeFileId:t,catalog:l=[],defaultCollapsed:u=!0}){let f=(0,b.useMemo)(()=>{let t=e.executors.added,n=e.executors.removed;if(t.length===0&&n.length===0)return{hasEvents:!1,added:t,removed:n};let r=e.app,i=r?.startTime??0,a=r?.endTime??i,o=E(i,a),s=_(T(t,n,i,a,o)).map(e=>({t:`${Math.round((e.tStart-i)/1e3)}s`,added:e.adds,removed:-e.removes}));return{hasEvents:!0,added:t,removed:n,rows:s,yAxisScale:O(s)}},[e,t]);if(!f.hasEvents)return(0,x.jsx)(g,{title:`Autoscaling Churn`,summary:(0,x.jsx)(`span`,{className:`text-muted-foreground text-xs`,children:`No executor add/remove events (static allocation).`}),children:(0,x.jsx)(`p`,{className:`text-muted-foreground text-xs`,children:`No executor add/remove events (static allocation).`})});let{added:p,removed:y,rows:S,yAxisScale:C}=f,D=l.find(e=>e.type===`autoscalingChurn`);return(0,x.jsx)(g,{title:`Autoscaling Churn`,impactBand:D?.impactBand,fixFor:D?[D]:[],badges:D&&(0,x.jsx)(d,{type:`autoscalingChurn`,impactBand:D.impactBand}),defaultCollapsed:u,summary:(0,x.jsx)(v,{value:`${p.length} added / ${y.length} removed`,context:D?`${D.value}% short-lived executors, ${D.impactBand}`:`executor churn events`}),children:(0,x.jsxs)(`div`,{className:`space-y-2`,children:[D&&(0,x.jsx)(A,{finding:D}),(0,x.jsx)(`p`,{className:`text-muted-foreground text-xs`,children:`executors added / removed over time`}),(0,x.jsx)(h,{ariaLabel:`Executor added and removed counts per time bucket over the run.`,height:w,table:{caption:`Executor added/removed counts by time bucket`,columns:[`Time`,`Executors added`,`Executors removed`],rows:S.map(e=>[e.t,e.added,Math.abs(e.removed)]),align:[`right`,`right`,`right`]},children:(0,x.jsxs)(s,{data:S,children:[(0,x.jsx)(r,{stroke:m.muted,strokeOpacity:.2}),(0,x.jsx)(o,{dataKey:`t`,tick:{fontSize:10}}),(0,x.jsx)(a,{tick:{fontSize:10},width:32,domain:C.domain,ticks:C.ticks}),(0,x.jsx)(c,{formatter:(e,t)=>[Math.abs(Number(e)),t]}),(0,x.jsx)(n,{wrapperStyle:{fontSize:10}}),(0,x.jsx)(i,{dataKey:`added`,name:`Added`,stackId:`churn`,fill:m.clean,shape:k}),(0,x.jsx)(i,{dataKey:`removed`,name:`Removed`,stackId:`churn`,fill:m.muted,shape:k})]})})]})})});export{j as AutoscalingChurn};

package/public/assets/CacheUtilization-CJs9tTum.js

@@ -1 +0,0 @@
-import{r as e}from"./rolldown-runtime-hePW80VL.js";import{M as t}from"./charts-vendor-0VMaLVLN.js";import{$ as n,S as r,U as i,Y as a,at as o,d as s,it as c,u as l,ut as u}from"./DisclosureContext-ZpE6CkHx.js";import{p as d}from"./plan-graph-vendor-BYl-AzN5.js";import{c as f}from"./useRecentFiles-XZEnLlal.js";import{H as p,P as m,R as h,U as g,V as _,W as v,k as y,z as b}from"./index-B-03mG7K.js";import{o as x,r as S,t as C}from"./Dashboard-C1hNeX49.js";import{n as w}from"./finding-anchor-Cl6_5hfV.js";import{t as T}from"./usePagedRows-Dyl6T8Ok.js";var E=e(t(),1),D=d(),O=70;function k(e){if(!e)return`—`;let t=[];return e.useMemory&&t.push(`Memory`),e.useDisk&&t.push(`Disk`),e.deserialized?t.push(`Deserialized`):(e.useMemory||e.useDisk)&&t.push(`Serialized`),(e.replication??1)>1&&t.push(`x${e.replication}`),t.join(` · `)||`—`}function A(e){return e.name||`RDD ${e.id}`}function j(e){let t=o(A(e));return t.length<=O?t:`${t.slice(0,O)}…`}function M(e){if(e.variant===`storageUnobserved`)return`No block updates logged: cached partition counts and sizes are unknown`;let t=n(`pct`,c(e));return e.variant===`diskSpillover`?`${t} spilled to disk: ${a(e.diskSize??0)} disk / ${a(e.memorySize??0)} memory`:`${t} cached (${e.numCachedPartitions??0}/${e.numPartitions??0} partitions)`}function N({finding:e}){let t=w([e]),n=e.dataUnavailable?`Cache storage not logged`:e.rddName??`RDD ${e.rddId}`;return(0,D.jsxs)(`div`,{ref:t.ref,tabIndex:t.tabIndex,"data-flashed":t.dataFlashed,className:`space-y-1 transition-colors ${t.flashClassName}`,children:[(0,D.jsxs)(`p`,{className:`flex flex-wrap items-start gap-2`,children:[(0,D.jsx)(l,{impactBand:e.impactBand,className:`mt-1.5`}),(0,D.jsx)(`span`,{children:n})]}),(0,D.jsx)(`p`,{className:`text-xs text-muted-foreground`,children:e.dataUnavailable?e.recommendation:M(e)}),(0,D.jsx)(C,{finding:e})]})}var P=(0,E.memo)(function({appModel:e,catalog:t}){let[n,o]=(0,E.useState)(0),[d,C]=(0,E.useState)(0),w=e.app?.rddInfo,O=(0,E.useMemo)(()=>w?[...w.values()].filter(e=>(e.storageLevel?.useMemory||e.storageLevel?.useDisk)&&(e.numCachedPartitions??0)>0).sort((e,t)=>(t.memorySize??0)+(t.diskSize??0)-((e.memorySize??0)+(e.diskSize??0))):[],[w]),M=(0,E.useMemo)(()=>f(t,`cacheUtilization`).sort((e,t)=>i[e.impactBand]-i[t.impactBand]),[t]),P=T(O,n,o),F=m(),I=F?M.findIndex(e=>e===F.finding):null,L=T(M,d,C,I),R=M.find(e=>e.dataUnavailable);if(O.length===0&&!R)return null;let z=e=>M.filter(t=>t.rddId===e),B=O.reduce((e,t)=>e+(t.memorySize??0)+(t.diskSize??0),0);return(0,D.jsx)(`div`,{"data-widget":`cache-utilization`,children:(0,D.jsxs)(y,{title:`Cache Storage`,fixFor:M,impactBand:u(M),badges:(0,D.jsxs)(D.Fragment,{children:[M.length>0?(0,D.jsx)(s,{type:`cacheUtilization`,impactBand:u(M)??`info`}):null,(0,D.jsxs)(`span`,{className:`text-xs text-muted-foreground`,children:[O.length>0?`${O.length} cached RDD${O.length===1?``:`s`}`:`cache storage not logged`,`, see`,` `,(0,D.jsx)(r,{anchor:`#memory-model`,children:`how Spark accounts cached memory`})]})]}),defaultCollapsed:!0,summary:O.length>0?(0,D.jsx)(x,{value:a(B),context:`cached across memory + disk`}):(0,D.jsx)(x,{value:`Unknown`,context:`${c(R)} persisted, no block updates`}),children:[O.length>0?(0,D.jsxs)(D.Fragment,{children:[(0,D.jsxs)(h,{children:[(0,D.jsx)(g,{children:(0,D.jsxs)(v,{children:[(0,D.jsx)(p,{children:`RDD`}),(0,D.jsx)(p,{children:`Storage level`}),(0,D.jsx)(p,{className:`text-right`,children:`Cached partitions`}),(0,D.jsx)(p,{className:`text-right`,children:`Memory`}),(0,D.jsx)(p,{className:`text-right`,children:`Disk`})]})}),(0,D.jsx)(b,{children:P.visible.map(e=>{let t=A(e),n=j(e),r=z(e.id);return(0,D.jsxs)(v,{children:[(0,D.jsxs)(_,{className:`max-w-80 truncate`,title:t===n?void 0:t,children:[n,r.length>0&&(0,D.jsx)(l,{impactBand:u(r)??`info`,className:`ml-1.5`})]}),(0,D.jsx)(_,{children:k(e.storageLevel)}),(0,D.jsxs)(_,{className:`text-right`,children:[e.numCachedPartitions,` / `,e.numPartitions]}),(0,D.jsx)(_,{className:`text-right`,children:a(e.memorySize??0)}),(0,D.jsx)(_,{className:`text-right`,children:a(e.diskSize??0)})]},e.id)})})]}),(0,D.jsx)(S,{page:P.effectivePage,totalPages:P.totalPages,onPrev:()=>o(e=>e-1),onNext:()=>o(e=>e+1)})]}):null,M.length>0?(0,D.jsxs)(`div`,{className:`mt-3 space-y-2 text-sm`,children:[L.visible.map(e=>(0,D.jsx)(N,{finding:e},e.id)),(0,D.jsx)(S,{page:L.effectivePage,totalPages:L.totalPages,onPrev:()=>C(e=>e-1),onNext:()=>C(e=>e+1)})]}):null]})})});export{P as CacheUtilization};

package/public/assets/ConfigAudit-B5Gbe5js.js

@@ -1 +0,0 @@
-import{r as e}from"./rolldown-runtime-hePW80VL.js";import{M as t}from"./charts-vendor-0VMaLVLN.js";import{S as n,U as r,d as i,j as a,p as o,u as s,ut as c}from"./DisclosureContext-ZpE6CkHx.js";import{p as l}from"./plan-graph-vendor-BYl-AzN5.js";import{c as u,l as d}from"./useRecentFiles-XZEnLlal.js";import{P as f,k as p,l as m}from"./index-B-03mG7K.js";import{o as h,r as g,t as _}from"./Dashboard-C1hNeX49.js";import{n as v}from"./finding-anchor-Cl6_5hfV.js";import{t as y}from"./usePagedRows-Dyl6T8Ok.js";var b=e(t(),1),x=l();function S({finding:e}){let t=v([e]);return(0,x.jsxs)(`li`,{ref:t.ref,tabIndex:t.tabIndex,"data-flashed":t.dataFlashed,className:`space-y-1 transition-colors ${t.flashClassName}`,children:[(0,x.jsxs)(`div`,{className:`flex items-center gap-2`,children:[(0,x.jsx)(s,{impactBand:e.impactBand}),(0,x.jsx)(`code`,{className:`text-xs`,children:e.property}),(0,x.jsx)(`span`,{className:`text-xs text-muted-foreground`,children:`=`}),(0,x.jsx)(`code`,{className:`rounded bg-accent/10 px-1.5 py-0.5 font-mono text-xs text-accent`,children:e.valueText})]}),(0,x.jsx)(_,{finding:e}),(0,x.jsxs)(`p`,{className:`text-sm`,children:[m(e.recommendation??``).measured??e.recommendation,e.docAnchor?(0,x.jsxs)(x.Fragment,{children:[` `,(0,x.jsxs)(n,{anchor:e.docAnchor,children:[`Why `,e.property,` matters`]})]}):null]})]})}var C=(0,b.memo)(function({appModel:e,configFindings:t,defaultCollapsed:n=!0}){let[s,l]=(0,b.useState)(0),m=(0,b.useMemo)(()=>u(t??[],`configAudit`).sort((e,t)=>r[e.impactBand]-r[t.impactBand]),[t]),_=f(),v=_?m.findIndex(e=>e===_.finding):null,{totalPages:C,effectivePage:w,visible:T}=y(m,s,l,v);if(m.length===0){let t=e.evidenceAvailability?.entries.find(e=>e.key===`sparkConfiguration`),n;if(t)n=t.state===`present`?`No misconfigurations detected.`:t.state===`unknown`&&t.reasonCode===`parseIncomplete`?(0,x.jsxs)(x.Fragment,{children:[(0,x.jsxs)(`span`,{children:[t.summary,` `]}),(0,x.jsx)(o,{children:(0,x.jsx)(d,{evidenceKey:`sparkConfiguration`})})]}):(0,x.jsxs)(x.Fragment,{children:[(0,x.jsx)(`span`,{children:`No environment info captured in this log. `}),(0,x.jsx)(o,{children:(0,x.jsx)(d,{evidenceKey:`sparkConfiguration`})})]});else{let t=e.app?.evidenceInputs;n=(t?t.environmentUpdates>0:Object.keys(e.app?.config??{}).length>0||e.app?.resources)?`No misconfigurations detected.`:(0,x.jsxs)(x.Fragment,{children:[(0,x.jsx)(`span`,{children:`No environment info captured in this log. `}),(0,x.jsx)(o,{children:(0,x.jsx)(d,{evidenceKey:`sparkConfiguration`})})]})}let r=(0,x.jsx)(`p`,{className:`text-muted-foreground text-xs`,children:n});return(0,x.jsx)(p,{title:`Config Audit`,compact:!0,summary:r,children:r})}let E=c(m);return(0,x.jsxs)(p,{title:`Config Audit`,fixFor:m,impactBand:E,badges:(0,x.jsx)(i,{type:`configAudit`,impactBand:E??`info`,docAnchor:a(m)}),statusBadge:(0,x.jsx)(o,{children:(0,x.jsx)(d,{evidenceKey:`sparkConfiguration`})}),defaultCollapsed:n,summary:(0,x.jsx)(h,{value:`${m.length}`,context:`misconfiguration${m.length===1?``:`s`} flagged`}),children:[(0,x.jsx)(`ul`,{className:`space-y-4`,children:T.map(e=>(0,x.jsx)(S,{finding:e},e.id))}),(0,x.jsx)(g,{page:w,totalPages:C,onPrev:()=>l(e=>e-1),onNext:()=>l(e=>e+1)})]})});export{C as ConfigAudit};