sourceverity 1.0.0

package/dist/rules/browser/timerCleanup.js

@@ -0,0 +1,115 @@
+import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
+export const timerCleanupRule = {
+    meta: {
+        id: "browser/timer-cleanup",
+        category: "browser",
+        defaultSeverity: "error",
+        defaultConfidence: "high",
+        description: "Detects timers registered in lifecycle hooks without corresponding cleanup.",
+        requiresTypeInformation: false,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!ts)
+            return;
+        context.visitNodes((node) => {
+            if (!ts.isCallExpression(node))
+                return;
+            let isLifecycleHook = false;
+            if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
+                isLifecycleHook = true;
+            }
+            else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
+                isLifecycleHook = true;
+            }
+            if (!isLifecycleHook)
+                return;
+            const effectCallback = node.arguments[0];
+            if (!effectCallback || (!ts.isArrowFunction(effectCallback) && !ts.isFunctionExpression(effectCallback))) {
+                return;
+            }
+            const timers = [];
+            const cleanups = new Set();
+            let hasCleanupReturn = false;
+            function inspectEffectBody(n) {
+                // Look for: const id = setInterval(...) or setInterval(...)
+                if (ts && ts.isCallExpression(n) && ts.isIdentifier(n.expression)) {
+                    const fnName = n.expression.text;
+                    if (fnName === "setInterval" || fnName === "setTimeout") {
+                        let varName;
+                        if (n.parent && ts.isVariableDeclaration(n.parent) && ts.isIdentifier(n.parent.name)) {
+                            varName = n.parent.name.text;
+                        }
+                        timers.push({
+                            node: n,
+                            timerKind: fnName,
+                            varName,
+                        });
+                    }
+                }
+                // Check for return statement
+                if (ts && ts.isReturnStatement(n) && n.expression) {
+                    const retExpr = n.expression;
+                    if (ts.isArrowFunction(retExpr) || ts.isFunctionExpression(retExpr)) {
+                        hasCleanupReturn = true;
+                        inspectCleanupBody(retExpr);
+                    }
+                }
+                if (ts && n !== effectCallback && (ts.isFunctionDeclaration(n) || ts.isArrowFunction(n) || ts.isFunctionExpression(n))) {
+                    return;
+                }
+                n.forEachChild(inspectEffectBody);
+            }
+            function inspectCleanupBody(cleanupFn) {
+                function walkCleanup(cn) {
+                    if (ts && ts.isCallExpression(cn) && ts.isIdentifier(cn.expression)) {
+                        const fnName = cn.expression.text;
+                        if (fnName === "clearInterval" || fnName === "clearTimeout") {
+                            cleanups.add(fnName);
+                            const arg = cn.arguments[0];
+                            if (arg && ts.isIdentifier(arg)) {
+                                cleanups.add(arg.text);
+                            }
+                        }
+                    }
+                    cn.forEachChild(walkCleanup);
+                }
+                cleanupFn.forEachChild(walkCleanup);
+            }
+            inspectEffectBody(effectCallback.body);
+            for (const timer of timers) {
+                let isCleaned = false;
+                if (hasCleanupReturn) {
+                    const expectedClear = timer.timerKind === "setInterval" ? "clearInterval" : "clearTimeout";
+                    if (cleanups.has(expectedClear)) {
+                        if (!timer.varName || cleanups.has(timer.varName)) {
+                            isCleaned = true;
+                        }
+                    }
+                }
+                if (!isCleaned) {
+                    const range = getNodeSourceRange(timer.node, sourceFile);
+                    const isInterval = timer.timerKind === "setInterval";
+                    context.report({
+                        ruleId: "browser/timer-cleanup",
+                        category: "browser",
+                        severity: isInterval ? "error" : "warning",
+                        confidence: isInterval ? "high" : "medium",
+                        message: `${timer.timerKind} registered in lifecycle hook is missing matching ${isInterval ? "clearInterval" : "clearTimeout"} cleanup.`,
+                        file: sourceFile.fileName,
+                        range,
+                        evidence: [
+                            {
+                                message: `Active ${timer.timerKind} timers that outlive the component lifecycle cause state leaks and background CPU consumption.`,
+                                range,
+                            },
+                        ],
+                        suggestedAction: `Clear the timer in the returned cleanup function: return () => ${isInterval ? "clearInterval" : "clearTimeout"}(id);`,
+                        safeAutomaticFix: false,
+                    });
+                }
+            }
+        });
+    },
+};
+//# sourceMappingURL=timerCleanup.js.map

package/dist/rules/browser/timerCleanup.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"timerCleanup.js","sourceRoot":"","sources":["../../../src/rules/browser/timerCleanup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAG/E,MAAM,CAAC,MAAM,gBAAgB,GAAS;IACpC,IAAI,EAAE;QACJ,EAAE,EAAE,uBAAuB;QAC3B,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,6EAA6E;QAC1F,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,eAAe,GAAG,KAAK,CAAC;YAC5B,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;YAED,IAAI,CAAC,eAAe;gBAAE,OAAO;YAE7B,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACzC,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC;gBACzG,OAAO;YACT,CAAC;YAED,MAAM,MAAM,GAIP,EAAE,CAAC;YAER,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;YACnC,IAAI,gBAAgB,GAAG,KAAK,CAAC;YAE7B,SAAS,iBAAiB,CAAC,CAAc;gBACvC,4DAA4D;gBAC5D,IAAI,EAAE,IAAI,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC;oBAClE,MAAM,MAAM,GAAG,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC;oBACjC,IAAI,MAAM,KAAK,aAAa,IAAI,MAAM,KAAK,YAAY,EAAE,CAAC;wBACxD,IAAI,OAA2B,CAAC;wBAChC,IAAI,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;4BACrF,OAAO,GAAG,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC;wBAC/B,CAAC;wBACD,MAAM,CAAC,IAAI,CAAC;4BACV,IAAI,EAAE,CAAC;4BACP,SAAS,EAAE,MAAM;4BACjB,OAAO;yBACR,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBAED,6BAA6B;gBAC7B,IAAI,EAAE,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;oBAClD,MAAM,OAAO,GAAG,CAAC,CAAC,UAAU,CAAC;oBAC7B,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;wBACpE,gBAAgB,GAAG,IAAI,CAAC;wBACxB,kBAAkB,CAAC,OAAO,CAAC,CAAC;oBAC9B,CAAC;gBACH,CAAC;gBAED,IAAI,EAAE,IAAI,CAAC,KAAK,cAAc,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACvH,OAAO;gBACT,CAAC;gBAED,CAAC,CAAC,YAAY,CAAC,iBAAiB,CAAC,CAAC;YACpC,CAAC;YAED,SAAS,kBAAkB,CAAC,SAAsB;gBAChD,SAAS,WAAW,CAAC,EAAe;oBAClC,IAAI,EAAE,IAAI,EAAE,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,EAAE,CAAC,UAAU,CAAC,EAAE,CAAC;wBACpE,MAAM,MAAM,GAAG,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC;wBAClC,IAAI,MAAM,KAAK,eAAe,IAAI,MAAM,KAAK,cAAc,EAAE,CAAC;4BAC5D,QAAQ,CAAC,GAAG,CAAC,MAAM,CAAC,CAAC;4BACrB,MAAM,GAAG,GAAG,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;4BAC5B,IAAI,GAAG,IAAI,EAAE,CAAC,YAAY,CAAC,GAAG,CAAC,EAAE,CAAC;gCAChC,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;4BACzB,CAAC;wBACH,CAAC;oBACH,CAAC;oBACD,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;gBAC/B,CAAC;gBACD,SAAS,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;YACtC,CAAC;YAED,iBAAiB,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;YAEvC,KAAK,MAAM,KAAK,IAAI,MAAM,EAAE,CAAC;gBAC3B,IAAI,SAAS,GAAG,KAAK,CAAC;gBACtB,IAAI,gBAAgB,EAAE,CAAC;oBACrB,MAAM,aAAa,GAAG,KAAK,CAAC,SAAS,KAAK,aAAa,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,cAAc,CAAC;oBAC3F,IAAI,QAAQ,CAAC,GAAG,CAAC,aAAa,CAAC,EAAE,CAAC;wBAChC,IAAI,CAAC,KAAK,CAAC,OAAO,IAAI,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC;4BAClD,SAAS,GAAG,IAAI,CAAC;wBACnB,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,IAAI,CAAC,SAAS,EAAE,CAAC;oBACf,MAAM,KAAK,GAAG,kBAAkB,CAAC,KAAK,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBACzD,MAAM,UAAU,GAAG,KAAK,CAAC,SAAS,KAAK,aAAa,CAAC;oBAErD,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,uBAAuB;wBAC/B,QAAQ,EAAE,SAAS;wBACnB,QAAQ,EAAE,UAAU,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,SAAS;wBAC1C,UAAU,EAAE,UAAU,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,QAAQ;wBAC1C,OAAO,EAAE,GAAG,KAAK,CAAC,SAAS,qDAAqD,UAAU,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,cAAc,WAAW;wBACxI,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,UAAU,KAAK,CAAC,SAAS,gGAAgG;gCAClI,KAAK;6BACN;yBACF;wBACD,eAAe,EAAE,kEAAkE,UAAU,CAAC,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,cAAc,OAAO;wBACvI,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/index.d.ts

@@ -0,0 +1,19 @@
+import { asyncForeachRule } from "./async/asyncForeach.js";
+import { floatingPromiseRule } from "./async/floatingPromise.js";
+import { unsafeUnvalidatedAssertionRule } from "./typescript/unsafeUnvalidatedAssertion.js";
+import { nonNullAssertionRiskRule } from "./typescript/nonNullAssertionRisk.js";
+import { uncheckedIndexAccessRule } from "./typescript/uncheckedIndexAccess.js";
+import { fetchStatusUncheckedRule } from "./network/fetchStatusUnchecked.js";
+import { eventListenerCleanupRule } from "./browser/eventListenerCleanup.js";
+import { timerCleanupRule } from "./browser/timerCleanup.js";
+import { observerCleanupRule } from "./browser/observerCleanup.js";
+import { asyncEffectCallbackRule } from "./react/asyncEffectCallback.js";
+import { derivedStateEffectRule } from "./react/derivedStateEffect.js";
+import { missingEffectCleanupRule } from "./react/missingEffectCleanup.js";
+export declare const BUILTIN_RULES: readonly [import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule, import("../index.js").Rule];
+/**
+ * Registers all 12 built-in production rules into the global registry.
+ */
+export declare function registerBuiltinRules(): void;
+export { asyncForeachRule, floatingPromiseRule, unsafeUnvalidatedAssertionRule, nonNullAssertionRiskRule, uncheckedIndexAccessRule, fetchStatusUncheckedRule, eventListenerCleanupRule, timerCleanupRule, observerCleanupRule, asyncEffectCallbackRule, derivedStateEffectRule, missingEffectCleanupRule, };
+//# sourceMappingURL=index.d.ts.map

package/dist/rules/index.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/rules/index.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,8BAA8B,EAAE,MAAM,4CAA4C,CAAC;AAC5F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAChF,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAChF,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAC;AAC7E,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAC;AAC7E,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAC;AAC7D,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,EAAE,uBAAuB,EAAE,MAAM,gCAAgC,CAAC;AACzE,OAAO,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AACvE,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAE3E,eAAO,MAAM,aAAa,2VAahB,CAAC;AAEX;;GAEG;AACH,wBAAgB,oBAAoB,IAAI,IAAI,CAM3C;AAKD,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EACnB,8BAA8B,EAC9B,wBAAwB,EACxB,wBAAwB,EACxB,wBAAwB,EACxB,wBAAwB,EACxB,gBAAgB,EAChB,mBAAmB,EACnB,uBAAuB,EACvB,sBAAsB,EACtB,wBAAwB,GACzB,CAAC"}

package/dist/rules/index.js

@@ -0,0 +1,41 @@
+import { globalRuleRegistry } from "../engine/registry.js";
+import { asyncForeachRule } from "./async/asyncForeach.js";
+import { floatingPromiseRule } from "./async/floatingPromise.js";
+import { unsafeUnvalidatedAssertionRule } from "./typescript/unsafeUnvalidatedAssertion.js";
+import { nonNullAssertionRiskRule } from "./typescript/nonNullAssertionRisk.js";
+import { uncheckedIndexAccessRule } from "./typescript/uncheckedIndexAccess.js";
+import { fetchStatusUncheckedRule } from "./network/fetchStatusUnchecked.js";
+import { eventListenerCleanupRule } from "./browser/eventListenerCleanup.js";
+import { timerCleanupRule } from "./browser/timerCleanup.js";
+import { observerCleanupRule } from "./browser/observerCleanup.js";
+import { asyncEffectCallbackRule } from "./react/asyncEffectCallback.js";
+import { derivedStateEffectRule } from "./react/derivedStateEffect.js";
+import { missingEffectCleanupRule } from "./react/missingEffectCleanup.js";
+export const BUILTIN_RULES = [
+    asyncForeachRule,
+    floatingPromiseRule,
+    unsafeUnvalidatedAssertionRule,
+    nonNullAssertionRiskRule,
+    uncheckedIndexAccessRule,
+    fetchStatusUncheckedRule,
+    eventListenerCleanupRule,
+    timerCleanupRule,
+    observerCleanupRule,
+    asyncEffectCallbackRule,
+    derivedStateEffectRule,
+    missingEffectCleanupRule,
+];
+/**
+ * Registers all 12 built-in production rules into the global registry.
+ */
+export function registerBuiltinRules() {
+    for (const rule of BUILTIN_RULES) {
+        if (!globalRuleRegistry.get(rule.meta.id)) {
+            globalRuleRegistry.register(rule);
+        }
+    }
+}
+// Auto-register built-ins on module load
+registerBuiltinRules();
+export { asyncForeachRule, floatingPromiseRule, unsafeUnvalidatedAssertionRule, nonNullAssertionRiskRule, uncheckedIndexAccessRule, fetchStatusUncheckedRule, eventListenerCleanupRule, timerCleanupRule, observerCleanupRule, asyncEffectCallbackRule, derivedStateEffectRule, missingEffectCleanupRule, };
+//# sourceMappingURL=index.js.map

package/dist/rules/index.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/rules/index.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,kBAAkB,EAAE,MAAM,uBAAuB,CAAC;AAC3D,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC3D,OAAO,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACjE,OAAO,EAAE,8BAA8B,EAAE,MAAM,4CAA4C,CAAC;AAC5F,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAChF,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAChF,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAC;AAC7E,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAC;AAC7E,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAC;AAC7D,OAAO,EAAE,mBAAmB,EAAE,MAAM,8BAA8B,CAAC;AACnE,OAAO,EAAE,uBAAuB,EAAE,MAAM,gCAAgC,CAAC;AACzE,OAAO,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AACvE,OAAO,EAAE,wBAAwB,EAAE,MAAM,iCAAiC,CAAC;AAE3E,MAAM,CAAC,MAAM,aAAa,GAAG;IAC3B,gBAAgB;IAChB,mBAAmB;IACnB,8BAA8B;IAC9B,wBAAwB;IACxB,wBAAwB;IACxB,wBAAwB;IACxB,wBAAwB;IACxB,gBAAgB;IAChB,mBAAmB;IACnB,uBAAuB;IACvB,sBAAsB;IACtB,wBAAwB;CAChB,CAAC;AAEX;;GAEG;AACH,MAAM,UAAU,oBAAoB;IAClC,KAAK,MAAM,IAAI,IAAI,aAAa,EAAE,CAAC;QACjC,IAAI,CAAC,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC;YAC1C,kBAAkB,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;QACpC,CAAC;IACH,CAAC;AACH,CAAC;AAED,yCAAyC;AACzC,oBAAoB,EAAE,CAAC;AAEvB,OAAO,EACL,gBAAgB,EAChB,mBAAmB,EACnB,8BAA8B,EAC9B,wBAAwB,EACxB,wBAAwB,EACxB,wBAAwB,EACxB,wBAAwB,EACxB,gBAAgB,EAChB,mBAAmB,EACnB,uBAAuB,EACvB,sBAAsB,EACtB,wBAAwB,GACzB,CAAC"}

package/dist/rules/network/fetchStatusUnchecked.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const fetchStatusUncheckedRule: Rule;
+//# sourceMappingURL=fetchStatusUnchecked.d.ts.map

package/dist/rules/network/fetchStatusUnchecked.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"fetchStatusUnchecked.d.ts","sourceRoot":"","sources":["../../../src/rules/network/fetchStatusUnchecked.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,wBAAwB,EAAE,IAkGtC,CAAC"}

package/dist/rules/network/fetchStatusUnchecked.js

@@ -0,0 +1,96 @@
+import { getNodeSourceRange, isDOMGlobal } from "../../engine/symbols.js";
+export const fetchStatusUncheckedRule = {
+    meta: {
+        id: "network/fetch-status-unchecked",
+        category: "network",
+        defaultSeverity: "warning",
+        defaultConfidence: "high",
+        description: "Detects consumption of fetch() response bodies without checking response.ok or status.",
+        requiresTypeInformation: true,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!checker || !ts)
+            return;
+        context.visitNodes((node) => {
+            // Look for VariableDeclaration: const res = await fetch(...)
+            if (!ts.isVariableDeclaration(node))
+                return;
+            if (!ts.isIdentifier(node.name))
+                return;
+            const resVarName = node.name.text;
+            const init = node.initializer;
+            if (!init)
+                return;
+            let callExpr;
+            if (ts.isAwaitExpression(init) && ts.isCallExpression(init.expression)) {
+                callExpr = init.expression;
+            }
+            else if (ts.isCallExpression(init)) {
+                callExpr = init;
+            }
+            if (!callExpr)
+                return;
+            // Check if call target is global DOM fetch
+            let isFetchCall = false;
+            if (ts.isIdentifier(callExpr.expression) && callExpr.expression.text === "fetch") {
+                if (isDOMGlobal(callExpr.expression, checker, "fetch")) {
+                    isFetchCall = true;
+                }
+            }
+            else if (ts.isPropertyAccessExpression(callExpr.expression) &&
+                callExpr.expression.name.text === "fetch" &&
+                ts.isIdentifier(callExpr.expression.expression) &&
+                (callExpr.expression.expression.text === "window" || callExpr.expression.expression.text === "globalThis")) {
+                isFetchCall = true;
+            }
+            if (!isFetchCall)
+                return;
+            // Find enclosing block or function
+            const scope = context.findEnclosingScope(node);
+            if (!scope)
+                return;
+            let hasStatusCheck = false;
+            let bodyConsumptionNode;
+            // Walk scope to look for usages of resVarName
+            function inspectScope(n) {
+                // Check for res.ok or res.status access
+                if (ts && ts.isPropertyAccessExpression(n)) {
+                    if (ts.isIdentifier(n.expression) && n.expression.text === resVarName) {
+                        const prop = n.name.text;
+                        if (prop === "ok" || prop === "status" || prop === "statusText") {
+                            hasStatusCheck = true;
+                        }
+                        if (prop === "json" || prop === "text" || prop === "blob" || prop === "arrayBuffer" || prop === "formData") {
+                            bodyConsumptionNode = n;
+                        }
+                    }
+                }
+                n.forEachChild(inspectScope);
+            }
+            inspectScope(scope);
+            // If body was consumed but status was never checked in scope
+            if (bodyConsumptionNode && !hasStatusCheck) {
+                const range = getNodeSourceRange(bodyConsumptionNode, sourceFile);
+                context.report({
+                    ruleId: "network/fetch-status-unchecked",
+                    category: "network",
+                    severity: "warning",
+                    confidence: "high",
+                    message: `Response body consumed via .${bodyConsumptionNode.name.text}() without checking response.ok or response.status.`,
+                    file: sourceFile.fileName,
+                    range,
+                    evidence: [
+                        {
+                            message: "fetch() does not reject on HTTP 4xx or 5xx status codes.",
+                            range,
+                        },
+                    ],
+                    suggestedAction: "Check `if (response.ok)` or verify `response.status` before consuming the response body.",
+                    safeAutomaticFix: false,
+                });
+            }
+        });
+    },
+};
+//# sourceMappingURL=fetchStatusUnchecked.js.map

package/dist/rules/network/fetchStatusUnchecked.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"fetchStatusUnchecked.js","sourceRoot":"","sources":["../../../src/rules/network/fetchStatusUnchecked.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAG1E,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,gCAAgC;QACpC,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,wFAAwF;QACrG,uBAAuB,EAAE,IAAI;KAC9B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,OAAO,IAAI,CAAC,EAAE;YAAE,OAAO;QAE5B,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,6DAA6D;YAC7D,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAC5C,IAAI,CAAC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC;gBAAE,OAAO;YACxC,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;YAElC,MAAM,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC;YAC9B,IAAI,CAAC,IAAI;gBAAE,OAAO;YAElB,IAAI,QAA2C,CAAC;YAChD,IAAI,EAAE,CAAC,iBAAiB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;gBACvE,QAAQ,GAAG,IAAI,CAAC,UAAU,CAAC;YAC7B,CAAC;iBAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrC,QAAQ,GAAG,IAAI,CAAC;YAClB,CAAC;YAED,IAAI,CAAC,QAAQ;gBAAE,OAAO;YAEtB,2CAA2C;YAC3C,IAAI,WAAW,GAAG,KAAK,CAAC;YACxB,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,QAAQ,CAAC,UAAU,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBACjF,IAAI,WAAW,CAAC,QAAQ,CAAC,UAAU,EAAE,OAAO,EAAE,OAAO,CAAC,EAAE,CAAC;oBACvD,WAAW,GAAG,IAAI,CAAC;gBACrB,CAAC;YACH,CAAC;iBAAM,IACL,EAAE,CAAC,0BAA0B,CAAC,QAAQ,CAAC,UAAU,CAAC;gBAClD,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO;gBACzC,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC;gBAC/C,CAAC,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,QAAQ,IAAI,QAAQ,CAAC,UAAU,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY,CAAC,EAC1G,CAAC;gBACD,WAAW,GAAG,IAAI,CAAC;YACrB,CAAC;YAED,IAAI,CAAC,WAAW;gBAAE,OAAO;YAEzB,mCAAmC;YACnC,MAAM,KAAK,GAAG,OAAO,CAAC,kBAAkB,CAAC,IAAI,CAAC,CAAC;YAC/C,IAAI,CAAC,KAAK;gBAAE,OAAO;YAEnB,IAAI,cAAc,GAAG,KAAK,CAAC;YAC3B,IAAI,mBAA4C,CAAC;YAEjD,8CAA8C;YAC9C,SAAS,YAAY,CAAC,CAAc;gBAClC,wCAAwC;gBACxC,IAAI,EAAE,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;oBAC3C,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,IAAI,KAAK,UAAU,EAAE,CAAC;wBACtE,MAAM,IAAI,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;wBACzB,IAAI,IAAI,KAAK,IAAI,IAAI,IAAI,KAAK,QAAQ,IAAI,IAAI,KAAK,YAAY,EAAE,CAAC;4BAChE,cAAc,GAAG,IAAI,CAAC;wBACxB,CAAC;wBACD,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,MAAM,IAAI,IAAI,KAAK,aAAa,IAAI,IAAI,KAAK,UAAU,EAAE,CAAC;4BAC3G,mBAAmB,GAAG,CAAC,CAAC;wBAC1B,CAAC;oBACH,CAAC;gBACH,CAAC;gBACD,CAAC,CAAC,YAAY,CAAC,YAAY,CAAC,CAAC;YAC/B,CAAC;YAED,YAAY,CAAC,KAAK,CAAC,CAAC;YAEpB,6DAA6D;YAC7D,IAAI,mBAAmB,IAAI,CAAC,cAAc,EAAE,CAAC;gBAC3C,MAAM,KAAK,GAAG,kBAAkB,CAAC,mBAAmB,EAAE,UAAU,CAAC,CAAC;gBAClE,OAAO,CAAC,MAAM,CAAC;oBACb,MAAM,EAAE,gCAAgC;oBACxC,QAAQ,EAAE,SAAS;oBACnB,QAAQ,EAAE,SAAS;oBACnB,UAAU,EAAE,MAAM;oBAClB,OAAO,EAAE,+BAAgC,mBAAuD,CAAC,IAAI,CAAC,IAAI,qDAAqD;oBAC/J,IAAI,EAAE,UAAU,CAAC,QAAQ;oBACzB,KAAK;oBACL,QAAQ,EAAE;wBACR;4BACE,OAAO,EAAE,0DAA0D;4BACnE,KAAK;yBACN;qBACF;oBACD,eAAe,EAAE,0FAA0F;oBAC3G,gBAAgB,EAAE,KAAK;iBACxB,CAAC,CAAC;YACL,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/react/asyncEffectCallback.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const asyncEffectCallbackRule: Rule;
+//# sourceMappingURL=asyncEffectCallback.d.ts.map

package/dist/rules/react/asyncEffectCallback.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"asyncEffectCallback.d.ts","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,uBAAuB,EAAE,IA8DrC,CAAC"}

package/dist/rules/react/asyncEffectCallback.js

@@ -0,0 +1,62 @@
+import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
+export const asyncEffectCallbackRule = {
+    meta: {
+        id: "react/async-effect-callback",
+        category: "react",
+        defaultSeverity: "error",
+        defaultConfidence: "high",
+        description: "Detects async functions passed directly as React useEffect callbacks.",
+        requiresTypeInformation: false,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!ts)
+            return;
+        context.visitNodes((node) => {
+            if (!ts.isCallExpression(node))
+                return;
+            let isEffectHook = false;
+            if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
+                isEffectHook = true;
+            }
+            else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
+                isEffectHook = true;
+            }
+            if (!isEffectHook)
+                return;
+            const args = node.arguments;
+            if (!args || args.length === 0)
+                return;
+            const callback = args[0];
+            if (!callback)
+                return;
+            let isAsync = false;
+            if (ts.isArrowFunction(callback) || ts.isFunctionExpression(callback)) {
+                if (callback.modifiers?.some((m) => m.kind === ts.SyntaxKind.AsyncKeyword)) {
+                    isAsync = true;
+                }
+            }
+            if (isAsync) {
+                const range = getNodeSourceRange(callback, sourceFile);
+                context.report({
+                    ruleId: "react/async-effect-callback",
+                    category: "react",
+                    severity: "error",
+                    confidence: "high",
+                    message: "Effect setup callback must not be an async function.",
+                    file: sourceFile.fileName,
+                    range,
+                    evidence: [
+                        {
+                            message: "React expects useEffect setup functions to return undefined or a synchronous cleanup function; async functions return a Promise.",
+                            range,
+                        },
+                    ],
+                    suggestedAction: "Define an async function inside the effect and call it synchronously: useEffect(() => { async function load() { ... } load(); }, []).",
+                    safeAutomaticFix: false,
+                });
+            }
+        });
+    },
+};
+//# sourceMappingURL=asyncEffectCallback.js.map

package/dist/rules/react/asyncEffectCallback.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"asyncEffectCallback.js","sourceRoot":"","sources":["../../../src/rules/react/asyncEffectCallback.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAG/E,MAAM,CAAC,MAAM,uBAAuB,GAAS;IAC3C,IAAI,EAAE;QACJ,EAAE,EAAE,6BAA6B;QACjC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,uEAAuE;QACpF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,YAAY,GAAG,KAAK,CAAC;YACzB,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,OAAO;YAE1B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ;gBAAE,OAAO;YACtB,IAAI,OAAO,GAAG,KAAK,CAAC;YAEpB,IAAI,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACtE,IAAI,QAAQ,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,YAAY,CAAC,EAAE,CAAC;oBAC3E,OAAO,GAAG,IAAI,CAAC;gBACjB,CAAC;YACH,CAAC;YAED,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,KAAK,GAAG,kBAAkB,CAAC,QAAQ,EAAE,UAAU,CAAC,CAAC;gBACvD,OAAO,CAAC,MAAM,CAAC;oBACb,MAAM,EAAE,6BAA6B;oBACrC,QAAQ,EAAE,OAAO;oBACjB,QAAQ,EAAE,OAAO;oBACjB,UAAU,EAAE,MAAM;oBAClB,OAAO,EAAE,sDAAsD;oBAC/D,IAAI,EAAE,UAAU,CAAC,QAAQ;oBACzB,KAAK;oBACL,QAAQ,EAAE;wBACR;4BACE,OAAO,EAAE,kIAAkI;4BAC3I,KAAK;yBACN;qBACF;oBACD,eAAe,EACb,uIAAuI;oBACzI,gBAAgB,EAAE,KAAK;iBACxB,CAAC,CAAC;YACL,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/react/derivedStateEffect.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const derivedStateEffectRule: Rule;
+//# sourceMappingURL=derivedStateEffect.d.ts.map

package/dist/rules/react/derivedStateEffect.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"derivedStateEffect.d.ts","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AA0D7D,eAAO,MAAM,sBAAsB,EAAE,IAkIpC,CAAC"}

package/dist/rules/react/derivedStateEffect.js

@@ -0,0 +1,172 @@
+import { getNodeSourceRange, resolveReactHook } from "../../engine/symbols.js";
+import { isResetValue, resolveConstantValue, unwrapExpression } from "../../analysis/values.js";
+/**
+ * Collects all identifier names referenced within an AST node, following local const variable initializers.
+ */
+function collectReferencedIdentifiers(node, ts, checker) {
+    const names = new Set();
+    const visitedSymbols = new Set();
+    function walk(n) {
+        if (ts.isIdentifier(n)) {
+            names.add(n.text);
+            if (checker) {
+                const sym = checker.getSymbolAtLocation(n);
+                if (sym && !visitedSymbols.has(sym)) {
+                    visitedSymbols.add(sym);
+                    const decl = sym.valueDeclaration ?? sym.declarations?.[0];
+                    if (decl && ts.isVariableDeclaration(decl) && decl.initializer) {
+                        walk(decl.initializer);
+                    }
+                }
+            }
+        }
+        n.forEachChild(walk);
+    }
+    walk(node);
+    return names;
+}
+/**
+ * Extracts dependency identifier names from a React hook dependency array (e.g. `[a, b.c, d]`).
+ */
+function extractDependencyNames(depsArg, ts) {
+    const depNames = new Set();
+    const unwrapped = unwrapExpression(depsArg, ts);
+    if (ts.isArrayLiteralExpression(unwrapped)) {
+        for (const elem of unwrapped.elements) {
+            const u = unwrapExpression(elem, ts);
+            if (ts.isIdentifier(u)) {
+                depNames.add(u.text);
+            }
+            else if (ts.isPropertyAccessExpression(u)) {
+                // e.g. props.value -> collect 'props' and 'value'
+                const base = unwrapExpression(u.expression, ts);
+                if (ts.isIdentifier(base)) {
+                    depNames.add(base.text);
+                }
+            }
+        }
+    }
+    return depNames;
+}
+export const derivedStateEffectRule = {
+    meta: {
+        id: "react/derived-state-effect",
+        category: "react",
+        defaultSeverity: "warning",
+        defaultConfidence: "high",
+        description: "Detects Effects used exclusively to derive state from render inputs.",
+        requiresTypeInformation: false,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!ts)
+            return;
+        context.visitNodes((node) => {
+            if (!ts.isCallExpression(node))
+                return;
+            let isEffectHook = false;
+            if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
+                isEffectHook = true;
+            }
+            else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
+                isEffectHook = true;
+            }
+            if (!isEffectHook)
+                return;
+            const args = node.arguments;
+            if (!args || args.length === 0)
+                return;
+            const callback = args[0];
+            if (!callback || (!ts.isArrowFunction(callback) && !ts.isFunctionExpression(callback))) {
+                return;
+            }
+            // Inspect statements in effect body
+            const body = callback.body;
+            let setterCallExpr;
+            let setterName = "";
+            if (ts.isBlock(body)) {
+                const stmts = body.statements;
+                if (stmts.length === 1 && stmts[0] && ts.isExpressionStatement(stmts[0])) {
+                    const expr = unwrapExpression(stmts[0].expression, ts);
+                    if (ts.isCallExpression(expr) && ts.isIdentifier(expr.expression)) {
+                        const fnName = expr.expression.text;
+                        if (/^set[A-Z]/.test(fnName)) {
+                            setterCallExpr = expr;
+                            setterName = fnName;
+                        }
+                    }
+                }
+            }
+            else if (ts.isCallExpression(body)) {
+                const unwrappedBody = unwrapExpression(body, ts);
+                if (ts.isCallExpression(unwrappedBody) && ts.isIdentifier(unwrappedBody.expression)) {
+                    const fnName = unwrappedBody.expression.text;
+                    if (/^set[A-Z]/.test(fnName)) {
+                        setterCallExpr = unwrappedBody;
+                        setterName = fnName;
+                    }
+                }
+            }
+            if (!setterCallExpr)
+                return;
+            const setterArgs = setterCallExpr.arguments;
+            if (setterArgs.length === 0)
+                return;
+            const setterArg = setterArgs[0];
+            if (!setterArg)
+                return;
+            // 1. Exclude functional state updates: setState(prev => prev + 1)
+            const unwrappedArg = unwrapExpression(setterArg, ts);
+            if (ts.isArrowFunction(unwrappedArg) || ts.isFunctionExpression(unwrappedArg)) {
+                return;
+            }
+            // 2. Exclude state resets: setState(0), setState(""), setState(null), setState(DEFAULT_STATE where DEFAULT_STATE is static)
+            if (isResetValue(unwrappedArg, ts, checker)) {
+                return;
+            }
+            // 3. Exclude static literals/constants that do not depend on effect dependencies
+            const constantVal = resolveConstantValue(unwrappedArg, ts, checker);
+            if (constantVal.isStatic) {
+                return;
+            }
+            // 4. If dependency array exists, check whether setter argument actually references any dependency (including through local aliases)
+            const depsArg = args[1];
+            if (depsArg) {
+                const deps = extractDependencyNames(depsArg, ts);
+                const referencedInArg = collectReferencedIdentifiers(unwrappedArg, ts, checker);
+                // Check if any referenced variable in the setter expression is part of the dependencies
+                let dependsOnDependencies = false;
+                for (const ref of referencedInArg) {
+                    if (deps.has(ref)) {
+                        dependsOnDependencies = true;
+                        break;
+                    }
+                }
+                // If the setter value does not depend on any Effect dependency, it is a state reset / trigger,
+                // not a derived state synchronization.
+                if (!dependsOnDependencies && deps.size > 0) {
+                    return;
+                }
+            }
+            const range = getNodeSourceRange(node, sourceFile);
+            context.report({
+                ruleId: "react/derived-state-effect",
+                category: "react",
+                severity: "warning",
+                confidence: "high",
+                message: `State setter '${setterName}' is called unconditionally inside useEffect to derive state.`,
+                file: sourceFile.fileName,
+                range,
+                evidence: [
+                    {
+                        message: "Synchronizing derived state in useEffect causes an extra render cycle and potential UI flicker.",
+                        range,
+                    },
+                ],
+                suggestedAction: "Compute the derived value directly during render instead of storing it in useState and syncing with useEffect.",
+                safeAutomaticFix: false,
+            });
+        });
+    },
+};
+//# sourceMappingURL=derivedStateEffect.js.map

package/dist/rules/react/derivedStateEffect.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"derivedStateEffect.js","sourceRoot":"","sources":["../../../src/rules/react/derivedStateEffect.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAC/E,OAAO,EAAE,YAAY,EAAE,oBAAoB,EAAE,gBAAgB,EAAE,MAAM,0BAA0B,CAAC;AAGhG;;GAEG;AACH,SAAS,4BAA4B,CACnC,IAAiB,EACjB,EAAiB,EACjB,OAAwC;IAExC,MAAM,KAAK,GAAG,IAAI,GAAG,EAAU,CAAC;IAChC,MAAM,cAAc,GAAG,IAAI,GAAG,EAAiB,CAAC;IAEhD,SAAS,IAAI,CAAC,CAAc;QAC1B,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;YACvB,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YAClB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;gBAC3C,IAAI,GAAG,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;oBACpC,cAAc,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oBACxB,MAAM,IAAI,GAAG,GAAG,CAAC,gBAAgB,IAAI,GAAG,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC;oBAC3D,IAAI,IAAI,IAAI,EAAE,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;wBAC/D,IAAI,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;oBACzB,CAAC;gBACH,CAAC;YACH,CAAC;QACH,CAAC;QACD,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;IACvB,CAAC;IACD,IAAI,CAAC,IAAI,CAAC,CAAC;IACX,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;GAEG;AACH,SAAS,sBAAsB,CAAC,OAA0B,EAAE,EAAiB;IAC3E,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAC;IACnC,MAAM,SAAS,GAAG,gBAAgB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAEhD,IAAI,EAAE,CAAC,wBAAwB,CAAC,SAAS,CAAC,EAAE,CAAC;QAC3C,KAAK,MAAM,IAAI,IAAI,SAAS,CAAC,QAAQ,EAAE,CAAC;YACtC,MAAM,CAAC,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;YACrC,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC,CAAC,EAAE,CAAC;gBACvB,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;YACvB,CAAC;iBAAM,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,EAAE,CAAC;gBAC5C,kDAAkD;gBAClD,MAAM,IAAI,GAAG,gBAAgB,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;gBAChD,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC1B,QAAQ,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAC1B,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,MAAM,CAAC,MAAM,sBAAsB,GAAS;IAC1C,IAAI,EAAE;QACJ,EAAE,EAAE,4BAA4B;QAChC,QAAQ,EAAE,OAAO;QACjB,eAAe,EAAE,SAAS;QAC1B,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,sEAAsE;QACnF,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,YAAY,GAAG,KAAK,CAAC;YACzB,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,OAAO;YAE1B,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC;YAC5B,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEvC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,IAAI,CAAC,QAAQ,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,QAAQ,CAAC,CAAC,EAAE,CAAC;gBACvF,OAAO;YACT,CAAC;YAED,oCAAoC;YACpC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC;YAC3B,IAAI,cAAiD,CAAC;YACtD,IAAI,UAAU,GAAG,EAAE,CAAC;YAEpB,IAAI,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrB,MAAM,KAAK,GAAG,IAAI,CAAC,UAAU,CAAC;gBAC9B,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC,IAAI,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,qBAAqB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACzE,MAAM,IAAI,GAAG,gBAAgB,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;oBACvD,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;wBAClE,MAAM,MAAM,GAAG,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC;wBACpC,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;4BAC7B,cAAc,GAAG,IAAI,CAAC;4BACtB,UAAU,GAAG,MAAM,CAAC;wBACtB,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;iBAAM,IAAI,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;gBACrC,MAAM,aAAa,GAAG,gBAAgB,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;gBACjD,IAAI,EAAE,CAAC,gBAAgB,CAAC,aAAa,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,aAAa,CAAC,UAAU,CAAC,EAAE,CAAC;oBACpF,MAAM,MAAM,GAAG,aAAa,CAAC,UAAU,CAAC,IAAI,CAAC;oBAC7C,IAAI,WAAW,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;wBAC7B,cAAc,GAAG,aAAa,CAAC;wBAC/B,UAAU,GAAG,MAAM,CAAC;oBACtB,CAAC;gBACH,CAAC;YACH,CAAC;YAED,IAAI,CAAC,cAAc;gBAAE,OAAO;YAE5B,MAAM,UAAU,GAAG,cAAc,CAAC,SAAS,CAAC;YAC5C,IAAI,UAAU,CAAC,MAAM,KAAK,CAAC;gBAAE,OAAO;YAEpC,MAAM,SAAS,GAAG,UAAU,CAAC,CAAC,CAAC,CAAC;YAChC,IAAI,CAAC,SAAS;gBAAE,OAAO;YAEvB,kEAAkE;YAClE,MAAM,YAAY,GAAG,gBAAgB,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;YACrD,IAAI,EAAE,CAAC,eAAe,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,YAAY,CAAC,EAAE,CAAC;gBAC9E,OAAO;YACT,CAAC;YAED,4HAA4H;YAC5H,IAAI,YAAY,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,EAAE,CAAC;gBAC5C,OAAO;YACT,CAAC;YAED,iFAAiF;YACjF,MAAM,WAAW,GAAG,oBAAoB,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;YACpE,IAAI,WAAW,CAAC,QAAQ,EAAE,CAAC;gBACzB,OAAO;YACT,CAAC;YAED,oIAAoI;YACpI,MAAM,OAAO,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACxB,IAAI,OAAO,EAAE,CAAC;gBACZ,MAAM,IAAI,GAAG,sBAAsB,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;gBACjD,MAAM,eAAe,GAAG,4BAA4B,CAAC,YAAY,EAAE,EAAE,EAAE,OAAO,CAAC,CAAC;gBAEhF,wFAAwF;gBACxF,IAAI,qBAAqB,GAAG,KAAK,CAAC;gBAClC,KAAK,MAAM,GAAG,IAAI,eAAe,EAAE,CAAC;oBAClC,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC;wBAClB,qBAAqB,GAAG,IAAI,CAAC;wBAC7B,MAAM;oBACR,CAAC;gBACH,CAAC;gBAED,+FAA+F;gBAC/F,uCAAuC;gBACvC,IAAI,CAAC,qBAAqB,IAAI,IAAI,CAAC,IAAI,GAAG,CAAC,EAAE,CAAC;oBAC5C,OAAO;gBACT,CAAC;YACH,CAAC;YAED,MAAM,KAAK,GAAG,kBAAkB,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;YACnD,OAAO,CAAC,MAAM,CAAC;gBACb,MAAM,EAAE,4BAA4B;gBACpC,QAAQ,EAAE,OAAO;gBACjB,QAAQ,EAAE,SAAS;gBACnB,UAAU,EAAE,MAAM;gBAClB,OAAO,EAAE,iBAAiB,UAAU,+DAA+D;gBACnG,IAAI,EAAE,UAAU,CAAC,QAAQ;gBACzB,KAAK;gBACL,QAAQ,EAAE;oBACR;wBACE,OAAO,EAAE,iGAAiG;wBAC1G,KAAK;qBACN;iBACF;gBACD,eAAe,EACb,gHAAgH;gBAClH,gBAAgB,EAAE,KAAK;aACxB,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/react/missingEffectCleanup.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const missingEffectCleanupRule: Rule;
+//# sourceMappingURL=missingEffectCleanup.d.ts.map

package/dist/rules/react/missingEffectCleanup.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"missingEffectCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/react/missingEffectCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,wBAAwB,EAAE,IA8FtC,CAAC"}