sourceverity 1.0.0

package/dist/rules/browser/eventListenerCleanup.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const eventListenerCleanupRule: Rule;
+//# sourceMappingURL=eventListenerCleanup.d.ts.map

package/dist/rules/browser/eventListenerCleanup.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"eventListenerCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/browser/eventListenerCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,wBAAwB,EAAE,IA0dtC,CAAC"}

package/dist/rules/browser/eventListenerCleanup.js

@@ -0,0 +1,378 @@
+import { getNodeSourceRange, resolveReactHook, isDOMEventTarget, isDOMAbortController } from "../../engine/symbols.js";
+export const eventListenerCleanupRule = {
+    meta: {
+        id: "browser/event-listener-cleanup",
+        category: "browser",
+        defaultSeverity: "error",
+        defaultConfidence: "high",
+        description: "Detects addEventListener registered in lifecycle hooks without matching removeEventListener cleanup.",
+        requiresTypeInformation: false,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!ts)
+            return;
+        context.visitNodes((node) => {
+            // Find useEffect or useLayoutEffect calls
+            if (!ts.isCallExpression(node))
+                return;
+            let isLifecycleHook = false;
+            if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
+                isLifecycleHook = true;
+            }
+            else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
+                isLifecycleHook = true;
+            }
+            if (!isLifecycleHook)
+                return;
+            const effectCallback = node.arguments[0];
+            if (!effectCallback || (!ts.isArrowFunction(effectCallback) && !ts.isFunctionExpression(effectCallback))) {
+                return;
+            }
+            function resolveEventExpression(expr, chk, t) {
+                let current = expr;
+                while (t.isParenthesizedExpression(current)) {
+                    current = current.expression;
+                }
+                if (t.isStringLiteral(current) || t.isNoSubstitutionTemplateLiteral(current)) {
+                    return {
+                        rawText: current.text,
+                        literalValue: current.text,
+                    };
+                }
+                if (t.isIdentifier(current)) {
+                    const rawText = current.text;
+                    if (!chk) {
+                        return { rawText };
+                    }
+                    const sym = chk.getSymbolAtLocation(current);
+                    let rootSym = sym;
+                    if (rootSym && (rootSym.flags & t.SymbolFlags.Alias) !== 0) {
+                        try {
+                            rootSym = chk.getAliasedSymbol(rootSym);
+                        }
+                        catch {
+                            // ignore
+                        }
+                    }
+                    let literalValue;
+                    let targetSym = sym;
+                    const visitedSyms = new Set();
+                    while (targetSym && !visitedSyms.has(targetSym)) {
+                        visitedSyms.add(targetSym);
+                        const decl = targetSym.valueDeclaration ?? targetSym.declarations?.[0];
+                        if (decl && t.isVariableDeclaration(decl) && decl.initializer) {
+                            let init = decl.initializer;
+                            while (t.isParenthesizedExpression(init)) {
+                                init = init.expression;
+                            }
+                            if (t.isStringLiteral(init) || t.isNoSubstitutionTemplateLiteral(init)) {
+                                literalValue = init.text;
+                                break;
+                            }
+                            else if (t.isIdentifier(init)) {
+                                const nextSym = chk.getSymbolAtLocation(init);
+                                if (nextSym) {
+                                    targetSym = nextSym;
+                                    if (!rootSym)
+                                        rootSym = nextSym;
+                                    continue;
+                                }
+                            }
+                        }
+                        break;
+                    }
+                    if (literalValue === undefined) {
+                        try {
+                            const type = chk.getTypeAtLocation(current);
+                            if (type.isStringLiteral()) {
+                                literalValue = type.value;
+                            }
+                        }
+                        catch {
+                            // ignore
+                        }
+                    }
+                    return {
+                        rawText,
+                        literalValue,
+                        symbol: sym,
+                        rootSymbol: rootSym,
+                    };
+                }
+                if (t.isPropertyAccessExpression(current)) {
+                    const rawText = current.getText();
+                    let literalValue;
+                    let sym;
+                    let rootSym;
+                    if (chk) {
+                        sym = chk.getSymbolAtLocation(current);
+                        rootSym = sym;
+                        try {
+                            const type = chk.getTypeAtLocation(current);
+                            if (type.isStringLiteral()) {
+                                literalValue = type.value;
+                            }
+                        }
+                        catch {
+                            // ignore
+                        }
+                    }
+                    return {
+                        rawText,
+                        literalValue,
+                        symbol: sym,
+                        rootSymbol: rootSym,
+                    };
+                }
+                return {
+                    rawText: current.getText(),
+                };
+            }
+            function areEventExpressionsIdentical(addInfo, remInfo) {
+                if (addInfo.literalValue !== undefined && remInfo.literalValue !== undefined) {
+                    return addInfo.literalValue === remInfo.literalValue;
+                }
+                if (addInfo.rootSymbol && remInfo.rootSymbol && addInfo.rootSymbol === remInfo.rootSymbol) {
+                    return true;
+                }
+                if (addInfo.symbol && remInfo.symbol && addInfo.symbol === remInfo.symbol) {
+                    return true;
+                }
+                if (addInfo.rawText && remInfo.rawText && addInfo.rawText === remInfo.rawText) {
+                    return true;
+                }
+                return false;
+            }
+            function resolveHandlerExpression(expr, chk, t) {
+                let current = expr;
+                while (t.isParenthesizedExpression(current)) {
+                    current = current.expression;
+                }
+                if (t.isArrowFunction(current) || t.isFunctionExpression(current)) {
+                    return { isInlineHandler: true };
+                }
+                if (t.isIdentifier(current)) {
+                    const sym = chk ? chk.getSymbolAtLocation(current) : undefined;
+                    return {
+                        isInlineHandler: false,
+                        handlerName: current.text,
+                        symbol: sym,
+                    };
+                }
+                return {
+                    isInlineHandler: false,
+                    handlerName: current.getText(),
+                    symbol: chk ? chk.getSymbolAtLocation(current) : undefined,
+                };
+            }
+            function areHandlersIdentical(addHandler, remHandler) {
+                if (addHandler.isInlineHandler || remHandler.isInlineHandler) {
+                    return false;
+                }
+                if (addHandler.symbol && remHandler.symbol && addHandler.symbol === remHandler.symbol) {
+                    return true;
+                }
+                if (addHandler.handlerName && remHandler.handlerName && addHandler.handlerName === remHandler.handlerName) {
+                    return true;
+                }
+                return false;
+            }
+            function resolveTargetExpression(expr, chk, t) {
+                let current = expr;
+                while (t.isParenthesizedExpression(current)) {
+                    current = current.expression;
+                }
+                const text = current.getText();
+                const symbol = chk ? chk.getSymbolAtLocation(current) : undefined;
+                return { text, symbol };
+            }
+            function areTargetsIdentical(addTarget, remTarget) {
+                if (addTarget.symbol && remTarget.symbol && addTarget.symbol === remTarget.symbol) {
+                    return true;
+                }
+                return addTarget.text === remTarget.text;
+            }
+            const addListeners = [];
+            const removeListeners = [];
+            const abortedControllerNames = new Set();
+            const abortedControllerSymbols = new Set();
+            let hasCleanupReturn = false;
+            function extractControllerNode(signalExpr, chk, t) {
+                if (t.isPropertyAccessExpression(signalExpr) && signalExpr.name.text === "signal") {
+                    const target = signalExpr.expression;
+                    if (isDOMAbortController(target, chk, t)) {
+                        return target;
+                    }
+                }
+                if (t.isIdentifier(signalExpr) && chk) {
+                    const sym = chk.getSymbolAtLocation(signalExpr);
+                    if (sym?.valueDeclaration && t.isVariableDeclaration(sym.valueDeclaration) && sym.valueDeclaration.initializer) {
+                        return extractControllerNode(sym.valueDeclaration.initializer, chk, t);
+                    }
+                }
+                return undefined;
+            }
+            function inspectEffectBody(n) {
+                // Look for target.addEventListener('event', handler, options)
+                if (ts && ts.isCallExpression(n) && ts.isPropertyAccessExpression(n.expression) && n.expression.name.text === "addEventListener") {
+                    const target = n.expression.expression;
+                    // Only audit authentic DOM EventTargets (window, document, HTMLElement, etc.)
+                    if (!isDOMEventTarget(target, checker, ts)) {
+                        return;
+                    }
+                    const args = n.arguments;
+                    const eventTypeArg = args[0];
+                    const handlerArg = args[1];
+                    if (eventTypeArg && handlerArg) {
+                        const targetInfo = resolveTargetExpression(target, checker, ts);
+                        const eventInfo = resolveEventExpression(eventTypeArg, checker, ts);
+                        const handlerInfo = resolveHandlerExpression(handlerArg, checker, ts);
+                        let controllerName;
+                        let controllerSymbol;
+                        // Check options argument (3rd arg) for { signal: controller.signal } or { signal }
+                        const optionsArg = args[2];
+                        if (optionsArg && ts.isObjectLiteralExpression(optionsArg)) {
+                            for (const prop of optionsArg.properties) {
+                                if (ts.isPropertyAssignment(prop) && prop.name && "text" in prop.name && prop.name.text === "signal") {
+                                    const ctrlNode = extractControllerNode(prop.initializer, checker, ts);
+                                    if (ctrlNode && ts.isIdentifier(ctrlNode)) {
+                                        controllerName = ctrlNode.text;
+                                        if (checker) {
+                                            controllerSymbol = checker.getSymbolAtLocation(ctrlNode);
+                                        }
+                                    }
+                                }
+                                else if (ts.isShorthandPropertyAssignment(prop) && prop.name.text === "signal") {
+                                    if (checker) {
+                                        const valSym = checker.getShorthandAssignmentValueSymbol(prop) ?? checker.getSymbolAtLocation(prop.name);
+                                        if (valSym?.valueDeclaration && ts.isVariableDeclaration(valSym.valueDeclaration) && valSym.valueDeclaration.initializer) {
+                                            const ctrlNode = extractControllerNode(valSym.valueDeclaration.initializer, checker, ts);
+                                            if (ctrlNode && ts.isIdentifier(ctrlNode)) {
+                                                controllerName = ctrlNode.text;
+                                                controllerSymbol = checker.getSymbolAtLocation(ctrlNode);
+                                            }
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                        addListeners.push({
+                            node: n,
+                            targetInfo,
+                            eventInfo,
+                            handlerInfo,
+                            controllerName,
+                            controllerSymbol,
+                        });
+                    }
+                }
+                // Look for return statement with cleanup function: return () => { ... }
+                if (ts && ts.isReturnStatement(n) && n.expression) {
+                    const retExpr = n.expression;
+                    if (ts.isArrowFunction(retExpr) || ts.isFunctionExpression(retExpr)) {
+                        hasCleanupReturn = true;
+                        inspectCleanupBody(retExpr);
+                    }
+                }
+                // Don't recurse into nested function declarations (their returns aren't effect cleanups)
+                if (ts && n !== effectCallback && (ts.isFunctionDeclaration(n) || ts.isArrowFunction(n) || ts.isFunctionExpression(n))) {
+                    return;
+                }
+                n.forEachChild(inspectEffectBody);
+            }
+            function inspectCleanupBody(cleanupFn) {
+                function walkCleanup(cn) {
+                    // 1. removeEventListener calls
+                    if (ts && ts.isCallExpression(cn) && ts.isPropertyAccessExpression(cn.expression) && cn.expression.name.text === "removeEventListener") {
+                        const target = cn.expression.expression;
+                        const args = cn.arguments;
+                        const eventTypeArg = args[0];
+                        const handlerArg = args[1];
+                        if (eventTypeArg && handlerArg) {
+                            const targetInfo = resolveTargetExpression(target, checker, ts);
+                            const eventInfo = resolveEventExpression(eventTypeArg, checker, ts);
+                            const handlerInfo = resolveHandlerExpression(handlerArg, checker, ts);
+                            removeListeners.push({
+                                targetInfo,
+                                eventInfo,
+                                handlerInfo,
+                            });
+                        }
+                    }
+                    // 2. controller.abort() calls
+                    if (ts && ts.isCallExpression(cn) && ts.isPropertyAccessExpression(cn.expression) && cn.expression.name.text === "abort") {
+                        const abortReceiver = cn.expression.expression;
+                        if (isDOMAbortController(abortReceiver, checker, ts) && ts.isIdentifier(abortReceiver)) {
+                            abortedControllerNames.add(abortReceiver.text);
+                            if (checker) {
+                                const sym = checker.getSymbolAtLocation(abortReceiver);
+                                if (sym) {
+                                    abortedControllerSymbols.add(sym);
+                                }
+                            }
+                        }
+                    }
+                    cn.forEachChild(walkCleanup);
+                }
+                cleanupFn.forEachChild(walkCleanup);
+            }
+            inspectEffectBody(effectCallback.body);
+            // Check each addListener against removeListeners and aborted controllers
+            for (const listener of addListeners) {
+                let isCleanedUp = false;
+                if (hasCleanupReturn) {
+                    // 1. Check AbortController abort() cleanup
+                    if (listener.controllerSymbol && abortedControllerSymbols.has(listener.controllerSymbol)) {
+                        isCleanedUp = true;
+                    }
+                    else if (listener.controllerName && abortedControllerNames.has(listener.controllerName)) {
+                        isCleanedUp = true;
+                    }
+                    // 2. Check removeEventListener cleanup
+                    if (!isCleanedUp) {
+                        for (const rem of removeListeners) {
+                            if (areTargetsIdentical(listener.targetInfo, rem.targetInfo) &&
+                                areEventExpressionsIdentical(listener.eventInfo, rem.eventInfo)) {
+                                if (listener.handlerInfo.isInlineHandler || rem.handlerInfo.isInlineHandler) {
+                                    isCleanedUp = false;
+                                }
+                                else if (areHandlersIdentical(listener.handlerInfo, rem.handlerInfo)) {
+                                    isCleanedUp = true;
+                                    break;
+                                }
+                            }
+                        }
+                    }
+                }
+                if (!isCleanedUp) {
+                    const range = getNodeSourceRange(listener.node, sourceFile);
+                    const detailMsg = listener.handlerInfo.isInlineHandler && !listener.controllerName
+                        ? "Inline callback function in addEventListener cannot be removed because a new function reference is created."
+                        : hasCleanupReturn
+                            ? `Neither matching removeEventListener nor controller.abort() was found in the cleanup function.`
+                            : "No cleanup function was returned from the lifecycle hook.";
+                    const eventDisplay = listener.eventInfo.literalValue ?? listener.eventInfo.rawText ?? "event";
+                    context.report({
+                        ruleId: "browser/event-listener-cleanup",
+                        category: "browser",
+                        severity: "error",
+                        confidence: "high",
+                        message: `addEventListener for '${eventDisplay}' in lifecycle hook is missing matching cleanup.`,
+                        file: sourceFile.fileName,
+                        range,
+                        evidence: [
+                            {
+                                message: detailMsg,
+                                range,
+                            },
+                        ],
+                        suggestedAction: "Remove the event listener in cleanup (removeEventListener) or abort the associated AbortController (controller.abort()).",
+                        safeAutomaticFix: false,
+                    });
+                }
+            }
+        });
+    },
+};
+//# sourceMappingURL=eventListenerCleanup.js.map

package/dist/rules/browser/eventListenerCleanup.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"eventListenerCleanup.js","sourceRoot":"","sources":["../../../src/rules/browser/eventListenerCleanup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,gBAAgB,EAAE,oBAAoB,EAAE,MAAM,yBAAyB,CAAC;AAGvH,MAAM,CAAC,MAAM,wBAAwB,GAAS;IAC5C,IAAI,EAAE;QACJ,EAAE,EAAE,gCAAgC;QACpC,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,sGAAsG;QACnH,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,0CAA0C;YAC1C,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,eAAe,GAAG,KAAK,CAAC;YAC5B,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;YAED,IAAI,CAAC,eAAe;gBAAE,OAAO;YAE7B,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACzC,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC;gBACzG,OAAO;YACT,CAAC;YAoBD,SAAS,sBAAsB,CAC7B,IAAuB,EACvB,GAAmC,EACnC,CAAgB;gBAEhB,IAAI,OAAO,GAAsB,IAAI,CAAC;gBACtC,OAAO,CAAC,CAAC,yBAAyB,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC5C,OAAO,GAAG,OAAO,CAAC,UAAU,CAAC;gBAC/B,CAAC;gBAED,IAAI,CAAC,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,+BAA+B,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC7E,OAAO;wBACL,OAAO,EAAE,OAAO,CAAC,IAAI;wBACrB,YAAY,EAAE,OAAO,CAAC,IAAI;qBAC3B,CAAC;gBACJ,CAAC;gBAED,IAAI,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC5B,MAAM,OAAO,GAAG,OAAO,CAAC,IAAI,CAAC;oBAC7B,IAAI,CAAC,GAAG,EAAE,CAAC;wBACT,OAAO,EAAE,OAAO,EAAE,CAAC;oBACrB,CAAC;oBAED,MAAM,GAAG,GAAG,GAAG,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;oBAC7C,IAAI,OAAO,GAAG,GAAG,CAAC;oBAClB,IAAI,OAAO,IAAI,CAAC,OAAO,CAAC,KAAK,GAAG,CAAC,CAAC,WAAW,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC;wBAC3D,IAAI,CAAC;4BACH,OAAO,GAAG,GAAG,CAAC,gBAAgB,CAAC,OAAO,CAAC,CAAC;wBAC1C,CAAC;wBAAC,MAAM,CAAC;4BACP,SAAS;wBACX,CAAC;oBACH,CAAC;oBAED,IAAI,YAAgC,CAAC;oBACrC,IAAI,SAAS,GAAG,GAAG,CAAC;oBACpB,MAAM,WAAW,GAAG,IAAI,GAAG,EAAiB,CAAC;oBAC7C,OAAO,SAAS,IAAI,CAAC,WAAW,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;wBAChD,WAAW,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;wBAC3B,MAAM,IAAI,GAAG,SAAS,CAAC,gBAAgB,IAAI,SAAS,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC;wBACvE,IAAI,IAAI,IAAI,CAAC,CAAC,qBAAqB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,WAAW,EAAE,CAAC;4BAC9D,IAAI,IAAI,GAAG,IAAI,CAAC,WAAW,CAAC;4BAC5B,OAAO,CAAC,CAAC,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC;gCACzC,IAAI,GAAG,IAAI,CAAC,UAAU,CAAC;4BACzB,CAAC;4BACD,IAAI,CAAC,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,+BAA+B,CAAC,IAAI,CAAC,EAAE,CAAC;gCACvE,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC;gCACzB,MAAM;4BACR,CAAC;iCAAM,IAAI,CAAC,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;gCAChC,MAAM,OAAO,GAAG,GAAG,CAAC,mBAAmB,CAAC,IAAI,CAAC,CAAC;gCAC9C,IAAI,OAAO,EAAE,CAAC;oCACZ,SAAS,GAAG,OAAO,CAAC;oCACpB,IAAI,CAAC,OAAO;wCAAE,OAAO,GAAG,OAAO,CAAC;oCAChC,SAAS;gCACX,CAAC;4BACH,CAAC;wBACH,CAAC;wBACD,MAAM;oBACR,CAAC;oBAED,IAAI,YAAY,KAAK,SAAS,EAAE,CAAC;wBAC/B,IAAI,CAAC;4BACH,MAAM,IAAI,GAAG,GAAG,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;4BAC5C,IAAI,IAAI,CAAC,eAAe,EAAE,EAAE,CAAC;gCAC3B,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC;4BAC5B,CAAC;wBACH,CAAC;wBAAC,MAAM,CAAC;4BACP,SAAS;wBACX,CAAC;oBACH,CAAC;oBAED,OAAO;wBACL,OAAO;wBACP,YAAY;wBACZ,MAAM,EAAE,GAAG;wBACX,UAAU,EAAE,OAAO;qBACpB,CAAC;gBACJ,CAAC;gBAED,IAAI,CAAC,CAAC,0BAA0B,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC1C,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,EAAE,CAAC;oBAClC,IAAI,YAAgC,CAAC;oBACrC,IAAI,GAA8B,CAAC;oBACnC,IAAI,OAAkC,CAAC;oBAEvC,IAAI,GAAG,EAAE,CAAC;wBACR,GAAG,GAAG,GAAG,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC;wBACvC,OAAO,GAAG,GAAG,CAAC;wBACd,IAAI,CAAC;4BACH,MAAM,IAAI,GAAG,GAAG,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;4BAC5C,IAAI,IAAI,CAAC,eAAe,EAAE,EAAE,CAAC;gCAC3B,YAAY,GAAG,IAAI,CAAC,KAAK,CAAC;4BAC5B,CAAC;wBACH,CAAC;wBAAC,MAAM,CAAC;4BACP,SAAS;wBACX,CAAC;oBACH,CAAC;oBAED,OAAO;wBACL,OAAO;wBACP,YAAY;wBACZ,MAAM,EAAE,GAAG;wBACX,UAAU,EAAE,OAAO;qBACpB,CAAC;gBACJ,CAAC;gBAED,OAAO;oBACL,OAAO,EAAE,OAAO,CAAC,OAAO,EAAE;iBAC3B,CAAC;YACJ,CAAC;YAED,SAAS,4BAA4B,CACnC,OAA4B,EAC5B,OAA4B;gBAE5B,IAAI,OAAO,CAAC,YAAY,KAAK,SAAS,IAAI,OAAO,CAAC,YAAY,KAAK,SAAS,EAAE,CAAC;oBAC7E,OAAO,OAAO,CAAC,YAAY,KAAK,OAAO,CAAC,YAAY,CAAC;gBACvD,CAAC;gBACD,IAAI,OAAO,CAAC,UAAU,IAAI,OAAO,CAAC,UAAU,IAAI,OAAO,CAAC,UAAU,KAAK,OAAO,CAAC,UAAU,EAAE,CAAC;oBAC1F,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,IAAI,OAAO,CAAC,MAAM,IAAI,OAAO,CAAC,MAAM,IAAI,OAAO,CAAC,MAAM,KAAK,OAAO,CAAC,MAAM,EAAE,CAAC;oBAC1E,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,IAAI,OAAO,CAAC,OAAO,IAAI,OAAO,CAAC,OAAO,IAAI,OAAO,CAAC,OAAO,KAAK,OAAO,CAAC,OAAO,EAAE,CAAC;oBAC9E,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,SAAS,wBAAwB,CAC/B,IAAuB,EACvB,GAAmC,EACnC,CAAgB;gBAEhB,IAAI,OAAO,GAAsB,IAAI,CAAC;gBACtC,OAAO,CAAC,CAAC,yBAAyB,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC5C,OAAO,GAAG,OAAO,CAAC,UAAU,CAAC;gBAC/B,CAAC;gBAED,IAAI,CAAC,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;oBAClE,OAAO,EAAE,eAAe,EAAE,IAAI,EAAE,CAAC;gBACnC,CAAC;gBAED,IAAI,CAAC,CAAC,YAAY,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC5B,MAAM,GAAG,GAAG,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;oBAC/D,OAAO;wBACL,eAAe,EAAE,KAAK;wBACtB,WAAW,EAAE,OAAO,CAAC,IAAI;wBACzB,MAAM,EAAE,GAAG;qBACZ,CAAC;gBACJ,CAAC;gBAED,OAAO;oBACL,eAAe,EAAE,KAAK;oBACtB,WAAW,EAAE,OAAO,CAAC,OAAO,EAAE;oBAC9B,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,SAAS;iBAC3D,CAAC;YACJ,CAAC;YAED,SAAS,oBAAoB,CAC3B,UAAiC,EACjC,UAAiC;gBAEjC,IAAI,UAAU,CAAC,eAAe,IAAI,UAAU,CAAC,eAAe,EAAE,CAAC;oBAC7D,OAAO,KAAK,CAAC;gBACf,CAAC;gBACD,IAAI,UAAU,CAAC,MAAM,IAAI,UAAU,CAAC,MAAM,IAAI,UAAU,CAAC,MAAM,KAAK,UAAU,CAAC,MAAM,EAAE,CAAC;oBACtF,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,IAAI,UAAU,CAAC,WAAW,IAAI,UAAU,CAAC,WAAW,IAAI,UAAU,CAAC,WAAW,KAAK,UAAU,CAAC,WAAW,EAAE,CAAC;oBAC1G,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,SAAS,uBAAuB,CAC9B,IAAuB,EACvB,GAAmC,EACnC,CAAgB;gBAEhB,IAAI,OAAO,GAAsB,IAAI,CAAC;gBACtC,OAAO,CAAC,CAAC,yBAAyB,CAAC,OAAO,CAAC,EAAE,CAAC;oBAC5C,OAAO,GAAG,OAAO,CAAC,UAAU,CAAC;gBAC/B,CAAC;gBACD,MAAM,IAAI,GAAG,OAAO,CAAC,OAAO,EAAE,CAAC;gBAC/B,MAAM,MAAM,GAAG,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,mBAAmB,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;gBAClE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC;YAC1B,CAAC;YAED,SAAS,mBAAmB,CAC1B,SAA+B,EAC/B,SAA+B;gBAE/B,IAAI,SAAS,CAAC,MAAM,IAAI,SAAS,CAAC,MAAM,IAAI,SAAS,CAAC,MAAM,KAAK,SAAS,CAAC,MAAM,EAAE,CAAC;oBAClF,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,OAAO,SAAS,CAAC,IAAI,KAAK,SAAS,CAAC,IAAI,CAAC;YAC3C,CAAC;YAYD,MAAM,YAAY,GAAsB,EAAE,CAAC;YAS3C,MAAM,eAAe,GAAyB,EAAE,CAAC;YACjD,MAAM,sBAAsB,GAAG,IAAI,GAAG,EAAU,CAAC;YACjD,MAAM,wBAAwB,GAAG,IAAI,GAAG,EAAiB,CAAC;YAC1D,IAAI,gBAAgB,GAAG,KAAK,CAAC;YAE7B,SAAS,qBAAqB,CAC5B,UAA6B,EAC7B,GAAmC,EACnC,CAAgB;gBAEhB,IAAI,CAAC,CAAC,0BAA0B,CAAC,UAAU,CAAC,IAAI,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAClF,MAAM,MAAM,GAAG,UAAU,CAAC,UAAU,CAAC;oBACrC,IAAI,oBAAoB,CAAC,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,CAAC;wBACzC,OAAO,MAAM,CAAC;oBAChB,CAAC;gBACH,CAAC;gBAED,IAAI,CAAC,CAAC,YAAY,CAAC,UAAU,CAAC,IAAI,GAAG,EAAE,CAAC;oBACtC,MAAM,GAAG,GAAG,GAAG,CAAC,mBAAmB,CAAC,UAAU,CAAC,CAAC;oBAChD,IAAI,GAAG,EAAE,gBAAgB,IAAI,CAAC,CAAC,qBAAqB,CAAC,GAAG,CAAC,gBAAgB,CAAC,IAAI,GAAG,CAAC,gBAAgB,CAAC,WAAW,EAAE,CAAC;wBAC/G,OAAO,qBAAqB,CAAC,GAAG,CAAC,gBAAgB,CAAC,WAAW,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC;oBACzE,CAAC;gBACH,CAAC;gBAED,OAAO,SAAS,CAAC;YACnB,CAAC;YAED,SAAS,iBAAiB,CAAC,CAAc;gBACvC,8DAA8D;gBAC9D,IAAI,EAAE,IAAI,EAAE,CAAC,gBAAgB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,kBAAkB,EAAE,CAAC;oBACjI,MAAM,MAAM,GAAG,CAAC,CAAC,UAAU,CAAC,UAAU,CAAC;oBACvC,8EAA8E;oBAC9E,IAAI,CAAC,gBAAgB,CAAC,MAAM,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC;wBAC3C,OAAO;oBACT,CAAC;oBAED,MAAM,IAAI,GAAG,CAAC,CAAC,SAAS,CAAC;oBACzB,MAAM,YAAY,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;oBAC7B,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;oBAC3B,IAAI,YAAY,IAAI,UAAU,EAAE,CAAC;wBAC/B,MAAM,UAAU,GAAG,uBAAuB,CAAC,MAAM,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;wBAChE,MAAM,SAAS,GAAG,sBAAsB,CAAC,YAAY,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;wBACpE,MAAM,WAAW,GAAG,wBAAwB,CAAC,UAAU,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;wBAEtE,IAAI,cAAkC,CAAC;wBACvC,IAAI,gBAA2C,CAAC;wBAEhD,mFAAmF;wBACnF,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;wBAC3B,IAAI,UAAU,IAAI,EAAE,CAAC,yBAAyB,CAAC,UAAU,CAAC,EAAE,CAAC;4BAC3D,KAAK,MAAM,IAAI,IAAI,UAAU,CAAC,UAAU,EAAE,CAAC;gCACzC,IAAI,EAAE,CAAC,oBAAoB,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,IAAI,MAAM,IAAI,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oCACrG,MAAM,QAAQ,GAAG,qBAAqB,CAAC,IAAI,CAAC,WAAW,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;oCACtE,IAAI,QAAQ,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,EAAE,CAAC;wCAC1C,cAAc,GAAG,QAAQ,CAAC,IAAI,CAAC;wCAC/B,IAAI,OAAO,EAAE,CAAC;4CACZ,gBAAgB,GAAG,OAAO,CAAC,mBAAmB,CAAC,QAAQ,CAAC,CAAC;wCAC3D,CAAC;oCACH,CAAC;gCACH,CAAC;qCAAM,IAAI,EAAE,CAAC,6BAA6B,CAAC,IAAI,CAAC,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oCACjF,IAAI,OAAO,EAAE,CAAC;wCACZ,MAAM,MAAM,GAAG,OAAO,CAAC,iCAAiC,CAAC,IAAI,CAAC,IAAI,OAAO,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;wCACzG,IAAI,MAAM,EAAE,gBAAgB,IAAI,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,gBAAgB,CAAC,IAAI,MAAM,CAAC,gBAAgB,CAAC,WAAW,EAAE,CAAC;4CACzH,MAAM,QAAQ,GAAG,qBAAqB,CAAC,MAAM,CAAC,gBAAgB,CAAC,WAAW,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;4CACzF,IAAI,QAAQ,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,EAAE,CAAC;gDAC1C,cAAc,GAAG,QAAQ,CAAC,IAAI,CAAC;gDAC/B,gBAAgB,GAAG,OAAO,CAAC,mBAAmB,CAAC,QAAQ,CAAC,CAAC;4CAC3D,CAAC;wCACH,CAAC;oCACH,CAAC;gCACH,CAAC;4BACH,CAAC;wBACH,CAAC;wBAED,YAAY,CAAC,IAAI,CAAC;4BAChB,IAAI,EAAE,CAAC;4BACP,UAAU;4BACV,SAAS;4BACT,WAAW;4BACX,cAAc;4BACd,gBAAgB;yBACjB,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBAED,wEAAwE;gBACxE,IAAI,EAAE,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;oBAClD,MAAM,OAAO,GAAG,CAAC,CAAC,UAAU,CAAC;oBAC7B,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;wBACpE,gBAAgB,GAAG,IAAI,CAAC;wBACxB,kBAAkB,CAAC,OAAO,CAAC,CAAC;oBAC9B,CAAC;gBACH,CAAC;gBAED,yFAAyF;gBACzF,IAAI,EAAE,IAAI,CAAC,KAAK,cAAc,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACvH,OAAO;gBACT,CAAC;gBAED,CAAC,CAAC,YAAY,CAAC,iBAAiB,CAAC,CAAC;YACpC,CAAC;YAED,SAAS,kBAAkB,CAAC,SAAsB;gBAChD,SAAS,WAAW,CAAC,EAAe;oBAClC,+BAA+B;oBAC/B,IAAI,EAAE,IAAI,EAAE,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,qBAAqB,EAAE,CAAC;wBACvI,MAAM,MAAM,GAAG,EAAE,CAAC,UAAU,CAAC,UAAU,CAAC;wBACxC,MAAM,IAAI,GAAG,EAAE,CAAC,SAAS,CAAC;wBAC1B,MAAM,YAAY,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;wBAC7B,MAAM,UAAU,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;wBAC3B,IAAI,YAAY,IAAI,UAAU,EAAE,CAAC;4BAC/B,MAAM,UAAU,GAAG,uBAAuB,CAAC,MAAM,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;4BAChE,MAAM,SAAS,GAAG,sBAAsB,CAAC,YAAY,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;4BACpE,MAAM,WAAW,GAAG,wBAAwB,CAAC,UAAU,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;4BAEtE,eAAe,CAAC,IAAI,CAAC;gCACnB,UAAU;gCACV,SAAS;gCACT,WAAW;6BACZ,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;oBAED,8BAA8B;oBAC9B,IAAI,EAAE,IAAI,EAAE,CAAC,gBAAgB,CAAC,EAAE,CAAC,IAAI,EAAE,CAAC,0BAA0B,CAAC,EAAE,CAAC,UAAU,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;wBACzH,MAAM,aAAa,GAAG,EAAE,CAAC,UAAU,CAAC,UAAU,CAAC;wBAC/C,IAAI,oBAAoB,CAAC,aAAa,EAAE,OAAO,EAAE,EAAE,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,aAAa,CAAC,EAAE,CAAC;4BACvF,sBAAsB,CAAC,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC;4BAC/C,IAAI,OAAO,EAAE,CAAC;gCACZ,MAAM,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,aAAa,CAAC,CAAC;gCACvD,IAAI,GAAG,EAAE,CAAC;oCACR,wBAAwB,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;gCACpC,CAAC;4BACH,CAAC;wBACH,CAAC;oBACH,CAAC;oBAED,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;gBAC/B,CAAC;gBACD,SAAS,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;YACtC,CAAC;YAED,iBAAiB,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;YAEvC,yEAAyE;YACzE,KAAK,MAAM,QAAQ,IAAI,YAAY,EAAE,CAAC;gBACpC,IAAI,WAAW,GAAG,KAAK,CAAC;gBAExB,IAAI,gBAAgB,EAAE,CAAC;oBACrB,2CAA2C;oBAC3C,IAAI,QAAQ,CAAC,gBAAgB,IAAI,wBAAwB,CAAC,GAAG,CAAC,QAAQ,CAAC,gBAAgB,CAAC,EAAE,CAAC;wBACzF,WAAW,GAAG,IAAI,CAAC;oBACrB,CAAC;yBAAM,IAAI,QAAQ,CAAC,cAAc,IAAI,sBAAsB,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,EAAE,CAAC;wBAC1F,WAAW,GAAG,IAAI,CAAC;oBACrB,CAAC;oBAED,uCAAuC;oBACvC,IAAI,CAAC,WAAW,EAAE,CAAC;wBACjB,KAAK,MAAM,GAAG,IAAI,eAAe,EAAE,CAAC;4BAClC,IACE,mBAAmB,CAAC,QAAQ,CAAC,UAAU,EAAE,GAAG,CAAC,UAAU,CAAC;gCACxD,4BAA4B,CAAC,QAAQ,CAAC,SAAS,EAAE,GAAG,CAAC,SAAS,CAAC,EAC/D,CAAC;gCACD,IAAI,QAAQ,CAAC,WAAW,CAAC,eAAe,IAAI,GAAG,CAAC,WAAW,CAAC,eAAe,EAAE,CAAC;oCAC5E,WAAW,GAAG,KAAK,CAAC;gCACtB,CAAC;qCAAM,IAAI,oBAAoB,CAAC,QAAQ,CAAC,WAAW,EAAE,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;oCACvE,WAAW,GAAG,IAAI,CAAC;oCACnB,MAAM;gCACR,CAAC;4BACH,CAAC;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,IAAI,CAAC,WAAW,EAAE,CAAC;oBACjB,MAAM,KAAK,GAAG,kBAAkB,CAAC,QAAQ,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBAC5D,MAAM,SAAS,GAAG,QAAQ,CAAC,WAAW,CAAC,eAAe,IAAI,CAAC,QAAQ,CAAC,cAAc;wBAChF,CAAC,CAAC,6GAA6G;wBAC/G,CAAC,CAAC,gBAAgB;4BAClB,CAAC,CAAC,gGAAgG;4BAClG,CAAC,CAAC,2DAA2D,CAAC;oBAEhE,MAAM,YAAY,GAAG,QAAQ,CAAC,SAAS,CAAC,YAAY,IAAI,QAAQ,CAAC,SAAS,CAAC,OAAO,IAAI,OAAO,CAAC;oBAE9F,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,gCAAgC;wBACxC,QAAQ,EAAE,SAAS;wBACnB,QAAQ,EAAE,OAAO;wBACjB,UAAU,EAAE,MAAM;wBAClB,OAAO,EAAE,yBAAyB,YAAY,kDAAkD;wBAChG,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,SAAS;gCAClB,KAAK;6BACN;yBACF;wBACD,eAAe,EACb,0HAA0H;wBAC5H,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/browser/observerCleanup.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const observerCleanupRule: Rule;
+//# sourceMappingURL=observerCleanup.d.ts.map

package/dist/rules/browser/observerCleanup.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"observerCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/browser/observerCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AA6B7D,eAAO,MAAM,mBAAmB,EAAE,IAsLjC,CAAC"}

package/dist/rules/browser/observerCleanup.js

@@ -0,0 +1,184 @@
+import { getNodeSourceRange, resolveReactHook, isDOMGlobal } from "../../engine/symbols.js";
+const DOM_OBSERVER_NAMES = new Set(["ResizeObserver", "IntersectionObserver", "MutationObserver"]);
+function isDOMObserverClass(node, checker, ts) {
+    if (ts.isIdentifier(node)) {
+        const name = node.text;
+        if (DOM_OBSERVER_NAMES.has(name)) {
+            if (checker) {
+                return isDOMGlobal(node, checker, name) ? name : null;
+            }
+            return name;
+        }
+    }
+    if (ts.isPropertyAccessExpression(node) &&
+        ts.isIdentifier(node.expression) &&
+        (node.expression.text === "window" || node.expression.text === "globalThis")) {
+        const name = node.name.text;
+        if (DOM_OBSERVER_NAMES.has(name)) {
+            return name;
+        }
+    }
+    return null;
+}
+export const observerCleanupRule = {
+    meta: {
+        id: "browser/observer-cleanup",
+        category: "browser",
+        defaultSeverity: "error",
+        defaultConfidence: "high",
+        description: "Detects DOM Observers instantiated in lifecycle hooks without .disconnect() cleanup.",
+        requiresTypeInformation: false,
+    },
+    analyze(context) {
+        const { sourceFile, checker, ts } = context;
+        if (!ts)
+            return;
+        context.visitNodes((node) => {
+            if (!ts.isCallExpression(node))
+                return;
+            let isLifecycleHook = false;
+            if (checker && (resolveReactHook(node, checker, "useEffect") || resolveReactHook(node, checker, "useLayoutEffect"))) {
+                isLifecycleHook = true;
+            }
+            else if (ts.isIdentifier(node.expression) && (node.expression.text === "useEffect" || node.expression.text === "useLayoutEffect")) {
+                isLifecycleHook = true;
+            }
+            if (!isLifecycleHook)
+                return;
+            const effectCallback = node.arguments[0];
+            if (!effectCallback || (!ts.isArrowFunction(effectCallback) && !ts.isFunctionExpression(effectCallback))) {
+                return;
+            }
+            const observers = [];
+            const disconnectedSymbols = new Set();
+            const disconnectedNames = new Set();
+            let hasCleanupReturn = false;
+            function inspectEffectBody(n) {
+                if (ts && ts.isNewExpression(n)) {
+                    const className = isDOMObserverClass(n.expression, checker, ts);
+                    if (className) {
+                        let varName;
+                        let symbol;
+                        const parent = n.parent;
+                        if (parent && ts.isVariableDeclaration(parent) && ts.isIdentifier(parent.name)) {
+                            varName = parent.name.text;
+                            if (checker) {
+                                symbol = checker.getSymbolAtLocation(parent.name);
+                            }
+                        }
+                        else if (parent &&
+                            ts.isBinaryExpression(parent) &&
+                            parent.operatorToken.kind === ts.SyntaxKind.EqualsToken &&
+                            ts.isIdentifier(parent.left)) {
+                            varName = parent.left.text;
+                            if (checker) {
+                                symbol = checker.getSymbolAtLocation(parent.left);
+                            }
+                        }
+                        observers.push({
+                            node: n,
+                            observerName: className,
+                            varName,
+                            symbol,
+                        });
+                    }
+                }
+                // Check for cleanup return
+                if (ts && ts.isReturnStatement(n) && n.expression) {
+                    const retExpr = n.expression;
+                    if (ts.isArrowFunction(retExpr) || ts.isFunctionExpression(retExpr)) {
+                        hasCleanupReturn = true;
+                        inspectCleanupBody(retExpr);
+                    }
+                }
+                if (ts && n !== effectCallback && (ts.isFunctionDeclaration(n) || ts.isArrowFunction(n) || ts.isFunctionExpression(n))) {
+                    return;
+                }
+                n.forEachChild(inspectEffectBody);
+            }
+            function inspectCleanupBody(cleanupFn) {
+                function walkCleanup(cn) {
+                    if (ts &&
+                        ts.isCallExpression(cn) &&
+                        ts.isPropertyAccessExpression(cn.expression) &&
+                        cn.expression.name.text === "disconnect") {
+                        const receiver = cn.expression.expression;
+                        if (ts.isIdentifier(receiver)) {
+                            disconnectedNames.add(receiver.text);
+                            if (checker) {
+                                const sym = checker.getSymbolAtLocation(receiver);
+                                if (sym) {
+                                    disconnectedSymbols.add(sym);
+                                    // Resolve local variable aliases (e.g. const cleanupRef = ro)
+                                    let currentDecl = sym.valueDeclaration;
+                                    while (currentDecl &&
+                                        ts.isVariableDeclaration(currentDecl) &&
+                                        currentDecl.initializer &&
+                                        ts.isIdentifier(currentDecl.initializer)) {
+                                        disconnectedNames.add(currentDecl.initializer.text);
+                                        const originSym = checker.getSymbolAtLocation(currentDecl.initializer);
+                                        if (originSym) {
+                                            disconnectedSymbols.add(originSym);
+                                            currentDecl = originSym.valueDeclaration;
+                                        }
+                                        else {
+                                            break;
+                                        }
+                                    }
+                                    try {
+                                        const aliased = checker.getAliasedSymbol(sym);
+                                        if (aliased)
+                                            disconnectedSymbols.add(aliased);
+                                    }
+                                    catch {
+                                        // Not an aliased symbol
+                                    }
+                                }
+                            }
+                        }
+                    }
+                    cn.forEachChild(walkCleanup);
+                }
+                cleanupFn.forEachChild(walkCleanup);
+            }
+            inspectEffectBody(effectCallback.body);
+            for (const obs of observers) {
+                let isDisconnected = false;
+                if (hasCleanupReturn) {
+                    if (obs.symbol && disconnectedSymbols.has(obs.symbol)) {
+                        isDisconnected = true;
+                    }
+                    else if (obs.varName && disconnectedNames.has(obs.varName)) {
+                        isDisconnected = true;
+                    }
+                }
+                if (!isDisconnected) {
+                    const range = getNodeSourceRange(obs.node, sourceFile);
+                    const detailMsg = !obs.varName
+                        ? `Anonymous ${obs.observerName} instance cannot be disconnected in cleanup.`
+                        : hasCleanupReturn
+                            ? `${obs.observerName} instance '${obs.varName}' is missing matching '${obs.varName}.disconnect()' in cleanup return.`
+                            : "No cleanup function was returned from the lifecycle hook.";
+                    context.report({
+                        ruleId: "browser/observer-cleanup",
+                        category: "browser",
+                        severity: "error",
+                        confidence: "high",
+                        message: `${obs.observerName} instantiated in lifecycle hook without calling .disconnect() in cleanup.`,
+                        file: sourceFile.fileName,
+                        range,
+                        evidence: [
+                            {
+                                message: detailMsg,
+                                range,
+                            },
+                        ],
+                        suggestedAction: `Disconnect the observer in the returned cleanup function: return () => ${obs.varName ?? "observer"}.disconnect();`,
+                        safeAutomaticFix: false,
+                    });
+                }
+            }
+        });
+    },
+};
+//# sourceMappingURL=observerCleanup.js.map

package/dist/rules/browser/observerCleanup.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"observerCleanup.js","sourceRoot":"","sources":["../../../src/rules/browser/observerCleanup.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,kBAAkB,EAAE,gBAAgB,EAAE,WAAW,EAAE,MAAM,yBAAyB,CAAC;AAG5F,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAAC,CAAC,gBAAgB,EAAE,sBAAsB,EAAE,kBAAkB,CAAC,CAAC,CAAC;AAEnG,SAAS,kBAAkB,CAAC,IAAiB,EAAE,OAAuC,EAAE,EAAiB;IACvG,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,EAAE,CAAC;QAC1B,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC;QACvB,IAAI,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACjC,IAAI,OAAO,EAAE,CAAC;gBACZ,OAAO,WAAW,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;YACxD,CAAC;YACD,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IAED,IACE,EAAE,CAAC,0BAA0B,CAAC,IAAI,CAAC;QACnC,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC;QAChC,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,YAAY,CAAC,EAC5E,CAAC;QACD,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;QAC5B,IAAI,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC;YACjC,OAAO,IAAI,CAAC;QACd,CAAC;IACH,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,CAAC,MAAM,mBAAmB,GAAS;IACvC,IAAI,EAAE;QACJ,EAAE,EAAE,0BAA0B;QAC9B,QAAQ,EAAE,SAAS;QACnB,eAAe,EAAE,OAAO;QACxB,iBAAiB,EAAE,MAAM;QACzB,WAAW,EAAE,sFAAsF;QACnG,uBAAuB,EAAE,KAAK;KAC/B;IAED,OAAO,CAAC,OAAoB;QAC1B,MAAM,EAAE,UAAU,EAAE,OAAO,EAAE,EAAE,EAAE,GAAG,OAAO,CAAC;QAC5C,IAAI,CAAC,EAAE;YAAE,OAAO;QAEhB,OAAO,CAAC,UAAU,CAAC,CAAC,IAAiB,EAAE,EAAE;YACvC,IAAI,CAAC,EAAE,CAAC,gBAAgB,CAAC,IAAI,CAAC;gBAAE,OAAO;YAEvC,IAAI,eAAe,GAAG,KAAK,CAAC;YAC5B,IAAI,OAAO,IAAI,CAAC,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,WAAW,CAAC,IAAI,gBAAgB,CAAC,IAAI,EAAE,OAAO,EAAE,iBAAiB,CAAC,CAAC,EAAE,CAAC;gBACpH,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;iBAAM,IAAI,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,WAAW,IAAI,IAAI,CAAC,UAAU,CAAC,IAAI,KAAK,iBAAiB,CAAC,EAAE,CAAC;gBACpI,eAAe,GAAG,IAAI,CAAC;YACzB,CAAC;YAED,IAAI,CAAC,eAAe;gBAAE,OAAO;YAE7B,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;YACzC,IAAI,CAAC,cAAc,IAAI,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,cAAc,CAAC,IAAI,CAAC,EAAE,CAAC,oBAAoB,CAAC,cAAc,CAAC,CAAC,EAAE,CAAC;gBACzG,OAAO;YACT,CAAC;YASD,MAAM,SAAS,GAAuB,EAAE,CAAC;YACzC,MAAM,mBAAmB,GAAG,IAAI,GAAG,EAAiB,CAAC;YACrD,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAU,CAAC;YAC5C,IAAI,gBAAgB,GAAG,KAAK,CAAC;YAE7B,SAAS,iBAAiB,CAAC,CAAc;gBACvC,IAAI,EAAE,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,EAAE,CAAC;oBAChC,MAAM,SAAS,GAAG,kBAAkB,CAAC,CAAC,CAAC,UAAU,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;oBAChE,IAAI,SAAS,EAAE,CAAC;wBACd,IAAI,OAA2B,CAAC;wBAChC,IAAI,MAAiC,CAAC;wBAEtC,MAAM,MAAM,GAAG,CAAC,CAAC,MAAM,CAAC;wBACxB,IAAI,MAAM,IAAI,EAAE,CAAC,qBAAqB,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;4BAC/E,OAAO,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC;4BAC3B,IAAI,OAAO,EAAE,CAAC;gCACZ,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;4BACpD,CAAC;wBACH,CAAC;6BAAM,IACL,MAAM;4BACN,EAAE,CAAC,kBAAkB,CAAC,MAAM,CAAC;4BAC7B,MAAM,CAAC,aAAa,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,WAAW;4BACvD,EAAE,CAAC,YAAY,CAAC,MAAM,CAAC,IAAI,CAAC,EAC5B,CAAC;4BACD,OAAO,GAAG,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC;4BAC3B,IAAI,OAAO,EAAE,CAAC;gCACZ,MAAM,GAAG,OAAO,CAAC,mBAAmB,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;4BACpD,CAAC;wBACH,CAAC;wBAED,SAAS,CAAC,IAAI,CAAC;4BACb,IAAI,EAAE,CAAC;4BACP,YAAY,EAAE,SAAS;4BACvB,OAAO;4BACP,MAAM;yBACP,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBAED,2BAA2B;gBAC3B,IAAI,EAAE,IAAI,EAAE,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,UAAU,EAAE,CAAC;oBAClD,MAAM,OAAO,GAAG,CAAC,CAAC,UAAU,CAAC;oBAC7B,IAAI,EAAE,CAAC,eAAe,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;wBACpE,gBAAgB,GAAG,IAAI,CAAC;wBACxB,kBAAkB,CAAC,OAAO,CAAC,CAAC;oBAC9B,CAAC;gBACH,CAAC;gBAED,IAAI,EAAE,IAAI,CAAC,KAAK,cAAc,IAAI,CAAC,EAAE,CAAC,qBAAqB,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;oBACvH,OAAO;gBACT,CAAC;gBAED,CAAC,CAAC,YAAY,CAAC,iBAAiB,CAAC,CAAC;YACpC,CAAC;YAED,SAAS,kBAAkB,CAAC,SAAsB;gBAChD,SAAS,WAAW,CAAC,EAAe;oBAClC,IACE,EAAE;wBACF,EAAE,CAAC,gBAAgB,CAAC,EAAE,CAAC;wBACvB,EAAE,CAAC,0BAA0B,CAAC,EAAE,CAAC,UAAU,CAAC;wBAC5C,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,KAAK,YAAY,EACxC,CAAC;wBACD,MAAM,QAAQ,GAAG,EAAE,CAAC,UAAU,CAAC,UAAU,CAAC;wBAC1C,IAAI,EAAE,CAAC,YAAY,CAAC,QAAQ,CAAC,EAAE,CAAC;4BAC9B,iBAAiB,CAAC,GAAG,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;4BACrC,IAAI,OAAO,EAAE,CAAC;gCACZ,MAAM,GAAG,GAAG,OAAO,CAAC,mBAAmB,CAAC,QAAQ,CAAC,CAAC;gCAClD,IAAI,GAAG,EAAE,CAAC;oCACR,mBAAmB,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oCAC7B,8DAA8D;oCAC9D,IAAI,WAAW,GAAmC,GAAG,CAAC,gBAAgB,CAAC;oCACvE,OACE,WAAW;wCACX,EAAE,CAAC,qBAAqB,CAAC,WAAW,CAAC;wCACrC,WAAW,CAAC,WAAW;wCACvB,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,WAAW,CAAC,EACxC,CAAC;wCACD,iBAAiB,CAAC,GAAG,CAAC,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;wCACpD,MAAM,SAAS,GAAG,OAAO,CAAC,mBAAmB,CAAC,WAAW,CAAC,WAAW,CAAC,CAAC;wCACvE,IAAI,SAAS,EAAE,CAAC;4CACd,mBAAmB,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;4CACnC,WAAW,GAAG,SAAS,CAAC,gBAAgB,CAAC;wCAC3C,CAAC;6CAAM,CAAC;4CACN,MAAM;wCACR,CAAC;oCACH,CAAC;oCACD,IAAI,CAAC;wCACH,MAAM,OAAO,GAAG,OAAO,CAAC,gBAAgB,CAAC,GAAG,CAAC,CAAC;wCAC9C,IAAI,OAAO;4CAAE,mBAAmB,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;oCAChD,CAAC;oCAAC,MAAM,CAAC;wCACP,wBAAwB;oCAC1B,CAAC;gCACH,CAAC;4BACH,CAAC;wBACH,CAAC;oBACH,CAAC;oBACD,EAAE,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;gBAC/B,CAAC;gBACD,SAAS,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC;YACtC,CAAC;YAED,iBAAiB,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;YAEvC,KAAK,MAAM,GAAG,IAAI,SAAS,EAAE,CAAC;gBAC5B,IAAI,cAAc,GAAG,KAAK,CAAC;gBAE3B,IAAI,gBAAgB,EAAE,CAAC;oBACrB,IAAI,GAAG,CAAC,MAAM,IAAI,mBAAmB,CAAC,GAAG,CAAC,GAAG,CAAC,MAAM,CAAC,EAAE,CAAC;wBACtD,cAAc,GAAG,IAAI,CAAC;oBACxB,CAAC;yBAAM,IAAI,GAAG,CAAC,OAAO,IAAI,iBAAiB,CAAC,GAAG,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,CAAC;wBAC7D,cAAc,GAAG,IAAI,CAAC;oBACxB,CAAC;gBACH,CAAC;gBAED,IAAI,CAAC,cAAc,EAAE,CAAC;oBACpB,MAAM,KAAK,GAAG,kBAAkB,CAAC,GAAG,CAAC,IAAI,EAAE,UAAU,CAAC,CAAC;oBACvD,MAAM,SAAS,GAAG,CAAC,GAAG,CAAC,OAAO;wBAC5B,CAAC,CAAC,aAAa,GAAG,CAAC,YAAY,8CAA8C;wBAC7E,CAAC,CAAC,gBAAgB;4BAClB,CAAC,CAAC,GAAG,GAAG,CAAC,YAAY,cAAc,GAAG,CAAC,OAAO,0BAA0B,GAAG,CAAC,OAAO,mCAAmC;4BACtH,CAAC,CAAC,2DAA2D,CAAC;oBAEhE,OAAO,CAAC,MAAM,CAAC;wBACb,MAAM,EAAE,0BAA0B;wBAClC,QAAQ,EAAE,SAAS;wBACnB,QAAQ,EAAE,OAAO;wBACjB,UAAU,EAAE,MAAM;wBAClB,OAAO,EAAE,GAAG,GAAG,CAAC,YAAY,2EAA2E;wBACvG,IAAI,EAAE,UAAU,CAAC,QAAQ;wBACzB,KAAK;wBACL,QAAQ,EAAE;4BACR;gCACE,OAAO,EAAE,SAAS;gCAClB,KAAK;6BACN;yBACF;wBACD,eAAe,EAAE,0EAA0E,GAAG,CAAC,OAAO,IAAI,UAAU,gBAAgB;wBACpI,gBAAgB,EAAE,KAAK;qBACxB,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;CACF,CAAC"}

package/dist/rules/browser/timerCleanup.d.ts

@@ -0,0 +1,3 @@
+import type { Rule } from "../../core/types.js";
+export declare const timerCleanupRule: Rule;
+//# sourceMappingURL=timerCleanup.d.ts.map

package/dist/rules/browser/timerCleanup.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"timerCleanup.d.ts","sourceRoot":"","sources":["../../../src/rules/browser/timerCleanup.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,IAAI,EAAe,MAAM,qBAAqB,CAAC;AAE7D,eAAO,MAAM,gBAAgB,EAAE,IAgI9B,CAAC"}