smol-symphony 0.2.0 → 0.3.0

package/dist/tests/core/workspace-decide.test.js

@@ -0,0 +1,236 @@
+// Pure unit tests for the workspace-janitor decision core. The function under
+// test is total and synchronous: (WorkspaceObservedState) -> WorkspaceDecision,
+// so no mocks are needed — every input is plain data.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { decideWorkspace } from '../../src/core/reconcile/workspace-decide.js';
+const CLEAN_INSPECT = {
+    head: 'headsha',
+    workspaceBaseSha: 'base-current',
+    hasUncommitted: false,
+    commitsAheadOfBase: 0,
+};
+function base(over = {}) {
+    return {
+        desired: [],
+        observed: [],
+        baseRefSha: null,
+        inspections: {},
+        prMergeState: null,
+        handoffPending: new Set(),
+        ...over,
+    };
+}
+test('orphan dir (not in desired set) is removed with stale_issue reason', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '42', state: 'Todo' }],
+        observed: [
+            { name: '42', path: '/ws/42' },
+            { name: '99', path: '/ws/99' },
+        ],
+    }));
+    const removes = d.actions.filter((a) => a.kind === 'remove_workspace');
+    assert.equal(removes.length, 1);
+    assert.deepEqual(removes[0], { kind: 'remove_workspace', identifier: '99' });
+    // 42 is present and has no dir-missing/create need, so no create either.
+    assert.equal(d.actions.filter((a) => a.kind === 'create_workspace').length, 0);
+});
+test('FAILED handoff: terminal dir with a handoff-pending marker is RETAINED, not reaped (234)', () => {
+    // The Done issue is terminal → not in the desired (active+in-flight) set, so it is a
+    // reap candidate. Its phase-8 push handoff failed and left a marker, so the only copy
+    // of the completed commit lives in the dir: it MUST be retained for recovery.
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '42', state: 'Todo' }],
+        observed: [
+            { name: '42', path: '/ws/42' },
+            { name: '224', path: '/ws/224' }, // terminal Done issue, push failed
+        ],
+        handoffPending: new Set(['224']),
+    }));
+    // No remove for the marked dir; the unmarked-but-wanted dir is untouched too.
+    assert.equal(d.actions.filter((a) => a.kind === 'remove_workspace').length, 0);
+    assert.ok(d.logs.some((l) => l.message.includes('retained') && l.fields?.identifier === '224'), 'expected a retention log line for the marked dir');
+});
+test('SUCCESSFUL handoff (no marker): an un-marked terminal dir still reaps exactly as today (234 no-regression)', () => {
+    // CRITICAL no-leak guard: the normal successful-handoff case carries NO marker, so the
+    // terminal dir reaps within the same window as before — a normal push+PR is unaffected.
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '42', state: 'Todo' }],
+        observed: [
+            { name: '42', path: '/ws/42' },
+            { name: '224', path: '/ws/224' }, // terminal Done issue, push SUCCEEDED → no marker
+        ],
+        handoffPending: new Set(), // no marker for 224
+    }));
+    const removes = d.actions.filter((a) => a.kind === 'remove_workspace');
+    assert.equal(removes.length, 1);
+    assert.deepEqual(removes[0], { kind: 'remove_workspace', identifier: '224' });
+    assert.ok(d.logs.some((l) => l.message.includes('removed') && l.fields?.reason === 'stale_issue'));
+});
+test('desired id with no dir on disk gets create_workspace (raw identifier)', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: 'feat/x', state: 'Todo' }],
+        observed: [],
+    }));
+    const creates = d.actions.filter((a) => a.kind === 'create_workspace');
+    assert.equal(creates.length, 1);
+    // create carries the RAW operator-visible identifier (shell re-sanitizes).
+    assert.deepEqual(creates[0], { kind: 'create_workspace', identifier: 'feat/x' });
+    assert.equal(d.createdCount, 1);
+});
+test('merge-state guard suppresses create when state === prMergeState', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '7', state: 'Merging' }],
+        observed: [],
+        prMergeState: 'Merging',
+    }));
+    assert.equal(d.actions.filter((a) => a.kind === 'create_workspace').length, 0);
+    assert.equal(d.createdCount, 0);
+    assert.ok(d.logs.some((l) => l.message.includes('merge-state guard')));
+});
+test('merge-state guard does NOT suppress create for a different state', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '7', state: 'Todo' }],
+        observed: [],
+        prMergeState: 'Merging',
+    }));
+    assert.equal(d.actions.filter((a) => a.kind === 'create_workspace').length, 1);
+});
+test('null baseRefSha skips drift detection but still reaps orphans', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '1', state: 'Doing' }],
+        observed: [
+            { name: '1', path: '/ws/1' },
+            { name: 'orphan', path: '/ws/orphan' },
+        ],
+        baseRefSha: null,
+        // inspection present but should be ignored because baseRefSha is null
+        inspections: {
+            '1': { head: 'h', workspaceBaseSha: 'old', hasUncommitted: true, commitsAheadOfBase: 3 },
+        },
+    }));
+    assert.equal(d.staleCount, 0);
+    assert.equal(d.stuckCount, 0);
+    assert.equal(d.marks.length, 0);
+    assert.equal(d.actions.filter((a) => a.kind === 'remove_workspace').length, 1);
+});
+test('drift with no agent work to lose => mark_stale', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '5', state: 'Doing' }],
+        observed: [{ name: '5', path: '/ws/5' }],
+        baseRefSha: 'base-current',
+        inspections: {
+            '5': { head: 'h', workspaceBaseSha: 'base-OLD', hasUncommitted: false, commitsAheadOfBase: 0 },
+        },
+    }));
+    assert.equal(d.staleCount, 1);
+    assert.equal(d.stuckCount, 0);
+    assert.equal(d.marks.length, 1);
+    const [staleMark] = d.marks;
+    assert.ok(staleMark);
+    assert.equal(staleMark.status, 'stale');
+    assert.equal(staleMark.identifier, '5');
+    assert.ok(d.lastError && d.lastError.includes('stale'));
+    // non-destructive: no remove action for drift
+    assert.equal(d.actions.length, 0);
+});
+test('drift with uncommitted changes => mark_stuck (reason = uncommitted)', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '6', state: 'Doing' }],
+        observed: [{ name: '6', path: '/ws/6' }],
+        baseRefSha: 'base-current',
+        inspections: {
+            '6': { head: 'h', workspaceBaseSha: 'base-OLD', hasUncommitted: true, commitsAheadOfBase: 0 },
+        },
+    }));
+    assert.equal(d.stuckCount, 1);
+    const [uncommittedMark] = d.marks;
+    assert.ok(uncommittedMark);
+    assert.equal(uncommittedMark.status, 'stuck');
+    assert.equal(uncommittedMark.reason, 'uncommitted changes present');
+    assert.equal(d.actions.length, 0);
+});
+test('drift with commits ahead (no uncommitted) => mark_stuck (reason = commits ahead)', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '8', state: 'Doing' }],
+        observed: [{ name: '8', path: '/ws/8' }],
+        baseRefSha: 'base-current',
+        inspections: {
+            '8': { head: 'h', workspaceBaseSha: 'base-OLD', hasUncommitted: false, commitsAheadOfBase: 2 },
+        },
+    }));
+    assert.equal(d.stuckCount, 1);
+    const [aheadMark] = d.marks;
+    assert.ok(aheadMark);
+    assert.equal(aheadMark.status, 'stuck');
+    assert.equal(aheadMark.reason, '2 commit(s) ahead of base');
+});
+test('matching base SHA, head null, and missing workspaceBaseSha all skip drift', () => {
+    const cases = [
+        CLEAN_INSPECT, // workspaceBaseSha === baseRefSha
+        { head: null, workspaceBaseSha: 'base-OLD', hasUncommitted: true, commitsAheadOfBase: 9 },
+        { head: 'h', workspaceBaseSha: null, hasUncommitted: true, commitsAheadOfBase: 9 },
+    ];
+    for (const inspection of cases) {
+        const d = decideWorkspace(base({
+            desired: [{ identifier: 'x', state: 'Doing' }],
+            observed: [{ name: 'x', path: '/ws/x' }],
+            baseRefSha: 'base-current',
+            inspections: { x: inspection },
+        }));
+        assert.equal(d.staleCount, 0);
+        assert.equal(d.stuckCount, 0);
+        assert.equal(d.marks.length, 0);
+        assert.equal(d.lastError, null);
+    }
+});
+test('missing inspection entry (shell skipped/failed) is treated as ok', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: 'z', state: 'Doing' }],
+        observed: [{ name: 'z', path: '/ws/z' }],
+        baseRefSha: 'base-current',
+        inspections: {}, // no entry for z
+    }));
+    assert.equal(d.marks.length, 0);
+    assert.equal(d.lastError, null);
+});
+test('sanitization: desired identifier maps to sanitized dir name for matching', () => {
+    // dir on disk is the sanitized form; desired carries the raw id.
+    const d = decideWorkspace(base({
+        desired: [{ identifier: 'feat/x', state: 'Todo' }],
+        observed: [{ name: 'feat_x', path: '/ws/feat_x' }],
+    }));
+    // matched -> no remove, no create
+    assert.equal(d.actions.length, 0);
+});
+test('active entry wins over in-flight on key overlap (last-write precedence)', () => {
+    // Shell hands in-flight first, then active (the merged precedence order).
+    // Both sanitize to the same key; the active state must be the one create sees.
+    const d = decideWorkspace(base({
+        desired: [
+            { identifier: '3', state: 'Merging' }, // in-flight target_state
+            { identifier: '3', state: 'Todo' }, // active authoritative state
+        ],
+        observed: [],
+        prMergeState: 'Merging',
+    }));
+    // Because active state (Todo) wins, the merge-state guard does NOT fire.
+    const creates = d.actions.filter((a) => a.kind === 'create_workspace');
+    assert.equal(creates.length, 1);
+    assert.deepEqual(creates[0], { kind: 'create_workspace', identifier: '3' });
+});
+test('clean pass: matching dirs, no drift => empty decision', () => {
+    const d = decideWorkspace(base({
+        desired: [{ identifier: '10', state: 'Doing' }],
+        observed: [{ name: '10', path: '/ws/10' }],
+        baseRefSha: 'base-current',
+        inspections: { '10': CLEAN_INSPECT },
+    }));
+    assert.deepEqual(d.actions, []);
+    assert.deepEqual(d.marks, []);
+    assert.equal(d.staleCount, 0);
+    assert.equal(d.stuckCount, 0);
+    assert.equal(d.createdCount, 0);
+    assert.equal(d.lastError, null);
+});
+//# sourceMappingURL=workspace-decide.test.js.map

package/dist/tests/core/workspace-decide.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"workspace-decide.test.js","sourceRoot":"","sources":["../../../tests/core/workspace-decide.test.ts"],"names":[],"mappings":"AAAA,8EAA8E;AAC9E,gFAAgF;AAChF,sDAAsD;AAEtD,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AAExC,OAAO,EAAE,eAAe,EAAE,MAAM,8CAA8C,CAAC;AAM/E,MAAM,aAAa,GAAwB;IACzC,IAAI,EAAE,SAAS;IACf,gBAAgB,EAAE,cAAc;IAChC,cAAc,EAAE,KAAK;IACrB,kBAAkB,EAAE,CAAC;CACtB,CAAC;AAEF,SAAS,IAAI,CAAC,OAAwC,EAAE;IACtD,OAAO;QACL,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE;QACZ,UAAU,EAAE,IAAI;QAChB,WAAW,EAAE,EAAE;QACf,YAAY,EAAE,IAAI;QAClB,cAAc,EAAE,IAAI,GAAG,EAAU;QACjC,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AAED,IAAI,CAAC,oEAAoE,EAAE,GAAG,EAAE;IAC9E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAC9C,QAAQ,EAAE;YACR,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE;YAC9B,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE;SAC/B;KACF,CAAC,CACH,CAAC;IACF,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC;IACvE,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,CAAC;IAC7E,yEAAyE;IACzE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACjF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,GAAG,EAAE;IACpG,qFAAqF;IACrF,sFAAsF;IACtF,8EAA8E;IAC9E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAC9C,QAAQ,EAAE;YACR,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE;YAC9B,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,EAAE,mCAAmC;SACtE;QACD,cAAc,EAAE,IAAI,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC;KACjC,CAAC,CACH,CAAC;IACF,8EAA8E;IAC9E,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAC/E,MAAM,CAAC,EAAE,CACP,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,UAAU,KAAK,KAAK,CAAC,EACpF,kDAAkD,CACnD,CAAC;AACJ,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,4GAA4G,EAAE,GAAG,EAAE;IACtH,uFAAuF;IACvF,wFAAwF;IACxF,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAC9C,QAAQ,EAAE;YACR,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE;YAC9B,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,EAAE,kDAAkD;SACrF;QACD,cAAc,EAAE,IAAI,GAAG,EAAU,EAAE,oBAAoB;KACxD,CAAC,CACH,CAAC;IACF,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC;IACvE,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,UAAU,EAAE,KAAK,EAAE,CAAC,CAAC;IAC9E,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,MAAM,KAAK,aAAa,CAAC,CAAC,CAAC;AACrG,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;IACjF,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAClD,QAAQ,EAAE,EAAE;KACb,CAAC,CACH,CAAC;IACF,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC;IACvE,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,2EAA2E;IAC3E,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,UAAU,EAAE,QAAQ,EAAE,CAAC,CAAC;IACjF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC;AAClC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,iEAAiE,EAAE,GAAG,EAAE;IAC3E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC;QAChD,QAAQ,EAAE,EAAE;QACZ,YAAY,EAAE,SAAS;KACxB,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAC/E,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC;AACzE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAC5E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAC7C,QAAQ,EAAE,EAAE;QACZ,YAAY,EAAE,SAAS;KACxB,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACjF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+DAA+D,EAAE,GAAG,EAAE;IACzE,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC9C,QAAQ,EAAE;YACR,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE;YAC5B,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,YAAY,EAAE;SACvC;QACD,UAAU,EAAE,IAAI;QAChB,sEAAsE;QACtE,WAAW,EAAE;YACX,GAAG,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,gBAAgB,EAAE,KAAK,EAAE,cAAc,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,EAAE;SACzF;KACF,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACjF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,gDAAgD,EAAE,GAAG,EAAE;IAC1D,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC9C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;QACxC,UAAU,EAAE,cAAc;QAC1B,WAAW,EAAE;YACX,GAAG,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,gBAAgB,EAAE,UAAU,EAAE,cAAc,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,EAAE;SAC/F;KACF,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,SAAS,CAAC,CAAC;IACrB,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACxC,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,UAAU,EAAE,GAAG,CAAC,CAAC;IACxC,MAAM,CAAC,EAAE,CAAC,CAAC,CAAC,SAAS,IAAI,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,OAAO,CAAC,CAAC,CAAC;IACxD,8CAA8C;IAC9C,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACpC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;IAC/E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC9C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;QACxC,UAAU,EAAE,cAAc;QAC1B,WAAW,EAAE;YACX,GAAG,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,gBAAgB,EAAE,UAAU,EAAE,cAAc,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,EAAE;SAC9F;KACF,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC;IAClC,MAAM,CAAC,EAAE,CAAC,eAAe,CAAC,CAAC;IAC3B,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAC9C,MAAM,CAAC,KAAK,CAAC,eAAe,CAAC,MAAM,EAAE,6BAA6B,CAAC,CAAC;IACpE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACpC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kFAAkF,EAAE,GAAG,EAAE;IAC5F,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC9C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;QACxC,UAAU,EAAE,cAAc;QAC1B,WAAW,EAAE;YACX,GAAG,EAAE,EAAE,IAAI,EAAE,GAAG,EAAE,gBAAgB,EAAE,UAAU,EAAE,cAAc,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,EAAE;SAC/F;KACF,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC;IAC5B,MAAM,CAAC,EAAE,CAAC,SAAS,CAAC,CAAC;IACrB,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IACxC,MAAM,CAAC,KAAK,CAAC,SAAS,CAAC,MAAM,EAAE,2BAA2B,CAAC,CAAC;AAC9D,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2EAA2E,EAAE,GAAG,EAAE;IACrF,MAAM,KAAK,GAA0B;QACnC,aAAa,EAAE,kCAAkC;QACjD,EAAE,IAAI,EAAE,IAAI,EAAE,gBAAgB,EAAE,UAAU,EAAE,cAAc,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,EAAE;QACzF,EAAE,IAAI,EAAE,GAAG,EAAE,gBAAgB,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,EAAE;KACnF,CAAC;IACF,KAAK,MAAM,UAAU,IAAI,KAAK,EAAE,CAAC;QAC/B,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;YACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;YAC9C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;YACxC,UAAU,EAAE,cAAc;YAC1B,WAAW,EAAE,EAAE,CAAC,EAAE,UAAU,EAAE;SAC/B,CAAC,CACH,CAAC;QACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;QAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;QAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;IAClC,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,GAAG,EAAE;IAC5E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC9C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,GAAG,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;QACxC,UAAU,EAAE,cAAc;QAC1B,WAAW,EAAE,EAAE,EAAE,iBAAiB;KACnC,CAAC,CACH,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AAClC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0EAA0E,EAAE,GAAG,EAAE;IACpF,iEAAiE;IACjE,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,QAAQ,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;QAClD,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,YAAY,EAAE,CAAC;KACnD,CAAC,CACH,CAAC;IACF,kCAAkC;IAClC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;AACpC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,yEAAyE,EAAE,GAAG,EAAE;IACnF,0EAA0E;IAC1E,+EAA+E;IAC/E,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE;YACP,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,SAAS,EAAE,EAAE,yBAAyB;YAChE,EAAE,UAAU,EAAE,GAAG,EAAE,KAAK,EAAE,MAAM,EAAE,EAAE,6BAA6B;SAClE;QACD,QAAQ,EAAE,EAAE;QACZ,YAAY,EAAE,SAAS;KACxB,CAAC,CACH,CAAC;IACF,yEAAyE;IACzE,MAAM,OAAO,GAAG,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,kBAAkB,CAAC,CAAC;IACvE,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,CAAC;AAC9E,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uDAAuD,EAAE,GAAG,EAAE;IACjE,MAAM,CAAC,GAAG,eAAe,CACvB,IAAI,CAAC;QACH,OAAO,EAAE,CAAC,EAAE,UAAU,EAAE,IAAI,EAAE,KAAK,EAAE,OAAO,EAAE,CAAC;QAC/C,QAAQ,EAAE,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC;QAC1C,UAAU,EAAE,cAAc;QAC1B,WAAW,EAAE,EAAE,IAAI,EAAE,aAAa,EAAE;KACrC,CAAC,CACH,CAAC;IACF,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAChC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,YAAY,EAAE,CAAC,CAAC,CAAC;IAChC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC;AAClC,CAAC,CAAC,CAAC"}

package/dist/tests/helpers/fixtures.js

@@ -0,0 +1,167 @@
+// Shared test-fixture builders (issue 188).
+//
+// The bulk of the jscpd copy-paste sweep (#176) was hand-rolled fixture literals
+// re-typed across many `tests/` files: the same ServiceConfig / Issue / PrView /
+// PrIntent / kill-action shapes inlined file after file. These builders give one
+// canonical default per shape; callers spread their per-test overrides on top so
+// the effective fixture (and therefore every assertion) is unchanged.
+//
+// This module is plain data + pure builders — it is NOT a `*.test.ts` file, so the
+// `node --test` glob never executes it directly; it is only imported by tests.
+// ─── Issue ───────────────────────────────────────────────────────────────────
+/** A minimal valid tracker Issue (active `Todo` state, no blockers). */
+export function makeIssue(over = {}) {
+    return {
+        id: 'iss-1',
+        identifier: 'SYM-1',
+        title: 'a title',
+        description: null,
+        priority: null,
+        state: 'Todo',
+        branch_name: null,
+        url: null,
+        labels: [],
+        blocked_by: [],
+        created_at: null,
+        updated_at: null,
+        ...over,
+    };
+}
+/**
+ * A complete, structurally-valid ServiceConfig with "shell-realistic" defaults
+ * (the values the slice/integration tests use: a `sym:latest` image, 1s ACP
+ * timeouts, a bound HTTP port, an `o/r` repo). Overrides merge one level deep —
+ * each nested section is `{ ...default, ...override }` — so callers only declare
+ * the fields that matter to their assertions.
+ */
+export function makeServiceConfig(o = {}) {
+    return {
+        workflow_path: o.workflow_path ?? '/x/WORKFLOW.md',
+        workflow_dir: o.workflow_dir ?? '/x',
+        tracker: { kind: 'local', states: {}, root: '/trk', ...o.tracker },
+        prompt: { preamble_file: null, footer_file: null, ...o.prompt },
+        polling: { interval_ms: 1000, ...o.polling },
+        workspace: { root: '/ws', base_branch: 'main', github_repo: 'o/r', ...o.workspace },
+        logs: { root: '/logs', ...o.logs },
+        agent: {
+            max_concurrent_agents: 2,
+            max_turns: 8,
+            max_retry_backoff_ms: 1000,
+            memory_admission_enabled: false,
+            host_memory_reserve_mib: 0,
+            circuit_breaker_threshold: 0,
+            ...o.agent,
+        },
+        acp: {
+            adapter: 'claude',
+            model: null,
+            effort: null,
+            shell: 'bash',
+            prompt_timeout_ms: 1000,
+            read_timeout_ms: 1000,
+            stall_timeout_ms: 1000,
+            connect_timeout_ms: 1000,
+            heartbeat_interval_ms: 15000,
+            heartbeat_timeout_ms: 45000,
+            ...o.acp,
+        },
+        gondolin: {
+            image: 'sym:latest',
+            managed_image: false,
+            oci_image: null,
+            oci_pull_policy: 'if-not-present',
+            oci_runtime: null,
+            cpus: 4,
+            mem_mib: 4096,
+            rootfs_size: '3G',
+            volumes: [],
+            forward_env: [],
+            guest_agent_path: '/opt/symphony/vm-agent.mjs',
+            node_bin: 'node',
+            mise: { data_dir: '/home/test/.symphony/mise' },
+            ...o.gondolin,
+        },
+        egress: { allowed_hosts: [], ...o.egress },
+        server: { port: 8787, host: '127.0.0.1', ...o.server },
+        mcp: { enabled: true, host: '127.0.0.1', explicit_host_url: null, ...o.mcp },
+        pr: { enabled: false, poll_interval_ms: 1000, ...o.pr },
+        credentials: { ticker_interval_ms: 0, refresh_margin_ms: 300_000, ...o.credentials },
+        states: o.states ?? {},
+    };
+}
+/**
+ * The "core-minimal" config flavor the pure-core decider tests prefer: a `/wf`
+ * workflow, no image, zeroed ACP timeouts, an ephemeral HTTP port, the in-VM
+ * `symphony-mcp` host, and no GitHub repo. Centralised here so the three callers
+ * (dispatch-config / tick-config / derive) don't re-type the same minimal block.
+ */
+const CORE_PRESET = {
+    workflow_path: '/wf/WORKFLOW.md',
+    workflow_dir: '/wf',
+    tracker: { root: null },
+    workspace: { github_repo: null },
+    agent: { max_concurrent_agents: 4, max_turns: 42, max_retry_backoff_ms: 0 },
+    acp: {
+        prompt_timeout_ms: 0,
+        read_timeout_ms: 0,
+        stall_timeout_ms: 0,
+        connect_timeout_ms: 0,
+        heartbeat_interval_ms: 0,
+        heartbeat_timeout_ms: 0,
+    },
+    gondolin: { image: null, cpus: 1, mem_mib: 1024 },
+    server: { port: null },
+    mcp: { host: 'symphony-mcp' },
+    pr: { poll_interval_ms: 0 },
+};
+/** {@link makeServiceConfig} pre-seeded with {@link CORE_PRESET}; overrides win per section. */
+export function makeCoreServiceConfig(o = {}) {
+    return makeServiceConfig({
+        ...CORE_PRESET,
+        ...o,
+        tracker: { ...CORE_PRESET.tracker, ...o.tracker },
+        workspace: { ...CORE_PRESET.workspace, ...o.workspace },
+        agent: { ...CORE_PRESET.agent, ...o.agent },
+        acp: { ...CORE_PRESET.acp, ...o.acp },
+        gondolin: { ...CORE_PRESET.gondolin, ...o.gondolin },
+        server: { ...CORE_PRESET.server, ...o.server },
+        mcp: { ...CORE_PRESET.mcp, ...o.mcp },
+        pr: { ...CORE_PRESET.pr, ...o.pr },
+    });
+}
+// ─── PR autopilot ────────────────────────────────────────────────────────────
+/** A `merge`-kind PR intent on a `Done` state with a `feat/42` branch. */
+export function makePrIntent(over = {}) {
+    return {
+        identifier: '42',
+        kind: 'merge',
+        state: 'Done',
+        workspace_path: '/ws/42',
+        branch: 'feat/42',
+        base_branch: 'main',
+        ...over,
+    };
+}
+/** An OPEN + MERGEABLE + CLEAN PR view (PR #7, APPROVED, not yet armed). */
+export function makePrView(over = {}) {
+    return {
+        number: 7,
+        url: 'https://example/pr/7',
+        state: 'OPEN',
+        mergeable: 'MERGEABLE',
+        merge_state_status: 'CLEAN',
+        base_ref_name: 'main',
+        base_ref_oid: 'base-sha',
+        head_ref_name: 'feat/42',
+        head_ref_oid: 'head-sha',
+        review_decision: 'APPROVED',
+        auto_merge_armed: false,
+        ...over,
+    };
+}
+// ─── VM reaper ─────────────────────────────────────────────────────────────────
+/** A `kill_session` action targeting a safe non-self pid (4242). */
+export function makeKillAction(over = {}) {
+    return { kind: 'kill_session', pid: 4242, label: 'symphony-42', ...over };
+}
+//# sourceMappingURL=fixtures.js.map

package/dist/tests/helpers/fixtures.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"fixtures.js","sourceRoot":"","sources":["../../../tests/helpers/fixtures.ts"],"names":[],"mappings":"AAAA,4CAA4C;AAC5C,EAAE;AACF,iFAAiF;AACjF,iFAAiF;AACjF,iFAAiF;AACjF,iFAAiF;AACjF,sEAAsE;AACtE,EAAE;AACF,mFAAmF;AACnF,+EAA+E;AAM/E,gFAAgF;AAEhF,wEAAwE;AACxE,MAAM,UAAU,SAAS,CAAC,OAAuB,EAAE;IACjD,OAAO;QACL,EAAE,EAAE,OAAO;QACX,UAAU,EAAE,OAAO;QACnB,KAAK,EAAE,SAAS;QAChB,WAAW,EAAE,IAAI;QACjB,QAAQ,EAAE,IAAI;QACd,KAAK,EAAE,MAAM;QACb,WAAW,EAAE,IAAI;QACjB,GAAG,EAAE,IAAI;QACT,MAAM,EAAE,EAAE;QACV,UAAU,EAAE,EAAE;QACd,UAAU,EAAE,IAAI;QAChB,UAAU,EAAE,IAAI;QAChB,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AA4BD;;;;;;GAMG;AACH,MAAM,UAAU,iBAAiB,CAAC,IAA4B,EAAE;IAC9D,OAAO;QACL,aAAa,EAAE,CAAC,CAAC,aAAa,IAAI,gBAAgB;QAClD,YAAY,EAAE,CAAC,CAAC,YAAY,IAAI,IAAI;QACpC,OAAO,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,CAAC,CAAC,OAAO,EAAE;QAClE,MAAM,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,WAAW,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,MAAM,EAAE;QAC/D,OAAO,EAAE,EAAE,WAAW,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,OAAO,EAAE;QAC5C,SAAS,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,WAAW,EAAE,MAAM,EAAE,WAAW,EAAE,KAAK,EAAE,GAAG,CAAC,CAAC,SAAS,EAAE;QACnF,IAAI,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE;QAClC,KAAK,EAAE;YACL,qBAAqB,EAAE,CAAC;YACxB,SAAS,EAAE,CAAC;YACZ,oBAAoB,EAAE,IAAI;YAC1B,wBAAwB,EAAE,KAAK;YAC/B,uBAAuB,EAAE,CAAC;YAC1B,yBAAyB,EAAE,CAAC;YAC5B,GAAG,CAAC,CAAC,KAAK;SACX;QACD,GAAG,EAAE;YACH,OAAO,EAAE,QAAQ;YACjB,KAAK,EAAE,IAAI;YACX,MAAM,EAAE,IAAI;YACZ,KAAK,EAAE,MAAM;YACb,iBAAiB,EAAE,IAAI;YACvB,eAAe,EAAE,IAAI;YACrB,gBAAgB,EAAE,IAAI;YACtB,kBAAkB,EAAE,IAAI;YACxB,qBAAqB,EAAE,KAAK;YAC5B,oBAAoB,EAAE,KAAK;YAC3B,GAAG,CAAC,CAAC,GAAG;SACT;QACD,QAAQ,EAAE;YACR,KAAK,EAAE,YAAY;YACnB,aAAa,EAAE,KAAK;YACpB,SAAS,EAAE,IAAI;YACf,eAAe,EAAE,gBAAgB;YACjC,WAAW,EAAE,IAAI;YACjB,IAAI,EAAE,CAAC;YACP,OAAO,EAAE,IAAI;YACb,WAAW,EAAE,IAAI;YACjB,OAAO,EAAE,EAAE;YACX,WAAW,EAAE,EAAE;YACf,gBAAgB,EAAE,4BAA4B;YAC9C,QAAQ,EAAE,MAAM;YAChB,IAAI,EAAE,EAAE,QAAQ,EAAE,2BAA2B,EAAE;YAC/C,GAAG,CAAC,CAAC,QAAQ;SACd;QACD,MAAM,EAAE,EAAE,aAAa,EAAE,EAAE,EAAE,GAAG,CAAC,CAAC,MAAM,EAAE;QAC1C,MAAM,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,WAAW,EAAE,GAAG,CAAC,CAAC,MAAM,EAAE;QACtD,GAAG,EAAE,EAAE,OAAO,EAAE,IAAI,EAAE,IAAI,EAAE,WAAW,EAAE,iBAAiB,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,GAAG,EAAE;QAC5E,EAAE,EAAE,EAAE,OAAO,EAAE,KAAK,EAAE,gBAAgB,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,EAAE,EAAE;QACvD,WAAW,EAAE,EAAE,kBAAkB,EAAE,CAAC,EAAE,iBAAiB,EAAE,OAAO,EAAE,GAAG,CAAC,CAAC,WAAW,EAAE;QACpF,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,EAAE;KACvB,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,MAAM,WAAW,GAA2B;IAC1C,aAAa,EAAE,iBAAiB;IAChC,YAAY,EAAE,KAAK;IACnB,OAAO,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE;IACvB,SAAS,EAAE,EAAE,WAAW,EAAE,IAAI,EAAE;IAChC,KAAK,EAAE,EAAE,qBAAqB,EAAE,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,oBAAoB,EAAE,CAAC,EAAE;IAC3E,GAAG,EAAE;QACH,iBAAiB,EAAE,CAAC;QACpB,eAAe,EAAE,CAAC;QAClB,gBAAgB,EAAE,CAAC;QACnB,kBAAkB,EAAE,CAAC;QACrB,qBAAqB,EAAE,CAAC;QACxB,oBAAoB,EAAE,CAAC;KACxB;IACD,QAAQ,EAAE,EAAE,KAAK,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,EAAE,OAAO,EAAE,IAAI,EAAE;IACjD,MAAM,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE;IACtB,GAAG,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE;IAC7B,EAAE,EAAE,EAAE,gBAAgB,EAAE,CAAC,EAAE;CAC5B,CAAC;AAEF,gGAAgG;AAChG,MAAM,UAAU,qBAAqB,CAAC,IAA4B,EAAE;IAClE,OAAO,iBAAiB,CAAC;QACvB,GAAG,WAAW;QACd,GAAG,CAAC;QACJ,OAAO,EAAE,EAAE,GAAG,WAAW,CAAC,OAAO,EAAE,GAAG,CAAC,CAAC,OAAO,EAAE;QACjD,SAAS,EAAE,EAAE,GAAG,WAAW,CAAC,SAAS,EAAE,GAAG,CAAC,CAAC,SAAS,EAAE;QACvD,KAAK,EAAE,EAAE,GAAG,WAAW,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,KAAK,EAAE;QAC3C,GAAG,EAAE,EAAE,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,CAAC,CAAC,GAAG,EAAE;QACrC,QAAQ,EAAE,EAAE,GAAG,WAAW,CAAC,QAAQ,EAAE,GAAG,CAAC,CAAC,QAAQ,EAAE;QACpD,MAAM,EAAE,EAAE,GAAG,WAAW,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,MAAM,EAAE;QAC9C,GAAG,EAAE,EAAE,GAAG,WAAW,CAAC,GAAG,EAAE,GAAG,CAAC,CAAC,GAAG,EAAE;QACrC,EAAE,EAAE,EAAE,GAAG,WAAW,CAAC,EAAE,EAAE,GAAG,CAAC,CAAC,EAAE,EAAE;KACnC,CAAC,CAAC;AACL,CAAC;AAED,gFAAgF;AAEhF,0EAA0E;AAC1E,MAAM,UAAU,YAAY,CAAC,OAA0B,EAAE;IACvD,OAAO;QACL,UAAU,EAAE,IAAI;QAChB,IAAI,EAAE,OAAO;QACb,KAAK,EAAE,MAAM;QACb,cAAc,EAAE,QAAQ;QACxB,MAAM,EAAE,SAAS;QACjB,WAAW,EAAE,MAAM;QACnB,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AAED,4EAA4E;AAC5E,MAAM,UAAU,UAAU,CAAC,OAAwB,EAAE;IACnD,OAAO;QACL,MAAM,EAAE,CAAC;QACT,GAAG,EAAE,sBAAsB;QAC3B,KAAK,EAAE,MAAM;QACb,SAAS,EAAE,WAAW;QACtB,kBAAkB,EAAE,OAAO;QAC3B,aAAa,EAAE,MAAM;QACrB,YAAY,EAAE,UAAU;QACxB,aAAa,EAAE,SAAS;QACxB,YAAY,EAAE,UAAU;QACxB,eAAe,EAAE,UAAU;QAC3B,gBAAgB,EAAE,KAAK;QACvB,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AAED,kFAAkF;AAElF,oEAAoE;AACpE,MAAM,UAAU,cAAc,CAAC,OAAmC,EAAE;IAClE,OAAO,EAAE,IAAI,EAAE,cAAc,EAAE,GAAG,EAAE,IAAI,EAAE,KAAK,EAAE,aAAa,EAAE,GAAG,IAAI,EAAE,CAAC;AAC5E,CAAC"}

package/dist/tests/shell/acp-substrate.test.js

@@ -0,0 +1,101 @@
+// FCIS rewrite — integration tests for the ACP-substrate wiring
+// (src/shell/main-acp.ts), the way the composition root composes it.
+//
+// Proves invariant (d): the ACP interpreter CONSUMES the dial-back stream the
+// runner-populated dispatch context carries. The WS registration (and its token)
+// is created BEFORE the agent launches — by the runner slice, against the SAME
+// AcpWsRegistry the HTTP server exposes on the `/acp` Upgrade (exposed here as
+// `sub.registry`) — so `sessionNew(vmId)` awaits `ctx.accepted` and NEVER registers
+// a second, mismatched token (the late-registration race that rejected the dial-back).
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import {} from 'node:stream';
+import { buildAcpSubstrate } from '../../src/shell/main-acp.js';
+import { AcpWsRegistry } from '../../src/shell/interp/acp-ws.js';
+import { toolCallLifecycle } from '../../src/core/schedule/token-fold.js';
+import { isTransportError, selectPermissionOption } from '../../src/core/runner/turn.js';
+const noopLog = { emit: () => undefined, withIssue() { return noopLog; } };
+const fixedClock = { now: () => 0, iso: () => '1970-01-01T00:00:00.000Z' };
+function noopRunlog() {
+    return {
+        open: () => undefined, setAttempt: () => undefined, record: () => undefined,
+        system: () => undefined, writeSummary: () => undefined, close: () => undefined,
+    };
+}
+function buildWith(registry) {
+    return buildAcpSubstrate({
+        core: { toolCallLifecycle, isTransportError, selectPermissionOption },
+        registry,
+        runlog: noopRunlog(),
+        clock: fixedClock,
+        log: noopLog,
+        readTimeoutMs: () => 1_000,
+        promptTimeoutMs: () => 1_000,
+        connectTimeoutMs: () => 50,
+    });
+}
+test('(d) sessionNew CONSUMES the context dial-back stream and races the connect timeout', async () => {
+    let cancelled = false;
+    const sub = buildWith({ register: () => ({ token: 't', accepted: new Promise(() => { }), cancel: () => { } }) });
+    // The runner registered the WS registration BEFORE launch and carried its never-
+    // resolving dial-back + cancel into the dispatch context. sessionNew must await THAT
+    // stream (not register a new one) → the connect-timeout fires and the context's
+    // own cancelAccept is invoked.
+    sub.context.register('vm-1', {
+        issueId: 'issue-1', identifier: '42', workspacePath: '/ws', mcpServers: [],
+        accepted: new Promise(() => { }),
+        cancelAccept: () => { cancelled = true; },
+    });
+    await assert.rejects(() => sub.port.sessionNew('vm-1', { mcpEnabled: false }), /did not connect in time/);
+    assert.equal(cancelled, true); // cancels the CONTEXT's registration on connect timeout
+});
+test('(d) sessionNew never registers a second token on the WS registry', async () => {
+    const calls = [];
+    // If sessionNew ever called register() again it would mint a SECOND token the guest
+    // never presented (the dial-back-rejection bug). Assert it does NOT touch register().
+    const registry = {
+        register: (issueId, identifier) => {
+            calls.push({ issueId, identifier });
+            return { token: 'tok', accepted: new Promise(() => { }), cancel: () => { } };
+        },
+    };
+    const sub = buildWith(registry);
+    sub.context.register('vm-1', {
+        issueId: 'issue-1', identifier: '42', workspacePath: '/ws', mcpServers: [],
+        accepted: new Promise(() => { }), cancelAccept: () => { },
+    });
+    await assert.rejects(() => sub.port.sessionNew('vm-1', { mcpEnabled: false }), /did not connect in time/);
+    assert.deepEqual(calls, [], 'sessionNew must NOT register a second registration');
+});
+test('(d) the substrate exposes the SAME /acp registry the runner registers EARLY against', () => {
+    // The real registry — the SAME class main.ts constructs as a.acpWs and attaches to
+    // the unified HTTP server's `upgrade` event. The substrate re-exposes it so the
+    // runner slice can register(issueId, identifier) BEFORE bring-up and place the
+    // returned token in the launch env.
+    const realRegistry = new AcpWsRegistry({ log: noopLog });
+    const sub = buildWith(realRegistry);
+    assert.equal(sub.registry, realRegistry);
+    // Registering through it mints a real per-dispatch bearer in that registry's table.
+    const reg = sub.registry.register('i-9', '9');
+    assert.equal(typeof reg.token, 'string');
+    assert.ok(reg.token.length > 0);
+    reg.cancel('cleanup');
+});
+test('(d) sessionNew with no registered dispatch context refuses (unknown vm)', async () => {
+    const sub = buildWith({ register: () => ({ token: 't', accepted: new Promise(() => { }), cancel: () => { } }) });
+    await assert.rejects(() => sub.port.sessionNew('unknown-vm', { mcpEnabled: true }), /no dispatch context/);
+});
+test('the ACP substrate exposes the runner-facing dispatch-context registry', () => {
+    const sub = buildWith({ register: () => ({ token: 't', accepted: new Promise(() => { }), cancel: () => { } }) });
+    sub.context.register('vm-x', {
+        issueId: 'i', identifier: '1', workspacePath: '/w', mcpServers: [],
+        accepted: new Promise(() => { }), cancelAccept: () => { },
+    });
+    assert.ok(sub.context.contextForVm('vm-x'));
+    sub.context.deregister('vm-x');
+    assert.equal(sub.context.contextForVm('vm-x'), undefined);
+    // The port is a real AcpPort.
+    assert.equal(typeof sub.port.sessionNew, 'function');
+    assert.equal(typeof sub.port.onEvent, 'function');
+});
+//# sourceMappingURL=acp-substrate.test.js.map

package/dist/tests/shell/acp-substrate.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"acp-substrate.test.js","sourceRoot":"","sources":["../../../tests/shell/acp-substrate.test.ts"],"names":[],"mappings":"AAAA,gEAAgE;AAChE,qEAAqE;AACrE,EAAE;AACF,8EAA8E;AAC9E,iFAAiF;AACjF,+EAA+E;AAC/E,+EAA+E;AAC/E,oFAAoF;AACpF,uFAAuF;AAEvF,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAe,MAAM,aAAa,CAAC;AAE1C,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,aAAa,EAAE,MAAM,kCAAkC,CAAC;AACjE,OAAO,EAAE,iBAAiB,EAAE,MAAM,uCAAuC,CAAC;AAC1E,OAAO,EAAE,gBAAgB,EAAE,sBAAsB,EAAE,MAAM,+BAA+B,CAAC;AAIzF,MAAM,OAAO,GAAY,EAAE,IAAI,EAAE,GAAG,EAAE,CAAC,SAAS,EAAE,SAAS,KAAK,OAAO,OAAO,CAAC,CAAC,CAAC,EAAE,CAAC;AACpF,MAAM,UAAU,GAAU,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,0BAA0B,EAAE,CAAC;AAElF,SAAS,UAAU;IACjB,OAAO;QACL,IAAI,EAAE,GAAG,EAAE,CAAC,SAAS,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,SAAS,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,SAAS;QAC3E,MAAM,EAAE,GAAG,EAAE,CAAC,SAAS,EAAE,YAAY,EAAE,GAAG,EAAE,CAAC,SAAS,EAAE,KAAK,EAAE,GAAG,EAAE,CAAC,SAAS;KAC/E,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,QAAqB;IACtC,OAAO,iBAAiB,CAAC;QACvB,IAAI,EAAE,EAAE,iBAAiB,EAAE,gBAAgB,EAAE,sBAAsB,EAAE;QACrE,QAAQ;QACR,MAAM,EAAE,UAAU,EAAE;QACpB,KAAK,EAAE,UAAU;QACjB,GAAG,EAAE,OAAO;QACZ,aAAa,EAAE,GAAG,EAAE,CAAC,KAAK;QAC1B,eAAe,EAAE,GAAG,EAAE,CAAC,KAAK;QAC5B,gBAAgB,EAAE,GAAG,EAAE,CAAC,EAAE;KAC3B,CAAC,CAAC;AACL,CAAC;AAED,IAAI,CAAC,oFAAoF,EAAE,KAAK,IAAI,EAAE;IACpG,IAAI,SAAS,GAAG,KAAK,CAAC;IACtB,MAAM,GAAG,GAAG,SAAS,CAAC,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,KAAK,EAAE,GAAG,EAAE,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,GAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC;IACvH,iFAAiF;IACjF,qFAAqF;IACrF,gFAAgF;IAChF,+BAA+B;IAC/B,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,MAAM,EAAE;QAC3B,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,UAAU,EAAE,EAAE;QAC1E,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC;QACvC,YAAY,EAAE,GAAG,EAAE,GAAG,SAAS,GAAG,IAAI,CAAC,CAAC,CAAC;KAC1C,CAAC,CAAC;IAEH,MAAM,MAAM,CAAC,OAAO,CAClB,GAAG,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,EAAE,EAAE,UAAU,EAAE,KAAK,EAAE,CAAC,EACxD,yBAAyB,CAC1B,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,SAAS,EAAE,IAAI,CAAC,CAAC,CAAC,wDAAwD;AACzF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;IAClF,MAAM,KAAK,GAAmD,EAAE,CAAC;IACjE,oFAAoF;IACpF,sFAAsF;IACtF,MAAM,QAAQ,GAAgB;QAC5B,QAAQ,EAAE,CAAC,OAAO,EAAE,UAAU,EAAE,EAAE;YAChC,KAAK,CAAC,IAAI,CAAC,EAAE,OAAO,EAAE,UAAU,EAAE,CAAC,CAAC;YACpC,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,GAAE,CAAC,EAAE,CAAC;QACrF,CAAC;KACF,CAAC;IACF,MAAM,GAAG,GAAG,SAAS,CAAC,QAAQ,CAAC,CAAC;IAChC,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,MAAM,EAAE;QAC3B,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,IAAI,EAAE,aAAa,EAAE,KAAK,EAAE,UAAU,EAAE,EAAE;QAC1E,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,YAAY,EAAE,GAAG,EAAE,GAAE,CAAC;KAChE,CAAC,CAAC;IACH,MAAM,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,UAAU,CAAC,MAAM,EAAE,EAAE,UAAU,EAAE,KAAK,EAAE,CAAC,EAAE,yBAAyB,CAAC,CAAC;IAC1G,MAAM,CAAC,SAAS,CAAC,KAAK,EAAE,EAAE,EAAE,oDAAoD,CAAC,CAAC;AACpF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,qFAAqF,EAAE,GAAG,EAAE;IAC/F,mFAAmF;IACnF,gFAAgF;IAChF,+EAA+E;IAC/E,oCAAoC;IACpC,MAAM,YAAY,GAAG,IAAI,aAAa,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC,CAAC;IACzD,MAAM,GAAG,GAAG,SAAS,CAAC,YAAY,CAAC,CAAC;IACpC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,EAAE,YAAY,CAAC,CAAC;IACzC,oFAAoF;IACpF,MAAM,GAAG,GAAG,GAAG,CAAC,QAAQ,CAAC,QAAQ,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IAC9C,MAAM,CAAC,KAAK,CAAC,OAAO,GAAG,CAAC,KAAK,EAAE,QAAQ,CAAC,CAAC;IACzC,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAChC,GAAG,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC;AACxB,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,yEAAyE,EAAE,KAAK,IAAI,EAAE;IACzF,MAAM,GAAG,GAAG,SAAS,CAAC,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,KAAK,EAAE,GAAG,EAAE,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,GAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC;IACvH,MAAM,MAAM,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,GAAG,CAAC,IAAI,CAAC,UAAU,CAAC,YAAY,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,EAAE,qBAAqB,CAAC,CAAC;AAC7G,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;IACjF,MAAM,GAAG,GAAG,SAAS,CAAC,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,KAAK,EAAE,GAAG,EAAE,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,MAAM,EAAE,GAAG,EAAE,GAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC;IACvH,GAAG,CAAC,OAAO,CAAC,QAAQ,CAAC,MAAM,EAAE;QAC3B,OAAO,EAAE,GAAG,EAAE,UAAU,EAAE,GAAG,EAAE,aAAa,EAAE,IAAI,EAAE,UAAU,EAAE,EAAE;QAClE,QAAQ,EAAE,IAAI,OAAO,CAAS,GAAG,EAAE,GAAE,CAAC,CAAC,EAAE,YAAY,EAAE,GAAG,EAAE,GAAE,CAAC;KAChE,CAAC,CAAC;IACH,MAAM,CAAC,EAAE,CAAC,GAAG,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC,CAAC;IAC5C,GAAG,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;IAC/B,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,OAAO,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,SAAS,CAAC,CAAC;IAC1D,8BAA8B;IAC9B,MAAM,CAAC,KAAK,CAAC,OAAO,GAAG,CAAC,IAAI,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC;IACrD,MAAM,CAAC,KAAK,CAAC,OAAO,GAAG,CAAC,IAAI,CAAC,OAAO,EAAE,UAAU,CAAC,CAAC;AACpD,CAAC,CAAC,CAAC"}