smol-symphony 0.2.0 → 0.3.0

package/dist/tests/core/coerce.test.js

@@ -0,0 +1,87 @@
+// Pure unit tests for src/core/coerce.ts — the canonical scalar coercers.
+// These PIN the behaviours that had silently drifted across the ~5 former core
+// copies (see core/coerce.ts header), so a future re-fork is caught by CI.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { asString, asInt, asIntOr, asStringList, asStringListOr, asNumber, asTimestamp, } from '../../src/core/coerce.js';
+// ─── asString: NO length guard (the http renderer's guard was the drift) ──────
+test('asString: a string passes through unchanged, including the empty string', () => {
+    assert.equal(asString('hi'), 'hi');
+    // The canonical asString has NO `length > 0` guard (the http/render.ts copy
+    // did; the three parse copies did not). Empty string must pass through.
+    assert.equal(asString(''), '');
+});
+test('asString: non-strings (number/null/undefined/object) → null', () => {
+    assert.equal(asString(5), null);
+    assert.equal(asString(null), null);
+    assert.equal(asString(undefined), null);
+    assert.equal(asString({}), null);
+    assert.equal(asString(['a']), null);
+});
+// ─── asInt: isFinite + Math.trunc (NOT Number.isInteger — the issue drift) ────
+test('asInt: a fractional number truncates toward zero (isFinite + trunc)', () => {
+    // The issue/parse.ts copy used Number.isInteger and returned null here; the
+    // canonical (matching the 20+ workflow-config call sites) truncates.
+    assert.equal(asInt(2.5), 2);
+    assert.equal(asInt(-2.9), -2);
+    assert.equal(asInt(2), 2);
+    assert.equal(asInt(2.0), 2);
+});
+test('asInt: a decimal-digit string parses; a non-integer string → null', () => {
+    assert.equal(asInt('42'), 42);
+    assert.equal(asInt('-7'), -7);
+    assert.equal(asInt('3.5'), null); // not a pure integer string
+    assert.equal(asInt('abc'), null);
+});
+test('asInt: Infinity / NaN / non-numbers → null', () => {
+    assert.equal(asInt(Infinity), null);
+    assert.equal(asInt(NaN), null);
+    assert.equal(asInt(null), null);
+    assert.equal(asInt(undefined), null);
+    assert.equal(asInt({}), null);
+});
+test('asIntOr: returns the fallback when uncoercible, else the coerced int', () => {
+    assert.equal(asIntOr(undefined, 30_000), 30_000);
+    assert.equal(asIntOr('nope', 5), 5);
+    assert.equal(asIntOr('12', 5), 12);
+    assert.equal(asIntOr(7.9, 5), 7); // truncates, does NOT fall back
+});
+// ─── asStringList ─────────────────────────────────────────────────────────────
+test('asStringList: keeps only string elements; non-arrays → []', () => {
+    assert.deepEqual(asStringList(['a', 1, 'b', null, 'c']), ['a', 'b', 'c']);
+    assert.deepEqual(asStringList('not an array'), []);
+    assert.deepEqual(asStringList(undefined), []);
+});
+test('asStringListOr: non-array returns the fallback, array is filtered', () => {
+    const fb = ['default'];
+    assert.equal(asStringListOr(undefined, fb), fb); // same ref → fallback
+    assert.deepEqual(asStringListOr(['x', 2], fb), ['x']);
+});
+// ─── asNumber: finite number passes through (no truncation) ───────────────────
+test('asNumber: a finite number (including fractional) passes through; else null', () => {
+    assert.equal(asNumber(2.5), 2.5);
+    assert.equal(asNumber(0), 0);
+    assert.equal(asNumber(Infinity), null);
+    assert.equal(asNumber('5'), null); // strings are not numbers here
+    assert.equal(asNumber(null), null);
+});
+// ─── asTimestamp: folds the old formatTimestamp (empty string → null) ─────────
+test('asTimestamp: a non-empty string passes through; the empty string → null', () => {
+    assert.equal(asTimestamp('2026-01-01T00:00:00.000Z'), '2026-01-01T00:00:00.000Z');
+    // Folds the render.ts formatTimestamp length-guard the bare asTimestamp lacked.
+    assert.equal(asTimestamp(''), null);
+});
+// Core coercers operate over PLAIN DATA only: a `Date` (which the `yaml` lib would
+// auto-decode) is normalized to an ISO string at the SHELL decode boundary
+// (shell/interp/tracker-parse.ts:normalizeDates) BEFORE core sees it — covered by
+// tests/shell/tracker-parse-dates.test.ts. So core's asTimestamp never sees a Date
+// and treats one as a non-string → null.
+test('asTimestamp: a Date is NOT plain data → null (normalized in the shell decode)', () => {
+    assert.equal(asTimestamp(new Date('2026-01-02T03:04:05.000Z')), null);
+});
+test('asTimestamp: non-string → null', () => {
+    assert.equal(asTimestamp(123), null);
+    assert.equal(asTimestamp(null), null);
+    assert.equal(asTimestamp({}), null);
+});
+//# sourceMappingURL=coerce.test.js.map

package/dist/tests/core/coerce.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"coerce.test.js","sourceRoot":"","sources":["../../../tests/core/coerce.test.ts"],"names":[],"mappings":"AAAA,0EAA0E;AAC1E,+EAA+E;AAC/E,2EAA2E;AAE3E,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AAExC,OAAO,EACL,QAAQ,EACR,KAAK,EACL,OAAO,EACP,YAAY,EACZ,cAAc,EACd,QAAQ,EACR,WAAW,GACZ,MAAM,0BAA0B,CAAC;AAElC,iFAAiF;AAEjF,IAAI,CAAC,yEAAyE,EAAE,GAAG,EAAE;IACnF,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;IACnC,4EAA4E;IAC5E,wEAAwE;IACxE,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC;AACjC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC;IAChC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;IACnC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,IAAI,CAAC,CAAC;IACxC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC,CAAC;IACjC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC;AACtC,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;IAC/E,4EAA4E;IAC5E,qEAAqE;IACrE,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;IAC5B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAC1B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAC;AAC9B,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,EAAE,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;IAC9B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,4BAA4B;IAC9D,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,IAAI,CAAC,CAAC;AACnC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,4CAA4C,EAAE,GAAG,EAAE;IACtD,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC;IACpC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,IAAI,CAAC,CAAC;IAC/B,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;IAChC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,SAAS,CAAC,EAAE,IAAI,CAAC,CAAC;IACrC,MAAM,CAAC,KAAK,CAAC,KAAK,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC,CAAC;AAChC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,sEAAsE,EAAE,GAAG,EAAE;IAChF,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,SAAS,EAAE,MAAM,CAAC,EAAE,MAAM,CAAC,CAAC;IACjD,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IACpC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACnC,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,gCAAgC;AACpE,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,IAAI,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACrE,MAAM,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC,GAAG,EAAE,CAAC,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC,EAAE,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,CAAC,CAAC,CAAC;IAC1E,MAAM,CAAC,SAAS,CAAC,YAAY,CAAC,cAAc,CAAC,EAAE,EAAE,CAAC,CAAC;IACnD,MAAM,CAAC,SAAS,CAAC,YAAY,CAAC,SAAS,CAAC,EAAE,EAAE,CAAC,CAAC;AAChD,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,EAAE,GAAG,CAAC,SAAS,CAAC,CAAC;IACvB,MAAM,CAAC,KAAK,CAAC,cAAc,CAAC,SAAS,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,sBAAsB;IACvE,MAAM,CAAC,SAAS,CAAC,cAAc,CAAC,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC;AACxD,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,IAAI,CAAC,4EAA4E,EAAE,GAAG,EAAE;IACtF,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,GAAG,CAAC,CAAC;IACjC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC;IAC7B,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,QAAQ,CAAC,EAAE,IAAI,CAAC,CAAC;IACvC,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,GAAG,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,+BAA+B;IAClE,MAAM,CAAC,KAAK,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;AACrC,CAAC,CAAC,CAAC;AAEH,iFAAiF;AAEjF,IAAI,CAAC,yEAAyE,EAAE,GAAG,EAAE;IACnF,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,0BAA0B,CAAC,EAAE,0BAA0B,CAAC,CAAC;IAClF,gFAAgF;IAChF,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC,CAAC;AACtC,CAAC,CAAC,CAAC;AAEH,mFAAmF;AACnF,2EAA2E;AAC3E,kFAAkF;AAClF,mFAAmF;AACnF,yCAAyC;AACzC,IAAI,CAAC,+EAA+E,EAAE,GAAG,EAAE;IACzF,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,IAAI,CAAC,0BAA0B,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC;AACxE,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC1C,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,GAAG,CAAC,EAAE,IAAI,CAAC,CAAC;IACrC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,IAAI,CAAC,CAAC;IACtC,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,EAAE,CAAC,EAAE,IAAI,CAAC,CAAC;AACtC,CAAC,CAAC,CAAC"}

package/dist/tests/core/context.test.js

@@ -0,0 +1,228 @@
+// Pure unit tests for src/core/actions/context.ts.
+// The module is pure (data-in / data-out), so no mocks are needed.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { deriveActionContext, computeForwardedEnv, isCredentialEnvName, } from '../../src/core/actions/context.js';
+// ─── fixtures ────────────────────────────────────────────────────────────────
+function issue(over = {}) {
+    return {
+        id: 'ISS-42',
+        identifier: 'iss-42',
+        title: 'Fix the widget',
+        description: 'body text',
+        priority: null,
+        state: 'Todo',
+        branch_name: null,
+        url: null,
+        labels: [],
+        blocked_by: [],
+        created_at: null,
+        updated_at: null,
+        ...over,
+    };
+}
+function view(over = {}) {
+    return {
+        issue_id: 'ISS-42',
+        identifier: 'iss-42',
+        issue: issue(),
+        session_id: null,
+        workspace_path: '/ws/iss-42',
+        started_at: '2026-06-02T00:00:00Z',
+        turn_count: 0,
+        retry_attempt: null,
+        input_tokens: 0,
+        output_tokens: 0,
+        total_tokens: 0,
+        last_event: null,
+        last_event_at: null,
+        last_message: null,
+        recent_events: [],
+        last_error: null,
+        transitioned: false,
+        steering_requested: false,
+        steering_question: null,
+        steering_context: null,
+        active_tool_call_count: 0,
+        resolved_actor: 'claude/default',
+        base_branch_at_dispatch: 'main',
+        github_repo_at_dispatch: null,
+        tracker_root_at_dispatch: null,
+        cleanup_workspace_on_exit: false,
+        ...over,
+    };
+}
+// ─── deriveActionContext: all-fallback path (no staged env, no repo) ─────────
+test('deriveActionContext applies every fallback when extraEnv is undefined', () => {
+    const ctx = deriveActionContext({ view: view(), extraEnv: undefined });
+    assert.equal(ctx.identifier, 'iss-42');
+    assert.equal(ctx.workspace, '/ws/iss-42');
+    assert.equal(ctx.branch, 'agent/iss-42');
+    assert.equal(ctx.base_branch, 'main');
+    assert.equal(ctx.issue_title, 'Fix the widget');
+    assert.equal(ctx.issue_body, 'body text');
+    assert.equal(ctx.repo, null);
+    assert.equal(ctx.pr_title, 'ISS-42: Fix the widget');
+    assert.equal(ctx.pr_body_file, '');
+});
+test('deriveActionContext: empty description falls back to empty string', () => {
+    const ctx = deriveActionContext({
+        view: view({ issue: issue({ description: null }) }),
+        extraEnv: undefined,
+    });
+    assert.equal(ctx.issue_body, '');
+});
+// ─── deriveActionContext: staged SYMPHONY_* env wins over fallbacks ──────────
+test('deriveActionContext: staged SYMPHONY_* env overrides every fallback', () => {
+    const ctx = deriveActionContext({
+        view: view(),
+        extraEnv: {
+            SYMPHONY_BRANCH: 'feat/custom',
+            SYMPHONY_BASE_BRANCH: 'develop',
+            SYMPHONY_PR_TITLE: 'Custom PR title',
+            SYMPHONY_PR_BODY_FILE: '/tmp/body.md',
+        },
+    });
+    assert.equal(ctx.branch, 'feat/custom');
+    assert.equal(ctx.base_branch, 'develop');
+    assert.equal(ctx.pr_title, 'Custom PR title');
+    assert.equal(ctx.pr_body_file, '/tmp/body.md');
+});
+// ─── deriveActionContext: pr_title default with untitled issue ───────────────
+test('deriveActionContext: untitled issue → pr_title is just the id', () => {
+    const ctx = deriveActionContext({
+        view: view({ issue: issue({ title: '   ' }) }),
+        extraEnv: undefined,
+    });
+    assert.equal(ctx.pr_title, 'ISS-42');
+});
+// ─── deriveActionContext: repo precedence ────────────────────────────────────
+test('deriveActionContext: repoEnv wins over dispatch-pinned repo', () => {
+    const ctx = deriveActionContext({
+        view: view({ github_repo_at_dispatch: 'org/pinned' }),
+        extraEnv: undefined,
+        repoEnv: 'org/from-env',
+    });
+    assert.equal(ctx.repo, 'org/from-env');
+});
+test('deriveActionContext: empty repoEnv falls through to dispatch-pinned repo', () => {
+    const ctx = deriveActionContext({
+        view: view({ github_repo_at_dispatch: 'org/pinned' }),
+        extraEnv: undefined,
+        repoEnv: '',
+    });
+    assert.equal(ctx.repo, 'org/pinned');
+});
+test('deriveActionContext: no repoEnv and no pinned repo → null', () => {
+    const ctx = deriveActionContext({
+        view: view({ github_repo_at_dispatch: null }),
+        extraEnv: undefined,
+    });
+    assert.equal(ctx.repo, null);
+});
+test('deriveActionContext: unpinned repo falls back to repoDefault (cfg.workspace.github_repo)', () => {
+    const ctx = deriveActionContext({
+        view: view({ github_repo_at_dispatch: null }),
+        extraEnv: undefined,
+        repoDefault: 'org/from-cfg',
+    });
+    assert.equal(ctx.repo, 'org/from-cfg');
+});
+test('deriveActionContext: repoEnv and pinned repo both win over repoDefault', () => {
+    const fromEnv = deriveActionContext({
+        view: view({ github_repo_at_dispatch: null }),
+        extraEnv: undefined,
+        repoEnv: 'org/from-env',
+        repoDefault: 'org/from-cfg',
+    });
+    assert.equal(fromEnv.repo, 'org/from-env');
+    const fromPin = deriveActionContext({
+        view: view({ github_repo_at_dispatch: 'org/pinned' }),
+        extraEnv: undefined,
+        repoDefault: 'org/from-cfg',
+    });
+    assert.equal(fromPin.repo, 'org/pinned');
+});
+test('deriveActionContext: local-only (repoDefault null) keeps repo null', () => {
+    const ctx = deriveActionContext({
+        view: view({ github_repo_at_dispatch: null }),
+        extraEnv: undefined,
+        repoDefault: null,
+    });
+    assert.equal(ctx.repo, null);
+});
+// ─── deriveActionContext: base_branch precedence ─────────────────────────────
+test('deriveActionContext: dispatch-pinned base used when no staged env', () => {
+    const ctx = deriveActionContext({
+        view: view({ base_branch_at_dispatch: 'release/1.x' }),
+        extraEnv: undefined,
+    });
+    assert.equal(ctx.base_branch, 'release/1.x');
+});
+test('deriveActionContext: empty pinned base → literal main', () => {
+    const ctx = deriveActionContext({
+        view: view({ base_branch_at_dispatch: '' }),
+        extraEnv: undefined,
+    });
+    assert.equal(ctx.base_branch, 'main');
+});
+test('deriveActionContext: empty pinned base falls back to baseBranchDefault before main', () => {
+    const ctx = deriveActionContext({
+        view: view({ base_branch_at_dispatch: '' }),
+        extraEnv: undefined,
+        baseBranchDefault: 'develop',
+    });
+    assert.equal(ctx.base_branch, 'develop');
+});
+// ─── computeForwardedEnv: forward only non-empty, non-credential vars ────────
+test('computeForwardedEnv forwards non-empty, non-credential vars', () => {
+    const store = {
+        SYMPHONY_REPO: 'org/repo',
+        HOME: '/home/agent',
+        EMPTY: '',
+    };
+    const out = computeForwardedEnv(['SYMPHONY_REPO', 'HOME', 'EMPTY', 'MISSING'], undefined, (k) => store[k]);
+    assert.deepEqual(out, { SYMPHONY_REPO: 'org/repo', HOME: '/home/agent' });
+});
+test('computeForwardedEnv drops the omitVar', () => {
+    const store = { A: '1', B: '2' };
+    const out = computeForwardedEnv(['A', 'B'], 'B', (k) => store[k]);
+    assert.deepEqual(out, { A: '1' });
+});
+test('computeForwardedEnv strips credential-bearing vars even if listed', () => {
+    const store = {
+        ANTHROPIC_AUTH_TOKEN: 'sk-secret',
+        OPENAI_API_KEY: 'sk-openai',
+        GITHUB_TOKEN: 'ghp-x',
+        MY_API_KEY: 'k',
+        FOO_SECRET: 's',
+        BAR_TOKEN: 't',
+        ANTHROPIC_MODEL: 'claude', // ANTHROPIC_ prefix → stripped by boot-env policy
+        SAFE_VAR: 'ok',
+    };
+    const out = computeForwardedEnv(Object.keys(store), undefined, (k) => store[k]);
+    assert.deepEqual(out, { SAFE_VAR: 'ok' });
+});
+test('computeForwardedEnv: empty forward list yields empty env', () => {
+    const out = computeForwardedEnv([], undefined, () => 'whatever');
+    assert.deepEqual(out, {});
+});
+// ─── isCredentialEnvName: each rule family ───────────────────────────────────
+test('isCredentialEnvName: named set, prefixes, and suffixes', () => {
+    // named set
+    assert.equal(isCredentialEnvName('ANTHROPIC_AUTH_TOKEN'), true);
+    assert.equal(isCredentialEnvName('GH_TOKEN'), true);
+    // vendor prefix families (case-insensitive)
+    assert.equal(isCredentialEnvName('anthropic_model'), true);
+    assert.equal(isCredentialEnvName('OPENAI_BASE_URL'), true);
+    assert.equal(isCredentialEnvName('GITHUB_REPOSITORY'), true);
+    // secret suffix families
+    assert.equal(isCredentialEnvName('VENDOR_API_KEY'), true);
+    assert.equal(isCredentialEnvName('SOME_TOKEN'), true);
+    assert.equal(isCredentialEnvName('A_SECRET'), true);
+    // non-credential
+    assert.equal(isCredentialEnvName('SYMPHONY_REPO'), false);
+    assert.equal(isCredentialEnvName('HOME'), false);
+    assert.equal(isCredentialEnvName('PATH'), false);
+});
+//# sourceMappingURL=context.test.js.map

package/dist/tests/core/context.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"context.test.js","sourceRoot":"","sources":["../../../tests/core/context.test.ts"],"names":[],"mappings":"AAAA,mDAAmD;AACnD,mEAAmE;AAEnE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AACjC,OAAO,MAAM,MAAM,oBAAoB,CAAC;AAExC,OAAO,EACL,mBAAmB,EACnB,mBAAmB,EACnB,mBAAmB,GACpB,MAAM,mCAAmC,CAAC;AAI3C,gFAAgF;AAEhF,SAAS,KAAK,CAAC,OAAuB,EAAE;IACtC,OAAO;QACL,EAAE,EAAE,QAAQ;QACZ,UAAU,EAAE,QAAQ;QACpB,KAAK,EAAE,gBAAgB;QACvB,WAAW,EAAE,WAAW;QACxB,QAAQ,EAAE,IAAI;QACd,KAAK,EAAE,MAAM;QACb,WAAW,EAAE,IAAI;QACjB,GAAG,EAAE,IAAI;QACT,MAAM,EAAE,EAAE;QACV,UAAU,EAAE,EAAE;QACd,UAAU,EAAE,IAAI;QAChB,UAAU,EAAE,IAAI;QAChB,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AAED,SAAS,IAAI,CAAC,OAAkC,EAAE;IAChD,OAAO;QACL,QAAQ,EAAE,QAAQ;QAClB,UAAU,EAAE,QAAQ;QACpB,KAAK,EAAE,KAAK,EAAE;QACd,UAAU,EAAE,IAAI;QAChB,cAAc,EAAE,YAAY;QAC5B,UAAU,EAAE,sBAAsB;QAClC,UAAU,EAAE,CAAC;QACb,aAAa,EAAE,IAAI;QACnB,YAAY,EAAE,CAAC;QACf,aAAa,EAAE,CAAC;QAChB,YAAY,EAAE,CAAC;QACf,UAAU,EAAE,IAAI;QAChB,aAAa,EAAE,IAAI;QACnB,YAAY,EAAE,IAAI;QAClB,aAAa,EAAE,EAAE;QACjB,UAAU,EAAE,IAAI;QAChB,YAAY,EAAE,KAAK;QACnB,kBAAkB,EAAE,KAAK;QACzB,iBAAiB,EAAE,IAAI;QACvB,gBAAgB,EAAE,IAAI;QACtB,sBAAsB,EAAE,CAAC;QACzB,cAAc,EAAE,gBAAgB;QAChC,uBAAuB,EAAE,MAAM;QAC/B,uBAAuB,EAAE,IAAI;QAC7B,wBAAwB,EAAE,IAAI;QAC9B,yBAAyB,EAAE,KAAK;QAChC,GAAG,IAAI;KACR,CAAC;AACJ,CAAC;AAED,gFAAgF;AAEhF,IAAI,CAAC,uEAAuE,EAAE,GAAG,EAAE;IACjF,MAAM,GAAG,GAAG,mBAAmB,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC,CAAC;IACvE,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAC;IACvC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,SAAS,EAAE,YAAY,CAAC,CAAC;IAC1C,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,cAAc,CAAC,CAAC;IACzC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;IACtC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,gBAAgB,CAAC,CAAC;IAChD,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,EAAE,WAAW,CAAC,CAAC;IAC1C,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IAC7B,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,EAAE,wBAAwB,CAAC,CAAC;IACrD,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,YAAY,EAAE,EAAE,CAAC,CAAC;AACrC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,KAAK,EAAE,KAAK,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,CAAC,EAAE,CAAC;QACnD,QAAQ,EAAE,SAAS;KACpB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,UAAU,EAAE,EAAE,CAAC,CAAC;AACnC,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,qEAAqE,EAAE,GAAG,EAAE;IAC/E,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,EAAE;QACZ,QAAQ,EAAE;YACR,eAAe,EAAE,aAAa;YAC9B,oBAAoB,EAAE,SAAS;YAC/B,iBAAiB,EAAE,iBAAiB;YACpC,qBAAqB,EAAE,cAAc;SACtC;KACF,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;IACxC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,SAAS,CAAC,CAAC;IACzC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,EAAE,iBAAiB,CAAC,CAAC;IAC9C,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,YAAY,EAAE,cAAc,CAAC,CAAC;AACjD,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,+DAA+D,EAAE,GAAG,EAAE;IACzE,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,KAAK,EAAE,KAAK,CAAC,EAAE,KAAK,EAAE,KAAK,EAAE,CAAC,EAAE,CAAC;QAC9C,QAAQ,EAAE,SAAS;KACpB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;AACvC,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,YAAY,EAAE,CAAC;QACrD,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,cAAc;KACxB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,cAAc,CAAC,CAAC;AACzC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0EAA0E,EAAE,GAAG,EAAE;IACpF,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,YAAY,EAAE,CAAC;QACrD,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,EAAE;KACZ,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,YAAY,CAAC,CAAC;AACvC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACrE,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,IAAI,EAAE,CAAC;QAC7C,QAAQ,EAAE,SAAS;KACpB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AAC/B,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0FAA0F,EAAE,GAAG,EAAE;IACpG,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,IAAI,EAAE,CAAC;QAC7C,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,cAAc;KAC5B,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,cAAc,CAAC,CAAC;AACzC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,wEAAwE,EAAE,GAAG,EAAE;IAClF,MAAM,OAAO,GAAG,mBAAmB,CAAC;QAClC,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,IAAI,EAAE,CAAC;QAC7C,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,cAAc;QACvB,WAAW,EAAE,cAAc;KAC5B,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,cAAc,CAAC,CAAC;IAC3C,MAAM,OAAO,GAAG,mBAAmB,CAAC;QAClC,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,YAAY,EAAE,CAAC;QACrD,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,cAAc;KAC5B,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,EAAE,YAAY,CAAC,CAAC;AAC3C,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oEAAoE,EAAE,GAAG,EAAE;IAC9E,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,IAAI,EAAE,CAAC;QAC7C,QAAQ,EAAE,SAAS;QACnB,WAAW,EAAE,IAAI;KAClB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AAC/B,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,aAAa,EAAE,CAAC;QACtD,QAAQ,EAAE,SAAS;KACpB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,aAAa,CAAC,CAAC;AAC/C,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uDAAuD,EAAE,GAAG,EAAE;IACjE,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,EAAE,EAAE,CAAC;QAC3C,QAAQ,EAAE,SAAS;KACpB,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;AACxC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,oFAAoF,EAAE,GAAG,EAAE;IAC9F,MAAM,GAAG,GAAG,mBAAmB,CAAC;QAC9B,IAAI,EAAE,IAAI,CAAC,EAAE,uBAAuB,EAAE,EAAE,EAAE,CAAC;QAC3C,QAAQ,EAAE,SAAS;QACnB,iBAAiB,EAAE,SAAS;KAC7B,CAAC,CAAC;IACH,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,WAAW,EAAE,SAAS,CAAC,CAAC;AAC3C,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,MAAM,KAAK,GAA2B;QACpC,aAAa,EAAE,UAAU;QACzB,IAAI,EAAE,aAAa;QACnB,KAAK,EAAE,EAAE;KACV,CAAC;IACF,MAAM,GAAG,GAAG,mBAAmB,CAC7B,CAAC,eAAe,EAAE,MAAM,EAAE,OAAO,EAAE,SAAS,CAAC,EAC7C,SAAS,EACT,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAChB,CAAC;IACF,MAAM,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,aAAa,EAAE,UAAU,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC,CAAC;AAC5E,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,uCAAuC,EAAE,GAAG,EAAE;IACjD,MAAM,KAAK,GAA2B,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC;IACzD,MAAM,GAAG,GAAG,mBAAmB,CAAC,CAAC,GAAG,EAAE,GAAG,CAAC,EAAE,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;IAClE,MAAM,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,CAAC,EAAE,GAAG,EAAE,CAAC,CAAC;AACpC,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,KAAK,GAA2B;QACpC,oBAAoB,EAAE,WAAW;QACjC,cAAc,EAAE,WAAW;QAC3B,YAAY,EAAE,OAAO;QACrB,UAAU,EAAE,GAAG;QACf,UAAU,EAAE,GAAG;QACf,SAAS,EAAE,GAAG;QACd,eAAe,EAAE,QAAQ,EAAE,kDAAkD;QAC7E,QAAQ,EAAE,IAAI;KACf,CAAC;IACF,MAAM,GAAG,GAAG,mBAAmB,CAAC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,SAAS,EAAE,CAAC,CAAC,EAAE,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC;IAChF,MAAM,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;AAC5C,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,0DAA0D,EAAE,GAAG,EAAE;IACpE,MAAM,GAAG,GAAG,mBAAmB,CAAC,EAAE,EAAE,SAAS,EAAE,GAAG,EAAE,CAAC,UAAU,CAAC,CAAC;IACjE,MAAM,CAAC,SAAS,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;AAC5B,CAAC,CAAC,CAAC;AAEH,gFAAgF;AAEhF,IAAI,CAAC,wDAAwD,EAAE,GAAG,EAAE;IAClE,YAAY;IACZ,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,sBAAsB,CAAC,EAAE,IAAI,CAAC,CAAC;IAChE,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,CAAC;IACpD,4CAA4C;IAC5C,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,iBAAiB,CAAC,EAAE,IAAI,CAAC,CAAC;IAC3D,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,iBAAiB,CAAC,EAAE,IAAI,CAAC,CAAC;IAC3D,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,mBAAmB,CAAC,EAAE,IAAI,CAAC,CAAC;IAC7D,yBAAyB;IACzB,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,gBAAgB,CAAC,EAAE,IAAI,CAAC,CAAC;IAC1D,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,YAAY,CAAC,EAAE,IAAI,CAAC,CAAC;IACtD,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,UAAU,CAAC,EAAE,IAAI,CAAC,CAAC;IACpD,iBAAiB;IACjB,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,eAAe,CAAC,EAAE,KAAK,CAAC,CAAC;IAC1D,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC,CAAC;IACjD,MAAM,CAAC,KAAK,CAAC,mBAAmB,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC,CAAC;AACnD,CAAC,CAAC,CAAC"}

package/dist/tests/core/decisions.test.js

@@ -0,0 +1,310 @@
+// PURE unit tests for src/core/http/decisions.ts — node:test + node:assert.
+// No mocks: every function under test is a pure (data) -> data transform.
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { decideCreateIssue, decideMoveTransition, buildIssueDetailDto, } from '../../src/core/http/decisions.js';
+// A representative workflow: Triage (holding) → Todo (active) → InProgress (active)
+// → Done (terminal) → Cancelled (terminal). Declaration order is significant.
+const STATES = [
+    { name: 'Triage', role: 'holding' },
+    { name: 'Todo', role: 'active' },
+    { name: 'InProgress', role: 'active' },
+    { name: 'Done', role: 'terminal' },
+    { name: 'Cancelled', role: 'terminal' },
+];
+// ─── decideCreateIssue ────────────────────────────────────────────────────────
+test('decideCreateIssue: non-object body → 400 bad_request', () => {
+    for (const body of [null, undefined, 42, 'str', ['arr'], true]) {
+        const d = decideCreateIssue(body, STATES);
+        assert.equal(d.ok, false);
+        assert.equal(d.ok === false && d.status, 400);
+        assert.equal(d.ok === false && d.code, 'bad_request');
+    }
+});
+test('decideCreateIssue: missing/blank title → 400', () => {
+    const d = decideCreateIssue({ title: '   ' }, STATES);
+    assert.equal(d.ok, false);
+    assert.equal(d.ok === false && d.message, 'title is required');
+});
+test('decideCreateIssue: defaults state to first active, trims fields, parses optionals', () => {
+    const d = decideCreateIssue({
+        title: '  Fix the bug  ',
+        identifier: '  bug-1 ',
+        description: 'details',
+        priority: 2,
+        labels: ['x', 7, 'y'],
+        blocked_by: ['a', null, 'b'],
+    }, STATES);
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.title, 'Fix the bug');
+    assert.equal(d.identifier, 'bug-1');
+    assert.equal(d.state, 'Todo'); // first active
+    assert.equal(d.description, 'details');
+    assert.equal(d.priority, 2);
+    assert.deepEqual(d.labels, ['x', 'y']); // non-strings filtered
+    assert.deepEqual(d.blocked_by, ['a', 'b']);
+});
+test('decideCreateIssue: explicit holding state is allowed (non-terminal)', () => {
+    const d = decideCreateIssue({ title: 'Idea', state: 'Triage' }, STATES);
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.state, 'Triage');
+});
+test('decideCreateIssue: terminal state is rejected with allowed list', () => {
+    const d = decideCreateIssue({ title: 'X', state: 'Done' }, STATES);
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.status, 400);
+    // allowed = non-terminal names only
+    assert.equal(d.message, 'state must be one of: Triage, Todo, InProgress');
+});
+test('decideCreateIssue: unknown/path-escape state rejected', () => {
+    const d = decideCreateIssue({ title: 'X', state: '../escape' }, STATES);
+    assert.equal(d.ok, false);
+});
+test('decideCreateIssue: no active state declared + no explicit state → state required error', () => {
+    const noActive = [{ name: 'Done', role: 'terminal' }];
+    const d = decideCreateIssue({ title: 'X' }, noActive);
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.message, 'state is required (no active states declared to default to)');
+});
+test('decideCreateIssue: non-finite/non-number priority → null; missing optionals → defaults', () => {
+    const d = decideCreateIssue({ title: 'X', priority: Number.NaN }, STATES);
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.priority, null);
+    assert.equal(d.identifier, ''); // not supplied
+    assert.equal(d.description, undefined);
+    assert.deepEqual(d.labels, []);
+    assert.deepEqual(d.blocked_by, []);
+});
+// ─── decideMoveTransition ─────────────────────────────────────────────────────
+// The operator move replaces the fixed approve/discard pair (issue 126): any
+// declared target, off-flow only WARNED (never blocked), from-state resolved to
+// the file's actual directory (mismatch ⇒ 409).
+// A flow with a declared transition graph so off-flow can be exercised:
+//   Triage (holding, open) → Todo ⇄ Review → Done; Cancelled is a dead-end ([]).
+const FLOW = [
+    { name: 'Triage', role: 'holding', allowed_transitions: null }, // open default
+    { name: 'Todo', role: 'active', allowed_transitions: ['Review', 'Cancelled'] },
+    { name: 'Review', role: 'active', allowed_transitions: ['Todo', 'Done'] },
+    { name: 'Done', role: 'terminal', allowed_transitions: null },
+    { name: 'Cancelled', role: 'terminal', allowed_transitions: [] }, // no transitions out
+];
+test('decideMoveTransition: non-object body → 400 bad_request', () => {
+    for (const body of [null, undefined, 42, 'str', ['arr'], true]) {
+        const d = decideMoveTransition(body, FLOW, 'Todo');
+        assert.equal(d.ok, false);
+        assert.equal(d.ok === false && d.status, 400);
+        assert.equal(d.ok === false && d.code, 'bad_request');
+    }
+});
+test('decideMoveTransition: missing/blank target state → 400 state required', () => {
+    const d = decideMoveTransition({ state: '   ' }, FLOW, 'Todo');
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.status, 400);
+    assert.equal(d.message, 'state is required');
+});
+test('decideMoveTransition: undeclared target → 400 with the declared list', () => {
+    const d = decideMoveTransition({ state: 'Nowhere' }, FLOW, 'Todo');
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.status, 400);
+    assert.equal(d.message, 'state must be one of: Triage, Todo, Review, Done, Cancelled');
+});
+test('decideMoveTransition: case-insensitive target canonicalizes; fromState is the actual dir', () => {
+    // actualFromState is the on-disk directory (here lower-cased), echoed verbatim
+    // so the shell moves the RIGHT file; the target canonicalizes to declared casing.
+    const d = decideMoveTransition({ state: 'review' }, FLOW, 'todo');
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.toState, 'Review');
+    assert.equal(d.fromState, 'todo');
+    assert.equal(d.offFlow, false); // Review ∈ Todo.allowed_transitions
+});
+test('decideMoveTransition: approve-equivalent (Triage → first active) is in-flow', () => {
+    // Triage.allowed_transitions === null ⇒ open default ⇒ in-flow.
+    const d = decideMoveTransition({ state: 'Todo' }, FLOW, 'Triage');
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.toState, 'Todo');
+    assert.equal(d.fromState, 'Triage');
+    assert.equal(d.offFlow, false);
+});
+test('decideMoveTransition: discard-equivalent (Todo → Cancelled) is in-flow when allowed', () => {
+    const d = decideMoveTransition({ state: 'Cancelled' }, FLOW, 'Todo');
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.offFlow, false); // Cancelled ∈ Todo.allowed_transitions
+});
+test('decideMoveTransition: Review → Todo (rework) is in-flow', () => {
+    const d = decideMoveTransition({ state: 'Todo' }, FLOW, 'Review');
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.offFlow, false);
+});
+test('decideMoveTransition: off-flow target still applies but sets offFlow=true', () => {
+    // Todo only declares [Review, Cancelled]; Done is declared but off-flow.
+    const d = decideMoveTransition({ state: 'Done' }, FLOW, 'Todo');
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.toState, 'Done');
+    assert.equal(d.offFlow, true);
+});
+test('decideMoveTransition: an empty allowed_transitions list makes every target off-flow', () => {
+    // Cancelled.allowed_transitions === [] ⇒ no in-flow targets; yanking it back to
+    // Todo is allowed (operator is never blocked) but flagged off-flow.
+    const d = decideMoveTransition({ state: 'Todo' }, FLOW, 'Cancelled');
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.offFlow, true);
+});
+test('decideMoveTransition: a null/open from-state list is in-flow for any declared target', () => {
+    // Triage (open) → Done jumps past the active states yet is in-flow (open default).
+    const d = decideMoveTransition({ state: 'Done' }, FLOW, 'Triage');
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.offFlow, false);
+});
+test('decideMoveTransition: an undeclared (orphan) from-state is in-flow (gate skipped)', () => {
+    const d = decideMoveTransition({ state: 'Todo' }, FLOW, 'Ghost');
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.fromState, 'Ghost');
+    assert.equal(d.offFlow, false);
+});
+test('decideMoveTransition: self-transition is in-flow even from a dead-end state', () => {
+    const d = decideMoveTransition({ state: 'Cancelled' }, FLOW, 'Cancelled');
+    assert.equal(d.ok, true);
+    if (!d.ok)
+        return;
+    assert.equal(d.toState, 'Cancelled');
+    assert.equal(d.offFlow, false);
+});
+test('decideMoveTransition: claimed from_state mismatching the actual dir → 409', () => {
+    const d = decideMoveTransition({ state: 'Review', from_state: 'Triage' }, FLOW, 'Todo');
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.status, 409);
+    assert.equal(d.code, 'from_state_mismatch');
+    assert.match(d.message, /issue is in "Todo", not "Triage"/);
+});
+test('decideMoveTransition: claimed from_state matches the actual dir case-insensitively', () => {
+    const d = decideMoveTransition({ state: 'Review', from_state: 'todo' }, FLOW, 'Todo');
+    assert.equal(d.ok, true);
+    assert.equal(d.ok === true && d.toState, 'Review');
+});
+test('decideMoveTransition: a workflow with no declared states rejects any target (400)', () => {
+    const d = decideMoveTransition({ state: 'X' }, [], 'Todo');
+    assert.equal(d.ok, false);
+    if (d.ok)
+        return;
+    assert.equal(d.message, 'state must be one of: <none configured>');
+});
+// ─── buildIssueDetailDto ──────────────────────────────────────────────────────
+function makeEntry(over = {}) {
+    return {
+        issue_id: 'iss-1',
+        identifier: 'BUG-1',
+        workspace_path: '/ws/BUG-1',
+        session_id: 'sess-9',
+        turn_count: 3,
+        state: 'InProgress',
+        started_at: '2026-06-02T00:00:00.000Z',
+        last_event: 'tool_call',
+        last_message: 'working',
+        last_event_at: '2026-06-02T00:01:00.000Z',
+        input_tokens: 100,
+        output_tokens: 50,
+        total_tokens: 150,
+        recent_events: [],
+        last_error: null,
+        ...over,
+    };
+}
+function makeRetry(over = {}) {
+    return {
+        issue_id: 'iss-1',
+        identifier: 'BUG-1',
+        attempt: 2,
+        due_at_ms: 1_700_000_000_000,
+        error: 'boom',
+        kind: 'failure',
+        ...over,
+    };
+}
+test('buildIssueDetailDto: no entry and no retry → null', () => {
+    assert.equal(buildIssueDetailDto('BUG-1', null, null), null);
+});
+test('buildIssueDetailDto: live entry → status running, running section populated', () => {
+    const dto = buildIssueDetailDto('BUG-1', makeEntry(), null);
+    assert.ok(dto);
+    assert.equal(dto.status, 'running');
+    assert.equal(dto.issue_identifier, 'BUG-1');
+    assert.equal(dto.issue_id, 'iss-1');
+    assert.deepEqual(dto.workspace, { path: '/ws/BUG-1' });
+    assert.equal(dto.attempts.current_retry_attempt, null);
+    assert.equal(dto.retry, null);
+    assert.ok(dto.running);
+    assert.equal(dto.running.session_id, 'sess-9');
+    assert.equal(dto.running.turn_count, 3);
+    assert.deepEqual(dto.running.tokens, {
+        input_tokens: 100,
+        output_tokens: 50,
+        total_tokens: 150,
+    });
+    assert.deepEqual(dto.tracked, {});
+});
+test('buildIssueDetailDto: entry takes precedence over retry (status running)', () => {
+    const dto = buildIssueDetailDto('BUG-1', makeEntry(), makeRetry({ kind: 'continuation' }));
+    assert.ok(dto);
+    // entry present → running even though a continuation retry also exists
+    assert.equal(dto.status, 'running');
+    assert.ok(dto.running);
+    assert.ok(dto.retry); // retry section still rendered
+    // last_error = entry.last_error ?? retry.error ?? null. entry.last_error is
+    // null here so the `??` chain falls through to the retry's error ('boom').
+    assert.equal(dto.last_error, 'boom');
+    // current_retry_attempt still sourced from the retry
+    assert.equal(dto.attempts.current_retry_attempt, 2);
+});
+test('buildIssueDetailDto: entry last_error wins when non-null', () => {
+    const dto = buildIssueDetailDto('BUG-1', makeEntry({ last_error: 'entry-error' }), makeRetry());
+    assert.ok(dto);
+    assert.equal(dto.last_error, 'entry-error');
+});
+test('buildIssueDetailDto: failure retry → status retrying, ISO due_at from due_at_ms', () => {
+    const dto = buildIssueDetailDto('BUG-1', null, makeRetry({ kind: 'failure' }));
+    assert.ok(dto);
+    assert.equal(dto.status, 'retrying');
+    assert.equal(dto.running, null);
+    assert.ok(dto.retry);
+    assert.equal(dto.retry.kind, 'failure');
+    assert.equal(dto.retry.attempt, 2);
+    assert.equal(dto.retry.due_at, new Date(1_700_000_000_000).toISOString());
+    assert.equal(dto.retry.error, 'boom');
+    assert.equal(dto.last_error, 'boom');
+    assert.equal(dto.attempts.current_retry_attempt, 2);
+});
+test('buildIssueDetailDto: continuation retry → status resuming (the pill collapse case)', () => {
+    const dto = buildIssueDetailDto('BUG-1', null, makeRetry({ kind: 'continuation', error: null }));
+    assert.ok(dto);
+    assert.equal(dto.status, 'resuming');
+    assert.equal(dto.last_error, null);
+});
+test('buildIssueDetailDto: issue_id falls back to retry when no entry', () => {
+    const dto = buildIssueDetailDto('BUG-1', null, makeRetry({ issue_id: 'retry-id' }));
+    assert.ok(dto);
+    assert.equal(dto.issue_id, 'retry-id');
+    assert.deepEqual(dto.recent_events, []);
+});
+//# sourceMappingURL=decisions.test.js.map