skyloom 1.12.0 → 1.13.0

package/tests/semantic.test.ts

@@ -1,83 +1,83 @@
-/**
- * Tests for lightweight semantic retrieval.
- */
-import { describe, it, expect } from 'vitest';
-import { SemanticScorer, getScorer } from '../src/core/semantic';
-
-describe('SemanticScorer', () => {
-  const scorer = new SemanticScorer();
-
-  it('identical strings score 1.0', () => {
-    expect(scorer.similarity('hello world', 'hello world')).toBe(1.0);
-  });
-
-  it('completely different strings score 0.0', () => {
-    expect(scorer.similarity('aaaaa', 'bbbbb')).toBe(0.0);
-  });
-
-  it('partial overlap scores between 0 and 1', () => {
-    const score = scorer.similarity('deploy to server', 'deployment script');
-    expect(score).toBeGreaterThan(0.0);
-    expect(score).toBeLessThan(1.0);
-  });
-
-  it('CJK similarity works', () => {
-    const score = scorer.similarity('部署', '部署命令');
-    expect(score).toBeGreaterThan(0.0);
-  });
-
-  it('empty strings return 0', () => {
-    expect(scorer.similarity('', 'hello')).toBe(0.0);
-    expect(scorer.similarity('hello', '')).toBe(0.0);
-    expect(scorer.similarity('', '')).toBe(0.0);
-  });
-
-  it('case insensitive', () => {
-    expect(scorer.similarity('Hello World', 'hello world')).toBe(1.0);
-  });
-
-  it('mixed language overlap', () => {
-    const score = scorer.similarity('pnpm install', 'pnpm 安装');
-    expect(score).toBeGreaterThan(0.0);
-  });
-
-  it('code identifiers match partially', () => {
-    const score = scorer.similarity('snake_case_var', 'snakeCaseVar');
-    expect(score).toBeGreaterThan(0.0);
-  });
-
-  it('rank returns ordered results', () => {
-    const candidates = [
-      { key: 'k1', value: 'deploy to production' },
-      { key: 'k2', value: 'install dependencies' },
-      { key: 'k3', value: 'rollback version' },
-    ];
-    const ranked = scorer.rank('deploy', candidates, 'value', 2);
-    expect(ranked.length).toBeLessThanOrEqual(2);
-    expect(ranked[0][1].key).toBe('k1');
-  });
-
-  it('rank filters below minScore', () => {
-    const candidates = [
-      { key: 'k1', value: 'completely unrelated text here' },
-    ];
-    const ranked = scorer.rank('zzzzz', candidates, 'value', 1, 0.5);
-    expect(ranked).toHaveLength(0);
-  });
-
-  it('rank uses key field boost', () => {
-    const candidates = [
-      { key: 'deploy_command', value: 'npm run build' },
-    ];
-    const ranked = scorer.rank('deploy', candidates, 'value', 1);
-    expect(ranked).toHaveLength(1);
-  });
-});
-
-describe('getScorer singleton', () => {
-  it('returns the same instance', () => {
-    const s1 = getScorer();
-    const s2 = getScorer();
-    expect(s1).toBe(s2);
-  });
-});
+/**
+ * Tests for lightweight semantic retrieval.
+ */
+import { describe, it, expect } from 'vitest';
+import { SemanticScorer, getScorer } from '../src/core/semantic';
+
+describe('SemanticScorer', () => {
+  const scorer = new SemanticScorer();
+
+  it('identical strings score 1.0', () => {
+    expect(scorer.similarity('hello world', 'hello world')).toBe(1.0);
+  });
+
+  it('completely different strings score 0.0', () => {
+    expect(scorer.similarity('aaaaa', 'bbbbb')).toBe(0.0);
+  });
+
+  it('partial overlap scores between 0 and 1', () => {
+    const score = scorer.similarity('deploy to server', 'deployment script');
+    expect(score).toBeGreaterThan(0.0);
+    expect(score).toBeLessThan(1.0);
+  });
+
+  it('CJK similarity works', () => {
+    const score = scorer.similarity('部署', '部署命令');
+    expect(score).toBeGreaterThan(0.0);
+  });
+
+  it('empty strings return 0', () => {
+    expect(scorer.similarity('', 'hello')).toBe(0.0);
+    expect(scorer.similarity('hello', '')).toBe(0.0);
+    expect(scorer.similarity('', '')).toBe(0.0);
+  });
+
+  it('case insensitive', () => {
+    expect(scorer.similarity('Hello World', 'hello world')).toBe(1.0);
+  });
+
+  it('mixed language overlap', () => {
+    const score = scorer.similarity('pnpm install', 'pnpm 安装');
+    expect(score).toBeGreaterThan(0.0);
+  });
+
+  it('code identifiers match partially', () => {
+    const score = scorer.similarity('snake_case_var', 'snakeCaseVar');
+    expect(score).toBeGreaterThan(0.0);
+  });
+
+  it('rank returns ordered results', () => {
+    const candidates = [
+      { key: 'k1', value: 'deploy to production' },
+      { key: 'k2', value: 'install dependencies' },
+      { key: 'k3', value: 'rollback version' },
+    ];
+    const ranked = scorer.rank('deploy', candidates, 'value', 2);
+    expect(ranked.length).toBeLessThanOrEqual(2);
+    expect(ranked[0][1].key).toBe('k1');
+  });
+
+  it('rank filters below minScore', () => {
+    const candidates = [
+      { key: 'k1', value: 'completely unrelated text here' },
+    ];
+    const ranked = scorer.rank('zzzzz', candidates, 'value', 1, 0.5);
+    expect(ranked).toHaveLength(0);
+  });
+
+  it('rank uses key field boost', () => {
+    const candidates = [
+      { key: 'deploy_command', value: 'npm run build' },
+    ];
+    const ranked = scorer.rank('deploy', candidates, 'value', 1);
+    expect(ranked).toHaveLength(1);
+  });
+});
+
+describe('getScorer singleton', () => {
+  it('returns the same instance', () => {
+    const s1 = getScorer();
+    const s2 = getScorer();
+    expect(s1).toBe(s2);
+  });
+});

package/tests/setup.ts

@@ -1,10 +1,10 @@
-/**
- * Test setup — global fixtures and mocks for Skyloom tests.
- */
-import { vi, beforeEach } from 'vitest';
-import { MessageBus } from '../src/core/bus';
-
-// Clear tool state before each test
-beforeEach(() => {
-  // No-op — individual tests handle their own setup
-});
+/**
+ * Test setup — global fixtures and mocks for Skyloom tests.
+ */
+import { vi, beforeEach } from 'vitest';
+import { MessageBus } from '../src/core/bus';
+
+// Clear tool state before each test
+beforeEach(() => {
+  // No-op — individual tests handle their own setup
+});

package/tests/skill.test.ts

@@ -1,172 +1,172 @@
-/**
- * Tests for skill system.
- */
-import { describe, it, expect } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-
-describe('Skill', () => {
-  it('creates a skill with model override', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const skill = new Skill({
-      name: 'test_skill',
-      description: 'A test skill',
-      model: 'claude-opus-4-7',
-    });
-    expect(skill.model).toBe('claude-opus-4-7');
-    expect(skill.temperature).toBeNull();
-    expect(skill.maxTokens).toBeNull();
-  });
-
-  it('creates a skill with temperature override', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const skill = new Skill({ name: 'test_skill', description: 'A test skill', temperature: 0.3 });
-    expect(skill.temperature).toBe(0.3);
-  });
-
-  it('creates a skill with max_tokens override', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const skill = new Skill({ name: 'test_skill', description: 'A test skill', maxTokens: 32000 });
-    expect(skill.maxTokens).toBe(32000);
-  });
-
-  it('default has no overrides', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const skill = new Skill({ name: 'test', description: 'test' });
-    expect(skill.model).toBeNull();
-    expect(skill.temperature).toBeNull();
-    expect(skill.maxTokens).toBeNull();
-  });
-});
-
-describe('Skill.fromMarkdown', () => {
-  it('loads skill with YAML frontmatter', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const tmpDir = fs.mkdtempSync('skill-test-');
-    const mdPath = path.join(tmpDir, 'test.md');
-    fs.writeFileSync(mdPath, `---
-name: test_skill
-description: A test
-model: claude-sonnet-4-6
-temperature: 0.5
-max_tokens: 8192
----
-
-## Test Skill
-This is a test skill.
-`, 'utf-8');
-
-    const skill = Skill.fromMarkdown(mdPath);
-    expect(skill).not.toBeNull();
-    if (skill) {
-      expect(skill.model).toBe('claude-sonnet-4-6');
-      expect(skill.temperature).toBe(0.5);
-      expect(skill.maxTokens).toBe(8192);
-      expect(skill.systemPrompt).toContain('This is a test skill');
-    }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  });
-
-  it('supports string path', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const tmpDir = fs.mkdtempSync('skill-test-');
-    const mdPath = path.join(tmpDir, 'x.md');
-    fs.writeFileSync(mdPath, '---\nname: x\ndescription: x\n---\n\nBody.', 'utf-8');
-    const s = Skill.fromMarkdown(mdPath);
-    expect(s).not.toBeNull();
-    if (s) {
-      expect(s.name).toBe('x');
-      expect(typeof s.sourcePath).toBe('string');
-    }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  });
-
-  it('derives triggers from quoted descriptions', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const tmpDir = fs.mkdtempSync('skill-test-');
-    const mdPath = path.join(tmpDir, 'pptx.md');
-    fs.writeFileSync(mdPath, `---
-name: pptx
-description: |-
-  Use this skill any time a .pptx file is involved.
-  Trigger whenever the user mentions "deck," "slides," or "presentation."
-  If a .pptx file needs to be opened, use it.
----
-Body.`, 'utf-8');
-
-    const s = Skill.fromMarkdown(mdPath);
-    expect(s).not.toBeNull();
-    if (s) {
-      const triggersLower = s.triggers.map(t => t.toLowerCase());
-      expect(triggersLower).toContain('deck');
-      expect(triggersLower).toContain('slides');
-      expect(triggersLower).toContain('presentation');
-      expect(triggersLower).toContain('.pptx');
-    }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  });
-
-  it('small body loaded in full', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const tmpDir = fs.mkdtempSync('skill-test-');
-    const mdPath = path.join(tmpDir, 'small.md');
-    fs.writeFileSync(mdPath, '---\nname: small\ndescription: x\n---\n\n# Small Skill\n\nThis fits inline easily.', 'utf-8');
-    const s = Skill.fromMarkdown(mdPath);
-    expect(s).not.toBeNull();
-    if (s) {
-      expect(s.bodyTruncated).toBe(false);
-      expect(s.systemPrompt).toContain('This fits inline easily');
-    }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  });
-
-  it('large body truncated to head', async () => {
-    const { Skill } = await import('../src/core/skill');
-    const tmpDir = fs.mkdtempSync('skill-test-');
-    const mdPath = path.join(tmpDir, 'big.md');
-
-    let body = '# Big Skill\n\n## Quick Reference\nFirst section content.\n\n';
-    body += '## Detailed Guide\n';
-    body += 'X'.repeat(5000);
-
-    fs.writeFileSync(mdPath, `---\nname: big\ndescription: x\n---\n\n${body}`, 'utf-8');
-    const s = Skill.fromMarkdown(mdPath);
-    expect(s).not.toBeNull();
-    if (s) {
-      expect(s.bodyTruncated).toBe(true);
-      expect(s.systemPrompt).toContain('Big Skill');
-      expect(s.systemPrompt).toContain('Quick Reference');
-      expect(s.systemPrompt).not.toContain('Detailed Guide');
-    }
-    fs.rmSync(tmpDir, { recursive: true, force: true });
-  });
-});
-
-describe('SkillRegistry', () => {
-  it('registers and retrieves skills', async () => {
-    const { Skill, SkillRegistry } = await import('../src/core/skill');
-    const reg = new SkillRegistry();
-    const skill = new Skill({ name: 'test', description: 'Test' });
-    reg.register(skill);
-    expect(reg.get('test')).toBe(skill);
-    expect(reg.get('missing')).toBeUndefined();
-  });
-
-  it('lists names', async () => {
-    const { Skill, SkillRegistry } = await import('../src/core/skill');
-    const reg = new SkillRegistry();
-    reg.register(new Skill({ name: 'a', description: 'A' }));
-    reg.register(new Skill({ name: 'b', description: 'B' }));
-    expect(reg.listNames()).toEqual(['a', 'b']);
-  });
-
-  it('merges registries', async () => {
-    const { Skill, SkillRegistry } = await import('../src/core/skill');
-    const r1 = new SkillRegistry();
-    r1.register(new Skill({ name: 'a', description: 'A' }));
-    const r2 = new SkillRegistry();
-    r2.register(new Skill({ name: 'b', description: 'B' }));
-    r1.merge(r2);
-    expect(r1.get('b')).toBeDefined();
-  });
-});
+/**
+ * Tests for skill system.
+ */
+import { describe, it, expect } from 'vitest';
+import * as fs from 'fs';
+import * as path from 'path';
+
+describe('Skill', () => {
+  it('creates a skill with model override', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const skill = new Skill({
+      name: 'test_skill',
+      description: 'A test skill',
+      model: 'claude-opus-4-7',
+    });
+    expect(skill.model).toBe('claude-opus-4-7');
+    expect(skill.temperature).toBeNull();
+    expect(skill.maxTokens).toBeNull();
+  });
+
+  it('creates a skill with temperature override', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const skill = new Skill({ name: 'test_skill', description: 'A test skill', temperature: 0.3 });
+    expect(skill.temperature).toBe(0.3);
+  });
+
+  it('creates a skill with max_tokens override', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const skill = new Skill({ name: 'test_skill', description: 'A test skill', maxTokens: 32000 });
+    expect(skill.maxTokens).toBe(32000);
+  });
+
+  it('default has no overrides', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const skill = new Skill({ name: 'test', description: 'test' });
+    expect(skill.model).toBeNull();
+    expect(skill.temperature).toBeNull();
+    expect(skill.maxTokens).toBeNull();
+  });
+});
+
+describe('Skill.fromMarkdown', () => {
+  it('loads skill with YAML frontmatter', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const tmpDir = fs.mkdtempSync('skill-test-');
+    const mdPath = path.join(tmpDir, 'test.md');
+    fs.writeFileSync(mdPath, `---
+name: test_skill
+description: A test
+model: claude-sonnet-4-6
+temperature: 0.5
+max_tokens: 8192
+---
+
+## Test Skill
+This is a test skill.
+`, 'utf-8');
+
+    const skill = Skill.fromMarkdown(mdPath);
+    expect(skill).not.toBeNull();
+    if (skill) {
+      expect(skill.model).toBe('claude-sonnet-4-6');
+      expect(skill.temperature).toBe(0.5);
+      expect(skill.maxTokens).toBe(8192);
+      expect(skill.systemPrompt).toContain('This is a test skill');
+    }
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+  });
+
+  it('supports string path', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const tmpDir = fs.mkdtempSync('skill-test-');
+    const mdPath = path.join(tmpDir, 'x.md');
+    fs.writeFileSync(mdPath, '---\nname: x\ndescription: x\n---\n\nBody.', 'utf-8');
+    const s = Skill.fromMarkdown(mdPath);
+    expect(s).not.toBeNull();
+    if (s) {
+      expect(s.name).toBe('x');
+      expect(typeof s.sourcePath).toBe('string');
+    }
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+  });
+
+  it('derives triggers from quoted descriptions', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const tmpDir = fs.mkdtempSync('skill-test-');
+    const mdPath = path.join(tmpDir, 'pptx.md');
+    fs.writeFileSync(mdPath, `---
+name: pptx
+description: |-
+  Use this skill any time a .pptx file is involved.
+  Trigger whenever the user mentions "deck," "slides," or "presentation."
+  If a .pptx file needs to be opened, use it.
+---
+Body.`, 'utf-8');
+
+    const s = Skill.fromMarkdown(mdPath);
+    expect(s).not.toBeNull();
+    if (s) {
+      const triggersLower = s.triggers.map(t => t.toLowerCase());
+      expect(triggersLower).toContain('deck');
+      expect(triggersLower).toContain('slides');
+      expect(triggersLower).toContain('presentation');
+      expect(triggersLower).toContain('.pptx');
+    }
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+  });
+
+  it('small body loaded in full', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const tmpDir = fs.mkdtempSync('skill-test-');
+    const mdPath = path.join(tmpDir, 'small.md');
+    fs.writeFileSync(mdPath, '---\nname: small\ndescription: x\n---\n\n# Small Skill\n\nThis fits inline easily.', 'utf-8');
+    const s = Skill.fromMarkdown(mdPath);
+    expect(s).not.toBeNull();
+    if (s) {
+      expect(s.bodyTruncated).toBe(false);
+      expect(s.systemPrompt).toContain('This fits inline easily');
+    }
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+  });
+
+  it('large body truncated to head', async () => {
+    const { Skill } = await import('../src/core/skill');
+    const tmpDir = fs.mkdtempSync('skill-test-');
+    const mdPath = path.join(tmpDir, 'big.md');
+
+    let body = '# Big Skill\n\n## Quick Reference\nFirst section content.\n\n';
+    body += '## Detailed Guide\n';
+    body += 'X'.repeat(5000);
+
+    fs.writeFileSync(mdPath, `---\nname: big\ndescription: x\n---\n\n${body}`, 'utf-8');
+    const s = Skill.fromMarkdown(mdPath);
+    expect(s).not.toBeNull();
+    if (s) {
+      expect(s.bodyTruncated).toBe(true);
+      expect(s.systemPrompt).toContain('Big Skill');
+      expect(s.systemPrompt).toContain('Quick Reference');
+      expect(s.systemPrompt).not.toContain('Detailed Guide');
+    }
+    fs.rmSync(tmpDir, { recursive: true, force: true });
+  });
+});
+
+describe('SkillRegistry', () => {
+  it('registers and retrieves skills', async () => {
+    const { Skill, SkillRegistry } = await import('../src/core/skill');
+    const reg = new SkillRegistry();
+    const skill = new Skill({ name: 'test', description: 'Test' });
+    reg.register(skill);
+    expect(reg.get('test')).toBe(skill);
+    expect(reg.get('missing')).toBeUndefined();
+  });
+
+  it('lists names', async () => {
+    const { Skill, SkillRegistry } = await import('../src/core/skill');
+    const reg = new SkillRegistry();
+    reg.register(new Skill({ name: 'a', description: 'A' }));
+    reg.register(new Skill({ name: 'b', description: 'B' }));
+    expect(reg.listNames()).toEqual(['a', 'b']);
+  });
+
+  it('merges registries', async () => {
+    const { Skill, SkillRegistry } = await import('../src/core/skill');
+    const r1 = new SkillRegistry();
+    r1.register(new Skill({ name: 'a', description: 'A' }));
+    const r2 = new SkillRegistry();
+    r2.register(new Skill({ name: 'b', description: 'B' }));
+    r1.merge(r2);
+    expect(r1.get('b')).toBeDefined();
+  });
+});

package/tests/task.test.ts

@@ -0,0 +1,60 @@
+import { describe, it, expect } from "vitest";
+import { Task, TaskState, TaskResult, VALID_TRANSITIONS } from "../src/core/agent/task";
+// Also assert the re-export path stays stable for external importers.
+import { Task as TaskViaAgent, TaskState as TaskStateViaAgent } from "../src/core/agent";
+
+describe("Task domain model", () => {
+  it("applies sensible defaults", () => {
+    const t = new Task({ id: "1", description: "do a thing" });
+    expect(t.status).toBe(TaskState.PENDING);
+    expect(t.assignedTo).toBeNull();
+    expect(t.dependsOn).toEqual([]);
+    expect(t.priority).toBe(0);
+  });
+
+  it("allows PENDING -> RUNNING -> COMPLETED", () => {
+    const t = new Task({ id: "1", description: "x" });
+    t.transitionTo(TaskState.RUNNING);
+    expect(t.status).toBe(TaskState.RUNNING);
+    t.transitionTo(TaskState.COMPLETED);
+    expect(t.status).toBe(TaskState.COMPLETED);
+  });
+
+  it("rejects illegal transitions", () => {
+    const t = new Task({ id: "1", description: "x" });
+    // PENDING -> COMPLETED is not allowed (must go through RUNNING)
+    expect(() => t.transitionTo(TaskState.COMPLETED)).toThrow(/Invalid task state transition/);
+  });
+
+  it("treats COMPLETED as terminal", () => {
+    expect(VALID_TRANSITIONS[TaskState.COMPLETED].size).toBe(0);
+    expect(VALID_TRANSITIONS[TaskState.SKIPPED].size).toBe(0);
+  });
+
+  it("allows FAILED -> RUNNING (retry) and FAILED -> SKIPPED", () => {
+    const t = new Task({ id: "1", description: "x", status: TaskState.FAILED });
+    expect(() => t.transitionTo(TaskState.RUNNING)).not.toThrow();
+    const t2 = new Task({ id: "2", description: "y", status: TaskState.FAILED });
+    expect(() => t2.transitionTo(TaskState.SKIPPED)).not.toThrow();
+  });
+
+  it("allDeps merges parentId with dependsOn without duplicates", () => {
+    const t = new Task({ id: "3", description: "z", parentId: "1", dependsOn: ["1", "2"] });
+    expect(t.allDeps.sort()).toEqual(["1", "2"]);
+    const t2 = new Task({ id: "4", description: "z", parentId: "9", dependsOn: ["2"] });
+    expect(t2.allDeps.sort()).toEqual(["2", "9"]);
+  });
+
+  it("TaskResult carries success/content/data", () => {
+    const ok = new TaskResult(true, "done", { x: 1 });
+    expect(ok.success).toBe(true);
+    expect(ok.content).toBe("done");
+    expect(ok.data).toEqual({ x: 1 });
+    expect(new TaskResult(false, "oops").data).toEqual({});
+  });
+
+  it("re-export from ../core/agent stays identical", () => {
+    expect(TaskViaAgent).toBe(Task);
+    expect(TaskStateViaAgent).toBe(TaskState);
+  });
+});