skyloom 1.12.0 → 1.13.0

package/tests/icons.test.ts

@@ -1,45 +1,45 @@
-/**
- * Tests for agent icon system.
- */
-import { describe, it, expect } from 'vitest';
-import { AGENT_COLORS, AGENT_EMOJI, iconText, svgPath } from '../src/core/icons';
-
-describe('AGENT_COLORS', () => {
-  it('has all 6 agents', () => {
-    expect(Object.keys(AGENT_COLORS).sort()).toEqual(['dew', 'fair', 'fog', 'frost', 'rain', 'snow']);
-  });
-
-  it('each agent has a non-empty color', () => {
-    for (const color of Object.values(AGENT_COLORS)) {
-      expect(color).toBeTruthy();
-    }
-  });
-});
-
-describe('AGENT_EMOJI', () => {
-  it('has all 6 agents', () => {
-    expect(Object.keys(AGENT_EMOJI).sort()).toEqual(['dew', 'fair', 'fog', 'frost', 'rain', 'snow']);
-  });
-
-  it('unique emoji per agent', () => {
-    const values = Object.values(AGENT_EMOJI);
-    expect(new Set(values).size).toBe(values.length);
-  });
-});
-
-describe('iconText', () => {
-  it('returns glyph for known agent', () => {
-    expect(iconText('fog')).toBe('≋');
-    expect(iconText('fair')).toBe('☼');
-  });
-
-  it('returns name as fallback for unknown agent', () => {
-    expect(iconText('unknown')).toBe('unknown');
-  });
-});
-
-describe('svgPath', () => {
-  it('returns a path ending with .svg', () => {
-    expect(svgPath('fog')).toContain('icons');
-  });
-});
+/**
+ * Tests for agent icon system.
+ */
+import { describe, it, expect } from 'vitest';
+import { AGENT_COLORS, AGENT_EMOJI, iconText, svgPath } from '../src/core/icons';
+
+describe('AGENT_COLORS', () => {
+  it('has all 6 agents', () => {
+    expect(Object.keys(AGENT_COLORS).sort()).toEqual(['dew', 'fair', 'fog', 'frost', 'rain', 'snow']);
+  });
+
+  it('each agent has a non-empty color', () => {
+    for (const color of Object.values(AGENT_COLORS)) {
+      expect(color).toBeTruthy();
+    }
+  });
+});
+
+describe('AGENT_EMOJI', () => {
+  it('has all 6 agents', () => {
+    expect(Object.keys(AGENT_EMOJI).sort()).toEqual(['dew', 'fair', 'fog', 'frost', 'rain', 'snow']);
+  });
+
+  it('unique emoji per agent', () => {
+    const values = Object.values(AGENT_EMOJI);
+    expect(new Set(values).size).toBe(values.length);
+  });
+});
+
+describe('iconText', () => {
+  it('returns glyph for known agent', () => {
+    expect(iconText('fog')).toBe('≋');
+    expect(iconText('fair')).toBe('☼');
+  });
+
+  it('returns name as fallback for unknown agent', () => {
+    expect(iconText('unknown')).toBe('unknown');
+  });
+});
+
+describe('svgPath', () => {
+  it('returns a path ending with .svg', () => {
+    expect(svgPath('fog')).toContain('icons');
+  });
+});

package/tests/memory.test.ts

@@ -0,0 +1,147 @@
+import { describe, it, expect, afterEach } from "vitest";
+import * as os from "os";
+import * as path from "path";
+import * as fs from "fs";
+import { Memory } from "../src/core/memory";
+
+/** addMessage mutates shortTerm through an async mutex — let microtasks flush. */
+const flush = () => new Promise((r) => setTimeout(r, 15));
+
+let tmpDirs: string[] = [];
+function tmpConfig(shortTermLimit = 100) {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), "sky-mem-"));
+  tmpDirs.push(dir);
+  return { dbPath: path.join(dir, "memory.db"), shortTermLimit, maxPersistedMessages: 2000 };
+}
+
+afterEach(() => {
+  for (const d of tmpDirs) { try { fs.rmSync(d, { recursive: true, force: true }); } catch { /* ignore */ } }
+  tmpDirs = [];
+});
+
+describe("Memory · short-term (in-memory, no DB)", () => {
+  it("makes a message visible SYNCHRONOUSLY (regression: first-turn crash)", () => {
+    // Previously addMessage pushed inside an async mutex, so getMessages() in the
+    // same tick missed the message — crashing chatImpl/chatStreamImpl on a fresh
+    // session's first user message. The push must be synchronous.
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.addMessage("user", "first message");
+    const msgs = mem.getMessages(); // no flush!
+    expect(msgs).toHaveLength(1);
+    expect(msgs[0]).toMatchObject({ role: "user", content: "first message" });
+  });
+
+  it("records and returns messages in order", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.addMessage("user", "hello");
+    mem.addMessage("assistant", "hi there");
+    await flush();
+    const msgs = mem.getMessages();
+    expect(msgs.map((m) => m.role)).toEqual(["user", "assistant"]);
+    expect(msgs[0].content).toBe("hello");
+  });
+
+  it("preserves tool-call metadata in getMessages", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.addMessage("assistant", "", { toolCalls: [{ id: "t1", function: { name: "x" } }] });
+    mem.addMessage("tool", "result", { name: "x", toolCallId: "t1" });
+    await flush();
+    const msgs = mem.getMessages();
+    const toolMsg = msgs.find((m) => m.role === "tool");
+    expect(toolMsg?.tool_call_id).toBe("t1");
+    expect(toolMsg?.name).toBe("x");
+  });
+
+  it("prunes past the short-term limit but keeps system messages", async () => {
+    const mem = new Memory(tmpConfig(3), "fog");
+    mem.addMessage("system", "persona");
+    for (let i = 0; i < 5; i++) mem.addMessage("user", `m${i}`);
+    await flush();
+    const msgs = mem.getMessages();
+    expect(msgs.length).toBeLessThanOrEqual(3);
+    expect(msgs.some((m) => m.role === "system" && m.content === "persona")).toBe(true);
+    // most recent user message survives
+    expect(msgs[msgs.length - 1].content).toBe("m4");
+  });
+
+  it("clearShortTerm keeps system messages", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.addMessage("system", "persona");
+    mem.addMessage("user", "hello");
+    await flush();
+    await mem.clearShortTerm();
+    const msgs = mem.getMessages();
+    expect(msgs).toHaveLength(1);
+    expect(msgs[0].role).toBe("system");
+  });
+});
+
+describe("Memory · context window estimation", () => {
+  it("counts CJK as heavier than ascii", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.addMessage("user", "你好世界"); // 4 CJK chars
+    await flush();
+    const usage = mem.getContextWindowUsage();
+    expect(usage.messageCount).toBe(1);
+    expect(usage.totalChars).toBe(4);
+    // CJK weight is 2/char => >= 8
+    expect(usage.estimatedTokens).toBeGreaterThanOrEqual(8);
+  });
+});
+
+describe("Memory · working memory", () => {
+  it("set/get/clear round-trips", () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    mem.setWorking("plan", { step: 1 });
+    expect(mem.getWorking("plan")).toEqual({ step: 1 });
+    expect(mem.getWorking("missing", "fallback")).toBe("fallback");
+    mem.clearWorking();
+    expect(mem.getWorking("plan")).toBeNull();
+  });
+});
+
+describe("Memory · long-term (SQLite)", () => {
+  it("remember / recall / forget round-trips", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    await mem.initDb();
+    try {
+      await mem.remember("favorite_lang", "typescript", "pref");
+      const hits = await mem.recall("favorite_lang");
+      expect(hits).toHaveLength(1);
+      expect(hits[0].value).toBe("typescript");
+      expect(hits[0].category).toBe("pref");
+
+      await mem.forget("favorite_lang");
+      expect(await mem.recall("favorite_lang")).toHaveLength(0);
+    } finally {
+      await mem.close();
+    }
+  });
+
+  it("recall filters by category", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    await mem.initDb();
+    try {
+      await mem.remember("a", 1, "x");
+      await mem.remember("b", 2, "y");
+      const xs = await mem.recall(null, "x");
+      expect(xs).toHaveLength(1);
+      expect(xs[0].key).toBe("a");
+    } finally {
+      await mem.close();
+    }
+  });
+
+  it("getMemoryStats returns a populated object", async () => {
+    const mem = new Memory(tmpConfig(), "fog");
+    await mem.initDb();
+    try {
+      await mem.remember("k", "v");
+      const stats = await mem.getMemoryStats();
+      expect(typeof stats).toBe("object");
+      expect(stats).not.toBeNull();
+    } finally {
+      await mem.close();
+    }
+  });
+});

package/tests/router.test.ts

@@ -1,86 +1,86 @@
-/**
- * Tests for the complexity router.
- */
-import { describe, it, expect } from 'vitest';
-import { classify, pickAgentForGoal } from '../src/core/router';
-
-describe('classify', () => {
-  it.each([
-    '你好',
-    'hi',
-    '在吗',
-    '谢谢',
-    '什么是 RAG?',
-    '为什么天空是蓝的？',
-    '1 + 1 = ?',
-    '解释一下闭包',
-  ])('returns "direct" for simple questions: %s', (goal) => {
-    expect(classify(goal)).toBe('direct');
-  });
-
-  it.each([
-    '帮我写一个二分查找函数',
-    '搜一下今天的天气',
-    '审查 src/foo.py 的安全问题',
-    '把这段中文翻译成英文：我喜欢猫',
-  ])('returns "single" for focused tasks: %s', (goal) => {
-    expect(classify(goal)).toBe('single');
-  });
-
-  it.each([
-    '先帮我分析这段代码，然后重构它，最后写测试',
-    '首先调研一下市场上有哪些方案，其次对比性能，最后给出推荐',
-    '1. 创建数据库迁移\n2. 写 API\n3. 加测试\n4. 部署',
-  ])('returns "orchestrate" for multi-step: %s', (goal) => {
-    expect(classify(goal)).toBe('orchestrate');
-  });
-
-  it('empty goal returns direct', () => {
-    expect(classify('')).toBe('direct');
-    expect(classify('   ')).toBe('direct');
-  });
-
-  it('inline enumerated list is orchestrate', () => {
-    expect(classify('1. 拉数据 2. 分析 3. 出图')).toBe('orchestrate');
-    expect(classify('先做 1. xxx 2. yyy 3. zzz 4. www')).toBe('orchestrate');
-  });
-
-  it('two inline items is not orchestrate', () => {
-    expect(classify('1. 你好 2. 谢谢')).not.toBe('orchestrate');
-  });
-});
-
-describe('pickAgentForGoal', () => {
-  const allAgents = new Set(['fog', 'rain', 'frost', 'snow', 'dew', 'fair']);
-
-  it('security keyword picks frost', () => {
-    expect(pickAgentForGoal('帮我做安全审查', allAgents)).toBe('frost');
-  });
-
-  it('research keyword picks fog', () => {
-    expect(pickAgentForGoal('搜一下最新的 React 文档', allAgents)).toBe('fog');
-  });
-
-  it('greeting picks fair', () => {
-    expect(pickAgentForGoal('你好啊', allAgents)).toBe('fair');
-  });
-
-  it('falls back to rain', () => {
-    expect(pickAgentForGoal('处理这个东西', allAgents)).toBe('rain');
-  });
-
-  it('binary search picks rain not fog', () => {
-    expect(pickAgentForGoal('帮我写一个二分查找', allAgents)).toBe('rain');
-    expect(pickAgentForGoal('实现一个排序函数', allAgents)).toBe('rain');
-  });
-
-  it('skips missing agents', () => {
-    const available = new Set(['rain', 'snow']);
-    const result = pickAgentForGoal('做安全审查', available);
-    expect(available.has(result)).toBe(true);
-  });
-
-  it('single agent available', () => {
-    expect(pickAgentForGoal('anything', new Set(['rain']))).toBe('rain');
-  });
-});
+/**
+ * Tests for the complexity router.
+ */
+import { describe, it, expect } from 'vitest';
+import { classify, pickAgentForGoal } from '../src/core/router';
+
+describe('classify', () => {
+  it.each([
+    '你好',
+    'hi',
+    '在吗',
+    '谢谢',
+    '什么是 RAG?',
+    '为什么天空是蓝的？',
+    '1 + 1 = ?',
+    '解释一下闭包',
+  ])('returns "direct" for simple questions: %s', (goal) => {
+    expect(classify(goal)).toBe('direct');
+  });
+
+  it.each([
+    '帮我写一个二分查找函数',
+    '搜一下今天的天气',
+    '审查 src/foo.py 的安全问题',
+    '把这段中文翻译成英文：我喜欢猫',
+  ])('returns "single" for focused tasks: %s', (goal) => {
+    expect(classify(goal)).toBe('single');
+  });
+
+  it.each([
+    '先帮我分析这段代码，然后重构它，最后写测试',
+    '首先调研一下市场上有哪些方案，其次对比性能，最后给出推荐',
+    '1. 创建数据库迁移\n2. 写 API\n3. 加测试\n4. 部署',
+  ])('returns "orchestrate" for multi-step: %s', (goal) => {
+    expect(classify(goal)).toBe('orchestrate');
+  });
+
+  it('empty goal returns direct', () => {
+    expect(classify('')).toBe('direct');
+    expect(classify('   ')).toBe('direct');
+  });
+
+  it('inline enumerated list is orchestrate', () => {
+    expect(classify('1. 拉数据 2. 分析 3. 出图')).toBe('orchestrate');
+    expect(classify('先做 1. xxx 2. yyy 3. zzz 4. www')).toBe('orchestrate');
+  });
+
+  it('two inline items is not orchestrate', () => {
+    expect(classify('1. 你好 2. 谢谢')).not.toBe('orchestrate');
+  });
+});
+
+describe('pickAgentForGoal', () => {
+  const allAgents = new Set(['fog', 'rain', 'frost', 'snow', 'dew', 'fair']);
+
+  it('security keyword picks frost', () => {
+    expect(pickAgentForGoal('帮我做安全审查', allAgents)).toBe('frost');
+  });
+
+  it('research keyword picks fog', () => {
+    expect(pickAgentForGoal('搜一下最新的 React 文档', allAgents)).toBe('fog');
+  });
+
+  it('greeting picks fair', () => {
+    expect(pickAgentForGoal('你好啊', allAgents)).toBe('fair');
+  });
+
+  it('falls back to rain', () => {
+    expect(pickAgentForGoal('处理这个东西', allAgents)).toBe('rain');
+  });
+
+  it('binary search picks rain not fog', () => {
+    expect(pickAgentForGoal('帮我写一个二分查找', allAgents)).toBe('rain');
+    expect(pickAgentForGoal('实现一个排序函数', allAgents)).toBe('rain');
+  });
+
+  it('skips missing agents', () => {
+    const available = new Set(['rain', 'snow']);
+    const result = pickAgentForGoal('做安全审查', available);
+    expect(available.has(result)).toBe(true);
+  });
+
+  it('single agent available', () => {
+    expect(pickAgentForGoal('anything', new Set(['rain']))).toBe('rain');
+  });
+});

package/tests/schemas.test.ts

@@ -1,51 +1,51 @@
-/**
- * Tests for structured output schema validation.
- */
-import { describe, it, expect } from 'vitest';
-import { validateTaskPlan, TaskPlanSchema, parseSchema, SchemaValidationError } from '../src/core/schemas';
-
-describe('validateTaskPlan', () => {
-  it('parses valid JSON plan', () => {
-    const data = JSON.parse('{"goal": "build app", "steps": [{"id": "1", "description": "design", "agent": "fog"}]}');
-    const plan = validateTaskPlan(data);
-    expect(plan.goal).toBe('build app');
-    expect(plan.steps).toHaveLength(1);
-    expect(plan.steps[0].agent).toBe('fog');
-  });
-
-  it('passes through agent name', () => {
-    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a", "agent": "unknown"}]}');
-    const plan = validateTaskPlan(data);
-    // Schema-level validation just passes through; agent fallback is in SnowAgent
-    expect(plan.steps[0].agent).toBe('unknown');
-  });
-
-  it('empty steps', () => {
-    const data = JSON.parse('{"goal": "x", "steps": []}');
-    const plan = validateTaskPlan(data);
-    expect(plan.steps).toHaveLength(0);
-  });
-
-  it('parses depends_on', () => {
-    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a", "depends_on": ["0"]}]}');
-    const plan = validateTaskPlan(data);
-    expect(plan.steps[0].depends_on).toEqual(['0']);
-  });
-
-  it('default fields', () => {
-    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a"}]}');
-    const plan = validateTaskPlan(data);
-    expect(plan.steps[0].agent).toBe('rain');
-    expect(plan.steps[0].depends_on).toEqual([]);
-  });
-});
-
-describe('SchemaValidationError', () => {
-  it('raises on empty', () => {
-    expect(() => parseSchema('', TaskPlanSchema)).toThrow(SchemaValidationError);
-  });
-
-  it('raises on garbage', () => {
-    expect(() => parseSchema('<html>garbage</html>', TaskPlanSchema)).toThrow(SchemaValidationError);
-  });
-});
+/**
+ * Tests for structured output schema validation.
+ */
+import { describe, it, expect } from 'vitest';
+import { validateTaskPlan, TaskPlanSchema, parseSchema, SchemaValidationError } from '../src/core/schemas';
+
+describe('validateTaskPlan', () => {
+  it('parses valid JSON plan', () => {
+    const data = JSON.parse('{"goal": "build app", "steps": [{"id": "1", "description": "design", "agent": "fog"}]}');
+    const plan = validateTaskPlan(data);
+    expect(plan.goal).toBe('build app');
+    expect(plan.steps).toHaveLength(1);
+    expect(plan.steps[0].agent).toBe('fog');
+  });
+
+  it('passes through agent name', () => {
+    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a", "agent": "unknown"}]}');
+    const plan = validateTaskPlan(data);
+    // Schema-level validation just passes through; agent fallback is in SnowAgent
+    expect(plan.steps[0].agent).toBe('unknown');
+  });
+
+  it('empty steps', () => {
+    const data = JSON.parse('{"goal": "x", "steps": []}');
+    const plan = validateTaskPlan(data);
+    expect(plan.steps).toHaveLength(0);
+  });
+
+  it('parses depends_on', () => {
+    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a", "depends_on": ["0"]}]}');
+    const plan = validateTaskPlan(data);
+    expect(plan.steps[0].depends_on).toEqual(['0']);
+  });
+
+  it('default fields', () => {
+    const data = JSON.parse('{"goal": "x", "steps": [{"id": "1", "description": "a"}]}');
+    const plan = validateTaskPlan(data);
+    expect(plan.steps[0].agent).toBe('rain');
+    expect(plan.steps[0].depends_on).toEqual([]);
+  });
+});
+
+describe('SchemaValidationError', () => {
+  it('raises on empty', () => {
+    expect(() => parseSchema('', TaskPlanSchema)).toThrow(SchemaValidationError);
+  });
+
+  it('raises on garbage', () => {
+    expect(() => parseSchema('<html>garbage</html>', TaskPlanSchema)).toThrow(SchemaValidationError);
+  });
+});