skillrepo 2.0.0 → 3.0.0

package/src/test/e2e/cli-init.test.mjs

@@ -1,213 +0,0 @@
-/**
- * CLI E2E tests for `skillrepo init`.
- *
- * Spins up a mock HTTP server, runs the real CLI binary as a subprocess,
- * and verifies the generated setup actually works — not just that files exist.
- *
- * Uses node:test + node:assert — zero external dependencies.
- *
- * IMPORTANT: The CLI is run via async `execFile` (not `execFileSync`).
- * execFileSync would block the Node event loop and starve the mock HTTP
- * server running in the same process, causing the CLI's fetch to hang.
- */
-
-import { describe, it, before, after, beforeEach, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import {
-  mkdtempSync, mkdirSync, rmSync, readFileSync, writeFileSync,
-  existsSync,
-} from "node:fs";
-import { join, resolve, dirname } from "node:path";
-import { tmpdir } from "node:os";
-import { execFile } from "node:child_process";
-import { fileURLToPath } from "node:url";
-
-import { createMockServer } from "./mock-server.mjs";
-import { buildPayload } from "./payload-factory.mjs";
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const CLI_BIN = resolve(__dirname, "../../../bin/skillrepo.mjs");
-const API_KEY = "sk_live_test123";
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Run the CLI init command against a mock server in a given cwd.
- * Returns a promise that resolves with stdout on success.
- */
-function runInit(cwd, port, { key = API_KEY, extraArgs = [] } = {}) {
-  return new Promise((resolve, reject) => {
-    execFile(
-      process.execPath,
-      [CLI_BIN, "init", "--url", `http://127.0.0.1:${port}`, "--key", key, "--yes", ...extraArgs],
-      { cwd, encoding: "utf-8", timeout: 15_000, env: { ...process.env, NODE_NO_WARNINGS: "1" } },
-      (err, stdout, stderr) => {
-        if (err) return reject(Object.assign(err, { stdout, stderr }));
-        resolve(stdout);
-      },
-    );
-  });
-}
-
-/** Run the CLI and expect it to fail. Returns { stdout, stderr, status }. */
-function runInitExpectFail(cwd, port, { key = API_KEY } = {}) {
-  return new Promise((resolve) => {
-    execFile(
-      process.execPath,
-      [CLI_BIN, "init", "--url", `http://127.0.0.1:${port}`, "--key", key, "--yes"],
-      { cwd, encoding: "utf-8", timeout: 15_000, env: { ...process.env, NODE_NO_WARNINGS: "1" } },
-      (err, stdout, stderr) => {
-        if (err) {
-          resolve({ stdout: stdout ?? "", stderr: stderr ?? "", status: err.code ?? 1 });
-        } else {
-          resolve({ stdout, stderr: "", status: 0 });
-        }
-      },
-    );
-  });
-}
-
-/** Read a file from the temp dir. */
-function readFile(dir, relPath) {
-  return readFileSync(join(dir, relPath), "utf-8");
-}
-
-/** Check if a file exists in the temp dir. */
-function fileExists(dir, relPath) {
-  return existsSync(join(dir, relPath));
-}
-
-/** Parse JSON from a file in the temp dir. */
-function readJSON(dir, relPath) {
-  return JSON.parse(readFile(dir, relPath));
-}
-
-/** Create a fresh temp dir with .claude/ and .cursor/ markers. */
-function makeTempDir() {
-  const dir = mkdtempSync(join(tmpdir(), "cli-e2e-"));
-  mkdirSync(join(dir, ".claude"), { recursive: true });
-  mkdirSync(join(dir, ".cursor"), { recursive: true });
-  return dir;
-}
-
-// ---------------------------------------------------------------------------
-// Test suite
-// ---------------------------------------------------------------------------
-
-describe("CLI E2E: skillrepo init", () => {
-  let server;
-  let port;
-  let tempDir;
-
-  before(async () => {
-    server = createMockServer({});
-    port = await server.start();
-    const payload = buildPayload({ baseUrl: `http://127.0.0.1:${port}` });
-    server.setPayload(payload);
-  });
-
-  after(async () => {
-    if (server) await server.stop();
-  });
-
-  beforeEach(() => {
-    tempDir = makeTempDir();
-  });
-
-  afterEach(() => {
-    if (tempDir) rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  // =========================================================================
-  // 1. MCP Config
-  // =========================================================================
-
-  it(".mcp.json is created with MCP server config", async () => {
-    await runInit(tempDir, port);
-
-    const mcp = readJSON(tempDir, ".mcp.json");
-    assert.ok(mcp.mcpServers?.skillrepo, "Should have skillrepo MCP server entry");
-  });
-
-  it(".env.local contains the API key", async () => {
-    await runInit(tempDir, port);
-
-    const envContent = readFile(tempDir, ".env.local");
-    assert.ok(envContent.includes(`SKILLREPO_ACCESS_KEY=${API_KEY}`));
-  });
-
-  // =========================================================================
-  // 2. Error Handling
-  // =========================================================================
-
-  it("invalid API key (401) exits with error", async () => {
-    const srv = createMockServer({}, { validKey: "sk_live_onlythisone" });
-    const p = await srv.start();
-    const payload = buildPayload({ baseUrl: `http://127.0.0.1:${p}` });
-    srv.setPayload(payload);
-
-    try {
-      const result = await runInitExpectFail(tempDir, p, { key: "sk_live_wrongkey" });
-      assert.notEqual(result.status, 0);
-      const output = result.stdout + result.stderr;
-      assert.ok(output.toLowerCase().includes("invalid") || output.toLowerCase().includes("error"));
-    } finally {
-      await srv.stop();
-    }
-  });
-
-  it("unreachable server exits with error", async () => {
-    const result = await runInitExpectFail(tempDir, 19999);
-    assert.notEqual(result.status, 0);
-    const output = result.stdout + result.stderr;
-    assert.ok(
-      output.toLowerCase().includes("cannot reach") ||
-      output.toLowerCase().includes("error") ||
-      output.toLowerCase().includes("econnrefused"),
-    );
-  });
-
-  // =========================================================================
-  // 3. Generated Files Are Structurally Valid
-  // =========================================================================
-
-  it("all JSON files parse without error", async () => {
-    await runInit(tempDir, port);
-
-    for (const f of [".mcp.json"]) {
-      assert.doesNotThrow(() => readJSON(tempDir, f), `Invalid JSON: ${f}`);
-    }
-  });
-
-  // =========================================================================
-  // 4. .gitignore and old format cleanup
-  // =========================================================================
-
-  it("old format files are cleaned up during migration", async () => {
-    // Create old format files before init
-    writeFileSync(join(tempDir, ".claude/skillrepo.md"), "# Old skillrepo md");
-    writeFileSync(join(tempDir, ".claude/skillrepo-index.json"), '{"version":1}');
-    writeFileSync(join(tempDir, ".claude/skillrepo-config.json"), '{"version":2}');
-
-    await runInit(tempDir, port);
-
-    // Old format files should be removed
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo.md"), "Old .claude/skillrepo.md should be removed");
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo-index.json"), "Old .claude/skillrepo-index.json should be removed");
-    assert.ok(!fileExists(tempDir, ".claude/skillrepo-config.json"), "Old .claude/skillrepo-config.json should be removed");
-  });
-
-  // =========================================================================
-  // 5. No hook files generated (hooks removed in v1)
-  // =========================================================================
-
-  it("does not generate hook files", async () => {
-    await runInit(tempDir, port);
-
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-sync.mjs"), "Sync hook should not exist");
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-prompt-match.mjs"), "Prompt-match hook should not exist");
-    assert.ok(!fileExists(tempDir, ".claude/hooks/skillrepo-pretool-activation.mjs"), "PreToolUse hook should not exist");
-  });
-});

package/src/test/e2e/payload-factory.mjs

@@ -1,22 +0,0 @@
-/**
- * Factory for SetupPayload objects used in CLI E2E tests.
- *
- * Phase D (#534): The setup endpoint now returns only `skillCount` and
- * `mcpUrl`. All hook/rule/config generation was removed — standalone
- * scripts bundled with the CLI handle everything.
- */
-
-/**
- * Build a SetupPayload for E2E tests.
- *
- * @param {object} [options]
- * @param {string} [options.baseUrl] - The base URL for the mock server
- * @returns {object} A SetupPayload
- */
-export function buildPayload(options = {}) {
-  const baseUrl = options.baseUrl ?? "http://localhost:9999";
-  return {
-    skillCount: 5,
-    mcpUrl: `${baseUrl}/api/mcp`,
-  };
-}