skillrepo 2.0.0 → 3.0.0

package/src/test/e2e/cli-commands.test.mjs

@@ -0,0 +1,576 @@
+/**
+ * E2E tests for the PR2 read commands (#646).
+ *
+ * Spawns the real CLI binary as a subprocess against the in-process
+ * mock server. Asserts on stdout, stderr, exit code, and post-state
+ * file tree. Same pattern as the existing cli-init.test.mjs harness.
+ *
+ * Coverage:
+ *   • Full lifecycle: update → list → get → search
+ *   • Per-command --json output via subprocess
+ *   • Error exit codes propagated from CliError
+ */
+
+import { describe, it, before, after, beforeEach, afterEach } from "node:test";
+import assert from "node:assert/strict";
+import { mkdtempSync, mkdirSync, rmSync, existsSync } from "node:fs";
+import { join, dirname, resolve } from "node:path";
+import { tmpdir } from "node:os";
+import { execFile } from "node:child_process";
+import { fileURLToPath } from "node:url";
+
+import { createMockServer } from "./mock-server.mjs";
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const CLI_BIN = resolve(__dirname, "../../../bin/skillrepo.mjs");
+const VALID_KEY = "sk_live_test_e2e";
+
+let server;
+let port;
+let tempDir;
+let tempHome;
+
+function makeSkill(owner, name, content = `body of ${name}`) {
+  return {
+    owner,
+    name,
+    version: "1.0.0",
+    description: `${name} description`,
+    files: [
+      {
+        path: "SKILL.md",
+        content: `---\nname: ${name}\ndescription: ${name} description\n---\n\n${content}\n`,
+        sha256: "x",
+        size: 100,
+        contentType: "text/markdown",
+      },
+    ],
+    updatedAt: "2025-01-01T00:00:00Z",
+  };
+}
+
+/**
+ * Run the CLI as a subprocess from `tempDir` with `tempHome` as HOME.
+ * Always resolves with { stdout, stderr, status }.
+ */
+function runCli(args, extraEnv = {}) {
+  return new Promise((resolve) => {
+    execFile(
+      process.execPath,
+      [CLI_BIN, ...args],
+      {
+        cwd: tempDir,
+        encoding: "utf-8",
+        timeout: 15_000,
+        env: {
+          ...process.env,
+          HOME: tempHome,
+          NO_COLOR: "1",
+          NODE_NO_WARNINGS: "1",
+          SKILLREPO_ACCESS_KEY: "",
+          SKILLREPO_TIMEOUT_MS: "5000",
+          ...extraEnv,
+        },
+      },
+      (err, stdout, stderr) => {
+        resolve({
+          stdout: stdout ?? "",
+          stderr: stderr ?? "",
+          status: err ? err.code ?? 1 : 0,
+        });
+      },
+    );
+  });
+}
+
+describe("CLI E2E — read commands", () => {
+  before(async () => {
+    server = createMockServer({});
+    port = await server.start();
+  });
+
+  after(async () => {
+    if (server) await server.stop();
+  });
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), "cli-e2e-cmds-"));
+    tempHome = mkdtempSync(join(tmpdir(), "cli-e2e-home-"));
+    // Reset all mock-server slots between tests
+    server.setLibraryResponse({ skills: [], removals: [], syncedAt: "x" });
+    server.setEtag(null);
+    server.clearSkillResponses();
+    server.setSearchResponse({ skills: [], pagination: { total: 0, limit: 20, offset: 0 } });
+    server.clearAddResponses();
+    server.clearRemoveResponses();
+  });
+
+  afterEach(() => {
+    if (tempDir) rmSync(tempDir, { recursive: true, force: true });
+    if (tempHome) rmSync(tempHome, { recursive: true, force: true });
+  });
+
+  // ── Lifecycle: update → list → get → search ─────────────────────────
+
+  it("update on empty library prints up-to-date and exits 0", async () => {
+    const r = await runCli([
+      "update",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /up to date/);
+  });
+
+  it("update writes a single skill and prints the summary", async () => {
+    server.setLibraryResponse({
+      skills: [makeSkill("alice", "pdf-helper")],
+      removals: [],
+      syncedAt: "x",
+    });
+    const r = await runCli([
+      "update",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /1 added/);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+  });
+
+  it("update --json outputs structured summary", async () => {
+    server.setLibraryResponse({
+      skills: [makeSkill("alice", "pdf-helper")],
+      removals: [],
+      syncedAt: "x",
+    });
+    const r = await runCli([
+      "update",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--json",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    const json = JSON.parse(r.stdout);
+    assert.equal(json.added, 1);
+  });
+
+  it("list renders an empty-state hint when library is empty", async () => {
+    const r = await runCli([
+      "list",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /library is empty/);
+  });
+
+  it("list renders skills as a table after they're added", async () => {
+    server.setLibraryResponse({
+      skills: [makeSkill("alice", "pdf-helper"), makeSkill("bob", "code-review")],
+      removals: [],
+      syncedAt: "x",
+    });
+    const r = await runCli([
+      "list",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /pdf-helper/);
+    assert.match(r.stdout, /code-review/);
+    assert.match(r.stdout, /2 skills/);
+  });
+
+  it("get fetches a single skill and writes it to disk", async () => {
+    server.setSkillResponse("alice", "pdf-helper", makeSkill("alice", "pdf-helper"));
+    const r = await runCli([
+      "get",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/pdf-helper",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /Fetched/);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+  });
+
+  it("get with non-existent skill exits 5 with a clean error", async () => {
+    const r = await runCli([
+      "get",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/missing",
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /not found/);
+  });
+
+  it("search renders results from the registry", async () => {
+    server.setSearchResponse({
+      skills: [
+        {
+          owner: "alice",
+          name: "pdf-helper",
+          description: "Test skill",
+          version: "1.0.0",
+          license: null,
+          compatibility: null,
+          installs: 100,
+          avgRating: null,
+          safetyGrade: null,
+          publishedAt: null,
+        },
+      ],
+      pagination: { total: 1, limit: 20, offset: 0 },
+    });
+    const r = await runCli([
+      "search",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "pdf",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /pdf-helper/);
+    assert.match(r.stdout, /Results for "pdf"/);
+  });
+
+  it("search with no results prints helpful message", async () => {
+    const r = await runCli([
+      "search",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "obscure",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /No skills found matching/);
+  });
+
+  // ── Error paths ─────────────────────────────────────────────────────
+
+  it("invalid access key exits 2 (auth error)", async () => {
+    server.setForcedStatus(401, { error: "Invalid access key" });
+    const r = await runCli([
+      "list",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 2);
+    assert.match(r.stderr, /Invalid access key|access key/);
+  });
+
+  it("missing access key exits 2 (no key configured)", async () => {
+    const r = await runCli([
+      "list",
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 2);
+    assert.match(r.stderr, /No access key/);
+  });
+
+  it("unreachable server exits 1 (network error)", async () => {
+    const r = await runCli([
+      "list",
+      "--key", VALID_KEY,
+      "--url", "http://127.0.0.1:1",
+    ]);
+    assert.equal(r.status, 1);
+  });
+
+  it("get with malformed identifier exits 5 (validation)", async () => {
+    const r = await runCli([
+      "get",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "not-an-identifier",
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /missing owner/);
+  });
+
+  it("search without query exits 5 (validation)", async () => {
+    const r = await runCli([
+      "search",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /query is required/);
+  });
+
+  // ── Multi-command lifecycle ─────────────────────────────────────────
+
+  // ── PR3a: add + remove ──────────────────────────────────────────────
+
+  it("add writes the library + local files", async () => {
+    server.setSkillResponse("alice", "pdf-helper", makeSkill("alice", "pdf-helper"));
+    const r = await runCli([
+      "add",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/pdf-helper",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /Added @alice\/pdf-helper/);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+  });
+
+  it("add with already-in-library refreshes local files (idempotent)", async () => {
+    server.setAddResponse("alice", "pdf-helper", {
+      status: 409,
+      body: { code: "already_in_library" },
+    });
+    server.setSkillResponse("alice", "pdf-helper", makeSkill("alice", "pdf-helper"));
+
+    const r = await runCli([
+      "add",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/pdf-helper",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /already in your library — refreshed/);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+  });
+
+  it("add with 404 exits 5 (skill not found)", async () => {
+    server.setAddResponse("alice", "missing", {
+      status: 404,
+      body: { error: "Skill not found", code: "not_found" },
+    });
+    const r = await runCli([
+      "add",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/missing",
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /not found/);
+  });
+
+  it("add with 403 scope_required exits 4", async () => {
+    server.setAddResponseForAny({
+      status: 403,
+      body: { error: "Scope required", code: "scope_required" },
+    });
+    const r = await runCli([
+      "add",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/any",
+    ]);
+    assert.equal(r.status, 4);
+    assert.match(r.stderr, /write-scoped key|scope/);
+  });
+
+  it("add with 403 plan_limit exits 5 with billing hint", async () => {
+    server.setAddResponseForAny({
+      status: 403,
+      body: { error: "Your free plan allows up to 5 library skills.", code: "plan_limit" },
+    });
+    const r = await runCli([
+      "add",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/too-many",
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /plan/);
+  });
+
+  it("remove deletes from library + local files", async () => {
+    // Pre-populate a local skill
+    server.setSkillResponse("alice", "pdf-helper", makeSkill("alice", "pdf-helper"));
+    await runCli([
+      "get",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/pdf-helper",
+    ]);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper")));
+
+    const r = await runCli([
+      "remove",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/pdf-helper",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /Removed @alice\/pdf-helper/);
+    assert.ok(!existsSync(join(tempDir, ".claude", "skills", "pdf-helper")));
+  });
+
+  it("remove 404 not-in-library still exits 0 (idempotent)", async () => {
+    server.setRemoveResponseForAny({
+      status: 404,
+      body: { code: "not_in_library" },
+    });
+    const r = await runCli([
+      "remove",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/ghost",
+    ]);
+    assert.equal(r.status, 0);
+    assert.match(r.stdout, /nothing to do|wasn't in your library/);
+  });
+
+  it("remove 403 scope_required exits 4", async () => {
+    server.setRemoveResponseForAny({
+      status: 403,
+      body: { error: "Scope required", code: "scope_required" },
+    });
+    const r = await runCli([
+      "remove",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "@alice/any",
+    ]);
+    assert.equal(r.status, 4);
+  });
+
+  // ── PR3b: init ──────────────────────────────────────────────────
+
+  it("init writes config + MCP + runs first sync (happy path)", async () => {
+    // Create a .claude/ marker so detectIdes finds claudeCode
+    mkdirSync(join(tempDir, ".claude"), { recursive: true });
+
+    const r = await runCli([
+      "init",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--yes",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /SkillRepo is ready/);
+
+    // Config persisted under the tempHome
+    assert.ok(existsSync(join(tempHome, ".claude", "skillrepo", "config.json")));
+    // MCP config in project
+    assert.ok(existsSync(join(tempDir, ".mcp.json")));
+    // .env.local in project
+    assert.ok(existsSync(join(tempDir, ".env.local")));
+  });
+
+  it("init --json outputs structured summary", async () => {
+    mkdirSync(join(tempDir, ".claude"), { recursive: true });
+
+    const r = await runCli([
+      "init",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--yes",
+      "--json",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    const json = JSON.parse(r.stdout);
+    assert.equal(json.action, "initialized");
+    assert.equal(json.account.slug, "mock");
+  });
+
+  it("init --ide claude works in empty dir (headless CI scenario)", async () => {
+    const r = await runCli([
+      "init",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--yes",
+      "--ide", "claude",
+    ]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.ok(existsSync(join(tempDir, ".mcp.json")));
+  });
+
+  it("init with no IDEs detected and no --ide exits 5", async () => {
+    // No .claude marker, no --ide flag
+    const r = await runCli([
+      "init",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--yes",
+    ]);
+    assert.equal(r.status, 5);
+    assert.match(r.stderr, /No IDEs detected/);
+  });
+
+  it("init with 401 from validate exits 2", async () => {
+    mkdirSync(join(tempDir, ".claude"), { recursive: true });
+    server.setForcedStatus(401, { error: "Invalid access key" });
+    const r = await runCli([
+      "init",
+      "--key", VALID_KEY,
+      "--url", `http://127.0.0.1:${port}`,
+      "--yes",
+    ]);
+    assert.equal(r.status, 2);
+  });
+
+  it("full lifecycle: init → update → list → get → add → remove → search", async () => {
+    mkdirSync(join(tempDir, ".claude"), { recursive: true });
+
+    const endpoint = `http://127.0.0.1:${port}`;
+
+    // 0. Init — creates the config, MCP, and runs first sync
+    let r = await runCli(["init", "--key", VALID_KEY, "--url", endpoint, "--yes"]);
+    assert.equal(r.status, 0, `init stderr: ${r.stderr}`);
+    assert.ok(existsSync(join(tempHome, ".claude", "skillrepo", "config.json")));
+    assert.ok(existsSync(join(tempDir, ".mcp.json")));
+
+    // Subsequent calls can omit --key since init wrote the config.
+    // But they still need --url since the config's serverUrl is
+    // now the mock-server URL; a different port across this test
+    // run would collide with the stored config. That's fine — the
+    // subsequent calls inherit the same URL from the config.
+
+    // 1. Empty update
+    r = await runCli(["update", "--key", VALID_KEY, "--url", endpoint]);
+    assert.equal(r.status, 0);
+
+    // 2. List on empty library
+    r = await runCli(["list", "--key", VALID_KEY, "--url", endpoint]);
+    assert.equal(r.status, 0);
+    assert.match(r.stdout, /library is empty/);
+
+    // 3. Get a skill (server has it registered)
+    server.setSkillResponse("alice", "pdf-helper", makeSkill("alice", "pdf-helper"));
+    r = await runCli(["get", "--key", VALID_KEY, "--url", endpoint, "@alice/pdf-helper"]);
+    assert.equal(r.status, 0);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+
+    // 4. Add a skill (PR3a): POST default 201 + follow-up GET + local write
+    server.setSkillResponse("alice", "code-review", makeSkill("alice", "code-review"));
+    r = await runCli(["add", "--key", VALID_KEY, "--url", endpoint, "@alice/code-review"]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /Added @alice\/code-review/);
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "code-review", "SKILL.md")));
+
+    // 5. Remove a skill (PR3a): DELETE default 200 + local delete
+    r = await runCli(["remove", "--key", VALID_KEY, "--url", endpoint, "@alice/code-review"]);
+    assert.equal(r.status, 0, `stderr: ${r.stderr}`);
+    assert.match(r.stdout, /Removed @alice\/code-review/);
+    assert.ok(!existsSync(join(tempDir, ".claude", "skills", "code-review")));
+    // pdf-helper from the `get` step is still there
+    assert.ok(existsSync(join(tempDir, ".claude", "skills", "pdf-helper", "SKILL.md")));
+
+    // 6. Search works
+    server.setSearchResponse({
+      skills: [
+        {
+          owner: "alice",
+          name: "pdf-helper",
+          description: "test",
+          version: "1.0.0",
+          license: null,
+          compatibility: null,
+          installs: 1,
+          avgRating: null,
+          safetyGrade: null,
+          publishedAt: null,
+        },
+      ],
+      pagination: { total: 1, limit: 20, offset: 0 },
+    });
+    r = await runCli(["search", "--key", VALID_KEY, "--url", endpoint, "pdf"]);
+    assert.equal(r.status, 0);
+    assert.match(r.stdout, /pdf-helper/);
+  });
+});