shipwright-cli 3.1.0 → 3.3.0

package/scripts/sw-quality.sh

@@ -6,7 +6,7 @@
 set -euo pipefail
 trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
 
-VERSION="3.1.0"
+VERSION="3.3.0"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 
@@ -16,6 +16,8 @@ REPO_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
 # Canonical helpers (colors, output, events)
 # shellcheck source=lib/helpers.sh
 [[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
+# shellcheck source=lib/config.sh
+[[ -f "$SCRIPT_DIR/lib/config.sh" ]] && source "$SCRIPT_DIR/lib/config.sh"
 # Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
 [[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
 [[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
@@ -28,6 +30,7 @@ fi
 if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
   emit_event() {
     local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
+    # shellcheck disable=SC2155
     local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
     while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
     echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
@@ -81,7 +84,8 @@ validate_quality() {
     local uncommitted_pass=true
     if [[ -d "$REPO_DIR/.git" ]]; then
         local dirty_count
-        dirty_count=$(cd "$REPO_DIR" && git status --short 2>/dev/null | wc -l || echo "0")
+        dirty_count=$(cd "$REPO_DIR" && git status --short 2>/dev/null | wc -l || true)
+        dirty_count="${dirty_count:-0}"
         if [[ "$dirty_count" -gt 0 ]]; then
             uncommitted_pass=false
             all_pass=false
@@ -102,14 +106,16 @@ validate_quality() {
         json_output=$(echo "$json_output" | jq --arg tp "$todos_pass" '.checks.todos=$tp' 2>/dev/null || true)
     fi
 
-    # Check 5: Hardcoded secrets patterns
+    # Check 5: Secrets patterns in diff
     local secrets_pass=true
     local secret_patterns="(password|secret|token|api[_-]?key|aws_access|private_key)"
+    local secret_threshold
+    secret_threshold=$(_config_get_int "quality.secret_threshold" 3 2>/dev/null || echo 3)
     if [[ -d "$REPO_DIR/.git" ]]; then
         local secret_count
         secret_count=$(cd "$REPO_DIR" && git diff --cached 2>/dev/null | grep -ciE "$secret_patterns" || true)
         secret_count="${secret_count:-0}"
-        if [[ "$secret_count" -gt 3 ]]; then
+        if [[ "$secret_count" -gt "$secret_threshold" ]]; then
             secrets_pass=false
             all_pass=false
         fi
@@ -403,14 +409,16 @@ calculate_quality_score() {
     # Security audit (20%)
     local security_files=0
     if [[ -d "$REPO_DIR" ]]; then
-        security_files=$(find "$REPO_DIR" -type f \( -name "*.js" -o -name "*.py" -o -name "*.go" \) 2>/dev/null | wc -l || echo "0")
+        security_files=$(find "$REPO_DIR" -type f \( -name "*.js" -o -name "*.py" -o -name "*.go" \) 2>/dev/null | wc -l || true)
+        security_files="${security_files:-0}"
         security_score=$((security_files > 0 ? 85 : 0))
     fi
 
     # Architecture audit (15%)
     local architecture_files=0
     if [[ -d "$REPO_DIR" ]]; then
-        architecture_files=$(find "$REPO_DIR" -type f \( -name "*.js" -o -name "*.py" \) 2>/dev/null | wc -l || echo "0")
+        architecture_files=$(find "$REPO_DIR" -type f \( -name "*.js" -o -name "*.py" \) 2>/dev/null | wc -l || true)
+        architecture_files="${architecture_files:-0}"
         architecture_score=$((architecture_files > 0 ? 80 : 0))
     fi
 

package/scripts/sw-reaper.sh

@@ -11,32 +11,12 @@
 # ║    shipwright reaper --watch      Continuous loop (default: 5s)         ║
 # ║    shipwright reaper --dry-run    Preview what would be reaped          ║
 # ╚═══════════════════════════════════════════════════════════════════════════╝
-VERSION="3.1.0"
+# shellcheck disable=SC2034
+VERSION="3.3.0"
 set -euo pipefail
-trap 'echo "ERROR: $BASH_SOURCE:$LINENO exited with status $?" >&2' ERR
-
-SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-
-# Canonical helpers (colors, output, events)
-# shellcheck source=lib/helpers.sh
-[[ -f "$SCRIPT_DIR/lib/helpers.sh" ]] && source "$SCRIPT_DIR/lib/helpers.sh"
-# Fallbacks when helpers not loaded (e.g. test env with overridden SCRIPT_DIR)
-[[ "$(type -t info 2>/dev/null)" == "function" ]]    || info()    { echo -e "\033[38;2;0;212;255m\033[1m▸\033[0m $*"; }
-[[ "$(type -t success 2>/dev/null)" == "function" ]] || success() { echo -e "\033[38;2;74;222;128m\033[1m✓\033[0m $*"; }
-[[ "$(type -t warn 2>/dev/null)" == "function" ]]    || warn()    { echo -e "\033[38;2;250;204;21m\033[1m⚠\033[0m $*"; }
-[[ "$(type -t error 2>/dev/null)" == "function" ]]   || error()   { echo -e "\033[38;2;248;113;113m\033[1m✗\033[0m $*" >&2; }
-if [[ "$(type -t now_iso 2>/dev/null)" != "function" ]]; then
-  now_iso()   { date -u +"%Y-%m-%dT%H:%M:%SZ"; }
-  now_epoch() { date +%s; }
-fi
-if [[ "$(type -t emit_event 2>/dev/null)" != "function" ]]; then
-  emit_event() {
-    local event_type="$1"; shift; mkdir -p "${HOME}/.shipwright"
-    local payload="{\"ts\":\"$(date -u +%Y-%m-%dT%H:%M:%SZ)\",\"type\":\"$event_type\""
-    while [[ $# -gt 0 ]]; do local key="${1%%=*}" val="${1#*=}"; payload="${payload},\"${key}\":\"${val}\""; shift; done
-    echo "${payload}}" >> "${HOME}/.shipwright/events.jsonl"
-  }
-fi
+
+# shellcheck source=lib/bootstrap.sh
+source "$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/lib/bootstrap.sh"
 # ─── Defaults ──────────────────────────────────────────────────────────────
 WATCH=false
 DRY_RUN=false
@@ -193,6 +173,8 @@ scan_and_reap() {
     local skipped=0
     local scanned=0
 
+    # shellcheck disable=SC2034
+    # shellcheck disable=SC2034
     while IFS='|' read -r window_name pane_title pane_pid cmd pane_active pane_idle pane_dead pane_ref; do
         [[ -z "$window_name" ]] && continue
 
@@ -291,6 +273,7 @@ cleanup_team_dirs() {
                     cleaned=$((cleaned + 1))
                 }
                 if [[ -d "${tasks_dir}/${team_name}" ]]; then
+                    # shellcheck disable=SC2115
                     rm -rf "${tasks_dir}/${team_name}" && {
                         echo -e "  ${RED}✗${RESET} Removed task dir: ${BOLD}${team_name}/${RESET}"
                         log "CLEAN_TASKS team=${team_name}"