seisin 0.5.0 → 0.6.0

package/src/requests.js

@@ -4,9 +4,10 @@
  * ── Two words, kept apart on purpose ──
  * **Denied** is what the boundary does. **Declined** is what a person does to
  * a request. They used to be one word in one command: an entry read `first
- * refused on src/api/x.ts` and `seisin deny` answered `refused frontend ✕
- * src/api/**`. One means the kernel said no, the other means you did, and a
- * reader had nothing to tell them apart by.
+ * refused on src/api/x.ts` and the command that declined it answered `refused
+ * frontend ✕ src/api/**`. One means the kernel said no, the other means you
+ * did, and a reader had nothing to tell them apart by. The file kept the
+ * boundary's word for a decline until 0.6.0; see migrateQueue.
  *
  * The entry says **asked** now, because refused was not always true. Asking for
  * a path before reaching for it is reasonable, and nothing required a
@@ -19,21 +20,23 @@
  * A denial already contains everything a request needs — the hook knows the
  * role, the path and the owner — so the denial leaves something behind that a
  * person can act on in one command instead of in an editor. See
- * `docs/permission-requests.md` for why granting is deliberately not something
+ * `docs/requests.md` for why granting is deliberately not something
  * an agent can do.
  *
  * Append-only, beside the log, for the same reason: a decision that can be
  * rewritten is not evidence. A request that is granted or declined is not
  * deleted — it is followed by a line saying what happened to it.
  */
-import { neverWrites, isGitMetadata, covers, keyHolders, inKeyDir } from "./owners.js";
+import { neverWrites, isGitMetadata, covers, privateOwner } from "./owners.js";
+import { decideHandoff, chainOf, isKeyRequest } from "./handoff.js";
 import { protectedBy } from "./surface.js";
-import { appendFileSync, mkdirSync, readFileSync, statSync, writeFileSync, renameSync, unlinkSync } from "node:fs";
+import { appendFileSync, chmodSync, closeSync, fstatSync, mkdirSync, openSync, readFileSync, readSync, statSync, writeFileSync, renameSync, unlinkSync } from "node:fs";
 import { randomBytes } from "node:crypto";
 import { dirname, join } from "node:path";
 import { STATE_DIR, tomlString } from "./layout.js";
 import { send } from "./spool.js";
 import { withLock, readEntries } from "./log.js";
+import { loadConfig, policyId } from "./config.js";
 
 const REQUESTS_NAME = "requests.jsonl";
 
@@ -97,7 +100,9 @@ function write(file, entry) {
     mkdirSync(dirname(file), { recursive: true });
     // The time is this process's, named after the spread so no entry sets it.
     const now = new Date().toISOString();
-    appendFileSync(file, JSON.stringify({ at: now, ...entry, at: now }) + "\n");
+    // Under the queue's lock, as the log's lines are under the log's: the one
+    // rewrite the queue ever gets (migrateQueue) cannot then miss this line.
+    withLock(file, () => appendFileSync(file, JSON.stringify({ at: now, ...entry, at: now }) + "\n"));
     return true;
   } catch {
     // Same rule as the log: never take the agent down over bookkeeping.
@@ -106,33 +111,149 @@ function write(file, entry) {
 }
 
 /**
- * Who a read request's key belongs to, from the policy as it is now.
+ * Who each request goes to, decided now (handoff.js), and whose it is.
  *
- * A key is declared, not owned: nobody writes `.secrets/`, so the owners a
- * write-territory lookup finds for one are always none, and the queue said
- * "(unowned)" about a key another role declares — right before a grant that
- * would share it. Recomputed rather than read from the line, like every other
- * field that decides what a person is shown.
+ * Every reader of the queue goes through here — `seisin requests`, the end of
+ * `seisin run`, the notification, the console, the MCP — so they cannot
+ * disagree about where a request goes, and none of them works it out on its
+ * own. `owners` is replaced by the decision's: the owners stored on the line
+ * are who owned the path when it was denied, which is evidence; who owns it
+ * now is the policy's answer, and that is the one shown. For a key it is who
+ * declares it — nobody writes `.secrets/`, and the queue used to say
+ * "(unowned)" about a key another role declares, right before a grant that
+ * would share it.
+ *
+ * `handoff` is the decision as decideHandoff returns it: `type` is route,
+ * human, resolved, cycle or depth, and a route names `role`. It is the field
+ * something outside seisin reads to act on; seisin itself starts nothing.
  */
-export function withDeclarers(config, queue) {
+export function withHandoffs(config, queue, revision = policyId(config)) {
+  // Reading the queue must not be the thing that fails: a caller holding only
+  // a root gets every request decided as nobody's, which is what it can know.
+  const policy = config?.roles ? config : { ...config, roles: {} };
   for (const r of queue) {
-    if (r.action !== "read" || typeof r.target !== "string") continue;
-    if (!inKeyDir(config, r.target) && r.target.includes("/")) continue;
-    r.owners = keyHolders(config, r.target);
-    r.declared = true;
+    if (typeof r.role !== "string" || typeof r.target !== "string") continue;
+    r.ownersThen = r.owners;
+    r.handoff = decideHandoff({ request: r, config: policy, chain: chainOf(r), revision });
+    r.owners = r.handoff.owners ?? [];
+    if (isKeyRequest(config, r)) r.declared = true;
+  }
+  // Each request's chain is named by the request it started from. Where a
+  // later request in that chain stopped — a cycle, too deep, a person's call —
+  // the one it started from says so: seisin cannot know whether the role that
+  // took it finished, but it knows the chain did not end in a handoff.
+  const stoppedIn = new Map();
+  for (const q of queue) {
+    const id = q.chain?.id;
+    if (!id || id === q.key || !["cycle", "depth", "human"].includes(q.handoff?.type)) continue;
+    stoppedIn.set(id, [...(stoppedIn.get(id) ?? []), q.key]);
   }
+  for (const r of queue) if (stoppedIn.has(r.key)) r.chainStopped = stoppedIn.get(r.key);
   return queue;
 }
 
-/** Records that a role asked for something the policy denies it. Safe to call
- *  on every denial; `seisin run` drops anything the policy does not deny. */
-export function record(file, { role, action, target, owners }) {
-  return write(file, { kind: "asked", key: keyOf({ role, action, target }), role, action, target, owners: owners ?? [] });
+/**
+ * The pending queue as a person and an agent read it: keys in the policy's own
+ * form, each request's handoff decided against the policy as it stands, and —
+ * given the log — the ones the role stopped asking for marked. `readOnly` is
+ * pending()'s: the MCP server reads the queue and never migrates it.
+ */
+export function queueOf(config, history = null, { readOnly = false } = {}) {
+  const queue = withHandoffs(config, pending(requestsPath(config.root), { keyDirs: config.keyDirs, readOnly }));
+  return history ? markStale(queue, history) : queue;
+}
+
+/**
+ * The queue as data: what `seisin requests --json` prints and `seisin_requests`
+ * returns, one shape for both.
+ *
+ * `handoff` is the field to act on. It is decided by seisin from the policy as
+ * it stands (handoff.js) and carried whole, so whatever reads it — an agent, a
+ * script that starts roles — is reading a decision and not making one: a route
+ * names the role, and `seisin run <role> --handoff <id>` refuses any other.
+ */
+export function queueData(queue) {
+  return {
+    pending: queue.map((r, i) => ({
+      number: i + 1, id: r.key, role: r.role, action: r.action, target: r.target,
+      wants: r.grant, ownedBy: r.owners, asked: r.times, lastAsked: r.last,
+      handoff: r.handoff ?? null,
+      ...(r.attempt ? { attempt: r.attempt } : {}),
+      ...(r.chainStopped ? { chainStopped: r.chainStopped } : {}),
+      ...(r.stale ? { stale: `not asked again in ${r.stale.runs} runs of ${r.role} since` } : {}),
+    })),
+  };
 }
 
-/** Records a decision. `by` is always a person; there is no other caller. */
-export function settle(file, key, decision, reason = "") {
-  return write(file, { kind: decision, key, reason });
+/**
+ * Records that a role asked for something the policy denies it. Safe to call
+ * on every denial; `seisin run` drops anything the policy does not deny.
+ *
+ * `chain` is set only by a run started for a handoff (`seisin run --handoff`),
+ * from the decision the parent checked before starting it — never from
+ * anything the sandbox sent. A line without one starts a chain of its own.
+ */
+export function record(file, { role, action, target, owners, chain = null }) {
+  return write(file, {
+    kind: "asked", key: keyOf({ role, action, target }), role, action, target, owners: owners ?? [],
+    ...(chain && { chain: { id: chain.id, depth: chain.depth, visited: chain.visited } }),
+  });
+}
+
+/**
+ * Records a decision. `by` is always a person; there is no other caller.
+ *
+ * `only` is the one file a grant covered when the person chose it over the
+ * folder the request is keyed by. The key stays the folder's, so the queue
+ * needs to know: a later ask for a sibling is a new question, not this one
+ * asked again (see reduce).
+ */
+export function settle(file, key, decision, reason = "", { only = null } = {}) {
+  return write(file, { kind: decision, key, reason, ...(only ? { only } : {}) });
+}
+
+/**
+ * The same request, granting the one file it was asked over instead of the
+ * folder it is keyed by.
+ *
+ * Writes only: a key is already one file. The grant is the target exactly as
+ * the request carries it, so it reaches the policy as a literal path and goes
+ * through the same refuseIfBarred and applyGrant as the folder does.
+ */
+export function asFileGrant(request) {
+  if (request.action === "read")
+    throw new Error(`${request.key} is a key, and a key is already one file — grant it without --file`);
+  if (request.action !== "write")
+    throw new Error(`only a write can be granted as one file, and ${request.key} is a ${request.action}`);
+  const t = typeof request.target === "string" ? request.target : "";
+  if (!t || t.endsWith("/") || t.includes("*"))
+    throw new Error(`${JSON.stringify(t)} is not one file — grant the folder instead`);
+  return { ...request, grant: t, only: t };
+}
+
+/**
+ * The agent a role ran last, as its last canary line recorded it, or null.
+ *
+ * Asked for one reason: a literal file in `writes` is useless to Claude Code,
+ * whose Write and Edit save to a temporary beside the file and rename over it
+ * (docs/first-day.md). Null when the role never ran or ran before the canary
+ * line carried the agent — the caller then says it conditionally.
+ */
+export function lastAgentOf(entries, role) {
+  for (let i = entries.length - 1; i >= 0; i--) {
+    const e = entries[i];
+    if (e?.event === "canary" && e.role === role) return typeof e.agent === "string" ? e.agent : null;
+  }
+  return null;
+}
+
+/** One line on what a file-only grant does to a role that runs Claude Code, or "". */
+export function fileOnlyNote(role, agent) {
+  const why = "Claude Code's Write and Edit save to a temporary beside the file and rename it over, " +
+    "and the temporary is outside a one-file grant (EPERM)";
+  if (agent === "claude") return `${role} runs Claude Code: ${why} — grant the folder if it edits this file.`;
+  if (agent) return "";
+  return `If ${role} runs Claude Code, a one-file grant will not let it edit: ${why}.`;
 }
 
 /**
@@ -148,8 +269,9 @@ export function settle(file, key, decision, reason = "") {
  * It exists so that a refusal to run cannot be invisible. Admission may
  * postpone work; it may not make work disappear from the queue a person reads.
  *
- * Nothing in src/ calls it today — handoff.js decides but nothing records the
- * outcome; the tests do, and pending() keeps reading what it writes.
+ * `seisin run --handoff` writes one when it starts the receiver; whatever
+ * else starts roles writes one when it holds one back. It reaches a request
+ * as `attempt`, beside the decision, and never as `state`.
  */
 export function recordHandoff(file, key, decision = {}) {
   const { type, role, limit, max, reason, depth, chainId, revision } = decision;
@@ -178,14 +300,28 @@ export function recordHandoff(file, key, decision = {}) {
  */
 let reduced = null;   // { file, ino, size, mtimeMs, all }
 
-export function pending(file, { includeSettled = false, keyDirs = null } = {}) {
+/**
+ * `readOnly` is for the MCP server, which opens nothing for writing: a queue
+ * that still needs migrating is an error there, never a rewrite (migrateQueue).
+ */
+export function pending(file, { includeSettled = false, keyDirs = null, readOnly = false } = {}) {
   let st;
   try { st = statSync(file); } catch { return []; }
   let all;
   if (reduced && reduced.file === file && reduced.ino === st.ino && reduced.size === st.size && reduced.mtimeMs === st.mtimeMs) {
     all = reduced.all;
   } else {
-    all = reduce(file);
+    let entries = readEntries(file);
+    // Twice at most: a line an older seisin appended while the first pass ran
+    // is caught by the second; one still there after that is an error, not a guess.
+    for (let pass = 0; pass < 2 && entries.some(isOldDecline); pass++) {
+      if (readOnly) throw unmigrated(file, entries.filter(isOldDecline).length);
+      migrateQueue(file);
+      st = statSync(file);
+      entries = readEntries(file);
+    }
+    if (entries.some(isOldDecline)) throw unmigrated(file, entries.filter(isOldDecline).length);
+    all = reduce(entries);
     reduced = { file, ino: st.ino, size: st.size, mtimeMs: st.mtimeMs, all };
   }
   // The grant is re-derived with the policy's first key directory when the
@@ -195,20 +331,40 @@ export function pending(file, { includeSettled = false, keyDirs = null } = {}) {
   return includeSettled ? copies : copies.filter((r) => r.state === "pending");
 }
 
-function reduce(file) {
+function reduce(entries) {
   const byKey = new Map();
 
-  for (const e of readEntries(file)) {
+  for (const e of entries) {
     if (!e.key) continue;
 
     if (e.kind === "asked") {
       const seen = byKey.get(e.key);
-      if (seen) { seen.times++; seen.last = e.at; continue; }
-      byKey.set(e.key, {
+      /**
+       * A grant of one file answered that file, not the folder the key names.
+       * A sibling asked after it is a new question: reopened with that target,
+       * so it reaches the queue instead of folding into a settled request that
+       * nobody reads again. The same file asked again folds as before.
+       */
+      if (seen && seen.state === "granted" && seen.only?.length && typeof e.target === "string" &&
+          !seen.only.includes(e.target)) {
+        Object.assign(seen, {
+          target: e.target, owners: e.owners ?? [], grant: grantFor(e),
+          times: 1, first: e.at, last: e.at, state: "pending", reason: "",
+        });
+        delete seen.decided;
+        delete seen.chain;
+        delete seen.attempt;
+        keepChain(seen, e);
+        continue;
+      }
+      if (seen) { seen.times++; seen.last = e.at; keepChain(seen, e); continue; }
+      const fresh = {
         key: e.key, role: e.role, action: e.action, target: e.target,
         owners: e.owners ?? [], grant: grantFor(e),
         times: 1, first: e.at, last: e.at, state: "pending", reason: "",
-      });
+      };
+      keepChain(fresh, e);
+      byKey.set(e.key, fresh);
       continue;
     }
     const seen = byKey.get(e.key);
@@ -219,11 +375,12 @@ function reduce(file) {
      *
      * Without this branch the catch-all below would set state = "handoff" and a
      * throttled attempt would drop out of the pending queue — the exact silent
-     * disappearance the attempt is recorded to prevent. (Only the tests write
-     * handoff lines today — see recordHandoff.)
+     * disappearance the attempt is recorded to prevent. It is `attempt`, not
+     * `handoff`: the decision is recomputed on every read (withHandoffs), and
+     * what was tried is a different fact from where it goes.
      */
     if (e.kind === "handoff") {
-      seen.handoff = {
+      seen.attempt = {
         outcome: e.outcome, role: e.role, limit: e.limit, max: e.max,
         reason: e.reason, depth: e.depth, chainId: e.chainId, at: e.at,
       };
@@ -231,11 +388,143 @@ function reduce(file) {
     }
 
     seen.state = e.kind; seen.reason = e.reason ?? ""; seen.decided = e.at;
+    // Kept across reopenings: every file granted one at a time stays answered.
+    if (e.kind === "granted") {
+      if (typeof e.only === "string") seen.only = [...(seen.only ?? []), e.only];
+      else delete seen.only;
+    }
   }
 
   return [...byKey.values()];
 }
 
+/**
+ * A decline as seisin wrote it before 0.6.0: `kind: "denied"`.
+ *
+ * A person declines; the boundary denies (docs/glossary.md). The queue stored
+ * the boundary's word for the person's answer, and 0.6.0 stores "declined".
+ * Nothing reads the old value as a decline: a queue that holds one is
+ * rewritten once by migrateQueue, or refused where it cannot be.
+ */
+const OLD_DECLINE = "denied";
+
+function isOldDecline(e) {
+  return e.kind === OLD_DECLINE && typeof e.key === "string" && e.verdict === undefined;
+}
+
+function unmigrated(file, n) {
+  return Object.assign(new Error(
+    `${file} holds ${n} decline${n === 1 ? "" : "s"} written by seisin before 0.6.0 ` +
+    `as "kind":"denied", which this version does not read.\n` +
+    `  Run \`seisin requests\` once from a terminal: it rewrites them as "declined" and ` +
+    `keeps the original beside the queue as requests.jsonl.pre-0.6.0.`), { code: "EQUEUEFORMAT" });
+}
+
+/** One chunk of the queue with every old decline renamed; anything else, byte for byte. */
+function renameDeclines(text) {
+  let n = 0;
+  const lines = text.split("\n");
+  // The last piece has no newline after it: a line still being written, or
+  // nothing. It is copied as it is, and a later open migrates it if it must.
+  for (let i = 0; i < lines.length - 1; i++) {
+    let e;
+    try { e = JSON.parse(lines[i]); } catch { continue; }
+    if (!e || typeof e !== "object" || !isOldDecline(e)) continue;
+    lines[i] = JSON.stringify({ ...e, kind: "declined" });
+    n++;
+  }
+  return { text: lines.join("\n"), n };
+}
+
+/** Bytes of `fd` from `from` to its end, as it is now. */
+function readFrom(fd, from) {
+  const size = fstatSync(fd).size;
+  const buf = Buffer.alloc(Math.max(0, size - from));
+  let got = 0;
+  while (got < buf.length) {
+    const n = readSync(fd, buf, got, buf.length - got, from + got);
+    if (n === 0) break;
+    got += n;
+  }
+  return buf.subarray(0, got);
+}
+
+/**
+ * Rewrite the old declines of a queue as "declined", once. Returns how many.
+ *
+ * The one place the queue is not appended to, and why that is allowed is in
+ * docs/decisions.md: it renames one stored value, keeps every line, its order
+ * and its time, and copies the file as it was to `requests.jsonl.pre-0.6.0`
+ * before touching it, so the evidence is still there, word for word.
+ *
+ * Every line seisin 0.6.0 appends takes the queue's lock (write), and so does
+ * this, so none of those can land between the read and the rename. A run
+ * started by an older seisin and still going appends without it; for that one
+ * the rewrite follows the old file instead of trusting the lock: it works from
+ * one open descriptor, copies what was appended while it worked, renames, and
+ * keeps copying what still lands in the old file until it has been quiet for
+ * FOLLOW_QUIET_MS. Such an append opened the file before the rename and writes
+ * microseconds later; the wait is a hundred times that.
+ */
+const FOLLOW_QUIET_MS = 50;
+
+export function migrateQueue(file) {
+  return withLock(file, () => {
+    let fd;
+    try { fd = openSync(file, "r"); } catch (e) { if (e.code === "ENOENT") return 0; throw e; }
+    try {
+      const before = readFrom(fd, 0);
+      let read = before.length;
+      const first = renameDeclines(before.toString("utf8"));
+      if (!first.n) return 0;
+      let n = first.n;
+      const mode = fstatSync(fd).mode & 0o777;
+      let backup = `${file}.pre-0.6.0`;
+      try { writeFileSync(backup, before, { flag: "wx", mode }); }
+      catch (e) {
+        if (e.code !== "EEXIST") throw e;
+        backup = `${file}.pre-0.6.0.${Date.now()}`;
+        writeFileSync(backup, before, { flag: "wx", mode });
+      }
+      const tmp = join(dirname(file), `.requests.migrate-${randomBytes(8).toString("hex")}`);
+      writeFileSync(tmp, first.text, { flag: "wx", mode });
+      try {
+        const more = readFrom(fd, read);
+        read += more.length;
+        const tail = renameDeclines(more.toString("utf8"));
+        n += tail.n;
+        appendFileSync(tmp, tail.text);
+        renameSync(tmp, file);
+      } catch (e) { try { unlinkSync(tmp); } catch {} throw e; }
+      const until = Date.now() + 2000;
+      for (let quiet = Date.now(); Date.now() - quiet < FOLLOW_QUIET_MS && Date.now() < until;) {
+        const late = readFrom(fd, read);
+        if (!late.length) { Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 5); continue; }
+        read += late.length;
+        quiet = Date.now();
+        const tail = renameDeclines(late.toString("utf8"));
+        n += tail.n;
+        appendFileSync(file, tail.text);
+      }
+      return n;
+    } finally { closeSync(fd); }
+  });
+}
+
+/**
+ * The chain a request was asked in, kept as the deepest one seen.
+ *
+ * One request (same role, action, folder) can be asked by a run that was
+ * handed work and by one that was not. The deeper chain is the one that knows
+ * more of where the work has been, so it is the one kept: dropping it on a
+ * later plain ask would let the work be handed back to a role it came from.
+ */
+function keepChain(seen, e) {
+  const c = e.chain;
+  if (!c || typeof c !== "object" || !Number.isInteger(c.depth)) return;
+  if (!seen.chain || c.depth > seen.chain.depth) seen.chain = c;
+}
+
 /**
  * How many runs of the role, after the last time it asked, make a request old.
  *
@@ -328,11 +617,33 @@ export function refuseIfBarred(config, request) {
         `what you mean; otherwise decline this request.`
       : `${request.target} is protected (${guard.why}) and no role can ever be granted it. ` +
         `Decline this request.`);
+  // Another role's private folder: the kernel denies it to every role but its
+  // owner, however wide `writes` gets, so a grant would read as done and open nothing.
+  const mine = privateOwner(config, request.target);
+  if (mine && mine.role !== request.role)
+    throw new Error(
+      `${request.target} is in ${mine.role}'s private folder (private = ["${mine.entry}"]): every other role ` +
+      `is denied it, so a grant to ${request.role} would change nothing. Decline this request, or move the ` +
+      `folder out of ${mine.role}'s private list if it should not be private.`);
   // Only a repository the role does not write: its own `.git` is its own business.
   if (isGitMetadata(request.target) && !(role?.writes ?? []).some((g) => covers(g, request.target)))
     throw new Error(
       `${request.target} is git's own bookkeeping, not a territory: granting it lets ${request.role} ` +
       `rewrite another owner's history. Decline it; a role that needs to commit gets a worktree of its own.`);
+  /**
+   * The whole repository is never granted from a request. A request is one
+   * denied path; the grant it derives is that path's folder, and at the root
+   * that folder is everything — every other role's territory included. A role
+   * that should write the whole repo gets `writes = ["**"]` from a person
+   * editing the policy, not from approving one denial.
+   */
+  const grant = request.grant ?? grantFor(request);
+  const g = String(grant).replace(/^\.\/+/, "").replace(/\/+$/, "");
+  if (["", ".", "*", "**", "./**"].includes(g) || /^(\*\*\/)*\*\*$/.test(g))
+    throw new Error(
+      `this request would grant ${request.role} the whole repository ("${grant}"), every other ` +
+      `role's territory included. A request cannot do that: decline it, and if ${request.role} really ` +
+      `should write everything, edit [roles.${request.role}] writes by hand.`);
 }
 
 /**
@@ -355,7 +666,11 @@ export function editPolicy(config, mutate, { waitMs = 10000, after = null } = {}
   return withLock(policyLockBase(config), () => {
     const before = readFileSync(config.path, "utf8");
     const result = mutate(before);
-    if (result.changed) writePolicy(config, result.toml);
+    if (result.changed) {
+      // A decision cannot settle against text the next run cannot load.
+      loadConfig(config.path, result.toml);
+      writePolicy(config, result.toml);
+    }
     after?.(result);
     return result;
   }, { waitMs });
@@ -391,10 +706,12 @@ export function policyLockBase(config) {
  * exclusive, which is what defeats a planted name.
  */
 function writePolicy(config, text) {
+  const mode = statSync(config.path).mode & 0o777;
   const name = `seisin.toml.tmp-${randomBytes(12).toString("hex")}`;
   const stateTmp = join(config.root, STATE_DIR, name);
-  writeFileSync(stateTmp, text, { flag: "wx" });
+  writeFileSync(stateTmp, text, { flag: "wx", mode });
   try {
+    chmodSync(stateTmp, mode);
     renameSync(stateTmp, config.path);
     return;
   } catch (e) {
@@ -402,8 +719,8 @@ function writePolicy(config, text) {
     if (e.code !== "EXDEV") throw e;
   }
   const near = join(dirname(config.path), `.${name}`);
-  writeFileSync(near, text, { flag: "wx" });
-  try { renameSync(near, config.path); }
+  writeFileSync(near, text, { flag: "wx", mode });
+  try { chmodSync(near, mode); renameSync(near, config.path); }
   catch (e) { try { unlinkSync(near); } catch {} throw e; }
 }
 
@@ -424,17 +741,17 @@ function writePolicy(config, text) {
  */
 export function applyGrant(toml, request, note = "") {
   const field = request.action === "read" ? "keys" : "writes";
-  const header = new RegExp(`^\\[roles\\.${escapeRe(request.role)}\\]\\s*$`, "m");
+  const header = new RegExp(`^[ \\t]*\\[roles\\.${escapeRe(request.role)}\\][ \\t\\r]*(?:#[^\\n]*)?$`, "m");
   const at = header.exec(toml);
   if (!at) throw new Error(`no [roles.${request.role}] section to grant into`);
 
   // The section runs from its header to the next table header, or to the end.
   const from = at.index + at[0].length;
-  const next = /^\[[^\]]+\]\s*$/m.exec(toml.slice(from));
+  const next = /^[ \t]*\[[A-Za-z0-9_.\-]+\][ \t\r]*(?:#[^\n]*)?$/m.exec(toml.slice(from));
   const to = next ? from + next.index : toml.length;
   const section = toml.slice(from, to);
 
-  const open = new RegExp(`^${field}\\s*=\\s*\\[`, "m").exec(section);
+  const open = new RegExp(`^[ \\t]*${field}[ \\t]*=[ \\t]*\\[`, "m").exec(section);
   if (!open)
     throw new Error(
       `[roles.${request.role}] has no ${field} list to grant into. ` +
@@ -470,7 +787,8 @@ export function applyGrant(toml, request, note = "") {
   }
   const stamp = `# granted ${new Date().toISOString().slice(0, 10)} · asked ${request.times}×` +
                 `${note ? ` · «${cleanReason(note)}»` : ""}`;
-  const edited = section.slice(0, start) + `${inner}\n  "${request.grant}"   ${stamp}\n]` + section.slice(list.end + 1);
+  const eol = toml.includes("\r\n") ? "\r\n" : "\n";
+  const edited = section.slice(0, start) + `${inner}${eol}  "${request.grant}"   ${stamp}${eol}]` + section.slice(list.end + 1);
   return { toml: toml.slice(0, from) + edited + toml.slice(to), changed: true };
 }
 

package/src/review.js

@@ -29,7 +29,7 @@
  */
 import { read, logPath } from "./log.js";
 import { covers, standingOf } from "./owners.js";
-import { kindsOf } from "./kinds.js";
+import { kindsOf, expectedOf } from "./kinds.js";
 
 /**
  * One reading of the log against the policy.
@@ -38,16 +38,18 @@ import { kindsOf } from "./kinds.js";
  * is low on purpose: the cost of mentioning it is a line, and the cost of
  * missing it is a role that quietly cannot do its job.
  */
-export function review(config, { minDenials = 3 } = {}) {
-  const entries = read(logPath(config.root), { limit: 0 });
+export function review(config, { minDenials = 3, since = null } = {}) {
+  // `since`: an ISO time (views.js parseSince). Without it the whole log, and
+  // on a log months long "denied repeatedly" is led by paths fixed long ago.
+  const entries = read(logPath(config.root), { limit: 0, ...(since && { since }) });
 
   if (entries.length === 0)
-    return { window: null, entries: 0, friction: [], guarded: [], unused: [], unusedKnowable: false, unowned: [] };
+    return { window: null, ...(since && { since }), entries: 0, friction: [], expected: [], guarded: [], unused: [], unusedKnowable: false, unowned: [] };
 
   const at = entries.map((e) => e.at).filter(Boolean).sort();
   const window = { from: at[0], to: at[at.length - 1], entries: entries.length };
 
-  return { window, entries: entries.length, ...findings(config, entries, minDenials) };
+  return { window, ...(since && { since }), entries: entries.length, ...findings(config, entries, minDenials) };
 }
 
 function findings(config, entries, minDenials) {
@@ -74,15 +76,19 @@ function findings(config, entries, minDenials) {
   const stopped = new Map();                 // role + directory -> how often
   for (const e of entries) {
     if (e.verdict !== "denied" || !e.target) continue;
-    const dir = e.action === "read" || e.action === "connect" ? e.target : dirOf(e.target);
-    const key = `${e.role} ${e.action} ${dir}`;
+    // The caller's own probe (`seisin run --expect-denied`): denied on purpose.
+    if (e.expected === true) continue;
+    const dir = e.action === "read" || e.action === "connect" || e.kind === "system" ? e.target : dirOf(e.target);
+    const expected = expectedOf(e.target);
+    const key = `${e.role} ${e.action} ${dir}${expected ? " expected" : ""}`;
     const seen = stopped.get(key) ?? {
       role: e.role, action: e.action, where: dir, times: 0,
       owners: e.owners ?? [],
+      ...(expected && { expected }),
       // Carried by the log from both writers — the hook sets it from the config
       // and so does the parent for a kernel denial. Recomputing it from the path
       // here would be a second opinion on a settled question.
-      kind: e.kind === "key" || e.kind === "network" ? e.kind : "file",
+      kind: e.kind === "key" || e.kind === "network" || e.kind === "system" ? e.kind : "file",
     };
     seen.times++;
     stopped.set(key, seen);
@@ -92,7 +98,12 @@ function findings(config, entries, minDenials) {
     .filter((f) => f.times >= minDenials)
     .sort((a, b) => b.times - a.times);
 
-  const friction = repeated.filter((f) => f.kind !== "key" && f.kind !== "network");
+  // Expected (kinds.js expectedOf): Claude Code's plugin updater, refused
+  // correctly. Repeated on every start, and not a policy that is wrong — so it
+  // is said apart and never counts as friction, which is what exits 1.
+  const expected = repeated.filter((f) => f.expected);
+  // A system service is once per run (intake.js) and never grantable: not friction.
+  const friction = repeated.filter((f) => !f.expected && f.kind !== "key" && f.kind !== "network" && f.kind !== "system");
   const guarded = repeated.filter((f) => f.kind === "key");
   // Ports and sockets: repeated, and not a thing `grant` can answer.
   const connects = repeated.filter((f) => f.kind === "network");
@@ -179,6 +190,7 @@ function findings(config, entries, minDenials) {
 
   return {
     friction,
+    expected,
     guarded,
     connects,
     unused,