scai 0.1.178 → 1.0.1

package/dist/__tests__/agents/agentFeedback.test.js

@@ -0,0 +1,118 @@
+/**
+ * Verifies the simple-agent feedback module owns waiting state and reply handling.
+ *
+ * Why this file exists:
+ * - waiting should be a real runtime state instead of a shell-only pause
+ * - follow-up replies should resume the same task through one shared module
+ */
+import { describe, expect, it } from "vitest";
+import { buildRequestUserInputMessage, continueAgentTaskFromFeedback, prepareAgentWaitingState } from "../../agents/agentFeedback.js";
+import { createAgentMemory } from "../../agents/agentMemory.js";
+import { setWaitingTask } from "../../agents/agentStateMachine.js";
+describe("agentFeedback", () => {
+    it("creates one task-scoped clarification dialog for waiting runs", () => {
+        const memory = createAgentMemory("Explain the retry setup", "/repo", "/repo");
+        const dialog = prepareAgentWaitingState(memory);
+        expect(dialog).toMatchObject({
+            status: "awaiting-user",
+            kind: "clarification",
+        });
+        expect(dialog.prompt).toContain("Reply with");
+        expect(memory.task.dialogState).toEqual(dialog);
+    });
+    it("lists concrete path options for an ambiguous explicit filename", () => {
+        const memory = createAgentMemory("Explain README.md", "/repo", "/repo");
+        memory.task.explicitTargets = ["README.md"];
+        memory.evidence.candidateFiles = ["/repo/cli/README.md", "/repo/docs/README.md"];
+        memory.evidence.candidateMetadata = {
+            "/repo/cli/README.md": { searchReasons: ["exact-basename:readmemd"] },
+            "/repo/docs/README.md": { searchReasons: ["exact-basename:readmemd"] },
+        };
+        const dialog = prepareAgentWaitingState(memory);
+        expect(dialog.prompt).toContain("README.md");
+        expect(dialog.target).toBe("README.md");
+        expect(dialog.options).toEqual(["/repo/cli/README.md", "/repo/docs/README.md"]);
+        expect(dialog.allowFreeText).toBe(true);
+    });
+    it("renders numbered path options in the waiting message", () => {
+        const memory = createAgentMemory("Explain README.md", "/repo", "/repo");
+        memory.task.explicitTargets = ["README.md"];
+        memory.evidence.candidateFiles = ["/repo/cli/README.md", "/repo/docs/README.md"];
+        memory.evidence.candidateMetadata = {
+            "/repo/cli/README.md": { searchReasons: ["exact-basename:readmemd"] },
+            "/repo/docs/README.md": { searchReasons: ["exact-basename:readmemd"] },
+        };
+        const dialog = prepareAgentWaitingState(memory);
+        const message = buildRequestUserInputMessage(memory, dialog);
+        expect(message).toContain('Which in-repo file path did you mean for "README.md"?');
+        expect(message).toContain("1. /repo/cli/README.md");
+        expect(message).toContain("2. /repo/docs/README.md");
+        expect(message).toContain("Choose [1-2] or paste a path.");
+    });
+    it("applies one follow-up reply and resumes the same waiting task", () => {
+        const memory = createAgentMemory("Explain the retry setup", "/repo", "/repo");
+        prepareAgentWaitingState(memory);
+        setWaitingTask(memory);
+        const resumed = continueAgentTaskFromFeedback(memory, "cli/src/agents/agentPolicyState.ts");
+        expect(resumed).toBe(true);
+        expect(memory.task.status).toBe("active");
+        expect(memory.task.stopReason).toBeUndefined();
+        expect(memory.task.dialogState).toMatchObject({
+            status: "answered",
+            response: "cli/src/agents/agentPolicyState.ts",
+            comment: "cli/src/agents/agentPolicyState.ts",
+        });
+        expect(memory.task.initialQuery).toContain("User clarification:");
+        expect(memory.evidence.notes).toContain("User clarification: cli/src/agents/agentPolicyState.ts");
+    });
+    it("binds a selected ambiguous path choice into the task override map", () => {
+        const memory = createAgentMemory("Explain README.md", "/repo", "/repo");
+        memory.task.explicitTargets = ["README.md"];
+        memory.evidence.candidateFiles = ["/repo/cli/README.md", "/repo/docs/README.md"];
+        memory.evidence.candidateMetadata = {
+            "/repo/cli/README.md": { searchReasons: ["exact-basename:readmemd"] },
+            "/repo/docs/README.md": { searchReasons: ["exact-basename:readmemd"] },
+        };
+        prepareAgentWaitingState(memory);
+        setWaitingTask(memory);
+        const resumed = continueAgentTaskFromFeedback(memory, "/repo/docs/README.md");
+        expect(resumed).toBe(true);
+        expect(memory.task.explicitTargetOverrides).toEqual({
+            "README.md": "/repo/docs/README.md",
+        });
+    });
+    it("accepts a numbered reply for an ambiguous path choice", () => {
+        const memory = createAgentMemory("Explain README.md", "/repo", "/repo");
+        memory.task.explicitTargets = ["README.md"];
+        memory.evidence.candidateFiles = ["/repo/cli/README.md", "/repo/docs/README.md"];
+        memory.evidence.candidateMetadata = {
+            "/repo/cli/README.md": { searchReasons: ["exact-basename:readmemd"] },
+            "/repo/docs/README.md": { searchReasons: ["exact-basename:readmemd"] },
+        };
+        prepareAgentWaitingState(memory);
+        setWaitingTask(memory);
+        const resumed = continueAgentTaskFromFeedback(memory, "2");
+        expect(resumed).toBe(true);
+        expect(memory.task.dialogState).toMatchObject({
+            status: "answered",
+            selectedOption: "/repo/docs/README.md",
+        });
+        expect(memory.task.explicitTargetOverrides).toEqual({
+            "README.md": "/repo/docs/README.md",
+        });
+    });
+    it("keeps earlier clarifications when the same task waits more than once", () => {
+        const memory = createAgentMemory("Explain the retry setup", "/repo", "/repo");
+        prepareAgentWaitingState(memory);
+        setWaitingTask(memory);
+        expect(continueAgentTaskFromFeedback(memory, "cli/src/agents/agentPolicyState.ts")).toBe(true);
+        const firstQuery = memory.task.initialQuery;
+        prepareAgentWaitingState(memory);
+        setWaitingTask(memory);
+        expect(continueAgentTaskFromFeedback(memory, "show the retry branch too")).toBe(true);
+        expect(memory.task.initialQuery).toContain("cli/src/agents/agentPolicyState.ts");
+        expect(memory.task.initialQuery).toContain("show the retry branch too");
+        expect(memory.task.initialQuery).toContain(firstQuery);
+    });
+});
+//# sourceMappingURL=agentFeedback.test.js.map

package/dist/__tests__/agents/agentFeedback.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agentFeedback.test.js","sourceRoot":"","sources":["../../../src/__tests__/agents/agentFeedback.test.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AACH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,4BAA4B,EAAE,6BAA6B,EAAE,wBAAwB,EAAE,MAAM,+BAA+B,CAAC;AACtI,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,cAAc,EAAE,MAAM,mCAAmC,CAAC;AAEnE,QAAQ,CAAC,eAAe,EAAE,GAAG,EAAE;IAC7B,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,MAAM,GAAG,iBAAiB,CAAC,yBAAyB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAE9E,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAEhD,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,CAAC;YAC3B,MAAM,EAAE,eAAe;YACvB,IAAI,EAAE,eAAe;SACtB,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;QACxE,MAAM,MAAM,GAAG,iBAAiB,CAAC,mBAAmB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACxE,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,CAAC,WAAW,CAAC,CAAC;QAC5C,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,iBAAiB,GAAG;YAClC,qBAAqB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;YACrE,sBAAsB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;SACvE,CAAC;QAEF,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAEhD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAAC,CAAC;QAChF,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;QAC9D,MAAM,MAAM,GAAG,iBAAiB,CAAC,mBAAmB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACxE,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,CAAC,WAAW,CAAC,CAAC;QAC5C,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,iBAAiB,GAAG;YAClC,qBAAqB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;YACrE,sBAAsB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;SACvE,CAAC;QAEF,MAAM,MAAM,GAAG,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAChD,MAAM,OAAO,GAAG,4BAA4B,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;QAE7D,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,uDAAuD,CAAC,CAAC;QACnF,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,wBAAwB,CAAC,CAAC;QACpD,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,yBAAyB,CAAC,CAAC;QACrD,MAAM,CAAC,OAAO,CAAC,CAAC,SAAS,CAAC,+BAA+B,CAAC,CAAC;IAC7D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,MAAM,GAAG,iBAAiB,CAAC,yBAAyB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAC9E,wBAAwB,CAAC,MAAM,CAAC,CAAC;QACjC,cAAc,CAAC,MAAM,CAAC,CAAC;QAEvB,MAAM,OAAO,GAAG,6BAA6B,CAAC,MAAM,EAAE,oCAAoC,CAAC,CAAC;QAE5F,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3B,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC1C,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC,aAAa,EAAE,CAAC;QAC/C,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,aAAa,CAAC;YAC5C,MAAM,EAAE,UAAU;YAClB,QAAQ,EAAE,oCAAoC;YAC9C,OAAO,EAAE,oCAAoC;SAC9C,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,SAAS,CAAC,qBAAqB,CAAC,CAAC;QAClE,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,wDAAwD,CAAC,CAAC;IACpG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QAC3E,MAAM,MAAM,GAAG,iBAAiB,CAAC,mBAAmB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACxE,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,CAAC,WAAW,CAAC,CAAC;QAC5C,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,iBAAiB,GAAG;YAClC,qBAAqB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;YACrE,sBAAsB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;SACvE,CAAC;QACF,wBAAwB,CAAC,MAAM,CAAC,CAAC;QACjC,cAAc,CAAC,MAAM,CAAC,CAAC;QAEvB,MAAM,OAAO,GAAG,6BAA6B,CAAC,MAAM,EAAE,sBAAsB,CAAC,CAAC;QAE9E,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3B,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC;YAClD,WAAW,EAAE,sBAAsB;SACpC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,MAAM,GAAG,iBAAiB,CAAC,mBAAmB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QACxE,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,CAAC,WAAW,CAAC,CAAC;QAC5C,MAAM,CAAC,QAAQ,CAAC,cAAc,GAAG,CAAC,qBAAqB,EAAE,sBAAsB,CAAC,CAAC;QACjF,MAAM,CAAC,QAAQ,CAAC,iBAAiB,GAAG;YAClC,qBAAqB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;YACrE,sBAAsB,EAAE,EAAE,aAAa,EAAE,CAAC,yBAAyB,CAAC,EAAE;SACvE,CAAC;QACF,wBAAwB,CAAC,MAAM,CAAC,CAAC;QACjC,cAAc,CAAC,MAAM,CAAC,CAAC;QAEvB,MAAM,OAAO,GAAG,6BAA6B,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC;QAE3D,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3B,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC,aAAa,CAAC;YAC5C,MAAM,EAAE,UAAU;YAClB,cAAc,EAAE,sBAAsB;SACvC,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC;YAClD,WAAW,EAAE,sBAAsB;SACpC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,MAAM,GAAG,iBAAiB,CAAC,yBAAyB,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAC9E,wBAAwB,CAAC,MAAM,CAAC,CAAC;QACjC,cAAc,CAAC,MAAM,CAAC,CAAC;QAEvB,MAAM,CAAC,6BAA6B,CAAC,MAAM,EAAE,oCAAoC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC/F,MAAM,UAAU,GAAG,MAAM,CAAC,IAAI,CAAC,YAAY,CAAC;QAE5C,wBAAwB,CAAC,MAAM,CAAC,CAAC;QACjC,cAAc,CAAC,MAAM,CAAC,CAAC;QAEvB,MAAM,CAAC,6BAA6B,CAAC,MAAM,EAAE,2BAA2B,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtF,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,SAAS,CAAC,oCAAoC,CAAC,CAAC;QACjF,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,SAAS,CAAC,2BAA2B,CAAC,CAAC;QACxE,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Verifies the simple-agent feedback module owns waiting state and reply handling.\n *\n * Why this file exists:\n * - waiting should be a real runtime state instead of a shell-only pause\n * - follow-up replies should resume the same task through one shared module\n */\nimport { describe, expect, it } from \"vitest\";\nimport { buildRequestUserInputMessage, continueAgentTaskFromFeedback, prepareAgentWaitingState } from \"../../agents/agentFeedback.js\";\nimport { createAgentMemory } from \"../../agents/agentMemory.js\";\nimport { setWaitingTask } from \"../../agents/agentStateMachine.js\";\n\ndescribe(\"agentFeedback\", () => {\n  it(\"creates one task-scoped clarification dialog for waiting runs\", () => {\n    const memory = createAgentMemory(\"Explain the retry setup\", \"/repo\", \"/repo\");\n\n    const dialog = prepareAgentWaitingState(memory);\n\n    expect(dialog).toMatchObject({\n      status: \"awaiting-user\",\n      kind: \"clarification\",\n    });\n    expect(dialog.prompt).toContain(\"Reply with\");\n    expect(memory.task.dialogState).toEqual(dialog);\n  });\n\n  it(\"lists concrete path options for an ambiguous explicit filename\", () => {\n    const memory = createAgentMemory(\"Explain README.md\", \"/repo\", \"/repo\");\n    memory.task.explicitTargets = [\"README.md\"];\n    memory.evidence.candidateFiles = [\"/repo/cli/README.md\", \"/repo/docs/README.md\"];\n    memory.evidence.candidateMetadata = {\n      \"/repo/cli/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n      \"/repo/docs/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n    };\n\n    const dialog = prepareAgentWaitingState(memory);\n\n    expect(dialog.prompt).toContain(\"README.md\");\n    expect(dialog.target).toBe(\"README.md\");\n    expect(dialog.options).toEqual([\"/repo/cli/README.md\", \"/repo/docs/README.md\"]);\n    expect(dialog.allowFreeText).toBe(true);\n  });\n\n  it(\"renders numbered path options in the waiting message\", () => {\n    const memory = createAgentMemory(\"Explain README.md\", \"/repo\", \"/repo\");\n    memory.task.explicitTargets = [\"README.md\"];\n    memory.evidence.candidateFiles = [\"/repo/cli/README.md\", \"/repo/docs/README.md\"];\n    memory.evidence.candidateMetadata = {\n      \"/repo/cli/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n      \"/repo/docs/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n    };\n\n    const dialog = prepareAgentWaitingState(memory);\n    const message = buildRequestUserInputMessage(memory, dialog);\n\n    expect(message).toContain('Which in-repo file path did you mean for \"README.md\"?');\n    expect(message).toContain(\"1. /repo/cli/README.md\");\n    expect(message).toContain(\"2. /repo/docs/README.md\");\n    expect(message).toContain(\"Choose [1-2] or paste a path.\");\n  });\n\n  it(\"applies one follow-up reply and resumes the same waiting task\", () => {\n    const memory = createAgentMemory(\"Explain the retry setup\", \"/repo\", \"/repo\");\n    prepareAgentWaitingState(memory);\n    setWaitingTask(memory);\n\n    const resumed = continueAgentTaskFromFeedback(memory, \"cli/src/agents/agentPolicyState.ts\");\n\n    expect(resumed).toBe(true);\n    expect(memory.task.status).toBe(\"active\");\n    expect(memory.task.stopReason).toBeUndefined();\n    expect(memory.task.dialogState).toMatchObject({\n      status: \"answered\",\n      response: \"cli/src/agents/agentPolicyState.ts\",\n      comment: \"cli/src/agents/agentPolicyState.ts\",\n    });\n    expect(memory.task.initialQuery).toContain(\"User clarification:\");\n    expect(memory.evidence.notes).toContain(\"User clarification: cli/src/agents/agentPolicyState.ts\");\n  });\n\n  it(\"binds a selected ambiguous path choice into the task override map\", () => {\n    const memory = createAgentMemory(\"Explain README.md\", \"/repo\", \"/repo\");\n    memory.task.explicitTargets = [\"README.md\"];\n    memory.evidence.candidateFiles = [\"/repo/cli/README.md\", \"/repo/docs/README.md\"];\n    memory.evidence.candidateMetadata = {\n      \"/repo/cli/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n      \"/repo/docs/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n    };\n    prepareAgentWaitingState(memory);\n    setWaitingTask(memory);\n\n    const resumed = continueAgentTaskFromFeedback(memory, \"/repo/docs/README.md\");\n\n    expect(resumed).toBe(true);\n    expect(memory.task.explicitTargetOverrides).toEqual({\n      \"README.md\": \"/repo/docs/README.md\",\n    });\n  });\n\n  it(\"accepts a numbered reply for an ambiguous path choice\", () => {\n    const memory = createAgentMemory(\"Explain README.md\", \"/repo\", \"/repo\");\n    memory.task.explicitTargets = [\"README.md\"];\n    memory.evidence.candidateFiles = [\"/repo/cli/README.md\", \"/repo/docs/README.md\"];\n    memory.evidence.candidateMetadata = {\n      \"/repo/cli/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n      \"/repo/docs/README.md\": { searchReasons: [\"exact-basename:readmemd\"] },\n    };\n    prepareAgentWaitingState(memory);\n    setWaitingTask(memory);\n\n    const resumed = continueAgentTaskFromFeedback(memory, \"2\");\n\n    expect(resumed).toBe(true);\n    expect(memory.task.dialogState).toMatchObject({\n      status: \"answered\",\n      selectedOption: \"/repo/docs/README.md\",\n    });\n    expect(memory.task.explicitTargetOverrides).toEqual({\n      \"README.md\": \"/repo/docs/README.md\",\n    });\n  });\n\n  it(\"keeps earlier clarifications when the same task waits more than once\", () => {\n    const memory = createAgentMemory(\"Explain the retry setup\", \"/repo\", \"/repo\");\n    prepareAgentWaitingState(memory);\n    setWaitingTask(memory);\n\n    expect(continueAgentTaskFromFeedback(memory, \"cli/src/agents/agentPolicyState.ts\")).toBe(true);\n    const firstQuery = memory.task.initialQuery;\n\n    prepareAgentWaitingState(memory);\n    setWaitingTask(memory);\n\n    expect(continueAgentTaskFromFeedback(memory, \"show the retry branch too\")).toBe(true);\n    expect(memory.task.initialQuery).toContain(\"cli/src/agents/agentPolicyState.ts\");\n    expect(memory.task.initialQuery).toContain(\"show the retry branch too\");\n    expect(memory.task.initialQuery).toContain(firstQuery);\n  });\n});\n"]}

package/dist/__tests__/agents/agentGeneralScope.test.js

@@ -0,0 +1,74 @@
+/**
+ * Covers direct-answer handling for general questions in the new agent runtime.
+ *
+ * Why this file exists:
+ * - general questions should not drift into repo search when no repo target exists
+ * - policy should own the direct final-answer rule for general asks
+ * - one loop test keeps the git-bash regression covered end to end
+ */
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { createAgentMemory } from "../../agent/state/memory.js";
+import { resolvePolicyState } from "../../agent/policy/index.js";
+import { runAgentLoop } from "../../agent/runtime/runAgentLoop.js";
+const generateMock = vi.fn();
+vi.mock("../../lib/generate.js", () => ({
+    generate: (...args) => generateMock(...args),
+}));
+describe("general scope handling", () => {
+    beforeEach(() => {
+        generateMock.mockReset();
+    });
+    it("lets policy stop immediately for a general ask with no repo target", () => {
+        const memory = createAgentMemory("how do I use git bash to save a diff?", "/repo", "/repo");
+        memory.task.normalizedQuery = "how do I use git bash to save a diff";
+        memory.task.primaryIntent = "Learn how to save a git diff output to a file using Git Bash.";
+        memory.task.queryScope = "general";
+        const policy = resolvePolicyState(memory, { forcedEnd: true });
+        expect(policy.allowedActions).toEqual(["final-answer"]);
+        expect(policy.allowedActions).not.toContain("search-db");
+        expect(policy.decision.stop).toBe("final-answer");
+        expect(policy.endDecision?.action).toBe("final-answer");
+        expect(policy.reason).toContain("does not need grounded repo evidence");
+    });
+    it("answers a general ask without search-db or triage-file", async () => {
+        generateMock
+            .mockResolvedValueOnce({
+            data: JSON.stringify({
+                normalizedQuery: "how do I use git bash to save a diff",
+                queryScope: "general",
+                explicitTargets: [],
+                constraints: [],
+                primaryIntent: "Learn how to save a git diff output to a file using Git Bash.",
+                alternativeIntents: [],
+                searchTermGroups: [],
+                ambiguityFlags: [],
+            }),
+        })
+            .mockResolvedValueOnce({
+            data: "Use `git diff > my_diff.patch` to save the diff to a file.",
+        });
+        const memory = createAgentMemory("how do I use git bash to save a diff?", "/repo", "/repo");
+        const ui = {
+            update: vi.fn(),
+            message: vi.fn(),
+            pause: vi.fn((fn) => fn()),
+            succeed: vi.fn(),
+            fail: vi.fn(),
+            stop: vi.fn(),
+        };
+        await runAgentLoop(memory, ui);
+        expect(memory.task.status).toBe("done");
+        expect(memory.steps.map((step) => step.action)).toEqual(["final-answer"]);
+        expect(memory.steps.some((step) => step.action === "search-db")).toBe(false);
+        expect(memory.steps.some((step) => step.action === "triage-file")).toBe(false);
+        expect(memory.artifacts.finalAnswer).toContain("git diff > my_diff.patch");
+        expect(memory.artifacts.latestFinalAnswerPacket).toEqual(expect.objectContaining({
+            queryScope: "general",
+            mustMentionFiles: [],
+            mustMentionSymbols: [],
+            mustMentionFacts: [],
+        }));
+        expect(generateMock).toHaveBeenCalledTimes(2);
+    });
+});
+//# sourceMappingURL=agentGeneralScope.test.js.map

package/dist/__tests__/agents/agentGeneralScope.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agentGeneralScope.test.js","sourceRoot":"","sources":["../../../src/__tests__/agents/agentGeneralScope.test.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AACH,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,iBAAiB,EAAE,MAAM,6BAA6B,CAAC;AAChE,OAAO,EAAE,kBAAkB,EAAE,MAAM,6BAA6B,CAAC;AACjE,OAAO,EAAE,YAAY,EAAE,MAAM,qCAAqC,CAAC;AAEnE,MAAM,YAAY,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;AAE7B,EAAE,CAAC,IAAI,CAAC,uBAAuB,EAAE,GAAG,EAAE,CAAC,CAAC;IACtC,QAAQ,EAAE,CAAC,GAAG,IAAe,EAAE,EAAE,CAAC,YAAY,CAAC,GAAG,IAAI,CAAC;CACxD,CAAC,CAAC,CAAC;AAEJ,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;IACtC,UAAU,CAAC,GAAG,EAAE;QACd,YAAY,CAAC,SAAS,EAAE,CAAC;IAC3B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC5E,MAAM,MAAM,GAAG,iBAAiB,CAAC,uCAAuC,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAC5F,MAAM,CAAC,IAAI,CAAC,eAAe,GAAG,sCAAsC,CAAC;QACrE,MAAM,CAAC,IAAI,CAAC,aAAa,GAAG,+DAA+D,CAAC;QAC5F,MAAM,CAAC,IAAI,CAAC,UAAU,GAAG,SAAS,CAAC;QAEnC,MAAM,MAAM,GAAG,kBAAkB,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAC;QAE/D,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,OAAO,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC;QACxD,MAAM,CAAC,MAAM,CAAC,cAAc,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QACzD,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QAClD,MAAM,CAAC,MAAM,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;QACxD,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,sCAAsC,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACtE,YAAY;aACT,qBAAqB,CAAC;YACrB,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC;gBACnB,eAAe,EAAE,sCAAsC;gBACvD,UAAU,EAAE,SAAS;gBACrB,eAAe,EAAE,EAAE;gBACnB,WAAW,EAAE,EAAE;gBACf,aAAa,EAAE,+DAA+D;gBAC9E,kBAAkB,EAAE,EAAE;gBACtB,gBAAgB,EAAE,EAAE;gBACpB,cAAc,EAAE,EAAE;aACnB,CAAC;SACH,CAAC;aACD,qBAAqB,CAAC;YACrB,IAAI,EAAE,4DAA4D;SACnE,CAAC,CAAC;QAEL,MAAM,MAAM,GAAG,iBAAiB,CAAC,uCAAuC,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;QAC5F,MAAM,EAAE,GAAG;YACT,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE;YACf,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE;YAChB,KAAK,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC,EAAc,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC;YACtC,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE;YAChB,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;YACb,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;SACd,CAAC;QAEF,MAAM,YAAY,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;QAE/B,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACxC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,cAAc,CAAC,CAAC,CAAC;QAC1E,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,KAAK,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC7E,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,MAAM,KAAK,aAAa,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAC/E,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,0BAA0B,CAAC,CAAC;QAC3E,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC,MAAM,CAAC,gBAAgB,CAAC;YAC/E,UAAU,EAAE,SAAS;YACrB,gBAAgB,EAAE,EAAE;YACpB,kBAAkB,EAAE,EAAE;YACtB,gBAAgB,EAAE,EAAE;SACrB,CAAC,CAAC,CAAC;QACJ,MAAM,CAAC,YAAY,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["/**\n * Covers direct-answer handling for general questions in the new agent runtime.\n *\n * Why this file exists:\n * - general questions should not drift into repo search when no repo target exists\n * - policy should own the direct final-answer rule for general asks\n * - one loop test keeps the git-bash regression covered end to end\n */\nimport { beforeEach, describe, expect, it, vi } from \"vitest\";\nimport { createAgentMemory } from \"../../agent/state/memory.js\";\nimport { resolvePolicyState } from \"../../agent/policy/index.js\";\nimport { runAgentLoop } from \"../../agent/runtime/runAgentLoop.js\";\n\nconst generateMock = vi.fn();\n\nvi.mock(\"../../lib/generate.js\", () => ({\n  generate: (...args: unknown[]) => generateMock(...args),\n}));\n\ndescribe(\"general scope handling\", () => {\n  beforeEach(() => {\n    generateMock.mockReset();\n  });\n\n  it(\"lets policy stop immediately for a general ask with no repo target\", () => {\n    const memory = createAgentMemory(\"how do I use git bash to save a diff?\", \"/repo\", \"/repo\");\n    memory.task.normalizedQuery = \"how do I use git bash to save a diff\";\n    memory.task.primaryIntent = \"Learn how to save a git diff output to a file using Git Bash.\";\n    memory.task.queryScope = \"general\";\n\n    const policy = resolvePolicyState(memory, { forcedEnd: true });\n\n    expect(policy.allowedActions).toEqual([\"final-answer\"]);\n    expect(policy.allowedActions).not.toContain(\"search-db\");\n    expect(policy.decision.stop).toBe(\"final-answer\");\n    expect(policy.endDecision?.action).toBe(\"final-answer\");\n    expect(policy.reason).toContain(\"does not need grounded repo evidence\");\n  });\n\n  it(\"answers a general ask without search-db or triage-file\", async () => {\n    generateMock\n      .mockResolvedValueOnce({\n        data: JSON.stringify({\n          normalizedQuery: \"how do I use git bash to save a diff\",\n          queryScope: \"general\",\n          explicitTargets: [],\n          constraints: [],\n          primaryIntent: \"Learn how to save a git diff output to a file using Git Bash.\",\n          alternativeIntents: [],\n          searchTermGroups: [],\n          ambiguityFlags: [],\n        }),\n      })\n      .mockResolvedValueOnce({\n        data: \"Use `git diff > my_diff.patch` to save the diff to a file.\",\n      });\n\n    const memory = createAgentMemory(\"how do I use git bash to save a diff?\", \"/repo\", \"/repo\");\n    const ui = {\n      update: vi.fn(),\n      message: vi.fn(),\n      pause: vi.fn((fn: () => void) => fn()),\n      succeed: vi.fn(),\n      fail: vi.fn(),\n      stop: vi.fn(),\n    };\n\n    await runAgentLoop(memory, ui);\n\n    expect(memory.task.status).toBe(\"done\");\n    expect(memory.steps.map((step) => step.action)).toEqual([\"final-answer\"]);\n    expect(memory.steps.some((step) => step.action === \"search-db\")).toBe(false);\n    expect(memory.steps.some((step) => step.action === \"triage-file\")).toBe(false);\n    expect(memory.artifacts.finalAnswer).toContain(\"git diff > my_diff.patch\");\n    expect(memory.artifacts.latestFinalAnswerPacket).toEqual(expect.objectContaining({\n      queryScope: \"general\",\n      mustMentionFiles: [],\n      mustMentionSymbols: [],\n      mustMentionFacts: [],\n    }));\n    expect(generateMock).toHaveBeenCalledTimes(2);\n  });\n});\n"]}