savepoint 1.0.3 → 1.0.6

package/internal/board/view.go

@@ -1,317 +0,0 @@
-package board
-
-import (
-	"fmt"
-	"strings"
-
-	"github.com/charmbracelet/lipgloss"
-	xansi "github.com/charmbracelet/x/ansi"
-	"github.com/opencode/savepoint/internal/data"
-	"github.com/opencode/savepoint/internal/styles"
-)
-
-const defaultTermH = 24
-
-const defaultTermW = 80
-
-func (m Model) View() string {
-	w := m.Width
-	if w == 0 {
-		w = defaultTermW
-	}
-	m.Width = w
-	h := m.Height
-	if h == 0 {
-		h = defaultTermH
-	}
-	m.Height = h
-
-	header := m.renderHeader(w)
-	nextActivity := m.renderNextActivityLine(w)
-	extra := extraHeaderLines(nextActivity)
-	layout := CalculateLayoutWithChrome(w, h, extra)
-	topDivider := dividerLine(w)
-	board := m.renderBoard(layout)
-	boardBudget := h - 8 - extra
-	if boardBudget < 0 {
-		boardBudget = 0
-	}
-	boardLines := strings.Split(board, "\n")
-	if len(boardLines) > boardBudget {
-		board = strings.Join(boardLines[:boardBudget], "\n")
-	}
-	bottomDivider := dividerLine(w)
-	footer := m.renderFooter(w)
-	sections := []string{header}
-	if nextActivity != "" {
-		sections = append(sections, nextActivity)
-	}
-	sections = append(sections, topDivider, board, bottomDivider, footer)
-	base := lipgloss.JoinVertical(lipgloss.Left, sections...)
-
-	if m.Overlay == OverlayEpic {
-		overlay := RenderEpicDropdown(m.Epics, m.EpicCursor, min(40, w))
-		return overlayOnBase(dimLines(base), overlay, w, h)
-	}
-
-	if m.Overlay == OverlayRelease {
-		overlay := RenderReleaseDropdown(m.Releases, m.ReleaseCursor, min(40, w))
-		return overlayOnBase(dimLines(base), overlay, w, h)
-	}
-
-	if m.Overlay == OverlayHelp {
-		help := RenderHelp(overlayWidth(w))
-		return overlayOnBase(dimLines(base), help, w, h)
-	}
-
-	if m.Overlay == OverlayDetail {
-		task, ok := m.focusedTask()
-		if !ok {
-			return base
-		}
-		ow := overlayWidth(w)
-		detail := RenderDetail(task, ow, m.RouterState, detailMaxHeight(h), m.DetailOffset)
-		return overlayOnBase(dimLines(base), detail, w, h)
-	}
-
-	if m.Overlay == OverlayEpicDetail {
-		ow := overlayWidth(w)
-		epicSlug := m.epicDetailEpic()
-		var detail string
-		if m.EpicDetailTab == 1 {
-			detail = RenderEpicAuditTab(epicSlug, m.EpicAuditContent, ow, detailMaxHeight(h), m.EpicDetailOffset, m.EpicDetailTab)
-		} else {
-			detail = RenderEpicDetail(epicSlug, m.EpicDetailContent, ow, detailMaxHeight(h), m.EpicDetailOffset, m.EpicDetailTab)
-		}
-		return overlayOnBase(dimLines(base), detail, w, h)
-	}
-
-	return base
-}
-
-func (m Model) renderHeader(w int) string {
-	icon := styles.HeaderIcon.Render("▣")
-	text := styles.HeaderText.Render("S A V E P O I N T")
-	left := icon + "  " + text
-	return styles.HeaderFrame.Width(w).Render(left)
-}
-
-func extraHeaderLines(line string) int {
-	if line == "" {
-		return 0
-	}
-	return 1
-}
-
-func (m Model) renderNextActivityLine(w int) string {
-	if w <= 0 {
-		w = defaultTermW
-	}
-	return renderNextActivityLine(m.RouterState, w)
-}
-
-func renderNextActivityLine(state *data.RouterState, w int) string {
-	tag, style, ok := nextActivityPhase(state)
-	if !ok || strings.TrimSpace(state.NextAction) == "" {
-		return ""
-	}
-
-	content := style.Render(tag+":") + " " + state.NextAction
-	if lipgloss.Width(content) > w {
-		content = xansi.Truncate(content, w, "…")
-	}
-	return styles.RootLine.Width(w).Render(content)
-}
-
-func nextActivityPhase(state *data.RouterState) (string, lipgloss.Style, bool) {
-	if state == nil {
-		return "", lipgloss.Style{}, false
-	}
-	switch state.State {
-	case "task-building":
-		return "BUILD", styles.FooterPhaseBuild, true
-	case "audit-pending":
-		return "AUDIT", styles.FooterPhaseAudit, true
-	case "pre-implementation", "epic-design", "epic-task-breakdown":
-		return "PLAN", styles.FooterPhasePlan, true
-	default:
-		return "", lipgloss.Style{}, false
-	}
-}
-
-// FormatNextActivity formats a compact activity string from router state.
-// Returns empty string when state is nil. Result is capped at 20 visible chars.
-func FormatNextActivity(state *data.RouterState) string {
-	if state == nil {
-		return ""
-	}
-	var s string
-	switch state.State {
-	case "task-building":
-		s = fmt.Sprintf("Build %s %s/%s", state.Release, shortID(state.Epic), shortID(state.Task))
-	case "audit-pending":
-		s = fmt.Sprintf("Audit %s", shortID(state.Epic))
-	case "epic-design":
-		s = fmt.Sprintf("Design %s", shortID(state.Epic))
-	case "epic-task-breakdown":
-		s = fmt.Sprintf("Plan %s", shortID(state.Epic))
-	case "pre-implementation":
-		s = fmt.Sprintf("Planning %s", state.Release)
-	default:
-		s = state.State
-	}
-	return xansi.Truncate(s, 20, "…")
-}
-
-
-
-func (m Model) focusedTask() (data.Task, bool) {
-	tasks := m.Tasks[m.FocusedColumn]
-	if len(tasks) == 0 || m.FocusedTask >= len(tasks) {
-		return data.Task{}, false
-	}
-	return tasks[m.FocusedTask], true
-}
-
-func overlayWidth(termW int) int {
-	ow := termW - 4
-	if ow > 80 {
-		ow = 80
-	}
-	if ow < 20 {
-		ow = 20
-	}
-	return ow
-}
-
-// dimLines applies faint ANSI styling to each line individually.
-func dimLines(s string) string {
-	dim := lipgloss.NewStyle().Faint(true)
-	lines := strings.Split(s, "\n")
-	for i, l := range lines {
-		lines[i] = dim.Render(l)
-	}
-	return strings.Join(lines, "\n")
-}
-
-// overlayOnBase places overlay centered on base, preserving base lines outside
-// the overlay area and replacing the left portion of intersecting lines.
-func overlayOnBase(base, overlay string, termW, termH int) string {
-	baseLines := strings.Split(base, "\n")
-	overlayLines := strings.Split(overlay, "\n")
-
-	overlayH := len(overlayLines)
-	overlayW := 0
-	for _, l := range overlayLines {
-		if lw := lipgloss.Width(l); lw > overlayW {
-			overlayW = lw
-		}
-	}
-
-	startY := (termH - overlayH) / 2
-	if startY < 0 {
-		startY = 0
-	}
-	startX := (termW - overlayW) / 2
-	if startX < 0 {
-		startX = 0
-	}
-
-	for len(baseLines) < termH {
-		baseLines = append(baseLines, "")
-	}
-
-	result := make([]string, len(baseLines))
-	for i, line := range baseLines {
-		oi := i - startY
-		if oi >= 0 && oi < overlayH {
-			left := xansi.Truncate(line, startX, "")
-			leftW := lipgloss.Width(left)
-			if leftW < startX {
-				left += strings.Repeat(" ", startX-leftW)
-			}
-			result[i] = left + overlayLines[oi]
-		} else {
-			result[i] = line
-		}
-	}
-	return strings.Join(result, "\n")
-}
-
-func (m Model) renderBoard(layout Layout) string {
-	cols := m.renderColumns(layout)
-	var content string
-	if layout.EpicPanelVisible {
-		epic := m.renderEpicPanel(layout.EpicPanelWidth, layout.ContentHeight)
-		content = lipgloss.JoinHorizontal(lipgloss.Top, epic, cols)
-	} else {
-		content = cols
-	}
-	return styles.BoardFrame.Width(m.Width).Render(content)
-}
-
-func (m Model) renderColumns(layout Layout) string {
-	if layout.ColCount == 1 {
-		return m.renderColumn(m.FocusedColumn, layout.ColWidths[0], layout.ContentHeight)
-	}
-	allCols := []data.ColumnType{data.ColumnPlanned, data.ColumnInProgress, data.ColumnDone}
-	rendered := make([]string, len(allCols))
-	for i, col := range allCols {
-		rendered[i] = m.renderColumn(col, layout.ColWidths[i], layout.ContentHeight)
-	}
-	return lipgloss.JoinHorizontal(lipgloss.Top, rendered...)
-}
-
-func (m Model) renderEpicPanel(w int, maxHeight int) string {
-	return RenderEpicSidebar(m.Epics, m.SelectedEpic, w, m.EpicPanelFocus, m.EpicPanelCursor, m.EpicStatus, maxHeight)
-}
-
-func (m Model) renderColumn(col data.ColumnType, colW, maxHeight int) string {
-	focused := !m.EpicPanelFocus && m.FocusedColumn == col
-	return RenderColumn(m.Tasks[col], col, colW, maxHeight, m.ColumnOffsets[col], m.FocusedTask, focused, m.RouterState)
-}
-
-func detailMaxHeight(termH int) int {
-	if termH <= 0 {
-		termH = defaultTermH
-	}
-	h := termH * 7 / 10
-	if h < 6 {
-		h = 6
-	}
-	return h
-}
-
-func (m Model) renderFooter(termW int) string {
-	phase := footerLine(termW,
-		styles.FooterPhasePlan.Render("PLAN")+
-			styles.FooterDivider.Render(" │ ")+
-			styles.FooterPhaseBuild.Render("BUILD")+
-			styles.FooterDivider.Render(" │ ")+
-			styles.FooterPhaseAudit.Render("AUDIT"),
-	)
-	hints := footerLine(termW, styles.FooterHints.Render("←/→:nav  p: Priority  R:release  ?:help  q:quit"))
-	status := ""
-	if m.StatusMessage != "" {
-		status = styles.StatusBar.Render(m.StatusMessage)
-	}
-	statusLine := footerLine(termW, status)
-	return lipgloss.JoinVertical(lipgloss.Center, phase, statusLine, hints)
-}
-
-func dividerLine(termW int) string {
-	if termW <= 0 {
-		termW = defaultTermW
-	}
-	return styles.Divider.Render(strings.Repeat("─", termW))
-}
-
-func footerLine(termW int, content string) string {
-	if termW <= 0 {
-		termW = defaultTermW
-	}
-	if lipgloss.Width(content) > termW {
-		content = xansi.Truncate(content, termW, "")
-	}
-	return styles.RootLine.Width(termW).Align(lipgloss.Center).Render(content)
-}

package/internal/board/view_test.go

@@ -1,315 +0,0 @@
-package board
-
-import (
-	"strings"
-	"testing"
-
-	"github.com/charmbracelet/lipgloss"
-	"github.com/opencode/savepoint/internal/data"
-)
-
-func TestView_rendersWithoutPanic(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	m.Height = 40
-	got := m.View()
-	if got == "" {
-		t.Error("View() returned empty string")
-	}
-}
-
-func TestView_containsColumnTitles(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-
-	for _, title := range []string{"PLANNED", "IN PROGRESS", "DONE"} {
-		if !strings.Contains(got, title) {
-			t.Errorf("View() missing column title %q", title)
-		}
-	}
-}
-
-func TestView_containsHeader(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	if !strings.Contains(got, "S A V E P O I N T") {
-		t.Error("View() missing spaced header text")
-	}
-	if !strings.Contains(got, "▣") {
-		t.Error("View() missing header icon")
-	}
-}
-
-func TestView_containsDivider(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	if !strings.Contains(got, strings.Repeat("─", 120)) {
-		t.Error("View() missing full-width horizontal divider")
-	}
-}
-
-func TestView_containsFooterPhases(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	for _, phase := range []string{"PLAN", "BUILD", "AUDIT"} {
-		if !strings.Contains(got, phase) {
-			t.Errorf("View() missing footer phase %q", phase)
-		}
-	}
-}
-
-func TestView_containsFooterHints(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	footer := m.renderFooter(80)
-
-	if !strings.Contains(footer, "←/→:nav  p: Priority  R:release  ?:help  q:quit") {
-		t.Fatal("renderFooter() missing navigation hints")
-	}
-
-	lines := strings.Split(footer, "\n")
-	if len(lines) != 3 {
-		t.Fatalf("renderFooter() returned %d lines, want 3", len(lines))
-	}
-	if strings.TrimSpace(plainTerminal(lines[1])) != "" {
-		t.Fatalf("renderFooter() status line = %q, want blank", lines[1])
-	}
-	for i, line := range lines {
-		if got := lipgloss.Width(line); got > 80 {
-			t.Fatalf("renderFooter() line %d width = %d, want <= 80", i, got)
-		}
-	}
-}
-
-func TestView_footerRendersStatusMessage(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.StatusMessage = "Router set to v1.1 E05-tasking-permissions/T004"
-	footer := plainTerminal(m.renderFooter(80))
-
-	if !strings.Contains(footer, "Router set to v1.1 E05-tasking-permissions/T004") {
-		t.Fatal("renderFooter() missing status message")
-	}
-}
-
-func TestView_containsBottomDivider(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	// There should be at least two divider lines (top and bottom)
-	count := strings.Count(got, "─")
-	if count < 2 {
-		t.Errorf("View() expected at least 2 divider chars, got %d", count)
-	}
-}
-
-func TestView_defaultWidthWhenZero(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	// Width=0: should use default and not panic
-	got := m.View()
-	if got == "" {
-		t.Error("View() with zero Width returned empty string")
-	}
-}
-
-func TestView_taskLabelFallback(t *testing.T) {
-	tasks := []data.Task{{ID: "T1", Title: "", Column: data.ColumnPlanned}}
-	m := NewModel(tasks, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	if !strings.Contains(got, "T1") {
-		t.Error("View() missing task ID when title is empty")
-	}
-}
-
-func TestView_taskLabelWithTitle(t *testing.T) {
-	tasks := []data.Task{{ID: "T2", Title: "My Task", Column: data.ColumnPlanned}}
-	m := NewModel(tasks, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	if !strings.Contains(got, "My Task") {
-		t.Error("View() missing task title")
-	}
-}
-
-func TestView_wideShowsEpicPanel(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	got := m.View()
-	if !strings.Contains(got, "E03") {
-		t.Error("View() at width>=120 missing epic panel content")
-	}
-}
-
-func TestFormatNextActivity_nil(t *testing.T) {
-	if got := FormatNextActivity(nil); got != "" {
-		t.Errorf("FormatNextActivity(nil) = %q, want empty", got)
-	}
-}
-
-func TestFormatNextActivity_states(t *testing.T) {
-	cases := []struct {
-		state *data.RouterState
-		want  string
-	}{
-		{&data.RouterState{State: "task-building", Task: "T010", Epic: "E06", Release: "v1"}, "Build v1 E06/T010"},
-		{&data.RouterState{State: "audit-pending", Epic: "E06"}, "Audit E06"},
-		{&data.RouterState{State: "epic-design", Epic: "E06"}, "Design E06"},
-		{&data.RouterState{State: "epic-task-breakdown", Epic: "E06"}, "Plan E06"},
-		{&data.RouterState{State: "pre-implementation", Release: "v1"}, "Planning v1"},
-	}
-	for _, c := range cases {
-		got := FormatNextActivity(c.state)
-		if got != c.want {
-			t.Errorf("FormatNextActivity(%q) = %q, want %q", c.state.State, got, c.want)
-		}
-	}
-}
-
-func TestFormatNextActivity_truncation(t *testing.T) {
-	state := &data.RouterState{State: "task-building", Task: "T001", Epic: "E01-very-long-epic-name", Release: "v1.1"}
-	got := FormatNextActivity(state)
-	if lipgloss.Width(got) > 20 {
-		t.Errorf("FormatNextActivity truncation: width %d > 20, got %q", lipgloss.Width(got), got)
-	}
-}
-
-func TestFormatNextActivity_taskBuildingKeepsMinorReleaseVisible(t *testing.T) {
-	state := &data.RouterState{State: "task-building", Task: "T001", Epic: "E03", Release: "v1.1"}
-	got := FormatNextActivity(state)
-	if got != "Build v1.1 E03/T001" {
-		t.Errorf("FormatNextActivity() = %q, want Build v1.1 E03/T001", got)
-	}
-}
-
-func TestView_headerShowsNextActivity(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	m.RouterState = &data.RouterState{State: "audit-pending", NextAction: "Audit E06"}
-	got := m.View()
-	if !strings.Contains(got, "AUDIT:") {
-		t.Error("View() missing Next Activity phase tag")
-	}
-	if !strings.Contains(got, "Audit E06") {
-		t.Error("View() missing activity text below header")
-	}
-	if strings.Contains(got, "Next Activity:") {
-		t.Error("View() should not render Next Activity inside the header")
-	}
-}
-
-func TestView_nextActivityLineImmediatelyBelowHeader(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	m.RouterState = &data.RouterState{State: "task-building", NextAction: "Build T010 (E06) v1"}
-	got := m.View()
-
-	lines := strings.Split(got, "\n")
-	headerIndex := -1
-	activityIndex := -1
-	dividerIndex := -1
-	for i, line := range lines {
-		if strings.Contains(line, "S A V E P O I N T") {
-			headerIndex = i
-		}
-		if strings.Contains(line, "BUILD:") && strings.Contains(line, "Build T010 (E06) v1") {
-			activityIndex = i
-		}
-		if dividerIndex == -1 && strings.Contains(line, strings.Repeat("─", 120)) {
-			dividerIndex = i
-		}
-	}
-	if headerIndex == -1 || activityIndex == -1 || dividerIndex == -1 {
-		t.Fatalf("View() missing expected header/activity/divider lines: header=%d activity=%d divider=%d", headerIndex, activityIndex, dividerIndex)
-	}
-	if !(headerIndex < activityIndex && activityIndex < dividerIndex) {
-		t.Fatalf("Next Activity line order invalid: header=%d activity=%d divider=%d", headerIndex, activityIndex, dividerIndex)
-	}
-}
-
-func TestView_headerNoActivityWhenNilState(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 120
-	m.RouterState = nil
-	got := m.View()
-	if strings.Contains(got, "Next Activity:") || strings.Contains(got, "BUILD:") || strings.Contains(got, "PLAN:") || strings.Contains(got, "AUDIT:") {
-		t.Error("View() should not show Next Activity line when RouterState is nil")
-	}
-}
-
-func TestView_headerNarrowWidth(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 40
-	m.RouterState = &data.RouterState{State: "audit-pending", NextAction: "Audit E06"}
-	got := m.View()
-	// Should not panic and header text should still be present
-	if !strings.Contains(got, "S A V E P O I N T") {
-		t.Error("View() at narrow width missing header text")
-	}
-}
-
-func TestRenderNextActivityLine_phaseMapping(t *testing.T) {
-	cases := []struct {
-		name  string
-		state *data.RouterState
-		tag   string
-	}{
-		{"build", &data.RouterState{State: "task-building", NextAction: "Build T010 (E06) v1"}, "BUILD:"},
-		{"audit", &data.RouterState{State: "audit-pending", NextAction: "Audit E03"}, "AUDIT:"},
-		{"pre implementation", &data.RouterState{State: "pre-implementation", NextAction: "Plan v1.1"}, "PLAN:"},
-		{"epic design", &data.RouterState{State: "epic-design", NextAction: "Design E03"}, "PLAN:"},
-		{"task breakdown", &data.RouterState{State: "epic-task-breakdown", NextAction: "Break down E03"}, "PLAN:"},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			got := renderNextActivityLine(tc.state, 80)
-			if !strings.Contains(got, tc.tag) {
-				t.Fatalf("renderNextActivityLine() missing phase tag %q in %q", tc.tag, got)
-			}
-			if !strings.Contains(got, tc.state.NextAction) {
-				t.Fatalf("renderNextActivityLine() missing next_action %q in %q", tc.state.NextAction, got)
-			}
-		})
-	}
-}
-
-func TestRenderNextActivityLine_hiddenStates(t *testing.T) {
-	cases := []*data.RouterState{
-		nil,
-		{State: "idle", NextAction: "Wait"},
-		{State: "task-building", NextAction: ""},
-	}
-	for _, state := range cases {
-		if got := renderNextActivityLine(state, 80); got != "" {
-			t.Fatalf("renderNextActivityLine(%v) = %q, want empty", state, got)
-		}
-	}
-}
-
-func TestRenderNextActivityLine_truncatesAtNarrowWidth(t *testing.T) {
-	got := renderNextActivityLine(&data.RouterState{
-		State:      "pre-implementation",
-		NextAction: "Build T010 (E06) v1 with a very long follow-up activity",
-	}, 18)
-	if lipgloss.Width(got) > 18 {
-		t.Fatalf("renderNextActivityLine() width = %d, want <= 18; got %q", lipgloss.Width(got), got)
-	}
-	if !strings.Contains(got, "PLAN:") || !strings.Contains(got, "…") {
-		t.Fatalf("renderNextActivityLine() = %q, want PLAN tag and ellipsis", got)
-	}
-}
-
-func TestView_narrowShowsSingleColumn(t *testing.T) {
-	m := NewModel(nil, "v1", "E03")
-	m.Width = 60
-	m.FocusedColumn = data.ColumnInProgress
-	got := m.View()
-	if !strings.Contains(got, "IN PROGRESS") {
-		t.Error("View() at width<80 missing focused column title")
-	}
-	if strings.Contains(got, "PLANNED") {
-		t.Error("View() at width<80 should not show non-focused columns")
-	}
-}