savepoint 1.0.3 → 1.0.6

package/internal/board/detail_test.go

@@ -1,340 +0,0 @@
-package board
-
-import (
-	"regexp"
-	"strings"
-	"testing"
-
-	tea "github.com/charmbracelet/bubbletea"
-	"github.com/opencode/savepoint/internal/data"
-)
-
-var ansiPattern = regexp.MustCompile(`\x1b\[[0-9;?]*[ -/]*[@-~]`)
-
-func plainTerminal(s string) string {
-	return ansiPattern.ReplaceAllString(s, "")
-}
-
-func sampleTask() data.Task {
-	return data.Task{
-		ID:      "E04/T001",
-		Title:   "My Task",
-		Epic:    "E04-board-components",
-		Release: "v1",
-		Column:  data.ColumnInProgress,
-		Stage:   data.StageBuild,
-	}
-}
-
-func TestRenderDetail_containsID(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "E04/T001") {
-		t.Error("RenderDetail missing task ID")
-	}
-}
-
-func TestRenderDetail_containsTitle(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "My Task") {
-		t.Error("RenderDetail missing task title")
-	}
-}
-
-func TestRenderDetail_containsEpic(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "E04-board-components") {
-		t.Error("RenderDetail missing epic")
-	}
-}
-
-func TestRenderDetail_containsRelease(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "v1") {
-		t.Error("RenderDetail missing release")
-	}
-}
-
-func TestRenderDetail_containsStatus(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "in_progress") {
-		t.Error("RenderDetail missing status")
-	}
-}
-
-func TestRenderDetail_containsPhase(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "build") {
-		t.Error("RenderDetail missing phase")
-	}
-}
-
-func TestRenderDetail_containsEscHint(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if !strings.Contains(got, "esc") {
-		t.Error("RenderDetail missing esc:close hint")
-	}
-}
-
-func TestRenderDetail_containsDescription(t *testing.T) {
-	tk := sampleTask()
-	tk.Description = "some description text"
-	got := RenderDetail(tk, 60, nil, 0, 0)
-	if !strings.Contains(got, "some description text") {
-		t.Error("RenderDetail missing description text")
-	}
-}
-
-func TestRenderDetail_noDescriptionSectionWhenEmpty(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if strings.Contains(got, "Description:") {
-		t.Error("RenderDetail should not show Description section when empty")
-	}
-}
-
-func TestRenderDetail_containsChecklist(t *testing.T) {
-	tk := sampleTask()
-	tk.Checklist = []data.CheckItem{{Text: "first implementation item"}, {Text: "second implementation item", Done: true}}
-	got := RenderDetail(tk, 60, nil, 0, 0)
-	if !strings.Contains(got, "Implementation Plan:") {
-		t.Error("RenderDetail missing implementation plan heading")
-	}
-	if !strings.Contains(got, "first implementation item") {
-		t.Error("RenderDetail missing first checklist item")
-	}
-	if !strings.Contains(got, "second implementation item") {
-		t.Error("RenderDetail missing second checklist item")
-	}
-}
-
-func TestRenderDetail_checklistSingleSentenceGetsOneCheckbox(t *testing.T) {
-	tk := sampleTask()
-	tk.Checklist = []data.CheckItem{{Text: "single sentence task"}}
-
-	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
-
-	if count := strings.Count(got, "[ ]"); count != 1 {
-		t.Fatalf("RenderDetail checkbox count = %d, want 1\n%s", count, got)
-	}
-	if strings.Contains(got, "[x]") {
-		t.Fatal("RenderDetail should not render checked marker for unchecked item")
-	}
-}
-
-func TestRenderDetail_checklistMultiSentenceGetsOneCheckboxPerSentence(t *testing.T) {
-	tk := sampleTask()
-	tk.Checklist = []data.CheckItem{{Text: "First sentence. Second sentence! Third sentence?"}}
-
-	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
-
-	if count := strings.Count(got, "[ ]"); count != 3 {
-		t.Fatalf("RenderDetail checkbox count = %d, want 3\n%s", count, got)
-	}
-	for _, want := range []string{"[ ] First sentence.", "[ ] Second sentence!", "[ ] Third sentence?"} {
-		if !strings.Contains(got, want) {
-			t.Fatalf("RenderDetail missing sentence checkbox line %q\n%s", want, got)
-		}
-	}
-}
-
-func TestRenderDetail_checklistHardWrappedSentenceDoesNotDuplicateCheckbox(t *testing.T) {
-	tk := sampleTask()
-	tk.Checklist = []data.CheckItem{{
-		Text: "This sentence is intentionally long enough to wrap inside a narrow detail overlay while remaining one semantic sentence.",
-	}}
-
-	got := plainTerminal(RenderDetail(tk, 34, nil, 0, 0))
-
-	if count := strings.Count(got, "[ ]"); count != 1 {
-		t.Fatalf("RenderDetail checkbox count = %d, want 1\n%s", count, got)
-	}
-	if !strings.Contains(got, "    intentionally long enough") {
-		t.Fatalf("RenderDetail continuation line should align under checkbox text\n%s", got)
-	}
-}
-
-func TestRenderDetail_checklistCheckedSentenceUsesCheckedMarker(t *testing.T) {
-	tk := sampleTask()
-	tk.Checklist = []data.CheckItem{{Text: "already done. still done.", Done: true}}
-
-	got := plainTerminal(RenderDetail(tk, 60, nil, 0, 0))
-
-	if count := strings.Count(got, "[x]"); count != 2 {
-		t.Fatalf("RenderDetail checked checkbox count = %d, want 2\n%s", count, got)
-	}
-	if strings.Contains(got, "[ ]") {
-		t.Fatal("RenderDetail should not render unchecked marker for checked item")
-	}
-}
-
-func TestRenderDetail_wrapsLongDescription(t *testing.T) {
-	tk := sampleTask()
-	tk.Description = "alpha beta gamma delta epsilon zeta eta theta iota kappa lambda"
-	got := RenderDetail(tk, 30, nil, 0, 0)
-	if strings.Contains(got, tk.Description) {
-		t.Error("RenderDetail should wrap long description text")
-	}
-	if !strings.Contains(got, "alpha beta") || !strings.Contains(got, "lambda") {
-		t.Error("RenderDetail should preserve wrapped description words")
-	}
-}
-
-func TestRenderDetail_noAcceptanceSectionWhenEmpty(t *testing.T) {
-	got := RenderDetail(sampleTask(), 60, nil, 0, 0)
-	if strings.Contains(got, "Acceptance Criteria:") {
-		t.Error("RenderDetail should not show Acceptance section when empty")
-	}
-}
-
-func TestPhaseLabel_build(t *testing.T) {
-	if got := phaseLabel(data.StageBuild); got != "build" {
-		t.Errorf("phaseLabel(StageBuild) = %q, want %q", got, "build")
-	}
-}
-
-func TestPhaseLabel_test(t *testing.T) {
-	if got := phaseLabel(data.StageTest); got != "test" {
-		t.Errorf("phaseLabel(StageTest) = %q, want %q", got, "test")
-	}
-}
-
-func TestPhaseLabel_audit(t *testing.T) {
-	if got := phaseLabel(data.StageAudit); got != "audit" {
-		t.Errorf("phaseLabel(StageAudit) = %q, want %q", got, "audit")
-	}
-}
-
-func TestPhaseLabel_default(t *testing.T) {
-	if got := phaseLabel(""); got != "build" {
-		t.Errorf("phaseLabel(%q) = %q, want %q", "", got, "build")
-	}
-}
-
-func TestUpdate_enterOpensDetailOverlay(t *testing.T) {
-	tasks := []data.Task{sampleTask()}
-	m := NewModel(tasks, "v1", "E04-board-components")
-	m.FocusedColumn = data.ColumnInProgress
-	m.FocusedTask = 0
-	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyEnter})
-	updated := requireModel(t, got)
-	if updated.Overlay != OverlayDetail {
-		t.Errorf("Overlay = %q, want %q", updated.Overlay, OverlayDetail)
-	}
-}
-
-func TestUpdate_enterNoOpWhenNoTasks(t *testing.T) {
-	m := NewModel(nil, "v1", "E04-board-components")
-	m.FocusedColumn = data.ColumnPlanned
-	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyEnter})
-	updated := requireModel(t, got)
-	if updated.Overlay != OverlayNone {
-		t.Errorf("Overlay = %q, want none when column has no tasks", updated.Overlay)
-	}
-}
-
-func TestUpdate_detailOverlayEscCloses(t *testing.T) {
-	m := NewModel(nil, "v1", "E04-board-components")
-	m.Overlay = OverlayDetail
-	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyEsc})
-	updated := requireModel(t, got)
-	if updated.Overlay != OverlayNone {
-		t.Errorf("Overlay = %q after esc, want none", updated.Overlay)
-	}
-}
-
-func TestUpdate_detailOverlayBlocksColumnNav(t *testing.T) {
-	m := NewModel(nil, "v1", "E04-board-components")
-	m.Overlay = OverlayDetail
-	m.FocusedColumn = data.ColumnPlanned
-	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("l")})
-	updated := requireModel(t, got)
-	if updated.FocusedColumn != data.ColumnPlanned {
-		t.Error("column nav should be blocked when detail overlay is open")
-	}
-}
-
-func TestView_detailOverlayRendered(t *testing.T) {
-	tasks := []data.Task{sampleTask()}
-	m := NewModel(tasks, "v1", "E04-board-components")
-	m.Width = 100
-	m.Height = 30
-	m.FocusedColumn = data.ColumnInProgress
-	m.FocusedTask = 0
-	m.Overlay = OverlayDetail
-	got := m.View()
-	if !strings.Contains(got, "TASK DETAIL") {
-		t.Error("View() with OverlayDetail missing TASK DETAIL header")
-	}
-	if !strings.Contains(got, "E04/T001") {
-		t.Error("View() with OverlayDetail missing task ID")
-	}
-}
-
-func TestRenderDetail_routerPriorityLabel(t *testing.T) {
-	task := sampleTask()
-	router := &data.RouterState{Release: task.Release, Epic: task.Epic, Task: task.ID}
-	got := RenderDetail(task, 60, router, 0, 0)
-	if !strings.Contains(got, "(router priority)") {
-		t.Error("RenderDetail missing router priority label for matching task")
-	}
-}
-
-func TestRenderDetail_noRouterPriorityLabelWhenNoMatch(t *testing.T) {
-	task := sampleTask()
-	router := &data.RouterState{Release: task.Release, Epic: task.Epic, Task: "other-id"}
-	got := RenderDetail(task, 60, router, 0, 0)
-	if strings.Contains(got, "(router priority)") {
-		t.Error("RenderDetail should not show router priority label for non-matching task")
-	}
-}
-
-func TestRenderDetail_viewportShowsScrollIndicators(t *testing.T) {
-	task := sampleTask()
-	task.Description = "alpha beta gamma delta epsilon zeta eta theta iota kappa lambda mu nu xi omicron"
-
-	got := RenderDetail(task, 32, nil, 8, 2)
-
-	if !strings.Contains(got, "↑ 2 above") {
-		t.Error("RenderDetail missing above indicator")
-	}
-	if !strings.Contains(got, "↓") || !strings.Contains(got, "more") {
-		t.Error("RenderDetail missing more indicator")
-	}
-	if strings.Contains(got, "ID:") {
-		t.Error("RenderDetail should not render body lines above viewport")
-	}
-}
-
-func TestUpdate_detailOverlayScrollsWithJK(t *testing.T) {
-	m := NewModel([]data.Task{sampleTask()}, "v1", "E04-board-components")
-	m.Overlay = OverlayDetail
-
-	got, _ := m.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("j")})
-	updated := requireModel(t, got)
-	if updated.DetailOffset != 1 {
-		t.Errorf("DetailOffset after j = %d, want 1", updated.DetailOffset)
-	}
-
-	got, _ = updated.Update(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("k")})
-	updated = requireModel(t, got)
-	if updated.DetailOffset != 0 {
-		t.Errorf("DetailOffset after k = %d, want 0", updated.DetailOffset)
-	}
-}
-
-func TestOverlayWidth_clampMax(t *testing.T) {
-	if got := overlayWidth(120); got != 80 {
-		t.Errorf("overlayWidth(120) = %d, want 80", got)
-	}
-}
-
-func TestOverlayWidth_termMinus4(t *testing.T) {
-	if got := overlayWidth(60); got != 56 {
-		t.Errorf("overlayWidth(60) = %d, want 56", got)
-	}
-}
-
-func TestOverlayWidth_clampMin(t *testing.T) {
-	if got := overlayWidth(10); got != 20 {
-		t.Errorf("overlayWidth(10) = %d, want 20", got)
-	}
-}

package/internal/board/epic_panel.go

@@ -1,262 +0,0 @@
-package board
-
-import (
-	"strings"
-
-	"github.com/charmbracelet/lipgloss"
-	"github.com/opencode/savepoint/internal/styles"
-)
-
-// RenderEpicDetail renders an overlay showing the content of an E##-Detail.md file.
-func RenderEpicDetail(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
-	inner := overlayW - detailBorderPad
-	if inner < 4 {
-		inner = 4
-	}
-
-	tabIndicator := renderTabIndicator(tab, inner)
-	lines := []string{
-		styles.EpicTitleFocused.Render("EPIC DETAIL"),
-		tabIndicator,
-	}
-
-	body := epicDetailBody(content, inner)
-	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
-	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
-
-	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
-}
-
-func renderTabIndicator(tab int, width int) string {
-	var detail, audit string
-	if tab == 0 {
-		detail = styles.EpicItemFocused.Render("DETAIL [1]")
-		audit = styles.CardMeta.Render("AUDIT [2]")
-	} else {
-		detail = styles.CardMeta.Render("DETAIL [1]")
-		audit = styles.EpicItemFocused.Render("AUDIT [2]")
-	}
-	return detail + styles.CardMeta.Render(" │ ") + audit
-}
-
-// stripFrontmatter removes YAML frontmatter (between leading --- markers) from content.
-func stripFrontmatter(content string) []string {
-	lines := strings.Split(content, "\n")
-	start := 0
-	if len(lines) > 0 && strings.TrimSpace(lines[0]) == "---" {
-		for i := 1; i < len(lines); i++ {
-			if strings.TrimSpace(lines[i]) == "---" {
-				start = i + 1
-				break
-			}
-		}
-	}
-	return lines[start:]
-}
-
-// epicDetailBody parses markdown content into display lines, stripping frontmatter.
-func epicDetailBody(content string, width int) []string {
-	if strings.TrimSpace(content) == "" || content == "(no detail available)" {
-		return []string{styles.CardMeta.Render("(no detail available)")}
-	}
-
-	lines := stripFrontmatter(content)
-
-	var body []string
-	skip := false
-	for _, line := range lines {
-		trimmed := strings.TrimRight(line, " \t")
-		if strings.HasPrefix(trimmed, "## ") {
-			heading := strings.ToLower(strings.TrimPrefix(trimmed, "## "))
-			skip = strings.Contains(heading, "component") || strings.Contains(heading, "files")
-		}
-		if skip {
-			continue
-		}
-		switch {
-		case strings.HasPrefix(trimmed, "# "):
-			body = append(body, styles.EpicTitleFocused.Render(strings.TrimPrefix(trimmed, "# ")))
-		case strings.HasPrefix(trimmed, "## "):
-			body = append(body, "", styles.EpicItemFocused.Render(strings.TrimPrefix(trimmed, "## ")))
-		case strings.HasPrefix(trimmed, "### "):
-			body = append(body, styles.EpicItemFocused.Render(strings.TrimPrefix(trimmed, "### ")))
-		case strings.HasPrefix(trimmed, "|"):
-			body = append(body, styles.CardMeta.Render(trimmed))
-		case trimmed == "":
-			body = append(body, "")
-		default:
-			for _, wrapped := range WrapText(trimmed, width) {
-				body = append(body, styles.CardMeta.Render(wrapped))
-			}
-		}
-	}
-	return body
-}
-
-// RenderEpicAuditTab renders an overlay showing audit findings from an E##-Audit.md file.
-func RenderEpicAuditTab(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
-	inner := overlayW - detailBorderPad
-	if inner < 4 {
-		inner = 4
-	}
-
-	tabIndicator := renderTabIndicator(tab, inner)
-	lines := []string{
-		styles.GlyphAudit.Render("EPIC AUDIT"),
-		tabIndicator,
-	}
-
-	body := epicAuditBody(content, inner)
-	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
-	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
-
-	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
-}
-
-var epicAuditHiddenSectionHeadings = map[string]struct{}{
-	"12. Distribution & build": {},
-	"Acceptance Criteria":      {},
-	"Architectural notes":      {},
-	"Boundaries":               {},
-	"Context Files":            {},
-	"Implemented As":           {},
-	"Implemented as":           {},
-	"Implementation Plan":      {},
-	"Manual audit override":    {},
-	"Proposed Changes":         {},
-	"Quality Review":           {},
-	"With":                     {},
-}
-
-func epicAuditBody(content string, width int) []string {
-	if strings.TrimSpace(content) == "" || content == "(no audit available)" {
-		return []string{styles.CardMeta.Render("(no audit available)")}
-	}
-
-	lines := stripFrontmatter(content)
-
-	var body []string
-	inHiddenSection := false
-
-	for _, line := range lines {
-		trimmed := strings.TrimRight(line, " \t\r")
-		switch {
-		case strings.HasPrefix(trimmed, "## "):
-			sectionName := strings.TrimPrefix(trimmed, "## ")
-			_, inHiddenSection = epicAuditHiddenSectionHeadings[sectionName]
-			if !inHiddenSection {
-				body = append(body, "", styles.EpicItemFocused.Render(sectionName))
-			}
-		case inHiddenSection:
-		case strings.HasPrefix(trimmed, "### "):
-			body = append(body, styles.EpicItemFocused.Render(strings.TrimPrefix(trimmed, "### ")))
-		case strings.HasPrefix(trimmed, "- [x] ") || strings.HasPrefix(trimmed, "- [X] "):
-			text := strings.TrimPrefix(strings.TrimPrefix(trimmed, "- [x] "), "- [X] ")
-			body = append(body, renderChecklistSentences(text, "[x] ", width, styles.TagDone)...)
-		case strings.HasPrefix(trimmed, "- [ ] "):
-			text := strings.TrimPrefix(trimmed, "- [ ] ")
-			body = append(body, renderChecklistSentences(text, "[ ] ", width, styles.CardMeta)...)
-		case strings.HasPrefix(trimmed, "- "):
-			body = append(body, styles.CardMeta.Render("• "+strings.TrimPrefix(trimmed, "- ")))
-		case trimmed == "":
-			body = append(body, "")
-		default:
-			for _, wrapped := range WrapText(trimmed, width) {
-				body = append(body, styles.CardMeta.Render(wrapped))
-			}
-		}
-	}
-	return body
-}
-
-const epicActiveMarker = "►"
-
-// RenderEpicSidebar renders the fixed left sidebar listing epics with active indicator.
-// If epics is empty and selected is non-empty, selected is shown as the sole entry.
-func RenderEpicSidebar(epics []string, selected string, width int, focus bool, cursor int, status map[string]string, maxHeight int) string {
-	inner := width - epicPanelOverhead
-	if inner < 2 {
-		inner = 2
-	}
-	list := epics
-	if len(list) == 0 && selected != "" {
-		list = []string{selected}
-	}
-
-	title := styles.ColumnTitle.Render("EPICS")
-	if focus {
-		title = styles.EpicTitleFocused.Render("EPICS")
-	}
-	lines := []string{title, strings.Repeat("─", inner)}
-	for i, e := range list {
-		g := epicSidebarGlyph(status, e)
-		gw := lipgloss.Width(g)
-		if gw < 1 {
-			gw = 1
-		}
-		label := truncate(e, inner-2-gw)
-		if focus && len(epics) > 0 && i == cursor {
-			lines = append(lines, styles.EpicItemFocused.Render(epicActiveMarker+" "+g+" "+label))
-		} else if !focus && e == selected {
-			lines = append(lines, styles.EpicItemFocused.Render(epicActiveMarker+" "+g+" "+label))
-		} else {
-			lines = append(lines, styles.TaskItem.Render("  "+g+" "+label))
-		}
-	}
-	if len(list) == 0 {
-		lines = append(lines, styles.TaskItem.Render("(none)"))
-	}
-	if maxHeight > 0 && len(lines) > maxHeight {
-		items := lines[2:]
-		available := maxHeight - 3
-		if available < 1 {
-			available = 1
-		}
-		clipped := make([]string, 0, maxHeight)
-		clipped = append(clipped, lines[0], lines[1])
-		clipped = append(clipped, items[:min(available, len(items))]...)
-		if len(items) > available {
-			clipped = append(clipped, renderScrollIndicator("↓", len(items)-available, "more"))
-		}
-		lines = clipped
-	}
-	style := styles.EpicPanel.Width(width)
-	if focus && len(epics) > 0 {
-		style = styles.EpicPanelFocused.Width(width)
-	}
-	return style.Render(strings.Join(lines, "\n"))
-}
-
-func epicSidebarGlyph(status map[string]string, epicID string) string {
-	if status == nil {
-		return statusGlyphDefault
-	}
-	s, ok := status[epicID]
-	if !ok {
-		return statusGlyphDefault
-	}
-	return statusGlyph(s)
-}
-
-// RenderEpicDropdown renders the epic selection dropdown overlay.
-func RenderEpicDropdown(epics []string, cursor int, width int) string {
-	inner := width - epicPanelOverhead
-	if inner < 2 {
-		inner = 2
-	}
-
-	lines := []string{styles.ColumnTitleFocused.Render("SELECT EPIC"), strings.Repeat("─", inner)}
-	for i, e := range epics {
-		label := truncate(e, inner-2)
-		if i == cursor {
-			lines = append(lines, styles.TaskItemFocused.Render(epicActiveMarker+" "+label))
-		} else {
-			lines = append(lines, styles.TaskItem.Render("  "+label))
-		}
-	}
-	if len(epics) == 0 {
-		lines = append(lines, styles.TaskItem.Render("(none)"))
-	}
-	lines = append(lines, "", styles.CardMeta.Render("↑↓:nav  enter:select  esc:cancel"))
-	return styles.EpicPanel.Width(width).Render(strings.Join(lines, "\n"))
-}