savepoint 1.0.2 → 1.0.3

package/internal/board/plain_test.go

@@ -0,0 +1,117 @@
+package board
+
+import (
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+
+	"github.com/opencode/savepoint/internal/data"
+)
+
+func TestRenderPlainTable_warningBanner(t *testing.T) {
+	m := NewModel(nil, "", "")
+	got := RenderPlainTable(m)
+	if !strings.Contains(got, plainNonTTYWarning) {
+		t.Errorf("RenderPlainTable missing warning banner, got:\n%s", got)
+	}
+}
+
+func TestRenderPlainTable_columnHeaders(t *testing.T) {
+	m := NewModel(nil, "", "")
+	got := RenderPlainTable(m)
+	for _, header := range []string{"PLANNED", "IN PROGRESS", "DONE"} {
+		if !strings.Contains(got, header) {
+			t.Errorf("RenderPlainTable missing column header %q", header)
+		}
+	}
+}
+
+func TestRenderPlainTable_taskIDsAndTitles(t *testing.T) {
+	tasks := []data.Task{
+		{ID: "E08/T001", Title: "CLI entrypoint", Column: data.ColumnDone},
+		{ID: "E08/T002", Title: "Non-TTY fallback", Column: data.ColumnInProgress},
+		{ID: "E08/T003", Title: "TUI app shell", Column: data.ColumnPlanned},
+	}
+	m := NewModel(tasks, "", "")
+	got := RenderPlainTable(m)
+
+	for _, want := range []string{"E08/T001", "CLI entrypoint", "E08/T002", "Non-TTY fallback", "E08/T003", "TUI app shell"} {
+		if !strings.Contains(got, want) {
+			t.Errorf("RenderPlainTable missing %q", want)
+		}
+	}
+}
+
+func TestRenderPlainTable_noneWhenColumnEmpty(t *testing.T) {
+	m := NewModel(nil, "", "")
+	got := RenderPlainTable(m)
+	if !strings.Contains(got, "(none)") {
+		t.Errorf("RenderPlainTable should show (none) for empty columns")
+	}
+}
+
+func TestRenderPlainTable_auditSignalWhenProposalsExist(t *testing.T) {
+	root := t.TempDir()
+	epicDir := filepath.Join(root, "releases", "v1", "epics", "E01-test")
+	if err := os.MkdirAll(epicDir, 0755); err != nil {
+		t.Fatal(err)
+	}
+	auditContent := "---\ntype: audit\n---\n## Main Findings\nOK\n\n## Proposed Changes\n\n### Target File\nfoo.go\n"
+	if err := os.WriteFile(filepath.Join(epicDir, "E01-Audit.md"), []byte(auditContent), 0644); err != nil {
+		t.Fatal(err)
+	}
+
+	m := NewModel(nil, "", "")
+	m.Root = root
+	got := RenderPlainTable(m)
+	if !strings.Contains(got, plainAuditSignal) {
+		t.Errorf("RenderPlainTable missing audit signal when proposals exist, got:\n%s", got)
+	}
+}
+
+func TestRenderPlainTable_noAuditSignalWhenNone(t *testing.T) {
+	root := t.TempDir()
+	m := NewModel(nil, "", "")
+	m.Root = root
+	got := RenderPlainTable(m)
+	if strings.Contains(got, plainAuditSignal) {
+		t.Errorf("RenderPlainTable should not show audit signal when no proposals exist")
+	}
+}
+
+func TestHasAuditProposals_detectsSection(t *testing.T) {
+	root := t.TempDir()
+	epicDir := filepath.Join(root, "releases", "v1", "epics", "E02-slug")
+	if err := os.MkdirAll(epicDir, 0755); err != nil {
+		t.Fatal(err)
+	}
+	content := "## Main Findings\nAll good.\n\n## Proposed Changes\n\n### Target File\nbar.go\n"
+	if err := os.WriteFile(filepath.Join(epicDir, "E02-Audit.md"), []byte(content), 0644); err != nil {
+		t.Fatal(err)
+	}
+	if !hasAuditProposals(root) {
+		t.Error("hasAuditProposals should return true when Proposed Changes section exists")
+	}
+}
+
+func TestHasAuditProposals_noProposals(t *testing.T) {
+	root := t.TempDir()
+	epicDir := filepath.Join(root, "releases", "v1", "epics", "E03-slug")
+	if err := os.MkdirAll(epicDir, 0755); err != nil {
+		t.Fatal(err)
+	}
+	content := "## Main Findings\nAll good.\n"
+	if err := os.WriteFile(filepath.Join(epicDir, "E03-Audit.md"), []byte(content), 0644); err != nil {
+		t.Fatal(err)
+	}
+	if hasAuditProposals(root) {
+		t.Error("hasAuditProposals should return false when no Proposed Changes section")
+	}
+}
+
+func TestHasAuditProposals_missingRoot(t *testing.T) {
+	if hasAuditProposals("/nonexistent/path/xyz") {
+		t.Error("hasAuditProposals should return false for missing root")
+	}
+}

package/internal/board/release.go

@@ -31,12 +31,4 @@ func RenderReleaseDropdown(releases []string, cursor int, width int) string {
 	return styles.EpicPanel.Width(width).Render(strings.Join(lines, "\n"))
 }
 
-// releaseIndex returns the index of selected in releases, or 0 if not found.
-func releaseIndex(releases []string, selected string) int {
-	for i, r := range releases {
-		if r == selected {
-			return i
-		}
-	}
-	return 0
-}
+

package/internal/board/release_test.go

@@ -40,17 +40,17 @@ func TestRenderReleaseDropdown_hintsPresent(t *testing.T) {
 	}
 }
 
-func TestReleaseIndex_found(t *testing.T) {
+func TestSliceIndexRelease_found(t *testing.T) {
 	releases := []string{"v1", "v2", "v3"}
-	if got := releaseIndex(releases, "v2"); got != 1 {
-		t.Errorf("releaseIndex = %d, want 1", got)
+	if got := sliceIndex(releases, "v2"); got != 1 {
+		t.Errorf("sliceIndex = %d, want 1", got)
 	}
 }
 
-func TestReleaseIndex_notFound(t *testing.T) {
+func TestSliceIndexRelease_notFound(t *testing.T) {
 	releases := []string{"v1", "v2"}
-	if got := releaseIndex(releases, "v9"); got != 0 {
-		t.Errorf("releaseIndex = %d, want 0", got)
+	if got := sliceIndex(releases, "v9"); got != 0 {
+		t.Errorf("sliceIndex = %d, want 0", got)
 	}
 }
 

package/internal/board/status.go

@@ -9,13 +9,13 @@ const statusGlyphDefault = " "
 
 func statusGlyph(status string) string {
 	switch status {
-	case string(data.StatusPlanned):
+	case string(data.ColumnPlanned):
 		return styles.CardMeta.Render("○")
-	case string(data.StatusInProgress):
+	case string(data.ColumnInProgress):
 		return styles.GlyphBuild.Render("▶")
-	case string(data.StatusDone):
+	case string(data.ColumnDone):
 		return styles.TagDone.Render("◉")
-	case string(data.StatusAudited):
+	case "audited":
 		return styles.TagDone.Render("✓")
 	default:
 		return statusGlyphDefault

package/internal/board/theme.go

@@ -0,0 +1,24 @@
+package board
+
+import (
+	"os"
+
+	"github.com/charmbracelet/lipgloss"
+	"github.com/muesli/termenv"
+)
+
+// applyColorProfile detects terminal color support and configures lipgloss.
+// Priority: NO_COLOR → COLORTERM env hint → termenv auto-detect.
+func applyColorProfile() {
+	lipgloss.SetColorProfile(detectProfile())
+}
+
+func detectProfile() termenv.Profile {
+	if os.Getenv("NO_COLOR") != "" {
+		return termenv.Ascii
+	}
+	if c := os.Getenv("COLORTERM"); c == "truecolor" || c == "24bit" {
+		return termenv.TrueColor
+	}
+	return termenv.ColorProfile()
+}

package/internal/board/theme_test.go

@@ -0,0 +1,31 @@
+package board
+
+import (
+	"testing"
+
+	"github.com/muesli/termenv"
+)
+
+func TestDetectProfileNOCOLOR(t *testing.T) {
+	t.Setenv("NO_COLOR", "1")
+	t.Setenv("COLORTERM", "")
+	if got := detectProfile(); got != termenv.Ascii {
+		t.Fatalf("want Ascii, got %v", got)
+	}
+}
+
+func TestDetectProfileTruecolor(t *testing.T) {
+	t.Setenv("NO_COLOR", "")
+	t.Setenv("COLORTERM", "truecolor")
+	if got := detectProfile(); got != termenv.TrueColor {
+		t.Fatalf("want TrueColor, got %v", got)
+	}
+}
+
+func TestDetectProfile24bit(t *testing.T) {
+	t.Setenv("NO_COLOR", "")
+	t.Setenv("COLORTERM", "24bit")
+	if got := detectProfile(); got != termenv.TrueColor {
+		t.Fatalf("want TrueColor, got %v", got)
+	}
+}

package/internal/board/transitions.go

@@ -1,88 +1,113 @@
-package board
-
-import (
-	"fmt"
-
-	"github.com/opencode/savepoint/internal/data"
-)
-
-// Advance moves a task forward through the phase lifecycle.
-func Advance(t *data.Task) {
-	switch t.Column {
-	case data.ColumnPlanned:
-		t.Column = data.ColumnInProgress
-		t.Stage = data.StageBuild
-	case data.ColumnInProgress:
-		switch t.Stage {
-		case data.StageBuild:
-			t.Stage = data.StageTest
-		case data.StageTest:
-			t.Stage = data.StageAudit
-		case data.StageAudit:
-			t.Column = data.ColumnDone
-			t.Stage = ""
-		}
-	}
-}
-
-// Retreat moves a task backward through the phase lifecycle.
-func Retreat(t *data.Task) {
-	switch t.Column {
-	case data.ColumnDone:
-		t.Column = data.ColumnInProgress
-		t.Stage = data.StageAudit
-	case data.ColumnInProgress:
-		switch t.Stage {
-		case data.StageAudit:
-			t.Stage = data.StageTest
-		case data.StageTest:
-			t.Stage = data.StageBuild
-		case data.StageBuild:
-			t.Column = data.ColumnPlanned
-			t.Stage = ""
-		}
-	}
-}
-
-// CanAdvance checks whether a task is allowed to advance to its next phase.
-// It validates phase adjacency and dependency completion.
-// Returns (true, "") if allowed, or (false, reason) if blocked.
-func CanAdvance(t *data.Task, allTasks []data.Task) (bool, string) {
-	switch t.Column {
-	case data.ColumnPlanned:
-		return true, ""
-	case data.ColumnInProgress:
-		switch t.Stage {
-		case data.StageBuild:
-			return true, ""
-		case data.StageTest:
-			return true, ""
-		case data.StageAudit:
-			for _, depID := range t.DependsOn {
-				dep := findTask(depID, allTasks)
-				if dep == nil {
-					return false, fmt.Sprintf("dependency %q not found", depID)
-				}
-				if dep.Column != data.ColumnDone {
-					return false, fmt.Sprintf("dependency %q is not done", depID)
-				}
-			}
-			return true, ""
-		default:
-			return false, fmt.Sprintf("unknown stage %q", t.Stage)
-		}
-	case data.ColumnDone:
-		return false, "task is already done"
-	default:
-		return false, fmt.Sprintf("unknown column %q", t.Column)
-	}
-}
-
-func findTask(id string, tasks []data.Task) *data.Task {
-	for i := range tasks {
-		if tasks[i].ID == id {
-			return &tasks[i]
-		}
-	}
-	return nil
-}
+package board
+
+import (
+	"fmt"
+
+	"github.com/opencode/savepoint/internal/data"
+)
+
+// Advance moves a task forward through the phase lifecycle.
+func Advance(t *data.Task) {
+	stage := t.Stage
+	if stage == "" {
+		stage = data.StageBuild
+	}
+	switch t.Column {
+	case data.ColumnPlanned:
+		t.Column = data.ColumnInProgress
+		t.Stage = data.StageBuild
+	case data.ColumnInProgress:
+		switch stage {
+		case data.StageBuild:
+			t.Stage = data.StageTest
+		case data.StageTest:
+			t.Stage = data.StageAudit
+		case data.StageAudit:
+			t.Column = data.ColumnDone
+			t.Stage = ""
+		}
+	}
+	t.Status = string(t.Column)
+}
+
+// Retreat moves a task backward through the phase lifecycle.
+func Retreat(t *data.Task) {
+	stage := t.Stage
+	if stage == "" {
+		stage = data.StageBuild
+	}
+	switch t.Column {
+	case data.ColumnDone:
+		t.Column = data.ColumnInProgress
+		t.Stage = data.StageAudit
+	case data.ColumnInProgress:
+		switch stage {
+		case data.StageAudit:
+			t.Stage = data.StageTest
+		case data.StageTest:
+			t.Stage = data.StageBuild
+		case data.StageBuild:
+			t.Column = data.ColumnPlanned
+			t.Stage = ""
+		}
+	}
+	t.Status = string(t.Column)
+}
+
+func taskTransitionMessage(prefix string, task data.Task) string {
+	if task.Column == data.ColumnInProgress {
+		return fmt.Sprintf("%s %s to %s", prefix, shortID(task.ID), task.Stage)
+	}
+	return fmt.Sprintf("%s %s to %s", prefix, shortID(task.ID), task.Column)
+}
+
+// CanAdvance checks whether a task is allowed to advance to its next phase.
+// It validates phase adjacency and dependency completion.
+// Returns (true, "") if allowed, or (false, reason) if blocked.
+func CanAdvance(t *data.Task, allTasks []data.Task) (bool, string) {
+	switch t.Column {
+	case data.ColumnPlanned:
+		return dependenciesDone(t, allTasks)
+	case data.ColumnInProgress:
+		stage := t.Stage
+		if stage == "" {
+			stage = data.StageBuild
+		}
+		switch stage {
+		case data.StageBuild:
+			return true, ""
+		case data.StageTest:
+			return true, ""
+		case data.StageAudit:
+			return dependenciesDone(t, allTasks)
+		default:
+			return false, fmt.Sprintf("unknown stage %q", stage)
+		}
+	case data.ColumnDone:
+		return false, "task is already done"
+	default:
+		return false, fmt.Sprintf("unknown column %q", t.Column)
+	}
+}
+
+func dependenciesDone(t *data.Task, allTasks []data.Task) (bool, string) {
+	for _, depID := range t.DependsOn {
+		dep := findTask(depID, allTasks)
+		if dep == nil {
+			return false, fmt.Sprintf("dependency %q not found", depID)
+		}
+		if dep.Column != data.ColumnDone {
+			return false, fmt.Sprintf("dependency %q is not done", depID)
+		}
+	}
+	return true, ""
+}
+
+func findTask(id string, tasks []data.Task) *data.Task {
+	for i := range tasks {
+		if tasks[i].ID == id {
+			return &tasks[i]
+		}
+	}
+	return nil
+}