savepoint 1.0.2 → 1.0.3

package/internal/board/card.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/charmbracelet/lipgloss"
 	"github.com/opencode/savepoint/internal/data"
 	"github.com/opencode/savepoint/internal/styles"
 )
@@ -24,18 +25,20 @@ func RenderCard(t data.Task, width int, focused bool, routerState *data.RouterSt
 		inner = 2
 	}
 
-	var glyph string
-	if t.Status != "" {
-		glyph = statusGlyph(t.Status)
-	} else if t.Column == data.ColumnDone {
-		glyph = styles.GlyphBuild.Render(glyphBuild)
-	} else if isRouterPriority(t, routerState) {
-		glyph = styles.TagDone.Render(glyphBuild)
-	} else {
-		glyph = phaseGlyphStyled(t.Stage)
-	}
-	// glyph is 1 rune + 1 space prefix; leave room for "▣ "
-	idLine := fmt.Sprintf("%s %s", glyph, truncate(shortID(t.ID), inner-2))
+	glyph := taskGlyph(t, routerState)
+	phase := taskPhaseText(t)
+	idWidth := inner - 2
+	if phase != "" {
+		idWidth -= lipgloss.Width(phase) + 1
+	}
+	if idWidth < 1 {
+		idWidth = 1
+	}
+
+	idLine := fmt.Sprintf("%s %s", glyph, truncate(shortID(t.ID), idWidth))
+	if phase != "" && lipgloss.Width(idLine)+1+lipgloss.Width(phase) <= inner {
+		idLine += " " + phase
+	}
 	titleLine := styles.CardMeta.Render(strings.Join(WrapText(t.Title, inner), "\n"))
 
 	content := idLine + "\n" + titleLine
@@ -46,6 +49,33 @@ func RenderCard(t data.Task, width int, focused bool, routerState *data.RouterSt
 	return styles.Card.Width(width).Render(content)
 }
 
+func taskGlyph(t data.Task, routerState *data.RouterState) string {
+	if t.Column == data.ColumnInProgress {
+		return phaseGlyphStyled(t.Stage)
+	}
+	if t.Column == data.ColumnDone {
+		return styles.GlyphBuild.Render(glyphBuild)
+	}
+	if isRouterPriority(t, routerState) {
+		return styles.TagDone.Render(glyphBuild)
+	}
+	if t.Status != "" {
+		return statusGlyph(t.Status)
+	}
+	return phaseGlyphStyled(t.Stage)
+}
+
+func taskPhaseText(t data.Task) string {
+	switch t.Column {
+	case data.ColumnInProgress:
+		return styles.CardMeta.Render(strings.ToUpper(phaseLabel(t.Stage)))
+	case data.ColumnDone:
+		return styles.CardMeta.Render("DONE")
+	default:
+		return ""
+	}
+}
+
 func phaseGlyphStyled(stage data.ProgressStage) string {
 	switch stage {
 	case data.StageTest:
@@ -96,14 +126,4 @@ func shortID(id string) string {
 	return id
 }
 
-// truncate clips s to max runes, appending "…" if clipped.
-func truncate(s string, max int) string {
-	runes := []rune(s)
-	if len(runes) <= max {
-		return s
-	}
-	if max <= 1 {
-		return "…"
-	}
-	return string(runes[:max-1]) + "…"
-}
+

package/internal/board/card_test.go

@@ -194,13 +194,12 @@ func TestRenderCard_doneTaskUsesOrangeBuildGlyph(t *testing.T) {
 func TestRenderCard_explicitStatusUsesUnifiedGlyph(t *testing.T) {
 	tests := []struct {
 		name   string
-		status data.TaskStatus
+		status string
 		glyph  string
 	}{
-		{"planned", data.StatusPlanned, "○"},
-		{"in progress", data.StatusInProgress, "▶"},
-		{"done", data.StatusDone, "◉"},
-		{"audited", data.StatusAudited, "✓"},
+		{"planned", string(data.ColumnPlanned), "○"},
+		{"done", string(data.ColumnDone), "◉"},
+		{"audited", "audited", "✓"},
 	}
 
 	for _, tt := range tests {
@@ -216,3 +215,40 @@ func TestRenderCard_explicitStatusUsesUnifiedGlyph(t *testing.T) {
 		})
 	}
 }
+
+func TestRenderCard_inProgressShowsPhaseText(t *testing.T) {
+	tests := []struct {
+		name  string
+		stage data.ProgressStage
+		label string
+		glyph string
+	}{
+		{"build", data.StageBuild, "BUILD", glyphBuild},
+		{"test", data.StageTest, "TEST", glyphTest},
+		{"audit", data.StageAudit, "AUDIT", glyphAudit},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			task := data.Task{ID: "T1", Column: data.ColumnInProgress, Status: string(data.ColumnInProgress), Stage: tt.stage}
+			got := RenderCard(task, 30, false, nil)
+			if !strings.Contains(got, tt.label) {
+				t.Errorf("RenderCard missing phase label %q", tt.label)
+			}
+			if !strings.Contains(got, tt.glyph) {
+				t.Errorf("RenderCard missing phase glyph %q", tt.glyph)
+			}
+			if strings.Contains(got, "▶") {
+				t.Error("RenderCard should not use generic in_progress glyph when phase is available")
+			}
+		})
+	}
+}
+
+func TestRenderCard_doneShowsDoneText(t *testing.T) {
+	task := data.Task{ID: "T1", Column: data.ColumnDone, Status: string(data.ColumnDone)}
+	got := RenderCard(task, 30, false, nil)
+	if !strings.Contains(got, "DONE") {
+		t.Error("RenderCard missing DONE phase label")
+	}
+}

package/internal/board/column.go

@@ -28,17 +28,54 @@ func RenderColumn(tasks []data.Task, col data.ColumnType, width, maxHeight, offs
 	if len(tasks) == 0 {
 		lines = append(lines, styles.TaskItem.Render("(empty)"))
 	} else {
-		limit := visibleColumnTaskLimit(maxHeight)
-		end := min(offset+limit, len(tasks))
+		contentBudget := maxHeight - 2
+		if contentBudget < 1 {
+			contentBudget = 1
+		}
+
+		reserveAbove := 0
+		if offset > 0 {
+			reserveAbove = 1
+		}
+
+		type cardEntry struct {
+			card  string
+			lines int
+		}
+		cardEntries := make([]cardEntry, 0, len(tasks)-offset)
+		for i := offset; i < len(tasks); i++ {
+			c := RenderCard(tasks[i], inner, focused && i == focusedTask, routerState)
+			cardEntries = append(cardEntries, cardEntry{card: c, lines: strings.Count(c, "\n") + 1})
+		}
+
+		usedLines := reserveAbove
+		endIdx := 0
+		for endIdx < len(cardEntries) {
+			needsMore := endIdx < len(cardEntries)-1
+			bottomReserve := 0
+			if needsMore {
+				bottomReserve = 1
+			}
+			if usedLines+cardEntries[endIdx].lines+bottomReserve > contentBudget {
+				break
+			}
+			usedLines += cardEntries[endIdx].lines
+			endIdx++
+		}
+
+		if endIdx == 0 && len(cardEntries) > 0 {
+			endIdx = 1
+		}
+
 		if offset > 0 {
 			lines = append(lines, renderScrollIndicator("↑", offset, "above"))
 		}
-		for i, t := range tasks[offset:end] {
-			taskIndex := offset + i
-			lines = append(lines, RenderCard(t, inner, focused && taskIndex == focusedTask, routerState))
+		for i := 0; i < endIdx; i++ {
+			lines = append(lines, cardEntries[i].card)
 		}
-		if end < len(tasks) {
-			lines = append(lines, renderScrollIndicator("↓", len(tasks)-end, "more"))
+		if endIdx < len(cardEntries) {
+			remaining := len(tasks) - (offset + endIdx)
+			lines = append(lines, renderScrollIndicator("↓", remaining, "more"))
 		}
 	}
 
@@ -88,9 +125,3 @@ func columnTitle(col data.ColumnType) string {
 	}
 }
 
-func taskLabel(t data.Task) string {
-	if t.Title == "" {
-		return t.ID
-	}
-	return fmt.Sprintf("%s  %s", t.ID, t.Title)
-}

package/internal/board/column_test.go

@@ -118,12 +118,15 @@ func TestRenderColumn_viewportShowsScrollIndicators(t *testing.T) {
 	if !strings.Contains(got, "↑ 1 above") {
 		t.Error("RenderColumn missing above indicator")
 	}
-	if !strings.Contains(got, "↓ 1 more") {
-		t.Error("RenderColumn missing more indicator")
+	if !strings.Contains(got, "↓ 2 more") {
+		t.Errorf("RenderColumn missing more indicator, got:\n%s", got)
 	}
 	if strings.Contains(got, "Task one") {
 		t.Error("RenderColumn should not render tasks above viewport")
 	}
+	if strings.Contains(got, "Task three") {
+		t.Error("RenderColumn should not render tasks that don't fit budget")
+	}
 	if strings.Contains(got, "Task four") {
 		t.Error("RenderColumn should not render tasks below viewport")
 	}

package/internal/board/detail.go

@@ -182,51 +182,4 @@ func phaseLabel(s data.ProgressStage) string {
 	}
 }
 
-func WrapText(s string, width int) []string {
-	if width < 4 {
-		width = 4
-	}
-	words := strings.Fields(s)
-	if len(words) == 0 {
-		return nil
-	}
-	lines := []string{}
-	current := ""
-	for _, word := range words {
-		if len([]rune(word)) > width {
-			if current != "" {
-				lines = append(lines, current)
-				current = ""
-			}
-			lines = append(lines, SplitLongWord(word, width)...)
-			continue
-		}
-		if current == "" {
-			current = word
-			continue
-		}
-		if len([]rune(current))+1+len([]rune(word)) <= width {
-			current += " " + word
-			continue
-		}
-		lines = append(lines, current)
-		current = word
-	}
-	if current != "" {
-		lines = append(lines, current)
-	}
-	return lines
-}
 
-func SplitLongWord(word string, width int) []string {
-	runes := []rune(word)
-	lines := []string{}
-	for len(runes) > width {
-		lines = append(lines, string(runes[:width]))
-		runes = runes[width:]
-	}
-	if len(runes) > 0 {
-		lines = append(lines, string(runes))
-	}
-	return lines
-}

package/internal/board/epic_panel.go

@@ -8,33 +8,40 @@ import (
 )
 
 // RenderEpicDetail renders an overlay showing the content of an E##-Detail.md file.
-func RenderEpicDetail(epicSlug, content string, overlayW, maxHeight, offset int) string {
+func RenderEpicDetail(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
 	inner := overlayW - detailBorderPad
 	if inner < 4 {
 		inner = 4
 	}
 
+	tabIndicator := renderTabIndicator(tab, inner)
 	lines := []string{
 		styles.EpicTitleFocused.Render("EPIC DETAIL"),
-		strings.Repeat("─", inner),
+		tabIndicator,
 	}
 
 	body := epicDetailBody(content, inner)
-	body = append(body, "", styles.CardMeta.Render("esc:close"))
-	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead, offset)...)
+	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
+	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
 
 	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
 }
 
-// epicDetailBody parses markdown content into display lines, stripping frontmatter.
-func epicDetailBody(content string, width int) []string {
-	if strings.TrimSpace(content) == "" || content == "(no detail available)" {
-		return []string{styles.CardMeta.Render("(no detail available)")}
+func renderTabIndicator(tab int, width int) string {
+	var detail, audit string
+	if tab == 0 {
+		detail = styles.EpicItemFocused.Render("DETAIL [1]")
+		audit = styles.CardMeta.Render("AUDIT [2]")
+	} else {
+		detail = styles.CardMeta.Render("DETAIL [1]")
+		audit = styles.EpicItemFocused.Render("AUDIT [2]")
 	}
+	return detail + styles.CardMeta.Render(" │ ") + audit
+}
 
+// stripFrontmatter removes YAML frontmatter (between leading --- markers) from content.
+func stripFrontmatter(content string) []string {
 	lines := strings.Split(content, "\n")
-
-	// Strip YAML frontmatter between leading --- markers.
 	start := 0
 	if len(lines) > 0 && strings.TrimSpace(lines[0]) == "---" {
 		for i := 1; i < len(lines); i++ {
@@ -44,7 +51,16 @@ func epicDetailBody(content string, width int) []string {
 			}
 		}
 	}
-	lines = lines[start:]
+	return lines[start:]
+}
+
+// epicDetailBody parses markdown content into display lines, stripping frontmatter.
+func epicDetailBody(content string, width int) []string {
+	if strings.TrimSpace(content) == "" || content == "(no detail available)" {
+		return []string{styles.CardMeta.Render("(no detail available)")}
+	}
+
+	lines := stripFrontmatter(content)
 
 	var body []string
 	skip := false
@@ -77,11 +93,87 @@ func epicDetailBody(content string, width int) []string {
 	return body
 }
 
+// RenderEpicAuditTab renders an overlay showing audit findings from an E##-Audit.md file.
+func RenderEpicAuditTab(epicSlug, content string, overlayW, maxHeight, offset int, tab int) string {
+	inner := overlayW - detailBorderPad
+	if inner < 4 {
+		inner = 4
+	}
+
+	tabIndicator := renderTabIndicator(tab, inner)
+	lines := []string{
+		styles.GlyphAudit.Render("EPIC AUDIT"),
+		tabIndicator,
+	}
+
+	body := epicAuditBody(content, inner)
+	body = append(body, "", styles.CardMeta.Render("1:Detail 2:Audit  esc:close"))
+	lines = append(lines, visibleDetailLines(body, maxHeight-detailVerticalOverhead-1, offset)...)
+
+	return styles.EpicDetailOverlay.Width(overlayW).Render(strings.Join(lines, "\n"))
+}
+
+var epicAuditHiddenSectionHeadings = map[string]struct{}{
+	"12. Distribution & build": {},
+	"Acceptance Criteria":      {},
+	"Architectural notes":      {},
+	"Boundaries":               {},
+	"Context Files":            {},
+	"Implemented As":           {},
+	"Implemented as":           {},
+	"Implementation Plan":      {},
+	"Manual audit override":    {},
+	"Proposed Changes":         {},
+	"Quality Review":           {},
+	"With":                     {},
+}
+
+func epicAuditBody(content string, width int) []string {
+	if strings.TrimSpace(content) == "" || content == "(no audit available)" {
+		return []string{styles.CardMeta.Render("(no audit available)")}
+	}
+
+	lines := stripFrontmatter(content)
+
+	var body []string
+	inHiddenSection := false
+
+	for _, line := range lines {
+		trimmed := strings.TrimRight(line, " \t\r")
+		switch {
+		case strings.HasPrefix(trimmed, "## "):
+			sectionName := strings.TrimPrefix(trimmed, "## ")
+			_, inHiddenSection = epicAuditHiddenSectionHeadings[sectionName]
+			if !inHiddenSection {
+				body = append(body, "", styles.EpicItemFocused.Render(sectionName))
+			}
+		case inHiddenSection:
+		case strings.HasPrefix(trimmed, "### "):
+			body = append(body, styles.EpicItemFocused.Render(strings.TrimPrefix(trimmed, "### ")))
+		case strings.HasPrefix(trimmed, "- [x] ") || strings.HasPrefix(trimmed, "- [X] "):
+			text := strings.TrimPrefix(strings.TrimPrefix(trimmed, "- [x] "), "- [X] ")
+			body = append(body, renderChecklistSentences(text, "[x] ", width, styles.TagDone)...)
+		case strings.HasPrefix(trimmed, "- [ ] "):
+			text := strings.TrimPrefix(trimmed, "- [ ] ")
+			body = append(body, renderChecklistSentences(text, "[ ] ", width, styles.CardMeta)...)
+		case strings.HasPrefix(trimmed, "- "):
+			body = append(body, styles.CardMeta.Render("• "+strings.TrimPrefix(trimmed, "- ")))
+		case trimmed == "":
+			body = append(body, "")
+		default:
+			for _, wrapped := range WrapText(trimmed, width) {
+				body = append(body, styles.CardMeta.Render(wrapped))
+			}
+		}
+	}
+	return body
+}
+
 const epicActiveMarker = "►"
 
 // RenderEpicSidebar renders the fixed left sidebar listing epics with active indicator.
 // If epics is empty and selected is non-empty, selected is shown as the sole entry.
-func RenderEpicSidebar(epics []string, selected string, width int, focus bool, cursor int, status map[string]string) string {
+func RenderEpicSidebar(epics []string, selected string, width int, focus bool, cursor int, status map[string]string, maxHeight int) string {
 	inner := width - epicPanelOverhead
 	if inner < 2 {
 		inner = 2
@@ -114,6 +206,20 @@ func RenderEpicSidebar(epics []string, selected string, width int, focus bool, c
 	if len(list) == 0 {
 		lines = append(lines, styles.TaskItem.Render("(none)"))
 	}
+	if maxHeight > 0 && len(lines) > maxHeight {
+		items := lines[2:]
+		available := maxHeight - 3
+		if available < 1 {
+			available = 1
+		}
+		clipped := make([]string, 0, maxHeight)
+		clipped = append(clipped, lines[0], lines[1])
+		clipped = append(clipped, items[:min(available, len(items))]...)
+		if len(items) > available {
+			clipped = append(clipped, renderScrollIndicator("↓", len(items)-available, "more"))
+		}
+		lines = clipped
+	}
 	style := styles.EpicPanel.Width(width)
 	if focus && len(epics) > 0 {
 		style = styles.EpicPanelFocused.Width(width)
@@ -154,13 +260,3 @@ func RenderEpicDropdown(epics []string, cursor int, width int) string {
 	lines = append(lines, "", styles.CardMeta.Render("↑↓:nav  enter:select  esc:cancel"))
 	return styles.EpicPanel.Width(width).Render(strings.Join(lines, "\n"))
 }
-
-// epicIndex returns the index of selected in epics, or 0 if not found.
-func epicIndex(epics []string, selected string) int {
-	for i, e := range epics {
-		if e == selected {
-			return i
-		}
-	}
-	return 0
-}