rollbar 2.24.0 → 2.25.1

package/test/browser.core.test.js

@@ -43,23 +43,26 @@ describe('options.captureUncaught', function() {
 
     var element = document.getElementById('throw-error');
     element.click();
-    server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+    setTimeout(function() {
+      server.respond();
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('test error');
-    expect(body.data.notifier.diagnostic.raw_error.message).to.eql('test error');
-    expect(body.data.notifier.diagnostic.is_uncaught).to.eql(true);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false
-    });
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace.exception.message).to.eql('test error');
+      expect(body.data.notifier.diagnostic.raw_error.message).to.eql('test error');
+      expect(body.data.notifier.diagnostic.is_uncaught).to.eql(true);
 
-    done();
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false
+      });
+
+      done();
+    }, 1);
   });
 
   it('should respond to enable/disable in configure', function(done) {
@@ -75,34 +78,43 @@ describe('options.captureUncaught', function() {
     var rollbar = window.rollbar = new Rollbar(options);
 
     element.click();
-    server.respond();
-    expect(server.requests.length).to.eql(0); // Disabled, no event
-    server.requests.length = 0;
 
-    rollbar.configure({
-      captureUncaught: true
-    });
+    setTimeout(function() {
+      server.respond();
+      expect(server.requests.length).to.eql(0); // Disabled, no event
+      server.requests.length = 0;
 
-    element.click();
-    server.respond();
+      rollbar.configure({
+        captureUncaught: true
+      });
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      element.click();
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('test error');
-    expect(body.data.notifier.diagnostic.is_anonymous).to.not.be.ok();
+      setTimeout(function() {
+        server.respond();
 
-    server.requests.length = 0;
+        var body = JSON.parse(server.requests[0].requestBody);
 
-    rollbar.configure({
-      captureUncaught: false
-    });
+        expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+        expect(body.data.body.trace.exception.message).to.eql('test error');
+        expect(body.data.notifier.diagnostic.is_anonymous).to.not.be.ok();
 
-    element.click();
-    server.respond();
-    expect(server.requests.length).to.eql(0); // Disabled, no event
+        server.requests.length = 0;
 
-    done();
+        rollbar.configure({
+          captureUncaught: false
+        });
+
+        element.click();
+
+        setTimeout(function() {
+          server.respond();
+          expect(server.requests.length).to.eql(0); // Disabled, no event
+
+          done();
+        }, 1);
+      }, 1);
+    }, 1);
   });
 
   // Test case expects Chrome, which is the currently configured karma js/browser
@@ -132,22 +144,24 @@ describe('options.captureUncaught', function() {
       Error.prepareStackTrace(e);
     }
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('anon error');
-    expect(body.data.notifier.diagnostic.is_anonymous).to.eql(true);
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace.exception.message).to.eql('anon error');
+      expect(body.data.notifier.diagnostic.is_anonymous).to.eql(true);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false
-    });
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false
+      });
 
-    done();
+      done();
+    }, 1);
   });
 
   it('should ignore duplicate errors by default', function(done) {
@@ -167,24 +181,27 @@ describe('options.captureUncaught', function() {
     for(var i = 0; i < 2; i++) {
       element.click(); // use for loop to ensure the stack traces have identical line/col info
     }
-    server.respond();
 
-    // transmit only once
-    expect(server.requests.length).to.eql(1);
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      // transmit only once
+      expect(server.requests.length).to.eql(1);
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('test error');
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false
-    });
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace.exception.message).to.eql('test error');
 
-    done();
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false
+      });
+
+      done();
+    }, 1);
   });
 
   it('should transmit duplicate errors when set in config', function(done) {
@@ -205,24 +222,27 @@ describe('options.captureUncaught', function() {
     for(var i = 0; i < 2; i++) {
       element.click(); // use for loop to ensure the stack traces have identical line/col info
     }
-    server.respond();
 
-    // transmit both errors
-    expect(server.requests.length).to.eql(2);
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      // transmit both errors
+      expect(server.requests.length).to.eql(2);
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('test error');
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false
-    });
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace.exception.message).to.eql('test error');
 
-    done();
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false
+      });
+
+      done();
+    }, 1);
   });
   it('should send DOMException as trace_chain', function(done) {
     var server = window.server;
@@ -237,21 +257,24 @@ describe('options.captureUncaught', function() {
 
     var element = document.getElementById('throw-dom-exception');
     element.click();
-    server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+    setTimeout(function() {
+      server.respond();
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace_chain[0].exception.message).to.eql('test DOMException');
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false
-    });
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace_chain[0].exception.message).to.eql('test DOMException');
 
-    done();
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false
+      });
+
+      done();
+    }, 1);
   });
 
   it('should capture exta frames when stackTraceLimit is set', function(done) {
@@ -269,23 +292,26 @@ describe('options.captureUncaught', function() {
 
     var element = document.getElementById('throw-depp-stack-error');
     element.click();
-    server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+    setTimeout(function() {
+      server.respond();
 
-    expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
-    expect(body.data.body.trace.exception.message).to.eql('deep stack error');
-    expect(body.data.body.trace.frames.length).to.be.above(20);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    // karma doesn't unload the browser between tests, so the onerror handler
-    // will remain installed. Unset captureUncaught so the onerror handler
-    // won't affect other tests.
-    rollbar.configure({
-      captureUncaught: false,
-      stackTraceLimit: oldLimit // reset to default
-    });
+      expect(body.access_token).to.eql('POST_CLIENT_ITEM_TOKEN');
+      expect(body.data.body.trace.exception.message).to.eql('deep stack error');
+      expect(body.data.body.trace.frames.length).to.be.above(20);
 
-    done();
+      // karma doesn't unload the browser between tests, so the onerror handler
+      // will remain installed. Unset captureUncaught so the onerror handler
+      // won't affect other tests.
+      rollbar.configure({
+        captureUncaught: false,
+        stackTraceLimit: oldLimit // reset to default
+      });
+
+      done();
+    }, 1);
   });
 });
 
@@ -440,16 +466,18 @@ describe('log', function() {
 
     rollbar.log('test message', { 'foo': 'bar' });
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    expect(body.data.body.message.body).to.eql('test message');
-    expect(body.data.body.message.extra).to.eql({ 'foo': 'bar' });
-    expect(body.data.notifier.diagnostic.is_uncaught).to.eql(undefined);
-    expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['string', 'object']);
+      expect(body.data.body.message.body).to.eql('test message');
+      expect(body.data.body.message.extra).to.eql({ 'foo': 'bar' });
+      expect(body.data.notifier.diagnostic.is_uncaught).to.eql(undefined);
+      expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['string', 'object']);
 
-    done();
+      done();
+    }, 1);
   })
 
   it('should send exception when called with error and extra args', function(done) {
@@ -464,16 +492,18 @@ describe('log', function() {
 
     rollbar.log(new Error('test error'), { 'foo': 'bar' });
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    expect(body.data.body.trace.exception.message).to.eql('test error');
-    expect(body.data.body.trace.extra).to.eql({ 'foo': 'bar' });
-    expect(body.data.notifier.diagnostic.is_uncaught).to.eql(undefined);
-    expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['error', 'object']);
+      expect(body.data.body.trace.exception.message).to.eql('test error');
+      expect(body.data.body.trace.extra).to.eql({ 'foo': 'bar' });
+      expect(body.data.notifier.diagnostic.is_uncaught).to.eql(undefined);
+      expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['error', 'object']);
 
-    done();
+      done();
+    }, 1);
   })
 
   it('should add custom data when called with error context', function(done) {
@@ -492,15 +522,71 @@ describe('log', function() {
 
     rollbar.error(err, { 'foo': 'bar' });
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
+
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      expect(body.data.body.trace.exception.message).to.eql('test error');
+      expect(body.data.custom.foo).to.eql('bar');
+      expect(body.data.custom.err).to.eql('test');
 
-    expect(body.data.body.trace.exception.message).to.eql('test error');
-    expect(body.data.custom.foo).to.eql('bar');
-    expect(body.data.custom.err).to.eql('test');
+      done();
+    }, 1);
+  })
 
-    done();
+  it('should remove circular references in custom data', function(done) {
+    var server = window.server;
+    stubResponse(server);
+    server.requests.length = 0;
+
+    var options = {
+      accessToken: 'POST_CLIENT_ITEM_TOKEN',
+      addErrorContext: true
+    };
+    var rollbar = window.rollbar = new Rollbar(options);
+
+    var err = new Error('test error');
+    var contextData = { extra: 'baz' }
+    contextData.data = contextData;
+    var context = { err: 'test', contextData: contextData };
+    err.rollbarContext = context;
+
+    var array = ['one', 'two'];
+    array.push(array);
+    var custom = { foo: 'bar', array: array };
+    var notCircular = { key: 'value' };
+    custom.notCircular1 = notCircular;
+    custom.notCircular2 = notCircular;
+    custom.self = custom;
+    rollbar.error(err, custom);
+
+    setTimeout(function() {
+      server.respond();
+
+      var body = JSON.parse(server.requests[0].requestBody);
+
+      expect(body.data.body.trace.exception.message).to.eql('test error');
+      expect(body.data.custom.foo).to.eql('bar');
+      expect(body.data.custom.err).to.eql('test');
+
+      // Duplicate objects are allowed when there is no circular reference.
+      expect(body.data.custom.notCircular1).to.eql(notCircular);
+      expect(body.data.custom.notCircular2).to.eql(notCircular);
+
+      expect(body.data.custom.self).to.eql(
+        'Removed circular reference: object'
+      );
+      expect(body.data.custom.array).to.eql([
+        'one', 'two', 'Removed circular reference: array'
+      ]);
+      expect(body.data.custom.contextData).to.eql({
+        extra: 'baz',
+        data: 'Removed circular reference: object'
+      });
+
+      done();
+    }, 1);
   })
 
   it('should send message when called with only null arguments', function(done) {
@@ -516,14 +602,16 @@ describe('log', function() {
 
     rollbar.log(null);
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
 
-    var body = JSON.parse(server.requests[0].requestBody);
+      var body = JSON.parse(server.requests[0].requestBody);
 
-    expect(body.data.body.message.body).to.eql('Item sent with null or missing arguments.');
-    expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['null']);
+      expect(body.data.body.message.body).to.eql('Item sent with null or missing arguments.');
+      expect(body.data.notifier.diagnostic.original_arg_types).to.eql(['null']);
 
-    done();
+      done();
+    }, 1);
   })
 
   it('should skipFrames when set', function(done) {
@@ -542,14 +630,16 @@ describe('log', function() {
     rollbar.log(error);
     rollbar.log(error, { skipFrames: 1 });
 
-    server.respond();
+    setTimeout(function() {
+      server.respond();
 
-    var frames1 = JSON.parse(server.requests[0].requestBody).data.body.trace.frames;
-    var frames2 = JSON.parse(server.requests[1].requestBody).data.body.trace.frames;
+      var frames1 = JSON.parse(server.requests[0].requestBody).data.body.trace.frames;
+      var frames2 = JSON.parse(server.requests[1].requestBody).data.body.trace.frames;
 
-    expect(frames1.length).to.eql(frames2.length + 1);
-    expect(frames1.slice(0,-1)).to.eql(frames2);
+      expect(frames1.length).to.eql(frames2.length + 1);
+      expect(frames1.slice(0,-1)).to.eql(frames2);
 
-    done();
+      done();
+    }, 1);
   })
 });