rollbar 2.24.0 → 2.25.1

package/index.d.ts

@@ -40,6 +40,9 @@ declare namespace Rollbar {
     ) => void | Promise<TResult>;
     export type MaybeError = Error | undefined | null;
     export type Level = "debug" | "info" | "warning" | "error" | "critical";
+    /**
+     * {@link https://docs.rollbar.com/docs/rollbarjs-configuration-reference#reference}
+     */
     export interface Configuration {
         accessToken?: string;
         addErrorContext?: boolean;
@@ -52,7 +55,15 @@ declare namespace Rollbar {
         captureUnhandledRejections?: boolean;
         captureUsername?: boolean;
         checkIgnore?: (isUncaught: boolean, args: LogArgument[], item: object) => boolean;
+        /**
+         * `codeVersion` takes precedence over `code_version`, if provided.
+         * `client.javascript.code_version` takes precedence over both top level properties.
+         */
         codeVersion?: string;
+        /**
+         * `codeVersion` takes precedence over `code_version`, if provided.
+         * `client.javascript.code_version` takes precedence over both top level properties.
+         */
         code_version?: string;
         enabled?: boolean;
         endpoint?: string;
@@ -77,7 +88,7 @@ declare namespace Rollbar {
         nodeSourceMaps?: boolean;
         onSendCallback?: (isUncaught: boolean, args: LogArgument[], item: object) => void;
         overwriteScrubFields?: boolean;
-        payload?: object;
+        payload?: Payload;
         reportLevel?: Level;
         rewriteFilenamePatterns?: string[];
         scrubFields?: string[];
@@ -89,7 +100,7 @@ declare namespace Rollbar {
         stackTraceLimit?: number;
         telemetryScrubber?: TelemetryScrubber;
         timeout?: number;
-        transform?: (data: object) => void;
+        transform?: (data: object, item: object) => void | Promise<void>;
         transmit?: boolean;
         uncaughtErrorLevel?: Level;
         verbose?: boolean;
@@ -143,7 +154,7 @@ declare namespace Rollbar {
     export type LocalsType = typeof Locals;
     export type LocalsOptions = LocalsType | LocalsSettings;
     export interface LocalsSettings {
-        locals: LocalsType,
+        module: LocalsType,
         enabled?: boolean;
         uncaughtOnly?: boolean;
         depth?: number;
@@ -169,4 +180,73 @@ declare namespace Rollbar {
         scrub?: ScrubType,
         truncation?: TruncationType
     }
+
+    /**
+      * @deprecated number is deprecated for this field
+      */
+     export type DeprecatedNumber = number;
+
+    /**
+     * {@link https://docs.rollbar.com/docs/rollbarjs-configuration-reference#payload-1}
+     */
+    export interface Payload {
+        person?: {
+            id: string | DeprecatedNumber;
+            username?: string;
+            email?: string;
+            [property: string]: any;
+        },
+        context?: any;
+        client?: {
+            javascript?: {
+                /**
+                 * Version control number (i.e. git SHA) of the current revision. Used for linking filenames in stacktraces to GitHub.
+                 * Note: for the purposes of nesting under the payload key, only code_version will correctly set the value in the final item.
+                 * However, if you wish to set this code version at the top level of the configuration object rather than nested under
+                 * the payload key, we will accept both codeVersion and code_version with codeVersion given preference if both happened
+                 * to be defined. Furthermore, if code_version is nested under the payload key this will have the final preference over
+                 * any value set at the top level.
+                 */
+                code_version?: string | DeprecatedNumber;
+                /**
+                 * When true, the Rollbar service will attempt to find and apply source maps to all frames in the stack trace.
+                 * @default false
+                 */
+                source_map_enabled?: boolean;
+                /**
+                 * When true, the Rollbar service will attempt to apply source maps to frames even if they are missing column numbers.
+                 * Works best when the minified javascript file is generated using newlines instead of semicolons.
+                 * @default false
+                 */
+                guess_uncaught_frames?: boolean;
+                [property: string]: any;
+            }
+            [property: string]: any;
+        },
+        /**
+         * The environment that your code is running in.
+         * @default undefined
+         */
+        environment?: string;
+        server?: {
+            /**
+             * @default master
+             */
+            branch?: string;
+            /**
+             * The hostname of the machine that rendered the page.
+             */
+            host?: string;
+            /**
+             * It is used in two different ways: `source maps`, and `source control`.
+             *
+             * If you are looking for more information on it please go to:
+             * {@link https://docs.rollbar.com/docs/source-maps}
+             * {@link https://docs.rollbar.com/docs/source-control}
+             */
+            root?: string;
+            [property: string]: any;
+        },
+        [property: string]: any;
+    }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rollbar",
-  "version": "2.24.0",
+  "version": "2.25.1",
   "repository": {
     "type": "git",
     "url": "http://github.com/rollbar/rollbar.js"
@@ -11,14 +11,13 @@
   "browser": "dist/rollbar.umd.min.js",
   "types": "./index.d.ts",
   "dependencies": {
-    "async": "~1.2.1",
+    "async": "~3.2.3",
     "console-polyfill": "0.3.0",
     "error-stack-parser": "^2.0.4",
     "json-stringify-safe": "~5.0.0",
     "lru-cache": "~2.2.1",
     "request-ip": "~2.0.1",
-    "source-map": "^0.5.7",
-    "uuid": "3.0.x"
+    "source-map": "^0.5.7"
   },
   "devDependencies": {
     "babel-core": "^6.26.3",
@@ -66,7 +65,6 @@
     "karma-sourcemap-loader": "^0.3.5",
     "karma-webpack": "^4.0.2",
     "mocha": "^7.1.2",
-    "mootools": "^1.5.1",
     "natives": "^1.1.6",
     "nock": "^11.9.1",
     "node-libs-browser": "^0.5.2",
@@ -78,7 +76,7 @@
     "strict-loader": "^1.2.0",
     "time-grunt": "^1.0.0",
     "vows": "^0.8.3",
-    "webpack": "^4.41.5"
+    "webpack": "^4.46.0"
   },
   "optionalDependencies": {
     "decache": "^3.0.5"

package/src/api.js

@@ -47,7 +47,12 @@ function Api(options, transport, urllib, truncation, jsonBackup) {
 Api.prototype.postItem = function(data, callback) {
   var transportOptions = helpers.transportOptions(this.transportOptions, 'POST');
   var payload = helpers.buildPayload(this.accessToken, data, this.jsonBackup);
-  this.transport.post(this.accessToken, transportOptions, payload, callback);
+  var self = this;
+
+  // ensure the network request is scheduled after the current tick.
+  setTimeout(function() {
+    self.transport.post(self.accessToken, transportOptions, payload, callback);
+  }, 0);
 };
 
 /**

package/src/browser/shim.js

@@ -62,9 +62,16 @@ function setupShim(window, options) {
       globals.captureUnhandledRejections(window, handler, true);
     }
 
+    function pageTelemetryEnabled(ai) {
+      if (typeof ai === 'object' && (ai.page === undefined || ai.page)) {
+        return true;
+      }
+      return false;
+    }
+
     var ai = options.autoInstrument;
     if (options.enabled !== false) {
-      if (ai === undefined || ai === true || (typeof ai === 'object' && ai.network)) {
+      if (ai === undefined || ai === true || pageTelemetryEnabled(ai)) {
         if (window.addEventListener) {
           window.addEventListener('load', handler.captureLoad.bind(handler));
           window.addEventListener('DOMContentLoaded', handler.captureDomContentLoaded.bind(handler));

package/src/browser/telemetry.js

@@ -403,8 +403,10 @@ Instrumenter.prototype.instrumentNetwork = function() {
               // Test to ensure body is a Promise, which it should always be.
               if (typeof body.then === 'function') {
                 body.then(function (text) {
-                  if (self.isJsonContentType(metadata.response_content_type)) {
+                  if (text && self.isJsonContentType(metadata.response_content_type)) {
                     metadata.response.body = self.scrubJson(text);
+                  } else {
+                    metadata.response.body = text;
                   }
                 });
               } else {
@@ -729,16 +731,16 @@ Instrumenter.prototype.handleCspError = function(message) {
 }
 
 Instrumenter.prototype.deinstrumentContentSecurityPolicy = function() {
-  if (!('addEventListener' in this._window)) { return; }
+  if (!('addEventListener' in this._document)) { return; }
 
   this.removeListeners('contentsecuritypolicy');
 };
 
 Instrumenter.prototype.instrumentContentSecurityPolicy = function() {
-  if (!('addEventListener' in this._window)) { return; }
+  if (!('addEventListener' in this._document)) { return; }
 
   var cspHandler = this.handleCspEvent.bind(this);
-  this.addListener('contentsecuritypolicy', this._window, 'securitypolicyviolation', null, cspHandler, false);
+  this.addListener('contentsecuritypolicy', this._document, 'securitypolicyviolation', null, cspHandler, false);
 };
 
 Instrumenter.prototype.addListener = function(section, obj, type, altType, handler, capture) {

package/src/browser/transforms.js

@@ -42,8 +42,8 @@ function addErrorContext(item) {
 
   chain.push(err);
 
-  while (err.nested) {
-    err = err.nested;
+  while (err.nested || err.cause) {
+    err = err.nested || err.cause;
     chain.push(err);
   }
 

package/src/defaults.js

@@ -1,5 +1,5 @@
 module.exports = {
-  version: '2.24.0',
+  version: '2.25.1',
   endpoint: 'api.rollbar.com/api/1/item/',
   logLevel: 'debug',
   reportLevel: 'debug',

package/src/errorParser.js

@@ -64,11 +64,11 @@ function Stack(exception, skip) {
 function parse(e, skip) {
   var err = e;
 
-  if (err.nested) {
+  if (err.nested || err.cause) {
     var traceChain = [];
     while (err) {
       traceChain.push(new Stack(err, skip));
-      err = err.nested;
+      err = err.nested || err.cause;
 
       skip = 0; // Only apply skip value to primary error
     }

package/src/server/parser.js

@@ -181,7 +181,7 @@ function shouldReadFrameFile(frameFilename, callback) {
   isCached = !!cache.get(frameFilename);
   isPending = !!pendingReads[frameFilename];
 
-  callback(isValidFilename && !isCached && !isPending);
+  callback(null, isValidFilename && !isCached && !isPending);
 }
 
 
@@ -201,19 +201,13 @@ function readFileLines(filename, callback) {
   }
 }
 
-
-/* Older versions of node do not have fs.exists so we implement our own */
 function checkFileExists(filename, callback) {
   if (stackTrace.sourceContent(filename)) {
-    return callback(true);
-  }
-  if (fs.exists !== undefined) {
-    fs.exists(filename, callback);
-  } else {
-    fs.stat(filename, function (err) {
-      callback(!err);
-    });
+    return callback(null, true);
   }
+  fs.stat(filename, function (err) {
+    callback(null, !err);
+  });
 }
 
 
@@ -226,7 +220,9 @@ function gatherContexts(frames, callback) {
     }
   });
 
-  async.filter(frameFilenames, shouldReadFrameFile, function (results) {
+  async.filter(frameFilenames, shouldReadFrameFile, function (err, results) {
+    if (err) return callback(err);
+
     var tempFileCache;
 
     tempFileCache = {};
@@ -270,7 +266,8 @@ function gatherContexts(frames, callback) {
       callback(null);
     }
 
-    async.filter(results, checkFileExists, function (filenames) {
+    async.filter(results, checkFileExists, function (err, filenames) {
+      if (err) return callback(err);
       async.each(filenames, gatherFileData, function (err) {
         if (err) {
           return callback(err);
@@ -367,7 +364,8 @@ exports.parseStack = function (stack, options, item, callback) {
       return callback(err);
     }
     frames.reverse();
-    async.filter(frames, function (frame, callback) { callback(!!frame); }, function (results) {
+    async.filter(frames, function (frame, callback) { callback(null, !!frame); }, function (err, results) {
+      if (err) return callback(err);
       gatherContexts(results, callback);
     });
   });

package/src/server/transforms.js

@@ -85,7 +85,7 @@ function handleItemWithError(item, options, callback) {
   var chain = [];
   do {
     errors.push(err);
-    err = err.nested;
+    err = err.nested || err.cause;
   } while (err);
   item.stackInfo = chain;
 

package/src/utility.js

@@ -398,6 +398,37 @@ function wrapCallback(logger, f) {
   };
 }
 
+function nonCircularClone(obj) {
+  var seen = [obj];
+
+  function clone(obj, seen) {
+    var value, name, newSeen, result = {};
+
+    try {
+      for (name in obj) {
+        value = obj[name];
+
+        if (value && (isType(value, 'object') || isType(value, 'array'))) {
+          if (seen.includes(value)) {
+            result[name] = 'Removed circular reference: ' + typeName(value);
+          } else {
+            newSeen = seen.slice();
+            newSeen.push(value);
+            result[name] = clone(value, newSeen);
+          }
+          continue;
+        }
+
+        result[name] = value;
+      }
+    } catch (e) {
+      result = 'Failed cloning custom data: ' + e.message;
+    }
+    return result;
+  }
+  return clone(obj, seen);
+}
+
 function createItem(args, logger, notifier, requestKeys, lambdaContext) {
   var message, err, custom, callback, request;
   var arg;
@@ -455,10 +486,12 @@ function createItem(args, logger, notifier, requestKeys, lambdaContext) {
     }
   }
 
+  // if custom is an array this turns it into an object with integer keys
+  if (custom) custom = nonCircularClone(custom);
+
   if (extraArgs.length > 0) {
-    // if custom is an array this turns it into an object with integer keys
-    custom = merge(custom);
-    custom.extraArgs = extraArgs;
+    if (!custom) custom = nonCircularClone({});
+    custom.extraArgs = nonCircularClone(extraArgs);
   }
 
   var item = {
@@ -503,7 +536,7 @@ function addErrorContext(item, errors) {
   try {
     for (var i = 0; i < errors.length; ++i) {
       if (errors[i].hasOwnProperty('rollbarContext')) {
-        custom = merge(custom, errors[i].rollbarContext);
+        custom = merge(custom, nonCircularClone(errors[i].rollbarContext));
         contextAdded = true;
       }
     }