rig-review 3.7.0 → 4.0.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +3 -3
- package/docs/DESIGN.md +145 -74
- package/docs/PANELS.md +20 -12
- package/docs/PARTS_VIEW.md +133 -76
- package/docs/REVIEW_PACKAGE.md +446 -100
- package/docs/STABILITY.md +132 -198
- package/docs/WORKFLOWS.md +41 -120
- package/package.json +4 -3
- package/skills/rig-review/SKILL.md +41 -27
- package/src/build.ts +10 -2
- package/src/cli.ts +17 -16
- package/src/comment-crops.ts +6 -1
- package/src/compare-html.ts +22 -24
- package/src/compare-server.ts +1 -1
- package/src/compare-session.ts +41 -3
- package/src/correction-handoff.ts +27 -4
- package/src/create-pin-gate.ts +3 -0
- package/src/direction-inspection.ts +6 -2
- package/src/feedback-export.ts +68 -1
- package/src/front.ts +5 -200
- package/src/handoff.ts +1 -1
- package/src/interview-routes.ts +1 -1
- package/src/interview-scene.ts +3 -3
- package/src/job-act.ts +77 -73
- package/src/job-api.ts +326 -13
- package/src/job-checkpoint-evidence.ts +113 -0
- package/src/job-cli.ts +27 -14
- package/src/job-contract.ts +284 -62
- package/src/job-front.ts +192 -61
- package/src/job-host.ts +23 -4
- package/src/job-session.ts +109 -24
- package/src/job-source.ts +227 -58
- package/src/job-store.ts +80 -6
- package/src/job-worker.ts +1 -47
- package/src/joined-project.ts +61 -4
- package/src/manifest.ts +32 -4
- package/src/open-workspace.ts +12 -12
- package/src/open.ts +19 -12
- package/src/parts-comment-crops.ts +126 -31
- package/src/parts-comment.ts +351 -28
- package/src/parts-server.ts +19 -7
- package/src/parts-view.ts +588 -109
- package/src/scene-inspection.ts +50 -0
- package/src/server.ts +31 -22
- package/src/session.ts +58 -0
- package/src/stage-comment.ts +48 -1
- package/src/stage-parts.ts +23 -11
- package/web/animation-inspection.ts +1 -1
- package/web/bones-panel.ts +1 -3
- package/web/catalog-en.ts +175 -39
- package/web/catalog-ko.ts +175 -39
- package/web/cloth-panel.ts +1 -2
- package/web/compare.css +3 -13
- package/web/compare.html +3 -3
- package/web/compare.ts +69 -64
- package/web/cuts-panel.ts +1 -3
- package/web/density-strip-panel.ts +1 -2
- package/web/direction-panel.ts +22 -6
- package/web/i18n.ts +13 -1
- package/web/idle-panel.ts +1 -2
- package/web/index.html +1 -5
- package/web/inspection-persistence.ts +2 -1
- package/web/inspector-blocks.ts +149 -40
- package/web/instance-access.ts +24 -5
- package/web/interview-panel.ts +224 -175
- package/web/job-rig-capture.ts +164 -21
- package/web/job-rig-screen.ts +344 -0
- package/web/job-session.ts +611 -1443
- package/web/main.ts +614 -151
- package/web/mesh-panel.ts +1 -2
- package/web/owner-workspace.ts +88 -109
- package/web/part-selection.ts +47 -6
- package/web/part-thumbnails.ts +20 -6
- package/web/parts-render.ts +26 -19
- package/web/parts-viewport-provider.ts +181 -7
- package/web/physics-panel.ts +1 -2
- package/web/readings-panel.ts +1 -2
- package/web/requirements-panel.ts +1 -3
- package/web/retained-frame-stage.ts +105 -0
- package/web/retarget-panel.ts +2 -3
- package/web/rig-fields-panel.ts +1 -2
- package/web/rig-host.ts +64 -0
- package/web/rig-viewport-provider.ts +65 -16
- package/web/scene-plates.ts +57 -4
- package/web/stage-comments.ts +103 -46
- package/web/styles.css +117 -63
- package/web/view-controls.ts +201 -12
- package/web/viewport-capture.ts +12 -2
- package/web/viewport-controller.ts +107 -27
- package/web/viewport-pair.ts +2 -1
- package/web/workspace-preferences.ts +5 -4
- package/web/workspace-ui.ts +151 -19
- package/src/front-worker.ts +0 -2
- package/src/interview-server.ts +0 -54
- package/src/job-hub.ts +0 -304
- package/src/job-image-set.ts +0 -50
- package/web/interview.css +0 -28
- package/web/interview.html +0 -17
- package/web/interview.ts +0 -40
- package/web/job-hub.css +0 -14
- package/web/job-hub.html +0 -5
- package/web/job-hub.ts +0 -179
- package/web/owner-workspace.css +0 -14
- package/web/owner-workspace.html +0 -5
- package/web/parts-flags.ts +0 -48
- package/web/parts.css +0 -104
- package/web/parts.html +0 -49
- package/web/parts.ts +0 -604
- package/web/stage-nav.ts +0 -136
package/docs/STABILITY.md
CHANGED
|
@@ -1,5 +1,39 @@
|
|
|
1
1
|
# Public API stability
|
|
2
2
|
|
|
3
|
+
## Interview-stage project opening
|
|
4
|
+
|
|
5
|
+
The additional CLI form is:
|
|
6
|
+
|
|
7
|
+
```sh
|
|
8
|
+
rig-review open /path/to/project --project /path/to/project --picks-dir scratch/review-picks
|
|
9
|
+
```
|
|
10
|
+
|
|
11
|
+
Both root operands must resolve to the same Create project. The picks directory
|
|
12
|
+
must already exist, be project-relative and be disjoint from declared inputs.
|
|
13
|
+
Omitting both selectors is supported only at `stage: "interview"` without a
|
|
14
|
+
recorded draft or a non-null `versions[].review_package`. Demo/build versions
|
|
15
|
+
without a review package are allowed. Unrelated files under `derived/` do not
|
|
16
|
+
select or manufacture a review package. Explicit `--project-version` and
|
|
17
|
+
`--project-draft` retain their strict package joins and never fall back here.
|
|
18
|
+
This form is single-target and accepts no additional inspection options;
|
|
19
|
+
`feedback` and `control` keep their existing selector requirements.
|
|
20
|
+
|
|
21
|
+
The existing single-entry workspace opens the interview in its existing modal.
|
|
22
|
+
Its internal `/api/review` transport uses `subject: "interview"`, an actual
|
|
23
|
+
`project.json` path/hash, source hash, label and availability flags. It carries
|
|
24
|
+
no manifest, compiled model, reviewed-package identity or package session.
|
|
25
|
+
Model-dependent APIs refuse `MODEL_UNAVAILABLE`. Project, retained option sets
|
|
26
|
+
and declared inputs are hash-bound and rechecked; drift refuses
|
|
27
|
+
`INTERVIEW_OPTIONS_STALE`. Opening and reading change no source files.
|
|
28
|
+
The joined dialog and standing record form use one shared list | image | survey
|
|
29
|
+
answer builder. There is no interview Note input. Existing saved or historical
|
|
30
|
+
notes remain readable as read-only text and are carried unchanged. Joined picks
|
|
31
|
+
omit `note` when none exists; the job act retains its required string field.
|
|
32
|
+
Historical records, picks/act/verdict schemas and explicit
|
|
33
|
+
version/draft joins retain their existing readers and checks. This introduces
|
|
34
|
+
no job API, act schema, consumer contract or package-export change; it does not
|
|
35
|
+
replace the active standing review cycle with a picks-file handoff.
|
|
36
|
+
|
|
3
37
|
## Managed owner host
|
|
4
38
|
|
|
5
39
|
`@rig-c/review/job-host` is the installed Bun entry for the full standing owner
|
|
@@ -112,7 +146,6 @@ interface JobPublishedContext {
|
|
|
112
146
|
readonly selector: JobSelector | null;
|
|
113
147
|
readonly plan: JobPlanIdentity | null;
|
|
114
148
|
readonly parts: JobPartsIdentity | null;
|
|
115
|
-
readonly imageSet?: JobImageSetInput;
|
|
116
149
|
readonly subjects: readonly JobSubject[];
|
|
117
150
|
readonly partIds: readonly string[];
|
|
118
151
|
readonly files: readonly JobFileIdentity[];
|
|
@@ -306,8 +339,7 @@ Failed or aborted reads cancel and release their readers. The server enforces a
|
|
|
306
339
|
|
|
307
340
|
After body parsing, the owner executes a synchronous acceptance section inside a
|
|
308
341
|
deferred SQLite read transaction (`db.transaction(...).deferred()`). It checks
|
|
309
|
-
published, stopped and accepting flags
|
|
310
|
-
`closing`) and request abort, verifies UI capability, active job status and full
|
|
342
|
+
published, stopped and accepting flags and request abort, verifies UI capability, active job status and full
|
|
311
343
|
binding, checks `listenerIncarnation` and captured, current and observed `{dev, ino}`
|
|
312
344
|
identities (`root`, `stateDir`, `store`, `record`) plus exact descriptor bytes,
|
|
313
345
|
rechecks accepting and abort flags, freezes `{ok: true, attachment, pid}` and
|
|
@@ -316,7 +348,7 @@ read snapshot while `sealClose` commits with `BEGIN IMMEDIATE`, acceptance and c
|
|
|
316
348
|
execute in a single serial order. A prior committed close returns HTTP 409 with
|
|
317
349
|
`reason: 'closed'` and `phase: 'acceptance'`. A concurrent close waits for the read
|
|
318
350
|
snapshot, and a close or stop after acceptance is an ordinary subsequent lifecycle
|
|
319
|
-
event.
|
|
351
|
+
event. Owner stop initiated before or during body parsing returns HTTP
|
|
320
352
|
503 with `reason: 'stopped'` and `phase: 'acceptance'`. `JobHostAttachFailure` is a
|
|
321
353
|
closed two-member union of `{code: 'JOB_HOST_ATTACH_REFUSED', reason, phase}`
|
|
322
354
|
(`reason` in `'missing' | 'closed' | 'incarnation-missing' | 'replaced' | 'read' | 'probe' | 'stopped' | 'race'`
|
|
@@ -378,200 +410,70 @@ The runtime entry starts the full owner host with retained publication routes
|
|
|
378
410
|
and shipped HTML, JavaScript and CSS. Raw Requests and the existing A/B ports
|
|
379
411
|
preserve capability, origin, size, cancellation and replay checks.
|
|
380
412
|
|
|
381
|
-
##
|
|
382
|
-
|
|
383
|
-
`startJobHub` adds an embedded N-job owner to the same public
|
|
384
|
-
`@rig-c/review/job-host` facade. One host process owns one loopback listener and
|
|
385
|
-
one human owner list at `ownerUrl`. Each `openJob` registers its trusted hooks
|
|
386
|
-
in that process and returns the existing session and semantic ports. The jobs
|
|
387
|
-
use `rig-review/job-api@2` and `rig-review/act@2`.
|
|
388
|
-
|
|
389
|
-
```ts
|
|
390
|
-
import {startJobHub} from '@rig-c/review/job-host';
|
|
391
|
-
import type {
|
|
392
|
-
JobHubOptions, JobHubJobOptions, JobHubJob, JobOwnerHub,
|
|
393
|
-
JobHostReuseExpectation,
|
|
394
|
-
} from '@rig-c/review/job-host';
|
|
395
|
-
|
|
396
|
-
function startJobHub(options: JobHubOptions): Promise<JobOwnerHub>;
|
|
397
|
-
|
|
398
|
-
interface JobHubOptions {
|
|
399
|
-
readonly stateDir: string;
|
|
400
|
-
readonly reviewer: JobReviewerBinding;
|
|
401
|
-
readonly port?: number;
|
|
402
|
-
}
|
|
403
|
-
|
|
404
|
-
type JobHubJobOptions = Omit<JobHostOptions, 'stateDir' | 'port' | 'reviewer' | 'reuseOnly'>;
|
|
405
|
-
|
|
406
|
-
interface JobHubJob {
|
|
407
|
-
readonly session: JobSession;
|
|
408
|
-
readonly ports: JobHostPorts;
|
|
409
|
-
readonly origin: string;
|
|
410
|
-
readonly jobUrl: string;
|
|
411
|
-
readonly reused: boolean;
|
|
412
|
-
readonly attachment: JobHostReuseExpectation;
|
|
413
|
-
}
|
|
414
|
-
|
|
415
|
-
interface JobOwnerHub {
|
|
416
|
-
readonly origin: string;
|
|
417
|
-
readonly ownerUrl: string;
|
|
418
|
-
openJob(options: JobHubJobOptions): Promise<JobHubJob>;
|
|
419
|
-
stop(): Promise<void>;
|
|
420
|
-
}
|
|
421
|
-
```
|
|
422
|
-
|
|
423
|
-
`stateDir` stays outside every registered work root. `port` accepts 0..65535 and
|
|
424
|
-
defaults to an available port. The bootstrap `reviewer` is common to every job,
|
|
425
|
-
with the same trusted provenance and role checks as `startJobHost`. A retained
|
|
426
|
-
active job with a different reviewer refuses `JOB_AUTHORITY_REFUSED`.
|
|
427
|
-
`ownerUrl` has the form `/hub/?workspace=<incarnation>#cap=<private-capability>`.
|
|
428
|
-
`jobUrl` is the per-job owner URL, including its private UI capability.
|
|
429
|
-
The human receives the hub owner URL once. Agents receive their own per-job
|
|
430
|
-
bootstrap credentials privately and address `/jobs/<jobId>/api`.
|
|
431
|
-
|
|
432
|
-
Each `startJobHub` listener start mints one canonical lowercase UUIDv4
|
|
433
|
-
`listenerIncarnation` shared across all jobs registered on that hub. Opening
|
|
434
|
-
additional jobs on the same hub preserves that incarnation. Each `openJob` call
|
|
435
|
-
returns a required non-null detached deeply frozen `job.attachment: JobHostReuseExpectation`
|
|
436
|
-
derived directly from the owning hub context, including when a compact on-disk
|
|
437
|
-
`job-ui/<jobId>.json` descriptor omits `listenerIncarnation` at the 65,536-byte
|
|
438
|
-
limit. Passing a runtime `reuseOnly` property to `hub.openJob` rejects with
|
|
439
|
-
`JOB_REQUEST_INVALID`.
|
|
440
|
-
|
|
441
|
-
Each job keeps its own identity, source bindings, generation CAS, idempotency
|
|
442
|
-
keys, cursors, asks, acts, display receipts and agent/UI/writer grants. Hook IDs
|
|
443
|
-
follow the existing `JobHostOptions` rules. Reopening an active root and
|
|
444
|
-
fingerprint with compatible hook identities returns the same session with
|
|
445
|
-
`reused` true and invokes the writer-binding callback again. General
|
|
446
|
-
cross-process callback registration is deferred. The hub refuses an active
|
|
447
|
-
standalone owner with `JOB_HUB_EXTERNAL_HOST`, and a live unresponsive owner
|
|
448
|
-
with `JOB_HUB_HOST_UNRESPONSIVE`, preserving that owner. A second live hub for
|
|
449
|
-
the state directory refuses `JOB_HUB_ALREADY_RUNNING`. Existing `startJobHost`
|
|
450
|
-
callers can still attach to a compatible hub-owned job by ordinary authenticated
|
|
451
|
-
reuse or strict `reuseOnly: {expected}` attachment (which skips
|
|
452
|
-
`installWriterBinding` during strict bootstrap). Such attachment keeps the
|
|
453
|
-
registered process-local hooks under hub ownership.
|
|
454
|
-
|
|
455
|
-
Semantic `close` ends only the addressed job and revokes its writer grant.
|
|
456
|
-
Closed entries remain in the current hub list. `await hub.stop()` drains work,
|
|
457
|
-
stops the shared transport and disposes local sessions. Active jobs retain their
|
|
458
|
-
durable identity, grants, publications, asks, acts and replay history across
|
|
459
|
-
that transport stop. Restart requires `startJobHub` and `openJob` for each
|
|
460
|
-
required job, registering callbacks again and refreshing the writer adapter's
|
|
461
|
-
origin. The hub capability, `listenerIncarnation` and `workspace` incarnation
|
|
462
|
-
query rotate, forcing a fresh owner document and invalidating prior strict
|
|
463
|
-
`reuseOnly` expectations. Obtain the new owner URL and `job.attachment` from the
|
|
464
|
-
new handle. The retained active job's grants keep their identity until
|
|
465
|
-
semantic close. A later new job receives new grants.
|
|
466
|
-
|
|
467
|
-
Admission is an application bound of 32 registered entries, including closed
|
|
468
|
-
entries retained in that hub incarnation. `JOB_HUB_LIMIT` refuses a new entry
|
|
469
|
-
at the bound. Compatible reuse of an active entry still succeeds. Selected
|
|
470
|
-
frames are retained lazily under this bound. Hidden hub members suspend their event subscription after bootstrap and resume from the last delivered cursor when selected. Hardware performance requires its
|
|
471
|
-
own measurement.
|
|
472
|
-
|
|
473
|
-
Consumer-owned adoption remains external and pending in
|
|
474
|
-
[Review #512](https://github.com/rig-c/review/issues/512). See the
|
|
475
|
-
[embedded consumer example](WORKFLOWS.md#embedded-semantic-jobs) for trusted-hook
|
|
476
|
-
ownership and the ordinary semantic cycle.
|
|
477
|
-
|
|
478
|
-
## Image-set verdict extension
|
|
479
|
-
|
|
480
|
-
Review #522 adds an HQ-approved image branch to `rig-review/job-api@2` and
|
|
481
|
-
`rig-review/act@2`. The original model source and value keep their exact fields
|
|
482
|
-
and serialization. Model acts carry no image discriminant, digest, duplicate
|
|
483
|
-
array or added nulls. The image branch carries `source.subject = "image-set"`
|
|
484
|
-
and omits `model` and `selector` entirely. Its ask and value use
|
|
485
|
-
`{kind: "review-verdict", stage: "image-review"}` and the existing human UI
|
|
486
|
-
verdict lifecycle. HQ exact-head dependency sign-off is required before landing.
|
|
487
|
-
The current `src/job-contract.ts` candidate SHA-256 is
|
|
488
|
-
`e7d2be222af6be6cc4718a57fbfef6de606a0c6268efc7b32b15e1bd75bcce65`.
|
|
489
|
-
The Tower records the final signed head separately.
|
|
490
|
-
|
|
491
|
-
Agents discover support through `session next <job-url> --wait-ms 0`, reading
|
|
492
|
-
`response.value.capabilities.imageSetVerdict === true`. API callers send the
|
|
493
|
-
existing `next` request with their agent bearer capability. The authenticated
|
|
494
|
-
hub `/hub/host` and owner `/hub/api/jobs` metadata also advertise that capability.
|
|
495
|
-
`JOB_CAPABILITIES` is the current immutable capability object.
|
|
496
|
-
`assertJobImageSetCapability(response.value.capabilities)` throws
|
|
497
|
-
`JOB_IMAGE_SET_UNSUPPORTED` when support is absent. Call it before asking.
|
|
498
|
-
An older installed parser refuses `image-review` with `JOB_ASK_INVALID`.
|
|
499
|
-
The preserved parser control uses its exact original function body and shared
|
|
500
|
-
current validators. It does not run an older server.
|
|
501
|
-
|
|
502
|
-
The trusted `JobPublicationReader` may return optional `imageSet` in its
|
|
503
|
-
`JobPublishedContext`. The existing callback runs only when publication supplies
|
|
504
|
-
a non-null frozen record. A Create root still requires its producer-owned reader.
|
|
505
|
-
Review defines this return value, with no new producer record format or Parts
|
|
506
|
-
adoption adapter. `result.selector` is null for image publication.
|
|
507
|
-
|
|
508
|
-
```ts
|
|
509
|
-
interface JobImageSetInput {
|
|
510
|
-
readonly purpose: 'plate-adoption';
|
|
511
|
-
readonly images: readonly {
|
|
512
|
-
readonly role: 'source' | 'candidate' | 'reference';
|
|
513
|
-
readonly name: string;
|
|
514
|
-
readonly path: string;
|
|
515
|
-
readonly sha256?: string;
|
|
516
|
-
}[];
|
|
517
|
-
}
|
|
518
|
-
function assertJobImageSetCapability(capabilities: unknown): void;
|
|
519
|
-
```
|
|
520
|
-
|
|
521
|
-
The ordered set has 2–8 rows, exactly one `source`, at least one `candidate`, and
|
|
522
|
-
optional `reference` rows. Names and paths must each be unique. Names use the
|
|
523
|
-
existing nonempty 128-unit text bound. Paths are literal job-root-relative paths
|
|
524
|
-
with the existing 4096-unit bound and regular-file, containment and symlink
|
|
525
|
-
checks. Files retain the existing 64 MiB per-file and 256 MiB total source limits.
|
|
526
|
-
Every supplied hash must match disk bytes. The daemon hashes retained inputs,
|
|
527
|
-
seals them, derives ask bindings from checked disk bytes and rechecks at finalize.
|
|
528
|
-
Equal hashes are allowed and produce ordered `source.duplicateHashes` groups of
|
|
529
|
-
`{names: string[], sha256: string}`. Groups appear by first hash occurrence and
|
|
530
|
-
names retain producer order. An empty group array is explicit on image sources.
|
|
531
|
-
|
|
532
|
-
`source.imageSet` contains required derived hashes. `source.imageSetDigest` is
|
|
533
|
-
SHA-256 over the UTF-8 bytes of the following exact JSON serialization.
|
|
534
|
-
|
|
535
|
-
```ts
|
|
536
|
-
JSON.stringify(images.map(({role, name, sha256}) => ({role, name, sha256})))
|
|
537
|
-
```
|
|
413
|
+
## Changelog
|
|
538
414
|
|
|
539
|
-
|
|
540
|
-
with no whitespace insertion or Unicode normalization. Paths are excluded from
|
|
541
|
-
this digest. The separate source hash binds the package source hash, frozen
|
|
542
|
-
record and complete image set including paths under `rig-review-job-image-set/1`.
|
|
543
|
-
Consumers can hash their designated bytes and reconstruct the ordered digest
|
|
544
|
-
without parsing Review's private files.
|
|
545
|
-
|
|
546
|
-
The image value is `{stage: "image-review", verdict, words, imageNotes?}`.
|
|
547
|
-
Optional notes are `{name, words}` rows with unique member names and exact human
|
|
548
|
-
text. Unknown fields, duplicate names and nonmember notes refuse. The UI omits
|
|
549
|
-
empty optional notes and preserves whitespace-only notes. Source hashes, digests,
|
|
550
|
-
duplicate groups and authority are daemon-owned and rejected in UI values.
|
|
551
|
-
All images decode and reach the existing painted lifecycle boundary before
|
|
552
|
-
`ackDisplayed` supplies a nonce and enables submission. Retained routes serve only
|
|
553
|
-
sealed indexed image rows. Drafts, visibility messages, replay and writer-owned
|
|
554
|
-
`fetch-act` keep their existing publication/source and capability bindings.
|
|
555
|
-
|
|
556
|
-
New named refusals are `JOB_IMAGE_SET_UNSUPPORTED`, `JOB_IMAGE_SET_INVALID`,
|
|
557
|
-
`JOB_IMAGE_SET_DUPLICATE_NAME`, `JOB_IMAGE_SET_DUPLICATE_PATH`,
|
|
558
|
-
`JOB_IMAGE_SET_ROLE_INVALID` and `JOB_IMAGE_SET_PATH_REFUSED`.
|
|
559
|
-
Disk hash mismatches use `JOB_SOURCE_MISMATCH`. A verdict ask with neither a valid
|
|
560
|
-
model binding nor a valid image-set binding uses `JOB_ASK_INVALID`.
|
|
415
|
+
- Breaking, 4.0.0 (#806): remove `startJobHub` and its `JobHubOptions`, `JobHubJobOptions`, `JobHubJob` and `JobOwnerHub` types; the uncalled semantic-job hub is deleted.
|
|
561
416
|
|
|
562
417
|
## Named export inventory
|
|
563
418
|
|
|
564
|
-
The backend rig-still extension retains the original twelve runtime exports and `JOB_ACT_SCHEMA` at act@2. `JobAct` additionally includes `JobRigReviewAct` at act@3 with top-level `JobRigStill
|
|
419
|
+
The backend rig-still extension retains the original twelve runtime exports and `JOB_ACT_SCHEMA` at act@2. `JobAct` additionally includes `JobRigReviewAct` at act@3 with top-level `JobRigStill` and `JobPartsVerdictAct` at act@5 (`PartsVerdictValue` with pointed `issues` and `words`, while preserving `JobLegacyPartsVerdictValue` at act@2 for historical acts). The facade adds type-only `JobLegacyAct`, `JobRigReviewAct`, `JobPartsVerdictAct`, `JobLegacyPartsVerdictValue`, `PartsVerdictValue`, `JobPanelComposition`, `PanelComponent`, `JobRigStill` and `JobRigCapture` exports, [Review #563](https://github.com/rig-c/review/issues/563) adds five type-only exports (`JobHostListenerIncarnation`, `JobHostReuseBinding`, `JobHostReuseExpectation`, `JobHostAttachField` and `JobHostAttachFailure`), and [Review #555](https://github.com/rig-c/review/issues/555) adds four type-only interview diagnostic exports (`JobInterviewJson`, `JobInterviewRecord`, `JobInterviewDiagnostic` and `JobInterviewDiagnostics`). [Review #588](https://github.com/rig-c/review/issues/588) activates record mode when `readRecordPublished` and `recordReaderId` are supplied to a host or session (`publicationMode: 'record-and-package'`), serving `rig-review/job-api@3` (`JOB_API_V3_SCHEMA`), `rig-review/act@4` (`JOB_RECORD_ACT_SCHEMA`) and normal owner URL model-free record inspection while keeping default package-only hosts and exact `package-only` `job-ui/<jobId>.json` descriptor bytes at @2 and enforcing `publicationMode` / `recordReaderId` reuse compatibility across ordinary reuse and strict `reuseOnly` attachment. It exports six additional record-mode runtime symbols (`JOB_API_V3_SCHEMA`, `JOB_RECORD_ACT_SCHEMA`, `JOB_RECORD_READER_ID`, `parseRecordAct`, `prepareJobRecordAct` and `prepareJobRecordSource`, for eighteen runtime exports total) and the V3/record type surface listed below. The rig and parts-verdict act revision constants, transport limits and the internal `POST /jobs/<jobId>/host` helper remain internal to their modules. Consumer checks distinguish these act revisions as described in [Rig verdict still backend](REVIEW_PACKAGE.md#rig-verdict-still-backend) and [Model-free record mode and source seam](REVIEW_PACKAGE.md#model-free-record-mode-and-source-seam).
|
|
420
|
+
|
|
421
|
+
The comments decoder extension adds six functions and four schema constants,
|
|
422
|
+
for twenty-eight runtime exports total.
|
|
423
|
+
See [Comments decoder contract](REVIEW_PACKAGE.md#comments-decoder-contract).
|
|
424
|
+
|
|
425
|
+
[Review #714](https://github.com/rig-c/review/issues/714) adds the act@7 decoder
|
|
426
|
+
`parseContextCommentsAct` and its constant `JOB_COMMENT_CONTEXT_ACT_SCHEMA`
|
|
427
|
+
(`rig-review/act@7`), for thirty runtime exports total, plus the type-only
|
|
428
|
+
`JobCommentContext`, `JobContextComment` and `JobContextCommentsAct`. The change
|
|
429
|
+
is additive: `parseCommentsAct`, `JobComment` and `JobCommentsAct` keep their @6
|
|
430
|
+
shapes, and @2–@6 decode unchanged. Review does not emit @7 until Create pins a
|
|
431
|
+
Review version that reads it. See [Comment context (act@7)](REVIEW_PACKAGE.md#comment-context-act7).
|
|
432
|
+
|
|
433
|
+
[Review #713](https://github.com/rig-c/review/issues/713) turns on the act@6
|
|
434
|
+
writers. `JobAct` widens to `JobLegacyAct | JobRigReviewAct | JobPartsVerdictAct |
|
|
435
|
+
JobCommentsAct`, so `JobActV3`, `JobEvent`, `JobEventV3`, `JobNextValue`,
|
|
436
|
+
`JobNextValueV3` and `JobHostPorts.commitUIAct` admit fresh act@6 values. No
|
|
437
|
+
export is added or removed, and `JobComment` is unchanged. Fresh UI checkpoint,
|
|
438
|
+
parts-verdict, rig and direction review-verdict and signoff acts are
|
|
439
|
+
`rig-review/act@6`. Image-review verdicts and interview picks stay at act@2, and
|
|
440
|
+
record acts stay at act@4. Consumers narrow on `schema`. A consumer's
|
|
441
|
+
`Extract<JobAct, {kind: ...}>` alias now also contains the act@6 arm of that
|
|
442
|
+
kind. This changes the type on the consumer's next pin and does not break any
|
|
443
|
+
runtime reader. Historical act@2–@5 bytes keep their readers.
|
|
444
|
+
|
|
445
|
+
[Review #746](https://github.com/rig-c/review/issues/746) adds optional
|
|
446
|
+
`feedback: readonly Feedback[]` to `JobUIActValues['review-verdict']` only when
|
|
447
|
+
`stage` is `rig-review`; `stage`, `verdict` and required `words` remain.
|
|
448
|
+
A present list, including `[]`, supplies the complete comments through the
|
|
449
|
+
existing `feedbackItemComments` mapper and act@6 decoder. It preserves entry
|
|
450
|
+
order, text, IDs, frames, target, category and `anchor.context` (including point,
|
|
451
|
+
crop, bookmark and valid time-only null-frame evidence). `words` is not appended
|
|
452
|
+
as another comment. Without `feedback`, serialized output bytes stay unchanged.
|
|
453
|
+
Direction and image submissions retain their previous closed shapes. The
|
|
454
|
+
written act stays act@6, historical words-only acts still parse, and the
|
|
455
|
+
act@7 top-level `comment.context` emission gate remains off. There are no new
|
|
456
|
+
exports or schemas. See [Comments decoder contract](REVIEW_PACKAGE.md#comments-decoder-contract).
|
|
565
457
|
|
|
566
458
|
The exact runtime exports are listed below. Constants preserve their literal
|
|
567
459
|
values from the frozen semantic contract.
|
|
568
460
|
|
|
569
461
|
- `startJobHost`
|
|
570
|
-
- `startJobHub`
|
|
571
|
-
- `assertJobImageSetCapability`
|
|
572
462
|
- `parseRecordAct`
|
|
573
463
|
- `prepareJobRecordAct`
|
|
574
464
|
- `prepareJobRecordSource`
|
|
465
|
+
- `parseCommentsAct`
|
|
466
|
+
- `parseContextCommentsAct`
|
|
467
|
+
- `projectComments`
|
|
468
|
+
- `parseCommentsSession`
|
|
469
|
+
- `parseCommentsCompareSession`
|
|
470
|
+
- `parseCommentsPartsVerdict`
|
|
471
|
+
- `projectSelectedCommentsFeedback`
|
|
472
|
+
- `JOB_COMMENTS_ACT_SCHEMA`
|
|
473
|
+
- `JOB_COMMENT_CONTEXT_ACT_SCHEMA`
|
|
474
|
+
- `REVIEW_COMMENTS_SESSION_SCHEMA`
|
|
475
|
+
- `REVIEW_COMMENTS_COMPARE_SESSION_SCHEMA`
|
|
476
|
+
- `PARTS_COMMENTS_VERDICT_SCHEMA`
|
|
575
477
|
- `JOB_CAPABILITIES`
|
|
576
478
|
- `JOB_API_SCHEMA`
|
|
577
479
|
- `JOB_API_V3_SCHEMA`
|
|
@@ -587,13 +489,9 @@ values from the frozen semantic contract.
|
|
|
587
489
|
|
|
588
490
|
The exact type-only exports follow. Their existing definitions in
|
|
589
491
|
`src/job-contract.ts`, `src/job-source.ts`, `src/job-act.ts`, `src/job-session.ts`,
|
|
590
|
-
`src/job-worker.ts
|
|
492
|
+
`src/job-worker.ts` and `src/job-front.ts` are reexported
|
|
591
493
|
without aliases or copied wire shapes.
|
|
592
494
|
|
|
593
|
-
- `JobHubOptions`
|
|
594
|
-
- `JobHubJobOptions`
|
|
595
|
-
- `JobHubJob`
|
|
596
|
-
- `JobOwnerHub`
|
|
597
495
|
- `JobHostOptions`
|
|
598
496
|
- `JobOwnerHost`
|
|
599
497
|
- `JobHostListenerIncarnation`
|
|
@@ -627,13 +525,9 @@ without aliases or copied wire shapes.
|
|
|
627
525
|
- `JobSelector`
|
|
628
526
|
- `JobSourceBinding`
|
|
629
527
|
- `JobModelSourceBinding`
|
|
630
|
-
- `JobImageSourceBinding`
|
|
631
|
-
- `JobImageSetInput`
|
|
632
|
-
- `JobImageSet`
|
|
633
528
|
- `JobCapabilities`
|
|
634
529
|
- `JobCapabilitiesV3`
|
|
635
530
|
- `JobModelReviewValue`
|
|
636
|
-
- `JobImageReviewValue`
|
|
637
531
|
- `JobReviewerBinding`
|
|
638
532
|
- `JobHumanAuthority`
|
|
639
533
|
- `JobVerdict`
|
|
@@ -641,6 +535,11 @@ without aliases or copied wire shapes.
|
|
|
641
535
|
- `JobReviewStage`
|
|
642
536
|
- `JobLegacyAct`
|
|
643
537
|
- `JobRigReviewAct`
|
|
538
|
+
- `JobPartsVerdictAct`
|
|
539
|
+
- `JobLegacyPartsVerdictValue`
|
|
540
|
+
- `PartsVerdictValue`
|
|
541
|
+
- `JobPanelComposition`
|
|
542
|
+
- `PanelComponent`
|
|
644
543
|
- `JobRigStill`
|
|
645
544
|
- `JobRigCapture`
|
|
646
545
|
- `JobActValues`
|
|
@@ -729,10 +628,23 @@ without aliases or copied wire shapes.
|
|
|
729
628
|
- `JobRetainedSource`
|
|
730
629
|
- `JobRetainedSourceV3`
|
|
731
630
|
- `JobRootIdentity`
|
|
631
|
+
- `JobComment`
|
|
632
|
+
- `JobCommentAnchor`
|
|
633
|
+
- `JobCommentFeedbackAnchor`
|
|
634
|
+
- `JobCommentPartsAnchor`
|
|
635
|
+
- `JobCommentImageAnchor`
|
|
636
|
+
- `JobCommentsAct`
|
|
637
|
+
- `JobCommentsActValues`
|
|
638
|
+
- `JobCommentContext`
|
|
639
|
+
- `JobContextComment`
|
|
640
|
+
- `JobContextCommentsAct`
|
|
641
|
+
- `ReviewCommentsSession`
|
|
642
|
+
- `CompareCommentsSession`
|
|
643
|
+
- `PartsCommentsVerdict`
|
|
732
644
|
|
|
733
645
|
## Parts enumeration boundary
|
|
734
646
|
|
|
735
|
-
C4 binds the exact public `partsFileReferences(dir)` array from `@rig-c/parts/src/parts.ts`, whose contract is frozen at Parts 2.25.0. The trusted host resolves an installed version in `JOB_PARTS_ENUMERATOR_RANGE` (`>=2.25.0 <
|
|
647
|
+
C4 binds the exact public `partsFileReferences(dir)` array from `@rig-c/parts/src/parts.ts`, whose contract is frozen at Parts 2.25.0. The trusted host resolves an installed version in `JOB_PARTS_ENUMERATOR_RANGE` (`>=2.25.0 <3.0.0`), supplies its actual version and official callback through `partsEnumerator`, and declares `partsEnumeratorId`. `JobPartsIdentity.enumeratorVersion` carries that actual version. Manifest paths are work-root-relative and image paths are relative to the manifest directory. Each image carries `path`, bounded-string `role` and raw-byte `sha256`. Review compares the claimed array positionally with the official array, preserving its role/order/duplicate semantics. Upstream roles include `part`, `alternate`, `depth`, `painting` and `figure_mask`. Review bounds shape and paths, refuses traversal/symlinks, decodes PNGs and hashes retained bytes. Missing references refuse with row, role and path, including a missing sibling figure mask when a render copy exists. Unreferenced extras stay outside this parts identity. Composite source hashes use `rig-review-job-source/2`. Create #184 production reader/projection and official-hook wiring remain pending.
|
|
736
648
|
|
|
737
649
|
The directory passed to the public callback holds the retained `parts.json` bytes. The original paths resolve from the directory holding the bound manifest. The host owns the official import and same-installation version check. A supplied version string alone does not authenticate a replaced callback. Review has no Parts runtime dependency and never installs the producer. Its dev-only 2.25.1 fixture is synthetic reference evidence. Missing or out-of-range versions name the required range and received value through `PARTS_ENUMERATOR_VERSION_MISMATCH`. A claimed version differing from the host installation also refuses.
|
|
738
650
|
|
|
@@ -741,11 +653,11 @@ Rows are capped at 4096, roles at 128 UTF-16 code units and literal paths at 409
|
|
|
741
653
|
## Installed acceptance
|
|
742
654
|
|
|
743
655
|
`bun run smoke` packs the package and installs that tarball into an empty project.
|
|
744
|
-
A consumer
|
|
656
|
+
A consumer checks the thirty runtime exports and every listed type, including
|
|
745
657
|
`JobHostListenerIncarnation`, `JobHostReuseBinding`, `JobHostReuseExpectation`,
|
|
746
658
|
`JobHostAttachField`, `JobHostAttachFailure`, `JobInterviewJson`,
|
|
747
659
|
`JobInterviewRecord`, `JobInterviewDiagnostic`, `JobInterviewDiagnostics` and
|
|
748
|
-
the record-mode `JobRecordAct` / `JobActV3` / `JobPlanSource` /
|
|
660
|
+
the comments decoder types and the record-mode `JobRecordAct` / `JobActV3` / `JobPlanSource` /
|
|
749
661
|
`JobFetchActRequestV3` / `JobRecordHostHooks` surface, through `@rig-c/review/job-host`.
|
|
750
662
|
TypeScript checks the installed consumer and the runtime checks the full owner
|
|
751
663
|
resources, retained publication, semantic ports, declared hooks, enumerator
|
|
@@ -763,3 +675,25 @@ installed manifest and requires the public import to fail for that missing
|
|
|
763
675
|
subpath. It restores the exact manifest bytes, verifies their SHA-256 and imports
|
|
764
676
|
again. The smoke prints the planned RED's raw exit and diagnostic. This control
|
|
765
677
|
runs inside the ordinary installed smoke, alongside existing CLI coverage.
|
|
678
|
+
|
|
679
|
+
## Record direction-review signoff
|
|
680
|
+
|
|
681
|
+
Record publications accept `{kind: 'signoff', stage: 'direction-review'}` through
|
|
682
|
+
the existing signoff path. Like `plan-approved`, `rigging-interview` and
|
|
683
|
+
`post-interview`, it requires a declared subject and non-empty published plan.
|
|
684
|
+
Approval binds the frozen record revision through the existing project/source
|
|
685
|
+
hashes, with no separate post-version selector or new ask/act field. Existing
|
|
686
|
+
stages, schemas and stored act bytes retain their meaning. See the
|
|
687
|
+
[record contract](REVIEW_PACKAGE.md#model-free-record-mode-and-source-seam).
|
|
688
|
+
|
|
689
|
+
The public `JOB_PLAN_BOUND_SIGNOFF_STAGES` remains the original three-entry
|
|
690
|
+
package list. The fourth stage is record-only; package `direction-review`
|
|
691
|
+
signoffs and historical comments acts still accept a nullable plan.
|
|
692
|
+
|
|
693
|
+
## Record interview signoff
|
|
694
|
+
|
|
695
|
+
Record publications also accept `{kind: 'signoff', stage: 'interview'}` through
|
|
696
|
+
the existing modal and record act shape. A declared subject and non-empty displayed
|
|
697
|
+
plan remain required. The record stage type has five members; the public package
|
|
698
|
+
plan-bound list remains at three. Package interview signoffs and historical acts
|
|
699
|
+
retain their existing nullable-plan behavior. No schema or runtime export changes.
|
package/docs/WORKFLOWS.md
CHANGED
|
@@ -281,11 +281,6 @@ options refuse with `OPEN_OPTION_INVALID`; existing single options retain their
|
|
|
281
281
|
behavior. Flags and their literal values are consumed before counting operands.
|
|
282
282
|
Core's `rigc review` continues forwarding to `open`; Review owns this grammar.
|
|
283
283
|
|
|
284
|
-
Embedded semantic jobs share one owner list through `startJobHub` and
|
|
285
|
-
`hub.openJob`. Their trusted callbacks stay in the host process. Follow
|
|
286
|
-
[Embedded semantic jobs](#embedded-semantic-jobs) and the
|
|
287
|
-
[public hub contract](STABILITY.md#embedded-semantic-job-hub).
|
|
288
|
-
|
|
289
284
|
### Launcher contract
|
|
290
285
|
|
|
291
286
|
A launcher may start `rig-review open` as a child process and rely on its stdout,
|
|
@@ -501,109 +496,7 @@ On the view you are inspecting, choose **Comment · C (n)**, drag over the detai
|
|
|
501
496
|
|
|
502
497
|
The four-stage navigator preserves this entry and its explicit save behavior. Compiled sessions reuse the atlas surface read-only; see [Four inspection stages](PANELS.md#four-inspection-stages).
|
|
503
498
|
|
|
504
|
-
The
|
|
505
|
-
|
|
506
|
-
## Embedded semantic jobs
|
|
507
|
-
|
|
508
|
-
Use **N reviews → one invocation, one owner URL** for both CLI folder inspection
|
|
509
|
-
and embedded semantic jobs. External consumer-owned adoption remains
|
|
510
|
-
pending in [Review #512](https://github.com/rig-c/review/issues/512).
|
|
511
|
-
|
|
512
|
-
In an embedded consumer, start one hub and register each job from that same
|
|
513
|
-
process. Give the human `hub.ownerUrl` and one what-to-look-at line. The hub
|
|
514
|
-
owns one PID/listener and a list that selects each job's standing Review UI.
|
|
515
|
-
The bootstrap reviewer binding applies to all registered jobs. Each job retains
|
|
516
|
-
its separate generation, source, asks, acts, replay cursor and grants under
|
|
517
|
-
job-api@2/act@2. View-only CLI folder entries retain their inspection workflow.
|
|
518
|
-
|
|
519
|
-
This minimal Bun integration uses public imports. Its `host` argument is an
|
|
520
|
-
explicit trusted-hook placeholder supplied by the consumer application. The
|
|
521
|
-
consumer implements the publication reader, imports the official installed
|
|
522
|
-
Parts enumerator, and installs the writer's private binding through its own
|
|
523
|
-
adapter. The example defines their required public types and leaves those
|
|
524
|
-
consumer-owned implementations to the host.
|
|
525
|
-
|
|
526
|
-
```ts
|
|
527
|
-
import {startJobHub} from '@rig-c/review/job-host';
|
|
528
|
-
import type {
|
|
529
|
-
JobHubJob, JobHubJobOptions, JobOwnerHub, JobReviewerBinding,
|
|
530
|
-
} from '@rig-c/review/job-host';
|
|
531
|
-
|
|
532
|
-
type TrustedHostHooks = Required<Pick<JobHubJobOptions,
|
|
533
|
-
'readPublished' | 'readerId' | 'partsEnumerator' | 'partsEnumeratorId' |
|
|
534
|
-
'installWriterBinding' | 'bindingId'>>;
|
|
535
|
-
|
|
536
|
-
async function openReviews(host: {
|
|
537
|
-
stateDir: string;
|
|
538
|
-
reviewer: JobReviewerBinding;
|
|
539
|
-
jobs: readonly {
|
|
540
|
-
root: string;
|
|
541
|
-
fingerprint: string;
|
|
542
|
-
hooks: TrustedHostHooks;
|
|
543
|
-
}[];
|
|
544
|
-
}): Promise<{hub: JobOwnerHub; jobs: JobHubJob[]}> {
|
|
545
|
-
const hub = await startJobHub({
|
|
546
|
-
stateDir: host.stateDir,
|
|
547
|
-
reviewer: host.reviewer,
|
|
548
|
-
});
|
|
549
|
-
const jobs: JobHubJob[] = [];
|
|
550
|
-
try {
|
|
551
|
-
for (const job of host.jobs) {
|
|
552
|
-
jobs.push(await hub.openJob({
|
|
553
|
-
root: job.root,
|
|
554
|
-
fingerprint: job.fingerprint,
|
|
555
|
-
...job.hooks,
|
|
556
|
-
}));
|
|
557
|
-
}
|
|
558
|
-
return {hub, jobs};
|
|
559
|
-
} catch (error) {
|
|
560
|
-
await hub.stop();
|
|
561
|
-
throw error;
|
|
562
|
-
}
|
|
563
|
-
}
|
|
564
|
-
```
|
|
565
|
-
|
|
566
|
-
The consumer calls `openReviews` once with its designated jobs and retains the
|
|
567
|
-
returned `{hub, jobs}`. Privately hand `hub.ownerUrl` to the person. `stateDir`
|
|
568
|
-
is outside all job roots. Keep the host alive until its explicit transport
|
|
569
|
-
shutdown and await `hub.stop()` then. The public types and complete lifecycle are in
|
|
570
|
-
[Public API stability](STABILITY.md#embedded-semantic-job-hub).
|
|
571
|
-
|
|
572
|
-
For each handle in the returned `jobs`, trusted bootstrap uses
|
|
573
|
-
`job.session.hostCredentials()` to
|
|
574
|
-
deliver only that job's agent credential through a private agent channel.
|
|
575
|
-
Use `<origin>/jobs/<jobId>` as the CLI job address. `jobUrl` carries an owner UI
|
|
576
|
-
capability and belongs to the owner channel. The hub's private capability
|
|
577
|
-
allows owner-list selection. Bootstrap-declared reviewer provenance is distinct
|
|
578
|
-
from authenticating the person at the keyboard.
|
|
579
|
-
|
|
580
|
-
1. Freeze the producer's designated record and result through publication
|
|
581
|
-
acknowledgment, then `publish` with the job's current generation and an
|
|
582
|
-
idempotency key.
|
|
583
|
-
2. `ask` for the exact publication and supported semantic subject. The person
|
|
584
|
-
inspects and submits in that job's Review UI.
|
|
585
|
-
3. Use `next` to replay events and their cursor. The trusted writer directly
|
|
586
|
-
uses read-only `fetch-act` with its separately installed grant to consume a
|
|
587
|
-
finalized act. Check API@2/act@2 and the exact source binding.
|
|
588
|
-
4. Use semantic `close` for that job when its cycle ends. Other jobs and the
|
|
589
|
-
owner list continue. The closed entry stays visible in the list.
|
|
590
|
-
|
|
591
|
-
Agents use the semantic commands. Supplied sources and compiled assets stay
|
|
592
|
-
immutable, and agents never construct internal Review state, human acts or
|
|
593
|
-
binding files. Trusted callbacks remain process-local. Compatible active
|
|
594
|
-
root/fingerprint registrations reuse the job after hook-ID validation. Legacy
|
|
595
|
-
`startJobHost` can attach to a matching hub-owned job. A hub registration that
|
|
596
|
-
finds an active standalone owner refuses `JOB_HUB_EXTERNAL_HOST`, while a live
|
|
597
|
-
unresponsive descriptor refuses `JOB_HUB_HOST_UNRESPONSIVE`. General
|
|
598
|
-
cross-process callback registration is deferred.
|
|
599
|
-
|
|
600
|
-
Transport stop preserves active durable jobs and their grants. After restart,
|
|
601
|
-
register every required job's callbacks again, refresh the writer binding's
|
|
602
|
-
origin, and obtain the new hub owner URL. The hub capability and `workspace`
|
|
603
|
-
incarnation query rotate. Each retained active job keeps its identity and grants
|
|
604
|
-
until explicit close. The current hub admits at most 32 entries, including
|
|
605
|
-
closed retained entries, and lazily retains selected frames. This application
|
|
606
|
-
bound has no hardware performance guarantee. Hidden hub members suspend their event subscription after bootstrap and resume from the last delivered cursor when selected.
|
|
499
|
+
The current owner workspace accepts optional, nonduplicated `workspace` (matching the host incarnation) and `lang=en|ko` queries at `/`; `/main.js` and `/styles.css` accept only an optional `?lang=en` or `?lang=ko`, while workspace API and live routes reject queries. For allowed `/instances/<key>/…` routes, it passes landing-page queries (`/` or `/index.html`) to the in-process target handler and refuses queries on other target routes. Stage navigation never changes CLI arguments or package bindings.
|
|
607
500
|
|
|
608
501
|
## Standing live job workflow
|
|
609
502
|
|
|
@@ -683,7 +576,7 @@ the source-bound result and deduplicate by `actId`.
|
|
|
683
576
|
- **Explicit producer-held freeze and explicit close.** Every `publish` request designates a root-relative `result` (`path` and `selector`, never a command) and carries an explicit producer-held freeze (`freeze.kind` set to `'producer-held'`, `holdId`, `record` as `JobFileIdentity` or `null` for a declared non-Create root) held until acknowledgment. Review validates retained bytes, detects a moved record (`JOB_RECORD_MOVED`, `JOB_RECORD_INCOMPLETE`, `JOB_FREEZE_REQUIRED`, `JOB_SOURCE_MISMATCH`, `JOB_SOURCE_UNRETAINABLE`, `JOB_ROOT_REPLACED`) and commits local generation CAS (`JOB_GENERATION_STALE`, `JOB_IDEMPOTENCY_CONFLICT`). The freeze assertion is a caller obligation rather than a lock Review can impose on independent writers. Review offers no watched-root or automatic-close guarantee, and only explicit `close` ends an active job.
|
|
684
577
|
- **Exact displayed source and retained drafts.** The daemon derives `JobSourceBinding` from validated retained bytes and the actual displayed publication (`ackDisplayed` returning a page-scoped `displayedNonce` receipt, pinned same-origin `routes` with no mutable current alias). All metadata, images, runtime assets, routes and pending form dependencies prepare before the visible swap; paint and the single `displayedNonce` acknowledgment precede retirement of the previous view, and failed preparation or acknowledgment restores the prior view and draft. Clients never supply trusted source hashes or transfer prior approval onto a new binding. When a new publication updates the displayed source or a browser tab reconnects to the same job, the window shows an explicit changed-version notice, preserves compatible camera, animation, time, repeat, part/solo, reference and panel state (flagging incompatible selections explicitly), and retains old local drafts in storage for their original source binding without rebinding onto the new publication.
|
|
685
578
|
- **Finalized acts, five enabled kinds and cursor replay.** `next` (`after` cursor and bounded abortable `waitMs` that never consumes an act) and `subscribeJob` replay complete durable `JobEvent` records (`published`, `pending`, `act`, `closed`). Only five act kinds are enabled (`interview-picks`, `checkpoint`, `parts-verdict`, `review-verdict`, `signoff`). `described-correction` (awaiting the joint [Create #182](https://github.com/rig-c/create/issues/182) context allowlist) and `mesh-edit` (awaiting the joint [Parts #1159](https://github.com/rig-c/parts/issues/1159) freeze) stay reserved and disabled (`JOB_ACT_KIND_DISABLED`).
|
|
686
|
-
- **Checkpoints, signoffs, plan steps and parts PNGs.** In `checkpoint` acts, `outcome` is `'pass'` or `'fail'` only (`'pending'` stays in the UI draft and never produces a finalized act), and required `words` is preserved verbatim as a string including empty or whitespace-only text. The browser sends `checkpointId`, `outcome` and `words` only while the daemon copies resolved `planStepId` from the validated ask, and Create derives execution stage from its authoritative step phase and order without Review stamping a stage. Only `'pass'` is eligible for Create's checkpoint sign-off writer, while `'fail'` is feedback or a named consumer refusal. In `signoff` acts, `decision` is `'approved'` only (changes requested are a verdict) with required `words` preserved verbatim including empty or whitespace-only text. A verdict, a signoff and a Create stage transition are three separate writes, and plan-bound signoff stages (`plan-approved`, `rigging-interview`, `post-interview`) require `source.plan` with exact displayed step IDs and hashes published by [Create #184](https://github.com/rig-c/create/issues/184) without Review recomputing `stepHash`. C4 binds the exact public `partsFileReferences(dir)` array from `@rig-c/parts/src/parts.ts`, whose contract is frozen at Parts 2.25.0. The trusted host resolves an installed version in `JOB_PARTS_ENUMERATOR_RANGE` (`>=2.25.0 <
|
|
579
|
+
- **Checkpoints, signoffs, plan steps and parts PNGs.** In `checkpoint` acts, `outcome` is `'pass'` or `'fail'` only (`'pending'` stays in the UI draft and never produces a finalized act), and required `words` is preserved verbatim as a string including empty or whitespace-only text. The browser sends `checkpointId`, `outcome` and `words` only while the daemon copies resolved `planStepId` from the validated ask, and Create derives execution stage from its authoritative step phase and order without Review stamping a stage. Only `'pass'` is eligible for Create's checkpoint sign-off writer, while `'fail'` is feedback or a named consumer refusal. In `signoff` acts, `decision` is `'approved'` only (changes requested are a verdict) with required `words` preserved verbatim including empty or whitespace-only text. A verdict, a signoff and a Create stage transition are three separate writes, and plan-bound signoff stages (`plan-approved`, `rigging-interview`, `post-interview`) require `source.plan` with exact displayed step IDs and hashes published by [Create #184](https://github.com/rig-c/create/issues/184) without Review recomputing `stepHash`. C4 binds the exact public `partsFileReferences(dir)` array from `@rig-c/parts/src/parts.ts`, whose contract is frozen at Parts 2.25.0. The trusted host resolves an installed version in `JOB_PARTS_ENUMERATOR_RANGE` (`>=2.25.0 <3.0.0`), supplies its actual version and official callback through `partsEnumerator`, and declares `partsEnumeratorId`. `JobPartsIdentity.enumeratorVersion` carries that actual version. Manifest paths are work-root-relative and image paths are relative to the manifest directory. Each image carries `path`, bounded-string `role` and raw-byte `sha256`. Review compares the claimed array positionally with the official array, preserving its role/order/duplicate semantics. Upstream roles include `part`, `alternate`, `depth`, `painting` and `figure_mask`. Review bounds shape and paths, refuses traversal/symlinks, decodes PNGs and hashes retained bytes. Missing references refuse with row, role and path, including a missing sibling figure mask when a render copy exists. Unreferenced extras stay outside this parts identity. Composite source hashes use `rig-review-job-source/2`. Create #184 production reader/projection and official-hook wiring remain pending.
|
|
687
580
|
- **No agent file carriage, writer-owned sibling fetch and public host seam.** Agents never build, parse, reshape or carry Review session, picks, verdict or applied-record storage files. [Create #182](https://github.com/rig-c/create/issues/182) and [Create #184](https://github.com/rig-c/create/issues/184) own direct writer publication and act fetch through a private writer-owned sibling binding outside `project.json` (`writer-owned-sibling-fetch-capability`, pending Create #184 production reader/writer integration). That binding is never tracked in version control or unstaged project output, dies at explicit `close` with a new grant per job incarnation, and grants read-only `fetch-act` over loopback with `Authorization`. In the public managed-host startup seam (`startJobHost` from `@rig-c/review/job-host`, frozen in [Public API stability](STABILITY.md#managed-owner-host)), hook-bearing host callers declare `readerId` for `readPublished` and `bindingId` for `installWriterBinding` and `partsEnumeratorId` for `partsEnumerator`; missing or invalid IDs refuse with `JOB_HOST_OPTION_ID_INVALID`, and listener reuse requires equal `readerId`, `bindingId` and `partsEnumeratorId` or refuses with `JOB_HOST_REUSE_MISMATCH` (with no function hashes). Future mesh-edit consumption is owned by [Parts #1159](https://github.com/rig-c/parts/issues/1159), where Create fetches a finalized mesh act and passes its typed value in process to Parts' public exported API without Parts reading Review or Create storage.
|
|
688
581
|
- **Direction metadata vs playback.** Direction carriage in `#484` is metadata-only (`source.direction` and `direction-review`) and is distinct from [Review #482](https://github.com/rig-c/review/issues/482) preview and [Review #483](https://github.com/rig-c/review/issues/483) actual plated take playback, while [Review #373](https://github.com/rig-c/review/issues/373) stays parked.
|
|
689
582
|
|
|
@@ -715,6 +608,38 @@ to the joined command. The post must explicitly name the selected
|
|
|
715
608
|
printed feedback command, including the project, rig, post and picks arguments,
|
|
716
609
|
to export from that session.
|
|
717
610
|
|
|
611
|
+
### Open an interview before a draft or review package exists
|
|
612
|
+
|
|
613
|
+
Create the dedicated picks output directory first, then open the same project
|
|
614
|
+
root in both operand positions:
|
|
615
|
+
|
|
616
|
+
```sh
|
|
617
|
+
mkdir -p /path/to/project/scratch/review-picks
|
|
618
|
+
rig-review open /path/to/project \
|
|
619
|
+
--project /path/to/project --picks-dir scratch/review-picks
|
|
620
|
+
```
|
|
621
|
+
|
|
622
|
+
This form is limited to the interview stage with no recorded draft and no
|
|
623
|
+
non-null `versions[].review_package`. Versions containing only demo/build
|
|
624
|
+
records are permitted, as is unrelated derived evidence. A `derived/` directory
|
|
625
|
+
is not required. Explicit version/draft selectors never fall back to this form.
|
|
626
|
+
Both roots must resolve to the same project; the dedicated picks directory must
|
|
627
|
+
exist and not overlap an input. Other inspection flags and multiple targets
|
|
628
|
+
are refused for this form. `feedback` and `control` retain their existing syntax.
|
|
629
|
+
|
|
630
|
+
The interview opens and closes as a modal over the existing Review workspace.
|
|
631
|
+
The workspace reports model-dependent sections as `MODEL_UNAVAILABLE` and
|
|
632
|
+
creates no model, review package or package session. Reads preserve project and
|
|
633
|
+
input bytes. Changed project, option or source bytes require reopening, with
|
|
634
|
+
`INTERVIEW_OPTIONS_STALE`. Interview choices and inline Other text use the same list | image | survey
|
|
635
|
+
answer builder as the standing record dialog. There is no interview Note input;
|
|
636
|
+
existing saved or historical notes remain readable as read-only text and are
|
|
637
|
+
carried unchanged. Joined picks omit `note` when absent; job acts retain their
|
|
638
|
+
required string field. Historical records remain readable and the
|
|
639
|
+
picks-file schema is unchanged. The active standing live-job cycle above
|
|
640
|
+
still uses semantic acts and the trusted consumer; this inspection form does
|
|
641
|
+
not authorize an agent to manufacture or carry picks files.
|
|
642
|
+
|
|
718
643
|
### Open a recorded draft before rig review
|
|
719
644
|
|
|
720
645
|
In the active standing live-job cycle ([Standing live job workflow](#standing-live-job-workflow), [Create #182](https://github.com/rig-c/create/issues/182), [Create #184](https://github.com/rig-c/create/issues/184)), draft parts and mesh verdicts are submitted as `parts-verdict` acts over the semantic job API and fetched directly by the Create writer. The `--picks-dir`, `--parts-verdict-dir` and `--picks-file` commands below are preserved as legacy/history one-shot handoffs and are bypass findings if used in the active cycle.
|
|
@@ -741,15 +666,8 @@ package is unavailable. Reopen with a rig version once Create records one.
|
|
|
741
666
|
|
|
742
667
|
When the recorded draft entry includes `config`, `parts`, `rig` and `check` directories and the draft is editable (`parts` or `parts-review` stage without an effective `parts-review` sign-off, and not `--view-only`), **1 Parts + mesh** also offers the Chest regions, Mesh parameters and Edit Mesh instruments for mesh-bearing parts regardless of whether `--parts-verdict-dir` is supplied. Selecting an instrument opens the Setup inspector for that part while direct selection of **3 Rig + animation** remains refused with `RIG_VERSION_UNAVAILABLE`. Apply runs the installed producer and compiler in scratch under the existing discovery and operation-capability floors while keeping the recorded draft producer as provenance, and returning to **1 Parts + mesh** or running Undo or Reset updates the displayed mesh and report readings from the active build (verdict saving remains read-only on scratch builds and when `--parts-verdict-dir` is omitted).
|
|
743
668
|
|
|
744
|
-
|
|
745
|
-
|
|
746
|
-
|
|
747
|
-
```sh
|
|
748
|
-
mkdir -p scratch/review-picks
|
|
749
|
-
rig-review interview . --picks-dir scratch/review-picks
|
|
750
|
-
```
|
|
751
|
-
|
|
752
|
-
Open the printed loopback URL. Select a question and inspect its bound parts
|
|
669
|
+
The interview opens over the review screen of a joined workspace (the `open`
|
|
670
|
+
command above with `--picks-dir`): choose **2 Interview**. Select a question and inspect its bound parts
|
|
753
671
|
or source image. A direction set that binds only source inputs displays those
|
|
754
672
|
inputs with the no-bound-parts notice. Each recommendation shows the retained
|
|
755
673
|
reason and author/date. Choose an option for every prompt and save explicitly.
|
|
@@ -758,8 +676,11 @@ offered and picked. Auto stays pending until create has a covered agent
|
|
|
758
676
|
decision. Historical choice sets are read-only.
|
|
759
677
|
|
|
760
678
|
Each saved set has its own `<raw-set-sha256>.json` in the designated directory.
|
|
761
|
-
Reopening restores picks
|
|
762
|
-
|
|
679
|
+
Reopening restores picks for the same retained set. Existing records keep their
|
|
680
|
+
original note field byte-for-byte, displayed as read-only text. The survey has
|
|
681
|
+
no Note input. A saved note takes precedence over a historical note, including
|
|
682
|
+
an empty saved string; when neither exists, the picks record omits `note`.
|
|
683
|
+
A new set starts without selections. The directory must exist inside the project and be
|
|
763
684
|
separate from every bound input. A stale context, forged selection or
|
|
764
685
|
superseded set is refused. Review writes only `rig-review/interview-picks@1`
|
|
765
686
|
files. To ingest a file, run create separately from the project root:
|