rig-review 3.7.0 → 4.0.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (109) hide show
  1. package/README.md +3 -3
  2. package/docs/DESIGN.md +145 -74
  3. package/docs/PANELS.md +20 -12
  4. package/docs/PARTS_VIEW.md +133 -76
  5. package/docs/REVIEW_PACKAGE.md +446 -100
  6. package/docs/STABILITY.md +132 -198
  7. package/docs/WORKFLOWS.md +41 -120
  8. package/package.json +4 -3
  9. package/skills/rig-review/SKILL.md +41 -27
  10. package/src/build.ts +10 -2
  11. package/src/cli.ts +17 -16
  12. package/src/comment-crops.ts +6 -1
  13. package/src/compare-html.ts +22 -24
  14. package/src/compare-server.ts +1 -1
  15. package/src/compare-session.ts +41 -3
  16. package/src/correction-handoff.ts +27 -4
  17. package/src/create-pin-gate.ts +3 -0
  18. package/src/direction-inspection.ts +6 -2
  19. package/src/feedback-export.ts +68 -1
  20. package/src/front.ts +5 -200
  21. package/src/handoff.ts +1 -1
  22. package/src/interview-routes.ts +1 -1
  23. package/src/interview-scene.ts +3 -3
  24. package/src/job-act.ts +77 -73
  25. package/src/job-api.ts +326 -13
  26. package/src/job-checkpoint-evidence.ts +113 -0
  27. package/src/job-cli.ts +27 -14
  28. package/src/job-contract.ts +284 -62
  29. package/src/job-front.ts +192 -61
  30. package/src/job-host.ts +23 -4
  31. package/src/job-session.ts +109 -24
  32. package/src/job-source.ts +227 -58
  33. package/src/job-store.ts +80 -6
  34. package/src/job-worker.ts +1 -47
  35. package/src/joined-project.ts +61 -4
  36. package/src/manifest.ts +32 -4
  37. package/src/open-workspace.ts +12 -12
  38. package/src/open.ts +19 -12
  39. package/src/parts-comment-crops.ts +126 -31
  40. package/src/parts-comment.ts +351 -28
  41. package/src/parts-server.ts +19 -7
  42. package/src/parts-view.ts +588 -109
  43. package/src/scene-inspection.ts +50 -0
  44. package/src/server.ts +31 -22
  45. package/src/session.ts +58 -0
  46. package/src/stage-comment.ts +48 -1
  47. package/src/stage-parts.ts +23 -11
  48. package/web/animation-inspection.ts +1 -1
  49. package/web/bones-panel.ts +1 -3
  50. package/web/catalog-en.ts +175 -39
  51. package/web/catalog-ko.ts +175 -39
  52. package/web/cloth-panel.ts +1 -2
  53. package/web/compare.css +3 -13
  54. package/web/compare.html +3 -3
  55. package/web/compare.ts +69 -64
  56. package/web/cuts-panel.ts +1 -3
  57. package/web/density-strip-panel.ts +1 -2
  58. package/web/direction-panel.ts +22 -6
  59. package/web/i18n.ts +13 -1
  60. package/web/idle-panel.ts +1 -2
  61. package/web/index.html +1 -5
  62. package/web/inspection-persistence.ts +2 -1
  63. package/web/inspector-blocks.ts +149 -40
  64. package/web/instance-access.ts +24 -5
  65. package/web/interview-panel.ts +224 -175
  66. package/web/job-rig-capture.ts +164 -21
  67. package/web/job-rig-screen.ts +344 -0
  68. package/web/job-session.ts +611 -1443
  69. package/web/main.ts +614 -151
  70. package/web/mesh-panel.ts +1 -2
  71. package/web/owner-workspace.ts +88 -109
  72. package/web/part-selection.ts +47 -6
  73. package/web/part-thumbnails.ts +20 -6
  74. package/web/parts-render.ts +26 -19
  75. package/web/parts-viewport-provider.ts +181 -7
  76. package/web/physics-panel.ts +1 -2
  77. package/web/readings-panel.ts +1 -2
  78. package/web/requirements-panel.ts +1 -3
  79. package/web/retained-frame-stage.ts +105 -0
  80. package/web/retarget-panel.ts +2 -3
  81. package/web/rig-fields-panel.ts +1 -2
  82. package/web/rig-host.ts +64 -0
  83. package/web/rig-viewport-provider.ts +65 -16
  84. package/web/scene-plates.ts +57 -4
  85. package/web/stage-comments.ts +103 -46
  86. package/web/styles.css +117 -63
  87. package/web/view-controls.ts +201 -12
  88. package/web/viewport-capture.ts +12 -2
  89. package/web/viewport-controller.ts +107 -27
  90. package/web/viewport-pair.ts +2 -1
  91. package/web/workspace-preferences.ts +5 -4
  92. package/web/workspace-ui.ts +151 -19
  93. package/src/front-worker.ts +0 -2
  94. package/src/interview-server.ts +0 -54
  95. package/src/job-hub.ts +0 -304
  96. package/src/job-image-set.ts +0 -50
  97. package/web/interview.css +0 -28
  98. package/web/interview.html +0 -17
  99. package/web/interview.ts +0 -40
  100. package/web/job-hub.css +0 -14
  101. package/web/job-hub.html +0 -5
  102. package/web/job-hub.ts +0 -179
  103. package/web/owner-workspace.css +0 -14
  104. package/web/owner-workspace.html +0 -5
  105. package/web/parts-flags.ts +0 -48
  106. package/web/parts.css +0 -104
  107. package/web/parts.html +0 -49
  108. package/web/parts.ts +0 -604
  109. package/web/stage-nav.ts +0 -136
@@ -1,33 +1,356 @@
1
1
  /** Closed parts evidence. No synthetic model, frame, slot or package identity. */
2
- import {parsePartsComparison,type PartsComparison} from './parts-comparison.ts';
3
- import type {MarkRegion} from './stage-comment.ts';
4
- export interface PartsCrop {path:string;sha256:string;width:number;height:number}
2
+ import { parsePartsComparison, type PartsComparison } from './parts-comparison.ts';
3
+ import type { MarkRegion } from './stage-comment.ts';
4
+ import type { JobCommentPartsAnchor, JobComment } from './job-contract.ts';
5
+
6
+ export const PARTS_COMMENT_SCHEMA = 'rig-review-parts-comment/1' as const;
7
+ export const PARTS_ISSUE_SCHEMA = 'rig-review-parts-comment/2' as const;
8
+
9
+ export interface PartsCrop {
10
+ path: string;
11
+ sha256: string;
12
+ width: number;
13
+ height: number;
14
+ }
15
+
5
16
  export interface PartsComment {
6
- schema:'rig-review-parts-comment/1';id:string;summary:string;part:string;imageHash:string;sourceHash:string;
7
- imageRegion:MarkRegion;rigRegion:MarkRegion;
8
- view:{camera:{zoom:number;center:{x:number;y:number};viewport:{width:number;height:number}};cameraSync:boolean;referenceCamera:{zoom:number;center:{x:number;y:number};viewport:{width:number;height:number}}|null;background:string;alpha:boolean;footprints:boolean;mesh:boolean;comparison?:PartsComparison};
9
- crop:PartsCrop&{png:string};nativeCrop:PartsCrop|null;
10
- }
11
- const fail=(code:string,why:string):never=>{throw new Error(code+': '+why);};
12
- const obj=(v:unknown):Record<string,any>=>v!==null&&typeof v==='object'&&!Array.isArray(v)?v as Record<string,any>:fail('PARTS_COMMENT_INVALID','object required');
13
- const exact=(v:Record<string,any>,keys:string[])=>{if(Object.keys(v).length!==keys.length||keys.some(k=>!Object.hasOwn(v,k)))fail('PARTS_COMMENT_INVALID','unknown or missing fields');};
14
- const finite=(v:unknown):v is number=>typeof v==='number'&&Number.isFinite(v)&&Math.abs(v)<=Number.MAX_SAFE_INTEGER;
15
- const hash=(v:unknown)=>typeof v==='string'&&/^[a-f0-9]{64}$/.test(v);
16
- export function parsePartsComment(raw:unknown,prepared=true):PartsComment {
17
- const v=obj(raw);exact(v,['schema','id','summary','part','imageHash','sourceHash','imageRegion','rigRegion','view','crop','nativeCrop']);
18
- if(v.schema!=='rig-review-parts-comment/1'||typeof v.id!=='string'||!v.id||v.id.length>128||typeof v.summary!=='string'||!v.summary.trim()||v.summary.length>1000||typeof v.part!=='string'||!v.part||v.part.length>512||!hash(v.imageHash)||!hash(v.sourceHash))fail('PARTS_COMMENT_INVALID','schema, text or source binding');
19
- for(const key of ['imageRegion','rigRegion']){const r=obj(v[key]);exact(r,['x','y','width','height']);if(!Object.values(r).every(finite))fail('PARTS_COMMENT_INVALID','finite region required');if(key==='imageRegion'&&!Object.values(r).every(Number.isSafeInteger))fail('PARTS_COMMENT_FRACTIONAL','image coordinates must be integer pixels');if(r.width<=0||r.height<=0)fail('PARTS_COMMENT_EMPTY','positive region required');}
20
- const view=obj(v.view);exact(view,['camera','cameraSync','referenceCamera','background','alpha','footprints','mesh',...(Object.hasOwn(view,'comparison')?['comparison']:[])]);if(Object.hasOwn(view,'comparison'))parsePartsComparison(view.comparison);if(!['green','magenta','black','white','checker'].includes(view.background)||![view.alpha,view.footprints,view.mesh,view.cameraSync].every(n=>typeof n==='boolean'))fail('PARTS_COMMENT_INVALID','view state');
21
- for(const rawCamera of [view.camera,...(view.referenceCamera===null?[]:[view.referenceCamera])]){const c=obj(rawCamera);exact(c,['zoom','center','viewport']);exact(obj(c.center),['x','y']);exact(obj(c.viewport),['width','height']);if(!finite(c.zoom)||c.zoom<=0||c.zoom>16||!Object.values(c.center).every(finite)||!Object.values(c.viewport).every(n=>finite(n)&&n>0&&n<=65536))fail('PARTS_CAMERA_RANGE','native scale or camera extent');}
22
- for(const [crop,inline]of [[v.crop,true],[v.nativeCrop,false]] as const){if(crop===null&&!inline&&!prepared)continue;const p=obj(crop);exact(p,['path','sha256','width','height',...(inline?['png']:[])]);if(!hash(p.sha256)||p.path!==`comment-crops/${p.sha256}.png`||![p.width,p.height].every(n=>Number.isSafeInteger(n)&&n>0&&n<=16384)||inline&&(typeof p.png!=='string'||p.png.length>200000||p.width>1024||p.height>1024))fail('PARTS_COMMENT_CROP_INVALID','bounded content-addressed crop');}
23
- return v as PartsComment;
17
+ schema: typeof PARTS_COMMENT_SCHEMA;
18
+ id: string;
19
+ summary: string;
20
+ part: string;
21
+ imageHash: string;
22
+ sourceHash: string;
23
+ imageRegion: MarkRegion;
24
+ rigRegion: MarkRegion;
25
+ view: {
26
+ camera: { zoom: number; center: { x: number; y: number }; viewport: { width: number; height: number } };
27
+ cameraSync: boolean;
28
+ referenceCamera: { zoom: number; center: { x: number; y: number }; viewport: { width: number; height: number } } | null;
29
+ background: string;
30
+ alpha: boolean;
31
+ footprints: boolean;
32
+ mesh: boolean;
33
+ comparison?: PartsComparison;
34
+ };
35
+ crop: PartsCrop & { png: string };
36
+ nativeCrop: PartsCrop | null;
37
+ }
38
+
39
+ export interface PartsIssue {
40
+ schema: typeof PARTS_ISSUE_SCHEMA;
41
+ id: string;
42
+ summary: string;
43
+ parts: { name: string; imageHash: string }[];
44
+ sourceHash: string;
45
+ rigRegion: MarkRegion;
46
+ imageRegion: MarkRegion | null;
47
+ view: PartsComment['view'] & { mode: 'item' | 'assembled'; visibleLayers?: { name: string; imageHash: string }[] };
48
+ crop: PartsCrop & { png?: string };
49
+ nativeCrop: PartsCrop | null;
50
+ }
51
+
52
+ const fail = (code: string, why: string): never => {
53
+ throw new Error(code + ': ' + why);
54
+ };
55
+
56
+ const obj = (v: unknown): Record<string, any> =>
57
+ v !== null && typeof v === 'object' && !Array.isArray(v)
58
+ ? (v as Record<string, any>)
59
+ : fail('PARTS_COMMENT_INVALID', 'object required');
60
+
61
+ const exact = (v: Record<string, any>, keys: string[]) => {
62
+ if (Object.keys(v).length !== keys.length || keys.some(k => !Object.hasOwn(v, k))) {
63
+ fail('PARTS_COMMENT_INVALID', 'unknown or missing fields');
64
+ }
65
+ };
66
+
67
+ const finite = (v: unknown): v is number =>
68
+ typeof v === 'number' && Number.isFinite(v) && Math.abs(v) <= Number.MAX_SAFE_INTEGER;
69
+
70
+ const hash = (v: unknown) => typeof v === 'string' && /^[a-f0-9]{64}$/.test(v);
71
+
72
+ const token = (v: unknown): v is string =>
73
+ typeof v === 'string' && /^[A-Za-z0-9][A-Za-z0-9._-]{0,127}$/.test(v);
74
+
75
+ function parseRegion(raw: unknown, integer = false): void {
76
+ const r = obj(raw);
77
+ exact(r, ['x', 'y', 'width', 'height']);
78
+ if (!Object.values(r).every(finite)) {
79
+ fail('PARTS_COMMENT_INVALID', 'finite region required');
80
+ }
81
+ if (integer && !Object.values(r).every(Number.isSafeInteger)) {
82
+ fail('PARTS_COMMENT_FRACTIONAL', 'image coordinates must be integer pixels');
83
+ }
84
+ if (r.width <= 0 || r.height <= 0) {
85
+ fail('PARTS_COMMENT_EMPTY', 'positive region required');
86
+ }
87
+ }
88
+
89
+ function parseView(raw: unknown, withMode: boolean): Record<string, any> {
90
+ const view = obj(raw);
91
+ exact(view, [
92
+ ...(withMode ? ['mode'] : []),
93
+ 'camera',
94
+ 'cameraSync',
95
+ 'referenceCamera',
96
+ 'background',
97
+ 'alpha',
98
+ 'footprints',
99
+ 'mesh',
100
+ ...(Object.hasOwn(view, 'comparison') ? ['comparison'] : []),
101
+ ...(withMode && Object.hasOwn(view, 'visibleLayers') ? ['visibleLayers'] : []),
102
+ ]);
103
+ if (withMode && view.mode !== 'item' && view.mode !== 'assembled') {
104
+ fail('PARTS_COMMENT_INVALID', 'view mode');
105
+ }
106
+ if (Object.hasOwn(view, 'visibleLayers')) {
107
+ if (!withMode || view.mode !== 'assembled' || !Array.isArray(view.visibleLayers) || view.visibleLayers.length > 1000) {
108
+ fail('PARTS_COMMENT_INVALID', 'assembled visible layers required');
109
+ }
110
+ const seen = new Set<string>();
111
+ for (const rawLayer of view.visibleLayers) {
112
+ const layer = obj(rawLayer);
113
+ exact(layer, ['name', 'imageHash']);
114
+ if (!token(layer.name) || !hash(layer.imageHash) || seen.has(layer.name)) fail('PARTS_COMMENT_INVALID', 'visible layer binding');
115
+ seen.add(layer.name);
116
+ }
117
+ }
118
+ if (Object.hasOwn(view, 'comparison')) {
119
+ parsePartsComparison(view.comparison);
120
+ }
121
+ if (
122
+ !['green', 'magenta', 'black', 'white', 'checker'].includes(view.background) ||
123
+ ![view.alpha, view.footprints, view.mesh, view.cameraSync].every(n => typeof n === 'boolean')
124
+ ) {
125
+ fail('PARTS_COMMENT_INVALID', 'view state');
126
+ }
127
+ for (const rawCamera of [view.camera, ...(view.referenceCamera === null ? [] : [view.referenceCamera])]) {
128
+ const c = obj(rawCamera);
129
+ exact(c, ['zoom', 'center', 'viewport']);
130
+ exact(obj(c.center), ['x', 'y']);
131
+ exact(obj(c.viewport), ['width', 'height']);
132
+ if (
133
+ !finite(c.zoom) ||
134
+ c.zoom <= 0 ||
135
+ c.zoom > 16 ||
136
+ !Object.values(c.center).every(finite) ||
137
+ !Object.values(c.viewport).every(n => finite(n) && n > 0 && n <= 65536)
138
+ ) {
139
+ fail('PARTS_CAMERA_RANGE', 'native scale or camera extent');
140
+ }
141
+ }
142
+ return view;
143
+ }
144
+
145
+ function parseCrop(crop: unknown, inline: boolean, requireInline = true): void {
146
+ const p = obj(crop);
147
+ const hasPng = inline && Object.hasOwn(p, 'png');
148
+ if (inline && requireInline && !hasPng) {
149
+ fail('PARTS_COMMENT_INVALID', 'unknown or missing fields');
150
+ }
151
+ exact(p, ['path', 'sha256', 'width', 'height', ...(hasPng ? ['png'] : [])]);
152
+ if (
153
+ !hash(p.sha256) ||
154
+ p.path !== `comment-crops/${p.sha256}.png` ||
155
+ ![p.width, p.height].every(n => Number.isSafeInteger(n) && n > 0 && n <= 16384) ||
156
+ (hasPng && (typeof p.png !== 'string' || p.png.length > 200000 || p.width > 1024 || p.height > 1024))
157
+ ) {
158
+ fail('PARTS_COMMENT_CROP_INVALID', 'bounded content-addressed crop');
159
+ }
160
+ }
161
+
162
+ export function parsePartsComment(raw: unknown, prepared = true): PartsComment {
163
+ const v = obj(raw);
164
+ exact(v, ['schema', 'id', 'summary', 'part', 'imageHash', 'sourceHash', 'imageRegion', 'rigRegion', 'view', 'crop', 'nativeCrop']);
165
+ if (
166
+ v.schema !== PARTS_COMMENT_SCHEMA ||
167
+ typeof v.id !== 'string' ||
168
+ !v.id ||
169
+ v.id.length > 128 ||
170
+ typeof v.summary !== 'string' ||
171
+ !v.summary.trim() ||
172
+ v.summary.length > 1000 ||
173
+ typeof v.part !== 'string' ||
174
+ !v.part ||
175
+ v.part.length > 512 ||
176
+ !hash(v.imageHash) ||
177
+ !hash(v.sourceHash)
178
+ ) {
179
+ fail('PARTS_COMMENT_INVALID', 'schema, text or source binding');
180
+ }
181
+ parseRegion(v.imageRegion, true);
182
+ parseRegion(v.rigRegion, false);
183
+ parseView(v.view, false);
184
+ parseCrop(v.crop, true);
185
+ if (v.nativeCrop !== null || prepared) {
186
+ parseCrop(v.nativeCrop, false);
187
+ }
188
+ return v as PartsComment;
24
189
  }
190
+
191
+ export function parsePartsIssue(raw: unknown, prepared = true, allowLegacy = false, requireInlinePng = true): PartsIssue {
192
+ const v = obj(raw);
193
+ if (allowLegacy && v.schema === PARTS_COMMENT_SCHEMA) {
194
+ const c = parsePartsComment(raw, prepared);
195
+ return {
196
+ schema: PARTS_ISSUE_SCHEMA,
197
+ id: c.id,
198
+ summary: c.summary,
199
+ parts: [{ name: c.part, imageHash: c.imageHash }],
200
+ sourceHash: c.sourceHash,
201
+ rigRegion: c.rigRegion,
202
+ imageRegion: c.imageRegion,
203
+ view: { ...c.view, mode: 'item' },
204
+ crop: c.crop,
205
+ nativeCrop: c.nativeCrop,
206
+ };
207
+ }
208
+ exact(v, ['schema', 'id', 'summary', 'parts', 'sourceHash', 'imageRegion', 'rigRegion', 'view', 'crop', 'nativeCrop']);
209
+ if (
210
+ v.schema !== PARTS_ISSUE_SCHEMA ||
211
+ !token(v.id) ||
212
+ typeof v.summary !== 'string' ||
213
+ !v.summary.trim() ||
214
+ v.summary.length > 1000 ||
215
+ !hash(v.sourceHash) ||
216
+ !Array.isArray(v.parts) ||
217
+ v.parts.length < 1 ||
218
+ v.parts.length > 1000
219
+ ) {
220
+ fail('PARTS_COMMENT_INVALID', 'schema, text or source binding');
221
+ }
222
+ const seen = new Set<string>();
223
+ for (const entry of v.parts) {
224
+ const p = obj(entry);
225
+ exact(p, ['name', 'imageHash']);
226
+ if (!token(p.name) || seen.has(p.name) || !hash(p.imageHash)) {
227
+ fail('PARTS_COMMENT_INVALID', 'part binding');
228
+ }
229
+ seen.add(p.name);
230
+ }
231
+ const view = parseView(v.view, true);
232
+ if (view.mode === 'item') {
233
+ if (v.parts.length !== 1 || v.imageRegion === null) {
234
+ fail('PARTS_COMMENT_INVALID', 'item view requires a single part and imageRegion');
235
+ }
236
+ parseRegion(v.imageRegion, true);
237
+ parseRegion(v.rigRegion, false);
238
+ if (v.nativeCrop !== null || prepared) {
239
+ parseCrop(v.nativeCrop, false);
240
+ }
241
+ } else {
242
+ if (v.imageRegion !== null) {
243
+ fail('PARTS_COMMENT_INVALID', 'assembled view requires null imageRegion');
244
+ }
245
+ parseRegion(v.rigRegion, true);
246
+ if (v.nativeCrop !== null) {
247
+ fail('PARTS_COMMENT_CROP_INVALID', 'assembled view requires null nativeCrop');
248
+ }
249
+ }
250
+ parseCrop(v.crop, true, requireInlinePng);
251
+ return v as PartsIssue;
252
+ }
253
+
25
254
  /** Drag edges snap outward to whole native pixels. OOB is refused by the binding check, never clipped. */
26
- export function snapImageRegion(r:MarkRegion):MarkRegion {if(r.width<=0||r.height<=0)return {x:Math.floor(r.x),y:Math.floor(r.y),width:0,height:0};const x=Math.floor(r.x),y=Math.floor(r.y);return {x,y,width:Math.ceil(r.x+r.width)-x,height:Math.ceil(r.y+r.height)-y};}
27
- export function assertPartsCommentBinding(c:PartsComment,item:{name:string;x:number;y:number;w:number;h:number},imageHash:string,sourceHash:string):void {
28
- if(c.part!==item.name)fail('PARTS_COMMENT_PART_MISMATCH','comment belongs to another part');
29
- if(c.imageHash!==imageHash||c.sourceHash!==sourceHash)fail('PARTS_COMMENT_STALE_SOURCE','original image or package source hash differs');
30
- const camera=c.view.camera,fit=Math.max(.001,Math.min((camera.viewport.width-24)/item.w,(camera.viewport.height-24)/item.h));if(camera.zoom<Math.min(fit,1))fail('PARTS_CAMERA_RANGE','native zoom below fit/1 minimum');
31
- const r=c.imageRegion;if(r.x<0||r.y<0||r.x+r.width>item.w||r.y+r.height>item.h)fail('PARTS_COMMENT_OUT_OF_BOUNDS','region exceeds original image');
32
- if(c.rigRegion.x!==item.x+r.x||c.rigRegion.y!==item.y+r.y||c.rigRegion.width!==r.width||c.rigRegion.height!==r.height)fail('PARTS_COMMENT_RIG_REGION','rig region must be exact placement plus image region');
255
+ export function snapImageRegion(r: MarkRegion): MarkRegion {
256
+ if (r.width <= 0 || r.height <= 0) {
257
+ return { x: Math.floor(r.x), y: Math.floor(r.y), width: 0, height: 0 };
258
+ }
259
+ const x = Math.floor(r.x);
260
+ const y = Math.floor(r.y);
261
+ return { x, y, width: Math.ceil(r.x + r.width) - x, height: Math.ceil(r.y + r.height) - y };
262
+ }
263
+
264
+ export function assertPartsCommentBinding(
265
+ c: PartsComment,
266
+ item: { name: string; x: number; y: number; w: number; h: number },
267
+ imageHash: string,
268
+ sourceHash: string,
269
+ ): void {
270
+ if (c.part !== item.name) {
271
+ fail('PARTS_COMMENT_PART_MISMATCH', 'comment belongs to another part');
272
+ }
273
+ if (c.imageHash !== imageHash || c.sourceHash !== sourceHash) {
274
+ fail('PARTS_COMMENT_STALE_SOURCE', 'original image or package source hash differs');
275
+ }
276
+ const camera = c.view.camera;
277
+ const fit = Math.max(0.001, Math.min((camera.viewport.width - 24) / item.w, (camera.viewport.height - 24) / item.h));
278
+ if (camera.zoom < Math.min(fit, 1)) {
279
+ fail('PARTS_CAMERA_RANGE', 'native zoom below fit/1 minimum');
280
+ }
281
+ const r = c.imageRegion;
282
+ if (r.width * r.height > 16777216) {
283
+ fail('PARTS_COMMENT_CROP_LIMIT', 'native crop exceeds 16 million pixels');
284
+ }
285
+ if (r.x < 0 || r.y < 0 || r.x + r.width > item.w || r.y + r.height > item.h) {
286
+ fail('PARTS_COMMENT_OUT_OF_BOUNDS', 'region exceeds original image');
287
+ }
288
+ if (c.rigRegion.x !== item.x + r.x || c.rigRegion.y !== item.y + r.y || c.rigRegion.width !== r.width || c.rigRegion.height !== r.height) {
289
+ fail('PARTS_COMMENT_RIG_REGION', 'rig region must be exact placement plus image region');
290
+ }
291
+ }
292
+
293
+ export function assertPartsIssueBinding(
294
+ c: PartsIssue,
295
+ items: ReadonlyMap<string, { name: string; x: number; y: number; w: number; h: number; imageHash: string }>,
296
+ sourceHash: string,
297
+ ): void {
298
+ if (c.sourceHash !== sourceHash) {
299
+ fail('PARTS_COMMENT_STALE_SOURCE', 'original image or package source hash differs');
300
+ }
301
+ for (const layer of c.view.visibleLayers ?? []) {
302
+ const item = items.get(layer.name);
303
+ if (!item) fail('PARTS_COMMENT_PART_MISMATCH', 'visible layer belongs to another part');
304
+ if (item!.imageHash !== layer.imageHash) fail('PARTS_COMMENT_STALE_SOURCE', 'visible layer image hash differs');
305
+ }
306
+ const matchedItems: { name: string; x: number; y: number; w: number; h: number; imageHash: string }[] = [];
307
+ for (const p of c.parts) {
308
+ const item = items.get(p.name);
309
+ if (!item) {
310
+ return fail('PARTS_COMMENT_PART_MISMATCH', 'comment belongs to another part');
311
+ }
312
+ if (p.imageHash !== item.imageHash) {
313
+ return fail('PARTS_COMMENT_STALE_SOURCE', 'original image or package source hash differs');
314
+ }
315
+ matchedItems.push(item);
316
+ }
317
+ if (c.view.mode === 'item') {
318
+ const item = matchedItems[0]!;
319
+ assertPartsCommentBinding(
320
+ {
321
+ ...c,
322
+ schema: PARTS_COMMENT_SCHEMA,
323
+ part: item.name,
324
+ imageHash: c.parts[0]!.imageHash,
325
+ imageRegion: c.imageRegion!,
326
+ crop: { ...c.crop, png: c.crop.png ?? '' },
327
+ },
328
+ item,
329
+ item.imageHash,
330
+ sourceHash,
331
+ );
332
+ return;
333
+ }
334
+ const r = c.rigRegion;
335
+ if (![r.x, r.y, r.width, r.height].every(Number.isSafeInteger)) {
336
+ fail('PARTS_COMMENT_FRACTIONAL', 'rig coordinates must be integer pixels');
337
+ }
338
+ const minX = Math.min(...matchedItems.map(i => i.x));
339
+ const minY = Math.min(...matchedItems.map(i => i.y));
340
+ const maxX = Math.max(...matchedItems.map(i => i.x + i.w));
341
+ const maxY = Math.max(...matchedItems.map(i => i.y + i.h));
342
+ if (r.x < minX || r.y < minY || r.x + r.width > maxX || r.y + r.height > maxY) {
343
+ fail('PARTS_COMMENT_OUT_OF_BOUNDS', 'region exceeds union of issue parts');
344
+ }
345
+ }
346
+
347
+ /** The pointed issues of an act@6 Parts verdict: its comments with Parts anchors, in stored order. */
348
+ export function commentPartsIssues(comments: readonly JobComment[]): PartsIssue[] {
349
+ return comments.flatMap(comment => comment.anchor && 'schema' in comment.anchor ?
350
+ [{...structuredClone(comment.anchor), summary: comment.text} as PartsIssue] : []);
351
+ }
352
+
353
+ /** Pointed Parts issues keep their source-bound anchor; the summary becomes the comment text. */
354
+ export function partsIssueComments(issues: readonly PartsIssue[]): {text: string; anchor: JobCommentPartsAnchor}[] {
355
+ return issues.map(({summary, ...anchor}) => ({text: summary, anchor: structuredClone(anchor)}));
33
356
  }
@@ -1,12 +1,12 @@
1
- /** Serves the parts and atlas view (#348): the page, its bundle, the part and page images by index, and the sign-off. */
1
+ /** Serves the parts workspace: the page, its bundle, indexed images, and the sign-off. */
2
2
  import { PNG } from 'pngjs';
3
3
  import { readFile } from 'node:fs/promises';
4
- import { appRoot, buildWeb } from './build.ts';
4
+ import { appRoot, buildWeb, setupEntryHtml } from './build.ts';
5
5
  import { accessGate } from './open-protocol.ts';
6
6
  import { createLiveLifecycle, LIVE_PATH, type LiveExitInfo, type UpgradableServer } from './live-lifecycle.ts';
7
7
  import {preparePartsComment} from './parts-comment-crops.ts';
8
8
  import {serveReference} from './reference.ts';
9
- import { partsDifference, partsViewJson, exportPartsVerdict, assertPartsUnchanged, readVerdict, saveVerdictWithReceipt, servedImage, type PartsViewPackage, type PartsSaveReceipt } from './parts-view.ts';
9
+ import { partsDifference, partsViewJson, exportPartsVerdict, assertPartsUnchanged, assertPartsCanOpen, readVerdict, saveVerdictWithReceipt, servedImage, type PartsViewPackage, type PartsSaveReceipt } from './parts-view.ts';
10
10
 
11
11
  const headers = { 'X-Content-Type-Options': 'nosniff', 'Cache-Control': 'no-store', 'Content-Security-Policy': "default-src 'none'; script-src 'self'; style-src 'self' 'unsafe-inline'; img-src 'self' blob: data:; connect-src 'self'; base-uri 'none'; form-action 'none'; frame-ancestors 'none'" };
12
12
  const json = (value: unknown, status = 200) => Response.json(value, { status, headers });
@@ -47,9 +47,11 @@ export interface PartsServerOptions {
47
47
  }
48
48
 
49
49
  export async function startPartsServer(pkg: PartsViewPackage, options: PartsServerOptions = {}) {
50
+ assertPartsCanOpen(pkg);
50
51
  const by = options.by;
51
52
  if (by !== undefined && (typeof by !== 'string' || !by.trim())) throw new Error('PARTS_VERDICT_INVALID: reviewer name must be nonblank');
52
- const bundle = await buildWeb('parts');
53
+ const bundle = await buildWeb();
54
+ const page = await setupEntryHtml('parts');
53
55
  let rawStop: ((closeActiveConnections?: boolean) => void) | null = null;
54
56
  let pendingSaves = 0, saveCount = 0;
55
57
  let saveQueue: Promise<void> = Promise.resolve();
@@ -89,6 +91,14 @@ export async function startPartsServer(pkg: PartsViewPackage, options: PartsServ
89
91
  }
90
92
  live.onRequestStart(url.pathname);
91
93
  try {
94
+ // A parts subject has its own identity and verdict; never synthesize a rig manifest or session.
95
+ if (req.method === 'GET' && ['/api/review','/api/session','/api/access'].includes(url.pathname)) {
96
+ await assertPartsUnchanged(pkg);
97
+ if(url.pathname==='/api/access')return json({capabilityRequired:!!options.capability,control:false});
98
+ const saved=await readVerdict(pkg);
99
+ if(url.pathname==='/api/session')return json({subject:'parts',issues:saved.verdict?.issues??saved.legacy?.issues??[]});
100
+ return json({subject:'parts',parts:partsViewJson(pkg,saved)});
101
+ }
92
102
  if (url.pathname === '/api/parts' && req.method === 'GET'){await assertPartsUnchanged(pkg);return json(partsViewJson(pkg,await readVerdict(pkg)));}
93
103
  if(url.pathname==='/api/parts/comment'&&req.method==='POST'){if(req.headers.get('origin')!==origin)return json({error:'Same-origin Origin required'},403);await assertPartsUnchanged(pkg);return json({comment:await preparePartsComment(pkg,await bodyJson(req))});}
94
104
  if(url.pathname==='/api/parts/export'&&req.method==='GET'){await assertPartsUnchanged(pkg);const saved=await readVerdict(pkg);if(!saved.verdict)return json({error:'PARTS_VERDICT_UNAVAILABLE: save a verdict first'},409);return new Response(exportPartsVerdict(saved.verdict,url.searchParams.get('format')==='issue'?'issue':'json'),{headers:{...headers,'Content-Type':url.searchParams.get('format')==='issue'?'text/markdown':'application/json'}});}
@@ -112,9 +122,11 @@ export async function startPartsServer(pkg: PartsViewPackage, options: PartsServ
112
122
  const pinned=pkg.files.find(f=>f.abs===path);if(!pinned)return json({error:'PARTS_IMAGE_UNBOUND'},409);return serveReference(req,path,pinned.sha256,headers);
113
123
 
114
124
  }
115
- if (url.pathname === '/parts.js') return new Response(req.method === 'HEAD' ? null : bundle, { headers: { ...headers, 'Content-Type': 'text/javascript' } });
116
- if (url.pathname === '/' || url.pathname === '/parts.html') return new Response(req.method === 'HEAD' ? null : await readFile(appRoot + 'web/parts.html'), { headers: { ...headers, 'Content-Type': 'text/html; charset=utf-8' } });
117
- if (url.pathname === '/parts.css') return new Response(req.method === 'HEAD' ? null : await readFile(appRoot + 'web/parts.css'), { headers: { ...headers, 'Content-Type': 'text/css' } });
125
+ const read=req.method==='GET'||req.method==='HEAD';
126
+ if(read&&url.pathname==='/parts.html')return new Response(null,{status:302,headers:{...headers,Location:'/'+url.search}});
127
+ if(read&&url.pathname==='/main.js')return new Response(req.method==='HEAD'?null:bundle,{headers:{...headers,'Content-Type':'text/javascript'}});
128
+ if(read&&(url.pathname==='/'||url.pathname==='/index.html'))return new Response(req.method==='HEAD'?null:page,{headers:{...headers,'Content-Type':'text/html; charset=utf-8'}});
129
+ if(read&&url.pathname==='/styles.css')return new Response(req.method==='HEAD'?null:await readFile(appRoot+'web/styles.css'),{headers:{...headers,'Content-Type':'text/css'}});
118
130
  return json({ error: 'Not found' }, 404);
119
131
  } finally { live.onRequestEnd(url.pathname); }
120
132
  } catch (e) {