rig-review 2.12.0 → 2.13.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (89) hide show
  1. package/docs/DESIGN.md +82 -71
  2. package/docs/PANELS.md +20 -12
  3. package/docs/PARTS_VIEW.md +31 -11
  4. package/docs/REVIEW_PACKAGE.md +99 -9
  5. package/docs/STABILITY.md +74 -3
  6. package/docs/WORKFLOWS.md +40 -12
  7. package/package.json +2 -1
  8. package/skills/rig-review/SKILL.md +29 -1
  9. package/src/build.ts +10 -2
  10. package/src/cli.ts +14 -12
  11. package/src/compare-html.ts +22 -24
  12. package/src/compare-server.ts +1 -1
  13. package/src/create-pin-gate.ts +3 -0
  14. package/src/feedback-export.ts +49 -1
  15. package/src/front.ts +10 -16
  16. package/src/interview-routes.ts +1 -1
  17. package/src/job-act.ts +39 -21
  18. package/src/job-api.ts +102 -11
  19. package/src/job-contract.ts +44 -4
  20. package/src/job-front.ts +15 -7
  21. package/src/job-host.ts +4 -3
  22. package/src/job-hub.ts +4 -4
  23. package/src/job-session.ts +5 -2
  24. package/src/job-source.ts +42 -13
  25. package/src/joined-project.ts +61 -4
  26. package/src/open-workspace.ts +12 -12
  27. package/src/open.ts +17 -9
  28. package/src/parts-comment.ts +31 -1
  29. package/src/parts-server.ts +19 -7
  30. package/src/parts-view.ts +71 -20
  31. package/src/server.ts +30 -21
  32. package/src/stage-comment.ts +11 -1
  33. package/src/stage-parts.ts +18 -10
  34. package/web/animation-inspection.ts +1 -1
  35. package/web/bones-panel.ts +1 -3
  36. package/web/catalog-en.ts +76 -12
  37. package/web/catalog-ko.ts +76 -12
  38. package/web/cloth-panel.ts +1 -2
  39. package/web/compare.css +3 -9
  40. package/web/compare.html +3 -3
  41. package/web/compare.ts +69 -64
  42. package/web/cuts-panel.ts +1 -3
  43. package/web/density-strip-panel.ts +1 -2
  44. package/web/i18n.ts +13 -1
  45. package/web/idle-panel.ts +1 -2
  46. package/web/index.html +1 -5
  47. package/web/inspection-persistence.ts +2 -1
  48. package/web/inspector-blocks.ts +144 -39
  49. package/web/instance-access.ts +24 -5
  50. package/web/interview-panel.ts +224 -175
  51. package/web/job-hub.ts +50 -69
  52. package/web/job-rig-capture.ts +103 -10
  53. package/web/job-rig-screen.ts +317 -0
  54. package/web/job-session.ts +927 -1365
  55. package/web/main.ts +535 -129
  56. package/web/mesh-panel.ts +1 -2
  57. package/web/owner-workspace.ts +88 -109
  58. package/web/part-selection.ts +47 -6
  59. package/web/part-thumbnails.ts +20 -6
  60. package/web/parts-viewport-provider.ts +166 -9
  61. package/web/physics-panel.ts +1 -2
  62. package/web/readings-panel.ts +1 -2
  63. package/web/requirements-panel.ts +1 -3
  64. package/web/retained-frame-stage.ts +105 -0
  65. package/web/retarget-panel.ts +2 -3
  66. package/web/rig-fields-panel.ts +1 -2
  67. package/web/rig-host.ts +62 -0
  68. package/web/rig-viewport-provider.ts +63 -16
  69. package/web/stage-comments.ts +29 -26
  70. package/web/styles.css +127 -43
  71. package/web/view-controls.ts +201 -12
  72. package/web/viewport-controller.ts +97 -26
  73. package/web/viewport-pair.ts +2 -1
  74. package/web/workspace-preferences.ts +5 -4
  75. package/web/workspace-ui.ts +152 -19
  76. package/src/interview-server.ts +0 -54
  77. package/web/interview.css +0 -28
  78. package/web/interview.html +0 -17
  79. package/web/interview.ts +0 -40
  80. package/web/job-hub.css +0 -14
  81. package/web/job-hub.html +0 -5
  82. package/web/owner-workspace.css +0 -14
  83. package/web/owner-workspace.html +0 -5
  84. package/web/parts-flags.ts +0 -48
  85. package/web/parts-page.ts +0 -217
  86. package/web/parts.css +0 -116
  87. package/web/parts.html +0 -15
  88. package/web/parts.ts +0 -986
  89. package/web/stage-nav.ts +0 -136
package/web/compare.ts CHANGED
@@ -1,4 +1,4 @@
1
- import {bindStageNav} from './stage-nav.ts';
1
+ import {sharedViewToolsMarkup,sharedCommentMarkup,legacyCompareLayerControlsMarkup,legacyCompareHeaderContent} from '../src/compare-html.ts';
2
2
  import {bindWorkspaceVisibility} from './workspace-visibility.ts';
3
3
  import {requireFeedbackFrames} from '../src/stage-comment.ts';
4
4
  import {bindStageComments,type CommentPose} from './stage-comments.ts';
@@ -6,7 +6,9 @@ import {sharedTurnDials,type TurnDial} from '../src/turn-pad.ts';
6
6
  import {bindTurnPad,type TurnPad} from './turn-pad.ts';
7
7
  import {PartExplorer,loadPartModel} from './part-selection.ts';
8
8
  import {PartThumbnails,pageRegionTable} from './part-thumbnails.ts';
9
- import {cameraFrame,cameraSignature,cameraFromSignature,assertCameraView,boundsFitSignature,dragSignature,zoomSignature,type CameraFrame,type CameraPoint,type CameraSignature,type PaneCamera} from './camera-view.ts';
9
+ import {cameraSignature,type PaneCamera} from './camera-view.ts';
10
+ import {createViewportController,createViewportState} from './viewport-controller.ts';
11
+ import {createRigViewportProvider} from './rig-viewport-provider.ts';
10
12
  import { CanvasRenderer, loadModel, RigPlayer, type ModelAssets, type PoseBounds } from '@rig-c/play';
11
13
  import type { CompareResponse, CompareSide } from '../src/compare.ts';
12
14
  import type { CompareFeedback, CompareSession } from '../src/compare-session.ts';
@@ -15,22 +17,40 @@ import { commonDomain, drawSynchronizedPair, compareSeekStep, feedbackTrace, ins
15
17
  import { feedbackLastFrame, feedbackTargetNames, validateFeedbackSelection } from '../src/feedback-validation.ts';
16
18
  import type { StripInterval, StripRequest } from '../src/strip.ts';
17
19
 
18
- import {bindAppearance,bindPan,bindStageLayout,bindInspectorTabs,syncStageLayout,idleAvailable} from './view-controls.ts';
20
+ import {createViewControls,panelMake,actionButton,bindAppearance,bindInspectorTabs,syncStageLayout,idleAvailable} from './view-controls.ts';
19
21
  import {CLICK_SLOP_PX} from './stage-pick.ts';
20
22
  import {dragImpulse} from '../src/environment.ts';
21
23
  import {RigOverlays} from './rig-overlays.ts';
22
- import {bindWorkspaceUI,type WorkspaceUI} from './workspace-ui.ts';
24
+ import {mountWorkspaceShell,bindWorkspaceUI,type WorkspaceUI} from './workspace-ui.ts';
23
25
  import {connectControl} from './control.ts';
24
26
  import {connectLiveWindow} from './live-connection.ts';
25
27
  import {pageInstanceAccess,readOnlyReason} from './instance-access.ts';
26
28
  import {controlComparison,type ControlCommand,type ControlInspection,type ControlView} from '../src/control.ts';
27
29
  import {pairEligibility,type InputState,type PairDomain} from '../src/comparison-eligibility.ts';
28
- import {parseBookmark,connectInspectionPersistence,serializableView,numericCamera,restoredZoom,restoreTransaction,captureInputs,restoreInputs,type InspectionBookmark,type InspectionBinding,type PersistenceConnection} from './inspection-persistence.ts';
30
+ import {parseBookmark,connectInspectionPersistence,serializableView,restoredZoom,restoreTransaction,captureInputs,restoreInputs,type InspectionBookmark,type InspectionBinding,type PersistenceConnection} from './inspection-persistence.ts';
29
31
  import {RendererBadge} from './renderer-status.ts';
30
32
  import {ComparePresentation,type PresentationState} from '../src/compare-presentation.ts';
31
33
  import {nextReferenceInterval,ReferenceSelectionUnavailable,inspectionReferenceFrame,lastSupportedReferenceFrame,producerFrameAssociations,referenceFrameAtTime,referenceSeekPosition,type ReferenceFrameIndex,type VideoInfo,type VideoFrame} from '../src/reference-frames.ts';
32
34
  import {mountComparePickedTools,type ComparePickedTools} from './compare-picked-tools.ts';
33
35
  import {appliedCheckRefusal} from '../src/applied-context.ts';
36
+ /** Compose trusted content through the existing C1/C5b owners before domain lookups. */
37
+ function mountComparisonChrome(){
38
+ const domain={} as Record<keyof typeof legacyCompareHeaderContent,HTMLElement>;
39
+ for(const key of ['modeSwitch','buildPicker','actions'] as const){
40
+ const template=panelMake('template');template.innerHTML=legacyCompareHeaderContent[key];
41
+ domain[key]=template.content.firstElementChild as HTMLElement;
42
+ }
43
+ const shell=mountWorkspaceShell({compatibility:'legacyCompareStep3',compare:domain});
44
+ document.querySelector('[data-workspace-header]')!.replaceWith(shell.header);
45
+ for(const [seam,markup] of [['comment',sharedCommentMarkup],['view-tools',sharedViewToolsMarkup],['layers',legacyCompareLayerControlsMarkup]] as const){
46
+ const template=panelMake('template');template.innerHTML=markup;
47
+ document.querySelector(`[data-workspace-${seam}]`)!.replaceWith(template.content);
48
+ }
49
+ const controls=createViewControls({layout:'legacyCompareStep3'});
50
+ document.querySelector('[data-workspace-camera]')!.replaceWith(controls.zoomGroup!);
51
+ return shell;
52
+ }
53
+ const shell=mountComparisonChrome();
34
54
  type Side = 'a' | 'b';
35
55
  const el = <T extends HTMLElement = HTMLElement>(id: string): T => {
36
56
  const node = document.getElementById(id); if (!node) throw new Error(`Missing compare UI element: ${id}`); return node as T;
@@ -48,11 +68,11 @@ let seekAbort: AbortController | null = null, videoCallback: number | null = nul
48
68
  let latestSeek = 0;
49
69
  type CameraTarget=Side|'reference';
50
70
  const cameras:Record<CameraTarget,PaneCamera>={a:{zoom:1,center:null},b:{zoom:1,center:null},reference:{zoom:1,center:null}};
51
- const cameraFrames:Partial<Record<CameraTarget,CameraFrame>>={};
52
71
  const rigScales:Record<Side,number>={a:1,b:1};
53
72
  let cameraSync=true,activeCamera:CameraTarget='a',cameraRestoring=false,cameraLayout='';
54
73
  let idleHeld=true,loopRestarting=false,suspendedPreview=false;
55
74
  let appearance:ReturnType<typeof bindAppearance>|null=null,controlDispose:(()=>void)|null=null,workspace:WorkspaceUI|null=null;
75
+ let inspectorTabs:ReturnType<typeof bindInspectorTabs>|null=null;
56
76
  const viewDisposers:(()=>void)[]=[];
57
77
  let parts:PartExplorer|null=null,turnPad:TurnPad|null=null;
58
78
  const thumbnails:Partial<Record<Side,PartThumbnails>>={};
@@ -77,6 +97,8 @@ let endStopReason:string|null=null;
77
97
  // Actual load outcomes per input; the shared domain exists only after all three loaded.
78
98
  let pairInputs:{a:InputState;b:InputState;reference:InputState;domain:PairDomain}={a:{state:'pending'},b:{state:'pending'},reference:{state:'pending'},domain:null};
79
99
  const traceRows: CompareTrace[] = [];
100
+ const viewport=createCompareViewport();
101
+ const {paneFrame,renderCameraControls,setCameraSync,cameraAction,updateCamera,fitSelection:fitSelected}=viewport;
80
102
 
81
103
  function message(value: string, error = false): void { text('message', value); el('message').classList.toggle('error', error); }
82
104
  function savedState(): void { text('save-state', dirty ? 'Unsubmitted changes' : session.updatedAt ? 'Submitted' : 'Not submitted'); el('save-state').classList.toggle('dirty', dirty); button('submit').disabled = saving || draftConflict || !!readOnly || session.feedbackWarnings.length > 0; button('submit').title = readOnly ? readOnly : session.feedbackWarnings.length ? 'Delete feedback with validation warnings, then add it again with a valid target.' : ''; }
@@ -233,15 +255,7 @@ async function seekTo(target: number,producer:{side:Side;frame:number;time:numbe
233
255
  }
234
256
 
235
257
  function unionBounds(a: PoseBounds, b: PoseBounds): PoseBounds { const x = Math.min(a.x, b.x), y = Math.min(a.y, b.y); return { x, y, width: Math.max(a.x + a.width, b.x + b.width) - x, height: Math.max(a.y + a.height, b.y + b.height) - y }; }
236
- function fit(): void {
237
- const layout=['a','b','reference'].map(target=>{const v=el(target+'-viewport');return `${v.clientWidth}:${v.clientHeight}`;}).join('|')+!!players.a+!!players.b+video.videoWidth+':'+video.videoHeight;
238
- if(cameraSync&&!cameraRestoring&&layout!==cameraLayout)alignCameras();cameraLayout=layout;
239
- for(const side of ['a','b'] as const){
240
- const frame=paneFrame(side);if(!frame)continue;const camera=cameras[side],center=camera.center??frame.center,scale=rigScales[side]=frame.baseScale*camera.zoom;
241
- const viewport=el(side+'-viewport'),root=el(side+'-root');root.style.left=`${viewport.clientWidth/2-center.x*scale}px`;root.style.top=`${viewport.clientHeight/2+center.y*scale}px`;root.style.transform=`scale(${scale})`;players[side]?.renderer.syncPixelRatio();
242
- }
243
- redrawOverlays(false);referenceFit();renderCameraControls();renderNumericView();
244
- }
258
+ function fit(): void {viewport.fitCamera();}
245
259
 
246
260
  function configureTurnPad():void {
247
261
  const a=data.a.feedbackCatalog.turnDials??[],b=data.b.feedbackCatalog.turnDials??[],dials=sharedTurnDials(a,b);
@@ -331,7 +345,7 @@ function renderFeedback(): void {
331
345
  row.append(title, summary);
332
346
  for (const warning of session.feedbackWarnings.filter(value => value.id === feedback.id)) { const note = document.createElement('p'); note.className = 'hint'; note.textContent = `Validation warning · ${warning.error}`; row.append(note); }
333
347
  const details = document.createElement('details'), heading = document.createElement('summary'), source = document.createElement('pre'); heading.textContent = 'Saved feedback and inspection context'; source.className = 'feedback-json'; source.textContent = JSON.stringify(feedback, null, 2); details.append(heading, source);
334
- const remove = document.createElement('button'); remove.type = 'button'; remove.textContent = 'Delete'; remove.onclick = () => { session.feedback = session.feedback.filter(value => value.id !== feedback.id); session.feedbackWarnings = session.feedbackWarnings.filter(warning => warning.id !== feedback.id); renderFeedback(); markDirty(); };
348
+ const remove = actionButton('Delete', () => { session.feedback = session.feedback.filter(value => value.id !== feedback.id); session.feedbackWarnings = session.feedbackWarnings.filter(warning => warning.id !== feedback.id); renderFeedback(); markDirty(); });
335
349
  row.append(details);if((feedback.context as any)?.comment?.schema!=='rig-review-comment/1'||!submittedBaseline?.feedback.some(f=>f.id===feedback.id))row.append(remove); list.append(row);
336
350
  }
337
351
  savedState();
@@ -396,12 +410,7 @@ function bind(): void {
396
410
  button('seek').onclick = () => { const value = input('time-input').value.trim(); if (!value) { message('Enter a time in seconds.', true); return; } void seekTo(Number(value)); };
397
411
  video.addEventListener('ended', () => { stopAtSupportedEnd(); });
398
412
  input('reference-audio').onchange = () => { video.muted = !input('reference-audio').checked; };
399
- button('zoom-in').onclick=()=>cameraAction(()=>zoomCamera(1.25));button('zoom-out').onclick=()=>cameraAction(()=>zoomCamera(1/1.25));button('fit').onclick=()=>cameraAction(()=>fitActiveCamera());
400
- input('camera-sync').onchange=()=>cameraAction(()=>setCameraSync(input('camera-sync').checked));
401
- for(const target of ['a','b','reference'] as const){
402
- el(target+'-viewport').addEventListener('wheel',event=>{event.preventDefault();const rect=el(target+'-viewport').getBoundingClientRect();cameraAction(()=>zoomCamera(event.deltaY<0?1.1:1/1.1,target,{x:event.clientX-rect.left,y:event.clientY-rect.top}));},{passive:false});
403
- for(const event of ['pointerdown','focusin'] as const)el(target+'-viewport').addEventListener(event,()=>activateCamera(target));
404
- }
413
+ viewDisposers.push(viewport.bindControls());
405
414
  select('status').onchange = () => { session.status = select('status').value as CompareSession['status']; markDirty(); };
406
415
  select('side').onchange = () => { renderFeedbackSelection(); select('category').value = ''; input('summary').value = ''; }; select('target-kind').onchange = renderFeedbackSelection;
407
416
  button('add-feedback').onclick = () => {
@@ -421,26 +430,24 @@ function bind(): void {
421
430
  button('export-json').onclick = () => { download(`${session.id}-feedback.json`, JSON.stringify({ ...session, schema: 'rig-review-compare-feedback/1', issues: session.feedback.map(issue) }, null, 2) + '\n', 'application/json'); };
422
431
  button('export-markdown').onclick = () => { download(`${session.id}-issues.md`, [`# ${md(data.title)}`, '', 'Ordered A/B and reference provenance:', ...JSON.stringify(session.binding, null, 2).split('\n').map(line => ' ' + line), '', 'Validation warnings:', ...JSON.stringify(session.feedbackWarnings, null, 2).split('\n').map(line => ' ' + line), '', ...session.feedback.flatMap(feedback => { const entry = issue(feedback); return [`## ${md(entry.title)}`, '', entry.body, '', '---', '']; })].join('\n'), 'text/markdown'); };
423
432
  // Saved browser defaults seed a new inspection; explicit links and source drafts restore over them.
424
- workspace=bindWorkspaceUI({changed:fit,defaultTheme:theme=>appearance?.set(theme)});
433
+ workspace=bindWorkspaceUI({changed:fit,defaultTheme:theme=>appearance?.set(theme),language:shell.language!});
425
434
  cameraSync=workspace.defaults().defaultCameraSync;input('camera-sync').checked=cameraSync;input('idle-repeat').checked=workspace.defaults().defaultIdleRepeat;
426
435
  appearance=bindAppearance(select('appearance'),workspace.defaults().theme);
427
436
  for(const side of ['a','b'] as const)overlays[side]=new RigOverlays({canvas:el<HTMLCanvasElement>(side+'-overlay'),rigRoot:el(side+'-root')});
428
437
  // #331: a plain drag on either rig pans and carries both rigs, each by its own root scale, so A and B take the same
429
438
  // stimulus; the reference pane only pans, as the Family viewer's does.
430
439
  const carryBoth={threshold:CLICK_SLOP_PX,move:(dx:number,dy:number)=>{for(const side of ['a','b'] as const){const impulse=dragImpulse(dx,dy,rigScales[side]);if(impulse)players[side]?.moved(impulse);}}};
431
- for(const target of ['a','b','reference'] as const)viewDisposers.push(bindPan(el(target+'-viewport'),(dx,dy)=>cameraAction(()=>panCamera(target,dx,dy)),()=>!comments?.active(),target==='reference'?undefined:carryBoth));
432
- viewDisposers.push(bindStageLayout(el('stage-layout'),fit));
440
+ viewDisposers.push(viewport.bindNavigation(target=>target==='reference'?undefined:carryBoth,()=>!comments?.active()));
433
441
  for(const [id,key] of [['layer-images','images'],['layer-mesh','mesh'],['layer-bones','bones']] as const)input(id).onchange=()=>{layers[key]=input(id).checked;redrawOverlays(false);};
434
442
  input('idle-repeat').onchange=()=>{renderIdle();if(canRepeatIdle())void playComparison().catch(error=>message(describe(error),true));};
435
443
  el('inspector-feedback').addEventListener('focusin',()=>{idleHeld=true;const current=lastPresented?.time;stop();if(current!==undefined&&!seeking)void seekTo(current);});
436
444
  bindInspector();
437
445
  const transportBlock=document.querySelector<HTMLElement>('#animate-blocks [data-block-target="motion-tools"]');if(transportBlock)transportBlock.dataset.blockIncludes=[transportBlock.dataset.blockIncludes,'compare-transport-context'].filter(Boolean).join(' ');
438
446
  pickedTools=mountComparePickedTools({data:()=>data,readOnly:()=>readOnly,players,assets,rigScales,layers,parts:()=>parts,time:()=>trace?.reference??presentation.snapshot().lastDrawn?.reference??0,duration:()=>domain?.end??0,playing:()=>!video.paused,pause:()=>{idleHeld=true;stop();},seekTo:seconds=>seekTo(seconds),api,route:access.route,swapSideRig,redrawOverlays,fit,syncLayout:()=>{renderPairLayout();const mode=pickedTools?.mode()??'compare',picked=pickedTools?.pickedSide()??'a';if(mode!=='compare'&&activeCamera!=='reference'&&activeCamera!==picked)activeCamera=picked;fit();},saveDraft:()=>{persistence?.save();},message,download,turnAdjustFor:side=>turnAdjusts[side]??null,syncFeedbackSide:side=>{if(select('side').value!==side&&!input('summary').value.trim()){select('side').value=side;renderFeedbackSelection();}}});
439
- viewDisposers.push(bindStageNav({model:true,side:()=>pickedTools?.pickedSide()??'a',setup:()=>pickedTools?.setMode('setup')}));
440
447
  document.addEventListener('visibilitychange',()=>{if(document.hidden){suspendedPreview=!video.paused;stop();}else if(suspendedPreview&&!idleHeld){suspendedPreview=false;void playComparison().catch(error=>message(describe(error),true));}});
441
448
  const observer = new ResizeObserver(fit); observer.observe(el('a-viewport')); observer.observe(el('b-viewport'));observer.observe(el('reference-viewport'));
442
449
  window.addEventListener('beforeunload', event => { if (dirty) { event.preventDefault(); event.returnValue = ''; } });
443
- window.addEventListener('pagehide', () => { pickedTools?.dispose();comments?.dispose();persistence?.dispose();turnPad?.dispose();workspace?.dispose();disposed = true; seekAbort?.abort();controlDispose?.();appearance?.dispose();viewDisposers.forEach(dispose=>dispose());for(const overlay of Object.values(overlays))overlay.dispose();stop(); if (videoCallback !== null) video.cancelVideoFrameCallback(videoCallback); if (fallbackCallback !== null) cancelAnimationFrame(fallbackCallback); for (const side of ['a', 'b'] as const) { thumbnails[side]?.dispose(); players[side]?.dispose(); assets[side]?.dispose(); } observer.disconnect(); });
450
+ window.addEventListener('pagehide', () => { shell.dispose();pickedTools?.dispose();comments?.dispose();persistence?.dispose();turnPad?.dispose();inspectorTabs?.dispose();workspace?.dispose();disposed = true; seekAbort?.abort();controlDispose?.();appearance?.dispose();viewDisposers.forEach(dispose=>dispose());for(const overlay of Object.values(overlays))overlay.dispose();stop(); if (videoCallback !== null) video.cancelVideoFrameCallback(videoCallback); if (fallbackCallback !== null) cancelAnimationFrame(fallbackCallback); for (const side of ['a', 'b'] as const) { thumbnails[side]?.dispose(); players[side]?.dispose(); assets[side]?.dispose(); } observer.disconnect(); });
444
451
  }
445
452
 
446
453
  async function start(): Promise<void> {
@@ -451,7 +458,7 @@ async function start(): Promise<void> {
451
458
  readOnly = readOnlyReason(access, writes.capabilityRequired); if (readOnly) message(readOnly, true); controlServed = writes.control !== false;
452
459
  submittedBaseline=structuredClone(session);
453
460
  if (data.id !== session.id || data.sourceHash !== session.sourceHash || JSON.stringify(data.binding) !== JSON.stringify(session.binding)) throw new Error('Comparison and submission session refer to different source identities. Reopen the review.');
454
- text('title', data.title); text('animation', `${data.animation} · A/B order and reference video hash are fixed`); document.title = data.title + ' · rig review compare'; select('status').value = session.status; provenance(); bind(); parts=new PartExplorer(el('parts-explorer'),el('selected-part'),previous=>{redrawOverlays(true);const part=parts?.value();pickedTools?.onPartSelected(part?.side==='b'?'b':part?.side==='a'?'a':null,part?.slot??null);if(part&&!pickedTools?.isSwitchingSide()){activeCamera=part.side==='b'?'b':'a';workspace?.revealInspector();if(document.querySelector<HTMLElement>('[data-inspector][aria-selected="true"]')?.dataset.inspector!=='playback')document.querySelector<HTMLButtonElement>('[data-inspector=rig]')?.click();renderCameraControls();}if(!cameraRestoring&&!pickedTools?.isSwitchingSide()&&(previous?.side!==part?.side||previous?.slot!==part?.slot))cameraAction(()=>fitActiveCamera());persistence?.save();},part=>{select('side').value=part.side;select('target-kind').value='slot';renderFeedbackSelection();input('target-name').value=part.slot;document.querySelector<HTMLButtonElement>('[data-inspector=feedback]')?.click();}); updateStripControls(); stripStatus('Choose the entered start–end frames or all feedback ranges to download. Unsubmitted feedback is included; exporting does not submit the review.'); renderFeedbackSelection(); renderFeedback(); savedState();
461
+ text('title', data.title); text('animation', `${data.animation} · A/B order and reference video hash are fixed`); document.title = data.title + ' · rig review compare'; select('status').value = session.status; provenance(); bind(); parts=new PartExplorer(el('parts-explorer'),el('selected-part'),previous=>{redrawOverlays(true);const part=parts?.value();pickedTools?.onPartSelected(part?.side==='b'?'b':part?.side==='a'?'a':null,part?.slot??null);if(part&&!pickedTools?.isSwitchingSide()){activeCamera=part.side==='b'?'b':'a';workspace?.revealInspector();if(document.querySelector<HTMLElement>('[data-inspector][aria-selected="true"]')?.dataset.inspector!=='playback')document.querySelector<HTMLButtonElement>('[data-inspector=rig]')?.click();renderCameraControls();}if(!cameraRestoring&&!pickedTools?.isSwitchingSide()&&(previous?.side!==part?.side||previous?.slot!==part?.slot))cameraAction(()=>fitSelected());persistence?.save();},part=>{select('side').value=part.side;select('target-kind').value='slot';renderFeedbackSelection();input('target-name').value=part.slot;document.querySelector<HTMLButtonElement>('[data-inspector=feedback]')?.click();}); updateStripControls(); stripStatus('Choose the entered start–end frames or all feedback ranges to download. Unsubmitted feedback is included; exporting does not submit the review.'); renderFeedbackSelection(); renderFeedback(); savedState();
455
462
  renderPairLayout();
456
463
  const settled = await Promise.allSettled([loadReference(), loadSide('a', data.a), loadSide('b', data.b)]);
457
464
  const outcome = (value: PromiseSettledResult<number>): InputState => value.status === 'fulfilled' ? { state: 'loaded' } : { state: 'failed', reason: describe(value.reason) };
@@ -462,11 +469,39 @@ async function start(): Promise<void> {
462
469
  void loadFrameIndex();
463
470
  input('scrub').max = String(domain.end); input('time-input').max = String(domain.end); text('domain', `Shared range 0–${domain.end} s · Neither side is independently clamped or looped`); ready = true;
464
471
  input('scrub').disabled = false; input('time-input').disabled = false; button('seek').disabled = false; button('play').disabled = domain.end === 0;
465
- await seekTo(0);configureTurnPad();workspace?.refresh();activeCamera='a';if(cameraSync)alignCameras();fit();for(const id of ['layer-images','layer-mesh','layer-bones'])input(id).disabled=false;renderIdle();const restored=await setupPersistence();setupComments();await pickedTools?.loadInitialSideStatuses();if(!restored&&canRepeatIdle())void playComparison().catch(error=>message(describe(error),true));
472
+ await seekTo(0);configureTurnPad();workspace?.refresh();activeCamera='a';if(cameraSync)setCameraSync(true);fit();for(const id of ['layer-images','layer-mesh','layer-bones'])input(id).disabled=false;renderIdle();const restored=await setupPersistence();setupComments();await pickedTools?.loadInitialSideStatuses();if(!restored&&canRepeatIdle())void playComparison().catch(error=>message(describe(error),true));
466
473
  if(!readOnly&&controlServed)controlDispose=connectControl({sourceHash:data.sourceHash,mode:'compare',route:access.route,headers:()=>access.headers(),observe:controlState,apply:applyControl,onStatus:value=>text('control-state',value)});
467
474
  bindWorkspaceVisibility({key:access.key,sourceHash:data.sourceHash,pause:()=>{idleHeld=true;stop();}});
468
475
  } catch (error) { failPair(error); for (const side of ['a', 'b'] as const) if (!players[side]) text(`${side}-empty`, `${side.toUpperCase()} Could not open comparison rig.`); text('reference-empty', 'Check the reference video and comparison inputs.'); }
469
476
  }
477
+ /** Configure the shared camera and compiled renderer without changing the legacy compare layout. */
478
+ function createCompareViewport(){
479
+ const state=createViewportState();state.cameras=cameras;
480
+ Object.defineProperties(state,{
481
+ cameraSync:{get:()=>cameraSync,set:(value:boolean)=>{cameraSync=value;}},
482
+ activeCamera:{get:()=>activeCamera,set:(value:CameraTarget)=>{activeCamera=value;}},
483
+ cameraRestoring:{get:()=>cameraRestoring,set:(value:boolean)=>{cameraRestoring=value;}},
484
+ cameraLayout:{get:()=>cameraLayout,set:(value:string)=>{cameraLayout=value;}}
485
+ });
486
+ const provider=createRigViewportProvider({el,player:()=>null,assets:()=>null,
487
+ panes:(['a','b'] as const).map(target=>({target,viewport:el(target+'-viewport'),pane:el(target+'-pane'),
488
+ root:el(target+'-root'),fallback:target==='a'?'b' as const:'a' as const,box:sharedBox,
489
+ player:()=>players[target]??null,scale:(value:number)=>{rigScales[target]=value;}})),
490
+ rigMargins:{x:22,y:38},referenceTransform:{content:video,mode:'relative'},pinch:false,dimensionVisibility:true,
491
+ referenceSize:()=>video.videoWidth>0&&video.videoHeight>0?{width:video.videoWidth,height:video.videoHeight}:null,
492
+ view:()=>'',referenceGeneration:()=>0,parts:()=>null,text,message,redrawOverlay:redrawOverlays,
493
+ layoutKey:()=>['a','b','reference'].map(target=>{const v=el(target+'-viewport');return `${v.clientWidth}:${v.clientHeight}`;}).join('|')+!!players.a+!!players.b+video.videoWidth+':'+video.videoHeight,
494
+ selection:target=>{const selected=parts?.value()?.side===target;return {selected,bounds:selected?parts?.bounds()??null:null};},
495
+ fitMessage:selected=>{
496
+ const tools=typeof pickedTools!=='undefined'?pickedTools:null,mode=tools?.mode()??'compare',picked=tools?.pickedSide()??'a';
497
+ const suffix=mode==='compare'?'':` on Build ${picked.toUpperCase()} (${data[picked].manifest.title})`;
498
+ return selected?`Selected slot fitted${suffix}.`:`View fitted${suffix}.`;
499
+ },
500
+ cameraControls:{zoomId:'zoom-label',targetLabel:target=>target==='reference'?'Reference':target?.toUpperCase()??'A',
501
+ fitLabel:sync=>sync?'Fit synchronized views':'Fit active view',coordinatesId:null}
502
+ },state);
503
+ return createViewportController(provider,state);
504
+ }
470
505
  function sharedBox():PoseBounds|null {const a=assets.a?.stage??players.a?.bounds(),b=assets.b?.stage??players.b?.bounds();return a&&b?unionBounds(a,b):a??b??null;}
471
506
  /** The pair is offered only when both sides and the shared video actually loaded; a failed side leaves the survivor as a single pane, named. */
472
507
  function renderPairLayout():PairEligibilityState {
@@ -487,40 +522,13 @@ function showSurvivors():void {
487
522
  message(`Comparison unavailable · ${state.reasons.compare??''}${state.effective&&state.effective!=='compare'?` · showing ${state.effective==='reference'?'the reference':state.effective.toUpperCase()} alone`:''}`,true);
488
523
  if(!readOnly&&controlServed)controlDispose=connectControl({sourceHash:data.sourceHash,mode:'compare',route:access.route,headers:()=>access.headers(),observe:controlState,apply:applyControl,onStatus:value=>text('control-state',value)});
489
524
  }
490
- function paneFrame(target:CameraTarget,hidden=false):CameraFrame|null {
491
- const viewport=el(target+'-viewport');let width=viewport.clientWidth,height=viewport.clientHeight;
492
- if(width<=0||height<=0){if(!hidden)return null;if(cameraFrames[target])return cameraFrames[target]!;if(target==='a'||target==='b'){const other=el((target==='a'?'b':'a')+'-viewport');width=other.clientWidth;height=other.clientHeight;}if(width<=0||height<=0)return null;}
493
- const box=target==='reference'?video.videoWidth>0&&video.videoHeight>0?{x:0,y:0,width:video.videoWidth,height:video.videoHeight}:null:players[target]?sharedBox():null;
494
- if(!box)return null;const frame=cameraFrame(target==='reference'?'image':'world',box,width,height,target==='reference'?0:22,target==='reference'?0:38);if(frame)cameraFrames[target]=frame;return frame;
495
- }
496
- function availableCamera():CameraTarget|null {return paneFrame(activeCamera)?activeCamera:paneFrame('a')?'a':paneFrame('b')?'b':paneFrame('reference')?'reference':null;}
497
- function activateCamera(target:CameraTarget):void {if(paneFrame(target)){activeCamera=target;renderCameraControls();}}
498
- function alignCameras():void {
499
- const target=availableCamera();if(!target)return;const source=paneFrame(target)!;assertCameraView(cameras[target],source);const signature=cameraSignature(cameras[target],source);
500
- const updates:Partial<Record<CameraTarget,PaneCamera>>={};
501
- for(const other of ['a','b','reference'] as const){if(other===target)continue;const frame=paneFrame(other);if(frame)updates[other]=cameraFromSignature(signature,frame);}
502
- Object.assign(cameras,updates);activeCamera=target;
503
- }
504
- function renderCameraControls():void {input('camera-sync').checked=cameraSync;const target=availableCamera();text('zoom-label',`${Math.round((target?cameras[target].zoom:1)*100)}% · ${target==='reference'?'Reference':target?.toUpperCase()??'A'}`);button('fit').textContent=cameraSync?'Fit synchronized views':'Fit active view';}
505
- function setCameraSync(value:boolean):void {if(value)alignCameras();cameraSync=value;fit();}
506
- function cameraAction(action:()=>void):void {try{action();}catch(error){renderCameraControls();message(describe(error),true);}}
507
- function updateCamera(target:CameraTarget,value:CameraSignature,rigGroup=false):void {
508
- const frame=paneFrame(target);if(!frame)return;
509
- const updates:Partial<Record<CameraTarget,PaneCamera>>={[target]:cameraFromSignature(value,frame)};
510
- for(const other of ['a','b','reference'] as const){if(other===target||!cameraSync&&!(rigGroup&&other!=='reference'))continue;const next=paneFrame(other);if(next)updates[other]=cameraFromSignature(value,next);}
511
- Object.assign(cameras,updates);activeCamera=target;fit();
512
- }
513
- function zoomCamera(factor:number,target=availableCamera(),point?:CameraPoint|null):void {if(!target)return;const frame=paneFrame(target);if(frame)updateCamera(target,zoomSignature(cameraSignature(cameras[target],frame),factor,frame,point));}
514
- function panCamera(target:CameraTarget,dx:number,dy:number):void {const frame=paneFrame(target);if(frame)updateCamera(target,dragSignature(cameraSignature(cameras[target],frame),frame,dx,dy));}
515
- function fitActiveCamera(target=availableCamera()):void {if(!target)return;const tools=typeof pickedTools!=='undefined'?pickedTools:null,mode=tools?.mode()??'compare',picked=tools?.pickedSide()??'a',suffix=mode==='compare'?'':` on Build ${picked.toUpperCase()} (${data[picked].manifest.title})`;const part=parts?.value();if(part?.side===target){const box=parts?.bounds(),frame=paneFrame(target);if(!box||!frame){message('PART_FIT_UNAVAILABLE: selected slot has no positive drawn bounds.',true);return;}updateCamera(target,boundsFitSignature(box,frame,22,38));message(`Selected slot fitted${suffix}.`);}else{if(!paneFrame(target))return;updateCamera(target,{zoom:1,pan:{x:0,y:0}});message(`View fitted${suffix}.`);}}
516
- function referenceFit():void {const frame=paneFrame('reference');if(!frame)return;const signature=cameraSignature(cameras.reference,frame);video.style.transform=`translate(${signature.pan.x*frame.width}px,${signature.pan.y*frame.height}px) scale(${signature.zoom})`;}
517
525
  function redrawOverlays(fresh:boolean):void {
518
526
  const warnings:string[]=[];let needsCapture=false;
519
527
  for(const side of ['a','b'] as const){const overlay=overlays[side],player=players[side];if(!overlay||!player)continue;const root=el(`${side}-root`),project=(x:number,y:number)=>({x:parseFloat(root.style.left||'0')+x*rigScales[side],y:parseFloat(root.style.top||'0')-y*rigScales[side]}),extra=pickedTools?pickedTools.overlayInputFor(side):{regions:[],circles:[],markers:[],meshEdit:null,weights:null,anchors:null};const snapshot=fresh?overlay.refresh({player,frame:parts?.frame(side),selectedSlot:parts?.value()?.side===side?parts.value()!.slot:null,bones:(data[side].feedbackCatalog.bones??[]).map(name=>({name})),project,settings:layers,...extra}):overlay.redraw({project,settings:layers,...extra});pickedTools?.recordOverlaySnapshot(side,snapshot);warnings.push(...snapshot.warnings);needsCapture ||= snapshot.needsCapture;}
520
528
  text('layer-state',warnings.join(' · ')||'Actual last-drawn mesh edges / bone points');
521
529
  if(!fresh&&needsCapture&&trace&&!seeking&&!video.seeking&&players.a&&players.b){try{drawSynchronizedPair(inspectionPlayer('a'),inspectionPlayer('b'));redrawOverlays(true);for(const side of ['a','b'] as const)text(`${side}-renderer`,rendererBadges[side].observe('drawn',players[side]!.renderer).label);}catch(error){failPair(error);}}
522
530
  }
523
- function bindInspector():void {bindInspectorTabs(()=>{pickedTools?.onInspectorTabChanged();workspace?.afterTab();if(document.querySelector('[data-inspector="feedback"][aria-selected="true"]')){idleHeld=true;const current=lastPresented?.time;stop();if(current!==undefined&&!seeking)void seekTo(current);}fit();},()=>workspace?.beforeTab());}
531
+ function bindInspector():void {inspectorTabs?.dispose();inspectorTabs=bindInspectorTabs(()=>{pickedTools?.onInspectorTabChanged();workspace?.afterTab();if(document.querySelector('[data-inspector="feedback"][aria-selected="true"]')){idleHeld=true;const current=lastPresented?.time;stop();if(current!==undefined&&!seeking)void seekTo(current);}fit();},()=>workspace?.beforeTab());}
524
532
 
525
533
  function canRepeatIdle():boolean{return data?.animation==='idle'&&idleAvailable(assets.a?.animations.map(a=>a.name)??[],data.animation)&&idleAvailable(assets.b?.animations.map(a=>a.name)??[],data.animation)&&input('idle-repeat').checked&&!!domain&&domain.end>0;}
526
534
  function renderIdle():void {text('idle-state',canRepeatIdle()?'Actual idle · repeat enabled':'Bound non-idle inspection · no automatic playback');}
@@ -558,16 +566,13 @@ async function applyControl(command:ControlCommand,signal:AbortSignal):Promise<v
558
566
  if(command.type==='camera'||command.type==='fit'){
559
567
  const target=command.target==='rig'?'a':command.target,frame=paneFrame(target);if(!frame)throw new Error('CONTROL_CAMERA_UNAVAILABLE');
560
568
  const value=command.type==='fit'?{zoom:1,pan:{x:0,y:0}}:{zoom:command.zoom,pan:{x:command.pan.x/frame.width,y:command.pan.y/frame.height}};
561
- updateCamera(target,value,command.target==='rig');return;
569
+ updateCamera(target,value,command.target==='rig'?['a','b']:undefined);return;
562
570
  }
563
571
  if(command.type==='playback'){if(command.value==='play')await playComparison(signal);else{idleHeld=true;const current=lastPresented?.time;stop();if(current!==undefined){await seekTo(current);if(!trace)throw new Error('CONTROL_REFERENCE_UNAVAILABLE');}}return;}
564
572
  if(command.type==='time'){if(!domain)throw new Error('CONTROL_TIME_UNAVAILABLE');requireCommonTime(command.seconds,domain);await seekTo(command.seconds);if(signal.aborted||!trace)throw new Error('CONTROL_REFERENCE_UNAVAILABLE');}
565
573
  }
566
- function numericView():ControlView {
567
- const numeric=(target:CameraTarget)=>{const frame=paneFrame(target,true);if(!frame)return null;const camera=cameras[target];return numericCamera(frame.space,camera.center??frame.center,camera.zoom,frame.baseScale*camera.zoom,frame.width,frame.height);};
568
- return {schema:'rig-review-view/1',cameraSync,activeCamera,cameras:{rig:null,a:numeric('a'),b:numeric('b'),reference:numeric('reference')}};
569
- }
570
- function renderNumericView():void {const node=document.getElementById('view-coordinates');if(node)node.textContent=JSON.stringify(numericView(),null,2);}
574
+ function numericView():ControlView {return viewport.numericView();}
575
+ function renderNumericView():void {viewport.renderNumericView();}
571
576
  function inspectionBinding():InspectionBinding{return {mode:'compare',sourceHash:data.sourceHash,rigs:[data.a.reviewedSource.rig?.sha256??null,data.b.reviewedSource.rig?.sha256??null]};}
572
577
  function inspectionBookmark():InspectionBookmark {return {schema:'rig-review-inspection/1',binding:inspectionBinding(),animation:data.animation,time:trace?.reference??presentation.snapshot().lastDrawn?.reference??null,theme:appearance?.get()??'system',layers:{images:layers.images,meshes:layers.mesh,bones:layers.bones},view:numericView(),selection:{...(turnPad?{turn:turnPad.snapshot()}:{}),part:parts?.value()??null,reference:data.reference.sha256,inspector:document.querySelector<HTMLElement>('[data-inspector][aria-selected=true]')?.dataset.inspector??'view',mode:pickedTools?.mode()??'compare',side:pickedTools?.pickedSide()??'a'}};}
573
578
  async function restoreInspection(bookmark:InspectionBookmark,signal:AbortSignal):Promise<void> {
@@ -588,7 +593,7 @@ async function applyInspection(bookmark:InspectionBookmark,signal:AbortSignal):P
588
593
  parts?.select(bookmark.selection.part??null);
589
594
  idleHeld=true;stop();if(bookmark.time!==null){await seekTo(bookmark.time);if(signal.aborted||!trace)throw new Error('Saved reference inspection could not settle');}
590
595
  appearance?.set(bookmark.theme);Object.assign(layers,{images:bookmark.layers.images,mesh:bookmark.layers.meshes,bones:bookmark.layers.bones});input('layer-images').checked=layers.images;input('layer-mesh').checked=layers.mesh;input('layer-bones').checked=layers.bones;
591
- if(bookmark.selection.inspector){workspace?.beforeTab();for(const tab of document.querySelectorAll<HTMLButtonElement>('[data-inspector]')){const selected=tab.dataset.inspector===bookmark.selection.inspector;tab.setAttribute('aria-selected',String(selected));tab.tabIndex=selected?0:-1;}for(const panel of document.querySelectorAll<HTMLElement>('[data-inspector-panel]'))panel.hidden=panel.dataset.inspectorPanel!==bookmark.selection.inspector;workspace?.afterTab();}
596
+ if(bookmark.selection.inspector){workspace?.beforeTab();inspectorTabs?.restore(bookmark.selection.inspector);workspace?.afterTab();}
592
597
  if(typeof pickedTools!=='undefined'&&pickedTools){if(bookmark.selection.side==='a'||bookmark.selection.side==='b')pickedTools.setPickedSide(bookmark.selection.side);const nextMode=bookmark.selection.mode??(bookmark.selection.inspector==='rig'?'setup':bookmark.selection.inspector==='playback'?'animate':'compare');pickedTools.setMode(nextMode,{fromTab:true});}
593
598
  syncStageLayout(el('stage-layout'));fit();
594
599
  for(const target of ['a','b','reference'] as const){const camera=bookmark.view.cameras[target],frame=paneFrame(target,true);if(camera&&frame)cameras[target]={zoom:restoredZoom(camera,frame.baseScale,frame.width,frame.height),center:{...camera.center}};}
package/web/cuts-panel.ts CHANGED
@@ -19,7 +19,7 @@ import {
19
19
  } from '../src/cut-edits.ts';
20
20
  import {canvasToCrop} from './chest-editor.ts';
21
21
  import type {OverlayMarker,OverlayPoint,OverlayProject,OverlayRegion} from './rig-overlays.ts';
22
- import {textEntryFocused} from './view-controls.ts';
22
+ import {panelNode as node,panelMake as make,textEntryFocused} from './view-controls.ts';
23
23
  import type {PatchJobView,RebuildRefusal} from './rebuild-client.ts';
24
24
 
25
25
  export interface CutsPanelDeps {
@@ -50,8 +50,6 @@ export interface CutsPanel {
50
50
  status(text:string,error:boolean):void;busy(value:boolean):void;
51
51
  restore():void;clear():void;sync():void;dispose():void;
52
52
  }
53
- const node=<T extends HTMLElement>(id:string)=>{const found=document.getElementById(id);if(!found)throw new Error(`Missing UI element: ${id}`);return found as T;};
54
- const make=<K extends keyof HTMLElementTagNameMap>(tag:K,props:Record<string,unknown>={},...children:(Node|string)[]):HTMLElementTagNameMap[K]=>{const item=document.createElement(tag);Object.assign(item,props);item.append(...children);return item;};
55
53
  const fmt=(p:readonly number[])=>`[${p.join(', ')}]`;
56
54
  /** The handle under the pointer (canvas px), within 9 px; the nearest wins. */
57
55
  export function hitHandle(points:readonly {id:string;at:OverlayPoint}[],p:OverlayPoint):string|null {
@@ -6,6 +6,7 @@
6
6
  * verbatim). The two labels name rows; the table has no Apply. Load puts a built row on the stage as pending (the
7
7
  * Mesh panel's Apply then applies it, reusing its build); Refine between builds the next strip inside two rows.
8
8
  */
9
+ import {panelNode as node,panelMake as make} from './view-controls.ts';
9
10
  import {barText,densityField,densityPath,refineValues,stripValues,type DensityField,type StripRow} from '../src/density-strip.ts';
10
11
  import {entryValue,type MeshEntry} from '../src/mesh-entry.ts';
11
12
 
@@ -26,8 +27,6 @@ export interface DensityStripPanel {
26
27
  show(view:DensityStripViewLike|null,pending:number|null,busy:boolean):void;
27
28
  status(text:string,error:boolean):void;
28
29
  }
29
- const node=<T extends HTMLElement>(id:string)=>{const found=document.getElementById(id);if(!found)throw new Error(`Missing UI element: ${id}`);return found as T;};
30
- const make=<K extends keyof HTMLElementTagNameMap>(tag:K,props:Record<string,unknown>={},...children:(Node|string)[]):HTMLElementTagNameMap[K]=>{const item=document.createElement(tag);Object.assign(item,props);item.append(...children);return item;};
31
30
  const fieldLabel=(f:DensityField)=>f==='grid'?'grid':'contour.spacing';
32
31
 
33
32
  export function bindDensityStrip(host:DensityStripHost):DensityStripPanel {
package/web/i18n.ts CHANGED
@@ -180,6 +180,14 @@ function ensureMaps(): { enToKo: Map<string, string>; koToEn: Map<string, string
180
180
  koToEnMap.set(ko, en);
181
181
  }
182
182
  }
183
+ // Semantic keys have display values too; already rendered refusals must round-trip without expanding the key again.
184
+ for (const [key, english] of Object.entries(enCatalog)) {
185
+ if (english === key) continue;
186
+ const korean = koCatalog[key];
187
+ if (korean === undefined) continue;
188
+ enToKoMap.set(english, korean);
189
+ koToEnMap.set(korean, english);
190
+ }
183
191
  for (const [en, ko] of Object.entries(koCatalog)) {
184
192
  if (en.startsWith(' · ') && ko.startsWith(' · ')) {
185
193
  const enSub = en.slice(3);
@@ -413,6 +421,7 @@ function shouldTranslateCapturedArg(arg: string, lang: ResolvedLanguage): boolea
413
421
  function translateCore(text: string, lang: ResolvedLanguage, depth: number): string {
414
422
  if (!text || depth > 4) return text;
415
423
  if (lang === 'ko') {
424
+ if (getKoToEnMap().has(text)) return text;
416
425
  const exact = getEnToKoMap().get(text);
417
426
  if (exact !== undefined) return exact;
418
427
  } else {
@@ -573,6 +582,7 @@ const CONTEXT_LOWER_KEYS = new Set([
573
582
  function isExemptElement(el: Element | null): boolean {
574
583
  let cur: Element | null = el;
575
584
  while (cur) {
585
+ if (cur.getAttribute?.('translate') === 'no') return true;
576
586
  const id = cur.id;
577
587
  if (
578
588
  id === 'target-names' ||
@@ -593,7 +603,9 @@ function isExemptElement(el: Element | null): boolean {
593
603
  cls.includes('animation-lane-label') ||
594
604
  cls.includes('animation-tree-bone-name') ||
595
605
  cls.includes('stage-comment-pin') ||
596
- cls.includes('stage-hover-label')
606
+ cls.includes('stage-hover-label') ||
607
+ // The interview modal localizes its own chrome and never rewrites agent-authored prompts or options (#708).
608
+ cls.includes('interview-modal')
597
609
  ) {
598
610
  return true;
599
611
  }
package/web/idle-panel.ts CHANGED
@@ -7,6 +7,7 @@
7
7
  * "preview — Apply decides"; it is cleared on Apply and Reset and is never recorded: the source draft keeps only the
8
8
  * pending ops (`#idle-pending`) and the panel's own inputs carry no ids.
9
9
  */
10
+ import {panelNode as node,panelMake as make} from './view-controls.ts';
10
11
  import {AMP_RANGE,addTrack,entryChanged,idleDraftState,idleDraftText,idleOps,initialState,isChain,orderedEntries,periodFits,periodOffers,precheck,previewPlan,removeTrack,setBlink,stateFromOps,setField,setLinkAmp,SINGLE_PROPS,type BlinkField,type ChainField,type IdleKeying,type IdleSource,type IdleState,type IdleStatus,type PreviewPlan,type SingleField} from '../src/idle-tracks.ts';
11
12
  import {scrubBox} from './scrub-box.ts';
12
13
  import type {PatchOp} from '../src/config-patch.ts';
@@ -51,8 +52,6 @@ export interface IdlePanel {
51
52
  dispose():void;
52
53
  }
53
54
 
54
- const node=<T extends HTMLElement>(id:string)=>{const found=document.getElementById(id);if(!found)throw new Error(`Missing UI element: ${id}`);return found as T;};
55
- const make=<K extends keyof HTMLElementTagNameMap>(tag:K,props:Record<string,unknown>={},...children:(Node|string)[]):HTMLElementTagNameMap[K]=>{const item=document.createElement(tag);Object.assign(item,props);item.append(...children);return item;};
56
55
  const shown=(value:number|undefined)=>value===undefined?'—':String(Number(value.toPrecision(6)));
57
56
  export const PREVIEW_LABEL='preview — Apply decides';
58
57
  /** Degrees of amplitude per pane pixel dragged on a chain handle. */