rig-review 2.12.0 → 2.13.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/docs/DESIGN.md +82 -71
- package/docs/PANELS.md +20 -12
- package/docs/PARTS_VIEW.md +31 -11
- package/docs/REVIEW_PACKAGE.md +99 -9
- package/docs/STABILITY.md +74 -3
- package/docs/WORKFLOWS.md +40 -12
- package/package.json +2 -1
- package/skills/rig-review/SKILL.md +29 -1
- package/src/build.ts +10 -2
- package/src/cli.ts +14 -12
- package/src/compare-html.ts +22 -24
- package/src/compare-server.ts +1 -1
- package/src/create-pin-gate.ts +3 -0
- package/src/feedback-export.ts +49 -1
- package/src/front.ts +10 -16
- package/src/interview-routes.ts +1 -1
- package/src/job-act.ts +39 -21
- package/src/job-api.ts +102 -11
- package/src/job-contract.ts +44 -4
- package/src/job-front.ts +15 -7
- package/src/job-host.ts +4 -3
- package/src/job-hub.ts +4 -4
- package/src/job-session.ts +5 -2
- package/src/job-source.ts +42 -13
- package/src/joined-project.ts +61 -4
- package/src/open-workspace.ts +12 -12
- package/src/open.ts +17 -9
- package/src/parts-comment.ts +31 -1
- package/src/parts-server.ts +19 -7
- package/src/parts-view.ts +71 -20
- package/src/server.ts +30 -21
- package/src/stage-comment.ts +11 -1
- package/src/stage-parts.ts +18 -10
- package/web/animation-inspection.ts +1 -1
- package/web/bones-panel.ts +1 -3
- package/web/catalog-en.ts +76 -12
- package/web/catalog-ko.ts +76 -12
- package/web/cloth-panel.ts +1 -2
- package/web/compare.css +3 -9
- package/web/compare.html +3 -3
- package/web/compare.ts +69 -64
- package/web/cuts-panel.ts +1 -3
- package/web/density-strip-panel.ts +1 -2
- package/web/i18n.ts +13 -1
- package/web/idle-panel.ts +1 -2
- package/web/index.html +1 -5
- package/web/inspection-persistence.ts +2 -1
- package/web/inspector-blocks.ts +144 -39
- package/web/instance-access.ts +24 -5
- package/web/interview-panel.ts +224 -175
- package/web/job-hub.ts +50 -69
- package/web/job-rig-capture.ts +103 -10
- package/web/job-rig-screen.ts +317 -0
- package/web/job-session.ts +927 -1365
- package/web/main.ts +535 -129
- package/web/mesh-panel.ts +1 -2
- package/web/owner-workspace.ts +88 -109
- package/web/part-selection.ts +47 -6
- package/web/part-thumbnails.ts +20 -6
- package/web/parts-viewport-provider.ts +166 -9
- package/web/physics-panel.ts +1 -2
- package/web/readings-panel.ts +1 -2
- package/web/requirements-panel.ts +1 -3
- package/web/retained-frame-stage.ts +105 -0
- package/web/retarget-panel.ts +2 -3
- package/web/rig-fields-panel.ts +1 -2
- package/web/rig-host.ts +62 -0
- package/web/rig-viewport-provider.ts +63 -16
- package/web/stage-comments.ts +29 -26
- package/web/styles.css +127 -43
- package/web/view-controls.ts +201 -12
- package/web/viewport-controller.ts +97 -26
- package/web/viewport-pair.ts +2 -1
- package/web/workspace-preferences.ts +5 -4
- package/web/workspace-ui.ts +152 -19
- package/src/interview-server.ts +0 -54
- package/web/interview.css +0 -28
- package/web/interview.html +0 -17
- package/web/interview.ts +0 -40
- package/web/job-hub.css +0 -14
- package/web/job-hub.html +0 -5
- package/web/owner-workspace.css +0 -14
- package/web/owner-workspace.html +0 -5
- package/web/parts-flags.ts +0 -48
- package/web/parts-page.ts +0 -217
- package/web/parts.css +0 -116
- package/web/parts.html +0 -15
- package/web/parts.ts +0 -986
- package/web/stage-nav.ts +0 -136
package/docs/DESIGN.md
CHANGED
|
@@ -4,13 +4,18 @@
|
|
|
4
4
|
|
|
5
5
|
The delivery unit is an existing output folder or an optional curated review package handed from an agent to a person. This reusable app owns inspection, reference comparison, annotations and feedback export. Upstream compiler, splitter and runtime remain their respective tools. The existing producing agent needs no change to open its output here.
|
|
6
6
|
|
|
7
|
-
The person uses
|
|
7
|
+
The person uses the existing inspection workspace. The header **Setup · Animate · Compare** is the sole mode switch; the resizable bottom panel shows the current mode's blocks plus **Comments (n)**, with the act bar at the right of that row (#741). Parts packages use this same screen (#745). Header Compare retains its existing A/B comparison with a reference, enabled when a second build is supplied; its View, Rig, Playback and Feedback sections remain unchanged. Card D is **PARKED**, not planned. Setup already offers Difference as the fourth view item for parts (#745) and rig (#752). Setup covers setup geometry, source art, pivot/joint placement, meshes, weights and draw order; Animate covers angle coverage, frame intervals, reference video/poses, contact/deformation, audio inspection and the inspection environment (wind, gravity and impulses through the published player's `environment`/`moved`; its state is feedback context, never a model or motion edit) and the physics tuning panel (#103: constraint values edited as config patch ops and applied through the producer, never written into the model by review), and the readings block (#108: the compiler's own `rigc render` readings of the drawn animation, run on the inspected build and on the latest scratch build, shown as timeline ticks and worst-frame lines), the Environment block's *Use for readings* (#112: the controls exported as a `rigc-environment/1` schedule that readings, Apply's check and *Check under this world* — the installed producer's `rig-parts check --environment` — read, so the bars and readings are taken under the wind the person watched; the schedule is feedback context and is never authored into the rig), and the requirements block (#113: the scene's declared requirements written as a `spine-parts-requirements/1` file and measured by the installed producer's `rig-parts check --requirements`, one worst-frame line each). Time/angle controls navigate inspection. Timeline edits are six typed keyed operations on a scratch copy of `motion.animations_from`, built by the installed producer; review never writes source motion. Implemented modeling instruments send bounded changes through the installed producer into scratch, including setup-space mesh deltas.
|
|
8
8
|
|
|
9
9
|
## Core UI rules (owner, 2026-11-11)
|
|
10
10
|
|
|
11
11
|
These rules govern every Review view and all job kinds, including parts, interview,
|
|
12
12
|
plan, checkpoint, rig, direction, image review and signoff.
|
|
13
13
|
|
|
14
|
+
These are requirements, not a claim that every legacy host has migrated.
|
|
15
|
+
[Screen specification](https://github.com/rig-c/review/blob/main/docs/SCREENS.md) separates shipped behavior at main `22d824f`
|
|
16
|
+
from remaining B (#722), C (#715), F (#734) and #756 work. This documentation
|
|
17
|
+
change adds no screen, behavior or public contract.
|
|
18
|
+
|
|
14
19
|
- **R0** Every Review UI addition or change requires the owner's ruling twice.
|
|
15
20
|
The owner rules on the layout before implementation and on the working screen
|
|
16
21
|
before merge. Show both through the Review tool or a local page. Chat images
|
|
@@ -25,13 +30,40 @@ plan, checkpoint, rig, direction, image review and signoff.
|
|
|
25
30
|
any number of comments. Each comment can be general or pinned to an image
|
|
26
31
|
point, region, part, frame or checkpoint. Keep pointed image comments through
|
|
27
32
|
`stage-comments.ts` and `parts-comment-crops.ts` with their source-bound evidence.
|
|
28
|
-
Remove separate memo, note, per-part note, summary and `words` input
|
|
29
|
-
|
|
33
|
+
Remove separate memo, note, per-part note, summary and `words` feedback input
|
|
34
|
+
surfaces. Survey answers are a separate input kind. Preserve interview
|
|
35
|
+
selections, inline Other text and per-question note inputs through the existing
|
|
36
|
+
interview answer contract. R2 applies to feedback inputs.
|
|
30
37
|
- **R3** Inspection uses the main view's Difference switch to cover all regions.
|
|
31
38
|
Remove separate sidebar key-region checkpoint and evidence panels. Retain the
|
|
32
39
|
supported checkpoint act flow through its existing contract.
|
|
40
|
+
- **R3a** Any main view in rig, comparison, parts, job, interview or package review
|
|
41
|
+
has a resizable bottom panel directly beneath it. Use one control set in this
|
|
42
|
+
order: **Zoom in → Zoom out → Fit → 1:1 → View switch**, with the same names and
|
|
43
|
+
behavior across views. Use the shared viewport implementation and extend it
|
|
44
|
+
for missing behavior. Keep main-view code shared across screens.
|
|
33
45
|
- **R4** All view areas share zoom, Fit, 1:1 and resize behavior through the existing
|
|
34
46
|
viewport modules. Extend the shared modules for a missing capability.
|
|
47
|
+
- **R5** `web/index.html` is the single web entry for every screen, including rig,
|
|
48
|
+
comparison, parts, interview, package, job, hub and owner workspaces. Compose
|
|
49
|
+
these screens from a shared workspace shell, main view (viewport and controls),
|
|
50
|
+
resizable bottom and side panels, main and secondary toolbars, view switcher,
|
|
51
|
+
inspector and comments components. Do not introduce a screen through a new
|
|
52
|
+
HTML page or per-screen server route. Preserve existing public job, hub,
|
|
53
|
+
language and capability URLs as redirects or routes into the single entry.
|
|
54
|
+
The owner rules on the shared shell layout before implementation.
|
|
55
|
+
|
|
56
|
+
The main-view consistency requirement is retained verbatim.
|
|
57
|
+
|
|
58
|
+
```text
|
|
59
|
+
메인 뷰를 넣을거면 기준을 항상 규일하게 가져가(지침) * 메인뷰 하단 패널 리사이즈 * 뷰전환 기능 통일, * 에인뷰 코드가 하나가 아니라 여러개 복붙인지 확인
|
|
60
|
+
```
|
|
61
|
+
|
|
62
|
+
The single-entry architecture requirement is retained verbatim.
|
|
63
|
+
|
|
64
|
+
```text
|
|
65
|
+
뷰는 index.html 단일 진입점 하나고, 컴포넌트 조합으로 화면을 만들어내(ide like) 이거 안되면 진도 빼는거 의미없어, 이미 열린 헬 게이트를 더 활짝 여는 꼴이라고
|
|
66
|
+
```
|
|
35
67
|
|
|
36
68
|
Act-field and downstream-consumer changes follow the existing HQ approval boundary
|
|
37
69
|
for public contracts. Preserve historical record parsing, source binding and
|
|
@@ -60,6 +92,12 @@ The owner's comments clarification is retained verbatim.
|
|
|
60
92
|
코멘트가 왜 하나야? 미친거야?
|
|
61
93
|
```
|
|
62
94
|
|
|
95
|
+
The owner's survey and comment distinction is retained verbatim.
|
|
96
|
+
|
|
97
|
+
```text
|
|
98
|
+
설문과 코멘트는 다른 종류의 입력이야 / 설문은 여기 어떻게 할까요? 이고 / 코멘트는 유저가 여기 이상하니까 꼬쳐주세요! 라는 의미
|
|
99
|
+
```
|
|
100
|
+
|
|
63
101
|
The earlier shared-view requirement is also retained verbatim.
|
|
64
102
|
|
|
65
103
|
```text
|
|
@@ -117,8 +155,8 @@ Any future modeling edit needs provenance, undo/redo, explicit units and an expo
|
|
|
117
155
|
The single review page is one inspection workspace: a left column, the stage, the Inspector under the stage and one status footer. There is no right panel.
|
|
118
156
|
|
|
119
157
|
- **Left column.** A fixed header row (Parts title and slot search on one line; the search's name, *Find slot*, is its `aria-label`) and one scrolling body. Nothing sits above the header and it never scrolls. The body holds the reference select, the part list and browser Settings; it is the column's only scroll container. Region coverage and Difference inspection stay in the main view under R3. Settings opens and closes from its own header (`#settings-toggle`, `aria-expanded`, controlling `#settings-body`); it starts collapsed and the state is a browser preference.
|
|
120
|
-
- **Header.**
|
|
121
|
-
- **View bars.**
|
|
158
|
+
- **Header.** **Setup · Animate · Compare** sits next to the package title and is the only mode switch (#741). Setup and Animate keep their existing `rig` / `playback` mode IDs. Compare is enabled with a second build and retains A/B with a reference; card D is parked. There is no second mode selector in the bottom panel. The pending ask is shown beside the act bar. **Historical:** numbered step chips and `stage-nav.ts` were removed; they must not be restored.
|
|
159
|
+
- **View bars.** The main row holds Comment, camera sync and the shared controls in order: **Zoom in → Zoom out → Fit → 1:1 → View switch**, then zoom value. The separate secondary row holds layers and subject tools. `inspectionViewSwitch` in `view-controls.ts` defines **Side by side · Reference · Rig**, followed by **Difference** in Setup (#745 parts, #752 rig). Difference is disabled by name without a usable original reference; parts also require the declared rig-space painting operand, and rigs require a painting aligned to the native rig canvas. Outside Setup, rig Difference names `RIG_DIFFERENCE_SETUP_ONLY`. Compare retains its existing Side by side / Reference / Build A / Build B menu and legacy controls. Parts Overlay and Part opacity live in the secondary toolbar, not a grouped view menu. Appearance stays in Settings; numeric view state stays behind **View region**.
|
|
122
160
|
- **Panel headers and scrolling.** The left column's header is a fixed row outside its scrolling body. The Inspector heading, the Settings title and each drawer's header (title and close) carry `.sticky-header` and are their panel's first child, so the body scrolls beneath them. Every scrolling region shares one thin scrollbar rule on `*` whose colours are the `--rv-scrollbar-*` tokens. Resize separators are drawn 4px with a 16px transparent hit area (22px on coarse pointers) and use `--rv-separator` / `--rv-separator-hover`, never a scrollbar colour.
|
|
123
161
|
- **Chest-region editor.** In Setup only, the view bar's **Chest regions** toggle (`#chest-edit`, `aria-pressed`) opens `#chest-editor-bar` under the view bar: R / L groups (X, Y, R, Band), Mirror R → L, Download JSON, **Apply · Rebuild** and **Reset**. Apply sends the rows to the installed producer (`rig-parts remesh` on that part, then `rigc build`) through `POST /api/rebuild` (`src/rebuild.ts`, `src/producer.ts`) and loads the compiled scratch build in place; the producer's lines stream into `#chest-editor-status` and `#chest-editor-log`, a refusal shows its first named line verbatim, and Reset returns to the inspected build (README, *Chest regions*). The circles, their centre / core / band handles and labels are drawn on `#rig-overlay` through the crop → world mapping; handle drags (move, r, band) are clamped live with the example rebuild script's non-overlap rule (`CHEST_REGIONS_CLAMPED`) and never move the camera, while other drags and Space-drags pan. The values are the Setup **Chest regions · detail** block's fields, so its draft, export and binding apply unchanged; the block keeps names, bones, semi-axes, clip and the contour. Review builds no mesh: the rebuild is the producer's, into scratch under the state directory, never into the package. A **Circles** / **Landmarks** switch (`#bust-mode`, a hidden input the draft keeps) selects what Apply sends: Landmarks (#105) places the right apex, left apex and cleavage with draggable markers (`#lm-*`), alpha and clearance sliders and optional bone names, draws the producer's derived `bust_r` / `bust_l` live (`src/chest-landmarks.ts`, a transcription of parts' `deriveBustRegions`) and sends `{part, bust, configHash}`; review pre-checks only `CONFIG_BUST_CLEARANCE` and leaves bones and names to the producer.
|
|
124
162
|
- **Mesh panel.** In Setup, after Chest regions · detail: `#mesh-panel` for the selected mesh part — mode-specific sliders with number fields (`#mesh-params`), regions (`#mesh-regions`; **Add circle**, **Draw polygon** and **Drag on stage** with `aria-pressed`), segments (`#mesh-segments`, bones from the loaded model, ribs stations per chain), the pending diff (`#mesh-diff`), the pre-check (`#mesh-precheck`), **Apply** / **Reset** / **Folds reading**, the status (`#mesh-status`), the counts (`#mesh-counts`) and the `TEXTURE_STRETCH` readout (`#mesh-readout`). Region colours are theme tokens (`--rv-mesh-region`, `--rv-mesh-region-fill`, `--rv-mesh-handle`).
|
|
@@ -127,8 +165,8 @@ The single review page is one inspection workspace: a left column, the stage, th
|
|
|
127
165
|
- **Rig fields.** In Setup, after Bones: `#rig-fields` (#110). The producer config's small fields as patch ops at their own pointers (`src/rig-fields.ts`, `web/rig-fields-panel.ts`): a rigid part's bone (`/regions/<part>`, a select), a lash's blink still row (`/motion/blink/still/<part>`, a dashed line across the part dragged in whole rig px), a stop's inward / outward bounds (`/stops/<i>`, two filled arcs at the pivot around a dashed rest aim, their ends dragged in whole degrees), an inherit mode per bone (`/bones/<i>/inherit`, a chain's `link_inherit`) and `turn`'s pivot and per-part depth (`/turn/pivot`, `/turn/depths/<part>`, sliders). Stage handles live in `#rig-fields-stage` over the rig viewport (tokens `--rv-field-still`, `-inward`, `-inward-line`, `-outward`, `-outward-line`, `-rest`, `-handle-bg`, `-ink`; the stage stays dark, so both blocks carry the same values). The turn dial holds the drawn build's `turn` bone at x through play's `adjust`, composed with the idle preview, and shows `#rig-fields-dial-label` (*preview — Apply decides*); it is never recorded. Apply is the generic runner's whole-rig `rig` op behind the reproduced baseline; the readout quotes `BLINK_NO_HOLE` and `FEET_STAY_LEVEL` before and after, and **Angle range** runs one #108 reading. Adding a stop and `turn.deform` are out of scope.
|
|
128
166
|
- **Cloth.** In Setup, after Cuts: `#cloth-panel` (#111). One form per cloth tag the installed reader accepts (`bottomwear`, `back hair`, `front hair` — its own `CLOTH_TARGETS`), holding the recipe's fields as the config states them; each change is a patch op at `/cloth/<tag>/…` (`src/cloth-recipe.ts`, `web/cloth-panel.ts`). **Show links** draws, in rig px of the setup pose, every chain the tag's parts are meshed on from the config's `points` and `tip`, and after an Apply the chains of the config the producer wrote (one label per set). Apply runs `rig-parts propose --cloth --write-config` on the declared parts, painting and keypoints, then builds the written config (`build` when the config declares `limbs`, else `rig --config`) and reloads it under the stage's Environment. Review never merges the producer's draft: it reads only the written config, lists where it differs from its input and refuses one that differs outside the drafted sections. Hand-editing the drafted constraints is the physics block's, after the draft.
|
|
129
167
|
- **Mesh edit.** In Setup only, the view bar's **Edit mesh** toggle (`#mesh-edit`, `aria-pressed`) opens `#mesh-editor-bar`: sub-modes Modify / Create / Delete / Edges (keys `V` / `C` / `X` / `E`, one pressed), Undo, Redo, Reset, Download JSON and **Apply · Rebuild** (#135: `rig-parts remesh --delta` through the shared runner, the revision loaded in place, the producer's refusal verbatim; while a delta revision is on the stage Reset returns to the inspected build). A package without the compiled model document refuses `MESH_EDIT_MODEL_UNAVAILABLE` and does not open; whole rig refuses `MESH_EDIT_SELECT_SLOT`; a non-mesh or linked-mesh slot `MESH_EDIT_NO_MESH <slot>`. It edits in setup space (#100): the attachment's stored provenance in the model document (`src/setup-mesh.ts`) and geometry from Play's public `readSetupMesh` (`web/setup-pose.ts`, shared with Weights) and drawn over the paused stage with the stage camera. It records a typed delta (`src/mesh-edit.ts`, `basis: "setup"`, the shape `rig-parts remesh --delta` reads) and previews it over the original triangulation on the overlay; Delete removes only constraint edges the delta added (the triangulation is the producer's); it is not a mesher and never retriangulates, writes the package or runs a producer. The chest editor and mesh edit are exclusive: turning one on turns the other off.
|
|
130
|
-
- **Inspector.**
|
|
131
|
-
- **Review dialog.**
|
|
168
|
+
- **Inspector.** The shared bottom panel sits directly under the main view, with saved height and a resizable separator. Header mode selects its content; its tab row remains reachable when content is collapsed. Setup has Part · Modeling · Chest · Mesh · Weights · Bones · Fields · Cuts · Cloth; Animate has Transport · Sound · Environment · Physics · Idle tracks · Readings · Requirements · Retarget · Report and the existing timeline. Each mode appends the same **Comments (n)** tab, and the act bar stays at the right of that row (#741). Parts use Part and Comments; rig-only blocks are disabled with a missing-rig reason. `mountRigInspector`, `bindInspectorBlocks` and `mountBottomPanel` reuse the existing blocks, preserve their state and keep one Comments button/panel across modes. Block navigation does not apply or submit.
|
|
169
|
+
- **Review dialog.** This label is historical for rig feedback: `mountRigInspector` moves its existing source context, comments, frame range, category, typed target, correction request, provenance, strip downloads and warnings into **Comments (n)** and removes `#review-dialog`. The decision, submit and save state live in the act bar. Record publications separately reuse existing checkpoint, signoff, reopen and interview forms in a native dialog over this same screen (#754), including an explicitly empty workspace when no picture is supplied. That hosting has shipped; remaining interview-modal work B (#722), record-modal memo-to-Comments work C (#715), and legacy job-window owner-surface removal (#756) have not.
|
|
132
170
|
- **Footer.** Message (truncated, full text as tooltip) on the left; player, effective layout, renderer, layers, idle, remote control and draft state in the middle; the numeric view region (behind **View region**) and the source hash on the right. The View region body is a `position:fixed` popover above the 40px footer, right-aligned, its width and height clamped to the viewport and its content scrolling inside, so the footer's clipping never hides it and opening it never scrolls the page.
|
|
133
171
|
|
|
134
172
|
The compare page keeps its own markup and stylesheet: sources left, Parts explorer right, its four Inspector sections, its export buttons and its separator colour. It shares the workspace coordinator, so its separators are drawn at the same 4px.
|
|
@@ -209,82 +247,55 @@ Single review keeps the requested layout in the source-bound draft and shows it
|
|
|
209
247
|
|
|
210
248
|
## Four inspection stages
|
|
211
249
|
|
|
212
|
-
|
|
213
|
-
|
|
214
|
-
|
|
215
|
-
|
|
216
|
-
|
|
250
|
+
**Historical, superseded by #741:** the numbered Parts + mesh, Interview,
|
|
251
|
+
Rig + animation and Direction navigation was removed. This heading remains for
|
|
252
|
+
inbound links. Pipeline stages are internal and never another user mode switch.
|
|
253
|
+
The header selects Setup, Animate or the existing Compare; a pending ask is text
|
|
254
|
+
beside the act bar. Selecting a mode never applies, approves or submits.
|
|
217
255
|
|
|
218
256
|
### Standing live job boundary
|
|
219
257
|
|
|
220
|
-
|
|
221
|
-
|
|
222
|
-
|
|
223
|
-
|
|
224
|
-
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
230
|
-
|
|
231
|
-
|
|
232
|
-
|
|
233
|
-
|
|
234
|
-
|
|
235
|
-
|
|
236
|
-
|
|
237
|
-
|
|
238
|
-
|
|
239
|
-
|
|
240
|
-
|
|
241
|
-
|
|
242
|
-
|
|
243
|
-
a checked scratch revision. Each entry reloads against that explicit build ID;
|
|
244
|
-
a pending candidate or the server's unrelated latest build is never substituted.
|
|
245
|
-
Reset returns to the inspected revision. New scratch reads and made-mesh feedback
|
|
246
|
-
submissions recheck pinned producer inputs, revision files and compiled files.
|
|
247
|
-
A changed scratch input cannot inherit clean checked evidence.
|
|
248
|
-
|
|
249
|
-
The embedding is read-only: original verdicts and comments are never copied onto
|
|
250
|
-
scratch geometry or saved by navigating. Use the standalone `parts` command for
|
|
251
|
-
its separate explicit original-parts sign-off. Parts-only inputs remain
|
|
252
|
-
inspectable and name `STAGE_DRAFT_UNAVAILABLE` for direct correction. A missing
|
|
253
|
-
handoff keeps the inspected atlas available where supplied. Compare retains its
|
|
254
|
-
read-only, side-specific inspected atlas. Neither flow guesses a sibling draft.
|
|
255
|
-
|
|
256
|
-
Named draft boundaries are `STAGE_DRAFT_UNAVAILABLE`, `STAGE_DRAFT_MISMATCH`,
|
|
257
|
-
`STAGE_DRAFT_STALE`, `STAGE_DRAFT_CHANGED`, `STAGE_DRAFT_UNCHECKED` and
|
|
258
|
-
`STAGE_DRAFT_OPERATION`. Producer discovery and its named missing/old-producer
|
|
259
|
-
refusals are unchanged; Review never installs a producer. Correction-record
|
|
260
|
-
export remains unavailable pending review#369 and create#91. Existing reviewer
|
|
261
|
-
requests remain verbatim in their existing feedback/comment contracts; there
|
|
262
|
-
is no fake Apply for art repair.
|
|
263
|
-
|
|
264
|
-
Only Stage 3 shows the legacy Setup, Animate and Compare switch; its existing
|
|
265
|
-
instruments, DOM and mode IDs are retained. In Stage 1 a compare session keeps
|
|
266
|
-
the A/B source picker usable and shows the selected side's cached atlas frame.
|
|
267
|
-
**Open setup mesh instruments** returns from the atlas to Setup; it does not
|
|
268
|
-
rebuild. Existing bookmarks, Apply/Reset provenance, selected slot, compare side,
|
|
269
|
-
time, pending edits and applied build stay owned by those original tools. Stage
|
|
270
|
-
changes retain the original workspace and each compare side's atlas controller.
|
|
271
|
-
Single draft frames are rebound on revision changes. Language changes update retained
|
|
272
|
-
frames without applying or submitting.
|
|
273
|
-
The parts-only entry retains its part selection, geometry and pending verdict
|
|
274
|
-
while visiting unavailable stages; it needs no compiled model.
|
|
275
|
-
|
|
258
|
+
The standing Review window hosts published subjects on the existing inspection
|
|
259
|
+
screen. Rig and parts use its shared viewport and bottom panel. Record
|
|
260
|
+
checkpoint, signoff, reopen and interview asks use existing forms in a dialog
|
|
261
|
+
(#754). A record without a picture keeps that absence explicit; it does not
|
|
262
|
+
manufacture a model or package. Remaining B (#722), C (#715), F (#734) and #756
|
|
263
|
+
work is tracked in [the screen specification](https://github.com/rig-c/review/blob/main/docs/SCREENS.md#4-migration-order).
|
|
264
|
+
|
|
265
|
+
People submit decisions through Review's UI; agents use semantic `publish`,
|
|
266
|
+
`ask`, `next` and `close`, and consumer writers fetch finalized acts directly.
|
|
267
|
+
Opening or navigating never approves. Preserve reviewer authority, exact
|
|
268
|
+
source binding, publication freeze, generation checks, replay and recorded text.
|
|
269
|
+
A UI requirement does not authorize changing those public contracts or carrying
|
|
270
|
+
internal Review state as an agent handoff.
|
|
271
|
+
|
|
272
|
+
The [live job contract](REVIEW_PACKAGE.md#live-job-contract), including
|
|
273
|
+
[record mode](REVIEW_PACKAGE.md#model-free-record-mode-and-source-seam), and
|
|
274
|
+
[public API stability](STABILITY.md) own the schemas, fields and compatibility
|
|
275
|
+
rules. [Standing live job workflow](WORKFLOWS.md#standing-live-job-workflow)
|
|
276
|
+
owns the agent cycle. Historical stage-draft formats and named refusals remain
|
|
277
|
+
in [Stage-1 draft mesh inspection](REVIEW_PACKAGE.md#stage-1-draft-mesh-inspection);
|
|
278
|
+
they do not restore removed navigation or a second parts screen. Supplied inputs
|
|
279
|
+
and compiled models remain immutable, and precision edits still reach the
|
|
280
|
+
installed producer as data for a scratch rebuild.
|
|
276
281
|
|
|
277
282
|
## Shared parts viewport and comments
|
|
278
283
|
|
|
279
|
-
|
|
280
|
-
rig/reference DOM
|
|
284
|
+
Parts-only packages open the existing Setup screen, using `viewport-pair.ts`'s
|
|
285
|
+
actual rig/reference DOM (#745). They reuse `PartExplorer`, the toolbars,
|
|
286
|
+
resizable bottom panel, Comments and act bar rather than a standalone parts page. `parts-viewport-provider.ts` supplies raster geometry and painting-crop pixels;
|
|
281
287
|
`viewport-controller.ts` and `view-controls.ts` own camera writes, cursor zoom, pan, fit, resize
|
|
282
288
|
and the common two-pointer pinch. Parts' native scale policy is separate from the unchanged
|
|
283
289
|
compiled-rig Fit-relative policy. `parts-render.ts` remains the source of part, footprint and
|
|
284
290
|
mesh painting. The optional protected `--painting` input supplies the real reference crop;
|
|
285
|
-
|
|
291
|
+
Side by side and adjustable-opacity Overlay share the original painting
|
|
286
292
|
transform from declared rig/source canvas geometry, with exact fractional placement. This is a visual
|
|
287
293
|
comparison using browser interpolation, not native pixel parity with the producer's resampled raster.
|
|
294
|
+
The Reference crop follows the selected part (#749). Parts verdicts are
|
|
295
|
+
comments-based (#751): no issues approves; issues request changes.
|
|
296
|
+
**Historical:** the old parts page, producer flags and mesh-numbers panel were
|
|
297
|
+
deleted (#745). Mesh edges provides visual mesh inspection; agent readers retain
|
|
298
|
+
the numbers. The rig Mesh precision instrument remains separate.
|
|
288
299
|
Difference uses the producer-declared rig-space painting artifact; see [Declared-grid Difference](PARTS_VIEW.md#declared-grid-difference).
|
|
289
300
|
`tests/parts-comparison.test.ts` guards the geometry/settings; `tests/parts-overlay-browser.ts` verifies
|
|
290
301
|
displayed overlay pixels and comment restoration in both languages.
|
package/docs/PANELS.md
CHANGED
|
@@ -449,11 +449,23 @@ A reference-basis comment cannot become a producer-frame strip: CLI and browser
|
|
|
449
449
|
|
|
450
450
|
## Four inspection stages
|
|
451
451
|
|
|
452
|
-
The same numbered navigation appears on
|
|
452
|
+
The same numbered navigation appears on compiled and compare inspections:
|
|
453
453
|
1 Parts + mesh, 2 Interview, 3 Rig + animation, 4 Direction. These are navigation,
|
|
454
454
|
not create pipeline stages or sign-offs. Opening or switching never submits a
|
|
455
|
-
verdict, applies an edit or starts a producer job.
|
|
456
|
-
|
|
455
|
+
verdict, applies an edit or starts a producer job. Each chip opens a mode of the
|
|
456
|
+
one screen or names itself unavailable; no chip loads a separate page (#726):
|
|
457
|
+
|
|
458
|
+
| Chip | Opens |
|
|
459
|
+
| --- | --- |
|
|
460
|
+
| 1 Parts + mesh | the Setup mode |
|
|
461
|
+
| 2 Interview | the interview over the screen; until that view lands it names `INTERVIEW_MODAL_UNAVAILABLE` |
|
|
462
|
+
| 3 Rig + animation | the Animate mode |
|
|
463
|
+
| 4 Direction | nothing: it names `DIRECTION_NOT_AVAILABLE` |
|
|
464
|
+
|
|
465
|
+
Without a rig on the stage, chips 1 and 3 and the Setup, Animate and Compare
|
|
466
|
+
switch name `MODEL_UNAVAILABLE` or `RIG_VERSION_UNAVAILABLE`. The standalone
|
|
467
|
+
`parts` page shows only its own chip. The former Stage 1 atlas frame is deleted;
|
|
468
|
+
the Stage 1 paragraphs below describe the `/api/stage-parts` data that Setup reads.
|
|
457
469
|
|
|
458
470
|
Stage 1 in a single compiled inspection with a producer handoff shows the
|
|
459
471
|
handoff's **separated parts and draft meshes**, labelled **Draft rig · structure
|
|
@@ -490,14 +502,10 @@ export remains unavailable pending review#369 and create#91. Existing reviewer
|
|
|
490
502
|
requests remain verbatim in their existing feedback/comment contracts; there
|
|
491
503
|
is no fake Apply for art repair.
|
|
492
504
|
|
|
493
|
-
|
|
494
|
-
instruments, DOM and mode IDs are retained.
|
|
495
|
-
|
|
496
|
-
|
|
497
|
-
|
|
498
|
-
time, pending edits and applied build stay owned by those original tools. Stage
|
|
499
|
-
changes retain the original workspace and each compare side's atlas controller.
|
|
500
|
-
Single draft frames are rebound on revision changes. Language changes update retained
|
|
501
|
-
frames without applying or submitting.
|
|
505
|
+
Chips 1 and 3 select the existing Setup and Animate modes, so the Setup,
|
|
506
|
+
Animate and Compare switch, its instruments, DOM and mode IDs are retained.
|
|
507
|
+
Existing bookmarks, Apply/Reset provenance, selected slot, compare side, time,
|
|
508
|
+
pending edits and applied build stay owned by those original tools. Choosing a
|
|
509
|
+
chip never applies or submits.
|
|
502
510
|
The parts-only entry retains its part selection, geometry and pending verdict
|
|
503
511
|
while visiting unavailable stages; it needs no compiled model.
|
package/docs/PARTS_VIEW.md
CHANGED
|
@@ -1,27 +1,39 @@
|
|
|
1
1
|
# Parts and atlas view
|
|
2
2
|
|
|
3
|
+
> **Historical UI reference:** the standalone parts page and its sidebar,
|
|
4
|
+
> flags and mesh-numbers panel were removed in #745. UI instructions for those
|
|
5
|
+
> surfaces below are superseded by the existing Setup workspace, Comments and
|
|
6
|
+
> act bar; see the [current screen specification](https://github.com/rig-c/review/blob/main/docs/SCREENS.md).
|
|
7
|
+
> Retained input formats, API details, historical verdicts and heading targets
|
|
8
|
+
> remain compatibility references, not instructions to restore that UI.
|
|
9
|
+
|
|
3
10
|
`rig-review parts` shows a rig's parts as images, before any rig is built, so a part with missing material, a faint
|
|
4
|
-
island or a ragged rim is caught before rigging rather than in motion after it.
|
|
5
|
-
|
|
11
|
+
island or a ragged rim is caught before rigging rather than in motion after it. Atlas-only inputs refuse
|
|
12
|
+
`PARTS_ATLAS_NOT_CARRIED` before the parts workspace opens. Use rig review for read-only atlas inspection;
|
|
13
|
+
`parts --format json|issue` still reads saved atlas verdicts.
|
|
6
14
|
|
|
7
15
|
```sh
|
|
8
16
|
npx rig-review parts <out> # a rig-parts build root: opens <out>/rig/parts.json
|
|
9
17
|
npx rig-review parts <out>/rig # the same package, named directly
|
|
10
|
-
npx rig-review
|
|
18
|
+
npx rig-review open <out>/check # inspect a built rig, including its read-only atlas
|
|
19
|
+
npx rig-review parts <out>/check --format json # read a saved atlas verdict without opening a workspace
|
|
11
20
|
```
|
|
12
21
|
|
|
13
|
-
Options: `--rig <file>` (mesh geometry), `--mesh-report <file>`, `--check <file>` (producer flags; see below), `--verdict <file>` (where the sign-off
|
|
22
|
+
Options: `--rig <file>` (mesh geometry), `--mesh-report <file>`, `--check <file>` (historical producer flags; former UI removed in #745; see below), `--verdict <file>` (where the sign-off
|
|
14
23
|
is written), `--painting <png>` (the original painting), `--by <name>` (launch-only reviewer declaration), `--format json|issue` (export the saved verdict), `--port <n>`. Like `review`, it serves in the foreground and exits 3 s after its last tab closes.
|
|
15
24
|
|
|
16
25
|
## Inputs
|
|
17
26
|
|
|
18
|
-
| Mode |
|
|
27
|
+
| Mode | Input and availability | Items |
|
|
19
28
|
| --- | --- | --- |
|
|
20
29
|
| parts | a directory holding `parts.json` beside `parts/<name>.png`, as `rig-parts assemble` writes it, or a build root whose `rig/` holds them | every part, in `parts.json` order (draw order, back first) |
|
|
21
|
-
| atlas | a review package or build `check/` folder whose compiled model declares `pages[].regions[]
|
|
30
|
+
| atlas | a review package or build `check/` folder whose compiled model declares `pages[].regions[]`; read-only within rig review or saved-verdict export, refused at parts workspace open | every region, by page |
|
|
22
31
|
|
|
23
32
|
## What it shows
|
|
24
33
|
|
|
34
|
+
**Historical UI:** the following describes the former standalone parts page.
|
|
35
|
+
Use the current shared Setup workspace; these controls are not a second screen.
|
|
36
|
+
|
|
25
37
|
- **Every part on its own**, on a checker background by default (green, magenta, black and white are also available), at native scale with
|
|
26
38
|
Fit and exact **1:1**, cursor-anchored wheel zoom, pinch and drag pan in the shared rig/reference viewport pair. Sampling stays nearest-neighbour. **Alpha only** shows the alpha channel as grey (white is opaque).
|
|
27
39
|
- **Footprints of parts in front** (parts mode): the alpha of every part later in `parts.json` whose box meets the
|
|
@@ -30,12 +42,15 @@ is written), `--painting <png>` (the original painting), `--by <name>` (launch-o
|
|
|
30
42
|
occluder's shape at a glance. Nothing is measured; the tint is the front parts' own alpha.
|
|
31
43
|
- **Atlas mode**: the pages as packed, with each region's box and name; the background shows through padding, and a
|
|
32
44
|
region's own view keeps 4 page pixels around its box (dashed) so bleed is visible. Clicking a region opens it.
|
|
33
|
-
- **Producer flags**, read from the files rig-parts writes and shown on the part they name. None is re-measured here. Each reads as one labelled line (an opening's parts, animation, frame and cells; a seam pair's pixel counts; a gate's name, status and readings), with the producer's object verbatim under a collapsed **Producer line**.
|
|
45
|
+
- **Historical UI — Producer flags (removed in #745)**, read from the files rig-parts writes and shown on the part they name. None is re-measured here. Each reads as one labelled line (an opening's parts, animation, frame and cells; a seam pair's pixel counts; a gate's name, status and readings), with the producer's object verbatim under a collapsed **Producer line**.
|
|
34
46
|
|
|
35
47
|
The [23-part EN/KO comparison](https://github.com/rig-c/review/tree/main/tests/fixtures/parts-approve-all-evidence) records the same 1600×1100 initial view against installed 1.8.0: row height 49.375 → 26.1875 px, with all 23 after rows on one line (`tests/parts-approve-all-browser.ts`).
|
|
36
48
|
|
|
37
49
|
### Producer row groups
|
|
38
50
|
|
|
51
|
+
**Historical UI:** sidebar groups and badges below were removed in #745.
|
|
52
|
+
The producer row metadata and legacy API/verdict references are preserved.
|
|
53
|
+
|
|
39
54
|
The sidebar counts **only mesh-report flags and explicit part findings**. A check row counts only
|
|
40
55
|
when `row_scope: "part"`, `row_kind: "finding"` and a valid `row_subjects` array names that part.
|
|
41
56
|
A block status, a JSON path, a reason or a legacy part/slot/bone field never determines classification.
|
|
@@ -97,7 +112,7 @@ The occlusion-coverage report (rig-c/parts#998) is not read yet; the footprint t
|
|
|
97
112
|
Standalone sign-off uses saved files. The active Create and Parts cycle uses finalized acts through the
|
|
98
113
|
[standing live job workflow](WORKFLOWS.md#standing-live-job-workflow).
|
|
99
114
|
|
|
100
|
-
|
|
115
|
+
**Historical UI, superseded by #741/#751:** the former workspace kept pointed issues in the persistent **Issues** sidebar, including an empty state.
|
|
101
116
|
**Save sign-off** saves the current issue collection. An empty collection approves the inspection, and a
|
|
102
117
|
non-empty collection requests changes. The live job host submits the same issue collection through its
|
|
103
118
|
review dialog. Reviewer wording stays verbatim.
|
|
@@ -148,8 +163,8 @@ Sign-off JSON requests are limited to 4 MiB (4,194,304 bytes) of UTF-8 while str
|
|
|
148
163
|
cancelled before its remainder is read; a valid request exactly at the byte limit is accepted. Same-origin and
|
|
149
164
|
write-capability requirements remain unchanged.
|
|
150
165
|
|
|
151
|
-
|
|
152
|
-
only the producer flags
|
|
166
|
+
**Historical flag-bound sign-off UI:** on reopen, the former page offered a saved sign-off only when both `source.sha256` and `source.flags` matched the files on disk.
|
|
167
|
+
**Historical UI:** when only the producer flags differed, the page said the saved sign-off was for different producer flags and started fresh.
|
|
153
168
|
Consumers that gate on the sign-off (rig-c/create) check `source.sha256`.
|
|
154
169
|
|
|
155
170
|
Every file the view reads from a package resolves inside it: a part PNG or `parts.json` that symlinks out is refused
|
|
@@ -235,6 +250,11 @@ Crash-proof exactly-once delivery requires an additional acknowledgment/replay p
|
|
|
235
250
|
|
|
236
251
|
## Mesh geometry
|
|
237
252
|
|
|
253
|
+
**Historical UI:** the toggle labels and geometry/numbers panel below describe
|
|
254
|
+
the removed standalone parts page (#745). Current visual inspection uses Mesh
|
|
255
|
+
edges in the shared workspace. Geometry inputs and legacy wire references below
|
|
256
|
+
remain compatibility information, not a request to restore the old panel.
|
|
257
|
+
|
|
238
258
|
In parts mode, a `rig.json` beside `parts.json` supplies optional mesh geometry;
|
|
239
259
|
`--rig <file>` selects an explicit input instead. The workspace-wide **mesh from
|
|
240
260
|
rig.json UVs** toggle starts off and retains its setting across part selection, assembled view,
|
|
@@ -270,7 +290,7 @@ not an exact recovery of the producer's original unrounded positions.
|
|
|
270
290
|
|
|
271
291
|
Mode, vertex count, triangle count, `art_coverage` and `stray_cleared` are copied
|
|
272
292
|
from the part's `mesh_report.json` row without recomputing them. Absent fields
|
|
273
|
-
say **not reported**; faint islands
|
|
293
|
+
say **not reported**; **historical UI:** faint islands remained in Producer flags. A report count may
|
|
274
294
|
differ from the loaded geometry. These are producer readings. Historical verdicts stored
|
|
275
295
|
`parts[name].mesh` as `{outcome,note}` only for a mesh-bearing part.
|
|
276
296
|
`rig.json` and the loaded mesh report enter `source.files`, and the mesh report
|
package/docs/REVIEW_PACKAGE.md
CHANGED
|
@@ -848,6 +848,32 @@ parts verdict source digest and actual original PNG SHA-256, without a fabricate
|
|
|
848
848
|
manifest id, revision or compiled model. The rig's `rig-review-comment/1` schema stays closed.
|
|
849
849
|
See [the parts contract and validation instruments](PARTS_VIEW.md#pointed-parts-comments).
|
|
850
850
|
|
|
851
|
+
### Interview-stage project subject
|
|
852
|
+
|
|
853
|
+
`rig-review open <project-root> --project <project-root> --picks-dir <dir>`
|
|
854
|
+
opens an interview-stage Create project before a draft or recorded review
|
|
855
|
+
package exists. Both roots must resolve to the same directory. The picks output
|
|
856
|
+
is an existing dedicated project-relative directory disjoint from inputs.
|
|
857
|
+
No version/draft selector is inferred: demo/build version records and unrelated
|
|
858
|
+
derived evidence are allowed, while an actual draft or a non-null
|
|
859
|
+
`versions[].review_package` requires its existing explicit package designation.
|
|
860
|
+
This form takes exactly one target and no additional inspection options.
|
|
861
|
+
|
|
862
|
+
The existing joined resolver reads the project, retained option sets and input
|
|
863
|
+
hashes. The launcher retains an internal interview subject, not a `ReviewPackage`.
|
|
864
|
+
The shared server serves the same `web/index.html` and bounded interview routes;
|
|
865
|
+
its internal `/api/review` response contains `subject: "interview"`, project
|
|
866
|
+
path/hash, source hash, label and capability flags, with no manifest, model,
|
|
867
|
+
reviewed-package identity or package session. The existing modal mounts the
|
|
868
|
+
existing interview form. Model APIs refuse `MODEL_UNAVAILABLE`; source drift
|
|
869
|
+
refuses `INTERVIEW_OPTIONS_STALE`. Reads do not write sources. The joined dialog and standing record form use one shared list | image | survey
|
|
870
|
+
answer builder. There is no interview Note input. Existing saved or historical
|
|
871
|
+
notes remain readable as read-only text and are carried unchanged. Joined picks
|
|
872
|
+
omit `note` when none exists; the job act retains its required string field.
|
|
873
|
+
Historical records, picks/act/verdict schemas and explicit
|
|
874
|
+
version/draft joins retain their existing readers and checks.
|
|
875
|
+
This opening form does not replace the semantic standing review cycle.
|
|
876
|
+
|
|
851
877
|
## Stage-1 draft mesh inspection
|
|
852
878
|
|
|
853
879
|
`GET /api/stage-parts` in single inspections uses the live handoff's original
|
|
@@ -1425,14 +1451,39 @@ selections, inline Other text and per-question notes keep their existing formats
|
|
|
1425
1451
|
strings and readers. There is no interview-picks arm or question/ask anchor in
|
|
1426
1452
|
this extension. Technical configuration and search controls are outside it.
|
|
1427
1453
|
|
|
1428
|
-
|
|
1429
|
-
|
|
1430
|
-
|
|
1431
|
-
its
|
|
1432
|
-
|
|
1433
|
-
|
|
1434
|
-
|
|
1435
|
-
|
|
1454
|
+
The decoders and consumer projections are read-only. Since [Review #713](https://github.com/rig-c/review/issues/713)
|
|
1455
|
+
(HQ contract ruling), the UI finalizers write fresh checkpoint, parts-verdict,
|
|
1456
|
+
rig and direction review-verdict and signoff acts as act@6. The UI submission
|
|
1457
|
+
keeps its existing `words` and `issues` fields. [Review #746](https://github.com/rig-c/review/issues/746)
|
|
1458
|
+
adds optional `feedback: Feedback[]` beside required `words` only for the
|
|
1459
|
+
`rig-review` verdict submission. When present, including an empty list, it is
|
|
1460
|
+
the complete comment list: `feedbackItemComments` maps each row's `summary` to
|
|
1461
|
+
`text` and retains its `id`, frames, target, category and `anchor.context`.
|
|
1462
|
+
The existing decoder validates every mapped comment, its evidence and the
|
|
1463
|
+
whole scalar bound; malformed or blank rows refuse rather than falling back to
|
|
1464
|
+
`words`. The act bar sends a detached feedback list when comments exist and
|
|
1465
|
+
keeps `words` as their projection. It omits `feedback` when there are no comments.
|
|
1466
|
+
Absent `feedback` retains the previous written bytes and words-only mapping.
|
|
1467
|
+
Direction and image verdict submissions do not accept `feedback`. The written
|
|
1468
|
+
act remains act@6; historical words-only acts retain their readers.
|
|
1469
|
+
|
|
1470
|
+
Pointed marks, inline crops, bookmarks and valid time-only null frames remain
|
|
1471
|
+
inside the existing `anchor.context`. This is distinct from act@7's top-level
|
|
1472
|
+
`comment.context`, which remains disabled by `EMIT_UNPINNED_CREATE_FIELDS`.
|
|
1473
|
+
No new field or decoder rule is added to the written act.
|
|
1474
|
+
|
|
1475
|
+
For the words-only mapping, the daemon maps a nonblank note
|
|
1476
|
+
to one comment: anchored to the checkpoint for a checkpoint, general otherwise.
|
|
1477
|
+
It maps each Parts issue to a Parts-anchored comment, before the note. A blank
|
|
1478
|
+
or whitespace-only note writes no comment (`comments: []`). Nothing is padded.
|
|
1479
|
+
A note whose projection exceeds the 10,000-unit scalar bound refuses
|
|
1480
|
+
`JOB_ACT_INVALID`. The bound counts the stored `words`, and the `[label]\n`
|
|
1481
|
+
prefix is part of them, so a general note longer than 9,990 units refuses even
|
|
1482
|
+
though act@5 accepted it. Feedback is many comments, not one long note.
|
|
1483
|
+
Each written act must decode through `parseCommentsAct`.
|
|
1484
|
+
Image-review verdicts and interview picks stay at act@2, because Create refuses
|
|
1485
|
+
both under act@6. Record acts stay at act@4, because Create maps only a record
|
|
1486
|
+
checkpoint under act@6. Standalone save paths keep their existing versions.
|
|
1436
1487
|
|
|
1437
1488
|
The existing `@rig-c/review/job-host` facade exports:
|
|
1438
1489
|
|
|
@@ -1491,7 +1542,13 @@ Anchors use existing source-bound fields without a new kind discriminator:
|
|
|
1491
1542
|
`context.comment`; existing codecs and inline PNG validation are reused.
|
|
1492
1543
|
- PartsIssue without `summary`: `schema, id, parts, sourceHash, rigRegion,
|
|
1493
1544
|
imageRegion, view, crop, nativeCrop`. Finalized item anchors require prepared
|
|
1494
|
-
native crop metadata. Assembled anchors retain null native crop.
|
|
1545
|
+
native crop metadata. Assembled anchors retain null native crop. Optional assembled-only
|
|
1546
|
+
`view.visibleLayers: {name, imageHash}[]` retains the complete visible set in
|
|
1547
|
+
source item order, bound to `sourceHash` and each loaded source image. Entries
|
|
1548
|
+
must be unique and source-bound before restoration replaces the hidden set.
|
|
1549
|
+
Absent fields retain the historical restore branch and recorded bytes. Readers
|
|
1550
|
+
accept both forms; fresh capture writes this field only when the shared
|
|
1551
|
+
`EMIT_UNPINNED_CREATE_FIELDS` gate is enabled after Create confirms its parser pin.
|
|
1495
1552
|
- Named image: `name`, optionally the complete existing-field composition
|
|
1496
1553
|
`imageRegion, crop, nativeCrop`. Names resolve in the sealed image set. Regions
|
|
1497
1554
|
use nonnegative native-pixel integer origins, positive extents and at most
|
|
@@ -1541,3 +1598,36 @@ only absent `issues[]` uses `part.note`. Literal-byte controls and all eighteen
|
|
|
1541
1598
|
cross-repository oracle outcomes belong in the PR evidence. Parser-only native
|
|
1542
1599
|
coverage does not substitute for Create's actual ingest/replay receipt or owner
|
|
1543
1600
|
working-screen review.
|
|
1601
|
+
|
|
1602
|
+
### Comment context (act@7)
|
|
1603
|
+
|
|
1604
|
+
`JOB_COMMENT_CONTEXT_ACT_SCHEMA` is `rig-review/act@7` ([#714](https://github.com/rig-c/review/issues/714)).
|
|
1605
|
+
It is the @6 envelope, kinds, value keys and checks with one addition: each
|
|
1606
|
+
comment entry may carry an optional `context` object after `text` and `anchor`.
|
|
1607
|
+
`context` records where the comment was made so opening it can restore that
|
|
1608
|
+
view. It is not part of the signed projection: `projectComments` covers `text`
|
|
1609
|
+
and `anchor` only. `parseContextCommentsAct` decodes @7 only; `parseCommentsAct`
|
|
1610
|
+
still decodes @6 only and refuses `context`. @2–@6 bytes, hashes and readers do
|
|
1611
|
+
not change.
|
|
1612
|
+
|
|
1613
|
+
`context` is closed and nonempty. Every key is optional and copies a value an
|
|
1614
|
+
existing pin or restore path already carries:
|
|
1615
|
+
|
|
1616
|
+
| Key | Shape | Existing source |
|
|
1617
|
+
| --- | --- | --- |
|
|
1618
|
+
| `subject` | `{ask, sourceHash, selector?}` | the ask's `JobSubject`, the act source's `sourceHash` and `selector`. `ask.kind` must equal the act `kind`; `sourceHash` and `selector` must equal the act source (`JOB_ACT_INVALID`) |
|
|
1619
|
+
| `mode` | `setup`, `animate` or `compare` | StageComment `mode`, bookmark `selection.mode` |
|
|
1620
|
+
| `tab` | `view`, `rig`, `playback` or `feedback` | bookmark `selection.inspector` |
|
|
1621
|
+
| `part` | ControlPart `{side, slot, mode, identity?}` | bookmark `selection.part` (absent, never `null`) |
|
|
1622
|
+
| `region` | world-space `{x, y, width, height}` | StageComment `world`, PartsIssue `rigRegion` |
|
|
1623
|
+
| `viewMode` | `item` or `assembled` | PartsIssue `view.mode` |
|
|
1624
|
+
| `camera` | numeric camera `{space, center, zoom, viewport, visible}` | StageComment `camera` |
|
|
1625
|
+
| `frame` | `{index, basis}` (`producer` or `reference`) | StageComment `frame` (absent when time-only) |
|
|
1626
|
+
|
|
1627
|
+
Each key reuses the decoder of the shape it copies. A `reopen` act has no ask
|
|
1628
|
+
subject, so its comments cannot carry `context.subject`.
|
|
1629
|
+
|
|
1630
|
+
Create refuses unknown fields, so Review emits @7 only when
|
|
1631
|
+
`EMIT_UNPINNED_CREATE_FIELDS` (`src/create-pin-gate.ts`) is true. It is false
|
|
1632
|
+
until the create tower confirms Create has pinned the Review version that reads
|
|
1633
|
+
@7. While it is false, writers drop every `context` and emit @6.
|