revspec 0.5.0 → 0.7.0

package/test/state/review-state.test.ts

@@ -1,399 +0,0 @@
-import { describe, expect, it, beforeEach } from "bun:test";
-import { ReviewState } from "../../src/state/review-state";
-import type { Thread } from "../../src/protocol/types";
-
-const SPEC = ["line one", "line two", "line three", "line four", "line five"];
-
-function makeThread(
-  id: string,
-  line: number,
-  status: Thread["status"],
-  messages: Thread["messages"] = [{ author: "reviewer", text: "comment" }]
-): Thread {
-  return { id, line, status, messages };
-}
-
-describe("ReviewState", () => {
-  describe("initializes with spec lines and no threads", () => {
-    it("sets lineCount from specLines", () => {
-      const state = new ReviewState(SPEC, []);
-      expect(state.lineCount).toBe(5);
-    });
-
-    it("starts cursor at line 1", () => {
-      const state = new ReviewState(SPEC, []);
-      expect(state.cursorLine).toBe(1);
-    });
-
-    it("starts with empty threads array", () => {
-      const state = new ReviewState(SPEC, []);
-      expect(state.threads).toHaveLength(0);
-    });
-  });
-
-  describe("addComment", () => {
-    it("adds a new thread with status open", () => {
-      const state = new ReviewState(SPEC, []);
-      state.addComment(3, "needs clarification");
-      expect(state.threads).toHaveLength(1);
-      expect(state.threads[0].line).toBe(3);
-      expect(state.threads[0].status).toBe("open");
-      expect(state.threads[0].messages).toHaveLength(1);
-      expect(state.threads[0].messages[0].author).toBe("reviewer");
-      expect(state.threads[0].messages[0].text).toBe("needs clarification");
-      expect(state.threads[0].messages[0].ts).toBeGreaterThan(0);
-    });
-
-    it("assigns auto-incremented id", () => {
-      const state = new ReviewState(SPEC, [makeThread("t3", 1, "open")]);
-      state.addComment(2, "another comment");
-      expect(state.threads[1].id).toBe("t4");
-    });
-  });
-
-  describe("replyToThread", () => {
-    it("appends human message to existing thread", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
-      state.replyToThread("t1", "my reply");
-      expect(state.threads[0].messages).toHaveLength(2);
-      expect(state.threads[0].messages[1].author).toBe("reviewer");
-      expect(state.threads[0].messages[1].text).toBe("my reply");
-      expect(state.threads[0].messages[1].ts).toBeGreaterThan(0);
-    });
-
-    it("flips status to open", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
-      state.replyToThread("t1", "my reply");
-      expect(state.threads[0].status).toBe("open");
-    });
-
-    it("does nothing for unknown threadId", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
-      state.replyToThread("t99", "ghost reply");
-      expect(state.threads[0].messages).toHaveLength(1);
-    });
-  });
-
-  describe("resolveThread", () => {
-    it("sets thread status to resolved", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 1, "open")]);
-      state.resolveThread("t1");
-      expect(state.threads[0].status).toBe("resolved");
-    });
-
-    it("toggles resolved thread back to open", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 1, "resolved")]);
-      state.resolveThread("t1");
-      expect(state.threads[0].status).toBe("open");
-    });
-
-    it("does nothing for unknown threadId", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 1, "open")]);
-      state.resolveThread("t99");
-      expect(state.threads[0].status).toBe("open");
-    });
-  });
-
-  describe("resolveAllPending", () => {
-    it("resolves all pending threads", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "pending"),
-        makeThread("t2", 2, "pending"),
-        makeThread("t3", 3, "open"),
-      ]);
-      state.resolveAllPending();
-      expect(state.threads[0].status).toBe("resolved");
-      expect(state.threads[1].status).toBe("resolved");
-    });
-
-    it("leaves open threads unchanged", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "pending"),
-        makeThread("t2", 2, "open"),
-      ]);
-      state.resolveAllPending();
-      expect(state.threads[1].status).toBe("open");
-    });
-  });
-
-  describe("threadAtLine", () => {
-    it("returns thread when found", () => {
-      const thread = makeThread("t1", 3, "open");
-      const state = new ReviewState(SPEC, [thread]);
-      expect(state.threadAtLine(3)).toEqual(thread);
-    });
-
-    it("returns null when not found", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 3, "open")]);
-      expect(state.threadAtLine(5)).toBeNull();
-    });
-  });
-
-  describe("nextActiveThread", () => {
-    it("returns next open/pending thread line after cursor", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 2, "open"),
-        makeThread("t2", 4, "pending"),
-      ]);
-      state.cursorLine = 3;
-      expect(state.nextActiveThread()).toBe(4);
-    });
-
-    it("wraps around to first active thread when none after cursor", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "open"),
-        makeThread("t2", 3, "pending"),
-      ]);
-      state.cursorLine = 4;
-      expect(state.nextActiveThread()).toBe(1);
-    });
-
-    it("skips resolved threads", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 2, "resolved"),
-        makeThread("t2", 4, "open"),
-      ]);
-      state.cursorLine = 1;
-      expect(state.nextActiveThread()).toBe(4);
-    });
-
-    it("returns null when no active threads", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 2, "resolved"),
-        makeThread("t2", 4, "outdated"),
-      ]);
-      expect(state.nextActiveThread()).toBeNull();
-    });
-  });
-
-  describe("prevActiveThread", () => {
-    it("returns previous open/pending thread line before cursor", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "open"),
-        makeThread("t2", 3, "pending"),
-      ]);
-      state.cursorLine = 4;
-      expect(state.prevActiveThread()).toBe(3);
-    });
-
-    it("wraps around to last active thread when none before cursor", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 2, "open"),
-        makeThread("t2", 4, "pending"),
-      ]);
-      state.cursorLine = 1;
-      expect(state.prevActiveThread()).toBe(4);
-    });
-
-    it("skips resolved threads", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "open"),
-        makeThread("t2", 3, "resolved"),
-      ]);
-      state.cursorLine = 5;
-      expect(state.prevActiveThread()).toBe(1);
-    });
-
-    it("returns null when no active threads", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 2, "resolved")]);
-      expect(state.prevActiveThread()).toBeNull();
-    });
-  });
-
-  describe("canApprove", () => {
-    it("returns true when all threads are resolved", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "resolved"),
-        makeThread("t2", 2, "resolved"),
-      ]);
-      expect(state.canApprove()).toBe(true);
-    });
-
-    it("returns true when threads are resolved or outdated", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "resolved"),
-        makeThread("t2", 2, "outdated"),
-      ]);
-      expect(state.canApprove()).toBe(true);
-    });
-
-    it("returns false when any thread is open", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "resolved"),
-        makeThread("t2", 2, "open"),
-      ]);
-      expect(state.canApprove()).toBe(false);
-    });
-
-    it("returns false when any thread is pending", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "resolved"),
-        makeThread("t2", 2, "pending"),
-      ]);
-      expect(state.canApprove()).toBe(false);
-    });
-
-    it("returns true when there are no threads (clean approval)", () => {
-      const state = new ReviewState(SPEC, []);
-      expect(state.canApprove()).toBe(true);
-    });
-  });
-
-  describe("nextThreadId", () => {
-    it("returns t1 when no threads exist", () => {
-      const state = new ReviewState(SPEC, []);
-      expect(state.nextThreadId()).toBe("t1");
-    });
-
-    it("increments from the highest existing id", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t3", 1, "open"),
-        makeThread("t1", 2, "open"),
-        makeThread("t7", 3, "open"),
-      ]);
-      expect(state.nextThreadId()).toBe("t8");
-    });
-  });
-
-  describe("deleteLastDraftMessage", () => {
-    it("removes the last human message from the thread", () => {
-      const state = new ReviewState(SPEC, [
-        {
-          id: "t1",
-          line: 1,
-          status: "open",
-          messages: [
-            { author: "owner", text: "AI response" },
-            { author: "reviewer", text: "my draft" },
-          ],
-        },
-      ]);
-      state.deleteLastDraftMessage("t1");
-      expect(state.threads[0].messages).toHaveLength(1);
-      expect(state.threads[0].messages[0].author).toBe("owner");
-    });
-
-    it("removes the thread entirely when it becomes empty", () => {
-      const state = new ReviewState(SPEC, [
-        {
-          id: "t1",
-          line: 1,
-          status: "open",
-          messages: [{ author: "reviewer", text: "only message" }],
-        },
-      ]);
-      state.deleteLastDraftMessage("t1");
-      expect(state.threads).toHaveLength(0);
-    });
-
-    it("does nothing for unknown threadId", () => {
-      const state = new ReviewState(SPEC, [makeThread("t1", 1, "open")]);
-      state.deleteLastDraftMessage("t99");
-      expect(state.threads).toHaveLength(1);
-      expect(state.threads[0].messages).toHaveLength(1);
-    });
-  });
-
-  describe("toDraft", () => {
-    it("serializes current threads", () => {
-      const threads = [makeThread("t1", 2, "open")];
-      const state = new ReviewState(SPEC, threads);
-      expect(state.toDraft()).toEqual({ threads });
-    });
-  });
-
-  describe("activeThreadCount", () => {
-    it("counts open and pending threads separately", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "open"),
-        makeThread("t2", 2, "pending"),
-        makeThread("t3", 3, "open"),
-        makeThread("t4", 4, "resolved"),
-      ]);
-      expect(state.activeThreadCount()).toEqual({ open: 2, pending: 1 });
-    });
-
-    it("returns zeros when no active threads", () => {
-      const state = new ReviewState(SPEC, [
-        makeThread("t1", 1, "resolved"),
-        makeThread("t2", 2, "outdated"),
-      ]);
-      expect(state.activeThreadCount()).toEqual({ open: 0, pending: 0 });
-    });
-  });
-
-  describe("unread tracking", () => {
-    it("tracks unread owner replies", () => {
-      const state = new ReviewState(["line1", "line2"], []);
-      state.addComment(1, "fix this");
-      state.addOwnerReply("t1", "done", 1001);
-      expect(state.unreadCount()).toBe(1);
-    });
-
-    it("markRead clears unread for a thread", () => {
-      const state = new ReviewState(["line1"], []);
-      state.addComment(1, "fix");
-      state.addOwnerReply("t1", "done", 1001);
-      state.markRead("t1");
-      expect(state.unreadCount()).toBe(0);
-    });
-
-    it("nextUnreadThread returns line of next unread thread after cursor", () => {
-      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
-      state.addComment(2, "fix");
-      state.addComment(4, "fix too");
-      state.addOwnerReply("t1", "done", 1001);
-      state.addOwnerReply("t2", "done", 1002);
-      state.cursorLine = 1;
-      expect(state.nextUnreadThread()).toBe(2);
-    });
-
-    it("prevUnreadThread returns line of prev unread thread before cursor", () => {
-      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
-      state.addComment(2, "fix");
-      state.addComment(4, "fix too");
-      state.addOwnerReply("t1", "done", 1001);
-      state.addOwnerReply("t2", "done", 1002);
-      state.cursorLine = 5;
-      expect(state.prevUnreadThread()).toBe(4);
-    });
-
-    it("nextUnreadThread returns null when no unread", () => {
-      const state = new ReviewState(["a"], []);
-      expect(state.nextUnreadThread()).toBeNull();
-    });
-
-    it("isThreadUnread returns correct state", () => {
-      const state = new ReviewState(["a"], []);
-      state.addComment(1, "fix");
-      expect(state.isThreadUnread("t1")).toBe(false);
-      state.addOwnerReply("t1", "done", 1001);
-      expect(state.isThreadUnread("t1")).toBe(true);
-      state.markRead("t1");
-      expect(state.isThreadUnread("t1")).toBe(false);
-    });
-
-    it("nextUnreadThread wraps around", () => {
-      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
-      state.addComment(2, "fix");
-      state.addOwnerReply("t1", "done", 1001);
-      state.cursorLine = 4;
-      expect(state.nextUnreadThread()).toBe(2); // wraps to beginning
-    });
-
-    it("addOwnerReply sets thread status to pending", () => {
-      const state = new ReviewState(["a"], []);
-      state.addComment(1, "fix");
-      expect(state.threads[0].status).toBe("open");
-      state.addOwnerReply("t1", "done", 1001);
-      expect(state.threads[0].status).toBe("pending");
-    });
-
-    it("addOwnerReply preserves timestamp on message", () => {
-      const state = new ReviewState(["a"], []);
-      state.addComment(1, "fix");
-      state.addOwnerReply("t1", "done", 1234567890);
-      expect(state.threads[0].messages[1].ts).toBe(1234567890);
-    });
-  });
-});

package/test/tui/pager.test.ts

@@ -1,159 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { buildPagerContent } from "../../src/tui/pager";
-import { ReviewState } from "../../src/state/review-state";
-import type { Thread } from "../../src/protocol/types";
-
-const SPEC = ["# Title", "Some text", "More text", "Final line"];
-
-function makeThread(
-  id: string,
-  line: number,
-  status: Thread["status"],
-  messages: Thread["messages"] = [{ author: "reviewer", text: "comment" }]
-): Thread {
-  return { id, line, status, messages };
-}
-
-describe("buildPagerContent", () => {
-  it("renders lines with line numbers", () => {
-    const state = new ReviewState(SPEC, []);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines).toHaveLength(4);
-    expect(lines[0]).toContain("   1");
-    expect(lines[0]).toContain("# Title");
-    expect(lines[1]).toContain("   2");
-    expect(lines[1]).toContain("Some text");
-    expect(lines[2]).toContain("   3");
-    expect(lines[3]).toContain("   4");
-  });
-
-  it("marks cursor line with > prefix", () => {
-    const state = new ReviewState(SPEC, []);
-    state.cursorLine = 3;
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[2]).toMatch(/^>/);
-    expect(lines[0]).toMatch(/^ /);
-    expect(lines[1]).toMatch(/^ /);
-    expect(lines[3]).toMatch(/^ /);
-  });
-
-  it("shows gutter indicator for open threads", () => {
-    const state = new ReviewState(SPEC, [makeThread("t1", 2, "open")]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("\u258c");
-  });
-
-  it("shows gutter indicator for pending threads", () => {
-    const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("\u258c");
-  });
-
-  it("shows checkmark for resolved threads", () => {
-    const state = new ReviewState(SPEC, [makeThread("t1", 2, "resolved")]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("\u2713");
-  });
-
-  it("shows gutter indicator for outdated threads", () => {
-    const state = new ReviewState(SPEC, [makeThread("t1", 2, "outdated")]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("\u258c");
-  });
-
-  it("shows different icons for different statuses", () => {
-    const state = new ReviewState(SPEC, [
-      makeThread("t1", 1, "open"),
-      makeThread("t2", 2, "pending"),
-      makeThread("t3", 3, "resolved"),
-      makeThread("t4", 4, "outdated"),
-    ]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[0]).toContain("\u258c");
-    expect(lines[1]).toContain("\u258c");
-    expect(lines[2]).toContain("\u2713");
-    expect(lines[3]).toContain("\u258c");
-  });
-
-  it("does not show inline comment preview (removed)", () => {
-    const state = new ReviewState(SPEC, [
-      makeThread("t1", 2, "open", [
-        { author: "reviewer", text: "My response" },
-      ]),
-    ]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    // Only gutter indicator, no inline text preview
-    expect(lines[1]).toContain("\u258c");
-    expect(lines[1]).not.toContain("My response");
-  });
-
-  it("does not show status indicator for lines without threads", () => {
-    const state = new ReviewState(SPEC, [makeThread("t1", 2, "open")]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[0]).not.toContain("\u258c");
-    expect(lines[0]).not.toContain("\u2713");
-  });
-
-  it("pads line numbers to 4 characters", () => {
-    const state = new ReviewState(SPEC, []);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    expect(lines[0]).toContain("   1");
-    expect(lines[0]).toContain("# Title");
-  });
-
-  it("handles empty spec", () => {
-    const state = new ReviewState([], []);
-    const content = buildPagerContent(state);
-    expect(content).toBe("");
-  });
-
-  it("highlights search matches with >> << markers", () => {
-    const state = new ReviewState(SPEC, []);
-    const content = buildPagerContent(state, "text");
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("Some >>text<<");
-    expect(lines[2]).toContain("More >>text<<");
-    expect(lines[0]).not.toContain(">>");
-    expect(lines[3]).not.toContain(">>");
-  });
-
-  it("highlights search matches case-insensitively", () => {
-    const state = new ReviewState(["Hello World", "hello again"], []);
-    const content = buildPagerContent(state, "hello");
-    const lines = content.split("\n");
-
-    expect(lines[0]).toContain(">>Hello<<");
-    expect(lines[1]).toContain(">>hello<<");
-  });
-
-  it("does not highlight when searchQuery is null", () => {
-    const state = new ReviewState(SPEC, []);
-    const content = buildPagerContent(state, null);
-    const lines = content.split("\n");
-
-    expect(lines[1]).toContain("Some text");
-    expect(lines[1]).not.toContain(">>");
-  });
-
-});

package/test/tui/ui/keybinds.test.ts

@@ -1,71 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { createKeybindRegistry } from "../../../src/tui/ui/keybinds";
-
-function makeKey(name: string, opts: { ctrl?: boolean; shift?: boolean; sequence?: string } = {}): any {
-  return { name, ctrl: opts.ctrl ?? false, shift: opts.shift ?? false, sequence: opts.sequence ?? name };
-}
-
-describe("createKeybindRegistry", () => {
-  it("matches single keys", () => {
-    const reg = createKeybindRegistry([
-      { key: "j", action: "down" },
-      { key: "k", action: "up" },
-    ]);
-    expect(reg.match(makeKey("j"))).toBe("down");
-    expect(reg.match(makeKey("k"))).toBe("up");
-    expect(reg.match(makeKey("x"))).toBeNull();
-    reg.destroy();
-  });
-
-  it("matches ctrl keys", () => {
-    const reg = createKeybindRegistry([
-      { key: "C-d", action: "half-page-down" },
-    ]);
-    expect(reg.match(makeKey("d", { ctrl: true }))).toBe("half-page-down");
-    expect(reg.match(makeKey("d"))).toBeNull();
-    reg.destroy();
-  });
-
-  it("matches shift keys", () => {
-    const reg = createKeybindRegistry([
-      { key: "G", action: "goto-bottom" },
-      { key: "R", action: "resolve-all" },
-    ]);
-    expect(reg.match(makeKey("g", { shift: true }))).toBe("goto-bottom");
-    expect(reg.match(makeKey("r", { shift: true }))).toBe("resolve-all");
-    reg.destroy();
-  });
-
-  it("matches two-key sequences", () => {
-    const reg = createKeybindRegistry([
-      { key: "gg", action: "goto-top" },
-      { key: "dd", action: "delete" },
-    ]);
-    expect(reg.match(makeKey("g"))).toBeNull();
-    expect(reg.pending()).toBe("g...");
-    expect(reg.match(makeKey("g"))).toBe("goto-top");
-    expect(reg.pending()).toBeNull();
-    reg.destroy();
-  });
-
-  it("clears sequence on invalid second key", () => {
-    const reg = createKeybindRegistry([
-      { key: "gg", action: "goto-top" },
-      { key: "j", action: "down" },
-    ]);
-    expect(reg.match(makeKey("g"))).toBeNull();
-    expect(reg.match(makeKey("x"))).toBeNull();
-    expect(reg.match(makeKey("j"))).toBe("down");
-    reg.destroy();
-  });
-
-  it("handles bracket sequences", () => {
-    const reg = createKeybindRegistry([
-      { key: "]t", action: "next-thread" },
-      { key: "[t", action: "prev-thread" },
-    ]);
-    expect(reg.match(makeKey("]", { sequence: "]" }))).toBeNull();
-    expect(reg.match(makeKey("t"))).toBe("next-thread");
-    reg.destroy();
-  });
-});

package/tsconfig.json

@@ -1,14 +0,0 @@
-{
-  "compilerOptions": {
-    "lib": ["ESNext"],
-    "target": "ESNext",
-    "module": "ESNext",
-    "moduleResolution": "bundler",
-    "strict": true,
-    "skipLibCheck": true,
-    "outDir": "dist",
-    "rootDir": ".",
-    "types": ["bun-types"]
-  },
-  "include": ["src/**/*.ts", "bin/**/*.ts", "test/**/*.ts"]
-}