revspec 0.5.0 → 0.7.0

package/test/protocol/merge.test.ts

@@ -1,100 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { mergeDraftIntoReview } from "../../src/protocol/merge";
-import type { ReviewFile, DraftFile, Thread } from "../../src/protocol/types";
-
-const baseReview: ReviewFile = {
-  file: "spec.md",
-  threads: [],
-};
-
-function makeThread(id: string, messages: string[] = ["hello"]): Thread {
-  return {
-    id,
-    line: 1,
-    status: "open",
-    messages: messages.map((text) => ({ author: "reviewer", text })),
-  };
-}
-
-describe("mergeDraftIntoReview", () => {
-  it("adds new threads from draft to an empty review", () => {
-    const draft: DraftFile = {
-      threads: [makeThread("t1"), makeThread("t2")],
-    };
-    const result = mergeDraftIntoReview({ ...baseReview }, draft);
-    expect(result.threads).toHaveLength(2);
-    expect(result.threads.map((t) => t.id)).toEqual(["t1", "t2"]);
-  });
-
-  it("appends only new messages to an existing thread (draft has full history)", () => {
-    const existingThread: Thread = makeThread("t1", ["first message"]);
-    const review: ReviewFile = { file: "spec.md", threads: [existingThread] };
-
-    // Draft contains full history (existing + new)
-    const draftThread: Thread = {
-      ...existingThread,
-      messages: [
-        { author: "reviewer", text: "first message" },
-        { author: "owner", text: "second message" },
-      ],
-    };
-    const draft: DraftFile = { threads: [draftThread] };
-
-    const result = mergeDraftIntoReview(review, draft);
-    expect(result.threads).toHaveLength(1);
-    expect(result.threads[0].messages).toHaveLength(2);
-    expect(result.threads[0].messages[1].text).toBe("second message");
-  });
-
-  it("handles a mix of new and existing threads", () => {
-    const existing: Thread = makeThread("t1", ["msg1"]);
-    const review: ReviewFile = { file: "spec.md", threads: [existing] };
-
-    const draftExisting: Thread = {
-      ...existing,
-      messages: [
-        { author: "reviewer", text: "msg1" },
-        { author: "owner", text: "reply" },
-      ],
-    };
-    const draftNew: Thread = makeThread("t2", ["new thread"]);
-    const draft: DraftFile = { threads: [draftExisting, draftNew] };
-
-    const result = mergeDraftIntoReview(review, draft);
-    expect(result.threads).toHaveLength(2);
-    expect(result.threads[0].messages).toHaveLength(2);
-    expect(result.threads[1].id).toBe("t2");
-  });
-
-  it("updates thread status from draft", () => {
-    const existing: Thread = { ...makeThread("t1"), status: "open" };
-    const review: ReviewFile = { file: "spec.md", threads: [existing] };
-
-    const draftThread: Thread = {
-      ...existing,
-      status: "resolved",
-      messages: existing.messages,
-    };
-    const draft: DraftFile = { threads: [draftThread] };
-
-    const result = mergeDraftIntoReview(review, draft);
-    expect(result.threads[0].status).toBe("resolved");
-  });
-
-  it("returns review unchanged when draft has no threads", () => {
-    const thread: Thread = makeThread("t1");
-    const review: ReviewFile = { file: "spec.md", threads: [thread] };
-    const draft: DraftFile = { approved: true };
-
-    const result = mergeDraftIntoReview(review, draft);
-    expect(result.threads).toHaveLength(1);
-    expect(result.threads[0].id).toBe("t1");
-  });
-
-  it("creates a new ReviewFile with specFile when review is null", () => {
-    const draft: DraftFile = { threads: [makeThread("t1")] };
-    const result = mergeDraftIntoReview(null, draft, "new-spec.md");
-    expect(result.file).toBe("new-spec.md");
-    expect(result.threads).toHaveLength(1);
-  });
-});

package/test/protocol/read.test.ts

@@ -1,92 +0,0 @@
-import { describe, expect, it, afterEach } from "bun:test";
-import { mkdtempSync, rmSync, writeFileSync } from "fs";
-import { join } from "path";
-import { readReviewFile, readDraftFile } from "../../src/protocol/read";
-import type { ReviewFile, DraftFile } from "../../src/protocol/types";
-
-function tmpDir() {
-  return mkdtempSync("/tmp/revspec-test-");
-}
-
-describe("readReviewFile", () => {
-  it("returns null for a missing file", () => {
-    expect(readReviewFile("/nonexistent/path/review.json")).toBeNull();
-  });
-
-  it("returns parsed ReviewFile for a valid file", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "review.json");
-    const data: ReviewFile = {
-      file: "spec.md",
-      threads: [
-        {
-          id: "t1",
-          line: 10,
-          status: "open",
-          messages: [{ author: "reviewer", text: "Looks good?" }],
-        },
-      ],
-    };
-    writeFileSync(filePath, JSON.stringify(data));
-    const result = readReviewFile(filePath);
-    expect(result).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-
-  it("returns null for invalid JSON", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "review.json");
-    writeFileSync(filePath, "not valid json {{");
-    expect(readReviewFile(filePath)).toBeNull();
-    rmSync(dir, { recursive: true });
-  });
-
-  it("returns null when JSON doesn't match ReviewFile schema", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "review.json");
-    writeFileSync(filePath, JSON.stringify({ threads: [] })); // missing 'file'
-    expect(readReviewFile(filePath)).toBeNull();
-    rmSync(dir, { recursive: true });
-  });
-});
-
-describe("readDraftFile", () => {
-  it("returns null for a missing file", () => {
-    expect(readDraftFile("/nonexistent/path/draft.json")).toBeNull();
-  });
-
-  it("returns parsed DraftFile for an approval draft", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "draft.json");
-    const data: DraftFile = { approved: true };
-    writeFileSync(filePath, JSON.stringify(data));
-    expect(readDraftFile(filePath)).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-
-  it("returns parsed DraftFile for a threads draft", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "draft.json");
-    const data: DraftFile = {
-      threads: [
-        {
-          id: "t2",
-          line: 5,
-          status: "pending",
-          messages: [{ author: "owner", text: "Response here" }],
-        },
-      ],
-    };
-    writeFileSync(filePath, JSON.stringify(data));
-    expect(readDraftFile(filePath)).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-
-  it("returns null for corrupted JSON", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "draft.json");
-    writeFileSync(filePath, "{bad json");
-    expect(readDraftFile(filePath)).toBeNull();
-    rmSync(dir, { recursive: true });
-  });
-});

package/test/protocol/types.test.ts

@@ -1,95 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import {
-  isValidStatus,
-  isValidThread,
-  isValidReviewFile,
-} from "../../src/protocol/types";
-
-describe("isValidStatus", () => {
-  it("accepts open", () => expect(isValidStatus("open")).toBe(true));
-  it("accepts pending", () => expect(isValidStatus("pending")).toBe(true));
-  it("accepts resolved", () => expect(isValidStatus("resolved")).toBe(true));
-  it("accepts outdated", () => expect(isValidStatus("outdated")).toBe(true));
-  it("rejects addressed", () => expect(isValidStatus("addressed")).toBe(false));
-  it("rejects empty string", () => expect(isValidStatus("")).toBe(false));
-  it("rejects OPEN (uppercase)", () => expect(isValidStatus("OPEN")).toBe(false));
-});
-
-describe("isValidThread", () => {
-  it("accepts a minimal valid thread", () => {
-    expect(
-      isValidThread({
-        id: "t1",
-        line: 5,
-        status: "open",
-        messages: [{ author: "reviewer", text: "hello" }],
-      })
-    ).toBe(true);
-  });
-
-  it("rejects thread missing line", () => {
-    expect(
-      isValidThread({
-        id: "t1",
-        status: "open",
-        messages: [],
-      })
-    ).toBe(false);
-  });
-
-  it("rejects thread missing messages", () => {
-    expect(
-      isValidThread({
-        id: "t1",
-        line: 3,
-        status: "open",
-      })
-    ).toBe(false);
-  });
-
-  it("rejects thread with invalid status", () => {
-    expect(
-      isValidThread({
-        id: "t1",
-        line: 3,
-        status: "addressed",
-        messages: [],
-      })
-    ).toBe(false);
-  });
-});
-
-describe("isValidReviewFile", () => {
-  it("accepts a valid review file", () => {
-    expect(
-      isValidReviewFile({
-        file: "spec.md",
-        threads: [
-          {
-            id: "t1",
-            line: 1,
-            status: "open",
-            messages: [{ author: "reviewer", text: "comment" }],
-          },
-        ],
-      })
-    ).toBe(true);
-  });
-
-  it("accepts a review file with empty threads array", () => {
-    expect(
-      isValidReviewFile({
-        file: "spec.md",
-        threads: [],
-      })
-    ).toBe(true);
-  });
-
-  it("rejects a review file missing the file field", () => {
-    expect(
-      isValidReviewFile({
-        threads: [],
-      })
-    ).toBe(false);
-  });
-});

package/test/protocol/write.test.ts

@@ -1,72 +0,0 @@
-import { describe, expect, it } from "bun:test";
-import { mkdtempSync, rmSync, readFileSync } from "fs";
-import { join } from "path";
-import { writeReviewFile, writeDraftFile } from "../../src/protocol/write";
-import type { ReviewFile, DraftFile } from "../../src/protocol/types";
-
-function tmpDir() {
-  return mkdtempSync("/tmp/revspec-test-");
-}
-
-describe("writeReviewFile", () => {
-  it("writes valid JSON that can be parsed back to ReviewFile", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "review.json");
-    const data: ReviewFile = {
-      file: "spec.md",
-      threads: [
-        {
-          id: "t1",
-          line: 3,
-          status: "open",
-          messages: [{ author: "reviewer", text: "Is this right?" }],
-        },
-      ],
-    };
-    writeReviewFile(filePath, data);
-    const raw = readFileSync(filePath, "utf8");
-    expect(JSON.parse(raw)).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-
-  it("writes pretty-printed JSON (contains newlines)", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "review.json");
-    const data: ReviewFile = { file: "spec.md", threads: [] };
-    writeReviewFile(filePath, data);
-    const raw = readFileSync(filePath, "utf8");
-    expect(raw).toContain("\n");
-    rmSync(dir, { recursive: true });
-  });
-});
-
-describe("writeDraftFile", () => {
-  it("writes an approval draft", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "draft.json");
-    const data: DraftFile = { approved: true };
-    writeDraftFile(filePath, data);
-    const raw = readFileSync(filePath, "utf8");
-    expect(JSON.parse(raw)).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-
-  it("writes a threads draft", () => {
-    const dir = tmpDir();
-    const filePath = join(dir, "draft.json");
-    const data: DraftFile = {
-      threads: [
-        {
-          id: "t2",
-          line: 7,
-          status: "resolved",
-          messages: [{ author: "owner", text: "Fixed." }],
-        },
-      ],
-    };
-    writeDraftFile(filePath, data);
-    const raw = readFileSync(filePath, "utf8");
-    expect(JSON.parse(raw)).toEqual(data);
-    rmSync(dir, { recursive: true });
-  });
-});